mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
1592be779a
proxmox_kvm - Allow creation of VM with existing name but new vmid (#6709)
* proxmox_kvm - Allow creation of VM with existing name but new vmid
* Fix pylint and pep8 errors
* Add changelog fragment
* Move status variable outside of try block
* Add assertion for calling get_vm_node function
* Use try/catch for module_utils functions
* Update changelogs/fragments/6709-proxmox-create-vm-with-existing-name.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit fb04dc3db2)
Co-authored-by: Sergei Antipov <greendayonfire@gmail.com>
94 lines
3.7 KiB
Python
94 lines
3.7 KiB
Python
# -*- coding: utf-8 -*-
|
|
#
|
|
# Copyright (c) 2021, Ansible Project
|
|
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
|
|
# SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
from __future__ import absolute_import, division, print_function
|
|
|
|
__metaclass__ = type
|
|
|
|
import pytest
|
|
|
|
from ansible_collections.community.general.plugins.modules import proxmox_kvm
|
|
from ansible_collections.community.general.tests.unit.compat.mock import patch
|
|
from ansible_collections.community.general.tests.unit.plugins.modules.utils import (
|
|
AnsibleExitJson,
|
|
AnsibleFailJson,
|
|
ModuleTestCase,
|
|
set_module_args,
|
|
)
|
|
import ansible_collections.community.general.plugins.module_utils.proxmox as proxmox_utils
|
|
|
|
|
|
class TestProxmoxKvmModule(ModuleTestCase):
|
|
def setUp(self):
|
|
super(TestProxmoxKvmModule, self).setUp()
|
|
proxmox_utils.HAS_PROXMOXER = True
|
|
self.module = proxmox_kvm
|
|
self.connect_mock = patch(
|
|
"ansible_collections.community.general.plugins.module_utils.proxmox.ProxmoxAnsible._connect"
|
|
)
|
|
self.connect_mock.start()
|
|
|
|
def tearDown(self):
|
|
self.connect_mock.stop()
|
|
super(TestProxmoxKvmModule, self).tearDown()
|
|
|
|
def test_module_fail_when_required_args_missing(self):
|
|
with self.assertRaises(AnsibleFailJson):
|
|
set_module_args({})
|
|
self.module.main()
|
|
|
|
def test_module_exits_unchaged_when_provided_vmid_exists(self):
|
|
set_module_args(
|
|
{
|
|
"api_host": "host",
|
|
"api_user": "user",
|
|
"api_password": "password",
|
|
"vmid": "100",
|
|
"node": "pve",
|
|
}
|
|
)
|
|
with patch.object(proxmox_utils.ProxmoxAnsible, "get_vm") as get_vm_mock:
|
|
get_vm_mock.return_value = [{"vmid": "100"}]
|
|
with pytest.raises(AnsibleExitJson) as exc_info:
|
|
self.module.main()
|
|
|
|
assert get_vm_mock.call_count == 1
|
|
result = exc_info.value.args[0]
|
|
assert result["changed"] is False
|
|
assert result["msg"] == "VM with vmid <100> already exists"
|
|
|
|
@patch.object(proxmox_kvm.ProxmoxKvmAnsible, "create_vm")
|
|
def test_vm_created_when_vmid_not_exist_but_name_already_exist(self, create_vm_mock):
|
|
set_module_args(
|
|
{
|
|
"api_host": "host",
|
|
"api_user": "user",
|
|
"api_password": "password",
|
|
"vmid": "100",
|
|
"name": "existing.vm.local",
|
|
"node": "pve",
|
|
}
|
|
)
|
|
with patch.object(proxmox_utils.ProxmoxAnsible, "get_vm") as get_vm_mock:
|
|
with patch.object(proxmox_utils.ProxmoxAnsible, "get_node") as get_node_mock:
|
|
get_vm_mock.return_value = None
|
|
get_node_mock.return_value = {"node": "pve", "status": "online"}
|
|
with pytest.raises(AnsibleExitJson) as exc_info:
|
|
self.module.main()
|
|
|
|
assert get_vm_mock.call_count == 1
|
|
assert get_node_mock.call_count == 1
|
|
result = exc_info.value.args[0]
|
|
assert result["changed"] is True
|
|
assert result["msg"] == "VM existing.vm.local with vmid 100 deployed"
|
|
|
|
def test_parse_mac(self):
|
|
assert proxmox_kvm.parse_mac("virtio=00:11:22:AA:BB:CC,bridge=vmbr0,firewall=1") == "00:11:22:AA:BB:CC"
|
|
|
|
def test_parse_dev(self):
|
|
assert proxmox_kvm.parse_dev("local-lvm:vm-1000-disk-0,format=qcow2") == "local-lvm:vm-1000-disk-0"
|
|
assert proxmox_kvm.parse_dev("local-lvm:vm-101-disk-1,size=8G") == "local-lvm:vm-101-disk-1"
|
|
assert proxmox_kvm.parse_dev("local-zfs:vm-1001-disk-0") == "local-zfs:vm-1001-disk-0"
|