1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/tests/unit/plugins
Jonathan Kamens 627371e2d8
dconf: Check for changes properly despite style of quotes used by user (#6049)
dconf: parse GVariant values to check for equality whenever possible

Direct string comparisons are an inaccurate way to compare two
GVariant representations. For example, 'foo' and "foo" (including the
quote marks, which are part of the representation) are equal GVariants
but if you just do a string compare (remember, including the quotes)
they'll be interpreted.

We therefore want to use the `gi.repository` Python library to parse
GVariant representations before comparing them whenever possible.

However, we don't want to assume that this library will always be
available or require it for Ansible to function, so we use a straight
string comparison as a fallback when the library isn't available. This
may result in some false positives, i.e., Ansible thinking a value is
changing when it actually isn't, but will not result in incorrect
values being written into `dconf`.

Co-authored-by: Jonathan Kamens <jik@jik5.kamens.us>
2023-03-04 20:51:50 +01:00
..
become Remove unnecessary test imports (#5978) 2023-02-12 21:05:08 +01:00
cache Remove unnecessary test imports (#5978) 2023-02-12 21:05:08 +01:00
callback Remove unnecessary test imports (#5978) 2023-02-12 21:05:08 +01:00
connection Remove unnecessary test imports (#5978) 2023-02-12 21:05:08 +01:00
filter Remove unnecessary test imports (#5978) 2023-02-12 21:05:08 +01:00
inventory Remove unnecessary test imports (#5978) 2023-02-12 21:05:08 +01:00
lookup Consolidate onepassword unit tests so that ansible-test will find them when the plugin is modified (#6075) 2023-02-25 10:57:48 +01:00
module_utils Remove unnecessary test imports (#5978) 2023-02-12 21:05:08 +01:00
modules dconf: Check for changes properly despite style of quotes used by user (#6049) 2023-03-04 20:51:50 +01:00