1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/test
Dag Wieers d958440bcb win_firewall_rule: Implement idempotency, check-mode and diff support (#23162)
* win_firewall_rule: Small idempotency fix

This PR includes the following changes:
- an idempotency fix when `profile: any`
- better difference output to debug idempotency issues
- documentation fixes (remove `required: false`)
- Parameter handling fixes
- RDP example that matches default RDP rule
- Renamed parameter 'enable' to 'enabled' (kept alias)
- Renamed parameter 'profile' to 'profiles' (kept alias)

* Rewrite module completely

The logic is still intact, but various changes with a single goal:

- Make the module idempotent
- Implement check-mode
- Implement diff-mode
- Adapted integration tests

This fixes #18807 and #23455.

* Change casing to lowercase

* Improve the logic wrt. diff
2017-05-30 16:10:33 -07:00
..
compile Docs how to test (2nd) (#24094) 2017-04-28 09:08:26 +01:00
integration win_firewall_rule: Implement idempotency, check-mode and diff support (#23162) 2017-05-30 16:10:33 -07:00
results Create bot friendly sanity output. (#22381) 2017-03-07 14:59:50 -08:00
runner Fix expect for python 3 (#24912) 2017-05-23 15:51:46 -07:00
sanity contrib: PEP8 compliancy (#24680) 2017-05-30 21:08:09 +01:00
units Ensure exit_json returns failed = False 2017-05-30 14:56:31 -07:00
utils cloudstack: test: improve startup time, fix network dependency on run (#24876) 2017-05-22 10:58:16 +01:00