Adam Miller 75127092f2 refactor firewalld module with object abstraction (#26487) ... * refactor firewalld module with object abstraction This change creates a FirewallTransaction object that each individual transaction type is a sub-class of as they all follow the same pattern to enable or disable something in the firewall. Also, there's a few bugfixes here: - Fix the "source" type to handle permanent operations - Remove ambiguity of required parameters for only specific use cases that can lead to transactions effectively being a no-op. Instead, pick sane defaults and document them. - Change how imports are done so globals are no longer needed This is based on the original feedback by Toshio from the last refactor attempt: https://github.com/ansible/ansible-modules-extras/pull/3383 Signed-off-by: Adam Miller <maxamillion@fedoraproject.org> * fix line too long for pep8 for shippable tests Signed-off-by: Adam Miller <maxamillion@fedoraproject.org> * remove firewalld from pep8/legacy-files Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>		2017-09-11 14:10:07 -07:00
..
current-ignore.txt	Use pycodestyle instead of pep8 (#25947)	2017-07-13 11:46:31 -07:00
legacy-files.txt	refactor firewalld module with object abstraction (#26487)	2017-09-11 14:10:07 -07:00
legacy-ignore.txt	Swap pep8 current to legacy (#22891)	2017-03-23 13:16:55 -05:00
skip.txt	Don't skip action/__init__.py (#22911)	2017-03-23 13:40:02 -05:00