1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/tests/unit/plugins/inventory
patchback[bot] 4d74aa05a8
Fix linode inventory filtering (#4336) (#4356)
* Fix linode inventory filtering

There was a regression introduced in the addition of caching. The
`_consume_options` method was added and provided the `config_data`
dictionary. This `pop`s every entry, resulting in an empty `config_data`
dict, which was then reused and expected to be populated.

After reviewing, `_consume_data` doesn't need to be called. Also, once
the ``_read_config_data` method has been called, we no longer need the
config_data dict, and can instead use the `get_option` method throughout.

Once those were removed, the filtering function seemed a bit odd, since
we were no longer using the file. I used that opportunity to move the
filter calls into the populate function directly.

* Remove tests that target removed methods

This removes tests that targeted some custom methods on configuration
file handling. These are no longer necessary since they are now handled
by the BaseInventoryPlugin `_read_config_data` method.

* Add changelog entry for linode inventory bugfix

* Revert filters back to their own method

This moves filters back into their own method, but now uses the
get_option calls to pull filter configuration items.

(cherry picked from commit 386bb4bdd5)

Co-authored-by: steven jacobs <stjacobs@fastmail.fm>
2022-03-14 20:56:13 +01:00
..
fixtures LXD inventory: Support virtual machines (#3519) (#3900) 2021-12-14 06:42:47 +01:00
__init__.py Initial commit 2020-03-09 09:11:07 +00:00
test_cobbler.py add inventory plugin unit test test_verify_file (#2773) 2021-06-10 22:05:04 +02:00
test_icinga2.py Added new feature for ansible_user and ansible_port in Icinga2 inventory source (#4088) (#4130) 2022-01-31 20:22:59 +01:00
test_linode.py Fix linode inventory filtering (#4336) (#4356) 2022-03-14 20:56:13 +01:00
test_lxd.py LXD inventory: Support virtual machines (#3519) (#3900) 2021-12-14 06:42:47 +01:00
test_opennebula.py Added OpenNebula inventory plugin (#810) 2021-09-28 16:32:15 +02:00
test_proxmox.py Proxmox inventory: Added snapshots fact (#3044) 2021-07-22 22:55:07 +02:00
test_stackpath_compute.py add inventory plugin unit test test_verify_file (#2773) 2021-06-10 22:05:04 +02:00
test_xen_orchestra.py Xen orchestra inventory: Added groups, keyed_groups and compose support (#3766) (#3772) 2021-11-22 19:27:00 +01:00