1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/changelogs/fragments
patchback[bot] 4d74aa05a8
Fix linode inventory filtering (#4336) (#4356)
* Fix linode inventory filtering

There was a regression introduced in the addition of caching. The
`_consume_options` method was added and provided the `config_data`
dictionary. This `pop`s every entry, resulting in an empty `config_data`
dict, which was then reused and expected to be populated.

After reviewing, `_consume_data` doesn't need to be called. Also, once
the ``_read_config_data` method has been called, we no longer need the
config_data dict, and can instead use the `get_option` method throughout.

Once those were removed, the filtering function seemed a bit odd, since
we were no longer using the file. I used that opportunity to move the
filter calls into the populate function directly.

* Remove tests that target removed methods

This removes tests that targeted some custom methods on configuration
file handling. These are no longer necessary since they are now handled
by the BaseInventoryPlugin `_read_config_data` method.

* Add changelog entry for linode inventory bugfix

* Revert filters back to their own method

This moves filters back into their own method, but now uses the
get_option calls to pull filter configuration items.

(cherry picked from commit 386bb4bdd5)

Co-authored-by: steven jacobs <stjacobs@fastmail.fm>
2022-03-14 20:56:13 +01:00
..
.keep Rename changelogs/fragments/.empty -> changelogs/fragments/.keep 2020-08-07 08:17:57 +02:00
3295-mksysb-revamp.yaml mksysb - revamped module + fix bug in backup_dmapi_fs option (#3295) (#4353) 2022-03-14 07:29:08 +01:00
4108-nmcli-support-modifcation-without-type-param.yml Remove nmcli modify dependency on type parameter (#4108) (#4320) 2022-03-06 09:26:37 +01:00
4192-zypper-add-clean-deps.yml zypper: support automatic removal of orphaned dependencies (#4195) (#4301) 2022-02-28 19:54:58 +01:00
4207-add-redis-tls-support.yml Add tls parameter to redis module (#4207) (#4343) 2022-03-11 06:15:51 +00:00
4223-syslog-json-skip-syslog-option.yml [plugins/callback/syslog_json.py] use v2 api, add option to skip sysl… (#4223) (#4310) 2022-03-03 07:58:00 +01:00
4275-pacman-sysupgrade.yml pacman: fix upgrade: yes (#4275) (#4277) 2022-02-23 18:01:06 +01:00
4281-terraform-complex-variables.yml Allow complex values in variables parameter of terraform module (#4281) (#4341) 2022-03-11 06:56:07 +01:00
4286-pacman-url-pkgs.yml pacman: re-adding support for URL based pkgs (#4286) (#4302) 2022-03-01 06:34:27 +01:00
4287-fix-proxmox-vm-chek.yml Fix error when checking if Proxmox VM exists. (#4287) (#4313) 2022-03-04 13:30:57 +01:00
4288-fix-4259-support-busybox-dd.yml filesize: fix alpine linux sparse file (#4288) (#4294) 2022-02-27 13:55:50 +01:00
4299-npm-add-production-with-ci-flag.yml npm: add support for production flag when using ci (#4299) (#4339) 2022-03-11 06:55:54 +01:00
4303-pipx-editable.yml pipx: added options editable and pip_args (#4303) (#4309) 2022-03-02 22:47:37 +01:00
4304-jira-fields-in-comment.yml jira: Use fields in comment to merge in additional data (#4304) (#4347) 2022-03-12 08:29:28 +01:00
4306-proxmox-fix-error-on-vm-clone.yml proxmox: Fix error on VM clone (#4278) (#4306) (#4326) 2022-03-07 08:49:01 +00:00
4312-pacman-groups.yml pacman: user --groups instead of --group (#4312) (#4317) 2022-03-04 18:39:20 +00:00
4316-pacman-remove-nosave.yml pacman: add support for remove_nosave (#4316) (#4329) 2022-03-08 07:39:31 +01:00
4318-pacman-restore-old-changed-behavior.yml pacman: don't always return changed w/ update_cache (#4318) (#4322) 2022-03-06 22:57:22 +01:00
4330-pacman-packages-update_cache.yml pacman: improve docs, make sure that packages is always returned, deprecate update_cache behavior (#4330) (#4342) 2022-03-11 06:15:41 +00:00
4336-linode-inventory-filtering.yaml Fix linode inventory filtering (#4336) (#4356) 2022-03-14 20:56:13 +01:00