mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
4a5276b589
* proxmox_kvm: remove redundant parameters
The functions start_vm() and stop_vm() receive four common parameters:
module, proxmox, vm and vmid.
The last too are redundant so keep only vm.
I also took the opportunity to remove extra API calls to proxmox.nodes()
by assigning its return value to a variable.
* proxmox_kvm: remove extra calls to status.current
The get_vm() function already returns an array of properties containing
the status so remove extra API calls to retrieve this information.
Example:
[{''netin'': 177232, ''name'': ''test-instance'', ''maxcpu'': 1, ''node'': ''prx-01'', ''disk'': 0, ''template'': 0, ''uptime'': 267, ''cpu'': 0.0410680030805531, ''diskread'': 165294744, ''maxdisk'': 10737418240, ''vmid'': 42, ''status'': ''running'', ''id'': ''qemu/42'', ''maxmem'': 536870912, ''diskwrite'': 18528256, ''netout'': 2918, ''type'': ''qemu'', ''mem'': 160284950}]
* proxmox_kvm: kill VZ_TYPE global variable
It reduces readability without providing much values nowadays.
* proxmox_kvm: simplify vmid generation
Forgotten suggestion from Felix Fontein in PR#811.
* proxmox_kvm: add changelog fragment for PR#934
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| alicloud | ||
| atomic | ||
| centurylink | ||
| dimensiondata | ||
| docker | ||
| heroku | ||
| huawei | ||
| kubevirt | ||
| linode | ||
| lxc | ||
| lxd | ||
| memset | ||
| misc | ||
| oneandone | ||
| online | ||
| opennebula | ||
| oracle | ||
| ovh | ||
| ovirt | ||
| packet | ||
| profitbricks | ||
| pubnub | ||
| rackspace | ||
| scaleway | ||
| smartos | ||
| softlayer | ||
| spotinst | ||
| univention | ||
| webfaction | ||
| xenserver | ||