mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
671f850069
Fix keycloak_client_rolemapping role removal and diff (#5619)
* Keycloak: Fix client rolemapping removal
Keycloak's delete_group_rolemapping API wrapper didn't pass data about
the roles to remove to keycloak, resulting in removal of all roles.
Follow the intended behaviour and delete only the roles listed in the
module invocation.
Signed-off-by: Florian Achleitner <flo@fopen.at>
* Keycloak: Fix client_rolemapping diff
The module's diff output wrongly showed the changed roles list as
'after' state. This is obviously wrong for role removal and also
wrong for role addition, if there are other roles assigned.
Use the result of the API query for 'end_state' for 'diff' as well.
Signed-off-by: Florian Achleitner <flo@fopen.at>
* Keycloak: Calculate client_rolemapping proposed state properly
Signed-off-by: Florian Achleitner <flo@fopen.at>
* Add changelog fragment
Signed-off-by: Florian Achleitner <flo@fopen.at>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
* Fix for python2 unit test
Signed-off-by: Florian Achleitner <flo@fopen.at>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit f0b3bba030
)
Co-authored-by: fachleitner <flo@fopen.at>
355 lines
12 KiB
Python
355 lines
12 KiB
Python
#!/usr/bin/python
|
|
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright (c) Ansible project
|
|
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
|
|
# SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
from __future__ import absolute_import, division, print_function
|
|
__metaclass__ = type
|
|
|
|
DOCUMENTATION = '''
|
|
---
|
|
module: keycloak_client_rolemapping
|
|
|
|
short_description: Allows administration of Keycloak client_rolemapping with the Keycloak API
|
|
|
|
version_added: 3.5.0
|
|
|
|
description:
|
|
- This module allows you to add, remove or modify Keycloak client_rolemapping with the Keycloak REST API.
|
|
It requires access to the REST API via OpenID Connect; the user connecting and the client being
|
|
used must have the requisite access rights. In a default Keycloak installation, admin-cli
|
|
and an admin user would work, as would a separate client definition with the scope tailored
|
|
to your needs and a user having the expected roles.
|
|
|
|
- The names of module options are snake_cased versions of the camelCase ones found in the
|
|
Keycloak API and its documentation at U(https://www.keycloak.org/docs-api/8.0/rest-api/index.html).
|
|
|
|
- Attributes are multi-valued in the Keycloak API. All attributes are lists of individual values and will
|
|
be returned that way by this module. You may pass single values for attributes when calling the module,
|
|
and this will be translated into a list suitable for the API.
|
|
|
|
- When updating a client_rolemapping, where possible provide the role ID to the module. This removes a lookup
|
|
to the API to translate the name into the role ID.
|
|
|
|
|
|
options:
|
|
state:
|
|
description:
|
|
- State of the client_rolemapping.
|
|
- On C(present), the client_rolemapping will be created if it does not yet exist, or updated with the parameters you provide.
|
|
- On C(absent), the client_rolemapping will be removed if it exists.
|
|
default: 'present'
|
|
type: str
|
|
choices:
|
|
- present
|
|
- absent
|
|
|
|
realm:
|
|
type: str
|
|
description:
|
|
- They Keycloak realm under which this role_representation resides.
|
|
default: 'master'
|
|
|
|
group_name:
|
|
type: str
|
|
description:
|
|
- Name of the group to be mapped.
|
|
- This parameter is required (can be replaced by gid for less API call).
|
|
|
|
gid:
|
|
type: str
|
|
description:
|
|
- Id of the group to be mapped.
|
|
- This parameter is not required for updating or deleting the rolemapping but
|
|
providing it will reduce the number of API calls required.
|
|
|
|
client_id:
|
|
type: str
|
|
description:
|
|
- Name of the client to be mapped (different than I(cid)).
|
|
- This parameter is required (can be replaced by cid for less API call).
|
|
|
|
cid:
|
|
type: str
|
|
description:
|
|
- Id of the client to be mapped.
|
|
- This parameter is not required for updating or deleting the rolemapping but
|
|
providing it will reduce the number of API calls required.
|
|
|
|
roles:
|
|
description:
|
|
- Roles to be mapped to the group.
|
|
type: list
|
|
elements: dict
|
|
suboptions:
|
|
name:
|
|
type: str
|
|
description:
|
|
- Name of the role_representation.
|
|
- This parameter is required only when creating or updating the role_representation.
|
|
id:
|
|
type: str
|
|
description:
|
|
- The unique identifier for this role_representation.
|
|
- This parameter is not required for updating or deleting a role_representation but
|
|
providing it will reduce the number of API calls required.
|
|
|
|
extends_documentation_fragment:
|
|
- community.general.keycloak
|
|
|
|
|
|
author:
|
|
- Gaëtan Daubresse (@Gaetan2907)
|
|
'''
|
|
|
|
EXAMPLES = '''
|
|
- name: Map a client role to a group, authentication with credentials
|
|
community.general.keycloak_client_rolemapping:
|
|
realm: MyCustomRealm
|
|
auth_client_id: admin-cli
|
|
auth_keycloak_url: https://auth.example.com/auth
|
|
auth_realm: master
|
|
auth_username: USERNAME
|
|
auth_password: PASSWORD
|
|
state: present
|
|
client_id: client1
|
|
group_name: group1
|
|
roles:
|
|
- name: role_name1
|
|
id: role_id1
|
|
- name: role_name2
|
|
id: role_id2
|
|
delegate_to: localhost
|
|
|
|
- name: Map a client role to a group, authentication with token
|
|
community.general.keycloak_client_rolemapping:
|
|
realm: MyCustomRealm
|
|
auth_client_id: admin-cli
|
|
auth_keycloak_url: https://auth.example.com/auth
|
|
token: TOKEN
|
|
state: present
|
|
client_id: client1
|
|
group_name: group1
|
|
roles:
|
|
- name: role_name1
|
|
id: role_id1
|
|
- name: role_name2
|
|
id: role_id2
|
|
delegate_to: localhost
|
|
|
|
- name: Unmap client role from a group
|
|
community.general.keycloak_client_rolemapping:
|
|
realm: MyCustomRealm
|
|
auth_client_id: admin-cli
|
|
auth_keycloak_url: https://auth.example.com/auth
|
|
auth_realm: master
|
|
auth_username: USERNAME
|
|
auth_password: PASSWORD
|
|
state: absent
|
|
client_id: client1
|
|
group_name: group1
|
|
roles:
|
|
- name: role_name1
|
|
id: role_id1
|
|
- name: role_name2
|
|
id: role_id2
|
|
delegate_to: localhost
|
|
|
|
'''
|
|
|
|
RETURN = '''
|
|
msg:
|
|
description: Message as to what action was taken.
|
|
returned: always
|
|
type: str
|
|
sample: "Role role1 assigned to group group1."
|
|
|
|
proposed:
|
|
description: Representation of proposed client role mapping.
|
|
returned: always
|
|
type: dict
|
|
sample: {
|
|
clientId: "test"
|
|
}
|
|
|
|
existing:
|
|
description:
|
|
- Representation of existing client role mapping.
|
|
- The sample is truncated.
|
|
returned: always
|
|
type: dict
|
|
sample: {
|
|
"adminUrl": "http://www.example.com/admin_url",
|
|
"attributes": {
|
|
"request.object.signature.alg": "RS256",
|
|
}
|
|
}
|
|
|
|
end_state:
|
|
description:
|
|
- Representation of client role mapping after module execution.
|
|
- The sample is truncated.
|
|
returned: on success
|
|
type: dict
|
|
sample: {
|
|
"adminUrl": "http://www.example.com/admin_url",
|
|
"attributes": {
|
|
"request.object.signature.alg": "RS256",
|
|
}
|
|
}
|
|
'''
|
|
|
|
from ansible_collections.community.general.plugins.module_utils.identity.keycloak.keycloak import KeycloakAPI, camel, \
|
|
keycloak_argument_spec, get_token, KeycloakError, is_struct_included
|
|
from ansible.module_utils.basic import AnsibleModule
|
|
|
|
|
|
def main():
|
|
"""
|
|
Module execution
|
|
|
|
:return:
|
|
"""
|
|
argument_spec = keycloak_argument_spec()
|
|
|
|
roles_spec = dict(
|
|
name=dict(type='str'),
|
|
id=dict(type='str'),
|
|
)
|
|
|
|
meta_args = dict(
|
|
state=dict(default='present', choices=['present', 'absent']),
|
|
realm=dict(default='master'),
|
|
gid=dict(type='str'),
|
|
group_name=dict(type='str'),
|
|
cid=dict(type='str'),
|
|
client_id=dict(type='str'),
|
|
roles=dict(type='list', elements='dict', options=roles_spec),
|
|
)
|
|
|
|
argument_spec.update(meta_args)
|
|
|
|
module = AnsibleModule(argument_spec=argument_spec,
|
|
supports_check_mode=True,
|
|
required_one_of=([['token', 'auth_realm', 'auth_username', 'auth_password']]),
|
|
required_together=([['auth_realm', 'auth_username', 'auth_password']]))
|
|
|
|
result = dict(changed=False, msg='', diff={}, proposed={}, existing={}, end_state={})
|
|
|
|
# Obtain access token, initialize API
|
|
try:
|
|
connection_header = get_token(module.params)
|
|
except KeycloakError as e:
|
|
module.fail_json(msg=str(e))
|
|
|
|
kc = KeycloakAPI(module, connection_header)
|
|
|
|
realm = module.params.get('realm')
|
|
state = module.params.get('state')
|
|
cid = module.params.get('cid')
|
|
client_id = module.params.get('client_id')
|
|
gid = module.params.get('gid')
|
|
group_name = module.params.get('group_name')
|
|
roles = module.params.get('roles')
|
|
|
|
# Check the parameters
|
|
if cid is None and client_id is None:
|
|
module.fail_json(msg='Either the `client_id` or `cid` has to be specified.')
|
|
if gid is None and group_name is None:
|
|
module.fail_json(msg='Either the `group_name` or `gid` has to be specified.')
|
|
|
|
# Get the potential missing parameters
|
|
if gid is None:
|
|
group_rep = kc.get_group_by_name(group_name, realm=realm)
|
|
if group_rep is not None:
|
|
gid = group_rep['id']
|
|
else:
|
|
module.fail_json(msg='Could not fetch group %s:' % group_name)
|
|
if cid is None:
|
|
cid = kc.get_client_id(client_id, realm=realm)
|
|
if cid is None:
|
|
module.fail_json(msg='Could not fetch client %s:' % client_id)
|
|
if roles is None:
|
|
module.exit_json(msg="Nothing to do (no roles specified).")
|
|
else:
|
|
for role_index, role in enumerate(roles, start=0):
|
|
if role['name'] is None and role['id'] is None:
|
|
module.fail_json(msg='Either the `name` or `id` has to be specified on each role.')
|
|
# Fetch missing role_id
|
|
if role['id'] is None:
|
|
role_id = kc.get_client_role_id_by_name(cid, role['name'], realm=realm)
|
|
if role_id is not None:
|
|
role['id'] = role_id
|
|
else:
|
|
module.fail_json(msg='Could not fetch role %s:' % (role['name']))
|
|
# Fetch missing role_name
|
|
else:
|
|
role['name'] = kc.get_client_group_rolemapping_by_id(gid, cid, role['id'], realm=realm)['name']
|
|
if role['name'] is None:
|
|
module.fail_json(msg='Could not fetch role %s' % (role['id']))
|
|
|
|
# Get effective client-level role mappings
|
|
available_roles_before = kc.get_client_group_available_rolemappings(gid, cid, realm=realm)
|
|
assigned_roles_before = kc.get_client_group_composite_rolemappings(gid, cid, realm=realm)
|
|
|
|
result['existing'] = assigned_roles_before
|
|
result['proposed'] = list(assigned_roles_before) if assigned_roles_before else []
|
|
|
|
update_roles = []
|
|
for role_index, role in enumerate(roles, start=0):
|
|
# Fetch roles to assign if state present
|
|
if state == 'present':
|
|
for available_role in available_roles_before:
|
|
if role['name'] == available_role['name']:
|
|
update_roles.append({
|
|
'id': role['id'],
|
|
'name': role['name'],
|
|
})
|
|
result['proposed'].append(available_role)
|
|
# Fetch roles to remove if state absent
|
|
else:
|
|
for assigned_role in assigned_roles_before:
|
|
if role['name'] == assigned_role['name']:
|
|
update_roles.append({
|
|
'id': role['id'],
|
|
'name': role['name'],
|
|
})
|
|
if assigned_role in result['proposed']: # Handle double removal
|
|
result['proposed'].remove(assigned_role)
|
|
|
|
if len(update_roles):
|
|
if state == 'present':
|
|
# Assign roles
|
|
result['changed'] = True
|
|
if module._diff:
|
|
result['diff'] = dict(before=assigned_roles_before, after=result['proposed'])
|
|
if module.check_mode:
|
|
module.exit_json(**result)
|
|
kc.add_group_rolemapping(gid, cid, update_roles, realm=realm)
|
|
result['msg'] = 'Roles %s assigned to group %s.' % (update_roles, group_name)
|
|
assigned_roles_after = kc.get_client_group_composite_rolemappings(gid, cid, realm=realm)
|
|
result['end_state'] = assigned_roles_after
|
|
module.exit_json(**result)
|
|
else:
|
|
# Remove mapping of role
|
|
result['changed'] = True
|
|
if module._diff:
|
|
result['diff'] = dict(before=assigned_roles_before, after=result['proposed'])
|
|
if module.check_mode:
|
|
module.exit_json(**result)
|
|
kc.delete_group_rolemapping(gid, cid, update_roles, realm=realm)
|
|
result['msg'] = 'Roles %s removed from group %s.' % (update_roles, group_name)
|
|
assigned_roles_after = kc.get_client_group_composite_rolemappings(gid, cid, realm=realm)
|
|
result['end_state'] = assigned_roles_after
|
|
module.exit_json(**result)
|
|
# Do nothing
|
|
else:
|
|
result['changed'] = False
|
|
result['msg'] = 'Nothing to do, roles %s are %s with group %s.' % (roles, 'mapped' if state == 'present' else 'not mapped', group_name)
|
|
module.exit_json(**result)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
main()
|