mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
45d3661ccf
* pkgng: package reinstallations count as changed
`upgrade_packages()` only looked for the string
"Number of packages to be upgraded", but the
`pkg upgrade` command also reports "Number of packages to be
reinstalled". Reinstallation occurs when package metadata other
than version changes (e.g. build options, single architecture to `*`
architecture). In any other respect, though, a required
reinstallation is the same as an upgrade.
* pkgng: check_mode should count queued actions
Writing tests caught a bug in PR #3393, which enabled
installing more than one package per `pkg` execution.
In converting the module's install/upgrade code to a
queue structure, check_mode got broken because the count
of actions performed was only updated in the `if not check_mode`
block that invokes `pkg`. This two-line change counts
the number of actions in the queue when check mode is
enabled.
* pkgng: add basic integration tests
Test installing a package
Test installing a package into a jail
* pkgng: test with zsh not bash package
Had been using bash package, because it's not
likely to disappear from the package repository
any time soon. Turns out that bash is already
installed on the Ansible community.general
FreeBSD CI VM image, which makes the test fail.
Zsh probably isn't going away any time soon,
either, and likely won't be installed on the
CI image.
* pkgng: remove redundant test for docker container
These tests should be skip/docker, but the test
playbook also redundantly checked whether it was
running in a docker container.
Checking whether `ansible_facts.distribution` is
`FreeBSD` is really sufficient to be sure whether
the test is running in an environment that supports
the `pkgng` module.
* pkgng: add state=absent test
Also renumber `jail=...` test to make diffs less
noisy when adding more non-jailed tests.
* pkgng: add state=latest idemptency test
Add test between state=present and
state=absent that ensures state=latest runs
successfully on an already up-to-date package
with changed=false.
* pkgng: add state=latest test
Including small filesize out-of-date package from
FreeBSD 11 package repository, because FreeBSD 11 is
currently EOL. This test might fail at some point in the
future if the pkg utility in a FreeBSD version > 14
makes breaking changes that prevents it from installing
older package formats.
If that occurs, the fix is to replace
`files/freebsd-release-manifests-20210413__FreeBSD_11.pkg`
with the version of freebsd-release-manifests from the oldest
non-breaking release of FreeBSD, and update the
references to it in tasks/main.yml accordingly.
* pkgng: use hand-generated test package
Instead of relying on a broken-ish installation
of an older package from FreeBSD 11, hand-generate
a package named `zsh` with no contents and a version
number of `0`. It can be installed on any architecture
and any revision of FreeBSD sucessfully, and it will
always be eligible for upgrade.
* pkgng: CI seems to dislike plus-signs in filenames
* pkgng: refactor renaming test package manifests
refactored to make intent of adding '+' sign clearer
* pkgng: refactor upgraded pattern matching
Implement russoz's suggestion to put all
variants in the pattern.
* pkgng: add cached=yes test
Changed idempotency test, because this covers both.
* pkgng: test pkg works on any FreeBSD version
Removing `ansible_distribution_version`, because the
test out-of-date zsh package should install on any
FreeBSD version.
* pkgng: move FreeBSD tasks to imported file
Refactoring tests for more reuse and easier
readability.
* pkgng: refactor tests for task reuse
Several tests need to install an out-of-date package
to test whether upgrades occur successfully, so this
commit refactors out the generation of the test package.
Also, factor out things like the name and path of the
test package so that is more maintainable should the
target test package (currently `zsh`) ever need to
change.
* pkgng: test install multiple packages
Multiple packages should install with a single
invocation of the `pkg` utility.
* pkgng: handle space- and comma-separated lists
The module expects a list of strings in the `name` parameter,
but long-standing documentation showed space- and comma-delimited
lists as a valid way of telling the module to act on multiple
packages. Passing these lists through to the `pkg` command can
have unexpected side-effects of upgrading packages when
`state=present` rather than `state=latest` and could result
in the module reporting the wrong number of packages for each
action performed.
* pkgng: test state=latest for mixed install/upgrade
Test that a list of packages given, one not installed
and one installed but out-of-date are handled correctly.
* pkgng: use YAML lists for multiple packages
I had been following the documentation examples, and
specifiying multiple packages on one line. The right way
to do it is with YAML list syntax.
* pkgng: add test for autoremove=yes
Install package with known dependencies, then
remove it and ask autoremove to run.
* pkgng: test autoremove=yes only on FreeBSD > 12
The CI test runner on FreeBSD 12.0 times out when
downloading large packages.
* pkgng: test jail creation logging less verbose
`ezjail-admin` had been spewing every filename copied
into the jail onto stderr, making the `ansible-test -v`
logs hard to scroll through. Changed it so that ezjail
output only shows up in the ansible task logs if
`ansible_verbosity > 1` (`-vv...`). Full `ezjail-admin`
output is always logged to `/tmp/ezjail.log`.
* pkgng: pass tests when package dependencies change
Tests that install packages with dependencies were failing
when those dependencies were not already installed, because
the count of installed packages was greater than the count
of requested to be installed packages. This change checks
for a count of installed packages that is greater than or
equal to the count of requested to be installed packages.
Example:
- Test installs packages `zsh` and `fish`
- `fish` has a dependency on `pcre2`
- `pkg` reports `Number of packages to be installed: 3`
* pkgng: test annotation for single package
Add/modify/remove annotation for a single package
* pkgng: fix annotation operations
Annotation has been broken at least since the migration to
collections. There are some breaking typos and function argument
omissions in the code with nothing in `git blame` but "Initial commit".
New integration tests uncovered this breakage. Works now.
* pkgng: test multiple annotations
Test multiple annotations specified both in new (YAML list)
syntax and old (comma-delimited) syntax.
Rename some annotation test tags from the single-annotation
tests to make sure that single and multiple annotation tests
don't collide.
* pkgng: test invalid annotate strings
Ensure that some likely to occur, invalid strings
given to the annotate module parameter 1. fail,
2. do not cause an exception, and 3. do not create
any actual annotations on packages.
* pkgng: fix check_mode for annotate
Actions specified in the `annotate` parameter would
always be performed, even if `check_mode=yes`.
This commit fixes `check_mode` for the annotation
functions and adds integration tests to ensure that
check mode is honored in the future.
* pkgng: call module.run_command with list
Instead of calling `run_command` with a formatted
string, call it with a list to maintain safer argument
separation.
Also, introduce a wrapper for `run_command`, `run_pkgng`,
which manages the process environment and some common
command line switches, based upon the module parameters.
Introduced in this commit, also pass annotation values
to `pkg annotate` via stdin, which is safer with long
values than putting them in argv.
* pkgng: update documentation to match annotate type
Missed updating the documentation to match the change
of the annotate parameter from comma-separated string
to list of strings.
* pkgng: fix syntax for Python 2
Seems *args, **kwargs have to be the last
two arguments in Python 2 syntax. CI sanity
tests were failing.
* pkgng: oops, pkgsite should be from closure
I put `pkgsite` as a keyword argument to `run_pkgng()',
which wasn't correct at all and resulted it in capturing
the second positional argument given by any caller.
`pkgsite` should have been `p["pkgsite"]`, coming from the
closure environment of `main()`.
* pkgng: Fix changelog fragment quote formatting
Co-authored-by: Felix Fontein <felix@fontein.de>
* pkgng: add test prepare task
Make sure test environment does not contain the
test package.
* pkgng: make integration test package more flexible
Make integration test package building template-based,
so more flexible if in the future the name of the test package,
currently `zsh`, must change.
* pkgng: convert generator to list for 2.9
Ansible 2.9 can't count items from a generator,
so convert `select` filter output via `list`
before passing to `count`.
* pkgng: Ansible 2.9 has no "false" Jinja2 test
Apparently Ansible 2.9 doesn't have the "false" test
in Jinja2 contexts. Switching to use `rejectattr(...)`
instead of `selectattr(..., "false")`.
* pkgng: test pkgsite parameter
* pkgng: add tests for chroot and rootdir params
Refactor install tasks into an include file so they
can be reused and tested with various parameters.
* pkgng: clean up test package creation
Make pkg json manifest more readable. Create package using
FreeBSD's `pkg create` instead of manually using tar. This
change also simplifies the manifest to a single file for
the integration test role.
* pkgng: fix #3428; install from local file
Fixes a bug in which the module reported failure
when installing from a local (to the target host)
file path.
Fixes #3428
* pkgng: changelog fragment formatting issue
* pkgng: check for all test package extensions
pkg recently changed file extensions, so for the
tests to work on multiple recent versions of FreeBSD,
we must check for `pkg create` output with varying
filename.
* Revert "pkgng: fix #3428; install from local file"
As the module has invoked pkg with the `-g` flag for
at least 7 years, I'm not sure when it was possible
to install packages from files on the target host
filesystem, because pkg rejects file paths when
the `--glob` flag is enabled.
I considered doing a rework of the pkg invocation
to enable good support for installing from local
files, but it looks like more of a job than for this PR.
This reverts commit
|
||
|---|---|---|
| .. | ||
| .keep | ||
| 273-add_multiple_options_with_same_name_to_ini_file.yml | ||
| 502-zfs_bugfix_and_diff_mode_support.yaml | ||
| 634-gitlab_project_runners.yaml | ||
| 1085-consul-acl-hcl-whitelist-update.yml | ||
| 1334-jenkins-plugin-fallback-urls.yaml | ||
| 1942_timezone.yml | ||
| 2126-consul_kv-pass-token.yml | ||
| 2284-influxdb_retention_policy-fix_duration_parsing.yml | ||
| 2323-groupby_as_dict-filter.yml | ||
| 2334-redfish_config-skip-incorrect-attributes.yml | ||
| 2337-mark-inventory-scripts-executable.yml | ||
| 2348-composer-no-interaction-option-discovery-to-avoid-hang.yaml | ||
| 2355-spotinst_aws_elastigroup-list-elements.yml | ||
| 2364-influxdb_user-first_user.yml | ||
| 2369-lvol_size_bug_fixes.yml | ||
| 2373-svr4pkg-fix-typeerror.yml | ||
| 2383-influxdb_retention_policy-add-state-option.yml | ||
| 2393-module_helper-breakdown.yml | ||
| 2407-puppet-change_stdout_to_console.yaml | ||
| 2409-nmcli_add_slave-type_bridge_to_nmcli_command_if_type_is_bridge-slave.yml | ||
| 2410-linode-improvements.yml | ||
| 2411-snap-revamp-enabled-disabled-states.yml | ||
| 2416-nmcli_compare_mac_addresses_case_insensitively.yml | ||
| 2417-nmcli_remove_dead_code.yml | ||
| 2430-linodev4-error-message.yml | ||
| 2435-one_vm-fix_missing_keys.yml | ||
| 2448-stackpath_compute-fix.yml | ||
| 2450-gitlab_user-add_expires_at_option.yaml | ||
| 2454-detect_zfs_changed.yml | ||
| 2461-ovirt4-fix-configparser.yml | ||
| 2472_filesystem_module_revamp.yml | ||
| 2485-java_keystore-ssl_backend-parameter.yml | ||
| 2499-influxdb_user-fix-multiple-no-privileges.yml | ||
| 2500-passwordstore-add_option_ignore_missing.yml | ||
| 2510-jenkins_plugin_use_post_method.yml | ||
| 2514-mh-improved-changed.yml | ||
| 2516_fix_2515_keystore_type_jks.yml | ||
| 2517-cmd-params-from-vars.yml | ||
| 2518-nmap-fix-cache-disabled.yml | ||
| 2520-connection-refactors.yml | ||
| 2521-flatpak-list.yml | ||
| 2524-pacman_add_bin_option.yml | ||
| 2525-iptables_state-fix-initialization-command.yml | ||
| 2526-java_keystore-password-via-stdin.yml | ||
| 2540-zfs-delegate-choices.yml | ||
| 2556-add-comment_visibility-parameter-for-comment-operation-of-jira-module.yml | ||
| 2557-cloud-misc-refactor.yml | ||
| 2560-java_cert-pkcs12-alias-bugfix.yml | ||
| 2564-mh-cmd-process-output.yml | ||
| 2568-ssh_config-reduce-stormssh-searches-based-on-host.yml | ||
| 2571-rhsm_release-fix-release_matcher.yaml | ||
| 2573-terraform-overwrite-init.yml | ||
| 2578-ini-file-utf8-bom.yml | ||
| 2579-redis-cache-ipv6.yml | ||
| 2590-netcup_dns-exception-no-message-attr.yml | ||
| 2614-influxdb_user-fix-issue-introduced-in-PR#2499.yml | ||
| 2616-archive-exclusion_patterns-option.yml | ||
| 2632-cleanup.yml | ||
| 2634-terraform-switch-workspace.yml | ||
| 2635-nmcli-add-ignore-auto-arguments.yml | ||
| 2648-proxmox_kvm-fix-vmid-return-value.yml | ||
| 2650-composer-add_composer_executable.yml | ||
| 2661-maven_artifact-add-sha1-option.yml | ||
| 2671-fix-broken-query-of-async_status-result.yml | ||
| 2681-stacki-host-bugfix.yml | ||
| 2684-open_iscsi-single-target-multiple-portal-overrides.yml | ||
| 2691-gitlab_user-support-identity-provider.yml | ||
| 2692-logstash-callback-plugin-replacing_options.yml | ||
| 2711-fix-iptables_state-2700-async_status-call.yml | ||
| 2722-zypper_repository-fix_idempotency_on_adding_repo_with_releasever.yml | ||
| 2731-mh-cmd-locale.yml | ||
| 2732-nmcli_add_options.yml | ||
| 2735-onepassword-add_domain_option.yml | ||
| 2751-flatpak-no_dependencies.yml | ||
| 2771-scaleway_inventory_json_accept_byte_array.yml | ||
| 2774-datadog_event_api_parameter.yml | ||
| 2779_redhat_subscription-add_server_prefix_and_server_port.yml | ||
| 2787-yum_versionlock-fix_idempotency_when_using_wildcard.yml | ||
| 2790-callback_splunk-batch-option.yml | ||
| 2808-pids-older-psutil.yml | ||
| 2816-archive-refactor.yml | ||
| 2821-ipa_sudorule.yml | ||
| 2824-gitlab_project-project-under-user.yml | ||
| 2827-nmcli_fix_team_slave.yml | ||
| 2830-npm-version-update.yml | ||
| 2841-proxmox_kvm_zfs_devstr.yml | ||
| 2843-modprobe-failure-conditions.yml | ||
| 2844-ali_instance_info-deprecate-params.yml | ||
| 2845-serverless-deprecate-functions-param.yml | ||
| 2850-jenkins_build-support-stop-jenkins-build.yml | ||
| 2867-redis-terminology.yml | ||
| 2874-terraform-check-destroy.yml | ||
| 2875-ini_file-unicode.yml | ||
| 2878-validate-certs-bool.yml | ||
| 2881-gitlab_project-fix_workspace_user.yaml | ||
| 2883-_mount-fixed-sanity-checks.yml | ||
| 2901-nmcli_teaming.yml | ||
| 2902-filesystem_extend_freebsd_support.yml | ||
| 2904-fix-bug-when-2-identical-executions-in-same-auth-flow.yml | ||
| 2912-snap-module-helper.yml | ||
| 2913-archive-dest_state.yml | ||
| 2918-snap-param-order.yml | ||
| 2922-mh-cmd-output-feature-flag.yml | ||
| 2923-archive-remove-bugfix.yml | ||
| 2924-npm-fix-package-json.yml | ||
| 2935-lvol-support_check_mode_thinpool.yml | ||
| 2936-pacman-fix_changed_status_when_ignorepkg_has_been_defined.yml | ||
| 2946-python-dnsimple-v2-rewrite.yml | ||
| 2948-jenkins_job_info-remove_necessities_on_password_or_token.yml | ||
| 2949-add_authentication-flow-binding_keycloak-client.yml | ||
| 2951-mh-vars-deepcopy.yml | ||
| 2955-rax_mon_notification_plan-added-elements-to-list-params.yaml | ||
| 2958-datadog_monitor_support_composites.yml | ||
| 2960-launchd-validation-check.yaml | ||
| 2963-improve-diff-mode-on-keycloak_authentication.yml | ||
| 2967-proxmox_inventory-offline-node-fix.yml | ||
| 2987-archive-stage-idempotency-fix.yml | ||
| 2989-pamd-single-line.yaml | ||
| 3001-enhance_gitlab_module.yml | ||
| 3006-redfish_command-bootoverride-argument-check.yaml | ||
| 3028-snap-channel.yml | ||
| 3034-promox-kvm-return-new-id.yaml | ||
| 3036-archive-root-path-fix.yml | ||
| 3038-enhance_github_repo_api_url.yml | ||
| 3041-fix_gitlab_group_members_gitlab_project_mambers.yml | ||
| 3041-gitlab_x_members_fix_and_enhancement.yml | ||
| 3044-proxmox-inventory-snapshots.yml | ||
| 3049-xfconf-deprecate-get.yaml | ||
| 3052_proxmox_inventory_plugin.yml | ||
| 3067-taiga-bugfix.yaml | ||
| 3068-supervisorctl-bugfix.yaml | ||
| 3074-ini_file-3031-empty-value-inconsistency.yml | ||
| 3075-archive-idempotency-enhancements.yml | ||
| 3079-report-power-state-hpilo.yaml | ||
| 3080-java_cert-2460-import_private_key.yml | ||
| 3081-add-wifi-option-to-nmcli-module.yml | ||
| 3084-info-checkmode.yaml | ||
| 3092-gunicorn-refactor.yaml | ||
| 3093-ejabberd_user-refactor.yaml | ||
| 3098-django_manage-cmd-list.yaml | ||
| 3104-deploy_helper-required_if.yaml | ||
| 3106-apache2_module-review.yaml | ||
| 3125-hana-query-userstore.yaml | ||
| 3132-nmcli-dummy.yaml | ||
| 3135-add-redfish_command-bootoverridemode.yaml | ||
| 3136-add-wifi-sec-change-detection-to-nmcli-module.yml | ||
| 3139-tss-lookup-plugin-update-to-make-compatible-with-sdk-v1.yml | ||
| 3141-disallow-options-unsupported-by-nmcli.yml | ||
| 3160-pass-wifi-secrets-via-stdin-to-nmcli-module.yml | ||
| 3161-openbsd-pkg-fix-regexp-matching-crash.yml | ||
| 3164-zypper-support-transactional-updates.yaml | ||
| 3178-add-ipaselinuxusermaporder-to-ipa-config-module.yml | ||
| 3191-vdo-refactor.yml | ||
| 3194-sanity.yml | ||
| 3199-tss-lookup-plugin-bugfix-for-backwards-compatibility.yml | ||
| 3203-linode-inventory-return-full-api-ip-data.yml | ||
| 3205-slack-minor-refactor.yaml | ||
| 3206-mh-classmethod.yaml | ||
| 3211-snap-error-handling.yml | ||
| 3228-tss-domain-authorization.yml | ||
| 3231-fix-keycloak-realm-events.yml | ||
| 3233-include-thermal-sensor-status-via-redfish_info.yaml | ||
| 3237-copr-fix_chroot_naming.yml | ||
| 3239-nmcli-sit-ipip-config-bugfix.yaml | ||
| 3247-retry_servfail-for-dig.yaml | ||
| 3248-adds-few-more-gitlab-group-options.yml | ||
| 3250-parse-scw-config.yml | ||
| 3252-tss_lookup_plugin-refactor.yml | ||
| 3256-fix-ptr-handling-in-udm_dns_record.yml | ||
| 3258-apache2_module.yml | ||
| 3262-nmcli-add-gre-tunnel-support.yaml | ||
| 3266-vmid-existing-target-clone.yml | ||
| 3267-dnsimple1-deprecation.yml | ||
| 3283-django_manage-fix-command-splitting.yaml | ||
| 3284-openwrt_init-improvements.yaml | ||
| 3285-pamd-updated-with-empty-args.yaml | ||
| 3286-open_iscsi-improvements.yaml | ||
| 3290-mh-cmd-boolean-not.yaml | ||
| 3296-clean-etag.yaml | ||
| 3313-nmcli-add_gsm_support.yml | ||
| 3315-pids-refactor.yml | ||
| 3319-gitlab_project_members_enhancement.yml | ||
| 3327-tss-token-authorization.yml | ||
| 3328-interfaces_file-improvements.yaml | ||
| 3329-kernel_blacklist-improvements.yaml | ||
| 3330-bugfix-keycloak-authentication-flow-requirements-not-set-correctly.yml.yml | ||
| 3331-do_not_ignore_volatile_configs_by_option.yml | ||
| 3332-zpool_facts-pythonify.yaml | ||
| 3334-django_manage-split-params.yaml | ||
| 3336-openbsd_pkg-fix-KeyError.yml | ||
| 3337-linode-fix.yml | ||
| 3343-redfish_utils-addUser-userId.yml | ||
| 3359-add-unicode_normalize-filter.yml | ||
| 3367-add-require_two_factor_authentication-property-to-gitlab-group.yml | ||
| 3379-gitlab_project-ci_cd_properties.yml | ||
| 3393-pkgng-many_packages_one_command.yml | ||
| 3400-fix-gitLab-api-searches-always-return-first-found-match-3386.yml | ||
| 3401-nmcli-needs-type.yml | ||
| 3404-redfish_utils-skip-manager-network-check.yml | ||
| 3422-open-iscsi-mutual-authentication-support.yaml | ||
| 3425-mail_add_configurable_ehlo_hostname.yml | ||
| 3426-copy-permissions-along-with-file-for-jboss-module.yml | ||
| 3429-enable_deprecaded_message_for_ignore_volatile_option.yml | ||
| 3450-callback_opentelemetry-exception_handling.yml | ||
| 3451-gitlab-group-member-deprecate-name-and-path.yml | ||
| 3453-fix-gitlab_group-require_two_factor_authentication-cant_be_null.yml | ||
| 3461-remove-deprecations-for-4.0.0.yml | ||
| 3473-gitlab_deploy_key-fix_idempotency.yml | ||
| 3474-zypper_repository_improve_repo_file_idempotency.yml | ||
| 3478-yaml-callback.yml | ||
| 3495-ssh_config_add_forwardagent_option.yml | ||
| 3496-callback_opentelemetry-enrich_stacktraces.yml | ||
| 3498-callback_opentelemetry-only_in_ci.yml | ||
| 3500-macports-add-stdout-and-stderr-to-status.yaml | ||
| 3509-redfish_utils-SetOneTimeBoot-mode-fix.yml | ||
| 3514-ufw_insert_or_delete_biased_when_deletion_enabled.yml | ||
| 3526-pkgng-add-integration-tests.yml | ||
| 3536-quote-role-name-in-url.yml | ||
| 3538-fix-keycloak-idp-mappers-change-detection.yml | ||
| 3540-terraform_add_parallelism_parameter.yml | ||
| 3545-ipa_group-add-append-option.yml | ||
| 3554-opkg-name.yml | ||
| 3556-callback_elastic-enrich_stacktraces.yml | ||
| 3558-callback_opentelemetry-enrich_service_map.yml | ||
| 3561-fix-ipa-host-var-detection.yml | ||
| 3563-nmcli-ipv6_dns.yaml | ||
| ansible-core-_text.yml | ||
| gem_module_add_bindir_option.yml | ||
| ipaddress.yml | ||
| json_query_more_types.yml | ||
| keycloak-realm-no-log-password-reset.yml | ||
| keycloak_realm_ssl_required.yml | ||
| netapp-removal.yml | ||
| nios-removal.yml | ||
| pkgin-output-after-error.yml | ||
| remove-scripts.yml | ||