1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/tests
patchback[bot] 4255c0d2fc
nmcli: writing secrets to command line is a security hole (#3160) (#3180)
* nmcli: use `stdin` for setting private `wifi_sec` options

I.E.:
* `802-11-wireless-security.leap-password`
* `802-11-wireless-security.psk`
* `802-11-wireless-security.wep-key0`
* `802-11-wireless-security.wep-key1`
* `802-11-wireless-security.wep-key2`
* `802-11-wireless-security.wep-key3`

* Changelog fragement formatting.

* Update changelogs/fragments/3160-pass-wifi-secrets-via-stdin-to-nmcli-module.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Make `wifi_sec_secret_options()` into a constant

* Minor cleanup

`'set ' + key + ' ' + value`
=>
`'set %s %s' % (key, value)`

* Change `casing`

* Change `WIFI_SEC_SECRET_OPTIONS` from `list` to `tuple`

* Update `edit_connection()` to not reset `edit_commands`

It will just re`set` them if `edit_connection()` is called more than
once.

* Do not call `edit_connection()` if `connection_update(*)` fails

* Fixed `pep8` issue `E713` in tests

`test for membership should be 'not in'`

* Simplify `create_connection()`/`modify_connection()` logic

* `WIFI_SEC_SECRET_OPTIONS`=>`SECRET_OPTIONS`, options are prefixed

* Moved `if key in self.SECRET_OPTIONS` into `if value is not None` check

We don't need to do anything is the value is None

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 7f96b7df60)

Co-authored-by: David Hummel <6109326+hummeltech@users.noreply.github.com>
2021-08-08 19:27:11 +02:00
..
integration/targets Update AZP config (#3111) (#3154) 2021-08-06 08:12:52 +02:00
sanity Actually enable BOTMETA sanity test to force new plugins/modules to have BOTMETA entry. (#3096) (#3097) 2021-07-27 20:38:24 +02:00
unit nmcli: writing secrets to command line is a security hole (#3160) (#3180) 2021-08-08 19:27:11 +02:00
utils Dynamically add meta/runtime.yml redirects before integration tests. (#2633) (#2855) 2021-06-22 10:06:33 +02:00
.gitignore Initial commit 2020-03-09 09:11:07 +00:00
config.yml Add ansible-test config file. (#2404) (#2406) 2021-05-01 22:54:44 +02:00
requirements.yml Remove community.kubernetes testing dependency. (#1682) 2021-01-27 07:17:00 +01:00