1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/changelogs/fragments
patchback[bot] 4255c0d2fc
nmcli: writing secrets to command line is a security hole (#3160) (#3180)
* nmcli: use `stdin` for setting private `wifi_sec` options

I.E.:
* `802-11-wireless-security.leap-password`
* `802-11-wireless-security.psk`
* `802-11-wireless-security.wep-key0`
* `802-11-wireless-security.wep-key1`
* `802-11-wireless-security.wep-key2`
* `802-11-wireless-security.wep-key3`

* Changelog fragement formatting.

* Update changelogs/fragments/3160-pass-wifi-secrets-via-stdin-to-nmcli-module.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Make `wifi_sec_secret_options()` into a constant

* Minor cleanup

`'set ' + key + ' ' + value`
=>
`'set %s %s' % (key, value)`

* Change `casing`

* Change `WIFI_SEC_SECRET_OPTIONS` from `list` to `tuple`

* Update `edit_connection()` to not reset `edit_commands`

It will just re`set` them if `edit_connection()` is called more than
once.

* Do not call `edit_connection()` if `connection_update(*)` fails

* Fixed `pep8` issue `E713` in tests

`test for membership should be 'not in'`

* Simplify `create_connection()`/`modify_connection()` logic

* `WIFI_SEC_SECRET_OPTIONS`=>`SECRET_OPTIONS`, options are prefixed

* Moved `if key in self.SECRET_OPTIONS` into `if value is not None` check

We don't need to do anything is the value is None

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 7f96b7df60)

Co-authored-by: David Hummel <6109326+hummeltech@users.noreply.github.com>
2021-08-08 19:27:11 +02:00
..
.keep Rename changelogs/fragments/.empty -> changelogs/fragments/.keep 2020-08-07 08:17:57 +02:00
2946-python-dnsimple-v2-rewrite.yml dnsimple update for python-dnsimple >=2.0.0 (#2946) (#3143) 2021-08-04 12:56:52 +02:00
3034-promox-kvm-return-new-id.yaml Succesful clone from proxmox_kvm should return new vm id, not id from cloned vm. (#3034) (#3083) 2021-07-26 09:07:15 +02:00
3036-archive-root-path-fix.yml archive - fixing determination of archive root when root is '/' (#3036) (#3062) 2021-07-24 22:23:20 +02:00
3038-enhance_github_repo_api_url.yml github_repo: support GitHub on premise installations (#3039) (#3046) 2021-07-22 17:11:22 +02:00
3041-fix_gitlab_group_members_gitlab_project_mambers.yml gitlab_group_members/gitlab_project_members - fix pagination issue (#3054) (#3061) 2021-07-24 21:24:18 +02:00
3044-proxmox-inventory-snapshots.yml Proxmox inventory: Added snapshots fact (#3044) (#3048) 2021-07-22 23:19:39 +02:00
3052_proxmox_inventory_plugin.yml proxmox inventory plugin: Easy fix (#3052) (#3059) 2021-07-24 20:58:17 +02:00
3067-taiga-bugfix.yaml taiga_issue - bugfix + pythonification (#3067) (#3077) 2021-07-25 22:28:40 +02:00
3068-supervisorctl-bugfix.yaml supervisorctl - bugfix + using ansible validation + pythonification (#3068) (#3078) 2021-07-25 22:19:19 +02:00
3079-report-power-state-hpilo.yaml Feature: implement hpilo_info system power info (#3079) (#3121) 2021-07-31 09:38:18 +02:00
3080-java_cert-2460-import_private_key.yml java_cert: import certificate+key bundle from pkcs12 (#3080) (#3086) 2021-07-26 12:06:11 +02:00
3081-add-wifi-option-to-nmcli-module.yml nmcli: Add support for additional Wi-Fi network options (#3081) (#3142) 2021-08-04 08:30:19 +02:00
3084-info-checkmode.yaml added supports_check_mode=True to info/facts modules (#3084) (#3094) 2021-07-27 17:23:10 +00:00
3092-gunicorn-refactor.yaml gunicorn - minor refactoring (#3092) (#3103) 2021-07-28 08:55:33 +02:00
3093-ejabberd_user-refactor.yaml ejabberd_user - refactoring and simplification (#3093) (#3100) 2021-07-28 08:34:56 +02:00
3098-django_manage-cmd-list.yaml django_manage - using list instead of string in run_command() (#3098) (#3102) 2021-07-28 08:35:08 +02:00
3104-deploy_helper-required_if.yaml deploy_helper - changed in-code condition to required_if (#3104) (#3108) 2021-07-29 08:02:44 +02:00
3106-apache2_module-review.yaml apache2_module - multiple improvements (#3106) (#3116) 2021-07-30 20:03:39 +02:00
3125-hana-query-userstore.yaml Hana query userstore (#3125) (#3152) 2021-08-05 23:03:05 +02:00
3132-nmcli-dummy.yaml nmcli: manage dummy connections (#3132) (#3149) 2021-08-05 18:59:03 +02:00
3135-add-redfish_command-bootoverridemode.yaml redfish_command: allow setting the BootSourceOverrideMode property (#3135) (#3147) 2021-08-04 20:07:24 +02:00
3136-add-wifi-sec-change-detection-to-nmcli-module.yml nmcli: Fix change detection for Wi-Fi security options (#3136) (#3166) 2021-08-07 15:39:34 +02:00
3139-tss-lookup-plugin-update-to-make-compatible-with-sdk-v1.yml Updated the tss lookup plugin to reflect breaking changes introduced in the underpinning SDK (#3139) (#3150) 2021-08-05 22:40:15 +02:00
3160-pass-wifi-secrets-via-stdin-to-nmcli-module.yml nmcli: writing secrets to command line is a security hole (#3160) (#3180) 2021-08-08 19:27:11 +02:00
pkgin-output-after-error.yml pkgin: display stdout and stderr in case the error occurs (#3148) (#3156) 2021-08-06 10:22:54 +02:00