mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
93cfe73a76
This is a redesign in how plugins call _remote_checksum(). - _remote_stat() has been modified to report the real error as AnsiblError - Action plugin **unarchive** calls _remote_stat() directly instead of _remote_checksum() - Action plugin **unarchive** also handles the exceptions directly - Ensure get_exception() returns native text Two other action plugins, **template** and **fetch**, also do a remote checksum. In **template** we already call _remote_stat(), just like we now do for unarchive, in **fetch** we do call _remote_checksum() and we make the exact same mistake as the unarchive plugin. So that one could use a redesign as well. This fixes #19494 Before: ``` [dag@moria ansible.testing]$ ansible-playbook -v test137.yml Using /home/dag/home-made/ansible.testing/ansible.cfg as config file PLAY [localhost] ****************************************************************************************************** TASK [unarchive] ****************************************************************************************************** fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "msg": "python isn't present on the system. Unable to compute checksum"} PLAY RECAP ****************************************************************************************************** localhost : ok=0 changed=0 unreachable=0 failed=1 ``` After: ``` [dag@moria ansible.testing]$ ansible-playbook -v test137.yml Using /home/dag/home-made/ansible.testing/ansible.cfg as config file PLAY [localhost] ************************************************************************************************************* TASK [unarchive] ************************************************************************************************************* fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "msg": "Failed to get information on remote file (/tmp/): sudo: unknown user: foobar\nsudo: unable to initialize policy plugin\n"} PLAY RECAP ******************************************************************************************************************* localhost : ok=0 changed=0 unreachable=0 failed=1 ```
134 lines
5 KiB
Python
134 lines
5 KiB
Python
# (c) 2012, Michael DeHaan <michael.dehaan@gmail.com>
|
|
# (c) 2013, Dylan Martin <dmartin@seattlecentral.edu>
|
|
#
|
|
# This file is part of Ansible
|
|
#
|
|
# Ansible is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Ansible is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.
|
|
from __future__ import (absolute_import, division, print_function)
|
|
__metaclass__ = type
|
|
|
|
import os
|
|
|
|
from ansible.errors import AnsibleError
|
|
from ansible.module_utils._text import to_native
|
|
from ansible.module_utils.pycompat24 import get_exception
|
|
from ansible.plugins.action import ActionBase
|
|
from ansible.constants import mk_boolean as boolean
|
|
|
|
|
|
class ActionModule(ActionBase):
|
|
|
|
TRANSFERS_FILES = True
|
|
|
|
def run(self, tmp=None, task_vars=None):
|
|
''' handler for unarchive operations '''
|
|
if task_vars is None:
|
|
task_vars = dict()
|
|
|
|
result = super(ActionModule, self).run(tmp, task_vars)
|
|
|
|
source = self._task.args.get('src', None)
|
|
dest = self._task.args.get('dest', None)
|
|
remote_src = boolean(self._task.args.get('remote_src', False))
|
|
creates = self._task.args.get('creates', None)
|
|
|
|
# "copy" is deprecated in favor of "remote_src".
|
|
if 'copy' in self._task.args:
|
|
# They are mutually exclusive.
|
|
if 'remote_src' in self._task.args:
|
|
result['failed'] = True
|
|
result['msg'] = "parameters are mutually exclusive: ('copy', 'remote_src')"
|
|
return result
|
|
# We will take the information from copy and store it in
|
|
# the remote_src var to use later in this file.
|
|
remote_src = not boolean(self._task.args.get('copy'))
|
|
|
|
if source is None or dest is None:
|
|
result['failed'] = True
|
|
result['msg'] = "src (or content) and dest are required"
|
|
return result
|
|
|
|
remote_user = task_vars.get('ansible_ssh_user') or self._play_context.remote_user
|
|
if not tmp:
|
|
tmp = self._make_tmp_path(remote_user)
|
|
self._cleanup_remote_tmp = True
|
|
|
|
if creates:
|
|
# do not run the command if the line contains creates=filename
|
|
# and the filename already exists. This allows idempotence
|
|
# of command executions.
|
|
if self._remote_file_exists(creates):
|
|
result['skipped'] = True
|
|
result['msg'] = "skipped, since %s exists" % creates
|
|
self._remove_tmp_path(tmp)
|
|
return result
|
|
|
|
dest = self._remote_expand_user(dest) # CCTODO: Fix path for Windows hosts.
|
|
source = os.path.expanduser(source)
|
|
|
|
if not remote_src:
|
|
try:
|
|
source = self._loader.get_real_file(self._find_needle('files', source))
|
|
except AnsibleError:
|
|
result['failed'] = True
|
|
result['msg'] = to_native(get_exception())
|
|
self._remove_tmp_path(tmp)
|
|
return result
|
|
|
|
try:
|
|
remote_stat = self._execute_remote_stat(dest, all_vars=task_vars, follow=True)
|
|
except AnsibleError:
|
|
result['failed'] = True
|
|
result['msg'] = to_native(get_exception())
|
|
self._remove_tmp_path(tmp)
|
|
return result
|
|
|
|
if not remote_stat['exists'] or not remote_stat['isdir']:
|
|
result['failed'] = True
|
|
result['msg'] = "dest '%s' must be an existing dir" % dest
|
|
self._remove_tmp_path(tmp)
|
|
return result
|
|
|
|
if not remote_src:
|
|
# transfer the file to a remote tmp location
|
|
tmp_src = self._connection._shell.join_path(tmp, 'source')
|
|
self._transfer_file(source, tmp_src)
|
|
|
|
# handle diff mode client side
|
|
# handle check mode client side
|
|
|
|
if not remote_src:
|
|
# fix file permissions when the copy is done as a different user
|
|
self._fixup_perms2((tmp, tmp_src), remote_user)
|
|
# Build temporary module_args.
|
|
new_module_args = self._task.args.copy()
|
|
new_module_args.update(
|
|
dict(
|
|
src=tmp_src,
|
|
original_basename=os.path.basename(source),
|
|
),
|
|
)
|
|
|
|
else:
|
|
new_module_args = self._task.args.copy()
|
|
new_module_args.update(
|
|
dict(
|
|
original_basename=os.path.basename(source),
|
|
),
|
|
)
|
|
|
|
# execute the unarchive module now, with the updated args
|
|
result.update(self._execute_module(module_args=new_module_args, task_vars=task_vars))
|
|
self._remove_tmp_path(tmp)
|
|
return result
|