1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/test
Dag Wieers fceb71128e Return code is not very useful to assume a task failed
So I thought I fixed it before, but there's still one location where
the `rc` value is influential to decide whether a task failed or not.

We already established in #24867 that it is up to the module to decide
what the return code actually means, not the task executor. We modified
the existing modules to move that logic into the module (eg. for
command, shell, etc.)

This relates to the integration tests of win_robocopy, where different
return codes have different meanings:

  - 0  --  No files copied.
  - 1  --  Files copied successfully! (changed)
  - 2  --  Some Extra files or directories were detected. No files were copied. (warning)
  - 3  --  (2+1) Some files were copied. Additional files were present. (changed)
  - 4  --  Some mismatched files or directories were detected. Housekeeping might be required!  (changed + warning)
  - 5  --  (4+1) Some files were copied. Some files were mismatched.  (changed + warning)
  - 6  --  (4+2) Additional files and mismatched files exist.  No files were copied. (warning)
  - 7  --  (4+1+2) Files were copied, a file mismatch was present, and additional files were present. (changed + warning)
  - 8  --  Some files or directories could not be copied! (changed + failed)
  - 9 - 15  --  Fatal error. Check log message! (failed)
  - 16  --  Serious Error! No files were copied! Do you have permissions to access $src and $dest? (failed)

This also fixes #24652
2017-06-27 15:40:27 -04:00
..
compile Docs how to test (2nd) (#24094) 2017-04-28 09:08:26 +01:00
integration Add netscaler_server module (#25537) 2017-06-27 23:08:00 +05:30
results Create bot friendly sanity output. (#22381) 2017-03-07 14:59:50 -08:00
runner Cyptography pr 20566 rebase (#25560) 2017-06-27 06:00:15 -07:00
sanity nxos_vxlan_vtep (#25971) 2017-06-24 14:09:11 -04:00
units Return code is not very useful to assume a task failed 2017-06-27 15:40:27 -04:00
utils Cyptography pr 20566 rebase (#25560) 2017-06-27 06:00:15 -07:00