mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
396b94183d
redhat_subscription: refactor of internal Rhsm class (#6658)
The two RegistrationBase & Rhsm classes were copied from the ones in the
shared module_utils.redhat module; that said:
- the versions here got improvements over the years
- the RegistrationBase in module_utils.redhat is used only by the RHN
modules, which are deprecated and slated for removal
Hence, the classes here can be kept and simplified a bit:
- fold the non-dummy content of RegistrationBase into Rhsm: there is no
more need for the separate RegistrationBase base class
- drop the init arguments "username", "password", and "token": the
instance variables of them are not used anywhere, as the needed
credentials (together with other variables) are passed to the
register() method
- create the Rhsm object later in main(), after the AnsibleModule
creation and the uid check: this avoids the creation of Rhsm with a
null module variable, changing it later
There should be no behaviour change.
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| .keep | ||
| 6223-get-secret-ids-by-folderid.yml | ||
| 6435-snap-channel-aware.yml | ||
| 6471-redfish-add-multipart-http-push-command.yml | ||
| 6502-cobbler-inventory_hostname.yml | ||
| 6510-proxmox-create-support_timezone.yaml | ||
| 6512-cpanm-default-mode.yml | ||
| 6513-opkg-default-force.yml | ||
| 6520-mas-disable-signin.yaml | ||
| 6522-copr-respawn.yaml | ||
| 6523-datadog-monitor-notification-preset-name-and-renotify.yaml | ||
| 6525-sorcery-import.yaml | ||
| 6531-opentelemetry-add-event-attributes.yml | ||
| 6533-proxmox_kvm-tpmstate0-support.yaml | ||
| 6539-semantic-markup.yml | ||
| 6568-fix-get-user-by-username-in-keycloak-module-utils.yml | ||
| 6570-handle-shutdown-timeout.yaml | ||
| 6576-proxmox-snap-allow-to-remove-old-snapshots.yml | ||
| 6601-cmdrunner-deprecate-default-type.yml | ||
| 6602-vardict-as-dict.yml | ||
| 6644-dependencymixin-fix.yml | ||
| 6646-redhat_subscription-deprecate-autosubscribe.yml | ||
| 6649-varsmixin-deprecation.yml | ||
| 6650-redhat_subscription-deprecate-pool.yml | ||
| 6658-redhat_subscription-internal-rhsm-refactor.yml | ||
| 6663-deprecate-module_utils-redhat.yml | ||
| ini_file-preserve-symlink.yml | ||