mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
865de5baa0
* bitwarden - add support for filtering by organization_id * Update changelogs/fragments/8188-bitwarden-add-organization_id.yml Co-authored-by: Felix Fontein <felix@fontein.de> * implement PR discussion result on wording * rewrite search_field filtering To correctly handle organization_id and collection_id by passing both to bw. Tests needed to be extended to filter organizations / collections and the testdata needed changes to reflect that a collection always belongs to a single organizaion --------- Co-authored-by: Felix Fontein <felix@fontein.de>
263 lines
9.8 KiB
Python
263 lines
9.8 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Copyright (c) 2022, Jonathan Lung <lungj@heresjono.com>
|
|
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
|
|
# SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
from __future__ import (absolute_import, division, print_function)
|
|
__metaclass__ = type
|
|
|
|
import re
|
|
from ansible_collections.community.general.tests.unit.compat import unittest
|
|
from ansible_collections.community.general.tests.unit.compat.mock import patch
|
|
|
|
from ansible.errors import AnsibleError
|
|
from ansible.module_utils import six
|
|
from ansible.plugins.loader import lookup_loader
|
|
from ansible_collections.community.general.plugins.lookup.bitwarden import Bitwarden
|
|
from ansible.parsing.ajson import AnsibleJSONEncoder
|
|
|
|
MOCK_COLLECTION_ID = "3b12a9da-7c49-40b8-ad33-aede017a7ead"
|
|
MOCK_ORGANIZATION_ID = "292ba0c6-f289-11ee-9301-ef7b639ccd2a"
|
|
|
|
MOCK_RECORDS = [
|
|
{
|
|
"collectionIds": [
|
|
MOCK_COLLECTION_ID
|
|
],
|
|
"deletedDate": None,
|
|
"favorite": False,
|
|
"fields": [
|
|
{
|
|
"linkedId": None,
|
|
"name": "a_new_secret",
|
|
"type": 1,
|
|
"value": "this is a new secret"
|
|
},
|
|
{
|
|
"linkedId": None,
|
|
"name": "not so secret",
|
|
"type": 0,
|
|
"value": "not secret"
|
|
}
|
|
],
|
|
"folderId": "3b12a9da-7c49-40b8-ad33-aede017a7ead",
|
|
"id": "90992f63-ddb6-4e76-8bfc-aede016ca5eb",
|
|
"login": {
|
|
"password": "passwordA3",
|
|
"passwordRevisionDate": "2022-07-26T23:03:23.399Z",
|
|
"totp": None,
|
|
"username": "userA"
|
|
},
|
|
"name": "a_test",
|
|
"notes": None,
|
|
"object": "item",
|
|
"organizationId": MOCK_ORGANIZATION_ID,
|
|
"passwordHistory": [
|
|
{
|
|
"lastUsedDate": "2022-07-26T23:03:23.405Z",
|
|
"password": "a_new_secret: this is secret"
|
|
},
|
|
{
|
|
"lastUsedDate": "2022-07-26T23:03:23.399Z",
|
|
"password": "passwordA2"
|
|
},
|
|
{
|
|
"lastUsedDate": "2022-07-26T22:59:52.885Z",
|
|
"password": "passwordA"
|
|
}
|
|
],
|
|
"reprompt": 0,
|
|
"revisionDate": "2022-07-26T23:03:23.743Z",
|
|
"type": 1
|
|
},
|
|
{
|
|
"collectionIds": [],
|
|
"deletedDate": None,
|
|
"favorite": False,
|
|
"folderId": None,
|
|
"id": "5ebd4d31-104c-49fc-a09c-aedf003d28ad",
|
|
"login": {
|
|
"password": "b",
|
|
"passwordRevisionDate": None,
|
|
"totp": None,
|
|
"username": "a"
|
|
},
|
|
"name": "dupe_name",
|
|
"notes": None,
|
|
"object": "item",
|
|
"organizationId": None,
|
|
"reprompt": 0,
|
|
"revisionDate": "2022-07-27T03:42:40.353Z",
|
|
"type": 1
|
|
},
|
|
{
|
|
"collectionIds": [
|
|
MOCK_COLLECTION_ID
|
|
],
|
|
"deletedDate": None,
|
|
"favorite": False,
|
|
"folderId": None,
|
|
"id": "90657653-6695-496d-9431-aedf003d3015",
|
|
"login": {
|
|
"password": "d",
|
|
"passwordRevisionDate": None,
|
|
"totp": None,
|
|
"username": "c"
|
|
},
|
|
"name": "dupe_name",
|
|
"notes": None,
|
|
"object": "item",
|
|
"organizationId": MOCK_ORGANIZATION_ID,
|
|
"reprompt": 0,
|
|
"revisionDate": "2022-07-27T03:42:46.673Z",
|
|
"type": 1
|
|
},
|
|
{
|
|
"collectionIds": [],
|
|
"deletedDate": None,
|
|
"favorite": False,
|
|
"folderId": None,
|
|
"id": "2bf517be-fb13-11ee-be89-a345aa369a94",
|
|
"login": {
|
|
"password": "e",
|
|
"passwordRevisionDate": None,
|
|
"totp": None,
|
|
"username": "f"
|
|
},
|
|
"name": "non_collection_org_record",
|
|
"notes": None,
|
|
"object": "item",
|
|
"organizationId": MOCK_ORGANIZATION_ID,
|
|
"reprompt": 0,
|
|
"revisionDate": "2024-14-15T11:30:00.000Z",
|
|
"type": 1
|
|
}
|
|
]
|
|
|
|
|
|
class MockBitwarden(Bitwarden):
|
|
|
|
unlocked = True
|
|
|
|
def _run(self, args, stdin=None, expected_rc=0):
|
|
if args[0] == 'get':
|
|
if args[1] == 'item':
|
|
for item in MOCK_RECORDS:
|
|
if item.get('id') == args[2]:
|
|
return AnsibleJSONEncoder().encode(item), ''
|
|
if args[0] == 'list':
|
|
if args[1] == 'items':
|
|
try:
|
|
search_value = args[args.index('--search') + 1]
|
|
except ValueError:
|
|
search_value = None
|
|
|
|
try:
|
|
collection_to_filter = args[args.index('--collectionid') + 1]
|
|
except ValueError:
|
|
collection_to_filter = None
|
|
|
|
try:
|
|
organization_to_filter = args[args.index('--organizationid') + 1]
|
|
except ValueError:
|
|
organization_to_filter = None
|
|
|
|
items = []
|
|
for item in MOCK_RECORDS:
|
|
if search_value and not re.search(search_value, item.get('name')):
|
|
continue
|
|
if collection_to_filter and collection_to_filter not in item.get('collectionIds', []):
|
|
continue
|
|
if organization_to_filter and item.get('organizationId') != organization_to_filter:
|
|
continue
|
|
items.append(item)
|
|
return AnsibleJSONEncoder().encode(items), ''
|
|
|
|
return '[]', ''
|
|
|
|
|
|
class LoggedOutMockBitwarden(MockBitwarden):
|
|
|
|
unlocked = False
|
|
|
|
|
|
class TestLookupModule(unittest.TestCase):
|
|
|
|
def setUp(self):
|
|
self.lookup = lookup_loader.get('community.general.bitwarden')
|
|
|
|
@patch('ansible_collections.community.general.plugins.lookup.bitwarden._bitwarden', new=MockBitwarden())
|
|
def test_bitwarden_plugin_no_match(self):
|
|
# Entry 0, "a_test" of the test input should have no duplicates.
|
|
self.assertEqual([], self.lookup.run(['not_here'], field='password')[0])
|
|
|
|
@patch('ansible_collections.community.general.plugins.lookup.bitwarden._bitwarden', new=MockBitwarden())
|
|
def test_bitwarden_plugin_fields(self):
|
|
# Entry 0, "a_test" of the test input should have no duplicates.
|
|
record = MOCK_RECORDS[0]
|
|
record_name = record['name']
|
|
for k, v in six.iteritems(record['login']):
|
|
self.assertEqual([v],
|
|
self.lookup.run([record_name], field=k)[0])
|
|
|
|
@patch('ansible_collections.community.general.plugins.lookup.bitwarden._bitwarden', new=MockBitwarden())
|
|
def test_bitwarden_plugin_duplicates(self):
|
|
# There are two records with name dupe_name; we need to be order-insensitive with
|
|
# checking what was retrieved.
|
|
self.assertEqual(set(['b', 'd']),
|
|
set(self.lookup.run(['dupe_name'], field='password')[0]))
|
|
|
|
@patch('ansible_collections.community.general.plugins.lookup.bitwarden._bitwarden', new=MockBitwarden())
|
|
def test_bitwarden_plugin_full_item(self):
|
|
# Try to retrieve the full record of the first entry where the name is "a_name".
|
|
self.assertEqual([MOCK_RECORDS[0]],
|
|
self.lookup.run(['a_test'])[0])
|
|
|
|
@patch('ansible_collections.community.general.plugins.lookup.bitwarden._bitwarden', LoggedOutMockBitwarden())
|
|
def test_bitwarden_plugin_unlocked(self):
|
|
record = MOCK_RECORDS[0]
|
|
record_name = record['name']
|
|
with self.assertRaises(AnsibleError) as raised_error:
|
|
self.lookup.run([record_name], field='password')
|
|
|
|
self.assertEqual("Bitwarden Vault locked. Run 'bw unlock'.", str(raised_error.exception))
|
|
|
|
def test_bitwarden_plugin_without_session_option(self):
|
|
mock_bitwarden = MockBitwarden()
|
|
with patch("ansible_collections.community.general.plugins.lookup.bitwarden._bitwarden", mock_bitwarden):
|
|
record = MOCK_RECORDS[0]
|
|
record_name = record['name']
|
|
session = 'session'
|
|
|
|
self.lookup.run([record_name], field=None)
|
|
self.assertIsNone(mock_bitwarden.session)
|
|
|
|
def test_bitwarden_plugin_session_option(self):
|
|
mock_bitwarden = MockBitwarden()
|
|
with patch("ansible_collections.community.general.plugins.lookup.bitwarden._bitwarden", mock_bitwarden):
|
|
record = MOCK_RECORDS[0]
|
|
record_name = record['name']
|
|
session = 'session'
|
|
|
|
self.lookup.run([record_name], field=None, bw_session=session)
|
|
self.assertEqual(mock_bitwarden.session, session)
|
|
|
|
@patch('ansible_collections.community.general.plugins.lookup.bitwarden._bitwarden', new=MockBitwarden())
|
|
def test_bitwarden_plugin_full_collection(self):
|
|
# Try to retrieve the full records of the given collection.
|
|
self.assertEqual([MOCK_RECORDS[0], MOCK_RECORDS[2]], self.lookup.run(None, collection_id=MOCK_COLLECTION_ID)[0])
|
|
|
|
@patch('ansible_collections.community.general.plugins.lookup.bitwarden._bitwarden', new=MockBitwarden())
|
|
def test_bitwarden_plugin_full_organization(self):
|
|
self.assertEqual([MOCK_RECORDS[0], MOCK_RECORDS[2], MOCK_RECORDS[3]],
|
|
self.lookup.run(None, organization_id=MOCK_ORGANIZATION_ID)[0])
|
|
|
|
@patch('ansible_collections.community.general.plugins.lookup.bitwarden._bitwarden', new=MockBitwarden())
|
|
def test_bitwarden_plugin_filter_organization(self):
|
|
self.assertEqual([MOCK_RECORDS[2]],
|
|
self.lookup.run(['dupe_name'], organization_id=MOCK_ORGANIZATION_ID)[0])
|
|
|
|
@patch('ansible_collections.community.general.plugins.lookup.bitwarden._bitwarden', new=MockBitwarden())
|
|
def test_bitwarden_plugin_full_collection_organization(self):
|
|
self.assertEqual([MOCK_RECORDS[0], MOCK_RECORDS[2]], self.lookup.run(None,
|
|
collection_id=MOCK_COLLECTION_ID, organization_id=MOCK_ORGANIZATION_ID)[0])
|