1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/plugins
patchback[bot] 33cf4877f5
proxmox_kvm: fix idempotency issue with state=absent (#811) (#914)
When the `vmid` parameter is not supplied and the module can only rely on
name look-up an early failure can happen if the targeted VM doesn't exist.
In this case a task execution with the parameter `state` set to `absent`
will actually fail instead of being considered ok.

This patch introduces a deferred error-checking for non-existent VMs
by assigning the value -1 to the `vmid` parameter, allowing the actual
verification to be performed in the right code paths.
Is also help to differentiate between a non-existent `vmid` or non-existent
VM `name`.

Previously:

    TASK [ansible-role-proxmox-instance : Remove instance-test]
    changed: [localhost]
    ...
    TASK [ansible-role-proxmox-instance : Remove instance-test]
    fatal: [localhost]: FAILED! => changed=false
      msg: VM instance-test does not exist in cluster.

Now:

    TASK [ansible-role-proxmox-instance : Remove instance-test]
    ok: [localhost]
    ...
    TASK [ansible-role-proxmox-instance : Remove instance-test]
    ok: [localhost]

Update changelogs/fragments/811-proxmox-kvm-state-absent.yml

With suggestions from Felix Fontein <felix@fontein.de>.

(cherry picked from commit 73f8338980)

Co-authored-by: Tristan Le Guern <tleguern@bouledef.eu>
2020-09-17 19:41:19 +02:00
..
action New module: shutdown (#700) 2020-08-18 08:29:38 +02:00
become Fix various sanity errors in plugins (#881) (#893) 2020-09-17 16:39:57 +00:00
cache Clean up deprecations (#504) 2020-06-16 13:15:19 +02:00
callback Fix various sanity errors in plugins (#881) (#893) 2020-09-17 16:39:57 +00:00
connection Fix plugins (names, constants, FQCNs in examples) (#722) 2020-08-18 08:29:44 +02:00
doc_fragments Scaleway - Fix api_token documentation (#747) 2020-08-18 08:30:30 +02:00
filter JC plugin (#750) 2020-08-18 08:30:37 +02:00
inventory Fix various sanity errors in plugins (#881) (#893) 2020-09-17 16:39:57 +00:00
lookup Fix various sanity errors in plugins (#881) (#893) 2020-09-17 16:39:57 +00:00
module_utils ipa module utils: BUGFIX ipa modules Cookie problem with Loadbalanced IPA and Python3 (… (#738) 2020-08-18 08:30:04 +02:00
modules proxmox_kvm: fix idempotency issue with state=absent (#811) (#914) 2020-09-17 19:41:19 +02:00