1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/tests/unit/plugins
patchback[bot] 02a257569a
[PR #7369/1bf5a44a backport][stable-6] Fix lxc plugin options (#7370)
Fix lxc plugin options (#7369)

* Fixture for liblxc

Add a fixture to allow testing the lxc connection plugin both with and
without liblxc being present.

Also change the test from unittest to pytest.

* Update liblxc error message

The error is not specific to python2, so remove the version. Also add
a test for it.

* Migrate to options

Because the lxc plugin was only using PlayContext properties, using host
vars like `ansible_lxc_host` didn't work. This is fixed by instead using
the `get_option` method inherited from `AnsiblePlugin`.
The options are not yet available in the `__init__` function, so the
determination of the container name is moved to the `_connect` method,
which is the first time it is actually needed.
The default for the `remote_addr` option is removed, because the string
`inventory_hostname` is not very useful. At all. This seams to have been
spread with copy&paste and a bit of cargo culting. The variable priority
already takes care of setting the value.

* Add changelog fragment

* Fix for Py2.7

`TypeError: super() takes at least 1 argument (0 given)`

* Add plugin type to changelog fragment.

* Restore untemplated default

This partially reverts commit 429d8c8cfb.

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 1bf5a44a77)

Co-authored-by: Corubba <97832352+corubba@users.noreply.github.com>
2023-10-09 09:21:43 +02:00
..
become [PR #5978/9f87989e backport][stable-6] Remove unnecessary test imports (#5979) 2023-02-12 21:36:32 +01:00
cache [PR #5978/9f87989e backport][stable-6] Remove unnecessary test imports (#5979) 2023-02-12 21:36:32 +01:00
callback [PR #5978/9f87989e backport][stable-6] Remove unnecessary test imports (#5979) 2023-02-12 21:36:32 +01:00
connection [PR #7369/1bf5a44a backport][stable-6] Fix lxc plugin options (#7370) 2023-10-09 09:21:43 +02:00
filter [PR #5978/9f87989e backport][stable-6] Remove unnecessary test imports (#5979) 2023-02-12 21:36:32 +01:00
inventory [PR #5978/9f87989e backport][stable-6] Remove unnecessary test imports (#5979) 2023-02-12 21:36:32 +01:00
lookup [PR #7241/1beb38ce backport][stable-6] Use get(..) instead of [..] for safe lookup of value (Fixes #7240) (#7257) 2023-09-13 06:24:24 +00:00
module_utils [PR #6688/032996e0 backport][stable-6] Fix composites comparison for role in is_struct_included keycloak.py … (#6689) 2023-06-14 23:30:30 +02:00
modules [PR #7181/d6ebba1a backport][stable-6] cmd tests improvement (#7186) 2023-09-01 11:28:01 +00:00