1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/tests
patchback[bot] 1cddae2265
nmcli: avoid changed status for most cases with VPN connections (#5126) (#5220)
* nmcli: avoid changed status for most cases with VPN connections

Follow-up https://github.com/ansible-collections/community.general/pull/4746

* `nmcli connection show` includes vpn.service-type but not vpn-type.
  Switching to vpn.service-type removes unneeded diffs while keeping
  the same functionality, as vpn-type is an alias of vpn.service-type
  per nm-settings-nmcli(1).

  NetworkManager also adds `org.freedesktop.NetworkManager.` prefix for
  known VPN types [1]. The logic is non-trivial so I didn't implement it
  in this commit. If a user specifies `service-type: l2tp`, changed will
  be always be True:

    -    "vpn.service-type": "org.freedesktop.NetworkManager.l2tp"
    +    "vpn.service-type": "l2tp"

* The vpn.data field from `nmcli connection show` is sorted by keys and
  there are spaces around equal signs. I added codes for parsing such
  data.

Tests are also updated to match outputs of nmcli commands.

[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/1.38.4/src/libnm-core-impl/nm-vpn-plugin-info.c#L619

* Add changelog

* Some suggested changes

* Make space stripping more flexible - works for cases without equal
  signs.
* Keep vpn.data in a test case with no spaces

* nmcli: allow any string for vpn service-type

(cherry picked from commit 6ff594b524)

Co-authored-by: Chih-Hsuan Yen <yan12125@gmail.com>
2022-09-03 12:15:38 +02:00
..
integration/targets Catch more broader error messages. (#5212) (#5215) 2022-09-03 11:38:38 +02:00
sanity Make reuse conformant (#5138) (#5139) 2022-08-21 09:14:04 +02:00
unit nmcli: avoid changed status for most cases with VPN connections (#5126) (#5220) 2022-09-03 12:15:38 +02:00
utils [TEMP] Fix RHEL 8 issues by restricting bcrypt to < 4.0.0 (#5183) (#5187) 2022-08-25 08:07:20 +02:00
.gitignore Add more default license and copyright notices (#5087) (#5094) 2022-08-08 14:06:21 +02:00
config.yml Add default license header to files which have no copyright or license header yet (#5074) (#5075) 2022-08-05 20:16:36 +02:00
requirements.yml Add default license header to files which have no copyright or license header yet (#5074) (#5075) 2022-08-05 20:16:36 +02:00