ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity
community.general/changelogs/fragments
History
patchback[bot] 1cddae2265
nmcli: avoid changed status for most cases with VPN connections (#5126) (#5220) 
* nmcli: avoid changed status for most cases with VPN connections

Follow-up https://github.com/ansible-collections/community.general/pull/4746

* `nmcli connection show` includes vpn.service-type but not vpn-type.
  Switching to vpn.service-type removes unneeded diffs while keeping
  the same functionality, as vpn-type is an alias of vpn.service-type
  per nm-settings-nmcli(1).

  NetworkManager also adds `org.freedesktop.NetworkManager.` prefix for
  known VPN types [1]. The logic is non-trivial so I didn't implement it
  in this commit. If a user specifies `service-type: l2tp`, changed will
  be always be True:

    -    "vpn.service-type": "org.freedesktop.NetworkManager.l2tp"
    +    "vpn.service-type": "l2tp"

* The vpn.data field from `nmcli connection show` is sorted by keys and
  there are spaces around equal signs. I added codes for parsing such
  data.

Tests are also updated to match outputs of nmcli commands.

[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/1.38.4/src/libnm-core-impl/nm-vpn-plugin-info.c#L619

* Add changelog

* Some suggested changes

* Make space stripping more flexible - works for cases without equal
  signs.
* Keep vpn.data in a test case with no spaces

* nmcli: allow any string for vpn service-type

(cherry picked from commit 6ff594b524)

Co-authored-by: Chih-Hsuan Yen <yan12125@gmail.com>
2022-09-03 12:15:38 +02:00
..
.keep Rename changelogs/fragments/.empty -> changelogs/fragments/.keep 2020-08-07 08:17:57 +02:00
5124-compatibility-virtualmedia-resource-location.yaml Update redfish module for compatibility with VirtualMedia resource location (#5124) (#5180) 2022-08-24 21:44:44 +02:00
5126-nmcli-remove-diffs.yml nmcli: avoid changed status for most cases with VPN connections (#5126) (#5220) 2022-09-03 12:15:38 +02:00
5151-add-delinea-support-tss-lookup.yml adding nested try block for tss.py to import new Delinea library (#5151) (#5164) 2022-08-23 22:03:30 +02:00
5194-fix-proxmox-agent-exception.yaml Fix exception when agent argument is not specified. (#5194) (#5195) 2022-08-28 12:16:07 +02:00
5202-bugfix-environmentError-wrong-indentation.yaml Bugfix - EnvironmentError with wrong indentation (#5202) (#5221) 2022-09-03 12:15:30 +02:00
5203-seport-add-local-argument.yaml seport: add local argument (#5203) (#5218) 2022-09-03 11:58:47 +02:00