1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/plugins
Mike Wadsten 787fa46217
fix(modules/gitlab_runner): Use correct argument to list all runners (#7790)
* fix(modules/gitlab_runner): Use correct argument to list all runners

python-gitlab 4.0.0 removed support for the `as_list=False` parameter.
This functionality is now available as `iterator=True`.

Without this change, the module actually only retrieves the first
20 results, which can lead to non-idempotent behavior, such as
registering a runner again.

* Add changelog entry (#7790)

* gitlab_runner: Check python-gitlab version when listing runners

* gitlab: Add list_all_kwargs variable to module_utils

* refactor(gitlab modules): use list_all_kwargs where it helps (#7790)

I did not change every instance of all=True or all=False, only those
which could obviously benefit from simplifying:

  * Code using `all=True` but then searching for any items that match a
    condition (no need to collect the full list).
  * Code that basically reimplements `all=True` with manual pagination.
    (These could be changed to `all=True`, but `list_all_kwargs` also
    sets per_page to 100, to gather data faster.)

* gitlab_instance_variable: Use list_all_kwargs

* Add new changelog entry for gitlab module changes (#7790)
2024-02-25 19:45:30 +01:00
..
action Fix more typos (#7439) 2023-10-29 18:04:44 +01:00
become machinectl become plugin: mark as require_tty (#6935) 2023-07-15 12:53:59 +02:00
cache Fix more typos (#7439) 2023-10-29 18:04:44 +01:00
callback Add default_without_diff callback (#7949) 2024-02-14 22:53:16 +01:00
connection Refer to LXD containers/VMs as instances (#7873) 2024-01-24 13:35:17 +01:00
doc_fragments Consul action group (#7897) 2024-01-27 10:58:41 +01:00
filter New filters to calculate the union, intersection, difference and symmetric difference of lists by preserving the items order (#7985) 2024-02-23 20:35:09 +01:00
inventory Add templating support to Icinga2 Inventory (#7996) 2024-02-25 07:37:53 +01:00
lookup feat(lookup/bitwarden): add support for "session" arg (#7994) 2024-02-25 19:44:37 +01:00
module_utils fix(modules/gitlab_runner): Use correct argument to list all runners (#7790) 2024-02-25 19:45:30 +01:00
modules fix(modules/gitlab_runner): Use correct argument to list all runners (#7790) 2024-02-25 19:45:30 +01:00
test Add test fqdn_valid (#7533) 2023-11-22 09:12:00 +01:00