mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
1613a739ad
* Fix errors decrypted non-ascii vault vars AnsibleVaultEncryptedUnicode was just using b"".decode() instead of to_text() on the bytestrings returned from vault.decrypt() and could cause errors on python2 if non-ascii since decode() defaults to ascii. Use to_text() to default to decoding utf-8. add intg and unit tests for value of vaulted vars being non-ascii utf8 based on https://github.com/ansible/ansible/issues/37258 Fixes #37258 * yamllint fixups
157 lines
5.5 KiB
Python
157 lines
5.5 KiB
Python
# This file is part of Ansible
|
|
# -*- coding: utf-8 -*-
|
|
#
|
|
# Ansible is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Ansible is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
# Copyright 2016, Adrian Likins <alikins@redhat.com>
|
|
|
|
# Make coding more python3-ish
|
|
from __future__ import (absolute_import, division, print_function)
|
|
__metaclass__ = type
|
|
|
|
from ansible.compat.tests import unittest
|
|
|
|
from ansible.errors import AnsibleError
|
|
|
|
from ansible.parsing import vault
|
|
from ansible.parsing.yaml.loader import AnsibleLoader
|
|
|
|
# module under test
|
|
from ansible.parsing.yaml import objects
|
|
|
|
from units.mock.yaml_helper import YamlTestUtils
|
|
from units.mock.vault_helper import TextVaultSecret
|
|
|
|
|
|
class TestAnsibleVaultUnicodeNoVault(unittest.TestCase, YamlTestUtils):
|
|
def test_empty_init(self):
|
|
self.assertRaises(TypeError, objects.AnsibleVaultEncryptedUnicode)
|
|
|
|
def test_empty_string_init(self):
|
|
seq = ''.encode('utf8')
|
|
self.assert_values(seq)
|
|
|
|
def test_empty_byte_string_init(self):
|
|
seq = b''
|
|
self.assert_values(seq)
|
|
|
|
def _assert_values(self, avu, seq):
|
|
self.assertIsInstance(avu, objects.AnsibleVaultEncryptedUnicode)
|
|
self.assertTrue(avu.vault is None)
|
|
# AnsibleVaultEncryptedUnicode without a vault should never == any string
|
|
self.assertNotEquals(avu, seq)
|
|
|
|
def assert_values(self, seq):
|
|
avu = objects.AnsibleVaultEncryptedUnicode(seq)
|
|
self._assert_values(avu, seq)
|
|
|
|
def test_single_char(self):
|
|
seq = 'a'.encode('utf8')
|
|
self.assert_values(seq)
|
|
|
|
def test_string(self):
|
|
seq = 'some letters'
|
|
self.assert_values(seq)
|
|
|
|
def test_byte_string(self):
|
|
seq = 'some letters'.encode('utf8')
|
|
self.assert_values(seq)
|
|
|
|
|
|
class TestAnsibleVaultEncryptedUnicode(unittest.TestCase, YamlTestUtils):
|
|
def setUp(self):
|
|
self.good_vault_password = "hunter42"
|
|
good_vault_secret = TextVaultSecret(self.good_vault_password)
|
|
self.good_vault_secrets = [('good_vault_password', good_vault_secret)]
|
|
self.good_vault = vault.VaultLib(self.good_vault_secrets)
|
|
|
|
# TODO: make this use two vault secret identities instead of two vaultSecrets
|
|
self.wrong_vault_password = 'not-hunter42'
|
|
wrong_vault_secret = TextVaultSecret(self.wrong_vault_password)
|
|
self.wrong_vault_secrets = [('wrong_vault_password', wrong_vault_secret)]
|
|
self.wrong_vault = vault.VaultLib(self.wrong_vault_secrets)
|
|
|
|
self.vault = self.good_vault
|
|
self.vault_secrets = self.good_vault_secrets
|
|
|
|
def _loader(self, stream):
|
|
return AnsibleLoader(stream, vault_secrets=self.vault_secrets)
|
|
|
|
def test_dump_load_cycle(self):
|
|
aveu = self._from_plaintext('the test string for TestAnsibleVaultEncryptedUnicode.test_dump_load_cycle')
|
|
self._dump_load_cycle(aveu)
|
|
|
|
def assert_values(self, avu, seq):
|
|
self.assertIsInstance(avu, objects.AnsibleVaultEncryptedUnicode)
|
|
|
|
self.assertEqual(avu, seq)
|
|
self.assertTrue(avu.vault is self.vault)
|
|
self.assertIsInstance(avu.vault, vault.VaultLib)
|
|
|
|
def _from_plaintext(self, seq):
|
|
id_secret = vault.match_encrypt_secret(self.good_vault_secrets)
|
|
return objects.AnsibleVaultEncryptedUnicode.from_plaintext(seq, vault=self.vault, secret=id_secret[1])
|
|
|
|
def _from_ciphertext(self, ciphertext):
|
|
avu = objects.AnsibleVaultEncryptedUnicode(ciphertext)
|
|
avu.vault = self.vault
|
|
return avu
|
|
|
|
def test_empty_init(self):
|
|
self.assertRaises(TypeError, objects.AnsibleVaultEncryptedUnicode)
|
|
|
|
def test_empty_string_init_from_plaintext(self):
|
|
seq = ''
|
|
avu = self._from_plaintext(seq)
|
|
self.assert_values(avu, seq)
|
|
|
|
def test_empty_unicode_init_from_plaintext(self):
|
|
seq = u''
|
|
avu = self._from_plaintext(seq)
|
|
self.assert_values(avu, seq)
|
|
|
|
def test_string_from_plaintext(self):
|
|
seq = 'some letters'
|
|
avu = self._from_plaintext(seq)
|
|
self.assert_values(avu, seq)
|
|
|
|
def test_unicode_from_plaintext(self):
|
|
seq = u'some letters'
|
|
avu = self._from_plaintext(seq)
|
|
self.assert_values(avu, seq)
|
|
|
|
def test_unicode_from_plaintext_encode(self):
|
|
seq = u'some text here'
|
|
avu = self._from_plaintext(seq)
|
|
b_avu = avu.encode('utf-8', 'strict')
|
|
self.assertIsInstance(avu, objects.AnsibleVaultEncryptedUnicode)
|
|
self.assertEqual(b_avu, seq.encode('utf-8', 'strict'))
|
|
self.assertTrue(avu.vault is self.vault)
|
|
self.assertIsInstance(avu.vault, vault.VaultLib)
|
|
|
|
# TODO/FIXME: make sure bad password fails differently than 'thats not encrypted'
|
|
def test_empty_string_wrong_password(self):
|
|
seq = ''
|
|
self.vault = self.wrong_vault
|
|
avu = self._from_plaintext(seq)
|
|
|
|
def compare(avu, seq):
|
|
return avu == seq
|
|
|
|
self.assertRaises(AnsibleError, compare, avu, seq)
|
|
|
|
def test_vaulted_utf8_value_37258(self):
|
|
seq = u"aöffü"
|
|
avu = self._from_plaintext(seq)
|
|
self.assert_values(avu, seq)
|