1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/plugins
marcus67 12c0220c59
Add option "options" to snap module (#3943)
* Add functionality proposed in https://github.com/ansible-collections/community.general/issues/666

* Fix pylint errors mentioned in CI pipeline

* Fix pylint errors mentioned in CI pipeline (continued)

* Update plugins/modules/packaging/os/snap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Added tests
Fixed error occurring when called without options
Added changelog snippet

* Remove changelog entry as suggested in review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* rewrite `if len(overall_options_changed) > 0` in a more Pythonic way
un-indent `if len(overall_options_changed) > 0` to only be executed after the options of all snaps have been checked

* better placement of local variable `overall_options_changed`

* Re-arrange code to reduce indentation level (suggested by reviewer)

* Re-arrange code to reduce indentation level (suggested by reviewer, continued)

* Re-arrange code to reduce indentation level (suggested by reviewer, continued)
Raise exception if option map returned by `snap set` contains list container (suggested by reviewer)
Handle Python2 type `long` correctly (suggested by reviewer)

Co-authored-by: Felix Fontein <felix@fontein.de>
2022-01-24 06:39:37 +01:00
..
action fixed the utf-8 marker (#3162) 2021-08-07 15:02:21 +02:00
become
cache Fix new devel sanity errors. (#3194) 2021-08-12 12:07:50 +02:00
callback mail: add Date and Message-ID headers (#4056) 2022-01-21 07:27:20 +01:00
connection Get rid of distutils.spawn and distutils.util (#3934) 2022-01-04 06:56:28 +01:00
doc_fragments Add additional auth support to Gitlab (#705) (#3918) 2021-12-20 21:59:12 +01:00
filter Add counter filter (#3921) 2021-12-26 14:56:21 +01:00
inventory Update example (#4041) 2022-01-16 20:31:24 +01:00
lookup Fix example code for flattened lookup (#4013) 2022-01-09 11:11:56 +01:00
module_utils Move Proxmox HAS_PROXMOXER check into module_utils. (#4030) 2022-01-16 20:13:47 +01:00
modules Add option "options" to snap module (#3943) 2022-01-24 06:39:37 +01:00
test a_module test: fix crash in case of tombstoning (#3660) 2021-11-04 08:29:17 +01:00