1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/test/units/executor
Steve Kuznetsov 0bc35354ce Change v2_playbook_on_start logic to positively detect legacy plugins
In order to support legacy plugins, the following two method signatures
are allowed for `CallbackBase.v2_playbook_on_start`:

def v2_playbook_on_start(self):
def v2_playbook_on_start(self, playbook):

Previously, the logic to handle this divergence checked to see if the
callback plugin being called supported an argument named `playbook`
in its `v2_playbook_on_start` method. This was fragile in a few ways:
 - if a plugin author did not use the literal `playbook` to name their
   method argument, their plugin would not be called correctly
 - if a plugin author wrapped their `v2_playbook_on_start` method and
   by doing so changed the argspec to no longer expose an argument
   with that literal name, their plugin would not be called correctly

In order to continue to support both types of callback for backwards
compatibility while making the call more robust for plugin authors,
the logic can be reversed in order to have a positive check for the old
method signature instead of a positive check for the new one.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
2016-10-28 10:05:58 -07:00
..
__init__.py Making the switch to v2 2015-05-03 21:47:26 -05:00
test_play_iterator.py Cache tasks by uuid in PlayIterator for O(1) lookups 2016-08-10 12:49:19 -05:00
test_playbook_executor.py test name TestPlayIterator->TestPlaybookExecutor 2016-10-23 02:19:04 +02:00
test_task_executor.py Avoid copying task parents in TaskExecutor 2016-08-08 15:58:46 -05:00
test_task_queue_manager_callbacks.py Change v2_playbook_on_start logic to positively detect legacy plugins 2016-10-28 10:05:58 -07:00
test_task_result.py add jimi-c's unit test for squashed skip results, tweaked is_skipped() logic to pass 2016-05-05 15:29:10 -07:00