1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/plugins/modules/packaging/os
patchback[bot] d27c06faeb
[PR #3943/12c0220c backport][stable-4] Add option "options" to snap module (#4076)
* Add option "options" to snap module (#3943)

* Add functionality proposed in https://github.com/ansible-collections/community.general/issues/666

* Fix pylint errors mentioned in CI pipeline

* Fix pylint errors mentioned in CI pipeline (continued)

* Update plugins/modules/packaging/os/snap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Added tests
Fixed error occurring when called without options
Added changelog snippet

* Remove changelog entry as suggested in review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* rewrite `if len(overall_options_changed) > 0` in a more Pythonic way
un-indent `if len(overall_options_changed) > 0` to only be executed after the options of all snaps have been checked

* better placement of local variable `overall_options_changed`

* Re-arrange code to reduce indentation level (suggested by reviewer)

* Re-arrange code to reduce indentation level (suggested by reviewer, continued)

* Re-arrange code to reduce indentation level (suggested by reviewer, continued)
Raise exception if option map returned by `snap set` contains list container (suggested by reviewer)
Handle Python2 type `long` correctly (suggested by reviewer)

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 12c0220c59)

* Fix version_added.

(cherry picked from commit 62d519de10)

Co-authored-by: marcus67 <marcus.rickert@web.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-01-24 09:23:31 +01:00
..
apk.py Tidy up validate-modules ignores for packaging modules (#1289) 2020-11-13 12:41:11 +00:00
apt_repo.py modules: fix examples to use FQCN (#644) 2020-07-13 21:50:31 +02:00
apt_rpm.py Deprecation of parameters triggering the parameter-invalid sanity-check (#1927) 2021-03-05 08:17:36 +01:00
copr.py Fix copr integration tests (#3237) 2021-09-01 22:58:10 +02:00
dnf_versionlock.py dnf_versionlock: new module (#3552) 2021-10-27 22:36:48 +02:00
flatpak.py Prepare for distutils.version being removed in Python 3.12 (#3936) (#3941) 2021-12-24 19:15:47 +01:00
flatpak_remote.py Replace ansible.module_utils._text by ansible.module_utils.common.text.converters (#2877) 2021-06-26 23:59:11 +02:00
homebrew.py Fixed typo in homebrew documentation (#3577) 2021-10-18 22:43:57 +02:00
homebrew_cask.py Prepare for distutils.version being removed in Python 3.12 (#3936) (#3941) 2021-12-24 19:15:47 +01:00
homebrew_tap.py homebrew_tap: Add support for brew search path (#1708) 2021-02-01 08:42:32 +01:00
installp.py modules: fix examples to use FQCN (#644) 2020-07-13 21:50:31 +02:00
layman.py modules: fix examples to use FQCN (#644) 2020-07-13 21:50:31 +02:00
macports.py macports: add stdout and stderr to status (#3499) (#3500) 2021-10-11 06:55:09 +02:00
mas.py Prepare for distutils.version being removed in Python 3.12 (#3936) (#3941) 2021-12-24 19:15:47 +01:00
openbsd_pkg.py Prepare for distutils.version being removed in Python 3.12 (#3936) (#3941) 2021-12-24 19:15:47 +01:00
opkg.py Improve opkg module (#3554) 2021-10-14 21:14:32 +02:00
pacman.py pacman: add stdout and stderr as return parameters (#3758) (#3775) 2021-11-22 20:01:50 +01:00
pacman_key.py Replace ansible.module_utils._text by ansible.module_utils.common.text.converters (#2877) 2021-06-26 23:59:11 +02:00
pkg5.py Tidy up validate-modules ignores for packaging modules (#1289) 2020-11-13 12:41:11 +00:00
pkg5_publisher.py modules: fix examples to use FQCN (#644) 2020-07-13 21:50:31 +02:00
pkgin.py Fix exception in pkgin module when all packages are already installed (#3583) 2021-10-22 07:47:27 +02:00
pkgng.py pkgng: add basic integration tests (#3526) 2021-10-22 07:32:35 +02:00
pkgutil.py fixed calls to list.extend() (#2161) 2021-04-04 23:38:59 +02:00
portage.py Replace ansible.module_utils._text by ansible.module_utils.common.text.converters (#2877) 2021-06-26 23:59:11 +02:00
portinstall.py modules: fix examples to use FQCN (#644) 2020-07-13 21:50:31 +02:00
pulp_repo.py Add a Pulp 2 related note to pulp_repo (#2096) 2021-03-24 17:48:24 +01:00
redhat_subscription.py mass-added the utf-8 marker (#3163) 2021-08-08 10:40:22 +02:00
rhn_channel.py mass-added the utf-8 marker (#3163) 2021-08-08 10:40:22 +02:00
rhn_register.py rhn_register: added force option to allow forced registering (#1454) (#1455) 2020-12-08 13:12:04 +01:00
rhsm_release.py mass-added the utf-8 marker (#3163) 2021-08-08 10:40:22 +02:00
rhsm_repository.py mass-added the utf-8 marker (#3163) 2021-08-08 10:40:22 +02:00
rpm_ostree_pkg.py mass-added the utf-8 marker (#3163) 2021-08-08 10:40:22 +02:00
slackpkg.py Deprecation of parameters triggering the parameter-invalid sanity-check (#1927) 2021-03-05 08:17:36 +01:00
snap.py [PR #3943/12c0220c backport][stable-4] Add option "options" to snap module (#4076) 2022-01-24 09:23:31 +01:00
snap_alias.py fix modules' output by using publish_cmd (#3655) 2021-11-01 13:53:02 +01:00
sorcery.py modules: fix examples to use FQCN (#644) 2020-07-13 21:50:31 +02:00
svr4pkg.py Fix #2373 - TypeError: a bytes-like object is required, not 'str' (#2375) 2021-05-03 07:25:08 +02:00
swdepot.py modules: fix examples to use FQCN (#644) 2020-07-13 21:50:31 +02:00
swupd.py mass-added the utf-8 marker (#3163) 2021-08-08 10:40:22 +02:00
urpmi.py Deprecation of parameters triggering the parameter-invalid sanity-check (#1927) 2021-03-05 08:17:36 +01:00
xbps.py Remove deprecated features scheduled for removal in 3.0.0 (#1926) 2021-03-09 21:23:20 +01:00
yum_versionlock.py yum_versionlock: fix idempotency when using wildcard (asterisk) (#2787) 2021-06-27 16:40:49 +02:00
zypper.py zypper: support transactional-updates (#3164) 2021-08-12 08:17:03 +02:00
zypper_repository.py Prepare for distutils.version being removed in Python 3.12 (#3936) (#3941) 2021-12-24 19:15:47 +01:00