mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
445ff39f94
* [WIP] become plugins Move from hardcoded method to plugins for ease of use, expansion and overrides - load into connection as it is going to be the main consumer - play_context will also use to keep backwards compat API - ensure shell is used to construct commands when needed - migrate settings remove from base config in favor of plugin specific configs - cleanup ansible-doc - add become plugin docs - remove deprecated sudo/su code and keywords - adjust become options for cli - set plugin options from context - ensure config defs are avaialbe before instance - refactored getting the shell plugin, fixed tests - changed into regex as they were string matching, which does not work with random string generation - explicitly set flags for play context tests - moved plugin loading up front - now loads for basedir also - allow pyc/o for non m modules - fixes to tests and some plugins - migrate to play objects fro play_context - simiplify gathering - added utf8 headers - moved option setting - add fail msg to dzdo - use tuple for multiple options on fail/missing - fix relative plugin paths - shift from play context to play - all tasks already inherit this from play directly - remove obsolete 'set play' - correct environment handling - add wrap_exe option to pfexec - fix runas to noop - fixed setting play context - added password configs - removed required false - remove from doc building till they are ready future development: - deal with 'enable' and 'runas' which are not 'command wrappers' but 'state flags' and currently hardcoded in diff subsystems * cleanup remove callers to removed func removed --sudo cli doc refs remove runas become_exe ensure keyerorr on plugin also fix backwards compat, missing method is attributeerror, not ansible error get remote_user consistently ignore missing system_tmpdirs on plugin load correct config precedence add deprecation fix networking imports backwards compat for plugins using BECOME_METHODS * Port become_plugins to context.CLIARGS This is a work in progress: * Stop passing options around everywhere as we can use context.CLIARGS instead * Refactor make_become_commands as asked for by alikins * Typo in comment fix * Stop loading values from the cli in more than one place Both play and play_context were saving default values from the cli arguments directly. This changes things so that the default values are loaded into the play and then play_context takes them from there. * Rename BECOME_PLUGIN_PATH to DEFAULT_BECOME_PLUGIN_PATH As alikins said, all other plugin paths are named DEFAULT_plugintype_PLUGIN_PATH. If we're going to rename these, that should be done all at one time rather than piecemeal. * One to throw away This is a set of hacks to get setting FieldAttribute defaults to command line args to work. It's not fully done yet. After talking it over with sivel and jimi-c this should be done by fixing FieldAttributeBase and _get_parent_attribute() calls to do the right thing when there is a non-None default. What we want to be able to do ideally is something like this: class Base(FieldAttributeBase): _check_mode = FieldAttribute([..] default=lambda: context.CLIARGS['check']) class Play(Base): # lambda so that we have a chance to parse the command line args # before we get here. In the future we might be able to restructure # this so that the cli parsing code runs before these classes are # defined. class Task(Base): pass And still have a playbook like this function: --- - hosts: tasks: - command: whoami check_mode: True (The check_mode test that is added as a separate commit in this PR will let you test variations on this case). There's a few separate reasons that the code doesn't let us do this or a non-ugly workaround for this as written right now. The fix that jimi-c, sivel, and I talked about may let us do this or it may still require a workaround (but less ugly) (having one class that has the FieldAttributes with default values and one class that inherits from that but just overrides the FieldAttributes which now have defaults) * Revert "One to throw away" This reverts commit 23aa883cbed11429ef1be2a2d0ed18f83a3b8064. * Set FieldAttr defaults directly from CLIARGS * Remove dead code * Move timeout directly to PlayContext, it's never needed on Play * just for backwards compat, add a static version of BECOME_METHODS to constants * Make the become attr on the connection public, since it's used outside of the connection * Logic fix * Nuke connection testing if it supports specific become methods * Remove unused vars * Address rebase issues * Fix path encoding issue * Remove unused import * Various cleanups * Restore network_cli check in _low_level_execute_command * type improvements for cliargs_deferred_get and swap shallowcopy to default to False * minor cleanups * Allow the su plugin to work, since it doesn't define a prompt the same way * Fix up ksu become plugin * Only set prompt if build_become_command was called * Add helper to assist connection plugins in knowing they need to wait for a prompt * Fix tests and code expectations * Doc updates * Various additional minor cleanups * Make doas functional * Don't change connection signature, load become plugin from TaskExecutor * Remove unused imports * Add comment about setting the become plugin on the playcontext * Fix up tests for recent changes * Support 'Password:' natively for the doas plugin * Make default prompts raw * wording cleanups. ci_complete * Remove unrelated changes * Address spelling mistake * Restore removed test, and udpate to use new functionality * Add changelog fragment * Don't hard fail in set_attributes_from_cli on missing CLI keys * Remove unrelated change to loader * Remove internal deprecated FieldAttributes now * Emit deprecation warnings now
192 lines
8.2 KiB
Python
192 lines
8.2 KiB
Python
# (c) 2012-2014, Michael DeHaan <michael.dehaan@gmail.com>
|
|
# (c) 2017 Ansible Project
|
|
#
|
|
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
|
|
|
|
# Make coding more python3-ish
|
|
from __future__ import (absolute_import, division, print_function)
|
|
__metaclass__ = type
|
|
|
|
import re
|
|
import pytest
|
|
|
|
from ansible import constants as C
|
|
from ansible import context
|
|
from ansible.cli.arguments import optparse_helpers as opt_help
|
|
from ansible.errors import AnsibleError
|
|
from ansible.playbook.play_context import PlayContext
|
|
from ansible.playbook.play import Play
|
|
from ansible.plugins.loader import become_loader
|
|
from ansible.utils import context_objects as co
|
|
|
|
|
|
@pytest.fixture
|
|
def parser():
|
|
parser = opt_help.create_base_parser()
|
|
|
|
opt_help.add_runas_options(parser)
|
|
opt_help.add_meta_options(parser)
|
|
opt_help.add_runtask_options(parser)
|
|
opt_help.add_vault_options(parser)
|
|
opt_help.add_async_options(parser)
|
|
opt_help.add_connect_options(parser)
|
|
opt_help.add_subset_options(parser)
|
|
opt_help.add_check_options(parser)
|
|
opt_help.add_inventory_options(parser)
|
|
|
|
return parser
|
|
|
|
|
|
@pytest.fixture
|
|
def reset_cli_args():
|
|
co.GlobalCLIArgs._Singleton__instance = None
|
|
yield
|
|
co.GlobalCLIArgs._Singleton__instance = None
|
|
|
|
|
|
def test_play_context(mocker, parser, reset_cli_args):
|
|
(options, args) = parser.parse_args(['-vv', '--check'])
|
|
options.args = args
|
|
context._init_global_context(options)
|
|
play = Play.load({})
|
|
play_context = PlayContext(play=play)
|
|
|
|
# Note: **Must** test the value from _attributes here because play_context.connection will end
|
|
# up calling PlayContext._get_attr_connection() which changes the 'smart' connection type into
|
|
# the best guessed type (and since C.DEFAULT_TRANSPORT starts off as smart, we would then never
|
|
# match)
|
|
assert play_context._attributes['connection'] == C.DEFAULT_TRANSPORT
|
|
assert play_context.remote_addr is None
|
|
assert play_context.remote_user is None
|
|
assert play_context.password == ''
|
|
assert play_context.port is None
|
|
assert play_context.private_key_file == C.DEFAULT_PRIVATE_KEY_FILE
|
|
assert play_context.timeout == C.DEFAULT_TIMEOUT
|
|
assert play_context.shell is None
|
|
assert play_context.verbosity == 2
|
|
assert play_context.check_mode is True
|
|
assert play_context.no_log is None
|
|
|
|
mock_task = mocker.MagicMock()
|
|
mock_task.connection = 'mocktask'
|
|
mock_task.remote_user = 'mocktask'
|
|
mock_task.port = 1234
|
|
mock_task.no_log = True
|
|
mock_task.become = True
|
|
mock_task.become_method = 'mocktask'
|
|
mock_task.become_user = 'mocktaskroot'
|
|
mock_task.become_pass = 'mocktaskpass'
|
|
mock_task._local_action = False
|
|
mock_task.delegate_to = None
|
|
|
|
all_vars = dict(
|
|
ansible_connection='mock_inventory',
|
|
ansible_ssh_port=4321,
|
|
)
|
|
|
|
mock_templar = mocker.MagicMock()
|
|
|
|
play_context = PlayContext()
|
|
play_context = play_context.set_task_and_variable_override(task=mock_task, variables=all_vars, templar=mock_templar)
|
|
|
|
assert play_context.connection == 'mock_inventory'
|
|
assert play_context.remote_user == 'mocktask'
|
|
assert play_context.port == 4321
|
|
assert play_context.no_log is True
|
|
assert play_context.become is True
|
|
assert play_context.become_method == "mocktask"
|
|
assert play_context.become_user == "mocktaskroot"
|
|
assert play_context.become_pass == "mocktaskpass"
|
|
|
|
mock_task.no_log = False
|
|
play_context = play_context.set_task_and_variable_override(task=mock_task, variables=all_vars, templar=mock_templar)
|
|
assert play_context.no_log is False
|
|
|
|
|
|
def test_play_context_make_become_cmd(mocker, parser, reset_cli_args):
|
|
(options, args) = parser.parse_args([])
|
|
options.args = args
|
|
context._init_global_context(options)
|
|
play_context = PlayContext()
|
|
|
|
default_cmd = "/bin/foo"
|
|
default_exe = "/bin/bash"
|
|
sudo_exe = 'sudo'
|
|
sudo_flags = '-H -s -n'
|
|
su_exe = 'su'
|
|
su_flags = ''
|
|
pbrun_exe = 'pbrun'
|
|
pbrun_flags = ''
|
|
pfexec_exe = 'pfexec'
|
|
pfexec_flags = ''
|
|
doas_exe = 'doas'
|
|
doas_flags = '-n'
|
|
ksu_exe = 'ksu'
|
|
ksu_flags = ''
|
|
dzdo_exe = 'dzdo'
|
|
dzdo_flags = ''
|
|
|
|
cmd = play_context.make_become_cmd(cmd=default_cmd, executable=default_exe)
|
|
assert cmd == default_cmd
|
|
|
|
success = 'BECOME-SUCCESS-.+?'
|
|
|
|
play_context.become = True
|
|
play_context.become_user = 'foo'
|
|
play_context.set_become_plugin(become_loader.get('sudo'))
|
|
play_context.become_flags = sudo_flags
|
|
cmd = play_context.make_become_cmd(cmd=default_cmd, executable="/bin/bash")
|
|
|
|
assert (re.match("""%s %s -u %s %s -c 'echo %s; %s'""" % (sudo_exe, sudo_flags, play_context.become_user,
|
|
default_exe, success, default_cmd), cmd) is not None)
|
|
|
|
play_context.become_pass = 'testpass'
|
|
cmd = play_context.make_become_cmd(cmd=default_cmd, executable=default_exe)
|
|
assert (re.match("""%s %s -p "%s" -u %s %s -c 'echo %s; %s'""" % (sudo_exe, sudo_flags.replace('-n', ''),
|
|
r"\[sudo via ansible, key=.+?\] password:", play_context.become_user,
|
|
default_exe, success, default_cmd), cmd) is not None)
|
|
|
|
play_context.become_pass = None
|
|
play_context.set_become_plugin(become_loader.get('su'))
|
|
play_context.become_flags = su_flags
|
|
cmd = play_context.make_become_cmd(cmd=default_cmd, executable="/bin/bash")
|
|
assert (re.match("""%s %s -c '%s -c '"'"'echo %s; %s'"'"''""" % (su_exe, play_context.become_user, default_exe,
|
|
success, default_cmd), cmd) is not None)
|
|
|
|
play_context.set_become_plugin(become_loader.get('pbrun'))
|
|
play_context.become_flags = pbrun_flags
|
|
cmd = play_context.make_become_cmd(cmd=default_cmd, executable="/bin/bash")
|
|
assert re.match("""%s %s -u %s 'echo %s; %s'""" % (pbrun_exe, pbrun_flags, play_context.become_user,
|
|
success, default_cmd), cmd) is not None
|
|
|
|
play_context.set_become_plugin(become_loader.get('pfexec'))
|
|
play_context.become_flags = pfexec_flags
|
|
cmd = play_context.make_become_cmd(cmd=default_cmd, executable="/bin/bash")
|
|
assert re.match('''%s %s "'echo %s; %s'"''' % (pfexec_exe, pfexec_flags, success, default_cmd), cmd) is not None
|
|
|
|
play_context.set_become_plugin(become_loader.get('doas'))
|
|
play_context.become_flags = doas_flags
|
|
cmd = play_context.make_become_cmd(cmd=default_cmd, executable="/bin/bash")
|
|
assert (re.match("""%s %s -u %s %s -c 'echo %s; %s'""" % (doas_exe, doas_flags, play_context.become_user, default_exe, success,
|
|
default_cmd), cmd) is not None)
|
|
|
|
play_context.set_become_plugin(become_loader.get('ksu'))
|
|
play_context.become_flags = ksu_flags
|
|
cmd = play_context.make_become_cmd(cmd=default_cmd, executable="/bin/bash")
|
|
assert (re.match("""%s %s %s -e %s -c 'echo %s; %s'""" % (ksu_exe, play_context.become_user, ksu_flags,
|
|
default_exe, success, default_cmd), cmd) is not None)
|
|
|
|
play_context.set_become_plugin(become_loader.get('bad'))
|
|
with pytest.raises(AnsibleError):
|
|
play_context.make_become_cmd(cmd=default_cmd, executable="/bin/bash")
|
|
|
|
play_context.set_become_plugin(become_loader.get('dzdo'))
|
|
play_context.become_flags = dzdo_flags
|
|
cmd = play_context.make_become_cmd(cmd=default_cmd, executable="/bin/bash")
|
|
assert re.match("""%s %s -u %s %s -c 'echo %s; %s'""" % (dzdo_exe, dzdo_flags, play_context.become_user, default_exe,
|
|
success, default_cmd), cmd) is not None
|
|
play_context.become_pass = 'testpass'
|
|
play_context.set_become_plugin(become_loader.get('dzdo'))
|
|
cmd = play_context.make_become_cmd(cmd=default_cmd, executable="/bin/bash")
|
|
assert re.match("""%s %s -p %s -u %s %s -c 'echo %s; %s'""" % (dzdo_exe, dzdo_flags, r'\"\[dzdo via ansible, key=.+?\] password:\"',
|
|
play_context.become_user, default_exe, success, default_cmd), cmd) is not None
|