1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/plugins
patchback[bot] afc620fc74
Avoid incorrectly marking zfs tasks as changed (#2454) (#2483)
* Avoid incorrectly marking zfs tasks as changed

The zfs module will incorrectly mark certain tasks as having been
changed. For example, if a dataset has a quota of "1G" and the user
changes it to "1024M", the actual quota vale has not changed, but since
the module is doing a simple string comparison between "1G" and "1024M",
it marks the step as "changed".

Instead of trying to handle all the corner cases of zfs (another example
is when the zpool "altroot" property has been set), this change simply
compares the output of "zfs-get" from before and after "zfs-set" is
called

* update changelog format

* Update changelogs/fragments/2454-detect_zfs_changed.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* add note about check_mode

* Update plugins/modules/storage/zfs/zfs.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/storage/zfs/zfs.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* clarify check mode qualifications

* rephrase to avoid hypothetical

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8e7aff00b5)

Co-authored-by: sam-lunt <samuel.j.lunt@gmail.com>
2021-05-10 18:16:49 +02:00
..
action Bump version to 2.0.0 (#1369) 2020-11-26 14:26:36 +01:00
become Make plugins pass validation. (#2414) (#2434) 2021-05-03 14:51:44 +02:00
cache fixed Python 3 keys() usage (#1861) (#1891) 2021-02-24 19:36:37 +01:00
callback Make plugins pass validation. (#2414) (#2434) 2021-05-03 14:51:44 +02:00
connection funcd connection plugin is now usable/loadable (#2235) (#2241) 2021-04-14 10:00:39 +02:00
doc_fragments fixed documentation for oneview modules (#2092) (#2093) 2021-03-24 16:41:03 +01:00
filter Add path_join compatibility shim (#2172) (#2206) 2021-04-08 08:31:35 +02:00
inventory fix stackpath_compute validate_config (#2448) (#2474) 2021-05-09 22:44:39 +02:00
lookup convert string returned by plugin to unicode (#2329) (#2339) 2021-04-24 12:48:02 +02:00
module_utils xenserver_guest - fixed validations (#2243) (#2253) 2021-04-17 09:51:16 +02:00
modules Avoid incorrectly marking zfs tasks as changed (#2454) (#2483) 2021-05-10 18:16:49 +02:00