mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
63df0adc17
* Update RDS parameter group for boto3 * Update to boto3 * Update to latest ansible standards * Remove choices list for valid engines (See #19221 for context) * Allow tagging * Return some useful information, and document that information * Add tests for rds_param_group * Improve testing of rds_param_group * Add purge_tags option for rds_param_group * Fix remaining broken rds_param_group tests * Ensure the group name is lowercased. Fixes integration tests when run on OSX
321 lines
11 KiB
YAML
321 lines
11 KiB
YAML
---
|
|
# A Note about ec2 environment variable name preference:
|
|
# - EC2_URL -> AWS_URL
|
|
# - EC2_ACCESS_KEY -> AWS_ACCESS_KEY_ID -> AWS_ACCESS_KEY
|
|
# - EC2_SECRET_KEY -> AWS_SECRET_ACCESS_KEY -> AWX_SECRET_KEY
|
|
# - EC2_REGION -> AWS_REGION
|
|
#
|
|
# TODO - name: test 'region' parameter
|
|
# TODO - name: test 'state=absent' parameter for existing key
|
|
# TODO - name: test 'state=absent' parameter for missing key
|
|
# TODO - name: test 'validate_certs' parameter
|
|
|
|
# ============================================================
|
|
# - include: ../../setup_ec2/tasks/common.yml module_name=rds_param_group
|
|
|
|
- block:
|
|
|
|
# ============================================================
|
|
- name: test empty parameter group
|
|
rds_param_group:
|
|
name: "{{ rds_param_group.name }}"
|
|
engine: "{{ rds_param_group.engine }}"
|
|
description: "{{ rds_param_group.description }}"
|
|
state: present
|
|
region: "{{ ec2_region }}"
|
|
ec2_access_key: '{{ aws_access_key }}'
|
|
ec2_secret_key: '{{ aws_secret_key }}'
|
|
security_token: '{{ security_token }}'
|
|
register: result
|
|
ignore_errors: true
|
|
|
|
- name: assert rds parameter group changed
|
|
assert:
|
|
that:
|
|
- 'result.changed'
|
|
- "'{{ result.db_parameter_group_name | lower }}' == '{{ rds_param_group.name | lower }}'"
|
|
- 'result.tags == {}'
|
|
|
|
# ============================================================
|
|
- name: test empty parameter group with no arguments changes nothing
|
|
rds_param_group:
|
|
name: "{{ rds_param_group.name }}"
|
|
engine: "{{ rds_param_group.engine }}"
|
|
description: "{{ rds_param_group.description }}"
|
|
state: present
|
|
region: "{{ ec2_region }}"
|
|
ec2_access_key: '{{ aws_access_key }}'
|
|
ec2_secret_key: '{{ aws_secret_key }}'
|
|
security_token: '{{ security_token }}'
|
|
register: result
|
|
ignore_errors: true
|
|
|
|
- name: assert no change when running empty parameter group a second time
|
|
assert:
|
|
that:
|
|
- 'not result.changed'
|
|
|
|
# ============================================================
|
|
- name: test adding numeric tag
|
|
rds_param_group:
|
|
name: "{{ rds_param_group.name }}"
|
|
engine: "{{ rds_param_group.engine }}"
|
|
description: "{{ rds_param_group.description }}"
|
|
state: present
|
|
tags:
|
|
Environment: test
|
|
Test: 123
|
|
region: "{{ ec2_region }}"
|
|
ec2_access_key: '{{ aws_access_key }}'
|
|
ec2_secret_key: '{{ aws_secret_key }}'
|
|
security_token: '{{ security_token }}'
|
|
register: result
|
|
ignore_errors: true
|
|
|
|
- name: adding numeric tag just silently converts
|
|
assert:
|
|
that:
|
|
- 'result.changed'
|
|
- 'result.tags.Test == "123"'
|
|
|
|
# ============================================================
|
|
- name: test tagging existing group
|
|
rds_param_group:
|
|
name: "{{ rds_param_group.name }}"
|
|
engine: "{{ rds_param_group.engine }}"
|
|
description: "{{ rds_param_group.description }}"
|
|
state: present
|
|
tags:
|
|
Environment: test
|
|
Test: "123"
|
|
NewTag: "hello"
|
|
region: "{{ ec2_region }}"
|
|
ec2_access_key: '{{ aws_access_key }}'
|
|
ec2_secret_key: '{{ aws_secret_key }}'
|
|
security_token: '{{ security_token }}'
|
|
register: result
|
|
ignore_errors: true
|
|
|
|
- name: assert tagging existing group changes it and adds tags
|
|
assert:
|
|
that:
|
|
- 'result.changed'
|
|
- 'result.tags.NewTag == "hello"'
|
|
|
|
# ============================================================
|
|
- name: test repeating tagging existing group
|
|
rds_param_group:
|
|
name: "{{ rds_param_group.name }}"
|
|
engine: "{{ rds_param_group.engine }}"
|
|
description: "{{ rds_param_group.description }}"
|
|
state: present
|
|
tags:
|
|
Environment: test
|
|
Test: "123"
|
|
NewTag: "hello"
|
|
region: "{{ ec2_region }}"
|
|
ec2_access_key: '{{ aws_access_key }}'
|
|
ec2_secret_key: '{{ aws_secret_key }}'
|
|
security_token: '{{ security_token }}'
|
|
register: result
|
|
ignore_errors: true
|
|
|
|
- name: assert tagging existing group changes it and adds tags
|
|
assert:
|
|
that:
|
|
- 'not result.changed'
|
|
- 'result.tags.Test == "123"'
|
|
|
|
# ============================================================
|
|
- name: test deleting tags from existing group
|
|
rds_param_group:
|
|
name: "{{ rds_param_group.name }}"
|
|
engine: "{{ rds_param_group.engine }}"
|
|
description: "{{ rds_param_group.description }}"
|
|
state: present
|
|
tags:
|
|
Environment: test
|
|
region: "{{ ec2_region }}"
|
|
ec2_access_key: '{{ aws_access_key }}'
|
|
ec2_secret_key: '{{ aws_secret_key }}'
|
|
security_token: '{{ security_token }}'
|
|
purge_tags: yes
|
|
register: result
|
|
ignore_errors: true
|
|
|
|
- name: assert removing tags from existing group changes it
|
|
assert:
|
|
that:
|
|
- 'result.changed'
|
|
- 'result.tags.Environment == "test"'
|
|
- '"NewTag" not in result.tags'
|
|
|
|
# ============================================================
|
|
- name: test state=absent with engine defined (expect changed=true)
|
|
rds_param_group:
|
|
name: "{{ rds_param_group.name }}"
|
|
engine: "{{ rds_param_group.engine }}"
|
|
state: absent
|
|
region: "{{ ec2_region }}"
|
|
ec2_access_key: '{{ aws_access_key }}'
|
|
ec2_secret_key: '{{ aws_secret_key }}'
|
|
security_token: '{{ security_token }}'
|
|
register: result
|
|
ignore_errors: true
|
|
|
|
- name: assert state=absent with engine defined (expect changed=true)
|
|
assert:
|
|
that:
|
|
- 'result.changed'
|
|
|
|
# ============================================================
|
|
- name: test creating group with parameters
|
|
rds_param_group:
|
|
name: "{{ rds_param_group.name }}"
|
|
engine: "{{ rds_param_group.engine }}"
|
|
description: "{{ rds_param_group.description }}"
|
|
state: present
|
|
params:
|
|
log_directory: /var/log/postgresql
|
|
log_statement: 'all'
|
|
log_duration: on
|
|
this_param_does_not_exist: oh_no
|
|
tags:
|
|
Environment: test
|
|
Test: "123"
|
|
region: "{{ ec2_region }}"
|
|
ec2_access_key: '{{ aws_access_key }}'
|
|
ec2_secret_key: '{{ aws_secret_key }}'
|
|
security_token: '{{ security_token }}'
|
|
register: result
|
|
ignore_errors: true
|
|
|
|
- name: assert creating a new group with parameter changes it
|
|
assert:
|
|
that:
|
|
- 'result.changed'
|
|
- 'result.tags.Test == "123"'
|
|
- 'result.errors|length == 2'
|
|
|
|
# ============================================================
|
|
- name: test repeating group with parameters
|
|
rds_param_group:
|
|
name: "{{ rds_param_group.name }}"
|
|
engine: "{{ rds_param_group.engine }}"
|
|
description: "{{ rds_param_group.description }}"
|
|
state: present
|
|
params:
|
|
log_directory: /var/log/postgresql
|
|
log_statement: 'all'
|
|
log_duration: on
|
|
this_param_does_not_exist: oh_no
|
|
tags:
|
|
Environment: test
|
|
Test: "123"
|
|
region: "{{ ec2_region }}"
|
|
ec2_access_key: '{{ aws_access_key }}'
|
|
ec2_secret_key: '{{ aws_secret_key }}'
|
|
security_token: '{{ security_token }}'
|
|
register: result
|
|
ignore_errors: true
|
|
|
|
- name: assert repeating group with parameters does not change it
|
|
assert:
|
|
that:
|
|
- 'not result.changed'
|
|
- 'result.tags.Test == "123"'
|
|
- 'result.errors|length == 2'
|
|
|
|
# ============================================================
|
|
- name: test state=absent with engine defined (expect changed=true)
|
|
rds_param_group:
|
|
name: "{{ rds_param_group.name }}"
|
|
engine: "{{ rds_param_group.engine }}"
|
|
state: absent
|
|
region: "{{ ec2_region }}"
|
|
ec2_access_key: '{{ aws_access_key }}'
|
|
ec2_secret_key: '{{ aws_secret_key }}'
|
|
security_token: '{{ security_token }}'
|
|
register: result
|
|
ignore_errors: true
|
|
|
|
- name: assert state=absent with engine defined (expect changed=true)
|
|
assert:
|
|
that:
|
|
- 'result.changed'
|
|
|
|
# ============================================================
|
|
- name: test repeating state=absent (expect changed=false)
|
|
rds_param_group:
|
|
name: "{{ rds_param_group.name }}"
|
|
engine: "{{ rds_param_group.engine }}"
|
|
state: absent
|
|
region: "{{ ec2_region }}"
|
|
ec2_access_key: '{{ aws_access_key }}'
|
|
ec2_secret_key: '{{ aws_secret_key }}'
|
|
security_token: '{{ security_token }}'
|
|
register: result
|
|
ignore_errors: true
|
|
|
|
- name: assert repeating state=absent (expect changed=false)
|
|
assert:
|
|
that:
|
|
- 'not result.changed'
|
|
|
|
# ============================================================
|
|
- name: test creating group with more than 20 parameters
|
|
rds_param_group:
|
|
name: "{{ rds_param_group.name }}"
|
|
engine: "{{ rds_param_group.engine }}"
|
|
description: "{{ rds_param_group.description }}"
|
|
params: "{{ rds_long_param_list }}"
|
|
state: present
|
|
region: "{{ ec2_region }}"
|
|
ec2_access_key: '{{ aws_access_key }}'
|
|
ec2_secret_key: '{{ aws_secret_key }}'
|
|
security_token: '{{ security_token }}'
|
|
register: result
|
|
ignore_errors: true
|
|
|
|
- name: assert creating a new group with lots of parameter changes it
|
|
assert:
|
|
that:
|
|
- 'result.changed'
|
|
|
|
# ============================================================
|
|
- name: test creating group with more than 20 parameters
|
|
rds_param_group:
|
|
name: "{{ rds_param_group.name }}"
|
|
engine: "{{ rds_param_group.engine }}"
|
|
description: "{{ rds_param_group.description }}"
|
|
params: "{{ rds_long_param_list }}"
|
|
region: "{{ ec2_region }}"
|
|
state: present
|
|
ec2_access_key: '{{ aws_access_key }}'
|
|
ec2_secret_key: '{{ aws_secret_key }}'
|
|
security_token: '{{ security_token }}'
|
|
register: result
|
|
ignore_errors: true
|
|
|
|
- name: assert repeating a group with lots of parameter does not change it
|
|
assert:
|
|
that:
|
|
- 'not result.changed'
|
|
|
|
always:
|
|
# ============================================================
|
|
- name: test state=absent (expect changed=false)
|
|
rds_param_group:
|
|
name: "{{ rds_param_group.name }}"
|
|
state: absent
|
|
region: "{{ ec2_region }}"
|
|
ec2_access_key: '{{ aws_access_key }}'
|
|
ec2_secret_key: '{{ aws_secret_key }}'
|
|
security_token: '{{ security_token }}'
|
|
register: result
|
|
ignore_errors: true
|
|
|
|
- name: assert state=absent (expect changed=false)
|
|
assert:
|
|
that:
|
|
- 'result.changed'
|