#!/usr/bin/python # -*- coding: utf-8 -*- # Copyright: (c) 2013, Adam Miller # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt) from __future__ import absolute_import, division, print_function __metaclass__ = type DOCUMENTATION = r''' --- module: firewalld short_description: Manage arbitrary ports/services with firewalld description: - This module allows for addition or deletion of services and ports (either TCP or UDP) in either running or permanent firewalld rules. options: service: description: - Name of a service to add/remove to/from firewalld. - The service must be listed in output of firewall-cmd --get-services. type: str port: description: - Name of a port or port range to add/remove to/from firewalld. - Must be in the form PORT/PROTOCOL or PORT-PORT/PROTOCOL for port ranges. type: str rich_rule: description: - Rich rule to add/remove to/from firewalld. type: str source: description: - The source/network you would like to add/remove to/from firewalld. type: str interface: description: - The interface you would like to add/remove to/from a zone in firewalld. type: str icmp_block: description: - The ICMP block you would like to add/remove to/from a zone in firewalld. type: str icmp_block_inversion: description: - Enable/Disable inversion of ICMP blocks for a zone in firewalld. type: str zone: description: - The firewalld zone to add/remove to/from. - Note that the default zone can be configured per system but C(public) is default from upstream. - Available choices can be extended based on per-system configs, listed here are "out of the box" defaults. - Possible values include C(block), C(dmz), C(drop), C(external), C(home), C(internal), C(public), C(trusted), C(work). type: str permanent: description: - Should this configuration be in the running firewalld configuration or persist across reboots. - As of Ansible 2.3, permanent operations can operate on firewalld configs when it is not running (requires firewalld >= 3.0.9). - Note that if this is C(no), immediate is assumed C(yes). type: bool immediate: description: - Should this configuration be applied immediately, if set as permanent. type: bool default: no state: description: - Enable or disable a setting. - 'For ports: Should this port accept (enabled) or reject (disabled) connections.' - The states C(present) and C(absent) can only be used in zone level operations (i.e. when no other parameters but zone and state are set). type: str required: true choices: [ absent, disabled, enabled, present ] timeout: description: - The amount of time the rule should be in effect for when non-permanent. type: int default: 0 masquerade: description: - The masquerade setting you would like to enable/disable to/from zones within firewalld. type: str offline: description: - Whether to run this module even when firewalld is offline. type: bool target: description: - firewalld Zone target - If state is set to C(absent), this will reset the target to default choices: [ default, ACCEPT, DROP, REJECT ] type: str version_added: 0.2.0 notes: - Not tested on any Debian based system. - Requires the python2 bindings of firewalld, which may not be installed by default. - For distributions where the python2 firewalld bindings are unavailable (e.g Fedora 28 and later) you will have to set the ansible_python_interpreter for these hosts to the python3 interpreter path and install the python3 bindings. - Zone transactions (creating, deleting) can be performed by using only the zone and state parameters "present" or "absent". Note that zone transactions must explicitly be permanent. This is a limitation in firewalld. This also means that you will have to reload firewalld after adding a zone that you wish to perform immediate actions on. The module will not take care of this for you implicitly because that would undo any previously performed immediate actions which were not permanent. Therefore, if you require immediate access to a newly created zone it is recommended you reload firewalld immediately after the zone creation returns with a changed state and before you perform any other immediate, non-permanent actions on that zone. requirements: - firewalld >= 0.2.11 author: - Adam Miller (@maxamillion) ''' EXAMPLES = r''' - community.general.firewalld: service: https permanent: yes state: enabled - community.general.firewalld: port: 8081/tcp permanent: yes state: disabled - community.general.firewalld: port: 161-162/udp permanent: yes state: enabled - community.general.firewalld: zone: dmz service: http permanent: yes state: enabled - community.general.firewalld: rich_rule: rule service name="ftp" audit limit value="1/m" accept permanent: yes state: enabled - community.general.firewalld: source: 192.0.2.0/24 zone: internal state: enabled - community.general.firewalld: zone: trusted interface: eth2 permanent: yes state: enabled - community.general.firewalld: masquerade: yes state: enabled permanent: yes zone: dmz - community.general.firewalld: zone: custom state: present permanent: yes - community.general.firewalld: zone: drop state: enabled permanent: yes icmp_block_inversion: yes - community.general.firewalld: zone: drop state: enabled permanent: yes icmp_block: echo-request - community.general.firewalld: zone: internal state: present permanent: yes target: ACCEPT - name: Redirect port 443 to 8443 with Rich Rule community.general.firewalld: rich_rule: rule family=ipv4 forward-port port=443 protocol=tcp to-port=8443 zone: public permanent: yes immediate: yes state: enabled ''' from ansible.module_utils.basic import AnsibleModule from ansible_collections.community.general.plugins.module_utils.firewalld import FirewallTransaction, fw_offline try: from firewall.client import Rich_Rule from firewall.client import FirewallClientZoneSettings except ImportError: # The import errors are handled via FirewallTransaction, don't need to # duplicate that here pass class IcmpBlockTransaction(FirewallTransaction): """ IcmpBlockTransaction """ def __init__(self, module, action_args=None, zone=None, desired_state=None, permanent=False, immediate=False): super(IcmpBlockTransaction, self).__init__( module, action_args=action_args, desired_state=desired_state, zone=zone, permanent=permanent, immediate=immediate ) def get_enabled_immediate(self, icmp_block, timeout): return icmp_block in self.fw.getIcmpBlocks(self.zone) def get_enabled_permanent(self, icmp_block, timeout): fw_zone, fw_settings = self.get_fw_zone_settings() return icmp_block in fw_settings.getIcmpBlocks() def set_enabled_immediate(self, icmp_block, timeout): self.fw.addIcmpBlock(self.zone, icmp_block, timeout) def set_enabled_permanent(self, icmp_block, timeout): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.addIcmpBlock(icmp_block) self.update_fw_settings(fw_zone, fw_settings) def set_disabled_immediate(self, icmp_block, timeout): self.fw.removeIcmpBlock(self.zone, icmp_block) def set_disabled_permanent(self, icmp_block, timeout): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.removeIcmpBlock(icmp_block) self.update_fw_settings(fw_zone, fw_settings) class IcmpBlockInversionTransaction(FirewallTransaction): """ IcmpBlockInversionTransaction """ def __init__(self, module, action_args=None, zone=None, desired_state=None, permanent=False, immediate=False): super(IcmpBlockInversionTransaction, self).__init__( module, action_args=action_args, desired_state=desired_state, zone=zone, permanent=permanent, immediate=immediate ) def get_enabled_immediate(self): if self.fw.queryIcmpBlockInversion(self.zone) is True: return True else: return False def get_enabled_permanent(self): fw_zone, fw_settings = self.get_fw_zone_settings() if fw_settings.getIcmpBlockInversion() is True: return True else: return False def set_enabled_immediate(self): self.fw.addIcmpBlockInversion(self.zone) def set_enabled_permanent(self): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.setIcmpBlockInversion(True) self.update_fw_settings(fw_zone, fw_settings) def set_disabled_immediate(self): self.fw.removeIcmpBlockInversion(self.zone) def set_disabled_permanent(self): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.setIcmpBlockInversion(False) self.update_fw_settings(fw_zone, fw_settings) class ServiceTransaction(FirewallTransaction): """ ServiceTransaction """ def __init__(self, module, action_args=None, zone=None, desired_state=None, permanent=False, immediate=False): super(ServiceTransaction, self).__init__( module, action_args=action_args, desired_state=desired_state, zone=zone, permanent=permanent, immediate=immediate ) def get_enabled_immediate(self, service, timeout): if service in self.fw.getServices(self.zone): return True else: return False def get_enabled_permanent(self, service, timeout): fw_zone, fw_settings = self.get_fw_zone_settings() if service in fw_settings.getServices(): return True else: return False def set_enabled_immediate(self, service, timeout): self.fw.addService(self.zone, service, timeout) def set_enabled_permanent(self, service, timeout): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.addService(service) self.update_fw_settings(fw_zone, fw_settings) def set_disabled_immediate(self, service, timeout): self.fw.removeService(self.zone, service) def set_disabled_permanent(self, service, timeout): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.removeService(service) self.update_fw_settings(fw_zone, fw_settings) class MasqueradeTransaction(FirewallTransaction): """ MasqueradeTransaction """ def __init__(self, module, action_args=None, zone=None, desired_state=None, permanent=False, immediate=False): super(MasqueradeTransaction, self).__init__( module, action_args=action_args, desired_state=desired_state, zone=zone, permanent=permanent, immediate=immediate ) self.enabled_msg = "Added masquerade to zone %s" % self.zone self.disabled_msg = "Removed masquerade from zone %s" % self.zone def get_enabled_immediate(self): if self.fw.queryMasquerade(self.zone) is True: return True else: return False def get_enabled_permanent(self): fw_zone, fw_settings = self.get_fw_zone_settings() if fw_settings.getMasquerade() is True: return True else: return False def set_enabled_immediate(self): self.fw.addMasquerade(self.zone) def set_enabled_permanent(self): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.setMasquerade(True) self.update_fw_settings(fw_zone, fw_settings) def set_disabled_immediate(self): self.fw.removeMasquerade(self.zone) def set_disabled_permanent(self): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.setMasquerade(False) self.update_fw_settings(fw_zone, fw_settings) class PortTransaction(FirewallTransaction): """ PortTransaction """ def __init__(self, module, action_args=None, zone=None, desired_state=None, permanent=False, immediate=False): super(PortTransaction, self).__init__( module, action_args=action_args, desired_state=desired_state, zone=zone, permanent=permanent, immediate=immediate ) def get_enabled_immediate(self, port, protocol, timeout): port_proto = [port, protocol] if self.fw_offline: fw_zone, fw_settings = self.get_fw_zone_settings() ports_list = fw_settings.getPorts() else: ports_list = self.fw.getPorts(self.zone) if port_proto in ports_list: return True else: return False def get_enabled_permanent(self, port, protocol, timeout): port_proto = (port, protocol) fw_zone, fw_settings = self.get_fw_zone_settings() if port_proto in fw_settings.getPorts(): return True else: return False def set_enabled_immediate(self, port, protocol, timeout): self.fw.addPort(self.zone, port, protocol, timeout) def set_enabled_permanent(self, port, protocol, timeout): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.addPort(port, protocol) self.update_fw_settings(fw_zone, fw_settings) def set_disabled_immediate(self, port, protocol, timeout): self.fw.removePort(self.zone, port, protocol) def set_disabled_permanent(self, port, protocol, timeout): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.removePort(port, protocol) self.update_fw_settings(fw_zone, fw_settings) class InterfaceTransaction(FirewallTransaction): """ InterfaceTransaction """ def __init__(self, module, action_args=None, zone=None, desired_state=None, permanent=False, immediate=False): super(InterfaceTransaction, self).__init__( module, action_args=action_args, desired_state=desired_state, zone=zone, permanent=permanent, immediate=immediate ) self.enabled_msg = "Changed %s to zone %s" % \ (self.action_args[0], self.zone) self.disabled_msg = "Removed %s from zone %s" % \ (self.action_args[0], self.zone) def get_enabled_immediate(self, interface): if self.fw_offline: fw_zone, fw_settings = self.get_fw_zone_settings() interface_list = fw_settings.getInterfaces() else: interface_list = self.fw.getInterfaces(self.zone) if interface in interface_list: return True else: return False def get_enabled_permanent(self, interface): fw_zone, fw_settings = self.get_fw_zone_settings() if interface in fw_settings.getInterfaces(): return True else: return False def set_enabled_immediate(self, interface): self.fw.changeZoneOfInterface(self.zone, interface) def set_enabled_permanent(self, interface): fw_zone, fw_settings = self.get_fw_zone_settings() if self.fw_offline: iface_zone_objs = [] for zone in self.fw.config.get_zones(): old_zone_obj = self.fw.config.get_zone(zone) if interface in old_zone_obj.interfaces: iface_zone_objs.append(old_zone_obj) if len(iface_zone_objs) > 1: # Even it shouldn't happen, it's actually possible that # the same interface is in several zone XML files self.module.fail_json( msg='ERROR: interface {0} is in {1} zone XML file, can only be in one'.format( interface, len(iface_zone_objs) ) ) old_zone_obj = iface_zone_objs[0] if old_zone_obj.name != self.zone: old_zone_settings = FirewallClientZoneSettings( self.fw.config.get_zone_config(old_zone_obj) ) old_zone_settings.removeInterface(interface) # remove from old self.fw.config.set_zone_config( old_zone_obj, old_zone_settings.settings ) fw_settings.addInterface(interface) # add to new self.fw.config.set_zone_config(fw_zone, fw_settings.settings) else: old_zone_name = self.fw.config().getZoneOfInterface(interface) if old_zone_name != self.zone: if old_zone_name: old_zone_obj = self.fw.config().getZoneByName(old_zone_name) old_zone_settings = old_zone_obj.getSettings() old_zone_settings.removeInterface(interface) # remove from old old_zone_obj.update(old_zone_settings) fw_settings.addInterface(interface) # add to new fw_zone.update(fw_settings) def set_disabled_immediate(self, interface): self.fw.removeInterface(self.zone, interface) def set_disabled_permanent(self, interface): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.removeInterface(interface) self.update_fw_settings(fw_zone, fw_settings) class RichRuleTransaction(FirewallTransaction): """ RichRuleTransaction """ def __init__(self, module, action_args=None, zone=None, desired_state=None, permanent=False, immediate=False): super(RichRuleTransaction, self).__init__( module, action_args=action_args, desired_state=desired_state, zone=zone, permanent=permanent, immediate=immediate ) def get_enabled_immediate(self, rule, timeout): # Convert the rule string to standard format # before checking whether it is present rule = str(Rich_Rule(rule_str=rule)) if rule in self.fw.getRichRules(self.zone): return True else: return False def get_enabled_permanent(self, rule, timeout): fw_zone, fw_settings = self.get_fw_zone_settings() # Convert the rule string to standard format # before checking whether it is present rule = str(Rich_Rule(rule_str=rule)) if rule in fw_settings.getRichRules(): return True else: return False def set_enabled_immediate(self, rule, timeout): self.fw.addRichRule(self.zone, rule, timeout) def set_enabled_permanent(self, rule, timeout): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.addRichRule(rule) self.update_fw_settings(fw_zone, fw_settings) def set_disabled_immediate(self, rule, timeout): self.fw.removeRichRule(self.zone, rule) def set_disabled_permanent(self, rule, timeout): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.removeRichRule(rule) self.update_fw_settings(fw_zone, fw_settings) class SourceTransaction(FirewallTransaction): """ SourceTransaction """ def __init__(self, module, action_args=None, zone=None, desired_state=None, permanent=False, immediate=False): super(SourceTransaction, self).__init__( module, action_args=action_args, desired_state=desired_state, zone=zone, permanent=permanent, immediate=immediate ) self.enabled_msg = "Added %s to zone %s" % \ (self.action_args[0], self.zone) self.disabled_msg = "Removed %s from zone %s" % \ (self.action_args[0], self.zone) def get_enabled_immediate(self, source): if source in self.fw.getSources(self.zone): return True else: return False def get_enabled_permanent(self, source): fw_zone, fw_settings = self.get_fw_zone_settings() if source in fw_settings.getSources(): return True else: return False def set_enabled_immediate(self, source): self.fw.addSource(self.zone, source) def set_enabled_permanent(self, source): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.addSource(source) self.update_fw_settings(fw_zone, fw_settings) def set_disabled_immediate(self, source): self.fw.removeSource(self.zone, source) def set_disabled_permanent(self, source): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.removeSource(source) self.update_fw_settings(fw_zone, fw_settings) class ZoneTargetTransaction(FirewallTransaction): """ ZoneTargetTransaction """ def __init__(self, module, action_args=None, zone=None, desired_state=None, permanent=True, immediate=False, enabled_values=None, disabled_values=None): super(ZoneTargetTransaction, self).__init__( module, action_args=action_args, desired_state=desired_state, zone=zone, permanent=permanent, immediate=immediate, enabled_values=enabled_values or ["present", "enabled"], disabled_values=disabled_values or ["absent", "disabled"]) self.enabled_msg = "Set zone %s target to %s" % \ (self.zone, action_args[0]) self.disabled_msg = "Reset zone %s target to default" % \ (self.zone) self.tx_not_permanent_error_msg = "Zone operations must be permanent. " \ "Make sure you didn't set the 'permanent' flag to 'false' or the 'immediate' flag to 'true'." def get_enabled_immediate(self, target): self.module.fail_json(msg=self.tx_not_permanent_error_msg) def get_enabled_permanent(self, target): fw_zone, fw_settings = self.get_fw_zone_settings() current_target = fw_settings.getTarget() return (current_target == target) def set_enabled_immediate(self, target): self.module.fail_json(msg=self.tx_not_permanent_error_msg) def set_enabled_permanent(self, target): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.setTarget(target) self.update_fw_settings(fw_zone, fw_settings) def set_disabled_immediate(self, target): self.module.fail_json(msg=self.tx_not_permanent_error_msg) def set_disabled_permanent(self, target): fw_zone, fw_settings = self.get_fw_zone_settings() fw_settings.setTarget("default") self.update_fw_settings(fw_zone, fw_settings) class ZoneTransaction(FirewallTransaction): """ ZoneTransaction """ def __init__(self, module, action_args=None, zone=None, desired_state=None, permanent=True, immediate=False, enabled_values=None, disabled_values=None): super(ZoneTransaction, self).__init__( module, action_args=action_args, desired_state=desired_state, zone=zone, permanent=permanent, immediate=immediate, enabled_values=enabled_values or ["present"], disabled_values=disabled_values or ["absent"]) self.enabled_msg = "Added zone %s" % \ (self.zone) self.disabled_msg = "Removed zone %s" % \ (self.zone) self.tx_not_permanent_error_msg = "Zone operations must be permanent. " \ "Make sure you didn't set the 'permanent' flag to 'false' or the 'immediate' flag to 'true'." def get_enabled_immediate(self): self.module.fail_json(msg=self.tx_not_permanent_error_msg) def get_enabled_permanent(self): zones = self.fw.config().listZones() zone_names = [self.fw.config().getZone(z).get_property("name") for z in zones] if self.zone in zone_names: return True else: return False def set_enabled_immediate(self): self.module.fail_json(msg=self.tx_not_permanent_error_msg) def set_enabled_permanent(self): self.fw.config().addZone(self.zone, FirewallClientZoneSettings()) def set_disabled_immediate(self): self.module.fail_json(msg=self.tx_not_permanent_error_msg) def set_disabled_permanent(self): zone_obj = self.fw.config().getZoneByName(self.zone) zone_obj.remove() def main(): module = AnsibleModule( argument_spec=dict( icmp_block=dict(type='str'), icmp_block_inversion=dict(type='str'), service=dict(type='str'), port=dict(type='str'), rich_rule=dict(type='str'), zone=dict(type='str'), immediate=dict(type='bool', default=False), source=dict(type='str'), permanent=dict(type='bool'), state=dict(type='str', required=True, choices=['absent', 'disabled', 'enabled', 'present']), timeout=dict(type='int', default=0), interface=dict(type='str'), masquerade=dict(type='str'), offline=dict(type='bool'), target=dict(type='str', required=False, choices=['default', 'ACCEPT', 'DROP', 'REJECT']), ), supports_check_mode=True, required_by=dict( interface=('zone',), target=('zone',), source=('permanent',), ), ) permanent = module.params['permanent'] desired_state = module.params['state'] immediate = module.params['immediate'] timeout = module.params['timeout'] interface = module.params['interface'] masquerade = module.params['masquerade'] # Sanity checks FirewallTransaction.sanity_check(module) # If neither permanent or immediate is provided, assume immediate (as # written in the module's docs) if not permanent and not immediate: immediate = True # Verify required params are provided if immediate and fw_offline: module.fail_json(msg='firewall is not currently running, unable to perform immediate actions without a running firewall daemon') changed = False msgs = [] icmp_block = module.params['icmp_block'] icmp_block_inversion = module.params['icmp_block_inversion'] service = module.params['service'] rich_rule = module.params['rich_rule'] source = module.params['source'] zone = module.params['zone'] target = module.params['target'] if module.params['port'] is not None: if '/' in module.params['port']: port, protocol = module.params['port'].strip().split('/') else: protocol = None if not protocol: module.fail_json(msg='improper port format (missing protocol?)') else: port = None modification_count = 0 if icmp_block is not None: modification_count += 1 if icmp_block_inversion is not None: modification_count += 1 if service is not None: modification_count += 1 if port is not None: modification_count += 1 if rich_rule is not None: modification_count += 1 if interface is not None: modification_count += 1 if masquerade is not None: modification_count += 1 if source is not None: modification_count += 1 if target is not None: modification_count += 1 if modification_count > 1: module.fail_json( msg='can only operate on port, service, rich_rule, masquerade, icmp_block, icmp_block_inversion, interface or source at once' ) elif (modification_count > 0) and (desired_state in ['absent', 'present']) and (target is None): module.fail_json( msg='absent and present state can only be used in zone level operations' ) if icmp_block is not None: transaction = IcmpBlockTransaction( module, action_args=(icmp_block, timeout), zone=zone, desired_state=desired_state, permanent=permanent, immediate=immediate, ) changed, transaction_msgs = transaction.run() msgs = msgs + transaction_msgs if changed is True: msgs.append("Changed icmp-block %s to %s" % (icmp_block, desired_state)) if icmp_block_inversion is not None: transaction = IcmpBlockInversionTransaction( module, action_args=(), zone=zone, desired_state=desired_state, permanent=permanent, immediate=immediate, ) changed, transaction_msgs = transaction.run() msgs = msgs + transaction_msgs if changed is True: msgs.append("Changed icmp-block-inversion %s to %s" % (icmp_block_inversion, desired_state)) if service is not None: transaction = ServiceTransaction( module, action_args=(service, timeout), zone=zone, desired_state=desired_state, permanent=permanent, immediate=immediate, ) changed, transaction_msgs = transaction.run() msgs = msgs + transaction_msgs if changed is True: msgs.append("Changed service %s to %s" % (service, desired_state)) if source is not None: transaction = SourceTransaction( module, action_args=(source,), zone=zone, desired_state=desired_state, permanent=permanent, immediate=immediate, ) changed, transaction_msgs = transaction.run() msgs = msgs + transaction_msgs if port is not None: transaction = PortTransaction( module, action_args=(port, protocol, timeout), zone=zone, desired_state=desired_state, permanent=permanent, immediate=immediate, ) changed, transaction_msgs = transaction.run() msgs = msgs + transaction_msgs if changed is True: msgs.append( "Changed port %s to %s" % ( "%s/%s" % (port, protocol), desired_state ) ) if rich_rule is not None: transaction = RichRuleTransaction( module, action_args=(rich_rule, timeout), zone=zone, desired_state=desired_state, permanent=permanent, immediate=immediate, ) changed, transaction_msgs = transaction.run() msgs = msgs + transaction_msgs if changed is True: msgs.append("Changed rich_rule %s to %s" % (rich_rule, desired_state)) if interface is not None: transaction = InterfaceTransaction( module, action_args=(interface,), zone=zone, desired_state=desired_state, permanent=permanent, immediate=immediate, ) changed, transaction_msgs = transaction.run() msgs = msgs + transaction_msgs if masquerade is not None: transaction = MasqueradeTransaction( module, action_args=(), zone=zone, desired_state=desired_state, permanent=permanent, immediate=immediate, ) changed, transaction_msgs = transaction.run() msgs = msgs + transaction_msgs if target is not None: transaction = ZoneTargetTransaction( module, action_args=(target,), zone=zone, desired_state=desired_state, permanent=permanent, immediate=immediate, ) changed, transaction_msgs = transaction.run() msgs = msgs + transaction_msgs ''' If there are no changes within the zone we are operating on the zone itself ''' if modification_count == 0 and desired_state in ['absent', 'present']: transaction = ZoneTransaction( module, action_args=(), zone=zone, desired_state=desired_state, permanent=permanent, immediate=immediate, ) changed, transaction_msgs = transaction.run() msgs = msgs + transaction_msgs if changed is True: msgs.append("Changed zone %s to %s" % (zone, desired_state)) if fw_offline: msgs.append("(offline operation: only on-disk configs were altered)") module.exit_json(changed=changed, msg=', '.join(msgs)) if __name__ == '__main__': main()