Deepak Agrawal
a1026dbce5
Eos :do not push config to device if check_mode is enabled ( #37287 )
...
* eos can not check config without config session support
* add testcase for check_mode without config session
* fix eos eapi to read use_session env var
2018-03-13 17:13:23 +05:30
saichint
dc61f4c6b1
Fix nxos_vrf issues ( #37092 )
...
* fix nxos_vrf issues
* fix doc
2018-03-13 17:08:37 +05:30
Trishna Guha
ba5e562c76
Fix nxos_l2_interface and test typo ( #37336 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-13 13:36:38 +05:30
Mike Wiebe
ff57fd0bb4
Fix nxos_switchport ( #37328 )
2018-03-13 12:03:05 +05:30
Julien Vey
099d8f0b56
route53_zone: enable check mode ( #37201 )
2018-03-12 14:43:43 -04:00
Ganesh Nalawade
c1008d693c
Fix eos_facts eapi integration test failures ( #37301 )
2018-03-12 20:12:44 +05:30
Sebastian Gumprich
16c564c4b4
fix spelling mistakes in several modules ( #36296 )
...
* fix more spelling mistakes
* fix spelling mistakes
2018-03-12 11:00:19 +01:00
Matt Clay
11ad559010
Terminate Tower instances after CI ends. ( #37265 )
...
* Remove obsolete Tower support from manage_ci.
* Add missing remote settings to cloud tests.
2018-03-09 16:17:29 -08:00
Matt Martz
8980d275a0
Support recursive suboptions schema ( #37206 )
...
* Support recursive suboptions schema
* Remove todo line, add voluptuous version constraint
2018-03-09 17:09:58 -06:00
Matt Clay
5688d2243c
Update support for Tower testing.
...
This is required for compatibility with the latest
version of ansible-core-ci, which now handles more
of the Tower instance setup.
2018-03-09 14:42:49 -08:00
mikedlr
c2a063a5c0
aws ssm parameter lookup - testing and documentation around negative and failure cases ( #36550 )
2018-03-09 12:30:33 -05:00
David Newswanger
5e827f4cc4
added nxos_smoke tests ( #36647 )
...
* added nxos_smoke tests
* add connection information, check length of output
* updated name of task
2018-03-09 09:03:33 -05:00
Ganesh Nalawade
b440544e73
eos_config module exit session gracefully ( #37244 )
...
Fixes #36979
If `abort` is not issued in the top level session prompt
the existing session goes to pending state.
The fix is to come out of config mode by issuing `end` command
and again to same config session and execute `abort` which
`abort` is issued at the top level session prompt.
2018-03-09 19:24:23 +05:30
Trishna Guha
2501834c42
add nxos_snapshot test for missing required param ( #37248 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-09 17:47:14 +05:30
Dylan Murray
90943a3362
Add APB role_type to ansible-galaxy init ( #36789 )
...
* Add APB role_type to ansible-galaxy init
* Add handlers scaffolding
* Fix shippable errors by setting default
* Add unit tests and fix shippable
* Updates init description
2018-03-09 06:50:17 -05:00
saichint
74e79d9f5e
fix nxos_vrf_af issues ( #37211 )
2018-03-09 12:20:27 +05:30
Abhijeet Kasurde
c25a42bef6
VMware: New module : vmware_datastore_cluster ( #36365 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-03-08 23:44:15 -05:00
Jordan Borean
708869edd6
win: handle non string as an environment value ( #37215 )
...
* win: handle non string as an environment value
* Changed powershell environment handler to use .net function instead for special chars
2018-03-09 08:02:54 +10:00
René Moser
0130490faa
cs_instance: fix py3 user_data base64 ( #37135 )
...
* cs_instance: tests: reproduce py3 user_data base64 issue
* cs_instance: fix base64 encoding with py3
2018-03-08 17:05:57 +01:00
Trishna Guha
02999b77a4
fix nxos_switchport/l2_interface trunk_vlans state absent ( #37180 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-08 18:10:04 +05:30
Jordan Borean
c1f5e11cdf
win_uri: return response info on non 200 responses, convert DateTime values to ISO 8601 ( #37104 )
2018-03-08 09:43:42 +10:00
Matt Clay
b4bf502268
Initial Tower module integration test support.
2018-03-07 14:21:55 -08:00
Matt Clay
b9b8081a87
Cleanup and enhancements for ansible-test. ( #37142 )
...
* Fix type hint typos.
* Add one-time cloud env setup after delegation.
* Add generate_password to util.
* Add username/password support to HttpClient.
* Avoid pip requirement for ansible-test shell.
* Support provisioning Tower instances.
2018-03-07 14:02:31 -08:00
Julien Vey
7c07877b1b
s3_bucket: add integration tests ( #36941 )
...
Also update testing-policies/storage
2018-03-07 11:25:24 -05:00
Julien Vey
51d491f8f0
route53_zone: move to boto3, and enable comment update ( #36641 )
2018-03-07 11:16:04 -05:00
Pilou
bc6b96d42e
webfaction modules: fix broken import ( #35024 )
...
* webfaction_app: fix broken import
* doc: use formatting functions
* webaction_db: fix broken import
* webfaction_domain: fix broken import
* webfaction_mailbox: fix broken import
* webaction_site: fix broken import
* webfaction modules: fix doc
2018-03-07 06:22:06 -08:00
Will Thames
a7371d4998
Having uppercase in the resource_prefix can cause unexpected issues
...
We may as well enforce lower case resource prefixes at source
2018-03-07 06:09:50 -08:00
René Moser
e1297af18a
cs_router: fix missing doc ( #37107 )
...
* cs_router: fix missing doc
* update ignore.txt
2018-03-07 13:34:39 +00:00
René Moser
67d8c8f5c6
cs_ip_address.py: fix missing doc ( #37109 )
...
* cs_ip_address.py: fix missing doc
* update ignore.txt
2018-03-07 13:15:39 +00:00
René Moser
2559e832df
cloudstack: fix common E324 in docs ( #37082 )
...
Notes about precedence of common args.
Partly fixes E324.
2018-03-07 11:09:08 +01:00
rahushen
b7bc61c7df
fix nxos_l2_interface tests for fretta ( #37086 )
2018-03-07 10:15:56 +05:30
Adam Miller
3fd5b0740e
allow ANSIBLE_KEEP_REMOTE_FILES for local test runner ( #33357 )
...
* allow ANSIBLE_KEEP_REMOTE_FILES for local test runner
* add ANSIBLE_KEEP_REMOTE_FILES to tox.ini, update docs
* Clarify handling of environment variables.
2018-03-06 16:28:06 -08:00
Nathaniel Case
efb8b539c1
Don't fail on configure in command ( #37011 )
...
* Don't fail on configure in command
* Change test to check mode
2018-03-06 18:10:09 -05:00
René Moser
4705edd1a7
letsencrypt: add new param force ( #37077 )
...
* letsencrypt: add new param force to ignore remaining days
* letsencrypt: fix E325
2018-03-06 20:51:24 +01:00
saichint
4ed0e5072d
fix nxos_vrrp issues ( #36930 )
2018-03-06 13:36:50 +05:30
Ganesh Nalawade
ba3201cd2f
Fix eos integration test failures ( #37020 )
...
Fixes #36919
Fix other eos modules integration test failure in dci
2018-03-06 10:04:40 +05:30
msven
a2b3120e85
ec2_asg: fix #28087 and #35993 ( #36679 )
...
Fixes #35993 - Changes to update_size in commit eb4cc31Fixes #28087 - Make replace_all_instances and replace_instances behave
exactly the same by setting replace_instances = current list of instances
when replace_all_instances used. Root cause of issue was that without lc_check
terminate_batch will terminate all instances passed to it and after updating
the asg size we were querying the asg again for the list of instances - so terminate batch
saw the list including new ones just spun up.
When creating new asg with replace_all_instances: yes and lc_check: false
the instances that are initially created are then subsequently replaced.
This change makes it so replace only occurs if the asg already existed.
Add integration tests for #28087 and #35993 .
2018-03-05 11:47:31 -05:00
Guillaume Coré
daeec920b0
ini_file: add allow_no_value param ( #24442 )
2018-03-05 17:05:41 +01:00
Mikhail Naletov
7d0e1f92f4
[terraform] Support initializing modules and providers at runtime ( #36996 )
...
* Fixes #36994
Added function for force initializing modules and providers
Added type for force_init parameter
2018-03-05 11:01:53 -05:00
Nathaniel Case
7016b3b9ca
ios_static_route idempotence fix ( #35912 )
...
* Remove default admin_distance and fix the idempotence thereof
Fixes #33290
* Fix tests and use yaml anchors to shorten tests
* Add test for undefined admin_distance
* Read config from `show run` if `show ip static route` fails
* Restore flags to ios.get_config & use get_config where appropriate
2018-03-05 09:28:37 -05:00
René Moser
6578403288
cs_zone_facts: implement return facts as ansible returns ( #36993 )
2018-03-05 11:42:38 +01:00
Abhijeet Kasurde
d1eb4fe58c
VMware: Refactor vmware_target_canonical_facts ( #36964 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-03-04 10:20:47 +05:30
Abhijeet Kasurde
3a161fa157
VMware: new module : vmware_datastore_maintenancemode ( #36436 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-03-02 23:35:53 +05:30
Ganesh Nalawade
83c3561ee5
Enable eapi integration test for eos modules ( #36934 )
2018-03-02 12:39:00 +05:30
Matt Martz
ca092b5c26
Skip top level args that are the same as args in provider in doc<->arg_spec comparisons ( #36911 )
2018-03-01 10:47:20 -06:00
Ganesh Nalawade
5c2a1a6124
Fix eos_vrf integration test failures ( #36893 )
2018-03-01 13:05:39 +05:30
Trishna Guha
2fbfce06e7
Fix nxos_interface multiple issues ( #36827 )
...
* fix interface_type
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix setting mtu, doc for state check param, doc for params applicable for ethernet intf
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* speed idempotence and add unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fabric_forwarding_anycast_gateway applicable for svi type intf only
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix speed
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-01 10:56:16 +05:30
Abhijeet Kasurde
0694aca2a0
VMware: refactor configure disk logic ( #36617 )
...
This fix corrects logic related to disk parameters.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-03-01 09:36:54 +05:30
Pilou
274a4b0688
gitlab_project: don't ignore errors ( #36702 )
...
* gitlab_project: check that errors are reported
* gitlab_project: report encountered errors
Fix #36495
2018-02-28 23:22:47 +01:00
Gaurav Rastogi
60e39b9718
Updated the documentation of modules to match argspec including the type setting for bool parameters ( #36821 )
2018-02-28 14:38:03 +00:00
Claes Nästén
042c111563
nso_config break cycles in dependency sorting ( #36828 )
...
False assumption that values can not have cyclic dependencies. Fix by
removing dependency on self and look for cycles, if found remove
dependency to get a partial sort done.
2018-02-28 11:16:49 +00:00
Matt Clay
dc71c2197f
More code-smell sanity test updates. ( #36830 )
...
* Add test for missing Azure requirements.
* Improve readability.
* Enhance no-unicode-literals code-smell test.
2018-02-28 00:50:00 -08:00
Ed Costello
645952c139
Add aws_caller_facts module and use it in setup-iam.yml ( #36683 )
...
* Add aws_caller_facts module and use it in setup-iam.yml
This removes the dependency on having the command line AWS tools
installed.
2018-02-28 16:30:34 +10:00
saichint
db43fe6a76
nxos_facts fix and integration tests ( #36796 )
...
* fix nxos_facts ipv6 error
* time_range not supported for N35
2018-02-28 10:45:50 +05:30
Abhijeet Kasurde
8d49bb6eee
VMware: new module: vmware_host_capability_facts ( #36497 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-28 09:54:52 +05:30
Matt Clay
ac1698099d
Overhaul additional sanity tests. ( #36803 )
...
* Remove unnecessary sys.exit calls.
* Add files filtering for code-smell tests.
* Enhance test-constraints code-smell test.
* Simplify compile sanity test.
* Pass paths to importer on stdin.
* Pass paths to yamllinter on stdin.
* Add work-around for unicode path filtering.
* Enhance configure-remoting-ps1 code-smell test.
* Enhance integration-aliases code-smell test.
* Enhance azure-requirements code-smell test.
* Enhance no-illegal-filenames code-smell test.
2018-02-27 15:05:39 -08:00
Claes Nästén
e75989ec88
nso_config work around ordering issues ( #36774 )
...
Include dependencies when sorting entries to avoid issues with certain
versions of NSO.
2018-02-27 15:22:57 +00:00
Matt Clay
60a24bbdaa
Pass code-smell paths on stdin.
2018-02-27 00:36:16 -08:00
Abhijeet Kasurde
87d6bdaf98
VMware: Re-enable VM poweroff testcases ( #36734 )
...
This testcases were failing due to vcsim version.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-27 09:04:42 +05:30
nwsparks
e15a903bdf
Win lineinfile fix ( #35100 )
...
* win_lineinfile: fix #33858 . Removed conversion from \r\n
* win_lineinfile: added test for #33858
* win_lineinfile: added documentation and more tests for change
* win_lineinfile: fixed wrong hash in testing
2018-02-26 19:34:44 -05:00
Matt Clay
009f536d4e
Update default docker container SHA.
...
ci_complete
2018-02-26 13:23:22 -08:00
David Newswanger
6bd715a17d
skip fmg_script unit test if the pyFMG script is not present ( #36732 )
...
* skip fmg_script unit test if the pyFMG script is not present
* appease the sanity test gods
2018-02-26 12:01:14 -05:00
Claes Nästén
2789cc5c09
NSO ValueBuilder improvements. 4.5 leaf-list compatability. ( #36583 )
...
Fix issues in ValueBuilder used in nso_config and nso_verify so that it
can handle leaf-list in NSO 4.5 and detect identityref types from
unions.
Fail gracefully if a type is not found.
2018-02-26 13:18:20 +00:00
Mário Santos
8b52006d5c
Fix sanity checks in OpenStack docs fragment ( #36722 )
...
* Fix sanity checks in OpenStack docs fragment
Signed-off-by: Mário Santos <mario.rf.santos@gmail.com>
2018-02-26 13:05:53 +00:00
Peter Sprygada
93b795baf0
allows ib_spec attrs to be filtered in update ( #36673 )
...
* allows ib_spec attrs to be filtered in update
This change will allow the ib_spec entries to be be filtered on a change
object by setting the update keyword to false. The default value for
update is true. When the update keyword is set to false, the keyed
entry will be removed from the update object before it is sent to the
api endpoint.
fixes #36563
* fix up pep8 issues
2018-02-26 07:55:26 -05:00
René Moser
cdb2969703
cs_sshkeypair: fix ssh key rename ( #36726 )
...
* tests: cs_sshkeypair: add reproducer for failed key rename
* cs_sshkeypair: fix rename ssh key
2018-02-26 13:43:40 +01:00
Martin Krizek
54e9096950
Add integration test for #36534 ( #36581 )
2018-02-26 09:49:25 +01:00
Abhijeet Kasurde
d94a1ef4cc
VMware: refactor vmware_datastore_facts ( #36423 )
...
This fix adds datastore cluster details about datastore in returning
facts. Updated documentation and tests.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-26 13:23:22 +05:30
Trishna Guha
44332bda78
fix nxos_vlan aggregate ( #36710 )
...
* fix nxos_vlan aggregate
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-26 12:29:49 +05:30
Ganesh Nalawade
5a6b893240
Decouple config and state check in vlan and vrf network modules ( #36386 )
...
* Decouple config and state check in {network_os }_vlan and { network_os }_vrf modules
Fixes #35567
Fixes #34754
`interfaces` option is used for configuration as well as operational state
check. If interface is configured to given vlan or vrf but if
operational state of interface is disabled it results in module failure.
Fix is to decouple same option usage for config and state.
With this fix `interfaces` is used as config option and a new
option named `associated_interfaces` will be used for intent check
for assigned interfaces.
* Fix CI failures
* Fix review comment
* Fixed integration test failure
2018-02-26 09:23:54 +05:30
Matt Clay
f283edcb19
Temporarily disable subversion test on osx.
2018-02-24 13:46:40 -08:00
Ed Costello
2a0c7c4331
Fix documentation of validate_certificates option in aws doc_fragment.
...
Unignore sanity test failures for AWS modules caused by this common
fragment.
2018-02-23 13:21:44 -08:00
Chris Houseknecht
53cfd70b7d
Adds k8s_raw, openshift_raw tests ( #36228 )
2018-02-23 10:13:09 -05:00
Pilou
07927f52ae
filesystem: fix documentation ( #36556 )
2018-02-23 10:59:38 +00:00
Matt Martz
a7062b7587
Start of tests for modify_module, specifically to ensure proper shebang replacement on old style modules ( #36602 )
2018-02-22 16:27:53 -06:00
Matt Clay
5b5cba5e50
Update more code-smell tests. ( #36570 )
...
* Enhance use-compat-six code-smell test.
* Enhance use-argspec-type-path code-smell test.
* Enhance replace-urlopen code-smell test.
* Enhance boilerplate code-smell test.
* Enhance no-underscore-variable code-smell test.
2018-02-22 08:08:29 -08:00
Matt Clay
891f4f3b2d
Upgrade more code-smell tests. ( #36560 )
...
* Enhance no-dict-* code-smell tests.
* Enhance no-basestring code-smell test.
* Enhance no-get-exception code-smell test.
* Enhance empty-init code-smell test.
* Enhance required-and-default-attribute test.
* Remove unused code-smell test.
2018-02-21 20:09:13 -08:00
Jordan Borean
ef4f8851dc
win_feature: better error handling to make it easier to debug issues ( #36491 )
...
* win_feature: better error handling to make it easier to debug issues
* removed ignroed pslint rules that are no longer needed
2018-02-22 11:33:48 +10:00
Dag Wieers
430088c6f0
aci_interface_policy_leaf_policy_group: Fix test ( #36551 )
2018-02-21 23:48:10 +01:00
Sam Doran
723daf3e3a
Check for regexp match when using insertbefore or insertafter ( #36474 )
...
Add tests to cover this scenario
Fixes #36156
2018-02-21 17:03:38 -05:00
Bruno
afdd748f4c
changed cisco mail to normail hotmail ( #36546 )
2018-02-21 23:01:26 +01:00
Bruno
53125d37d1
add aci_static_binding_to_epg integration tests ( #36542 )
2018-02-21 21:45:38 +01:00
Dag Wieers
51ba115dea
aci_domain_to_encap_pool: Remove integration tests ( #36535 )
2018-02-21 20:33:23 +01:00
Toshio Kuratomi
03a6d72633
Revert "remove query/q ( #36315 )"
...
This reverts commit b47d2e07e1
2018-02-21 10:37:51 -08:00
Dag Wieers
7435e115e0
ACI: Various changes to module documentation and guide ( #36516 )
...
* ACI: Various changes to module documentation and guide
This PR includes:
- We moved the object class information to the notes
- Add version information to guide chapters
- Add generic note to modules with reference to ACI guide
- Reference known issues in aci_rest documentation
- Remove module_utils function docs from modules
- Indicate which parameters are not required for querying all objects
- Added missing RETURN information
* Fix copyright strings
* Remove aci_domain_to_encap_pool.py for v2.5
* More updates
* PEP8 fix
* Improve listings of parameters/return values
2018-02-21 19:35:59 +01:00
Brian Coca
b47d2e07e1
remove query/q ( #36315 )
...
* remove query/q
remove and fixed tests for removed func
* paren fix
2018-02-21 10:42:54 -05:00
John R Barker
5d0ed38e3a
Fixup VMware module docs issues ( #36409 )
...
Fix various argspec vs documentation issue
2018-02-21 15:20:42 +00:00
Martin Krizek
9fced4f0a9
Add integration test for #36430 ( #36432 )
2018-02-21 16:16:02 +01:00
Sloane Hertel
f7d79d4789
[cloud] Retry WAF actions on WAFStaleDataException ( #36405 )
...
Add a util to run functions with AWSRetry to retry on WAFStaleDataExceptions and update ChangeToken for each attempt
2018-02-21 08:14:17 -05:00
mikedlr
52f2057472
aws ssm parameter lookup - change to return Nones for missing variables ( #36456 )
...
* aws ssm parameter lookup - change to return Nones for missing variables
* aws ssm parameter lookup - fix error case message to dump response
* aws ssm parameter lookup - fix integration test cases
2018-02-21 06:50:00 -05:00
Jordan Borean
df8a5d7a4f
fetch: set fail_on_missing: True as default as per docs ( #36469 )
...
* fetch: set fail_on_missing: True as default as per docs
* Updated docs for fetch to say behaviour was changed in 2.5 and updated tests
2018-02-21 18:10:23 +10:00
goshkis
abb956d9eb
vApp properties support ( #32579 )
...
* Adding support for vApp properties.
* vm specification updated only if changes have to be applied. I.e. subsequent updates with the same data will not trigger changed state
* Auxiliary variables renamed, hope this makes the code more readable
* Integration tests changed - re-adding the same properties test not implemented, but tested on real vCenter deployment
* fixing documentation "version_added" for the feature
* Addressing reviewers comments #2 :
* documentation updated with the only meaningful value for "option" attribute - "remove"
* Fixed improperly handled case when user requested "add" operation for existent property
* vApp configuration is updated only with properties that contains changes, not with all properties requested by user
2018-02-21 11:59:13 +05:30
saichint
47a92386c9
fix nxos_bgp_neighbor_af issues ( #36472 )
2018-02-21 10:20:24 +05:30
Dag Wieers
5635c50f9b
aci_iplpg: Various fixes to integration tests/module ( #36460 )
2018-02-21 00:20:38 +01:00
Dag Wieers
1720a210e9
aci_spvpg: Various fixes to integration tests/modules ( #36458 )
...
* aci_spvpg: Various fixes to integration tests/modules
This PR includes:
- A fix in module_utils aci.py
- Various fixes in integration tests
* Fix typo
2018-02-20 22:49:55 +01:00
Matt Clay
2b6ac4561b
Add support for enhanced code-smell tests. ( #36332 )
...
* Add support for enhanced code-smell tests:
- Path selection handled by ansible-test.
- Optional path filtering based on extension.
- Optional path filtering based on prefixes.
- Optional lint friendly output.
* Enhance no-assert code-smell test.
* Enhance no-tests-as-filters code-smell test.
2018-02-20 13:37:23 -08:00
Bruno
7143cf54bc
added aci_vpc_protection_group integration test ( #36448 )
...
added aci_switch_policy_vpc_protection_group integration test
2018-02-20 20:42:08 +01:00
Matt Clay
a9b58b84d8
Fix path handling in validate-modules sanity test.
2018-02-20 11:02:42 -08:00
Trishna Guha
3d06ce245a
fix vyos_l3_interface adding multiple addresses to interface ( #36377 )
...
* fix vyos_l3_interface adding multiple addresses to interface
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* add test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-20 20:54:27 +05:30
Bruno
4a6d837879
added aci_fabric_node integration test ( #36422 )
...
* added aci_fabric_node integration test
* Update main.yml
2018-02-20 15:06:41 +01:00
