1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

42862 commits

Author SHA1 Message Date
Maxim Babushkin
de542394af Add port_type argument to os_port module (#47415)
Openstack has multiple types for the port.
Add type selection during the port creation and update.
2019-01-24 09:48:08 +00:00
Vagner Farias
70c61cff05 ovirt_disk: Support ISO image uploads. (#51256)
* Support ISO image uploads.

* Fixing missing whitespace.
2019-01-24 03:28:29 -05:00
Jordan Borean
b2114a9ddf
test - skip dnf on RHEL 8 until test is fixed (#51260) 2019-01-24 16:43:20 +10:00
Jihad Dwidari
0050e8be31 Added Return Values (#51069)
Added variables set by this module and a description of each

+label: docsite_pr
2019-01-23 23:55:07 -05:00
Ganesh Nalawade
70bf9b9919
Add backup filename and dir path option for config network modules (#50801)
* Add configurable backup path option for network config modules

Fixes #50283
Fixes #32724

*  Add back_options in network config module argspec
*  Handle backup path options in network action plugin

* Fix review comments

* Add integration tests

* Update changelog
2019-01-24 09:36:16 +05:30
Anatoly Pugachev
fe8412128b facts: solaris: introduce distribution_major version detection for Solaris (#43978)
* facts: solaris: introduce distribution_major version detection for Solaris

Currently, there's no distribution_major in facts module on Solaris OS.
Use "uname -r" output to report major version.

Before the patch we get this on Solaris 11.3 :

$ ansible -o solaris11 -m setup -a filter=ansible_distribution_major_version
solaris11 | SUCCESS => {"ansible_facts": {}, "changed": false}

and after this patch, output is the following:

$ ansible -o solaris11 -m setup -a filter=ansible_distribution_major_version
solaris11 | SUCCESS => {"ansible_facts": {"ansible_distribution_major_version": "11"}, "changed": false}

Tested with Solaris 11.3 and Solaris 10 (both are x86_64 VMs)

Includes patch for test/units.

Fixes #18197

* Try to fix test unit

* should work now...

* fixes for W291 (trailing whitespace) and E265 (block comment)

* mock uname_release for solaris 10 and solaris 11

* facts: solaris: introduce distribution_major version detection for Solaris

Currently, there's no distribution_major in facts module on Solaris OS.
Use "uname -r" output to report major version.

Before the patch we get this on Solaris 11.3 :

$ ansible -o solaris11 -m setup -a filter=ansible_distribution_major_version
solaris11 | SUCCESS => {"ansible_facts": {}, "changed": false}

and after this patch, output is the following:

$ ansible -o solaris11 -m setup -a filter=ansible_distribution_major_version
solaris11 | SUCCESS => {"ansible_facts": {"ansible_distribution_major_version": "11"}, "changed": false}

Tested with Solaris 11.3 and Solaris 10 (both are x86_64 VMs)

Includes patch for test/units.

Fixes #18197

* Try to fix test unit

* should work now...

* fixes for W291 (trailing whitespace) and E265 (block comment)

* mock uname_release for solaris 10 and solaris 11

* typo uname_v -> uname_r

* rebase

* fix pep8 E302: 2 blank lines

* remove int() cast to match test case

* use single function for uname_r and uname_v

* add solaris 11.4 OS to distribution test unit

* fix pep8 sanity - E231 missing whitespace

* distribution_major_version variable strip newline

* mocker test function for mock_get_uname with parameters instead of two different functions

* failed to make one fuction with test unit, revert to use 2 different functions

* try to use single get_uname function

* fix pep8: E703
2019-01-23 20:33:32 -05:00
Brian Coca
96b3ef5553
Doc fragments to plugins (#50172)
* promote doc_fragments into actual plugins

  change tests hardcoded path to doc fragments
  avoid sanity in fragments
  avoid improper testing of doc_fragments
  also change runner paths
 fix botmeta
 updated comment for fragments
 updated docs
2019-01-23 20:03:47 -05:00
Zim Kalinowski
4041f02389
adding devtestlabs (#50961) 2019-01-24 08:03:16 +08:00
Zim Kalinowski
a6bbf21282 adding vmss extension (#50709)
* adding vmss extension

* added alias

* fixed one thing

* + better idempotence handling

* fixed mistake in module

* removed location check as not reliable
2019-01-23 15:51:10 -08:00
Dag Wieers
b44c8dc000
team_macos: Add auto-labeling for macOS (#51255) 2019-01-24 00:43:23 +01:00
Sebastien Rosset
1ec782900d ec2_vpc_nacl fails when the VPC is configured with IPv6 (#49979)
* Issue #41079. Failed to apply rule if there is a default IPv6 NACL

* Issue #41079. Failed to apply rule if there is a default IPv6 NACL

* Issue #41079. Failed to apply rule if there is a default IPv6 NACL

* Simplify logic to skip default deny-all rules

* Simplify logic to skip default deny-all rules

* Remove unnecessary tmp variables
2019-01-23 18:36:49 -05:00
Matt Clay
a20d0d1afb
Fix dnf integration test issues. (#51251)
* update/enable rhel8 beta integration tests for yum and dnf

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix typo in conditional for dnf/tasks/main.yml

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix var scoping for environment checks

Signed-off-by: Adam Miller <admiller@redhat.com>

* Disable install via path on RHEL.
2019-01-23 13:52:03 -08:00
Alex Stephen
73e7e663c6 New GCP module: gcp_iam_service_account_key (#50682) 2019-01-23 16:49:50 -05:00
Alex Stephen
708e4440c9 Bug fixes for GCP modules (as of 2019-01-22T12:43:52-08:00) (#51244) 2019-01-23 16:45:52 -05:00
Alex Stephen
47ce9ecd2e Bug fixes for GCP modules (as of 2019-01-22T12:43:52-08:00) (#51245) 2019-01-23 16:45:40 -05:00
Alex Stephen
395fbce194 Bug fixes for GCP modules (as of 2019-01-22T12:43:52-08:00) (#51246) 2019-01-23 16:45:30 -05:00
Alex Stephen
2836c8c897 Bug fixes for GCP modules (as of 2019-01-22T12:43:52-08:00) (#51247) 2019-01-23 16:45:20 -05:00
Alex Stephen
6a3eaba52e Bug fixes for GCP modules (as of 2019-01-22T12:43:52-08:00) (#51248) 2019-01-23 16:45:08 -05:00
Alex Stephen
7ceffb7ba2 New GCP module: gcp_sourcerepo_repository (#51249) 2019-01-23 16:44:54 -05:00
Alex Stephen
e4737ce730 New GCP module: gcp_sourcerepo_repository_facts (#51250) 2019-01-23 16:44:46 -05:00
Martin Krizek
11fb0a5d6a
facts: detect IP addresses on busybox properly (#51131)
* facts: detect IP addresses on busybox properly

Fixes #50871

* Check rc before parsing data

* Ooops
2019-01-23 22:24:29 +01:00
Sandra McCann
16511501b6 Remove outdated minor release info from table (#50903)
* removed outdated minor release info from table
* fixed grammar nits
* added link to releases
2019-01-23 15:22:40 -06:00
Felix Fontein
84562ea25b Add team_docker as maintainer for and docker label to docker scenario guide. (#51229) 2019-01-23 14:14:15 -06:00
Brian Coca
9793b194b9 clarify environment (#50987)
* clarify environment

* it does work on windoez
2019-01-23 13:54:05 -06:00
Ken Dreyer
1b09197244 doc: describe merging to ansible.module_utils.* (#51152)
Add a section to the documentation describing precisely how Ansible
merges custom module_utils/* Python code into the "ansible.module_utils"
namespace.
2019-01-23 13:52:16 -06:00
Sandra McCann
47d22bbcd8 add network roles info (#49501)
* add network roles info
* add role update instructions
* implemented feedback

Co-Authored-By: samccann <samccann@redhat.com>
2019-01-23 13:36:05 -06:00
Sandra McCann
3eec7f1820 Modules tocfix (#51077)
define & create subcategories, output by category and subcat
2019-01-23 13:21:23 -06:00
Adam Miller
2d83db7036 update/enable postgresql integration test target for rhel8 beta
Signed-off-by: Adam Miller <admiller@redhat.com>
2019-01-23 11:09:10 -08:00
Adam Miller
14a1199dfc update/enable filesystem integration test target for rhel8 beta
Signed-off-by: Adam Miller <admiller@redhat.com>
2019-01-23 11:08:52 -08:00
Adam Miller
1ad5bae359 update sefcontext integration target and enable for rhel8 beta
Signed-off-by: Adam Miller <admiller@redhat.com>
2019-01-23 10:51:42 -08:00
Adam Miller
f0df9760d3 enable groupby_filter test target for rhel8 beta (#48962) 2019-01-23 10:27:48 -08:00
Chris Archibald
890f4eb5c4 New Options for Autosupport (#50773)
* new option

* spelling

* fix minor issue

* Fix Doc line

* Add update netapp_module

* fix issue with autosupport

* Fix docuemntation
2019-01-23 18:18:07 +00:00
Matt Martz
8c08d03989
Fieldattribute inheritance with defaults (#50891)
* Add tests for check_mode at play and task level

These test inheritance of check_mode from the various levels (command
line, as a play attribute and as a task attribute) so they will be
useful for checking that the change to fieldattribute inheritance with
defaults works

* Add a sentinel object

The Sentinel object can be used in place of None when we need to mark an
entry as being special (usually used to mark something as not having
been set)

* Start of using a Sentinel object instead of None.

* Handle edge cases around use of Sentinel

* _get_parent_attribute needs to deal in Sentinel not None

* No need to special case any_errors_fatal in task.py any longer

* Handle more edge cases around Sentinel

* Use Sentinel instead of None in TaskInclude

* Update code to clarify the vars we are copying are class attrs

* Add changelog fragment

* Use a default of Sentinel for delegate_to, this also allows 'delegate_to: ~' now to unset inherited delegate_to

* Explain Sentinel stripping in _extend_value

* Fix ModuleArgsParser tests to compare with Sentinel

* Fixes for tasks inside of roles inheriting from play

* Remove incorrect note. ci_complete

* Remove commented code
2019-01-23 11:40:07 -06:00
Brian Coca
ad57efff8f
[WIP] force install role and its deps (#49347) 2019-01-23 12:34:26 -05:00
Brian Coca
42c35a2e01
parallelize getting mount info (#49398)
* parallelize getting mount info

* fixed timeout and made 8 max thread count

  - minor cleanup
  - avoid empty mount entries
  - set timeout on get
  - enforce timeout per mount/thread
  - make note on failure per mount
  - make note on timeout per mount
  - ensure proper pool control
  - minor fixes
  - less vars, simpler code
  - move filter 'pre threading'
  - remove timeout for all mounts, now per mount
  -  also use cpu count from multiprocessing lib
  -  moved 'bind' options out of thread as per comments
  - warn on error, more info on failure to get info
2019-01-23 12:33:59 -05:00
Brian Coca
960388143f
faster config loading (#48333)
* faster config loading

  - used already loaded module var instead of doc functions
  - add preload to populate config defs cache
  - avoid debug work when not in debug
  - generators, force consumption
2019-01-23 12:06:54 -05:00
Sam Doran
9d4c0dc111 Catch sshpass authentication errors and don't retry multiple times to prevent account lockout (#50776)
* Catch SSH authentication errors and don't retry multiple times to prevent account lock out

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Subclass AnsibleAuthenticationFailure from AnsibleConnectionFailure

Use comparison rather than range() because it's much more efficient.

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Add tests

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Make paramiko_ssh connection plugin behave the same way

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Add changelog

Signed-off-by: Sam Doran <sdoran@redhat.com>
2019-01-23 11:32:25 -05:00
Dag Wieers
2798d5bafc
Clarify gather_facts and highlight important lines
Clarify gather_facts and highlight important lines

+label: docsite_pr
2019-01-23 17:25:24 +01:00
Brian Coca
b6824669df
Handle complex quoting in extra args in pull cli (#50212)
* Handle complex quoting in extra args in pull cli

fixes #40729
2019-01-23 10:58:37 -05:00
Sumit Jaiswal
4049e33817
PR to implement support feature for creating NIOS network container (#51168)
* resolves 51161

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* resolves 51161

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* resolves 51161

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* resolves 51161

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* resolves 51161

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-01-23 19:21:00 +05:30
Peter Oliver
9edeb19354 Populate product_name and system_vendor facts on Solaris (#44114)
* Populate product_name and system_vendor facts on Solaris

* Add QEMU as Solaris "hardware" vendor.

* Lint fix.
2019-01-23 13:51:23 +01:00
Felix Fontein
d2c4f57f16 docker_service: rename to docker_compose. (#51035)
* Rename docker_service -> docker_compose.

* Added changelog.

* Update scenario guide.

* Clean up module.
2019-01-23 12:21:57 +00:00
Eike Frost
3c39c5d456 keycloak_client: fix ansible diff/changed (sorting, null-values) (#39515)
* - Fix sorting bug related to diff (attributes is sorted in the API, other lists are not)
- Remove null-valued entries from protocolMappers introduced by Ansible's argument spec checking (also fixes diff output).

* python2.6-ified dict comprehension

* avoid use of map
2019-01-23 03:53:07 -05:00
Olivier BLIN
87a01df6ad Fix 'defaults' option in the nxos_config module (#51076)
* Fix 'defaults' option in the nxos_config module

Nxos get_config is allways called with the 'all' option.
* Fix flag's calculation
* Add tests

* nxos_config: the 'backup' option take into account the value of 'defaults' option

If 'defaults' option is true, the running-config backup is done with the all
keyword.
2019-01-23 11:29:27 +05:30
Dag Wieers
7eab04e975 Required changes for zfs_delegate_admin (#51202)
* Required changes for zfs_delegate_admin

As discussed when merged.

* Sanity fixes
2019-01-22 21:04:23 -08:00
linnil1
dabdf171c5 Feature junos filter (#44703)
* Add filter in l3_interface

* Add filter in vlan

* Add filter in l2_interface

* Update version to 2.8
2019-01-23 09:36:24 +05:30
Smithx10
e7a113a70f New Module for SmartOS: nictagadm (#35919)
* added nictagadm functionality for smartos

* Added mac address assertion and mutex's for etherstub params

* removed old commented code

* Responding to ansibot lint

* Responding to ansibot lint underscore

* doc wording, if rc to return rc

* Version Added bump to 2.6

* Grammer Fix

* match documentation with the arg spec

* removed default from Options since None evidently is 'None'

* Guessing to please the linter, No documentation

* Various changes

* PEP8 fixes
2019-01-23 04:57:46 +01:00
Nate Coraor
64b57908bc A module for managing ZFS admin privileges (#19240)
* Create a module for managing ZFS admin privileges

* Actually support check mode in zfs_permissions

* Fix Python 2.4 invalid syntax

* Update added_version to 2.1

* Remove superflous sys.exit() and add an empty RETURN doc (empty because the module does not return anything other than status-related stuff)

* Update version_added since zfs_permissions was not accepted in 2.1.

* - Rename zfs_permissions to zfs_delegate_admin to more accurately reflect
  its purpose.
- Update with current Ansible module best practices.
- Stop checking whether changes need to be made (this was flawed since
  it was not able to detect whether, for example, changes would be made
  with `local=True` when the permissions already existed for
  `Local+Descendent`. Instead, just make the changes (`zfs allow` is
  idempotent) and compare the state before and after.
- Generally write things in a better way.

* Fix test errors

* Fix more tests.

* Catch exceptions when parsing `zfs allow` output. At least on one
version of ZFS (on a 2016 version of illumos) will have a single space
in the user or group column if the name can't be resolved by the
system's name services).
2019-01-23 03:51:06 +01:00
Dag Wieers
d2c739e9e7 A few small cosmetic changes 2019-01-22 20:03:03 -05:00
Julian Paul Dasmarinas
0622f387c4 Provide a boolean switch to enable/disable publisher refresh 2019-01-22 20:03:03 -05:00