Trishna Guha
fb87680046
fix state present nxos_evpn_vni ( #25212 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-01 08:57:17 +05:30
Nathaniel Case
53837c2ab0
Assorted nxos_bgp_* fixes ( #25080 )
...
* Simplify apply_key_map
* Fix nxapi
* Clean up get_value
* Fix missing non-values
* Add test for existing bgp_af case
* Fix small issues with bgp_neighbor_af
2017-05-30 14:11:15 -04:00
Dag Wieers
4efec414e7
test/: PEP8 compliancy ( #24803 )
...
* test/: PEP8 compliancy
- Make PEP8 compliant
* Python3 chokes on casting int to bytes (#24952 )
But if we tell the formatter that the var is a number, it works
2017-05-30 18:05:19 +01:00
Trishna Guha
31c59ad5f9
nxos_portchannel fix and unit test ( #25019 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-05-30 21:22:24 +05:30
Nathaniel Case
8985f7c930
nxos_static_route updates ( #24992 )
...
* Add static_route tests
* Add VRF tests
2017-05-25 12:19:04 -04:00
Trishna Guha
6a3ce18e4b
add more testcases for nxos_evpn_vni ( #24996 )
2017-05-25 10:50:42 +05:30
Tim Rupp
6ef022b034
Adds the bigip_snmp_trap module to Ansible ( #24848 )
...
This patch adds the bigip_snmp_trap module to Ansible to support managing
SNMP trap destinations on an F5 BIG-IP.
2017-05-24 12:57:30 -04:00
Nathaniel Case
dd4a79d7d3
Clean up nxos_bgp_neighbor_af ( #24890 )
...
* Fix pep8 in bgp_neighbor_af
* Remove WARNINGS
* Rewrite command detection
* Add bgp_neighbor_af test
* Finally kill invoke
2017-05-23 12:43:55 -04:00
Tim Rupp
4fc40304d5
Adds the bigip_command module to Ansible ( #24850 )
...
This patch adds the bigip_command module to Ansible to support arbitrary
tmsh command to a F5 BIG-IP.
2017-05-22 20:11:34 +01:00
Ricardo Carrillo Cruz
b12beca3ed
Refactos nxos_ip_interface module ( #24885 )
2017-05-22 19:48:59 +02:00
Trishna Guha
1e5a0982b9
Fix nxos_hsrp and add unit test ( #24770 )
...
* nxos_hsrp fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* unit test nxos_hsrp
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* ansibot told me to do this
* revert apply_key_map and simplify method
2017-05-19 10:40:42 -06:00
Tim Rupp
22e096f911
Changes skip test for bigip user ( #24799 )
...
All of the F5 Ansible modules will come to require the same major
dependencies over time. This mentions that.
2017-05-18 22:33:05 -07:00
Trishna Guha
998305a493
nxos_ospf_vrf fix and unittest ( #24495 )
2017-05-19 10:09:46 +05:30
Tim Rupp
c1397626fc
Adds the bigip_user module to Ansible ( #24753 )
...
The patch adds the bigip_user module to Ansible to support managing
users on an F5 BIG-IP.
Unit tests are provided. Integration tests can be found here
* https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_user.yaml
* https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_user/tasks
2017-05-18 20:21:18 +01:00
Trishna Guha
8937246f8f
Fix nxos ospf and Unit test ( #24613 )
...
* nxos_ospf fixes refactor
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* unit test nxos_ospf
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-05-17 11:16:41 +05:30
Ganesh Nalawade
f5d865a208
Fixes #24251 save config only if it is changed ( #24345 )
...
* Fixes #24251 save config only if it is changed
Save to startup configuration only when it is different
from running configuration.
* Fix unit test issue
2017-05-16 19:54:36 +05:30
Nathaniel Case
f240ba6b60
nxos_bgp_neighbor cleanup ( #24446 )
2017-05-16 10:14:10 -04:00
Trishna Guha
b2a2f69a6e
nxos_vrf_af fix and unit test ( #24399 )
...
* nxos_vrf_af fix and unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* ansibot told me to do this
* use sorted() as the test list elements differ in order for python2.x and 3.x
2017-05-11 10:54:47 +05:30
Trishna Guha
62eafa8837
fixes nxos_evpn_vni and unittest ( #24372 )
...
* fixes nxos_evpn_vni
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fixes pep8 issue and syntax error
* ansibot tole me to do this
* Unit test
2017-05-11 10:54:05 +05:30
Nathaniel Case
09b2964dee
nxos_bgp_af updates ( #24171 )
...
* update docs
* clean up nxos-bgp_af
* Remove useless params from bgp_af
* Add bgp_af tests
2017-05-10 16:12:00 -04:00
Nathaniel Case
830f19d444
nxos_bgp updates ( #24270 )
...
* Remove invoke from nxos_bgp
* Try to simplify get_existing
* Streamline state_present
* More testing, squash & compact get_value & get_custom_value
* Streamline main
* nxapi has problems reading CustomNetworkConfig directly
2017-05-08 11:38:50 -04:00
Trishna Guha
ad0a01ffb5
nxos_vrf refactor ( #24280 )
...
* nxos_vrf refactor
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Unit test for nxos_vrf
Remove unnecessary keys() method
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-05-05 15:38:30 +05:30
Ganesh Nalawade
0e756a1cf9
Add junos unit test case ( #24249 )
...
* Add junos modules unit test case
* Fix CI issues
2017-05-03 22:36:23 +05:30
Ricardo Carrillo Cruz
7195c31753
Refactor openvswitch_port module ( #24205 )
...
Use current patterns from other network modules for better
maintainability.
2017-05-03 10:36:44 +02:00
Ricardo Carrillo Cruz
467a9bdd4e
Refactor openvswitch_bridge ( #24014 )
...
Use common patterns from other network modules for better
maintainability.
2017-04-28 16:39:25 +02:00
Trishna Guha
2741907cba
Refactor nxos_interface and add unit test ( #24008 )
...
* [WIP] Refactor nxos_interface
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Modification in refactor
Unittest for nxos_interface
2017-04-27 21:19:10 +05:30
Nathaniel Case
fc0bf87c20
Run save
inside config mode. ( #23977 )
...
* Run `save` before exiting config mode.
* Fix unit tests for `save`
* Allow `save` to be on its own again and introspect success
* Introspecting `compare running` makes this a lot harder.
Move `save` tests to integration tests
2017-04-27 11:08:37 -04:00
Ganesh Nalawade
9c4daded94
Add junos_config unit test ( #24005 )
2017-04-27 20:37:15 +05:30
Ricardo Carrillo Cruz
2716fad38f
Return commands instead of command ( #24061 )
...
Ok, so for openvswitch_db in particular we just return one command
but in the sake of consistency and code re-use, let's return a list
of "commands", even if it's just one.
2017-04-27 16:36:08 +02:00
Ricardo Carrillo Cruz
7c1b8da1a1
Refactor openvswitch unit tests ( #24055 )
...
Rather than passing a file to load fixture, build a matrix containing
the run_command side_effect per test.
This will allow more code-reuse for other ovs modules unit tests.
2017-04-27 14:48:37 +02:00
Nathaniel Case
0d67a49d5a
nxos_bgp fixes ( #23927 )
...
* Pre-emptively fix sanity/pep8
* fix for commands
* Quick unit test
2017-04-26 16:33:54 -04:00
Nathaniel Case
c0ebdf144d
nxos_acl_interface fixes ( #23917 )
...
* Update nxos_acl_interface
* Add basic unit tests to nxos_acl_interface
2017-04-26 16:32:36 -04:00
Nathaniel Case
f0914ee3c2
nxos_acl fixes ( #23915 )
...
* Update nxos_acl
* unit tests for nxos_acl
* Remove nxos_acl from pep8-legacy
2017-04-26 16:29:53 -04:00
Ricardo Carrillo Cruz
a3a970180a
Unit tests for openvswitch_db module ( #23974 )
2017-04-25 20:02:55 +02:00
Ganesh Nalawade
1cdfcf0bb9
Add junos_command module unit test ( #23819 )
...
* Add junos_command module unit test
2017-04-21 18:23:40 +05:30
Ricardo Carrillo Cruz
60de93c31d
Add assertion on test_iosxr_facts ( #23852 )
...
We hit bug #23737 due to bad coverage on test_iosxr_facts, we
were not checking memory facts at all.
2017-04-21 11:19:46 +02:00
Nathaniel Case
0b4cebfb8b
nxos_vlan tweaks ( #23194 )
...
* Remove commented code
Remove a lot of unnecessary output
* Tests
* Sort vlan ids _after_ running set operations, so order is not lost
2017-04-18 10:49:47 -04:00
Peter Sprygada
f0008248d4
fix iosxr commands to encode json ( #23346 )
...
the command dict in the iosxr module_utils wasn't encoding the request
to json. this patch will fix that problem
2017-04-06 15:44:21 +01:00
Ricardo Carrillo Cruz
98c98125f0
Fallback to show-run on ios_banner for devices where show banner does not work ( #22793 )
...
On switches 'show banner' command doesn't work, fallback to show run|begin banner
and extract the banner text in case that fails.
2017-03-22 10:01:41 +01:00
Ricardo Carrillo Cruz
6e56a61535
Add ios_banner module ( #22687 )
...
With unit and integration tests.
2017-03-16 16:35:44 +01:00
Ricardo Carrillo Cruz
604a38cac1
Implement eos_banner for EAPI ( #22609 )
...
On EAPI, the multi-line commands are expected to be a dict,
with key/value pairs 'cmd'/'input' .
This change implements that behaviour and fixes the idempotency
on EAPI as well.
Fixes #22494
2017-03-14 21:00:17 +01:00
Peter Sprygada
3f0f7c4f4e
updates junos shared lib and action handler ( #22541 )
...
* removes cli functions from shared lib
* adds cli functions to junos_netconf module
* statically pins junos_netconf to cli transport
* all other modules use netconf transport
* adds command rpc function to junos shared
2017-03-12 08:37:45 -05:00
Ricardo Carrillo Cruz
c57729944b
Fix the eos_banner idempotency ( #22413 )
...
The map_config_to_obj calls the run_commands helper function,
which returns a list of results.
However, the map_params_to_obj return a single string.
Therefore, the comparison between the two datasets could never be equal,
breaking idempotency.
Also, the 'no banner' command should be run on absent only if there's a banner
text set.
Fixes #22194
2017-03-09 12:43:54 +00:00
Peter Sprygada
6c8025ce5c
adds eos_system integration tests ( #22214 )
...
* adds integration test cases
* updates eos_system with minor bug fixes
2017-03-02 21:20:17 -06:00
Matt Clay
a5e3d13adc
Remove shebangs from unit tests.
2017-02-27 17:53:10 -08:00
Peter Sprygada
216877c6ca
adds system_mtu argument to nxos_system ( #21970 )
...
* updates argument_spec
* adds unit test case
2017-02-26 11:33:58 -05:00
Peter Sprygada
10b23f3a00
adds unit test cases for nxos_command ( #21959 )
2017-02-26 07:38:08 -05:00
Peter Sprygada
0cb2019293
roll up of bug fixs for nxos_evpn_global ( #21961 )
...
* updates nxos_evpn_global module
* adds integration test cases
* adds unit test cases
2017-02-26 06:45:26 -05:00
Peter Sprygada
21880b9742
adds nxos_config unit test cases ( #21960 )
2017-02-26 00:45:01 -05:00
Peter Sprygada
16a39639f5
fixes minor bugs in eos_eapi module ( #21925 )
...
* module will now check protocol running state before return
* warns on config argument no longer being needed
* lots of integration test cases updated
* updates unit and integration test cases for state check
fixes #21908
2017-02-25 17:18:46 -05:00