1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

23298 commits

Author SHA1 Message Date
Abhijeet Kasurde
885ee25375
Documentation for several VMware modules (#45153)
* Added return for vmware_host_config_facts
* Added return for vmware_host_service_facts
* Correct typo in vmware_portgroup_facts

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-04 16:37:14 +05:30
Trishna Guha
ab3cd10dfe
fix Python 2.6 regex bug terminal plugin nxos, iosxr (#45135)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-09-04 13:44:43 +05:30
Zim Kalinowski
b1b90faf96 added missing resource_group description in return value (#45143) 2018-09-04 04:04:51 -04:00
Zim Kalinowski
e7ec1ef59c adding tags to container instance (#45142) 2018-09-04 03:56:10 -04:00
Ganesh Nalawade
455dfbe732
Fix netconf module and plugin issues (#45140)
* Fix netconf netconf issues

*  Identifier is optional for get_schema api
*  Fix dispatch api mandatory argument check
*  Add save option handling to copy config from target datastore
   to startup datastore if supported
*  Validate config in check-mode or if validate option set to true

* Copy config if check-mode is not enabled
2018-09-04 13:23:18 +05:30
linnil1
177fbea351 Fix sshkeyfilename is None not str (#44893) 2018-09-04 11:59:08 +05:30
Senthil Kumar Ganesan
3beeeffef9 Docs updated and review comments addressed (#45133) 2018-09-04 07:13:59 +01:00
Zim Kalinowski
1f8635fbd9 Virtual machine facts - retrieving instance view (#45128) 2018-09-04 11:25:01 +08:00
Zim Kalinowski
9bd702ef37 vm size idempotence (#45108) 2018-09-04 09:41:41 +08:00
Zim Kalinowski
55c549a832 added mysql management client to remove api version warning (#45103) 2018-09-04 09:23:11 +08:00
Madhura-CSI
a4663d8e73 New module for azure custom image facts (#42102)
* new module for azure custom image facts

* added facts in aliases, corrected assertion

* simplified managed disk id struct

* updated ansible version
2018-09-04 02:28:01 +08:00
Dag Wieers
e99db084f4
aci_interface_policy_leaf_policy_group: Fix filtering by lagT (#45088) 2018-09-03 16:40:57 +02:00
Dag Wieers
6faf400621
aci_switch_policy_vpc_protection_group: Fix idempotency (#45091) 2018-09-03 16:39:39 +02:00
Rémy Léone
aeac8fe141 Add licence and boilerplate to Online module_utils 2018-09-03 07:24:25 -07:00
Zim Kalinowski
9b28319020 adding container instance facts (#43326) 2018-09-03 15:51:42 +08:00
Rémy Léone
f465a251e1 Add a dynamic inventory plugin for Online (#44720) 2018-09-03 02:33:15 -04:00
Yunge Zhu
b58141555d fix blob in non-public azure cloud (#44802)
* fix blob in non-public azure cloud

* fix  lint

* fix typo
2018-09-03 11:16:23 +08:00
vpopescu
b4c148b6ea fixed boolean value for zone (#41974) 2018-09-03 10:20:16 +08:00
Zim Kalinowski
5fee46a8ec added postgresql management client version (#45079) 2018-09-03 09:47:31 +08:00
Felix Fontein
fec302b162 Fixing typo in acme_certificate docs. (#45082) 2018-09-02 13:01:45 -04:00
Matt Clay
bbca98ae8e Fix PEP8 issue. 2018-09-01 22:54:13 -07:00
Dan Farrell
667f62c5a8 Update lineinfile.py (#44976)
* Update lineinfile.py

The document should call out in the regexp section what regexp does in non-match scenario, not just leave it for the reader to find it under `insertbefore` and `insertafter`.  
+label: docsite_pr

* Update lineinfile.py

fixing for lint

* Use multiple entries
2018-09-02 05:18:33 +02:00
Jonathan
93cd050250 Added default value for when CloudFrontOriginAccessIdentityList is (#44984)
missing.
2018-09-02 12:17:25 +10:00
Matt Martz
f89d873698
Stub out modules scheduled for 2.8 removal (#44985)
* Remove modules scheduled for 2.8

* Add changelog and porting guide

* Skip docs test on removed modules

* Don't link to removed modules
2018-08-31 16:27:32 -05:00
Dag Wieers
b64e666643
Add elapsed return value to select modules (#37969)
* Add elapsed return value to select modules

It can be quite useful to know exactly how much time has elapsed
downloading/waiting. This improves existing modules or updates
documentation.

* Ensure elapsed is always returned

* Added changelog fragment
2018-08-31 22:20:56 +02:00
Toshio Kuratomi
3994300762 Update ansible version number to 2.8.0.dev0 2018-08-31 11:11:13 -07:00
Rémy Léone
5cf9644003 Add an user facts module for Online (#44709) 2018-08-31 14:02:40 -04:00
S. Veyrié
60af5ab962 maven_artifact: enforce required params (fixes #44823) (#44967) 2018-08-31 11:38:09 -04:00
Anil Kumar Muraleedharan
fbf55a09cc Lenovo image refactor (#44953)
* Refactoring code to adhere to persistence connection.

* Update cnos_rollback.py

* Updating license for the refactored method

* Update cnos_rollback.py

* Removing the BSD License as suggested by Legal

* Adding cnos_image after testing on sftp. Test code is also added

* Removing debug comments

* adding space
2018-08-31 20:04:57 +05:30
Ganesh Nalawade
c0326aea2f
Fix cli_command multiple prompt issue (#44922)
* Add check in network_cli to handle all prompts

* Add check_all flag to mandatory handle all the command prompt
  in prompts list. By default if any one prompt is handled
  remaining prompts are ignored.

* Fix cli_command multiple prompt issue

* If multiple prompt and answers are given as input network_cli
  handles only the first prompt that matched by default
* If a command execution results in muliple prompt the fix
  add support to set a boolean option C(check_all) to indicate
  network_cli to wait till all the prompts and answers are processed.

* Update cli_command

* Update api doc

* Fix unit test failure

* Fix CI failure

* Update network_cli

* Fix review comment
2018-08-31 20:04:12 +05:30
Ganesh Nalawade
005233f814
Fix iosxr_config integration test failure (#44969)
*  Check for commands presence in case running config
   is used as base config for diff
*  Correct the fixtures
2018-08-31 19:57:38 +05:30
Deepak Agrawal
50c7702e46
cisco firepower : Make API endpoints configurable via hostvars (#44952)
* httpapi host vars

* Make configurable end-points for firepower

* pep8 fix
2018-08-31 18:38:16 +05:30
Alex Stephen
276ad32a45 removing libcloud secrets support for legacy gcp modules (#44932)
* removing libcloud secrets support for legacy gcp modules

* test fixes
2018-08-31 08:28:32 -04:00
S. Veyrié
5b358db83f maven_artifact: download with shutil.copyfileobj to a temp file (#44956)
* maven_artifact: replace homemade chunked download with shutil.copyfileobj

* maven_artifact: copy to temp file first
2018-08-31 07:35:26 -04:00
Ganesh Nalawade
b0d6867fbb
Fix netconf_config module default_operation issue (#44958)
* Pass parameters as dict to edit_config api
  as either dict or args can be passed over
  jsonrpc 2.0 and not combination of args and
  kwargs
2018-08-31 16:33:34 +05:30
bonzi316
eee406dfd2 Fix maven_artifact md5 checksum check with archiva repository (#43250) 2018-08-31 05:32:37 -04:00
Matt Davis
2822fd8d9b
initial commit of azure_rm inventory plugin (#44944)
* crusty refactor of azure_rm to support auth from non-modules
2018-08-31 01:33:23 -07:00
Martin Nečas
c2fa0d2c4b recator uploading disk and downloading (#43635) 2018-08-31 03:23:52 -04:00
Martin Nečas
d5ebc3e0ec add quota_name to ovirt permition module (#44713) 2018-08-31 03:00:13 -04:00
Martin Nečas
c65c841ef3 add ovirt attach host devic (#44714) 2018-08-31 03:00:04 -04:00
Nilashish Chakraborty
0f268e70a1
Fix ios_user issues (#44904)
* Fix ios_user issues

* Modify regex and fix unittests
2018-08-31 11:08:46 +05:30
Ubuntu
7d81de2516 updates to azure_rm_sqlfirewallrule
updates to azure_rm_sqlfirewallrule

small fixes

move sql client to common

adding state

fixed sample

fixed sanity

fixed aliases

removed unnecessary object

removed unused resource_group

changed group to less crowdy

tags

no tags on firewall rule
2018-08-30 21:54:58 -07:00
Yuwei Zhou
b7d614df78 add auto scale module (#41533)
* add autoscale modules

* add test alias
2018-08-30 21:18:56 -07:00
Roman Belyakovsky
4f70eb3e26 ec2_vol_facts: moved to boto3 (#43348)
* ec2_vol_facts: moved to boto3

* vol_facts: formatting fixes

* vol_facts: formatting fixes

* vol_facts: added integration tests

* vol_facts: improved integration tests

* vol_facts: integration tests, fixed ami

* vol_facts: integration tests, fixed ami

* vol_facts: refactor, post-review update

* vol_facts: implemented pagination

* vol_facts: pep8 style fix

* CI IAM policy requirements fix

* Tests fixed, added to unsupported, removed empty files

* removed shippable alias
2018-08-31 13:50:17 +10:00
Dag Wieers
d71670655b
Fix small typo 2018-08-31 05:10:35 +02:00
Richard Levenberg
c759381b0b win_xml module for manipulating XML files on Windows (#26404)
documentation fixups

handling backup in a more ansible canonical way

remove quotes from $dest

Handle elements with only text child nodes
2018-08-31 12:20:09 +10:00
Sloane Hertel
113336d6f1 rds_instance module and tests (#43789)
* Add functions to retrieve the allowed and required parameters for boto3 client methods

* Add custom waiter for stopping an RDS DB instance

* Add rds_instance module

* Add rds_instance integration tests

* address requested changes from ryansb

* address requested changes from willthames

* address requested changes from dmsimard

* Fix final snapshots

Fix idempotence with already-deleting DB instances

Remove unused import from module_utils/aws/core.py

Consolidate function to get all boto3 client method parameters and the subset of required parameters

* Add some additional rds_instance integration tests

* Add some common functions to module_utils/aws/rds

* Move common code out of rds_instance

* Remove hardcoded engine choices and require the minimum boto3

* Document wait behavior

* Provide a list of valid engines in the error message if it is invalid

Add supported methods to whitelist

Remove AWSRetry around waiter

Wait for a less crazy amount of time

Remove unused variables

* Add a test for an invalid engine option

* pep8

* Missed adding a method to the whitelist

* Use retries

* Fix some little things

* Fix more things

* Improve error message

* Support creating cross-region read replicas

* Remove unused imports

* Add retry when getting RDS instance

* Soft-check required options so module fails properly when options are missing

* Fix mariadb parameter version

* Fix cross-region read_replica creation and tests

* fix modify tests

* Fix a modification test

* Fix typo

* Remove test for option_group_name that exists for this account but may not for others and added as a TODO to do properly
2018-08-31 12:17:02 +10:00
Yunge Zhu
ef8ce6b2f3 remove wrong alias on secret_value (#44877) 2018-08-31 09:36:52 +08:00
Dag Wieers
dbe30cc050
win_wait_for_process: Fixes and integration tests (#44801)
* win_wait_for_process: Add integration tests

* Disable reporting changes

* Added more tests checking PID

* Various improvements

This PR includes:
- Use Get-Process instead of CIM Win32_Process
- Rewrite of process filter logic (speedup)
- Fix error messages
- Fixes to documentation, examples and return output

* win_wait_for_process: Limit to PowerShell 4 and higher

* Improve RESULT documentation

* Last minute fixes for CI

* Catch Powershell exceptions

* Increase timeout to make tests more stable
2018-08-31 03:13:51 +02:00
Will Thames
ce110ff081 K8s retry merge (#44821)
* Make merge_type a list and apply merge_type in order

Allow use case of preferring strategic-merge and failing
back to merge, or just preferring a different merge type

* Improve k8s module test coverage
2018-08-30 20:42:47 -04:00
Matt Martz
2a4e92aab7
ensure if we get a non-Task object in _get_delegated_vars, we return early (#44934) 2018-08-30 17:11:32 -05:00
Alex Stephen
3550f342e0 Gcp auth deprecation (#44866) 2018-08-30 17:14:39 -04:00
Matt Martz
a0d7d4b82f Change insertion order of apply block to not affect the include_X task itself (#44912) 2018-08-30 16:56:28 -04:00
Stéphane Wirtel
711944aa97 Fix a comparison with a string and a byte in flatpak_remote (#44835)
* flatpak_remote: Fix the comparison between string and bytes for the remote_exists function

* Use to_text instead a new compare function

* Compare bytes to bytes
2018-08-30 22:36:34 +02:00
Ryan Conway
074aeeadff Add onepassword_facts module, based on the "onepassword" lookup plugin (#43953)
* Adding 1password facts module, based on the existing lookup plugin.

* Fix typo in error message.

* Fix tiny typo.

* Fixing documentation formatting errors.

* Clarify examples.

* Fix invalid return sample.

* Add required Ansible boilerplate.

* Swap AnsibleModuleError for plain Exception to fix "ImportError: No module named errors" error.

* Renaming from "1password_facts" to "onepassword_facts" to avoid potential compatibility issues.

* Renaming the module file also.

* Remove unnecessary comment.

* Fix use of incorrect code formatting wrappers.
2018-08-30 16:26:47 -04:00
Sam Doran
8cd8d17980
Add ability to unlock 1Password vault to lookup plugins (#44923)
* Add ability to use login to 1Password vault to 1Password lookups

* Adjust unit tests

* Add changelog
2018-08-30 16:24:06 -04:00
Ken Partridge
0b7a37c67b Add lookup cpm_metering to read WTI CPM and VMR PDU device power and current data (#44491)
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* re-add cpm_metering

* was gettign a ERROR: Command "docker exec from GitHub, so this is a retry

* removed un-needed files

* removed old cpm_metering

* removed cpm_metering.py

* re-add cpm_metering

* removed pyc file

* re-added cpm_metering.py

* cleaned up EXAMPLES indentation

* EXMAPLES startdate, enddate had : instead of = to indicate a value

* Fixed missing whitespace around arithmetic operator
2018-08-30 15:53:38 -04:00
Ken Partridge
77b4b2cdc9 Add module cpm_user to read, create, edit and delete users on WTI devices (#44512)
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* Add module cpm_user to read, create, edit and delete users on WTI devices

* changed user_name required to true

* fixed whitespace and argument spec problems

* fixed dict issues

* fixed use_proxy inconsistency
fixed whitespace warnings

* struggling with AnsibleError removal

* remove reference to ansible.errors

* changed EXAMPLES to reflect live unit
2018-08-30 15:51:44 -04:00
Ryan Breaker
c9adfdf68b Reword documentation for IOS L2/L3 interface modules (#44870)
* Update documentation to be cohesive with ios_l2_interface

* Fix small typo in documentation
2018-08-30 14:48:43 -05:00
Jose Delarosa
fdb1d1146f Add module redfish_command (#43469)
* Add module redfish_command

Communicates with Out-Of-Band Controller through Redfish APIs
Sends a command to execute an action

* Wrapped all instances of result['msg'] inside to_native()

* Added more entries to Description section

* Minor fixes for PEP8 compliance

* Update the root URI to match the DMTF specification

* Display valid Categories or Commands in case invalid value given

* Updated returned values and description
2018-08-30 15:40:45 -04:00
Jose Delarosa
7f43f49b42 Add module redfish_config (#43470)
* Add module redfish_config

Communicates with Out-Of-Band Controller through Redfish APIs
Sends a configuration update to the Controller

* Wrapped all instances of result['msg'] inside to_native()

* Added more entries to Description section

* Minor fixes for PEP8 compliance

* Update the root URI to match the DMTF specification

* Display valid Categories or Commands in case invalid value given

* Updated returned values and description

* Add default values to bios and mgr variables
2018-08-30 15:38:57 -04:00
Adam
00368a432f Update lightsail.py (#44902) 2018-08-30 13:24:04 -05:00
Matt Martz
9d89e15ff0
Ensure we only cache the loop when the task had a loop (#44901)
* Further restrict caching of loop when the task actually had a loop. Fixes #44874

* Extend tests for loop caching
2018-08-30 12:02:43 -05:00
Senthil Kumar Ganesan
a64b97da42 Support for Openswitch (OPX) Control Plane Services (CPS) Module (#44745)
* Generic module to support Openswitch (OPX) Contorl Plane Services (CPS)

* Address ansible-test sanity issues
2018-08-30 17:39:47 +01:00
Ganesh Nalawade
1fdd0e10bb
Update netconf_config module doc (#44910)
* Fix review comments from wisotzky
2018-08-30 21:39:37 +05:30
Ganesh Nalawade
1a684df109
Fix iosxr cli_config module diff issue (#44898)
* Fix iosxr cli_config module diff issue

* Modify iosxr plugin to support configuration
  diff capability (get_diff()) within Ansible
  to be in sync with iosxr_config module.

* Fix unit test case failure
2018-08-30 21:39:11 +05:30
Jeff Geerling
c3e526bf2c helm: Improve documentation style and readability. (#44876) 2018-08-30 11:06:35 -05:00
yaakov kuperman
6b7ea5078f [aws] New module: elb_target_facts (#43565)
* initial source of the elb_target_facts module, which gathers all
registered ELBv2 target groups for a given instance id

* updating

* initial dump of tests

* updating docs, adding AWSRetry decorators

* updating tests

* More brush up, some refactoring

* updating for sanity tests

* removing extra space

* updating elb_target_facts to use a new name for the return value, not return a fact, and use instance variables for the AWS connections.  updating tests to go along with that

* updating classes to be 'new-style' classes
2018-08-30 10:47:28 -04:00
Alex Stephen
3c6c7bae9d Allow home path expansion on GCP service account files (#44863)
* Allowing home path expansion on GCP service account files #42974

* wrong name for changelog
2018-08-30 10:27:29 -04:00
Dag Wieers
bf9ed0263a Ensure action plugins accept only valid args (#44779)
* Ensure action plugins accept only valid args

This fixes #25424
This also fixes #44773

* Add missing parameters, use private _VALID_ARGS
2018-08-30 09:40:36 -04:00
Matt Martz
0221d1ad20
Introduce and use locale-naive rfc2822 date format function (#44868)
* Introduce and use locale-naive rfc2822 date format function. Fixes #44857

* Adjust test expected response
2018-08-30 08:34:37 -05:00
Ghilli3
7bc2660017 fortimanager/fmgr_provisioning.py (#35743)
* Initial commit for new provisioning module
2018-08-30 14:25:17 +01:00
Justin Yaple
a767929456 Fix 'macro name' timeout (#44001)
* Fix 'macro name' timeout

Added function to send macro to device using 'sendonly'.

* Filter 'macro' from normal commands

* Removed white space

* Undefined variable 'cmd'
2018-08-30 18:11:51 +05:30
linnil1
d89a1be011 Fix bug of interface-mode in Junos (#44380)
* Fix bug of interface-mode in Junos

* Fix typo. Thanks webknjaz.
2018-08-30 18:10:58 +05:30
pierremahot
d11e078366 adding an option for the filter ipsubnet and testing (#40670)
* adding an option for the filter ipsubnet
2018-08-30 13:21:22 +01:00
Zim Kalinowski
bd866ed69a adding container registry facts (#43325) 2018-08-30 17:56:12 +08:00
Yunge Zhu
b731732616 add azure_rm_webapp_facts module (#43631)
* add webapp facts module

* remove certified

* remove useless argument

* add tests

* return curated output

* add description of return value, move test to webapp folder

* fix lint

* fix lint

* fix lint

* fix test

* fix bug

* fix test, will get all webapp with same tag created by previous test

* fix test

* fix test

* fix test

* add properties description, refine return name

* refine properties, add request_id when exception

* fix bug

* update doc, add publish profile

* fix error

* flatten properties, add option for return publish profile
2018-08-30 17:49:06 +08:00
gyurco
4ad7642ba0 mongodb_user: don't call buildInfo with Pymongo > 3.5 (#42350)
Bug: #35155
2018-08-30 03:01:28 -04:00
Jordan Borean
533656694e
win_disk_image: return all mount paths in return value (#44799) 2018-08-30 16:25:45 +10:00
Zim Kalinowski
78eb4724a0 Adding sql client to common (#44825) 2018-08-30 12:44:36 +08:00
ndswartz
b0cee34ca1 Fixed netapp_e_lun_mapping options for backwards compatibilitiy (#44769)
* Fixed netapp_e_lun_mapping options for backwards compatibility.

Readd lun and target_type as deprecated options.

Note: lun and target_type were removed in patch #44666 since they were
no longer needed for the logic in the module.  However, this cause will
cause existing playbooks utilizing these options to break.

* Add lun specification and target_type verification for netapp_e_lun_mapping
2018-08-30 05:35:57 +01:00
Lachlan Cooper
1e7ab24e40 Fix minor issues with docker_login docs (#35081)
* Fix typos in docker_login reauthorize parameter

* Remove note about docker_login email address

Docker Hub no longer requires an email address.

* Remove check for email parameter with Docker Hub

This is no longer required, so login should not fail if it's not provided.
2018-08-30 05:33:39 +01:00
Hai Cao
ccb7909cc5 [new module] Azure Traffic Manager profile module (#43812)
* add traffic manager client and models in azure_rm_common
- add traffic manager management client
- import traffic manager models to 'traffic_manager_models' proprety
- azure.mgmt.trafficmanager doesn't have models(), so use direct import
for now

* add traffic manager facts module

* add traffic manager module

* add integration test for two modules

* fix package info in requirements

* fix sanity check

* fix monitor config default value

* fix facts module doc

* move model import into module

* resolve comments except seprating endpoint

* remove endpoint operation

* fix test after removing endpoint operation

* change module name to azure_rm_trafficmanagerprofile/facts

* fix sanity test

* seperate endpoint into delegate module

* fix typo

* fix lint

* fix lint

* fix test

* fix test

* resolve comments

* fix test

* fix test

* fix test

* fix bug in return

* resolve comments

* fix lint

* fix lint

* add sample in endpoint module
2018-08-30 14:18:53 +10:00
lwm
fbcdf8ba5b Linode: Mark 'name' as required. Fixes #29785 (#44699)
* Mark 'name' parameter as required.

Closes https://github.com/ansible/ansible/issues/29785.

* Add the `linode-python` dependency for unit tests.

* Add unit test for linode name parameter.

* Add note about where to find required arguments.

Closes https://github.com/ansible/ansible/issues/44696.
2018-08-30 05:09:21 +02:00
newtonne
30fd326953 Various updates to macports module (#44605)
- Add support for installing specific variants of a port.
- Add support for using yaml lists with 'name' parameter, rather than comma-separated lists.
- Add to and clarify documentation and examples.
- Use Macports nomenclature:
  - s/package/port/g
  - Rename update_cache to sync_ports but keep update_cache as an alias. Remove undocumented update-cache alias.
  - Remove undocumented 'pkg' alias for 'name'. Replace with 'port' alias and document it.
- Print stdout and stderr output if `port sync` fails.
- Print stderr output, rather than stdout, if `port install/uninstall/activate/deactivate` fail.
2018-08-30 05:03:29 +02:00
Martin Adler
3c26616909 DNS made easy module: add sandbox parameter to utilize sandbox API (#44639)
* added sandbox param to switch between APIs

Signed-off-by: Martin Adler <1208749+EagleIJoe@users.noreply.github.com>

* Added warning as suggested
2018-08-30 04:35:57 +02:00
Felix Fontein
1dcf52c8fe docker_container: improving idempotency (#44808)
* Only handle cpu_shares, volume_driver, auto_remove as in _host_config().

* Don't compare log_options (resp restart_retries) if log_driver (resp restart_policy) is not specified.

* Warn that log_options (resp restart_retries) is ignored if log_driver (resp restart_policy) is not specified.
2018-08-29 21:07:32 -04:00
Felix Fontein
63fde92b60 Improve description of default network removal. (#44861) 2018-08-29 20:53:26 -04:00
Jasper Aorangi
2541a8c494 azure_rm_virtualmachine: Add 'accept_terms' for accepting terms when deploying paid marketplace images (#44701)
azure_rm_storageaccount: Add 'StandardSSD_LRS', and choices to correct unrelated sanity error
2018-08-29 17:14:44 -07:00
Tim Rupp
5bdcaff921
Various f5 fixes (#44858)
* Remove sdk from modules
* Correct IP address bugs in data_group
* Correct compare_dictionary bug in several modules
2018-08-29 16:08:37 -07:00
Constantin Bugneac
23adc3ecf1 added RETURN structure to _ec2_remote_facts.py (#26041) 2018-08-29 18:22:09 -04:00
Alex Stephen
56fa7eeb41 [gcp] gcp_compute_backend_service changes (#44796) 2018-08-29 16:41:37 -04:00
Alex Willmer
490c7e7b35 Clarify docs/examples of attribute removal (#35872)
If values="somestring" is specified then this module normalizes it to
["somestring"]. This means that passing name="foo", values="",
state=exact results in the ldap entry having a single attribute called
foo="".

To delete all attributes "foo", regardless of their values, it is
necessary to pass name="foo", values=[], state="exact".
2018-08-29 15:39:37 -05:00
Nathaniel Case
149aa767ff
Setting options is fine if plugins already exist (#44859) 2018-08-29 16:33:51 -04:00
Rémi REY
cd7c946ea5 modules/terraform: add support of backend configuration (#44860)
This patch adds a new `backend_config` parameter that allows to provide the
-backend-config parameter during the terraform init command.

The option allows to dynamically set the backend information, like the s3 bucket name
and statefile name.
2018-08-29 16:26:19 -04:00
Todd Walton
1247f4a464 Clarify docs re mode's octal representation (#44410)
* Clarify docs re mode's octal representation

I changed the language about how to use mode to make it more obvious
that using "01777" is not a typo, because the leading zero is not meant
to reflect the way that number might have been given on a command line.
See also: issues #5409 #9196 #11385 #13115 #18952 #23491 #23521
2018-08-29 15:12:32 -05:00
Matt Martz
d5ed818e7c
Make sure we skip handlers from includes in compile_roles_handlers. Fixes #44848 (#44852) 2018-08-29 15:05:55 -05:00
rgustomi
305ae5442a change docs for mime-type (#36693)
* change stat.py docs for mime-type

* corrects stat.py RETURN documentation for mimetype
2018-08-29 14:49:39 -05:00
Anil Kumar Muraleedharan
822dbe3016 Refactoring code to adhere to persistence connection. (#44398)
* Refactoring code to adhere to persistence connection.

* Update cnos_rollback.py

* Review comment of Qalthos incorporated

* Updating license for the refactored method

* Update cnos_rollback.py

* Removing the BSD License as suggested by Legal
2018-08-29 15:25:19 -04:00
Adrien Fleury
4249c5ca7f New module : tower_credential_type (#37243)
* Add new module *tower_credential_type*

* Add support for credential type creation and/or deletion
* Add test coverage for tower_credential_type
2018-08-29 11:01:19 -07:00
Adrien Fleury
aaa157f140 New module tower_workflow_template. (#37520)
* Add new module *tower_workflow_template*

Manage Tower workflows and their schemas.
2018-08-29 10:58:35 -07:00
Chris Archibald
7cded31ec9 Depreciate elementsw modules (#44792)
* rename deprecated files
2018-08-29 17:51:52 +01:00
Matt Martz
cd2f66f731
Don't allow import_tasks to transition to dynamic when file is missing. See #44822 (#44836) 2018-08-29 11:43:26 -05:00
Pilou
c07ba82d3e Scaleway inventory: allows to connect via private IP (#44342)
* scaleway inventory: remove useless duplicate

* scaleway inventory: allows to connect using private ip

ansible_host was hardcoded and it was not possible to connect using
private addresses.
This allows to define multiple host variables, values are templates
which can use hosts details send by API. For example this config file
use private address and defines two variables:

    plugin: scaleway
    hostnames:
      - hostname
    variables:
      ansible_host: private_ip
      state: state
      image: image.name
    regions:
      - ams1

inventory will looks like:

    {
        "_meta": {
            "hostvars": {
                "testhost": {
                    "ansible_host": "10.1.1.1",
                    "arch": "x86_64",
                    "commercial_type": "START1-M",
                    "hostname": "testhost",
                    "id": "af669464-0c74-4c89-8573-9fe763028448",
                    "image": "CentOS 7.4",
                    "organization": "2cc9a115-380d-4ac0-ba4b-8947eee71325",
                    "public_ipv4": "163.172.1.1",
                    "public_ipv6": "2001:bc8::1",
                    "state": "running",
                    "tags": [
                        "testtag"
                    ]
                }
            }
        },
        [...]
    }
2018-08-29 12:14:12 -04:00
Tim Rupp
de0acc9cfd
Deprecates bigip_gtm_facts (#44841)
The code to support these facts has been added to bigip_device_facts.
So it is no longer necessary to include this module.
2018-08-29 08:45:39 -07:00
Tim Rupp
817b74654f
Adds gtm facts to bigip_device_facts (#44842)
Merging in the gtm facts code to device facts
2018-08-29 08:45:29 -07:00
Ganesh Nalawade
eb9c75caad
Fix rollback option in cli_config module (#44834)
* Fix rollback option in cli_config module

* Update rollback flag in cliconf plugins
* Add rollback api for junos cliconf plugin

* Update doc

* Update doc
2018-08-29 21:00:11 +05:30
Jordan Borean
559599842a windows async: return pipeline output in case of a failure (#44807) 2018-08-29 16:13:31 +02:00
Anton Nikulin
40a97d43d1 New modules and updated HTTP API plugin for FTD devices (#44578)
* Add common and Swagger client utils for FTD modules

* Update FTD HTTP API plugin and add unit tests for it

* Add configuration layer handling object idempotency

* Add ftd_configuration module with unit tests

* Add ftd_file_download and ftd_file_upload modules with unit tests

* Validate operation data and parameters

* Fix ansible-doc, boilerplate and import errors

* Fix pip8 sanity errors

* Update object comparison to work recursively

* Add copyright
2018-08-29 15:48:10 +02:00
Tzur Eliyahu
c174b4b128 IBM_Storage: Added a module for managing IBM Spectrum Accelerate (#44166)
storage system pools
2018-08-29 13:42:10 +01:00
Tzur Eliyahu
0189db2aa5 IBM_Storage: Added a module to define hosts on IBM Spectrum Accelerate (#44365)
* IBM_Storage: Added a module to define hosts on IBM Spectrum Accelerate
storage systems.
2018-08-29 13:26:24 +01:00
Will Thames
b35ac8080f Change the return key of k8s_facts (#44446)
`items` is a *terrible* return key for ansible as Jinja
will often think it refers to the `items()` function.

Even though you can typically work around this with
`results['items']`, sometimes even that doesn't work:

```
- name: Resources should exist
  assert:
    that: item.status.phase == 'Active'
  loop: "{{ k8s_namespaces['items'] }}"
```

```
fatal: [testhost]: FAILED! => {"msg": "Invalid data passed to 'loop', it
requires a list, got this instead: <built-in method items of dict object
at 0x109dc9c58>. Hint: If you passed a list/dict of just one element,
try adding wantlist=True to your lookup invocation or use q/query
instead of lookup."}
```

Change it now while we still can.
2018-08-29 12:04:04 +01:00
Felix Fontein
1ef225601a Properly documenting environment variables in documentation fragment. (#44812) 2018-08-29 11:30:20 +01:00
denraf
bbb57f5a95 Set Default values correctly for docker variables (#42641)
* Set Default values correctly
2018-08-29 10:49:27 +01:00
Zim Kalinowski
ed2cd40a5b
adding new clients to common (#44804)
* adding new clients to common

* container registry and instance clients to the common

* fix problem
2018-08-29 13:52:18 +08:00
Tim Rupp
34b7b77bce
Deprecates bigip_facts (#44790)
This module has been superceded by the bigip_device_facts module
2018-08-28 18:29:23 -07:00
Jordan Borean
9d91607754
win_psexec: fix arg handling when command contains multiple args (#44797) 2018-08-29 10:12:29 +10:00
Charles
d5d2c80779 add win_wait_for_process (#40404)
* add win_wait_for_process

* try working on additional filter options and fix derps

* improve process name matching: support arrays. support pre and post wait

* use CIM instead of WIM.  requre exact contain process binary extension

* updates to metadata

* fix errors in waiting for process to start

* validate process min count for absent state.  fix typo

* fix bug if only one processes is detected

* address GitHub comments
2018-08-28 19:44:30 -04:00
Xyon
03261b3053 Add new session parameter to win_psexec (#44263)
* Add new session parameter to win_psexec

* Indicate which version the session option was added in

* Added changelog fragment and minor edit on doc entry
2018-08-29 09:42:59 +10:00
Yunge Zhu
2bd0a66c08 start/stop/restart azure webapp (#44498)
* add webapp start/stop/restart

* disable test with facts

* fix lint

* fix lint

* fix check mode

* rename power_action to app_state

* refine names of choices

* fix renaming bug
2018-08-29 07:41:11 +08:00
Chris Archibald
408868ed49 fix bug and documentation issue (#44793) 2018-08-28 18:32:44 -04:00
Dag Wieers
5e814d8d17 Fix support for JSON output when charset is set (#44762)
* Fix support for JSON output when charset is set

This fixes #41797

* Add specific exception to catch

* Add Changelog fragment
2018-08-29 08:10:46 +10:00
Adam Miller
1e3b927a73 Improve error condition handling for dnf module (#44770)
- Fix comma separated list handling for package names
- Fix error message for unavailable/unknown package install attempt
- Fix pkg install result output generation

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-28 17:44:46 -04:00
Chris Archibald
15886b1d56 Adding na_ontap_autosupport.py Module (#44178)
* Adding na_ontap_autosupport.py Module
2018-08-28 22:41:05 +01:00
Dag Wieers
f588b1cdf9 Fix issue when timeout and state=present (#43464)
* Fix issue when timeout and state=present

* added changelog fragment
2018-08-29 07:31:24 +10:00
Nathaniel Case
86f96d0212
Move plugin option settings. (#44774)
* Move plugin option settings.

* Add default value and clear after use.
2018-08-28 17:30:50 -04:00
Jordan Borean
0c3216c565 win_reboot: fix minor issues with the latest refactor (#44740)
* win_reboot: fix minor issues with the latest refactor

* Always return elapsed with win_reboot
2018-08-28 17:25:37 -04:00
Dag Wieers
7d51b2a6d2 Cross-reference win_reboot and reboot (#44784) 2018-08-28 17:10:25 -04:00
Matt Martz
113bdec2ed Fix subelements lookup docs example (#44782)
* Fix subelements lookup docs example

* Fix grammar
2018-08-28 16:52:07 -04:00
Rémy Léone
70adbb87d9 Added private_ipv4 to the hostvars in Scaleway dynamic inventory (#44122) 2018-08-28 16:35:38 -04:00
Rémy Léone
ea0f722d74 Fix verify_file check in Scaleway dynamic inventory (#44384) 2018-08-28 16:34:13 -04:00
Tim Rupp
47633b8d82
Adds provider connection for bigip_facts (#44785)
This is needed because this module will be deprecated and removed
*after* the args connection method is removed.
2018-08-28 13:31:33 -07:00
Tim Rupp
c19a4932eb
Remove f5-sdk usage (#44781)
This patch is part of an ongoing effort to remove the f5-sdk from
the f5 ansible modules for dependency reasons.
2018-08-28 12:18:28 -07:00
Daniel Nägele
edaa0b5245 ansible-pull: allow specifying --diff from check_opts cli flag group (#37645) 2018-08-28 15:15:14 -04:00
Piotr
966c87e111 ONTAP information gathering module (#43888)
* ONTAP information gathering module
2018-08-28 19:05:06 +01:00
René Moser
dd953dbe96
cs_template: implement update and revamp (#37015) 2018-08-28 19:55:21 +02:00
Tim Rupp
7f990cfc11
Removes invalid example (#44778)
The example included is currently invalid because the referenced
module is not in the upstream code.
2018-08-28 10:50:10 -07:00
Chris Archibald
adc5f0c89d Adding ontap_node.py Module (#44211)
* Adding ontap_node.py Module

* Change Short Description

* documentation changes
2018-08-28 18:41:49 +01:00
Chris Archibald
0f31111809 Adding ElementSW Snapshot Restore Module (#43973)
* Adding ElementSW Snapshot Restore Module
2018-08-28 18:41:02 +01:00
Chris Archibald
e2ae09117d Adding ElementSW Volume Clone (#43983)
* Adding ElementSW Volume Clone
2018-08-28 18:40:34 +01:00
Chris Archibald
ab9c4ab82d Adding ontap_cluster_peer.py Modules (#44189)
* Add ontap_cluster_peer.py Modules
2018-08-28 18:39:59 +01:00
Michael Price
70fd1ec130 Define module for NetApp E-Series iSCSI targets (#40632)
Create a new module for managing E-Series iSCSI targets.
2018-08-28 18:38:43 +01:00
Tim Rupp
f383826d76
Corrects downstream bugs in static-route module (#44775) 2018-08-28 10:28:11 -07:00
Felix Fontein
ed22efb2a6 Clarify that uninstalling docker-py can break docker (and vice versa). (#43238) 2018-08-28 17:53:43 +01:00
ndswartz
d31e25acbd Define netapp_e_mgmt_interface storage module. (#42519)
* Define netapp_e_mgmt_interface storage module.

The netapp_e_mgmt_interface module provides management configuration for
e-series storage array interface points including remote ssh access, NTP
and DNS services.

This patch also includes integration and unit tests.

* Fix netapp_e_mgmt_interface ssh option documentation and name/channel exclusivity.
2018-08-28 17:50:21 +01:00
Chris Archibald
26545ecac9 Adding ElementSW Drive Module (#43968)
* Adding ElementSW Drive Module
2018-08-28 17:43:10 +01:00
Michael Price
054b87acb8 Define module for managing E-Series email alerts (#42643)
Email alerts can be enabled for an E-Series system to provide
information to interested users by email when a warning or critical
level event occurs on the system. This module will allow a system owner
to configure whether or not system alerts are enabled, and who will
receive them.
2018-08-28 17:40:51 +01:00
Michael Price
97157cf876 New module for managing NetApp E-Series iSCSI Interfaces (#39877)
* New module for NTAP E-Series iSCSI Interfaces

Define a new module for configuring NetApp E-Series iSCSI interfaces.

* Improve netapp_e_iscsi_interface integration tests

Restructured integration test to set all iscsi ports to disabled, then
defines the ports either statically or with dhcp, next updates the ports
with the other definition type (static <-> dhcp), and lastly disables
all ports.  Each netapp_eseries_iscsi_interface call is verified with the
array.
2018-08-28 17:39:14 +01:00
Alex Stephen
d38bccfc3e New GCP Module: gcp_compute_router (#42796) 2018-08-28 12:35:20 -04:00
Yoan Blanc
cf61510f48 cs instance root_disk size update resizes the root volume (#43817)
* cloudstack: resize volume on root_disk_size changes

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
Reviewed-by: Marc-Aurèle Brothier <m@brothier.org>

* fixup! cloudstack: resize volume on root_disk_size changes

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

* fixup! fixup! cloudstack: resize volume on root_disk_size changes

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>

* cs_instance: rename flag to allow_root_disk_shrink

Signed-off-by: Yoan Blanc <yoan.blanc@exoscale.ch>
2018-08-28 12:19:43 -04:00
Michael Price
f781f341a2 Define NetApp E-Series ASUP module (#41153)
* Define NetApp E-Series ASUP module

ASUP, or Auto-Support, is a mechanism that allows NetApp support
to receive information on the status of E-Series storage-systems
in order to proactively resolve issues for customers. This module
gives customers the ability to tune ASUP settings to their liking,
including disabling the feature entirely.

* Improved testing for netapp_e_asup module

Added coverage and validation to asup integration and unit testing
2018-08-28 17:05:25 +01:00
Jasper Aorangi
56ea56f2b5 azure_rm_networkinterface: Feature/dns servers (#43588)
* Working through tests and fixing dumb mistakes

* Fix sanity issues and tests. All G

* Correct type test for azure_rm_networkinterface

* azure_rm_networkinterface correct type comparison

* Post rebase cleanup

* Remove erroneous reference to dns_servers
2018-08-28 08:59:45 -07:00
Alex Stephen
0972d37872 New GCP Module: gcp_spanner_database (#42799) 2018-08-28 11:58:33 -04:00
Alex Stephen
48de2cf214 New GCP Module: gcp_spanner_instance (#42800) 2018-08-28 11:57:59 -04:00
Alex Stephen
6d548d405b New GCP Module: gcp_sql_user (#42803) 2018-08-28 11:57:36 -04:00
Alex Stephen
e9c9ccc561 Bug fixes for gcp_dns_resource_record_set (#42832) 2018-08-28 11:56:43 -04:00
Alex Stephen
473b6dbe8a New GCP Module: gcp_sql_instance (#42802) 2018-08-28 11:56:13 -04:00
Alex Stephen
26cf8fafb5 New GCP Module: gcp_sql_database (#42801) 2018-08-28 11:55:44 -04:00
curry9999
aeed9255ba We modified the examples argument. (#44759)
<!--- Your description here -->

+label: docsite_pr
2018-08-28 08:48:23 -07:00
Chris Archibald
f101cb0226 Adding na_ontap_disks.py Module (#44192)
* Adding na_ontap_disks.py Disk
2018-08-28 16:43:55 +01:00
Piotr
5d31c5b2c6 na_ontap_motd module added (#44756)
* state=present is now default

* assign whole params dictionary to a single variable
2018-08-28 16:42:37 +01:00
Chris Archibald
61d8266442 Adding ontap_firewall_policy.py Module (#44198)
* Adding ontap_firewall_policy.py Module
2018-08-28 16:02:05 +01:00
Michael Price
1f2ae0d4cd Define a module for managing E-Series settings (#41010)
There are multiple settings that are defined at a global level for
E-Series systems, but don't necessarily fit with anything else. This
module is intended to provide a place to encapsulate those.
2018-08-28 15:38:53 +01:00
Chris Archibald
fe14781a46 Add ontap_command.py Module (#44190)
* Add ontap_command.py Module
2018-08-28 15:32:48 +01:00
Chris Archibald
45e7b2da98 Adding ElementSW Snapshot Module (#43972)
* Adding ElementSW Snapshot Module
2018-08-28 15:27:44 +01:00
Chris Archibald
c29acc7ee1 Adding ElementSW Node Module (#43971)
* Adding ElementSW Node Module
2018-08-28 15:27:09 +01:00
Chris Archibald
6b0fa954f4 Adding ElementSW Network Interfaces Module (#43970)
* Adding ElementSW Network Interfaces Module
2018-08-28 15:26:18 +01:00
Chris Archibald
12c7656268 Adding ElementSW Cluster Module (#43965)
* Adding ElementSW Cluster Module
2018-08-28 15:22:20 +01:00
Chris Archibald
09c7d1c4b9 Adding ElementSW check Connection Module (#43963)
* Adding ElementSW check Connections Module
2018-08-28 15:21:45 +01:00
Chris Archibald
9acbd81e02 Adding ElementSW Admin users Module (#43959)
* Adding ElementSW Admin users Module
2018-08-28 15:19:52 +01:00
Trishna Guha
1e7c745a5c
fix rollback option vyos cliconf (#44763)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-28 19:49:25 +05:30
Chris Archibald
1377019951 Adding ElementSW account Module (#43958)
* Adding ElementSW account Module
2018-08-28 15:19:11 +01:00
Chris Archibald
6d592dc505 adding ElementSW access group module (#43957)
* adding access group

* Change short description
2018-08-28 15:18:18 +01:00
Abhijeet Kasurde
fe8af27e5d
VMware: new module: vmware_host_ntp_facts (#44306)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-28 06:25:46 -07:00
ndswartz
cf41415bdf Define netapp_e_auditlog storage module. (#42535)
This module allows NetApp E-Series storage system's audit-log feature to be configured.
2018-08-28 14:11:33 +01:00
ndswartz
7eda94dc8d Defined netapp_e_syslog storage module (#42421)
Module allows syslog server configuration on NetApp E-Series storage arrays.
2018-08-28 13:22:36 +01:00
Michael Price
feb212b0a1 Define module for managing LDAP for E-Series (#42356)
This module will allow users to manage LDAP authentication domains for
accessing E-Series systems.
2018-08-28 13:00:19 +01:00
Milan Zink
2fab2d5775 Fixing missing modify_client_match function and get_export_policy_rule function logic (#44164) 2018-08-28 12:25:16 +01:00
ndswartz
06a5e6ae0f Improve netapp_e_lun_mapping module and documentation (#44666) 2018-08-28 12:13:32 +01:00
Felix Fontein
fabba43da7 docker_container: fix check mode for container creation (#42380)
* Create copy of HostConfig object before adding it to results.

* Create general sanitize function in docker_common. Using it for all return values of docker_container.

* Make Python 2.6 compatible.
2018-08-28 12:03:33 +01:00
Chris Archibald
047fddfe86 Adding ElementSW Ldap Module (#43969)
* Adding ElementSW Ldap Module
2018-08-28 11:45:57 +01:00
Simon Dodsley
86b72d1c8c Add QoS support for purefa_facts module and fix to support vVols (#42919) 2018-08-28 11:36:52 +01:00
Simon Dodsley
9bf12ee1c0 Add new Pure Storage module to discover facts for FlashBlade (#41673)
Facts that can be discovered are:
- all
- minimum
- config
- performance
- capacity
- network
- subnets
- lags
- filesystems
- snapshots
2018-08-28 11:35:25 +01:00
Jean-Bernard Jansen
390a08c781 azure_rm_virtualmachine : fix support for existing machines provisioned with a managed image (#32984) 2018-08-28 17:33:16 +08:00
Yunge Zhu
d5cbb53f5a fix linux webapp java framework bug (#44753)
* fix linux web app java linux_fx_version

* fix lint

* fix test

* resolve comments
2018-08-28 15:55:19 +08:00
Trishna Guha
8a79d944a3
nxos_system idempotence fix (#44752)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-28 12:05:19 +05:30
Zim Kalinowski
289be02224 Revert "fix linux web app java linux_fx_version (#44715)" (#44750) 2018-08-28 14:32:40 +08:00
Toshio Kuratomi
a11cc4bae9 Add post modifier to version 2018-08-27 23:18:38 -07:00
Go.YAMADA
e3dedb8df5 add_evaluation_delay of datadog monitor (#32784)
* add_evaluation_delay of datadog monitor

* fix version number

* fix version number

* update version num
2018-08-28 08:03:56 +02:00
Yunge Zhu
661172ab40
fix linux web app java linux_fx_version (#44715) 2018-08-28 13:14:11 +08:00
Toshio Kuratomi
f1c31cd592 Fix release to be correct 2018-08-27 21:58:09 -07:00
jainnikhil30
884c74a6c5 Add 'tower_settings' module for managing Ansible Tower Settings (#43933)
* add the tower_settings module
2018-08-27 21:42:38 -07:00
Will Thames
b8907ff09e
k8s_facts should not throw exceptions when not found (#44429)
Handle the case where a resource is not found by catching
the exception and returning an empty result set.
2018-08-28 12:51:26 +10:00
Anna Wiggins
5172bb068e Correct documentation for deployment_mode flag (#25978) 2018-08-27 19:05:31 -05:00
Tim Rupp
d12a045847
Adds metadata annotation that resource is managed by ansible (#44737)
Adds annotation so that other f5 utilities do not clobber config
by accident
2018-08-27 15:33:56 -07:00
Tim Rupp
0dacc606b4
Various fixes for f5 modules (#44734)
A number of bugfixes for the remaining 2.7 work on the F5 modules.
2018-08-27 14:09:03 -07:00
Adam Miller
0d5390a919 fix yum install with disablerepo (#44735)
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-27 17:06:06 -04:00
Michael Price
f89374bf6d Update the ignore and doc_fragments for E-Series
Make the generic updates to remove unneeded ignores and improve the
documentation for the NetApp E-Series modules.
2018-08-27 13:52:58 -07:00
Tim Rupp
c7eeb37f64
Adds bigip_software_install module (#44733)
This module can be used to install existing images on a bigip.
2018-08-27 12:56:19 -07:00
Christian Kotte
fc64ce3e0c Fix systemd service is already masked issue (#44730)
* Check if service is already masked

Newer versions of Systemd now report a 'LoadError' when the unit file
is masked. This causes the play to fail with an error stating that the
service is already masked.

Now the systemd module checks if the service is masked and doesn't
fail if it's masked and LoadError is reported.

Fixes issue #42384.

* Remove useless parens
2018-08-27 15:13:35 -04:00
Brian Coca
4dea9d84ed fix issue with no_log in py3
the error percolates differently from undefined vars in jinja2,
so fallback to use play_context as it is not involved in current templating
2018-08-27 11:57:02 -07:00
Rémi REY
26be68dd1c modules/terraform: Quote the variable values in the command line (#43493)
* modules/terraform: Quote the variable values in the command line

Fixes: #43492

* fix six import
2018-08-27 14:38:21 -04:00
Adam Miller
397febd343 YUM4/DNF compatibility via yum action plugin (#44322)
* YUM4/DNF compatibility via yum action plugin

DNF does not natively support allow_downgrade as an option, instead
that is always the default (not configurable by the administrator)
so it had to be implemented

 - Fixed group actions in check mode to report correct changed state
 - Better error handling for depsolve and transaction errors in DNF
 - Fixed group action idempotent transactions
 - Add use_backend to yum module/action plugin
 - Fix dnf handling of autoremove (didn't used to work nor had a
   default value specified, now does work and matches default
   behavior of yum)
 - Enable installroot tests for yum4(dnf) integration testing, dnf
   backend now supports that
 - Switch from zip to bc for certain package install/remove test
   cases in yum integration tests. The dnf depsolver downgrades
   python when you uninstall zip which alters the test environment
   and we have no control over that.
 - Add changelog fragment
 - Return a pkg_mgr fact if it was not previously set.
2018-08-27 10:17:47 -07:00
Matthias Fuchs
7871027c9d Share the implementation of hashing for both vars_prompt and password_hash (#21215)
* Share the implementation of hashing for both vars_prompt and password_hash.
* vars_prompt with encrypt does not require passlib for the algorithms
  supported by crypt.
* Additional checks ensure that there is always a result.
  This works around issues in the crypt.crypt python function that returns
  None for algorithms it does not know.
  Some modules (like user module) interprets None as no password at all,
  which is misleading.
* The password_hash filter supports all parameters of passlib.
  This allows users to provide a rounds parameter, fixing #15326.
* password_hash is not restricted to the subset provided by crypt.crypt,
  fixing one half of #17266.
* Updated documentation fixes other half of #17266.
* password_hash does not hard-code the salt-length, which fixes bcrypt
  in connection with passlib.
  bcrypt requires a salt with length 22, which fixes #25347
* Salts are only generated by ansible when using crypt.crypt.
  Otherwise passlib generates them.
* Avoids deprecated functionality of passlib with newer library versions.
* When no rounds are specified for sha256/sha256_crypt and sha512/sha512_crypt
  always uses the default values used by crypt, i.e. 5000 rounds.
  Before when installed passlibs' defaults were used.
  passlib changes its defaults with newer library versions, leading to non
  idempotent behavior.

  NOTE: This will lead to the recalculation of existing hashes generated
        with passlib and without a rounds parameter.
        Yet henceforth the hashes will remain the same.
        No matter the installed passlib version.
        Making these hashes idempotent.

Fixes #15326
Fixes #17266
Fixes #25347 except bcrypt still uses 2a, instead of the suggested 2b.

* random_salt is solely handled by encrypt.py.
  There is no _random_salt function there anymore.
  Also the test moved to test_encrypt.py.
* Uses pytest.skip when passlib is not available, instead of a silent return.
* More checks are executed when passlib is not available.

* Moves tests that require passlib into their own test-function.

* Uses the six library to reraise the exception.

* Fixes integration test.

When no rounds are provided the defaults of crypt are used.
In that case the rounds are not part of the resulting MCF output.
2018-08-27 08:40:41 -07:00
Rafael
ad993ca734 one_host environment variables, Fixes #44163 (#44568)
* including test case using environment variables as per issue #44163

* including missing environment variable in shared documentation fragement, related to issue #44163

* fixes parameters via environment variables, issue #44163
2018-08-27 10:55:04 -04:00
Chris Adams
23eb4f2093 ec2: add "IAM Role" to instance_profile_name
The AWS API and console docs are inconsistent about whether EC2 instances have IAM profiles or roles. Things which follow the API tend to use profile but the console uses “IAM Role”. This adds that term to the help text so it's searchable.

+label: docsite_pr
2018-08-27 10:06:15 -04:00
Dennis Israelsson
49f692b08f ios_vrf speed fix (#43765) 2018-08-27 08:51:33 -04:00
lolcube
1fac494d8c fix typo (#44712) 2018-08-27 14:35:53 +02:00
Trishna Guha
79a020e312
junos cli_config idempotence fix (#44706)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-27 12:40:16 +05:30
Charles
a7f35e232e Switch to LiteralPath instead of Path. Closes #44508 (#44509)
* Switch to LiteralPath instead of Path. Closes #44508

* add changelog fragment

* fix line endings and remove final empty line

* Minor text changes in changelog
2018-08-27 16:18:45 +10:00
Daniel-Sanchez-Fabregas
af49627a08 Module win_domain_computer fix delete computer with child (#44500)
* Module win_domain_computer fix delete computer with child

* add changelog fragment
2018-08-27 15:54:16 +10:00
Felix Fontein
fadf8a2d09 ACME: improve documentation (#44691)
* Override description for account_key_src and account_key_content to also mention private_key_*.

* Convert generic OpenSSL/cryptography remark from description to note.

This avoids the whole description list to be sorted alphabetically, which will be done by plugin_docs.py in case description is mentioned in both module fragment and module itself.

* Moving more notes to the notes: section.

* Uniformization of first paragraph. Mainly mention ACME supporting CAs, and only then mention Let's Encrypt as one of them.

* Adjusting to current drafts.

* Adjusting to updated drafts.

* Harmonizing short module descriptions.

* Referencing helper modules.

* Move general Let's Encrypt remark to doc fragment.

* Changing some Let's Encrypt references to more generic statements.
2018-08-26 22:46:55 +02:00
Abhijeet Kasurde
70d7513542
IPA: Add option to specify timeout (#44572)
This fix allows user to specify idle timeout for fetch_url used
internally in IPA connection and post_json call.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-26 23:18:46 +05:30
coreywan
50750c7363 Added nios_txt_record module (#39264)
* Added nios_txt_record module

Whitespace cleanup and version fix

First stab at txt record integration test

Fix for CI version requirement

Added nios_txt_record module

Whitespace cleanup and version fix

First stab at txt record integration test

Fix for CI version requirement

force re-run

* added alias for cloud group1
2018-08-26 12:25:16 +00:00
Tim Rupp
24a379f0b7
adds the bigip_cli_script module (#44674)
This module can be used to manage tmsh cli scripts on a BIG-IP
2018-08-24 22:08:37 -07:00
Dag Wieers
b6b36276a4 Clean up BOTMETA.yml (#44574)
This PR includes:
- Removal of maintainers that are listed as author in the module
- Removal of entries that do not extend the original author list
- Move ignored-statement to namespace/directory (where useful)
- In some cases, fix the authors-list or add missing github id

We end up with a list of exceptions/additions and a large set of
namespace/directory maintainers or team of maintainers.

Some entries could be further improved by discussing with some
maintainers.
2018-08-24 19:43:35 -04:00
Toshio Kuratomi
0873d46617 Fix ansible-doc and docsite generation for removed modules
* Fix ansible-doc wrt removed modules
  * Fix listing of modules ia ansible-doc to not complain about removed modules
    Removed modules are marked as such in the metadata but nowhere else.
    Need to retrieve the metadata when a module doesn't have a doc so that
    we can tell if it falls under this case.
  * omit removed modules from json dump
  * Print an error that the module has been removed if attempting to run
    ansible-doc on that specific module

* Get plugin_formatter to stop outputting removed modules
2018-08-24 15:37:13 -07:00
Toshio Kuratomi
b2932a41b0 Fixup removed and deprecated modules
* Removed modules no longer have documentation
  Decided this was causing people to think that modules were supported
  even after being removed.  This change is a new strategy to have the
  error message trying to use a removed module point people to the older
  documentation.

* Add stubs for modules removed in 2.7
  These are freshly removed so we want people who are still using them
  when they upgrade Ansible to have a hint as to where to find information
  on how to port.

* Finish properly undeprecating include
  include was undeprecated earlier but not all of the pieces that marked
  it as deprecated were reverted.  This change fixes the remaining
  pieces
2018-08-24 15:37:13 -07:00
Toshio Kuratomi
55503004ec Fix recursive_finder so it doesn't re-read files multiple times
This closes a corner case where recursive_finder could read a file
multiple times.
2018-08-24 15:37:13 -07:00
Toshio Kuratomi
14b3ae1120 Fix new AnsiballZ code to always include module_utils/basic
The AnsiballZ optimization which only uses one pyton interpreter
currently monkeypatches the arguments into a global argument in module_utils
so we need to always include basic.py.  In the future we should fix this
so that it monkeypatches its own file.  That way we won't need to always
include basic.py
2018-08-24 15:37:13 -07:00
vista-
f29ef1fc11 Add example for configuration item deletion (#44390) 2018-08-24 16:13:10 -04:00
Tim Rupp
79153b95e5
Adds params to the profile-client-ssl module (#44656)
This patch adds new parameters to the client ssl module.
2018-08-24 15:51:24 -04:00
Ryan S. Brown
990e95eb57 Fix ec2_instance synopsis. Fixes #44641 2018-08-24 15:44:28 -04:00
Dario Zanzico
d0bf38ab6a New module: docker_swarm_service (#19229) 2018-08-24 15:40:40 -04:00
Tim Rupp
ee1b899b18
Adds AS3 module (#44655)
This adds the as3 module for bigip to ansible.
2018-08-24 15:12:23 -04:00
Tim Rupp
cd2a3eb1ea
Removes more netaddr deps (#44657)
Removed dependency from bigip_snat_pool
2018-08-24 14:52:48 -04:00
Tim Rupp
f3a61dd93d
Adds aliases parameter to gtm wide ip (#44652)
This parameter can assign aliases to a wide ip.
2018-08-24 14:38:41 -04:00
Tim Rupp
73c97cb779
Adds parameters and removes netaddr dependency (#44654)
several new parameters added to bigip_node and the netaddr dependency
has been removed.
2018-08-24 14:38:23 -04:00
Tim Rupp
b5d45bdd1a
Refactors bigip_iapp_service and adds params (#44653)
Module was refactored to look like other f5 modules. also added new
params.

* decription
* device_group
* metadata
2018-08-24 14:38:13 -04:00
Tim Rupp
2930b28247
Adds new params to gtm server module (#44650)
Parameters to support iquery options were added.
2018-08-24 14:09:20 -04:00
Tim Rupp
7e6fbb3f8b
Adds params and remove netaddr (#44648)
This patch adds new parameters to the vcmp guest module and removes
the netaddr python dependency
2018-08-24 13:58:49 -04:00
Tim Rupp
e4af3e7b4d
Misc fixes (#44649)
Correcting docs and adding a Parameters handler for description
2018-08-24 13:58:25 -04:00
Tim Rupp
639cfe3b6f
Refactors device group (#44599)
Make module use patterns that other modules use
2018-08-24 13:58:12 -04:00
Aren
9db3e597f3 state: present added in docs (#37197)
* state: present added in docs

* atomic_container.py docs now match argspec, enforce test
2018-08-24 12:22:18 -05:00
Sloane Hertel
d3f5238c09
Fix dangerous elb_application_lb state (#44646)
* elb_application_lb: fix dangerous default of deleting an ELB if state is omitted by changing state to default to present to be more like other AWS modules
2018-08-24 13:04:15 -04:00
Shuang Wang
b03feb6d40 Implement part of #27617 [expend checksum format to <algorithm>:(<checksum>|<url>)] (#43751)
* expend checksum format to <algorithm>:(<checksum>|<url>)

* continue to code at office

* ALPHA - expend checksum format to <algorithm>:(<checksum>|<url>)

* clean up tmpfile and comment

* try to add test code for 27617

* try to add test code for 27617

* try to add test code for 27617

* try to fix [Could not find or access 'testserver.py']

* fix test code [Could not find or access 'testserver.py']

* fix test code [add files dir]

* fix test code [files dir not exists]

* as [connection was closed before a valid response was received]

* [connection was closed before a valid response was received]

* [connection was closed before a valid response was received]

* add test item [sha1 and sha256]

* since [connection was closed before a valid response was received]

* fix [connection was closed before a valid response was received]

* fix test code typo

* add docs for #27617

* PR #43751 is minor change

* fix pep8 issue.

* fix test code style.

* fix unexpected quote
2018-08-24 12:45:32 -04:00
Chris Archibald
3820c3351b Adding ElementSW Backup Module (#43960)
* Adding ElementSW Backup Module
2018-08-24 17:23:03 +01:00
Chris Archibald
319bd2de5f Adding ElementSW Cluster Pair Module (#43967)
* Adding ElementSW Cluster Pair
2018-08-24 17:21:52 +01:00
Chris Archibald
448db900dd Adding ElementSW SnapShot Schedule Module (#43974)
* Adding ElementSW SnapShot Schedule Module
2018-08-24 17:18:02 +01:00
Chris Archibald
d7efcc4161 Adding ElementSW Vlan Module (#43981)
* Adding ElementSW Vlan Module
2018-08-24 17:16:51 +01:00
Chris Archibald
790e19804b Adding ElementSW Volume Module (#43982)
* Adding ElementSW Volume Module
2018-08-24 17:16:07 +01:00
Yanis Guenane
03e3a0b202 scaleway: Introduce scaleway_organization_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane
809aa2d767 scaleway: Introduce scaleway_snapshot_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane
2cfcfd6dc9 scaleway: Introduce scaleway_server_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane
5c65ba62aa scaleway: Introduce scaleway_ip_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane
d62f63b680 scaleway: Introduce scaleway_image_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane
e4e6569cc9 scaleway: Introduce scaleway_volume_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane
4bdec575c0 scaleway: Introduce scaleway_security_group_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Rémy Léone
8f9d55529d scaleway: Refactor modules 2018-08-24 18:15:45 +02:00
Yanis Guenane
29cfebe332 scaleway: Create a base class for all the modules
Purpose of this commit is to create a base class for the upcoming
scaleway module to use.

Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Chris Archibald
caeae632ba Adding ElementSW Volume Pair (#43984)
* Adding ElementSW Volume Pair
2018-08-24 16:30:15 +01:00
Chris Archibald
54c526991a Adding ontap_cg_snapshot.py Module (#44181)
* Adding ontap_cg_snapshot.py Module

* Fix issues
2018-08-24 16:29:21 +01:00
Chris Archibald
ea5a455656 Adding ontap_dns.py Module (#44193)
* Adding ontap_dns.py Module

* Change Short Description
2018-08-24 16:23:34 +01:00
Chris Archibald
3c69ad7104 Adding ontap_fcp.py Module (#44197)
* Adding ontap_fcp.py Module
2018-08-24 16:21:33 +01:00
Chris Archibald
b85458d8ba Adding ontap_snapmirror.py Module (#44215)
* Adding ontap_snapmirror.py Module
2018-08-24 16:02:35 +01:00
Chris Archibald
d6e74adbf5 Adding ontap_software_update.py Module (#44218)
* Adding ontap_software_update.py Module
2018-08-24 16:01:37 +01:00
Chris Archibald
0534b7ad38 Adding ontap_svm_options.py Module (#44220)
* Adding ontap_svn_options.py Module
2018-08-24 15:58:45 +01:00
Michael Price
ad91793428 Resolve issues in NetApp E-Series Host module (#39748)
* Resolve issues in NetApp E-Series Host module

The E-Series host module had some bugs relating to the update/creation
of host definitions when iSCSI initiators when included in the
configuration. This patch resolves this and other minor issues with
correctly detecting updates.

There were also several minor issues found that were causing issues with
truly idepotent updates/changes to the host definition.

This patch also provides some unit tests and integration tests to help
catch future issues in these areas.

fixes #28272

* Improve NetApp E-Series Host module testing

The NetApp E-Series Host module integration test lacked feature test
verification to verify the changes made to the storage array.

The NetApp E-Series rest api was used to verify host create, update, and
remove changes made to the NetApp E-Series storage arrays.
2018-08-24 15:44:59 +01:00
Pierre Gaxatte
3122860f22 Update os_server docs when removing an instance (#41963)
When removing an instance via its ID, it is not clearly explained that one should use the `name` parameter.

Also a simple example is provided.

+label: docsite_pr
2018-08-24 10:42:25 -04:00
njferrant
507d6e241e NetApp: return lun info for na_ontap_lun_map module (#42961)
* return lun details for na_ontap_lun_map

return lun details for na_ontap_lun_map.py and added return value documentation
2018-08-24 15:37:28 +01:00
Victor da Costa
53405f673c friendly message when requirement is not installed (#42321)
* friendly message when requirement is not installed
2018-08-24 15:08:24 +01:00
Dag Wieers
86147d598f Various improvements to script module docs (#44637)
This PR includes:
- Use uppercase in descriptions
- Add trailing dot to descriptions
- Grammar/spelling fixes
- Adding names to examples as a best practice
- Simplify structure
2018-08-24 09:56:44 -04:00
Chris Coley
ce5530e08d Fix incorrect default value for shutdown_command (#44607) 2018-08-24 09:51:14 -04:00
Yanis Guenane
9869f378fd inventory/vultr: Few minor improvements (#44622) 2018-08-24 15:35:29 +02:00
Yuma Inaura (稲浦悠馬)
34c582287a Fix script module document (#42778)
script module seems does not create / remove files
it seems only checks file existence or not existence


+label: docsite_pr
2018-08-24 14:59:04 +02:00
linnil1
1651483e44 [Junos] Add l3-interface option for vlan (#43863)
* [Junos] Add l3-interface option for vlan

* Add version_added for new option
2018-08-24 18:06:27 +05:30
Ganesh Nalawade
b454fbe684
Update netconf_config module doc and return diff (#44634)
* Update netconf_config module doc
* Return santizied before and after config
  in diff key
2018-08-24 17:57:12 +05:30
Ganesh Nalawade
d20b4ee56a
Fix netconf_config source option issue (#44630) 2018-08-24 17:01:48 +05:30
Alex Mayer
e4e45a419a Firewalld: Switch "true" To "yes" In Examples (#44588)
Matches documentation section values
Make module examples more consistent with core modules
2018-08-24 10:17:56 +02:00
Abhijeet Kasurde
f59d189d02 Minor typo fix in package module documentation (#44617)
Added missing round bracket

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-24 10:14:58 +02:00
Samer Deeb
a07af2a1f7 issue:43021 add support for onyx version 3.6.6000 and above (#44527)
* issue:43021 add support for onyx version 3.6.6000

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* issue:43021 add support for onyx version 3.6.6000

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-08-24 07:59:10 +01:00
Ondra Machacek
56b9823bb8 ovirt_vm: Fix undefined variable (#44618)
Fix unassigned variable while suspending vm.
2018-08-24 02:29:02 -04:00
Abhijeet Kasurde
33f5b1aa0f
VMware: new module: vmware_local_role_facts (#44553)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-24 10:00:40 +05:30
Toshio Kuratomi
f46c943d3d Fix another corner case of too many warnings for world readable current working directory
There should be no warning if there is no ansible.cfg file i nthe
current working directory.
2018-08-23 20:23:59 -07:00
Sam Doran
4d9218cec4 Add reboot action plugin (#35205)
* Update docs

* Add reboot action plugin

Refactor win_reboot so it is subclassed from reboot

* Use new connection methods

* Test fixes

* Use better uptime command for Linux

Use who -b to get the last time the system was booted rather than uptime, which changes every second.

* Use distribution specefic commands and flags

Query the managed node to determien its distribution, then set the appropriate command and flags.

* Tune debug messages a bit

* Update module docs with details about pre_reboot_delay

s docs

* Ensure that post_reboot_delay is a positive number

* Remove the stringification

* Add integration tests

* Make sure aliases are honored

* Handle systems that have an incorrect last boot time

SystemD and fakehw-clock do not properly set the
last boot time and instead always set it to epoch.
Use a different command if that is the case.

* Copyright and encoding fixes

* Minor fixes based on feedback

* Add exponential backoff to sucess check method

* Update integration test

Skip the integration test if it would try to reboot the control node. We need a new mechanism to account for this scenario in ansible-test, so tests must currently be run manually for this plugin.

* Update integration test

Skip the integration test if it would try to reboot the control node. We need a new mechanism to account for this scenario in ansible-test, so tests must currently be run manually for this plugin.

* Fail early with running with local connection

* Update docs based on feedback

* minor refactoring, state mgmt changes
2018-08-23 18:12:12 -07:00
Will Thames
60e3af42d5 sns_topic boto3 port (#39292)
* Port sns_topic to boto3 and add tests
2018-08-23 21:04:18 -04:00
Stephen SORRIAUX
a78cc15099 Add new parameters to manage mtime and atime for file module, fixes #30226 (#43230)
* Add new parameters related to mtime and atime for file module, fixes #30226
2018-08-23 17:20:54 -07:00
Balthazar Rouberol
1b3f074ec6 Change DataDog to Datadog (#34273) 2018-08-23 20:20:29 -04:00
Brian Coca
9cc56981b5
Add new host_pinned strategy (#44586)
The 'free' strategy still attempts to do all hosts per task before going to the next, it just doesn't wait for slow hosts,
This strategy processes each host as fast as possible to the end of the play before trying to process another host in the pool.
2018-08-23 20:16:32 -04:00
Matt Clay
3fb5056606 Fix PEP8 issue. 2018-08-23 16:43:59 -07:00
Sloane Hertel
79ecb4c41f
Add diff mode for ec2_group (#44533)
* Add (preview) diff mode support ec2_group

* Add diff mode to some ec2_group integration tests

* Remove unnecessary arguments and add comment to the module notes

* Add changelog
2018-08-23 19:43:18 -04:00
Sloane Hertel
b152515fcb RDS inventory plugin (#41919)
Comments out uses of rds_instance in the integration tests and replace with AWS CLI until rds_instance has been merged
2018-08-23 19:42:32 -04:00
Dag Wieers
3d70274864
Added an async 'started' test (like 'finished') (#43445) 2018-08-24 01:29:34 +02:00
Dag Wieers
cc2164f92a
ACI: Add specific info about running locally (#43903)
Since the ACI modules (like most network-related modules) run on the
local controller, this PR adds the necessary details so users are aware
of this particular feature.
2018-08-24 01:28:39 +02:00
Matt Martz
242e9229a1
Pin deprecation of tags in params for include to deprecation of include (#44596) 2018-08-23 16:25:33 -05:00
Felix Fontein
0e6234ab04 Adding module which allows to complete certificate chains (#44169)
* Adding certificate_complete_chain module.

* Avoid code smell errors.

* Removing input_chain_src.

* Make sure line ending is there.
2018-08-23 23:18:36 +02:00
Yanis Guenane
72d4880b85 Vultr: Introduce the Vultr inventory plugin (#44400)
This commit introduce the Vultr inventory plugin.
2018-08-23 23:14:26 +02:00
Tim Rupp
14909e76ec
Adds features to device connectivity (#44598)
Adds new parameter and removes f5-sdk
2018-08-23 17:08:28 -04:00
Tim Rupp
9c12d845ab
Removes f5-sdk code from bigip modules (#44595)
This patch is part of an ongoing effort to fully remove the f5sdk
from the f5 modules.
2018-08-23 16:53:34 -04:00
GElkayam
4bea004a4e Fix assign_public_ip: no disregarded (#29691) (#43954)
in case assign_public_ip is False, it is not handled.
2018-08-23 16:43:44 -04:00
Tim Rupp
05920b92d6
Misc fixes to bigip modules. (#44594)
Adding docs, formatting docs, adding validation checks and values
2018-08-23 15:57:08 -04:00
Matt Martz
2787bda0fa
Deprecated version should be an explicit version number (#44593) 2018-08-23 14:45:39 -05:00
Tim Rupp
1fd6821db0
Add parameter and remove netaddr (#44584)
This patch adds a description parameter to most fields. It also removes
netaddr from the modules.
2018-08-23 15:28:08 -04:00
Jose Rodriguez
14e3febb2c Prevent utf-8 codec error in py3 (#44228)
Cannot upload templates in Python 3.x. Gives utf-8 codec error.
Fixes this by opening the template file in binary mode.
2018-08-23 14:33:00 -04:00
Matt Martz
aa07da21a3
Bump sudo/su deprecation to 2.9 (#44581) 2018-08-23 13:22:54 -05:00
Alex Mayer
4002be6960 Firewalld: Add bool Type To permanent In Docs (#44579) 2018-08-23 14:06:06 -04:00
Zim Kalinowski
1704c5932a adding app gateway module (#39940)
* adding app gateway module

* improved application gateway

* added register output

* subnet_output

* debugging

* dumping params

* fix dump

* fixed mapping

* fixed bug

* fixed param problem

* small fixes in code and added sample test

* fixed syntax

* fixing sanity stuff

* sanity fixes

* more sanity tests fixed

* added azure_tags

* tags

* pruning app gateway

* pruning app gateway

* string -> str

* removed type: str

* trying to add idempotency

* fixed syntax

* fix sanity

* fixed bugs

* fixed error

* disabled ssl policy check for  a while

* fixed dict comparison

* fixed syntax

* compare just http listeners & frontend ports

* fix syntax

* syntax

* syntax

* just compare sku

* fix syntax

* just http settings collections

* fixing appgw module

* make it green

* fix items issue

* compare all arrays

* fixed sanity

* adding snake_to_camel transformations

* fix

* another fix

* snake to camel

* additional snake to camel fixes

* fixed public ip address conversion

* version added is now 2.7

* changed alias

* dict_merge

* added ssl policy spec

* fixed new sanity issue

* renamed module

* fixed ssl policy translation

* added test for ssl & certificates

* updated doc

* fixed docs improved tests

* fix

* fixed test
2018-08-23 10:24:21 -07:00
Tim Rupp
5a020e7170
Minor fixes and enhancements to bigip modules (#44549)
Various cleanup and fixes in docs and iterations.
2018-08-23 12:50:30 -04:00
rabru
59e25bbe5b Update bigiq_application_https_offload.py (#44562)
<!--- Your description here -->

+label: docsite_pr
2018-08-23 12:47:21 -04:00
Sam Doran
05fff27415
Pass path to GalaxyRole object (#43051)
This will list all roles in all paths in roles_path rather than just the first path in roles_path.
2018-08-23 12:44:48 -04:00
Matt Martz
88509e75ad
Remove bare_deprecated functionality (#44517)
* Remove bare_deprecated functionality

* Change tests due to bare_deprecated removal
2018-08-23 11:31:16 -05:00
Sam Doran
df335d91b0
Properly un expire account on creation (#44174)
When creating a new account, check to see if the expiration parameter is negative and pass in the appropriate parameter. Since the negative integer passed into expires is converted to time.struct_time which in turn gets converted to a formatted time string when passed to the underlying command, a -1 or large negative number would result in passing a date before 1970-01-01 to the underlying command.

This had the opposite effect of creating an account with no expiration account resulting in a newly created account that was already expired, or just throwing an error on certain systems.
2018-08-23 12:29:33 -04:00
Uwila
b1d6802d71 Fix ignoring of 'Login Profile cannot be found' errors in iam (#43198) 2018-08-23 12:14:51 -04:00
jctanner
653d9c0f87 New keyword: ignore_unreachable (#43857) 2018-08-23 11:41:02 -04:00
Pilou
2603604fd6 gather facts improvements (#44008)
* gather_subset is a list of strings

When gather_subset is an integer, a message pointing out the problem, current tb error 
is replaced by this one:

    ERROR! the field 'gather_subset' should be a list of (<class 'str'>,), but the item '42' is a <class 'int'>
...
* gathering_facts test: ensure smart gathering is on
2018-08-23 11:36:06 -04:00
Guillaume Delpierre
23e44319ce crypto: Add new module openssl_pkcs12 (#27320)
[module] Create new module to handle PKCS#12 file.
2018-08-23 08:15:22 -07:00
Trishna Guha
9c4ed4dfc1 use retry_json nxos_banner (#44376)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-23 15:55:50 +02:00
Ganesh Nalawade
64045cb024 Add support for multiple answers in cli_command module (#44560)
* Add support for multiple answers in cli_command module

*  Add multiple answers support for multiple prompts

Depends on PR #44492

* Doc update
2018-08-23 09:49:18 -04:00
Lindsay Hill
6c05e03fea Replace invalid_params with ValueError (#44545) 2018-08-23 15:49:08 +02:00
skylerbunny
d4e15d40e8 Update tags documentation to explain newer tags behavior (#44274) 2018-08-23 09:46:54 -04:00
Ganesh Nalawade
e25d8e2b99 Add support for multiple prompt answers in network_cli (#44492)
* Currently network_cli support multiple prompts
  single answer as response. This PR adds support
  for multiple answers.
* In case of multiple prompts and mulitple answers the
  index of a particular prompt in the prompts list should
  match with the index in the answer list.
2018-08-23 09:46:42 -04:00
Ondra Machacek
24c26aded8 oVirt: Add depracation warning to all modules (#44440) 2018-08-23 09:42:05 -04:00
Lingxian Kong
4d2e0c58a8 Add os_member module for openstack loadbalancing service (#43908) 2018-08-23 08:45:16 -04:00
Vincent Rischmann
81a5aba0a2 docker_container: allow arbitrary log_driver (#33579)
Docker supports logging plugin (see https://docs.docker.com/engine/admin/logging/plugins)
so it no longer makes sense to limit the log_driver option to a set of
fixed choices.
2018-08-23 07:05:42 -04:00
Zim Kalinowski
9788951789
Adding os_disk_size_gb parameter to Virtual Machine (#43316)
* added os disk size gb

* fixed mistake

* added os_disk_size_gb to test

* fixed test

* no default for disk size
2018-08-23 15:36:58 +08:00
guoqiao
6ef9c2d7b7 Fix mail module for python 3.7.0 (#44550) (#44552)
In python 3.7.0, changes in `ssl.py` breaks `smtplib.SMTP_SSL`, which
then breaks `mail` module in ansible.

Run this line in python shell:

    import smtplib;smtplib.SMTP_SSL().connect(host='smtp.gmail.com', port=465)

Before python 3.7.0, we will get:

    (220, b'smtp.gmail.com ESMTP j13-v6sm3086685pgq.56 - gsmtp')

In python 3.7.0, we get such error at `lib/python3.7/ssl.py` line 843, method `_create`:

    ValueError: server_hostname cannot be an empty string or start with a leading dot.

The ssl module is using host info on SMTP_SSL instance, which is not set.
The fix/workaround is simple, just pass host info to it:

    import smtplib;smtplib.SMTP_SSL(host='smtp.gmail.com').connect(host='smtp.gmail.com', port=465)

Fixes: #44550

Signed-off-by: Guo Qiao <guoqiao@gmail.com>
2018-08-23 16:50:54 +10:00
Andreas Olsson
4e895c10ba Have nsupdate add expected quotation to TXT records (#43386)
This prevents the accidental creation of TXT records where every
single word gets split into its own string, such as TXT record values
in the format of `"foo" "bar" "baz"`. That being an implicit behavior
I have very hard to see anyone purposely relying on.

TXT record values can still explicitly be defined as one or more
strings, without any change in syntax.

Resolves #43380
2018-08-23 02:40:50 -04:00
Jordan Borean
e07352b9de basic.py: catch ValueError when trying to import hash algorithms (#44551)
* basic.py: catch more Exceptions when trying to import md5 hash algorithms
2018-08-22 23:34:50 -07:00
Felix Fontein
c8ee383783 Clarify usage of env_file (#42211). (#44535) 2018-08-23 02:16:48 -04:00
Sumit Jaiswal
b1f915b28b
Added Support for excluding IPs in nios_next_ip and created new pluggin for nios_next_network (#44437)
* adding next network pluggin

* include exclude option for next_ip search

* changing example provider input

* adding new line at end

* version added info

* to fix shippable errors

* to fix shippable errors

* adding exclude option in doc section

* fix review comment

* fix review comment
2018-08-23 03:08:39 +00:00
Sumit Jaiswal
1d2bb34992
Includes support for Reverse-Mapping zone in nios_zone module (#44525)
* support reverse mapping

* support reverse mapping

* support reverse mapping

* fix shippable errors

* fix shippable errors

* fix shippable errors
2018-08-23 03:07:30 +00:00
/v\atthew L Daniel
d7e66f16a6 Correct the default doc for attached in ec2_eni (#44523)
* Correct the default doc for attached in ec2_eni

Also corrected a typo in the summary

* Address ansible-test sanity error about E324

* Fix and remove the E325 suppression for ec2_eni
2018-08-23 12:44:49 +10:00
Steve Dodd
c89dfad846 Update shell.py (#44477)
* Update shell.py

<!--- Your description here -->
Add example for disabling warnings to shell module
+label: docsite_pr

* Fix PEP8 issues
2018-08-23 12:31:55 +10:00
Ryan Brown
4c8808ec9d
Extend module_defaults by adding default groups for cloud modules (#44127)
Extends `module_defaults` by adding a prefix to defaults `group/` which denotes a builtin list of modules. Initial groups are: `group/aws`, `group/azure`, and `group/gcp`
2018-08-22 21:33:27 -04:00
Tim Rupp
fdcb883ac0
Adds new params to bigip trunk (#44547)
* description and q-in-q
2018-08-22 21:21:46 -04:00
Tim Rupp
27059a859e
Add time_wait_recyle param to bigip_profile_tcp (#44543)
Allows for configuring the time-wait-recycle setting on a tcp profile
2018-08-22 20:55:35 -04:00
Yuwei Zhou
fff5fb2077 Add route table and route module (#41175)
* add route module

* add test

* add table

* add  route table

* fix dict

* fix

* fix

* route  table accept no name

* add default

* fix

* fix

* fix

* fix pep

* support route table

* fix line ending

* fix pep

* fix

* fix

* set the default to 'None'

* make return value only id

* camel and snake

* set test alias

* change facts line ending

* change test

* fix

* add default

* fix

* fix line break

* remove unsafe args

* fix comment

* fix
2018-08-22 15:24:57 -07:00
Tim Rupp
6da6652e6b
Fixes and features for bigip gtm monitor modules (#44540)
Merging in gtm monitor work from downstream repo. includes various
new fixes and features.
2018-08-22 18:19:55 -04:00
Zim Kalinowski
a73340ee74 adding postgresql server facts (#43328)
* adding postgresql server facts

* updating postgresql server facts, minor changes

* changed return dict to list

* fixed test

* fixed several issues

* several updates

* fixed naming

* list -> complex

* try again

* fixed mistake

* added user_visible_state to the result

* added fully_qualified_domain_name

* fixed second test

* updates

* fixed test

* updated samples in return value

* wait for postgresql server to be actually ready

* another approach for test

* second server was not created

* fixing pr comments

* fix sanity

* removed forgotten  ansible_facts
2018-08-22 15:18:01 -07:00
Matt Martz
a1febd95b7
Remove deprecated ec2_facts (#44536)
* Remove deprecated ec2_facts

* Add changelog
2018-08-22 16:48:22 -05:00
Matt Martz
5ea7480e90
Remove deprecated s3 module (#44537)
* Remove deprecated s3 module

* Add changelog
2018-08-22 16:48:09 -05:00
sdubrul
061877d584 added account_alias in the response of module aws_caller_facts (#42345)
* added account_alias in the response of module aws_caller_facts

* added comment to explain list_account_aliases

* renamed caller_identity to caller_facts as the content is extended

* created changelog

* security-policy needs the iam:ListAccountAliases for this module to work

* test now checks for the added field account_alias

* gracefully handle missing iam:ListAccountAliases permission
2018-08-22 17:21:12 -04:00
Felix Fontein
960d99a785 ACME: new helper module for ACME challenges which need TLS certs (#43756)
* Added helper module for generating ACME challenge certificates.

* Soft-fail on missing cryptography. Also check version.

* Adding integration test.

* Move acme_challenge_cert_helper from web_infrastructure to crypto/acme.

* Adjusting to draft-05.

* The cryptography branch has already been merged.
2018-08-22 23:12:43 +02:00
Matt Martz
6ac4dae834 Bump a few deprecations to correct versions (#44534) 2018-08-22 17:11:41 -04:00
Vladimir Dobriakov
6f480fd03d Fixes #23078 - eliminate trailing whitespace in to_nice_json (#42633)
* Fix #23078 - eliminate trailing whitespace in to_nice_json

* Add changelog fragment for #42633
2018-08-22 14:55:30 -05:00
♫ Christian Krause ♫
d779eb1f15 doc: fixes the the repetitions (#43937)
Wow, this does not seem to be an uncommon misspelling. Might be there
are some left that span over two lines. I noticed the one in the git
module and then used `grep -rw 'the the'` to find some more.
2018-08-22 21:53:30 +02:00
Tim Rupp
9a17ee6d84
Removes netaddr dependency (#44519)
One more dep removed from bigip_selfip
2018-08-22 15:16:55 -04:00
Chris Archibald
65c9280935 Adding ontap_vserver_peer.py Module (#44226)
* Adding ontap_vserver_peer.py Module
2018-08-22 12:04:26 -07:00
Wes Mosher
b6fef17848 fix ec2_vpc_peer example with incorrect parameter (#43905)
+label: docsite_pr
2018-08-22 14:57:42 -04:00
Pedro Magalhães
12812d21c5 Add 'instance_protocol' parameter when fetching ELB Listeners (#40785)
This PR changes the ec2_elb_facts module to output the value of ELB InstanceProtocol
2018-08-22 13:57:02 -04:00
Ben Irving
0e536f746b Fix spelling error of secondary_availability_zone in rds module (#43852) 2018-08-22 13:55:22 -04:00
Rob St. Marie
a8f2b8f5ab CloudFormation: Allow failed changesets to gather stack_outputs (#43509) 2018-08-22 13:54:31 -04:00
Mark Goddard
8522e6420e Support project parameter for os_security_group module (#34472)
Many OpenStack modules provide the ability to register a resource in a
project other than the one being used to authenticate with, by adding a
project parameter to the module. Examples include os_network, os_subnet,
and os_router. This change adds a project parameter to the
os_security_group module.

Fixes: #34467
Fixes: #30292
2018-08-22 13:52:25 -04:00
Will Thames
c4303804bf Ensure that target group ports are cast to int on creation (#44442)
A previous fix fixed this for existing target groups but not
for new target groups

Fixes #37368
2018-08-22 13:51:59 -04:00
bhuztez
dd8edf5ae2 docker_container: fix working_dir (#42857)
WorkingDir should be read from Config instead of HostConfig, check
https://docs.docker.com/engine/api/v1.37/#operation/ContainerInspect
2018-08-22 13:42:56 -04:00
Till Maas
0fabf2109f service_facts: Use LC_ALL/LANG=C to run commands (#44474)
This allows to parse the output when the user's locale changes the
commands' output. For example chkconfig uses 'Ein' and 'Aus' instead of
'on' and 'off' when using LANG=de_DE.UTF-8 breaking the service
detection on RHEL 6.
2018-08-22 13:27:03 -04:00
Christoph
2b9d4b9253 More consistent Docker unit parsing (#16748)
* Docker: Convert units for kernel_memory

Other memory arguments already use human_to_bytes to convert the
units.  This change makes the behavior more consistent.

* Update Docker unit parsing documentation

This explains the units more precisely and makes the documentation
more consistent.

This fixes #16526.
2018-08-22 13:05:23 -04:00
Alex Stephen
261b90edc0 New GCP Module: gcp_compute_ssl_policy (#42797) 2018-08-22 13:00:15 -04:00
photoninger
d68c734ae2 Fix for "cannot marshal None unless.." (#33660)
when using only an activation key without any channels.
As already suggested by mattclay in
https://github.com/ansible/ansible/pull/25079

and also patch unit test for rhn_register and
add test case for activationkey only
2018-08-22 12:25:58 -04:00
Chris Archibald
5b19d67873 Bug Fixes for ontap_export_policy_rule.py (#44196)
* Bug Fixes for ontap_export_policy_rule.py
2018-08-22 09:03:56 -07:00