1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

19843 commits

Author SHA1 Message Date
Zhijun Zhao
addc714e7c fix typo 2018-01-09 23:18:31 -08:00
Zhijun Zhao
f0198cc39a fix lint errors 2018-01-09 23:18:31 -08:00
Zhijun Zhao
1fecb6f923 compute models 2018-01-09 23:18:31 -08:00
Zhijun Zhao
8b482ecd81 resources models 2018-01-09 23:18:31 -08:00
Zhijun Zhao
11c5d7b670 network models 2018-01-09 23:18:30 -08:00
Zhijun Zhao
7d77ce6866 fix lint errors 2018-01-09 23:18:23 -08:00
Zhijun Zhao
e6aeed2a8e pin api version of azure storage models 2018-01-09 23:18:23 -08:00
Zhijun Zhao
c6531ad556 pin api version of azure storage models 2018-01-09 23:18:23 -08:00
saichint
6f8d3ad70d Fixes for nxos_bgp (#34590)
* fix bgp issues

* add new tests cases

* review comments
2018-01-10 10:52:26 +05:30
Trishna Guha
c309315c1d
fix nxos_bgp failure for graceful_restart warning (#34623)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-10 10:51:30 +05:30
Zim Kalinowski
dadeae3ce6 [new module] adding azure_rm_mysqlserver (#33566)
* adding azure_rm_mysqlserver

* removed stupid semicolon

* updates to azure_rm_mysqlserver

* adding dependency

* updates to azure_rm_mysqlserver

* updates to azure_rm_mysqlserver

* updates to azure_rm_mysqlserver

* updates to azure_rm_mysqlserver

* updates to azure_rm_mysqlserver

* updates to azure_rm_mysqlserver

* Updated dependencies
2018-01-10 14:39:43 +10:00
Zim Kalinowski
1a3db9377a [new module] adding azure_rm_postgresqlserver (#33569)
* adding azure_rm_postgresqlserver

* removed semicolon placed by mistake

* updates to azure_rm_postgresqlserver

* updates to azure_rm_postgresqlserver

* updates to azure_rm_postgresqlserver

* updates to azure_rm_postgresqlserver

* updates to azure_rm_postgresqlserver

* updates to azure_rm_postgresqlserver

* updates to azure_rm_postgresqlserver

* updates to azure_rm_postgresqlserver

* Updated dependencies
2018-01-10 14:39:26 +10:00
Will Thames
9cb0c08d75 Ensure alternatives are displayed in deprecation warnings
Use plural `alternatives` key to display deprecation alternatives.
2018-01-09 21:21:53 -05:00
Matt Clay
232dc7110c Fix Python 3.7 syntax error in yum_repository. 2018-01-09 17:54:10 -08:00
Matt Clay
15a04a3da7 Fix Python 3.7 syntax error. 2018-01-09 17:34:26 -08:00
Will Thames
a685b621cd Route table boto3 (#32059)
* Allow protection of certain keys during camel_to_snake

Create an `ignore_list` parameter that preserves the case
of the contents of certain dictionaries. Most valuable
for `tags` but other uses might arise.

* Port ec2_vpc_route_table to boto3

Update tests to reflect fixes in boto3.

* Add RETURN documentation to ec2_vpc_route_table

* Update DOCUMENTATION to be valid yaml

* Add check mode tests
2018-01-09 20:09:25 -05:00
Jordan Borean
ef48448e4a
win_scheduled_task_stat: correctly return values from nested com values (#34671) 2018-01-10 10:23:04 +10:00
Matt Martz
55352bdda4
Error early if executing python version doesn't meet documented minimums (#34655)
* Error early if executing python version doesn't meet documented minimums. Fixes #34597

* Make recommended enhancements
2018-01-09 16:17:55 -06:00
Ryan Brown
2f66755849 New Lookup Plugin: aws_service_ip_ranges (#32749)
* added ranges lookup

* Add docs

* Use `open_url` from module_utils

* Fix error handling on open_url

* Fix ConnectionError exception import
2018-01-09 17:16:45 -05:00
Tim Rupp
70e49b9243
Updates module utils for f5 (#34660)
These module utils are a refactor of the legacy ones and, in addition,
there are several new methods and classes to support f5 modules going
forward
2018-01-09 12:15:02 -08:00
Matt Martz
d1846425db
Provide a way to explicitly invoke the debugger (#34006)
* Provide a way to explicitly invoke the debugger with in the debug strategy

* Merge the debugger strategy into StrategyBase

* Fix some logic, pin to a single result

* Make redo also continue

* Make sure that if the debug closure doesn't need to process the result, that we still return it

* Fix failing tests for the strategy

* Clean up messages from debugger and exit code to match bin/ansible

* Move the FieldAttribute higher, to apply at different levels

* make debugger a string, expand logic

* Better host state rollbacks

* More explicit debugger prompt

* ENABLE_TASK_DEBUGGER should be boolean, and better docs

* No bare except, add pprint, alias h, vars to task_vars

* _validate_debugger can ignore non-string, that can be caught later

* Address issue if there were no previous tasks/state, and use the correct key

* Update docs for changes to the debugger

* Guard against a stat going negative through use of decrement

* Add a few notes about using the debugger on the free strategy

* Add changelog entry for task debugger

* Add a few versionadded indicators and a note about vars -> task_vars
2018-01-09 13:50:07 -06:00
Steve Glendinning
e802b769e6 Ios logging (#33151)
* ios_logging: Handle IOS versions that dont put the word host in logging config

This change allows the ansible module to parse and match either variant
being present in running-config.

* ios_logging: enhance logging buffered to handle both size and level

This change allows ios_logging to ensure local (buffered) logging
is configured with both the correct buffer size and logging level,
when both are specified on the task.
2018-01-09 14:07:31 -05:00
Will Thames
39af276639 Respect egress rule definitions when creating security groups in default VPC (#34626)
* Add test for unexpected egress rule in default VPC

When passing rules_egress to ec2_group, the default
egress rule shouldn't be created (if `purge_rules_egress`)
is set. Test this.

* Respect egress rule defintions for default VPC groups

When passing rules_egress and purge_rules_egress, the
default egress rule should not be created

Fixes #34429

* Change AWS credential passing to be YAML anchors

Vastly simplify the AWS tasks by reducing the credentials to a YAML
block
2018-01-09 13:44:13 -05:00
Dag Wieers
f67f8c7bc9
Fix examples with correct names 2018-01-09 18:26:05 +01:00
David Soper
99524e7262 World Wide Port/Node Name documentation updated to match UCS Manager online help. (#34648)
kwargs variable argument setup simplified.
2018-01-09 18:05:25 +01:00
Matt Martz
03794864c2
Fix piped transfer with become (#34584)
* Ignore become if we shouldn't be sudoable

* More explicit passing of kwargs

* dd/piped put should be sudoable=False. Fixes #34523
2018-01-09 09:32:27 -06:00
René Moser
fbe46c5e21
cs_vpn_customer_gateway: fix missing return doc (#34644) 2018-01-09 16:13:24 +01:00
Ricardo Carrillo Cruz
4b53539e27
Fix enable_https alias docstring (#34633)
* Fix enable_https alias docstring

* Explicitly set https on test, as we are setting https_port anyways
2018-01-09 15:24:45 +01:00
Chris Houseknecht
623ff39443
Separate common and raw (#34563) 2018-01-09 07:22:46 -05:00
Abhijeet Kasurde
b14c8b130f yum: handle exception in local_envra (#34400)
This fix adds rpm.error exception which is raised when
API unable to get envra information from RPM package.
Also, adds integration test for local_envra method.

Fixes: #30074

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-09 12:28:55 +01:00
Abhijeet Kasurde
7d037991a3 nmcli: Handle dbus exception (#34577)
This adds exception handling for dbus related code.

Fixes: #34546

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-09 10:03:36 +01:00
Anil Kumar Muraleedharan
436ca0a0a1 Bug Fix at cnos.py (#34607)
* Bug Fix at cnos.py

* Removed extra blank space
2018-01-09 08:33:45 +00:00
Clement Trebuchet
d5a8974ef3 Add the ability for the ios_vrf module to apply route targets to a VRF (#34248)
* Add the ability for the ios_vrf module to apply route targets to a VRF

* Fix W293 blank line contains whitespace
2018-01-09 02:04:18 -05:00
David Soper
9d1c48f7a4 Document descriptions updated to match UCS Manager online help. (#34593)
kwargs variable argument setup simplified.
2018-01-09 07:58:22 +01:00
Matt Martz
70cafcdef6 First pass at fixing #33064 (#33636) 2018-01-08 18:13:22 -05:00
Matt Martz
df909c5726
Fix with_items debug loop example. Fixes #34540 (#34578) 2018-01-08 16:13:10 -06:00
Abhijeet Kasurde
08a1d47427 nmcli: Add missing 'primary' option (#34252)
This fix adds missing 'primary' option in nmcli module.

Fixes: #30405

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-08 13:37:21 -08:00
Adam Miller
39edee7572
service_facts module (#34065)
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-01-08 13:35:16 -08:00
Daniel Shepherd
56da2c13d6 [cloud] Add ipv6 support to ec2_vpc_nacl_facts (#30581)
* wrap boto3 connection in try/except and handle exception, add traceback import

* params dont need to be mutually exclusive and support check mode

* add check to set nacl_ids to empty list instead of None for boto3 func

* standard exception handling using traceback

* update current RETURN documentation which is incorrect.

* update logic to check for and return ipv6 cidr instead of ipv4 cidr in a NACL

* ignore default and reserved rule numbers - greater than 32766

* was breaking on non-standard protocol numbers - AWS nacls now support full list -1 to 254

* update port range and icmp type/code handling

* add some more detail to returned nacl entries

* Update exception handling to account for BotoCoreError

Remove exception handling from the boto connection creation since it does nothing

* rules numbers from 32767 to 65535 are reserved for internal AWS use so we ignore here
2018-01-08 16:24:40 -05:00
Dag Wieers
dca5d9bbd4
Fix typo and copyright statement 2018-01-08 22:14:55 +01:00
Vinay Dandekar
f20af4b909 [cloud] Change S3 MD5 checksum for multipart support in aws_s3 (#34216)
- If file has only one part and is uploaded as multipart, it is still computed the same way as having multiple parts
2018-01-08 15:21:45 -05:00
Tomas Tomecek
0587aedc01 synchronize: add support for buildah (#33823)
Fixes #33533

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
2018-01-08 11:51:49 -08:00
Jordan Borean
b2a415daae
win_certificate_store: added new module (#33980)
* win_certificate_store: added new module

* added warning about become or credssp for pfx
2018-01-09 05:44:24 +10:00
Sloane Hertel
34206a0402 ec2_vpc_vgw_facts: fix getting facts about gateways without tags (#34575) 2018-01-08 13:16:49 -05:00
David Soper
dc85176512 Document descriptions updated to match UCS Manager online help. (#34581)
kwargs variable argument setup simplified.
2018-01-08 18:39:23 +01:00
Sloane Hertel
788010d0f0 [cloud][testing] New integration tests for ec2_asg (#30554)
* Add some integration tests for ec2_asg.

* Remove exception handling from ec2_asg boto3 connection since it is handled in boto3_conn().

* Update test failure assertions

* Use yaml anchor for credentials and remove unnecessary dependencies.

* Move AWS boto3 module credentials tests to separate target

* Remove filters from tests
2018-01-08 11:21:49 -05:00
Samer Deeb
473b2d58ec Add new module mlnxos_mlag_vip for configuring MLAG VIP on Mellanox network devices (#34285)
* Add new module mlnxos_mlag_vip for configuring MLAG VIP on Mellanox
network devices

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Remove unused variables

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix Test class name

* Fix Documentation

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix MAC address case-insensitive

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix MAC address unit-test

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-01-08 14:31:51 +00:00
Samer Deeb
ad73bda323 Add new module mlnxos_protocol for enabling disabling protocols on MLNX-OS Mellanox network devices (#34286)
* Add new module mlnxos_protocol for enabling disabling protocols on
MLNX-OS Mellanox network devices

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix Test Class name

* Fix IP routing protocol support

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Add missing support for check_mode, and Fix documentation

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-01-08 14:30:30 +00:00
Samer Deeb
943107b1b9 Add new module mlnxos_facts for retrieving facts of MLNX-OS Mellanox network devices (#34287)
* Add new module mlnxos_facts for retrieving facts of MLNX-OS Mellanox
network devices

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix Documenation and Examples

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-01-08 14:29:16 +00:00
Johannes Truschnigg
00d75ff449 Fix Linux blockdevice size computation (#34475)
Linux' sysfs _always_ reports device size in 512b sector units,
regardless of the device's actual, physical blocksize.
2018-01-08 06:18:25 -08:00
Samer Deeb
9ed4661860 Add new module mlnxos_pfc_interface for managing priority flow control on Mellanox devices (#34327)
* Add new module mlnxos_pfc_interface for managing priority flow control
on Mellanox devices

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Remove unnecessary if, and Fix Documentation

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix missing interface status

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-01-08 13:43:10 +00:00
René Moser
a0dbfb0089
vultr: new module vr_account_facts (#34394)
* vultr: new module vr_account_facts

* fix typo

* simplify

* minor doc fix
2018-01-08 14:40:10 +01:00
Trishna Guha
5e6b2495c0
Convert nxos_vrf to DI module (#34274)
* Convert nxos_vrf to DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add purge example and improve logic

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* revert version_added for rd param

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update test to use network_cli

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-08 10:10:34 +05:30
jn-bedag
7f59f7d80e Fixing issue with win_iis_website parameter types. Issue #34500 (#34501)
* remidate Windows debugging

Using $complex_args is not working (anymore?). We need to set $params directly.

* Fixing issue with win_iis_website parameter types

There are two types of attributes. "String" and "Configuration Attribute". We need to get the real "value" based on the type.

* Revert "remidate Windows debugging"

This reverts commit df75d3bb0d152b10c24187ce4c643b4733bae336.
2018-01-08 10:26:16 +10:00
Dag Wieers
49739dda47
ACI: Add signature-based authentication (#34451)
ACI: Add signature-based authentication
2018-01-08 00:44:30 +01:00
Jordan Borean
71ff77e51f
win_domain_user: added ability to explicitly set credentials and user when interacting with AD (#34562) 2018-01-08 09:38:13 +10:00
Jonathan Doig
e545127c2e Fix broken link to w3schools (#34561)
Closes issue #34528
2018-01-08 00:13:39 +01:00
quenck
b5579f55cc win_domain_user allow to update generic attributes (#34558)
* win_domain_user allow to update generic attributes

Signed-off-by: Marko Koehne <marko@mkoehne.de>

* win_domain_user.py fixed indentation

Signed-off-by: Marko Koehne <marko@mkoehne.de>

* win_domain_user.py attributes add version_added

Signed-off-by: Marko Koehne <marko@mkoehne.de>

* win_domain_user.p1 removed attributes from result

Signed-off-by: Marko Koehne <marko@mkoehne.de>

* moved run_change outside of if statement
2018-01-08 08:43:34 +10:00
David Soper
06cbc422c1 Document descriptions updated to match UCS Manager online help. (#34534)
Property checking variable argument setup simplified.
2018-01-07 20:32:34 +01:00
Chris Houseknecht
b5245e581a
Adds openshift_scale module (#34244) 2018-01-07 12:38:50 -05:00
René Moser
2db9878c76
cloudstack: streamline cs_network_offering (#34553)
* cs_network_offering: streamline docs a bit

* cs_network_offering: format traffic type as returned by API

* cs_network_offering: rename return to service_offering_id

* cs_network_offering: ensure absent tests don't require anyting else than name

* cs_network_offering: beautify the default_egress_policy param

* cs_network_offering: test enabling/disabling with existing syntax

* cs_network_offering: rename service_provider_list to service_providers

* cs_network_offering: allow update max_connections

* cs_network_offering: extend returns

* cs_network_offering: extend tests with max_connections
2018-01-07 17:30:52 +01:00
René Moser
439e64256f
cloudstack: rename new module to cs_service_offering (#34555)
* cloudstack: rename cs_serviceoffer to cs_service_offering

* adjust references to old name

* cs_service_offering: fix limitcpuuse not handled

* minor docs fix

* update changelog
2018-01-07 17:21:56 +01:00
Christopher Brown
d2ccc13857 Add VNC port range check (#34466)
This adds a check to ensure that both start and end of vnc range
is specified.
2018-01-07 04:27:42 -05:00
Samer Deeb
5edb800b6d Remove unnecessary if, and Fix Documentation (#34413)
* Remove unnecessary if, and Fix Documentation

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix aggregate spec for l2 interface

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Add aggregste test for l2 interface

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix MAC address case

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-01-07 08:35:50 +00:00
Tim Rupp
2916ff0a1a
Introduces numerous fixes for bigip command (#34550)
A bug in the parsing of single commands with commas
Token cleanup
Password argument now defaults to false
Addition of coding conventions from v3 conventions
2018-01-06 23:23:32 -08:00
Tim Rupp
8e5407e0da
Fixes bigip gtm params (#34544)
Changed bool params to be string params because there is a third
param that needs to be taken into account
2018-01-06 19:36:02 -08:00
Patrick Marques
8465830c1d Add new module digital_ocean_floating_ip_facts (#26372) 2018-01-07 08:51:57 +05:30
Tim Rupp
f4a2b0b103
Adds the bigiq_regkey_license module (#34543)
This module can be used to add license offerings to a pool. This
is the second part required to license a remote device from a
BIG-IQ (the first being to create a pool with bigiq_regkey_pool)
2018-01-06 12:13:50 -08:00
Tim Rupp
8c07ebe860
Adds bigiq regkey pool module (#34542)
This module can be used to manage the containers of regkeys
that exist on a BIG-IQ
2018-01-06 11:34:14 -08:00
Adam Miller
ad337503e7 add missing > to ansible-doc help message (#34512)
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-01-06 15:43:54 +00:00
James Cammarata
ebf971f931 Don't use getattr in _get_parent_attribute to avoid recursion issues (#33595)
* Don't use getattr in _get_parent_attribute to avoid recursion issues

Fixes #23609

* Move extend/prepend to field attribute

Also removes _get_attr* methods that were basically just calling
_get_parent_attribute because it needed to set those params.

Also modifies _get_parent_attribute() to pull those values from the
FieldAttributes instead of using the ones passed into the function.

* Better fixes for _get_parent_attribute
2018-01-05 21:51:44 -05:00
Tim Rupp
e5d77c7782
Fixes for bigip monitors and profiles (#34524)
Fixed incorrect parent comparison. Fixed old fqdn_name usage.
Fixed incorrect default parents
2018-01-05 15:53:26 -08:00
Tim Rupp
803e4124b6
Removes deprecated code from bigip_monitor_tcp (#34520)
* Removes deprecated code from bigip_monitor_tcp

The deprecated code was moved into its own modules. We let it lay
here for a release, and now I'm removing it.

* Fixing upstreaming tests
2018-01-05 15:22:50 -08:00
Brian Coca
f189106ef6 optimize config yaml loading (#34481)
fixes #34147
2018-01-05 16:58:05 -06:00
Tim Rupp
e6a7c0e30b
Adds more common doc strings to f5 modules (#34515) 2018-01-05 14:41:23 -08:00
Tim Rupp
e9bb5da37e
Adds the bigip_gtm_server module (#34513)
This module can be used to create GTM servers (not to be confused with
GTM virtual servers) on a BIGIP. GTM servers are a component of the
datacenter, and GTM virtual servers are their members.
2018-01-05 13:51:15 -08:00
Sam Doran
6d4ab66655 Allow variables to be used in vars_prompt (#32802) 2018-01-05 13:24:20 -06:00
dpassante
7bf75f2458 cloudstack: new module cs_network_offering (#34354) 2018-01-05 20:06:49 +01:00
Nathaniel Case
c371ed8d30
nxos tests to use network_cli (#34474)
* Fix over-byte

* Fix nxos_l2_interface docs

* Update connections for tasks

* Add default ssh port

* Only report provider when using connection=local

* Send empty provider when connection=network_cli

* Fix find tasks
2018-01-05 12:39:04 -05:00
Matt Martz
9b74b9bc8b
mongodb cache plugin (#34414)
* Initial commit of mongodb cache plugin

* Fix typo in method docstring

* Add ANSIBLE_METADATA indicating preview and community supported
2018-01-05 09:10:58 -06:00
Vitaliy Zhhuta
bac5808b94 New module for managing user in InfluxDB (#31566) 2018-01-05 15:27:43 +05:30
John R Barker
2be5ad4f08 deprecation dict not live yet (#34493) 2018-01-05 03:28:53 -05:00
Trishna Guha
9d2182bcf8 Deprecate nxos_switchport and Add nxos_l2_interface DI module (#33813)
* Deprecate nxos_switchport

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos_l2_interface DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* pep8 fixes

* aggregate test for nxos_l2_interface

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* revert nxos_switchport test change

* gundalow's comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-05 07:44:02 +00:00
Pilou
e9a5ff912a nxos_file_copy: fix broken import and 2.6 compatibility (#34480)
* Fix broken import: paramiko could be missing

* doc: use formatting function

* Use Python 2.6 compatible format string
2018-01-05 11:36:11 +05:30
Toshio Kuratomi
6da06fac3f Fix out-dated code style in new module logentries_msg.py 2018-01-04 20:50:42 -08:00
Pilou
e9df2083a3 If check mode enabled and file missing set changed to true 32676 (#33967)
* basic.py: add mock to os.path.exists

* set_*_if_different: if check_mode enabled & file missing: set changed to True

Fixes #32676
Thanks to mscherer and Spredzy for the distributed triplet programming
session!
2018-01-04 20:33:14 -08:00
Abhijeet Kasurde
9f969a2176
Misc. typo is display log (#34388)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-05 07:44:28 +05:30
Brian Coca
bc6b1ca17b corrected docs, removed comment, return is req 2018-01-04 20:46:26 -05:00
Jimmy Tang
dab0661cc7 Logentries msg plugin, this allows users to send log messages to logentries (#19456)
* This is a resubmission of https://github.com/ansible/ansible-modules-extras/pull/904

* Fix up logentries_msg module with current best practices

This commit also fixes up a few pep8 issues.
2018-01-04 20:45:47 -05:00
Matt Martz
aece0818c4
Don't cache duplicate plugin names (#34420)
* Don't cache duplicate plugin names. Fixes #33484

* Add tests for duplicate plugin filenames, to showcase what happens
2018-01-04 16:47:23 -06:00
Jordan Borean
edf56c9743
win_mapped_drive: add extra note around win_mapped_drive (#34478) 2018-01-05 08:00:09 +10:00
Jordan Borean
da69f5aeae
win_package: remove case sensitive check for msi extension (#34476) 2018-01-05 07:11:22 +10:00
Chris Houseknecht
85ff38d2e2
K8s lookup plugin (#34025)
* Use OpenShift client

* Refactored

* Fix lint issues

* Replace AnsibleError to make the bot happy

* Remove extra space
2018-01-04 15:24:31 -05:00
Pilou
bd38359ddc gcdns_zone: fix broken import (#34076)
* fix broken import
* whole project requires Python >= 2.6
2018-01-04 09:32:47 -08:00
Tim Rupp
19f5d969c5
Bugfix.add token cleanup 02 (#34441)
* Adds more token cleanup

Token cleanup ensures that the bigip doesnt become wedged from
excessive API calls

* Fixed missing usage of token cleanup
2018-01-04 09:24:14 -08:00
Chris Houseknecht
490a1625f7
K8s scale module (#33983)
* New K8s common modules

* Refactor

* Fixes lint issues

* openshift_scale to new branch

* Better docs

* Updates examples
2018-01-04 12:07:53 -05:00
Matt Martz
3d0da8f093 Inject attempts into result earlier for retry logic (#34148)
* Add integration test for missing attempts in until with failed/changed_when

* Extend tests to validate additional known behaviors of do-until loops

* Inject attempts into result earlier
2018-01-04 11:45:34 -05:00
Yuwei Zhou
6d3fafa2d5 upgrade the azure storage version (#34442) 2018-01-04 08:23:15 -08:00
ZhijunZhao
99551818a1 fix failure got multiple values for keyword argument id (#33624)
* fix failure `got multiple values for keyword argument id`

* fix test case failure

* fix pylint error

* fix typo

* use fixed version of azure mgmt network sdk

* resolve code review feedbacks
2018-01-04 08:22:35 -08:00
Brian Coca
1b34a17415 removed unused objects from include results proc 2018-01-04 11:20:56 -05:00
James Cammarata
c30ee42fe1 Don't use the Task object in the dictionary of results for include_role
The short-circuiting of include_role in TaskExecutor was using the _task object
in the result dictionary. This causes the playbook class to be serialized, which
is something we no longer do due to speed/size problems with nested objects.

Simply removing this should fix a lot of memory and speed problems with include_role.
2018-01-04 10:14:13 -05:00
Oliver Gondža
30cae1c356 Do not prevent username logging in jenkins_script module (#34459) 2018-01-04 10:03:01 -05:00
Trishna Guha
0f24199012
make eos_vlan idempotent (#34443)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-04 18:12:44 +05:30
Ganesh Nalawade
ab67539bef
Add nxos_lldp module (#34453)
* Add nxos_lldp module

*  Implemetation for nxos_lldp module
*  Integration test for nxos_lldp module

* Minor change
2018-01-04 18:06:15 +05:30
Ondra Machacek
2376d02f3f ovirt_cluster: Fix cluster cpu arch comparision (#34446) 2018-01-04 07:01:58 -05:00
Abhijeet Kasurde
dcc1355d54
VMware: new module - vmware_local_role_manager (#33372)
This fix adds new module for managing various roles in
local ESXi server. Also, adds integration tests for this change.

Fixes: #27899

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-04 15:53:58 +05:30
Seuf
0ddfdca143 New module grafana dashboard (#31930)
Reviewed
2018-01-04 10:12:02 +00:00
MarkusTeufelberger
10b3431990 expose subject_strict and issuer_strict to users (#34090) 2018-01-04 04:43:37 -05:00
Tim Rupp
6c97c340ea
Various bigip_gtm_datacenter fixes (#34440)
Code refactor to use f5 coding conventions. Removed deprecated
"enabled/disabled" params (this is now a state). Adds token cleanup
for cases where many api calls are made.
2018-01-03 21:18:34 -08:00
Tim Rupp
43812d82c1
Adds "allow" param to bigip_device_httpd (#34439)
This param can control what addresses are allowed to access the
httpd ui of the bigip
2018-01-03 20:58:22 -08:00
Tim Rupp
bdafb42156
Refactors the bigip_sys_global module (#34438)
Changes include the current f5 coding standards and unit tests
for the module
2018-01-03 20:39:08 -08:00
Tim Rupp
9bd4070bdf
Adds bigip_traffic_group module (#34436)
This module can be used to create and remove traffic groups. Managing
members of the group is not yet supported.
2018-01-03 20:26:18 -08:00
Jordan Borean
25a21f46bd
win async: removed async_wrapper module and fixed async for action plugins to use shell code (#34434)
* win async: removed async_wrapper module and fixed async for action plugins to use shell code

* fixed pep8 issue
2018-01-04 12:51:53 +10:00
Eric L
c2342f156c Count ignored failed tasks and successful tasks with expected failure… (#33282)
* Count ignored failed tasks and successful tasks with expected failure as failed tests.

* Make junit callback plugins changes backward compatible: add new task marker TOGGLE RESULT and new option fail_on_ignore
2018-01-03 16:03:15 -08:00
Jordan Borean
6c754d9d1c win_whoami: removed logon_sid from return results (#34425) 2018-01-03 17:57:44 -05:00
Jordan Borean
4eb0d74c22
win_domain_controller: add readonly support (#33850)
* win_domain_controller: add readonly and sitename functionality

* fixed minor typo

* removed choices from doc
2018-01-04 08:46:32 +10:00
Gaurav Rastogi
3536de0fb8 New Avi module to setup custom IPAM DNS profile (#34358)
* New Avi module to setup custom IPAM DNS profile

* Update copyright notice.

* updated required fields
2018-01-03 22:19:48 +00:00
Gaurav Rastogi
5164bf78bc Added a new module to fetch Avi Controller version and data (#34357)
* Added a new module to fetch Avi Controller version and data

* Updated copyright notice.

* setting options to empty as all of it is coming from common args.
2018-01-03 22:19:13 +00:00
Gaurav Rastogi
d702c720f6 New module to setup error page profile (#34361)
* New module to setup error page profile

* Update copyright notice.

* updated required fields
2018-01-03 22:17:45 +00:00
Tim Rupp
c132b977e8
Refactors bigip_virtual_server (#34412)
This refactors the bigip_virtual_server module to address several issues and
missing features. Additionally it adds tests and updates the coding standards
to the recent version used by f5. Finally, it removes deprecated items that
were announced in 2.4
2018-01-03 13:42:17 -08:00
Will Thames
4d5533c597 Update ec2_asg_lifecycle_hook to meet modern best AWS module practices (#34379)
* Use `AnsibleAWSModule`
* Update exception handling to use `fail_json_aws` and check
  for `BotoCoreError` exceptions associated with bad connection
  parameters.
* Remove connection creation exception handling as it does nothing.
2018-01-03 16:35:24 -05:00
Will Thames
1412d6eb18 Allow ec2_vpc_net to work in non classiclink regions (#34336)
describe_vpc_classic_link only works in regions that support
EC2-Classic.
2018-01-03 15:36:02 -05:00
Tim Rupp
b40c779e46
Adds token cleanup for bigip_partition (#34415)
Tokens need to be cleaned up or else the bigip may wedge itself
over time if not enough tokens auto-expire.
2018-01-03 12:34:54 -08:00
Jordan Borean
38a31d3156
win_domain: added option to set database and sysvol path (#34333)
* win_domain: added param to set database and sysvol path

* fixed up documentation to work with backslashes
2018-01-04 06:32:01 +10:00
Arie Bregman
dacd4c4a68 Add network namespace module (#21820)
Allows to create/delete network namespaces with ip.
2018-01-03 15:27:58 -05:00
Peter Sprygada
1183029591 update DOCUMENTATION for network_cli and netconf (#33396)
* update DOCUMENTATION for network_cli and netconf

This updates the DOCUMENTATION string for both the netconf and
network_cli connection plugin.

* add additional options to the connection documentation

* update documentation based on review and feedback

* adds persistent connection options to documentation string
2018-01-03 15:10:35 -05:00
Tim Rupp
9e4aed15ff
Adds bigip_software_update module (#34410)
This module can be used to adjust the ways by which a bigip communicates
back to F5 to check for system updates.
2018-01-03 11:30:11 -08:00
Gaurav Rastogi
7cec8986b9 New module to setup error page body policies (#34359)
* New module to setup error page body policies

* Update copyright notice.
2018-01-03 18:59:41 +00:00
Gaurav Rastogi
53051cf9e8 New module to setup WAF policy (#34362)
* New module to setup WAF policy

* Update copyright notice.
2018-01-03 18:57:07 +00:00
Gaurav Rastogi
627295365d New module to patch GSLB service object with just GSLB pool member an… (#34365)
* New module to patch GSLB service object with just GSLB pool member and settings

* Update copyright notice.
2018-01-03 18:55:21 +00:00
Gaurav Rastogi
e2928da0fd Updated copyright for all the avi modules (#34408) 2018-01-03 18:48:24 +00:00
Jordan Borean
57ed6a866f windows: Add IPv6 address support and docs to go with it (#34072)
* windows: Add IPv6 address support and docs to go with it

* minor docs fix

* fixed some doc sentances
2018-01-03 09:26:53 -08:00
Seuf
603d6122a3 New module: monitoring/grafana_plugin (#33150)
* Grafana plugin module

* Minor formatting
2018-01-03 16:37:52 +00:00
Michael Scherer
b0fc65bf9b Add doc fragment for files (#33953)
Found by Pilou- and spredzy during co-debugging #32676
2018-01-03 11:04:18 -05:00
Matt Martz
b762eb2d92
Fix some TODOs to use generic_urlparse which allows proper netrc selection. Fixes #34360 (#34372) 2018-01-03 09:52:56 -06:00
Abhijeet Kasurde
9879aa0382
VMware: Add support for resource allocation info (#33990)
This fix adds support for Virtual Machine resource allocation
information. This information is related to limit and reserve CPU and Memory
of virtual machine.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-03 21:13:56 +05:30
bdowling
552d1df901 Adds parents to mutually_exclusive with src for *_config modules (#33957)
* mutually_exclusive add - ios_config parents works with lines by not src

* mutually_execlusive parents,src added to all other net modules

* tests for mutually_exclusive parents,src and whitespce removal
2018-01-03 09:47:12 -05:00
Jim Pfleger
af236f2531 Accept other ios_banner types (#33961)
* Accept other ios_banner types

* Use 2.6-compatible format string

* Doc option values prior to this update
2018-01-03 14:38:14 +00:00
René Moser
798aa8a2d2 ec2_asg: fix desired_capacity not optional (#34194)
1# Please enter the commit message for your changes. Lines starting
2018-01-03 09:31:34 -05:00
Takuya Sato
a323521e46 ecs_taskdefinition module : proposal : add force_create: true parameter (#23480)
* ecs_taskdefinition module : add `force_create: true` parameter
2018-01-03 08:56:19 -05:00
Mohit Kumar
605243f41f Updating ecs_task_definition module example (#34237)
Appending logConfiguration: parameter for ecs task definition. To define user specific log configuration attribute.
2018-01-03 08:50:53 -05:00
Samer Deeb
1afd076dac Add new module mlnxos_magp for managing MAGP protocol on Mellanox (#34307)
MLMX-OS network devices

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-01-03 12:43:46 +00:00
Samer Deeb
42d5aeec3e Add support for vlan and loopback interfaces in mlnxos_interface (#34323)
Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-01-03 12:43:13 +00:00
Samer Deeb
52bea8dab6 Add new module mlnxos_mlag_ipl for managing IPL (inter-peer link) (#34326)
Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-01-03 12:41:26 +00:00
Christopher Brown
18e41ca4d9 add VMware provider to ManageIQ module (#34112)
Currently the manageiq remote management module only supports
OpenShift, AWS and oVirt. This adds the ability to create VMware
providers by adding two additional parameters for configuring a
host VNC range.
2018-01-03 07:14:02 -05:00
Ondra Machacek
b051fc6067 ovirt: host_pm: Add missing order parameter (#34213)
Fixes: https://github.com/ansible/ansible/issues/34134
2018-01-03 10:52:23 +00:00
Abhijeet Kasurde
daae4d922a Add missing msg keyword for fail_json (#34387)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-03 04:44:53 -05:00
Jacob F. Grant
6a322637c4 Add support for snapshot_id field (#23334)
The DigitalOcean API v2 supports creating a block storage volume from
a previously-saved snapshot using a snapshot_id string. This module now
likewise supports creating a block storage volume using a valid
snapshot_id string.

When creating a block storage volume from a snapshot_id using the
DigitalOcean API, the region and size_gigabytes parameters are ignored.
Therefore, these parameters are likewise ignored when using this module.
However, as of this commit, they are still required fields. It may be
necessary to find some way to eliminate these requirements if the
snapshot_id parameter is included.

The DigitalOcean API v2 allows for creating a block storage volume from
a previously-saved snapshot using the snapshot_id parameter. If this
parameter is used, the region and size_gigabytes parameters are
disregarded. In order to avoid confusion, when the snapshot_id parameter
is included when creating a block storage volume using this module, the
region and block_size fields are overridden and changed to null values.
This should make it clear that these values are NOT being used if a
snapshot_id is present.

This module will still fail as before if neither the region/block_size
or snapshot_id is not present when creating a block storage volume.

Documentation has been updated to reflect these changes.
2018-01-03 03:55:30 -05:00
Matt Davis
206b6ebe0d
fix PS type conversion failure when using "all" profiles (#34383)
* obscure type promotion issue in some versions of Powershell causes [int]::MaxValue to be promoted to [int64] when doing a COM property get or set. Since the "All" profiles value of 0x7FFFFFFF is [int]::MaxValue, it would trigger "Specified cast is not valid" when modifying a rule that's already set to All Profiles or trying to be.
* Fixed catch-all error handler to include exception detail
* Added test converage for this case
2018-01-02 20:25:46 -08:00
Will Thames
136d902ff3 Update ec2_asg_lifecycle_hook to pass tests
ec2_asg_lifecycle_hook was merged without rerunning tests.

Changes needed to pass tests:
* version_added
* metadata version
* copyright header
2018-01-02 18:09:31 -08:00
Jan Fader
2b4db5eaab fixes typo ansbile to ansible 2018-01-02 17:17:53 -08:00
Igor (Tsigankov) Eyrich
b14e5c33ab Autoscaling Groups Lifecycle Hooks module (#22412)
New ec2_asg_lifecycle_hook module
2018-01-03 10:30:20 +10:00
Jeffrey Zhang
e045f46132 Fix doc for with_first_found
the variables in with_first_found should be list rather than dict
2018-01-02 11:37:53 -05:00
Ganesh Nalawade
6dad717a9a
Add eos_lldp module (#34302)
* Add eos_lldp module

*  Implementation for eos_lldp module
*  eos_lldp integration test

* Fix minor issue

* Minor change
2018-01-02 18:54:06 +05:30
Ganesh Nalawade
48f20a77af
Add ios_lldp module (#34308)
* Add ios_lldp module

*  Implementation of ios_lldp module
*  Integration test for ios_lldp module

* Minor change
2018-01-02 18:43:08 +05:30
Martin Krizek
3681d0e3e0
yum: support installroot in is_group_env_installed (#34182) 2018-01-02 12:42:53 +01:00
Abhijeet Kasurde
5496326c4d nmcli: Add 'generic' connection type (#34251)
This fix adds 'generic' connection type in nmcli module.

Fixes: #33648

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-02 12:37:22 +01:00
Abhijeet Kasurde
d1b63bd5ef yum: Add option for enable and disable plugin (#34306)
This fix adds parameter to enable and disable plugins for yum
command.

Fixes: #30016

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-01-02 12:37:02 +01:00
Barney Sowood
158cd59994 Add Windows AD Domain facts for membership and server type (#23500)
* Add Windows Domain facts for membership and server type

Adds additional facts to setup.ps1 for Windows hosts

 * ansible_windows_domain_member - returns true if machine is domain
   joined
 * ansible_windows_domain_role - indicates role of machine in domain

Roles list is taken from
https://technet.microsoft.com/en-us/library/ee198796.aspx and will
return sensible values for non domain joined machines too.

* Use $win32_cs rather than Get-CimInstance Win32_ComputerSystem for consistency
2018-01-01 20:20:06 -05:00
nwsparks
0a3da471f5 win_iis_webbinding rewrite (#33958)
* Begin rewrite of win_iis_webbinding
Add integration testing, check mode and idempotency
Add support for SNI
Fix replacing SSL cert on existing bindings

* finished up initial rewrite of win_iis_webbinding

* updated test to remove tests as filters

* updated win_iis_webbinding docs

* fix more doc/formatting issues win_iis_webbinding

* Removed string empty defaults for certs. Added a few new helpful
comments.

* Revert "Removed string empty defaults for certs. Added a few new helpful"

This reverts commit 48f35faea8d5294b34e1aa842a95c9352b90257f.
2018-01-01 19:30:18 -05:00
Ted Timmons
32929f916a docfixes: spelling, width (#34301)
Remove examples from main section and make sure it is all in the examples. Should helpw ith the HTML breakage (it is too wide for most monitors).

tyop fixes too.
2017-12-29 21:44:21 -05:00
Ted Timmons
2f6fedd91f add aliases to match the names returned by the module (#34276) 2017-12-29 13:51:54 -05:00
Samer Deeb
585b3449c6 Add module mlnxos_lldp_interface for managing lldp interfaces configuration (#34179)
* Add module mlnxos_lldp_interface for managing lldp interfaces
configuration

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix unit test

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2017-12-29 10:51:31 +05:30
Samer Deeb
84a10903db Add module mlnxos_linkagg for configuring LAG and MLAG on Mellanox switches (#34204)
* Add module mlnxos_linkagg for configuring LAG and MLAG on Mellanox
switches

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Remove unnecessary  method in unit-test

remove _execute_module and use execute_module from base class
2017-12-29 09:03:45 +05:30
René Moser
17fcf7d946
cloudstack: new module cs_vpn_customer_gateway (#34260)
* cloudstack: new module cs_vpn_customer_gateway

* fix example is not a yaml

* add missing alias

* use case insensitve for name
2017-12-28 21:40:57 +01:00
Trishna Guha
80ba767204
Convert nxos_interface to DI (#34240)
* Convert nxos_interface to DI

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* commit for ganeshrn's comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-12-28 16:41:09 +05:30
Ganesh Nalawade
a3c185bfa8
Add eos_interface module (#34258)
* Add eos_interface module

*  Implementation of eos_interface module
*  Intergration test for eos_interface module
*  Minor fix in eos_l3_interface module
*  Minor fix in ios_interface integration test

* Fix CI issues

* Fix more CI issues
2017-12-28 16:03:50 +05:30
Abhijeet Kasurde
747682fa53 FreeIPA: Add CNAME, DNAME and A6 as record type (#34236)
This fix adds CNAME, DNAME and A6 record type in ipa_dnsrecord module.

Fixes: #34198

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-27 16:32:11 -05:00
Ondra Machacek
285f1187e0 ovirt: Fix check for upgrade when no updates (#33940) 2017-12-26 09:29:50 -05:00
Elad Alfassa
1c157a8cf1 Fix env lookup plugin docs (#34235)
The env lookup plugin docs mistakenly mentioned dns TXT records,
and that it requires a DNS resolver library.
2017-12-26 05:20:33 -05:00
Ganesh Nalawade
dc1d6ec684
Add eos_l3_interface module (#34224)
*  eos_l3_interface module implementation
*  Integration test cases for eos_l3_interface module
2017-12-26 13:54:27 +05:30
Chris Houseknecht
d73be7f461
Remove diff and request data. Add more return docs. (#34230) 2017-12-25 21:50:58 -05:00
Chris Houseknecht
32f963aa0f
Prevent secret data from being logged (#34229) 2017-12-25 21:01:28 -05:00
Chris Houseknecht
ec3c31b1f4
Fail when model not found (#34227) 2017-12-25 16:45:19 -05:00
Chris Houseknecht
54396a95c2
Adds datetime encoder. Fixes Service comparison. (#34223) 2017-12-25 12:09:31 -05:00
Ganesh Nalawade
f1bda19dea
Fixes get_prompt() issue for network platforms using cliconf plugins (#34221)
Fixes #34220
2017-12-25 18:15:25 +05:30
Ganesh Nalawade
98f3424ed0
Fix ios_l3_interface configure ipv4 address issue (#34222)
Adding a new interface and it's ipv4/ipv6 address results
in failure. Add a check to validate if interface address is
already configured or not.
2017-12-25 18:11:35 +05:30
Samer Deeb
89670133c1 Module mlnxos_l3_interface (#34199)
* Add module mlnxos_l3_interface for configuring L3 on Mellanox switches

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Rename test class

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2017-12-25 13:21:40 +05:30
Chris Houseknecht
ad04c1854d
Granular K8s doc fragments (#34215)
* Makes doc fragment more granular

* Fix lint issues
2017-12-24 17:50:07 -05:00
Gaurav Rastogi
9e2ff3e4d5 Updated Avi Modules with new features and documentation update. (#34206)
* Updated Avi Modules with following
1. Support to perform patch operation using the modules. The data update method is
selected using avi_api_update_method=patch and patch operation is determined by
avi_api_patch_op. The patch data is the normal params that are provided in the modules

2. Support for avi_credentials as single authentication dictionary for all API calls.
This is preferred way as opposed to previously all credentials details would pollute
the individual Ansible tasks. It also allows the module development to be enhanced
without breaking compatibility for new authentication schemes like SAML etc.

3. Support for sharing api_context between the module invocations. This is a
workaround to not do multiple logins to Avi Controller and be able to
re-use single login across multiple REST API calls.

4. Documentation update for new parameters and existing ones with Units data.

* Fixed the pylint and pep8 errors caused due to pycharm editor auto formatting
2017-12-24 08:15:23 +00:00
Chris Houseknecht
9b4a1ed475
Reorganize k8s common (#34212)
* Reorganize k8s common

* Separates AnsibleMixin

* Fix lint issues
2017-12-23 16:41:38 -05:00
Samer Deeb
8ddb84a155 Add module mlnxos_vlan for supporting vlan configuration on Mellanox switches (#34113)
* Add module mlnxos_vlan for supporting vlan configuration on Mellanox
switches

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* use sgort header and fix METADATA

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2017-12-23 12:11:25 +05:30
Samer Deeb
dbcfea587c Add module mlnxos_l2_interface for supporting configuration of L2 interfaces on Mellanox switches (#34158)
* Add module mlnxos_l2_interface for supporting configuration of L2
interfaces on Mellanox switches

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* use shorter header and fix METADATA

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2017-12-23 11:24:35 +05:30
Ganesh Nalawade
d5061aa8e6
Add ios_l3_interface module (#34201)
* Add ios_l3_interface module

Fixes #31298

*  Add ios_3_interface module
*  Integration test
*  Return command response for load_config()

* Fix CI issues
2017-12-23 11:24:00 +05:30
Samer Deeb
0deda64231 Add module mlnxos_lldp for supporting configuration of LLDP protocol on Mellanox switches (#34159)
* Add module mlnxos_lldp for supporting configuration of LLDP protocol on Mellanox switches

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix header and metadata

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix imports

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2017-12-23 10:54:05 +05:30
Chris Houseknecht
1c391e777a
Improving docs and examples (#34155)
* Improving docs and examples

* Removes trailing whitespace
2017-12-22 17:12:17 -05:00
Tim Rupp
d19108e592
Adds more token cleanup (#34207)
Token cleanup assists in preventing the ansible modules from
overwhelming the existing tokens in bigip api
2017-12-22 12:54:56 -08:00
Tim Rupp
75fbfb9e36
Fixes and additions to bigip_pool (#34205)
Removes deprecated host/port params. Adds metadata param. Adds new
classes to better support refactoring and maintenance.
2017-12-22 12:39:19 -08:00
Tim Rupp
554ffd70f5
Adds token cleanup to bigip irules (#34203)
Token cleanup helps keep the bigip from getting wedged
2017-12-22 11:40:20 -08:00
Claes Nästén
5bd8a8f491 Add nso_query module to query Cisco NSO using XPath (#34188) 2017-12-22 16:56:50 +00:00
John R Barker
cd8632dd7f Specify default (#34186) 2017-12-22 04:58:55 -05:00
Claes Nästén
d6fd9703f1 Add nso_show module for Cisco NSO (#34142)
* update version parsing and move requirements to nso_* modules

prepare for introduction of nso_show module that has other version
requirements than the existing nso_* modules.

* Add nso_show module for retreiving config from Cisco NSO

New module that supports getting configuration and operational data
from Cisco NSO.
2017-12-22 09:43:22 +00:00
René Moser
0f32f01644
influxdb: new module influxdb_write (#33800) 2017-12-22 08:20:18 +01:00
Abhijeet Kasurde
2cb4a725b4 nmcli: Add 'type' as required param for few ops (#33796)
This fix adds user friendly message for 'type' argument.
The 'type' is a required param when performing 'create' or 'modify' operations
on network connection or device.

Fixes: #33680

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-22 02:07:50 -05:00
markocelan
c97030cc44 cloudflare: fix CNAME not changed (#33939) 2017-12-22 08:00:35 +01:00
Robin Roth
fcd3db27f9 Add comment on auto_import_key for .repo files in zypper_repository (#33941)
Fixes #32375
2017-12-22 01:05:47 -05:00
Toshio Kuratomi
5a80375be9 Correct the AnsibleError exception to call its superclass's constructor 2017-12-21 20:42:44 -08:00
Toshio Kuratomi
235bdfb996 Remove shell module specialcases
Shell is implemented via the command module.  There was a special case
in mod_args to do that.  Make shell into an action plugin to handle that
instead.

Also move the special case for the command nanny into a command module
action plugin.  This is more appropriate as we then do not have to send
a parameter that is only for the command module to every single module.
2017-12-21 20:42:44 -08:00
Jordan Borean
39800e1390
win_domain_group: added ability to specify AD server to interact with (#34166) 2017-12-22 11:06:22 +10:00
Gustavo Maia
8fba6e6684 [cloud] New module aws_scaling_policy (#31241)
* Add scaling_policy module

* Change exception format

* Rename scaling_policy module to aws_application_scaling_policy
2017-12-21 19:47:02 -05:00
Abhijeet Kasurde
fc4ab22f05 Add gr_name and pw_name in find module
The fix adds gr_name and pw_name in return output.
Integration test added.

Fixes: #25643

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-21 17:00:25 -05:00
David Soper
58239671c0 Ucsm WWNN/WWPN pools (#34017)
* vhba template and integration test

* SAN Connectivity Policies and integration test

* VSANs and integration tests

* WWNN/WWPN Pools and integration test

* WWNN/WWPN Pools and integration test

* option description spelled out (aliased to descr)
removed docs for list of dictionaries syntax
follow ACI indent style
state absent only requires dn name match (not full prop match)
2017-12-21 21:34:13 +01:00
David Soper
027f8dcafd Ucsm vsans (#34016)
* vhba template and integration test

* SAN Connectivity Policies and integration test

* VSANs and integration tests

* WWNN/WWPN Pools and integration test

* VSANs module and integration test

* removed docs for list of dictionaries syntax
follow ACI indent style
state absent only requires dn name match (not full prop match)
2017-12-21 21:30:10 +01:00
David Soper
02894fb972 Ucsm vhba template (#34015)
* vhba template and integration test

* SAN Connectivity Policies and integration test

* VSANs and integration tests

* WWNN/WWPN Pools and integration test

* vHBA templates and integration test

* option description spelled out (aliased to descr)
removed docs for list of dictionaries syntax
follow ACI indent style
state absent only requires dn name match (not full prop match)
2017-12-21 21:27:07 +01:00
David Soper
d80b873a69 UCS SAN Connectivity Policy module and integration test (#34009)
* vhba template and integration test

* SAN Connectivity Policies and integration test

* VSANs and integration tests

* WWNN/WWPN Pools and integration test

* SAN Connectivity Policies only

* option description spelled out (aliased to descr)
removed docs for list of dictionaries syntax
follow ACI indent style
state absent only requires dn name match (not full prop match)
2017-12-21 21:15:07 +01:00
Rob
2616f9d713 [cloud] Add encryption support to efs module (#32815)
* Add encryption support to efs module

* Update the exception handling in AWS EFS module
2017-12-21 13:51:46 -05:00
Sloane Hertel
f0cf1b35d5 [ec2_asg_facts] Add exception handling to describing the target groups in case they are in the process of being deleted. (#33997) 2017-12-21 13:48:23 -05:00
Sloane Hertel
cc6331f155 ec2_asg: remove AWSRetry from function with many boto calls (#32512)
* Remove AWSRetry.backoff decorator from function with many boto calls.

* Use retries to describe autoscaling groups
2017-12-21 12:37:22 -05:00
Brian Coca
a0c171ce1b fix command warnings, add action warnings (#34060)
* fix command warnings, add action warnings
2017-12-21 08:35:32 -08:00
Christopher Brown
ebd096a732 Add C and U metrics to oVirt provider (#34138)
Adds the path parameter to allow configuration of C&U metrics
on the oVirt provider. Expands example to match.
2017-12-21 08:57:22 -05:00
Pilou
459adf8966 ios_static_route: fix broken import (#34133)
* Fix broken import

* doc: add ipaddress in requirements
2017-12-21 17:12:19 +05:30
Trishna Guha
60f3649ebd
Convert nxos_vlan to DI module (#31866)
* Convert nxos_vlan to DI

* fix conflict

* push fix for qalthos's comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-12-21 14:08:33 +05:30
René Moser
276f7122cd
influxdb: default hostname to localhost (#34117) 2017-12-21 07:04:45 +01:00
René Moser
a067575cab
influxdb: new module influxdb_query (#33801) 2017-12-21 07:03:27 +01:00
Yuwei Zhou
dc1b8e9a31 Fix #33114: vmss has parameter load balancer (#33223)
* vmss has parameter load balancer

* fix lint

* fix indent

* fix as pull request comment

* fix yaml
2017-12-21 00:13:09 -05:00
Mohamed Javeed
5089122a32 Encode xml data to utf8 standard (#34079) 2017-12-21 10:10:18 +05:30
Nathaniel Case
9e09a9ea61 Turns out the order is important (#34116) 2017-12-21 09:26:30 +05:30
Martin Eisenhardt
606540c15d Fix typo in haproxy.py doc string (#31310) 2017-12-20 22:46:54 -05:00
Larry Smith Jr
fd03223227 Updated documentation description (#34121)
The description for this plugin was referencing Foreman rather than Logstash.
2017-12-21 13:44:54 +10:00
MarkusTeufelberger
070ea3270c add usage example for the assertonly provider (#34092) 2017-12-21 13:38:15 +10:00
Tim Rupp
34f47d5e88
Fixes url to no longer redirect (#34118) 2017-12-20 16:30:34 -08:00
Yuwei Zhou
4d6c28f8c3 #30142:Enable attach data disk to existing VM or detach it from VM (#32711)
* disk can be mounted to vm

* add version added

* fix lint

* Fix some mirrors

* fix lint

* remove trailing space

* fix as review comment

* fix yaml

* fix

* fix

* Minor update to doc on unmounting disk from VM
2017-12-21 07:53:14 +10:00
Brian Coca
8c6d823963 simpler loop_control defaults (#34008) 2017-12-21 07:28:38 +10:00
radixdlt
76590ab8a5 azure_rm_virtualmachine_scaleset: ported PR#32367 (add custom image support) (#33422) 2017-12-21 07:17:57 +10:00
Yuwei Zhou
37ce7ef0db Add azure image module support create and delete (#32589)
* Add azure image module support create and delete

* Add os_type description

* fix lint

* fix lint

* fix lint

* fix line ending

* add enum_modules for serialize

* update for python3

* Fix mirror

* fix lint

* fix as pr comments

* fix name

* fix syntax

* fix

* none check

* fix test

* fix syntax

* fix example

* return only id in the top level

* doc

* doc

* fix

* fix test
2017-12-21 07:05:36 +10:00
Sloane Hertel
d877c146ab [cloud] ec2_group fix CIDR with host bits set - fixes #25403 (#29605)
* WIP adds network subnetting functions

* adds functions to convert between netmask and masklen
* adds functions to verify netmask and masklen
* adds function to dtermine network and subnet from address / mask pair

* network_common: add a function to get the first 48 bits in a IPv6 address.

ec2_group: only use network bits of a CIDR.

* Add tests for CIDRs with host bits set.

* ec2_group: add warning if CIDR isn't the networking address.

* Fix pep8.

* Improve wording.

* fix import for network utils

* Update tests to use pytest instead of unittest

* add test for to_ipv6_network()

* Fix PEP8
2017-12-20 14:57:47 -05:00
kalimsshar
4086cb4b25 Added support for Cisco stacks in ios_facts.py (#33714) 2017-12-20 12:33:47 -05:00
Nathaniel Case
2e76c89910
IOS XR cli tests move to network_cli (#34007)
* Update task definitions for network_cli

* Add connection to debug messages

* Specify connection for prepare task

* pc won't be around for connection=network_cli

* Assorted Python 3 fixes

* Give default port if ansible_ssh_port missing

* delegate -> connection

* Extend error regex
2017-12-20 11:26:09 -05:00
Abhijeet Kasurde
5db9ac23ee
freeipa: Refactor ipa_dnszone (#34078)
Code refactoring of ipa_dnszone module
- use ipa_argument_spec
- use common documentation fragment

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-20 21:29:52 +05:30
John R Barker
c50da48049
Fix various RST warnings (#34084)
* Fix various RST warnings

* shorter lines
2017-12-20 15:20:05 +00:00
John R Barker
20174f1c47 Suggest using replace module rather than command sed (#34085)
* Suggest using replace module rather than command sed

* Better order
2017-12-20 10:00:32 -05:00
Kim Egede Jakobsen
fd2150f9fa Typo fix (#34088) 2017-12-20 14:53:17 +00:00
Pilou
4713d9ea44 ce_file_copy: fix broken import (#34023)
* fix broken import

* doc: use formatting functions
2017-12-20 14:44:01 +00:00
Trishna Guha
663f8464ee
eos_linkagg DI module (#33007)
* eos_linkagg DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* pep8 fixes

* Push fix for Qalthos's comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-12-20 19:43:30 +05:30
Nathaniel Case
cb1b705218
ios integration tests to network_cli (#33920)
* Preliminary steps

* Fix Python3 network_cli ios

* Add connection to debug strings

* Fix ios confirm prompt by way of optional newline

Also update ios_user delete tests
2017-12-20 09:03:29 -05:00
Abhijeet Kasurde
8d5c8b252d
VMware: Add support for cpuHotRemoveEnabled (#33962)
This fix adds support for cpuHotRemoveEnabled in vmware_guest module.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-20 19:15:55 +05:30
René Moser
09edb032d3
vultr: new module vr_firewall_rule (#32637)
* vultr: new module vr_firewall_rule

* vr_firewall_rule: fix typo

* fix styles
2017-12-20 13:42:21 +01:00
René Moser
acfa8d8b75
vultr: new module vr_ssh_key (#30961) 2017-12-20 13:41:33 +01:00
René Moser
73ddecd819
vultr: new module vr_firewall_group (#30960) 2017-12-20 13:41:07 +01:00
René Moser
cfd7325ac4
vultr: new module vr_server (#30869)
* vultr: new module vr_server

* minor restyling

* fix method name
2017-12-20 13:40:33 +01:00
Marc Tschapek
b3ff93e129 Added new module win_disk_facts (#32935)
* Added module new win_disk_facts

* Corrected examples section

* Added integration tests

* Added some disk properties

* Removed whitspaces

* Extended docu

* Changed header

* Added partition, volume and physical disk output

* Removed MediaType property of phys. disk

* Added return values

Added virtual disk, volume and physical disk output

* Added docu for return values

* Removed whitespaces

* Improved and added values

- Added virtual disk return values
- Improved code

* Updated docu

* Removed whitespaces

* Removed check

* Improved code and docu

* Changed integration test

* Changed integration test

* Changed integration test

* Changed integration test

* corrected typo

* Added admin test because CIM is not available with user rights

* Changed unit prefix from decimal to binary
2017-12-20 21:53:19 +10:00
Trishna Guha
4a4da2b774
nxos_static_route DI module (#33797)
* nxos_static_route DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add version_added
2017-12-20 17:08:29 +05:30
Kedar Kekan
78a14d7966
Cliconf and Netconf refactoring iosxr_interface (#33909)
* Cliconf and Netconf refactoring iosxr_interface

* adds `xml` key and related changes for netconf output

* * review comments changes
2017-12-20 13:06:07 +05:30
Fedor Sumkin
8a9865cb10 Fix for dns4 empty setting (#30757)
This fix check if DNS4 is None or not before proceeding with
other operations. Also, added unit test for this change.

Signed-off-by: Fedor Sumkin <qosys.net@gmail.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-20 12:48:22 +05:30
Abhijeet Kasurde
f7fe6a065e
VMware: Allow users to specify port for ESXi (#34073)
This fix adds 'port' as module parameter in VMware modules,
which allows user to specify vCenter or ESXi server port number for
admin connection.

Fixes: #34070

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-20 11:53:22 +05:30
Trishna Guha
be89822bb5
Deprecate nxos_portchannel and add nxos_linkagg DI module (#33376)
* deprecate nxos_portchannel

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos_linkagg DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* remove nxos_portchannel unit test

* fix syntax issues

* fix ansible-doc failure

* update nxos_portchannel unittest

* minor fixes and integration test

* update nxos_linkagg
2017-12-20 11:26:07 +05:30
Trishna Guha
3cce8dfafd
Deprecate nxos_ip_interface and Add nxos_l3_interface DI module (#33866)
* Deprecate nxos_ip_interface module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos_l3_interface DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* pep8 fixes

* Add nxapi cli test

* Improve complexity

* manage layer3 interface

* fix unit test
2017-12-20 11:07:23 +05:30
Trishna Guha
27be2a0f5a
Handle nxos platform diffs with cli conf implementation (#34020)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-12-20 10:41:10 +05:30
Brian Coca
2db3d861e0 lookup templated value of a var (#32772)
* lookup templated value of a var
* better dupe loop detection
* corrected invalid test loops
2017-12-19 22:41:50 -06:00
Abhijeet Kasurde
bc91258124 apt_get: add warning for force_apt_get (#33994)
This fix adds strict check for package manager binary checking in given
path.

Fixes: #32940

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-19 22:39:15 -06:00
Fabio Alessandro Locati
dc86f6f6d5 Easier to debug (#30675) 2017-12-19 22:33:11 -06:00
Toshio Kuratomi
2e1c889275
Have command nanny tell you how to disable the warning (#34061)
* Have command nanny tell you how to disable the warning
2017-12-19 17:30:10 -08:00
Toshio Kuratomi
cc7a5228b0
Deprecate check_invalid_arguments (#34004)
* Deprecate check_invalid_arguments

Check_invalid_arguments is a piece of functionality from the early days
of Ansible that should not be used.  We'll remove it in Ansible 2.9.
Deprecating it for now.
2017-12-19 14:36:02 -08:00
Sloane Hertel
7bc754674c
[template/vars] Use to_native(exception) as a fallback for Python 3 which doesn't have a .message attribute (#34044) 2017-12-19 17:34:46 -05:00
Toshio Kuratomi
b06f7688cd Fix a unicodeerror so that we get the correct error message (#34058)
Fixes #33044
2017-12-19 16:26:30 -06:00
Gobin Sougrakpam
e2de3c9776 [cloud] New module - AWS Direct Connect Gateway (#33890)
* Adding module for AWS Direct Connect Gateway

* Fixes for failing checks

* Fix errors for shippable checks

* Fix pep8 errors

* Fixes from review comments

* Simplify logic and add exception handling for every boto3 call

* Fix undefined variable
2017-12-19 17:22:18 -05:00
Sloane Hertel
bf8d695ec3
[ec2_vpc_peer] Remove use of DryRun since the module doesn't support check mode (#34062) 2017-12-19 16:42:26 -05:00
Chris Houseknecht
1a59247f27 K8s raw modules (#34050)
* New dirs, raw modules, and deprecations, 'openshift' not 'oc'
2017-12-19 15:25:33 -06:00
Brian Lamar
fcc79de246 Add support for intra-region VPC peering (#34036)
* [ec2_vpc_peer] Add support for intra-region VPC peering
2017-12-19 16:05:14 -05:00
Nathaniel Case
513c75079e
Port eos tests to network_cli (#33586)
* Add eos and fix tests to run multiple connections

* Update tests to report connection

* Add missing START messages

* Fix unspecified connection

* Python 3 updates

Exceptions don't have `.message` in Python 3

* Override `become` when using `connection=local`

* Slight restructuring to make eapi easier later on

* Move eapi toggle to prepare_eos
* Pull out connection on eapi tasks
2017-12-19 15:49:49 -05:00
Matt Bachmann
f64b276f6a Add option allowing the user to specify a custom cowpath
This allows the user to use custom cowsay implementations without shadowing common cowsay paths
2017-12-19 15:39:38 -05:00
Tim Rupp
96335b12bb
Fixes some verbiage in the f5 docs (#34057) 2017-12-19 12:33:55 -08:00
Toshio Kuratomi
120af786af Remove params option from examples 2017-12-19 12:04:14 -08:00
René Moser
168fb07cba
influxdb: make param database_name uncommon (#34021) 2017-12-19 20:51:07 +01:00
Øyvind Saltvik
b385e3d725 Add support for adding CORS to S3 bucket on AWS - fixes #29238 (#22284)
* Add aws_s3_cors module for adding/removing CORS to S3 bucket on AWS

Based on code found here but fixes some of the mentioned issues.

https://github.com/ansible/ansible-modules-extras/pull/1177/files
2017-12-19 14:23:51 -05:00
James Mighion
ded4e6ac0f Ios config save (#33885)
* Fixing save so it still works. Adding changed as an option for save_when.

* Updating description to state that changed was added in 2.5.

* Fixing removal version for deprecated options.
2017-12-19 18:04:21 +00:00
Brian Coca
73a003aa50 added slice filter for dicts
also minor exception optimization
2017-12-19 12:54:10 -05:00
Pilou
107934241e gcdns_record: fix broken import (#34024) 2017-12-19 12:31:35 -05:00
Samer Deeb
1df57ac1ac Add mlnxos_interface module (#33839)
* Add new module: mlnxos_interface for configuring mlnxos ethernet
interfaces

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Update mlnxos.py

* Fix Documentation

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Add missing documentation

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2017-12-19 17:24:42 +00:00
Sloane Hertel
58adf1750e [cloud] New a lookup plugin for AWS account attributes (#33025)
* Add a lookup plugin for AWS account attributes

* PEP8

* Use config system instead of hard coding logic for environment variables

* simplify logic

* Return a flattened dict to make using easier

* Reformat return example
2017-12-19 12:20:19 -05:00
Nonoctis
a3d65056db Fixed typo on git module doc (#34039) 2017-12-19 17:44:06 +01:00
bmildren
d668281a6b Added docs fragment for proxysql (#32502)
* Added docs fragment for proxysql

* Added formatting for option names, and bool types

* Updated proxysql modules to use doc fragments
2017-12-19 12:12:19 +00:00
Ethan Devenport
e693d7e37c New module: manage 1&1 cloud compute (cloud/oneandone/oneandone_server) (#24878)
* Added oneandone provider cloud server module.

* Updated comments, idempotency, handling of multiple resources.

* Added check mode support.

* fix validation errors
2017-12-19 11:31:39 +00:00
Trishna Guha
9f86b923e9
[CLI_CONF] Refactor nxos module common library to use cliconf plugin (#31524)
* refactor nxos modules

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* get_config update

* fix get_config

* update nxos module

* device_info

* fix conflict

* add failure message check

* pep8 fixes

* use get_capabilities to check cliconf

* Add logic to detect platform in get_capabilities and cache in module_utils

* return msg in edit_config

* fix conflicts

* make modules compatible

* fix nxos cliconf api

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* cache capabilities

* Update transport queries to get_capabilities in module level

* fix unit tests

* load_config error code

* remove unnecessary change

* Refactor nxos_install_os module
2017-12-19 12:22:33 +05:30
Chris Houseknecht
bd399ec674
Adds single, non-generated OpenShift module (#33645)
* Adds single, non-generated openshift module

* Adds kubernetes doc fragment

* Clarify docs
2017-12-18 20:04:50 -05:00
Chris Houseknecht
ead5b1d024
Adds single, non-generated K8s module (#33517)
* Adds k8s.py

* Two module approach to support overlapping objects

* Clarify docs

* Clary state and force parameters

* Updates examples

* Add description and display_name

* Fix linting issues
2017-12-18 20:04:35 -05:00
Chris Houseknecht
d629a5ece2
Refactors common code for new K8s and OpenShift modules (#33646)
* Refactors common code for new k8s and openshift modules

* Move Ansible module helper code from OpenShift client
2017-12-18 20:03:44 -05:00
Jordan Borean
92e52ef515 winrm: attempting to get kerb auth to work on MacOS (#33795)
* winrm: attempting to get kerb auth to work on MacOS

* moved to use pexpect if possible as it is simpler

* Made the pexpect event more lenient around different localisations
2017-12-18 18:49:21 -05:00
Loïc Blot
b25e333076 icinga2_host: Don't set template attribute on modification, it's not permitted (#33989) 2017-12-18 16:40:56 -05:00
Wojciech Pietruszeski
2a0cb20a1f win_get_url: Changed basic auth from NetworkCredential to Base64 (#32389)
* Changed basic auth from NetworkCredential to Base64

* Added force_basic_auth parameter to win_get_url module

force_basic_auth provides user with option to control which mechanism to use

Updated win_get_url.py documentation section

* Add missing version_added in win_get_url.py

* minor update for documentation
2017-12-19 06:38:44 +10:00
Toshio Kuratomi
370a7ace4b
Split basic units (#33510)
Split the one monolithic test for basic.py into several files

* Split test_basic.py along categories.
  This is preliminary to get a handle on things.  Eventually we may want
  to further split it so each file is only testing a single function.
* Cleanup unused imports from splitting test_basic.py
* Port atomic_move test to pytest.
  Working on getting rid of need to maintain procenv
* Split a test of symbolic_mode_to_octal to follow unittest best practices
  Each test should only invoke the function under test once
* Port test_argument_spec to pytest.
* Fix suboptions failure
2017-12-18 10:17:13 -08:00
Prasad Katti
ba32827f3b Cleanup route53_zone examples (#34000) 2017-12-18 12:43:15 -05:00
Prasad Katti
2cdbde524b route53_zone: fix the private zone creation example (#33995)
Creating a private hosted zone requires both `vpc_id` as well as `vpc_region`
2017-12-18 12:02:53 -05:00
Prasad Katti
423b5e475e update ec2_vpc_net return values in docs (#33902) 2017-12-18 09:29:29 -05:00
Ondra Machacek
4e85cdc712 ovirt: Set no_log for storage connections (#33987) 2017-12-18 06:07:23 -05:00
Yanis Guenane
a724b8e722 openssl_certificate: Return self.cert.get_VALUES() (#33970)
Currently when we make up the return value, we take values based of the
parameters rather than the generated openssl_certificate itself.

This commits returns the actual certificate values making it all time
accurate.
2017-12-18 14:34:34 +05:30
Baptiste Fontaine
571f878817 file: Mention that src supports state=hard (#31697) 2017-12-15 17:17:34 -06:00
nathaniel gentile
441dc369ba py3 compatibility: convert bytes to str (#33206)
Fixes #31723
In python3, ansible's fetch_url utility function wraps urllib.request.urlopen.
For HTTP and HTTPS URLs, this function returns a http.client.HTTPResponse object slightly modified.
Calling .read() on an HTTPResponse object returns bytes (note the docstring fix).

Here, to_native is used to convert the bytestrings returned by fetch_url into unicode strings.
This is necessary because:
  1. Pre python3.6, json.loads requires passing a string, not a bytestring, as its argument
  2. In python3 generally, testing if a string is a substring of a bytestring
     using the 'in' operator will raise a TypeError

see:
- https://docs.python.org/3/library/urllib.request.html#urllib.request.urlopen
- https://docs.python.org/3/library/http.client.html#http.client.HTTPResponse.read
- https://docs.python.org/3/library/json.html#json.loads
2017-12-15 16:17:15 -06:00
André Nähring
b9bc64c7f9 Adding param "rule_num" for insert action to iptables module (#33708)
* Added rule_num parameter for insert action in iptables module
2017-12-15 16:08:40 -06:00
Pilou
85871da03d consul_acl: fix broken import (#33729) 2017-12-15 16:06:11 -06:00
Brian Coca
87c75b19dd
dont warn on not matching 'all' (#32806)
* dont warn on not matching 'all'

the implicit localhost warning shoudl be enough

* centralized no hosts handling

also extended info on implicit only
2017-12-15 15:43:51 -05:00
Brian Coca
2b7799f817
added flatten filter (#33102)
* added flatten filter
2017-12-15 14:40:02 -05:00
Maxime de Roucy
c2ac9d0831 fix file attributes changed detection
https://docs.python.org/2/library/stdtypes.html#str.split
str.split([sep[, maxsplit]])
If sep is given, consecutive delimiters are not grouped together and are deemed
to delimit empty strings.

>>> "85563      ----------------C-- /var/lib/libvirt/images".split(' ')[0:2]
['85563', '']
>>> "85563      ----------------C-- /var/lib/libvirt/images".split()[0:2]
['85563', '----------------C--']
2017-12-15 09:48:18 -08:00
Matthew Staebler
82cd5ffa1d [aws modules] use ec2_url in a few places it was missing (#33954) 2017-12-15 12:06:24 -05:00
bdowling
d59bba4652 Fixes prompt doubling issue that impacted missing ios enable password prompts. (#33794)
* Fixes a prompt doubling issue that impacted missing ios enable password prompts.

Due to get_prompt sending a '\n' the prompts became doubled and out-of-sync with what
was expected.  This caused the enable command prompts to be missed.
Also added verification that on_become succeeded to reach enable prompt.

* Moved prompt doubling comment per shippable
2017-12-15 11:31:28 -05:00
Konstantin Shalygin
3c0a84349b [module] find: Add ability to exclude results by pattern. (#18949) 2017-12-15 09:27:34 -07:00
Nathaniel Case
f71bbdfed5
Fix vyos sending 'None' to device (#33889)
* Fix vyos sending `'None'` to device

* Move bytes handling into common cliconf code
2017-12-15 11:20:53 -05:00
Claes Nästén
5fdb39c4d1 nso_verify for Cisco NSO (#33945)
Module for verifying that configuration is as expected in Cisco NSO.
2017-12-15 13:43:07 +00:00
Abhijeet Kasurde
b5318e2c34
VMware: Add NIC configuration option (#33851)
This fix adds following configurable parameters to virtual network card
of virtual machine.
* WakeOnLanEnabled
* StartConnected
* AllowGuestControl

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-15 17:54:52 +05:30
Claes Nästén
b2bc98c161 nso_action for Cisco NSO (#32781)
nso_action module for execution actions/RPCs in NSO.
2017-12-15 11:29:04 +00:00
Abhijeet Kasurde
29d3505cb4
VMware: check for ESXi server while creating user (#33061)
This fix check for ESXi server instance before proceeding
with managing local user. Also, adds integration tests for
this change.

Fixes: #32465

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-15 16:26:19 +05:30
Abhijeet Kasurde
31510259f6 VMware: Refactor vmware_portgroup (#33703)
Fix adds following:
* Documentation update
* Idempotency
* Remove Portgroup functionality

Fixes: #33666

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-15 05:14:05 -05:00
Ganesh Nalawade
2f932d8767
Add parent pid to persistent connection socket path hash (#33518)
* Add parent pid to persistent connection socket path hash

Fixes #33192

*  Add parent pid in persistent connection socket path hash
   to avoid using same socket path for multiple simultaneous
   connection to same remote host.

* Ensure unique persistent socket path for each ansible-playbook run

* Fix CI failures
2017-12-15 10:21:56 +05:30
Abhijeet Kasurde
08a2338277
Add idempotency in snapshot creation (#28466)
Fix adds idempotent behavior while creating snapshot

Fixes: #24511

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-15 08:34:39 +05:30
Jordan Borean
0ca828ebab
win_iis_webapppool: stop any passwords from being returned (#33931) 2017-12-15 09:50:44 +10:00
Sloane Hertel
cae14e16ac Port ec2_vpc_net to boto3 and add support to expand existing VPCs - fixes #31216 (#33105)
* Port ec2_vpc_net to boto3 and add support to expand existing VPCs

* Add s-hertel as an author for ec2_vpc_net

* Update ec2_vpc_net test for new error triggered by lack of credentials

Fix backwards compatibility

Document new return value

* Fix pep8 and return documentation
2017-12-15 09:41:03 +10:00
Brian Coca
465ace4c14 else was wrong 2017-12-14 17:38:39 -05:00
Haridas N
0eb426bb9e HipChat API v2 support for ansible callback plugin (#33882)
* hipchat API v2 support for callback plugin.

* hipchat API v2 support for callback plugin.

* Migrated to new way of handling plugin config.
2017-12-14 17:30:31 -05:00
Tim Rupp
22059cbe67
Adds bigip_device_httpd module (#33924)
this module can be used to adjust the details of the server that
hosts the BIG-IP web ui.
2017-12-14 14:16:28 -08:00
Matt Martz
0b9f1f7982
Handle vault filenames with nonascii chars when displaying messages. Fixes #33879 (#33926) 2017-12-14 16:02:25 -06:00
Ted Timmons
ff4eb94a04 accept variants of returned json mime type (#33894) 2017-12-14 15:54:59 -06:00
Will Thames
ddc3465408 [cloud] Remove repeated error handling and region checking, both now in boto3_conn (#32774)
* Remove boto usage from boto3 modules

* Remove region checking

boto3_conn now takes care of region checking and handles NoRegionError
exceptions with a standard message

boto3_conn also takes care of other connection exceptions too.

* Document boto3 as a requirement for ec2_eni_facts
2017-12-14 16:16:59 -05:00
Mamad Purbo
c52964a6f4 [cloud] support encryption on create S3 folder (#33854) 2017-12-14 16:10:42 -05:00
Brian Coca
54e8e122bf
fix doc fragments (#33892)
* fix doc fragments

fixes #33864

* pop it
2017-12-14 16:06:47 -05:00
Stefan Horning
c421878523 [cloud] Return id of ENI in addition to network_interface_id for ec2_eni_facts (#33814)
* Return id of ENI in addition to network_interface_id. To be compatible to ec2_eni.

* Added documentation for the return values of the ec2_eni_facts module

* Fix typo in docs for ec2_eni_facts
2017-12-14 15:02:06 -05:00
Gaël Lambert
82949f6e6f lookup hashi_vault: Add Vault App role in auth_method (#22403)
Provide Vault App role method to the lookup.

https://www.vaultproject.io/docs/auth/approle.html

Usage :

`{{ lookup('hashi_vault', 'secret=secret/hello:value auth_method=approle role_id=myroleid secret_id=mysecretid url=http://myvault:8200')}}`

You can skip `role_id` and `secret_id` if you set `VAULT_ROLE_ID` and `VAULT_SECRET_ID` environment variables.
2017-12-14 13:25:05 -06:00
Adam Miller
6cb388a98a New Module: package_facts (#33195)
* new package_facts module

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>

* remove package_facts pkg manager aliases, they are misleading

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>

* fix package_facts tests now that aliases are dropped

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>
2017-12-14 13:47:47 -05:00
David Soper
d1cf9cfeb6 Connection and MAC pool module for Cisco UCS (#31151)
* Initial commit for UcsConnection and ucs_macpool module.
Configures MAC address pools on UCS Manager.

* ansible-doc fixes

* PEP8 fixes

* pep8, pylint, and validate-modules fixes

* Correct indent issue introduced during pycodestyle cleanup

* Simplified module arugment setup.
Placed all code in main to avoid multiple calls and arg passing.

* module_utils/ucs changed to UCSModule which now handles login/logout directly
login_handle removed from module.params
doc updates on mac_list params and change to first_addr/last_addr for mac blocks
checking of all mac params

* Move module_utils to remote_management/ucs
Fix validate-modules issue with docs

* UCS MAC pool integration tests
Fixed issues with MAC pool descr and address range params
2017-12-14 19:38:35 +01:00
Brian Coca
67c83823f2 Add q/query aliases to lookup (#33466)
* Add L alias to lookup, defaults to real list
* renamed to q/query as per core meeting
* also force wantlist=true
2017-12-14 11:53:00 -06:00
John R Barker
f127e5d535
Fix a few docs build issues (#33685)
Noticed when doing `make webdocs`
2017-12-14 17:33:27 +00:00
Prasad Katti
6995985a52 Pass in '**results' to exit_json only if results is a dict (#33910) 2017-12-14 10:59:56 -05:00
Brian Coca
11063dabaf fixed version_added, update clog 2017-12-14 10:41:46 -05:00
Brian Coca
1a7c096954
new redis lookup (#33883)
* new redis lookup

deprecated redis_kv

* typo fix
2017-12-14 10:35:46 -05:00
Nathaniel Case
67a8ff47aa
Promote get_prompt to live in network_cli instead of cliconf (#33880)
This removes the immediate need for a cliconf plugin to use network_cli
2017-12-14 09:51:41 -05:00
rhpvorderman
5578193ae4 Block markers in blockinfile no longer hard coded (#31787)
* Block markers in blockinfile no longer hard coded
2017-12-14 08:24:14 -06:00
Kairo Araujo
7a5ea9cae4 Included ansible_distribution_major_version #29561 (#31754)
Included ansible_distribution_major_version according with
issue #29561
2017-12-14 08:22:48 -06:00
Abhijeet Kasurde
4391f5c094
VMware: Handle No Permission exception while clone (#33806)
This fix adds exception handling for No Permission exception
raised while clone operation.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-14 19:13:23 +05:30
tchernomax
a09fd80bba VMware: fix vmPathName on VM creation (#33315)
* VMware: fix vmPathName on VM creation
* vmware_guest: enable unit tests disk_type_d1_c1_f0
2017-12-14 18:41:09 +05:30
Katerina Koukiou
137498bff1 cloud:ovirt:ovirt_storage_domains.py: Allow not passing dc_name parameter (#33377)
When state == absent we can skpi dc_name parameter.
This patch introduces same functionality for other states.
2017-12-14 07:53:42 -05:00
pmargara
5a4fd97955 Added 'quota' parameter and 'description' parameter to ovirt_disk module (#33860)
* Added 'quota' field and 'description' field to ovirt_disk module

* ovirt_disk: fixed example

* quota => quota_id and other improvement
2017-12-14 07:53:16 -05:00
James Mighion
f8e3cfe9e2 Aruba indenting (#33884)
* Fixing aruba's inconsitent indenting.

* Adding config with different children indentation and unit test to confirm the different spacing does not matter.

* Fixing pylint check. Missed an r prefix.
2017-12-14 14:37:34 +05:30
Jurgen Brand
7bb55bdc2b Added icinga2_host module (#31720)
* Added icinga2_host module

* Fix build error

* trailing spaces and other errors from ansible build process

* Formating

* docu errors

* last spacing; import module

* fix imports

*  Removed request lib for ansible.module_utils.urls

* small whitespace fixes

* Remove typo

* Fix docu

* icinga2_hosts to icinga2_host in naming

* Update example
Fix Dewotine error when delete a none existing host

* Fixes docu problems

* White spaces

* small text improvements

* Remove force argument from module and docu

* Set author correct ( and hopefull the maintainer )

* Minor formatting changes
2017-12-14 07:38:22 +01:00
Gurchet Rai
490dc40203 Fix DO_API_KEY environment variable check (#33512)
`os.environ['DO_API_TOKEN']` raised a `KeyError` preventing the check
for `os.environ['DO_API_KEY]` from being executed. Fix this by failing
only if the api token isn't set.
2017-12-14 00:07:45 -05:00
Brian Coca
be5d68f3ad
add support for other scms to pull (#33152)
* add support for other scms to pull

* show choices for scms module in help
2017-12-13 22:16:54 -05:00
Jacob McGill
3b941802ac ACI ENCAP POOL RANGES: Add new module to support encap ranges (#33758)
* ACI ENCAP POOL RANGES: Add new module to support encap ranges

* fix module name

* remove extra format string
2017-12-14 00:35:50 +01:00
Brian Coca
afa82be019 make become prompt method agnostic (#33789)
fixes #33747
2017-12-13 17:57:06 -05:00
Brian Coca
ad94a3a6a2 fix reconcile to ensure 'ungrouped'
also removed redundant 'hosts to all' as all groups already ensure that inheritance
2017-12-13 17:29:01 -05:00
David Kretch
98260f9884 Fix pamd error when inserting a new rule at the end. Fixes #28487 (#28488)
* When inserting a new rule in `insert_after_rule`, check if the old rule is
the last rule, to avoid a list index out of range error when attempting to
access the next rule.
* Add a test for inserting a new rule after the last rule.
2017-12-13 15:31:20 -06:00
Russell Parks
158b32cd7a user: Fix add for SuSE Linux Enterprise 11 (#27015) 2017-12-13 15:30:51 -06:00
XuXinkun
7229eba569 use docker exec in case docker cp failed. (#26571) 2017-12-13 15:30:30 -06:00
Anil Kumar Muraleedharan
890b97a38f Lenovo enos bugfixes (#33857)
* Bug Fixes to issues foubd during testing

* Removing blank line

* undefined-variable Undefined variable 'run_commands' and training new line

* Reverting and Modifying changes with both Unit test and Integrated test with Devices passing
2017-12-13 20:57:51 +00:00
Will Thames
15a58d498d [cloud] Improve snake <-> camel conversion for AWS utils (#31400)
Allow CamelCase version of snake_dict_to_camel_dict
(currently only dromedaryCase is supported)

Add reversible option to camel_dict_to_snake_dict

Add tests for both of these options
2017-12-13 15:13:26 -05:00
Nathaniel Case
2425374fdd
Actually move vyos tests to network_cli (#33710)
* Fix vyos on network_cli on python3

bytes do not have format() in Python3

* Push connection to tasks, with bonus connection=local test

* Run tests without explicit connection set

* Add/update START messages where appropriate
2017-12-13 14:30:24 -05:00
John R Barker
cfb15b0272 Revert "YAML inventory unit test: fix test inventory format (#33828)" (#33869)
This reverts commit dfb2f346d8.

https://github.com/ansible/ansible/pull/33828
2017-12-13 14:19:19 -05:00
Alex
2f67d3a4f3 facts: Fix duplicate IPs in ipv4_secondaries (#32040) 2017-12-13 14:05:20 -05:00
Adam Miller
ae92426e72 fix ci, duplicate exception checking was merged in wait_for (my fault)
Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>
2017-12-13 09:53:39 -08:00
Mans Matulewicz
beef269d46 Update mount.py (#23906)
added noauto to dvd mount example, simply copy pasting + removed (virtual) optical disc will result in a non booting system (centos7)
2017-12-13 11:37:01 -06:00
Austin S. Hemmelgarn
50ceb8d7d8 wait_for: change file check to handle directories and sockets (#20979)
open(path) throws an error when called on a directory or UNIX socket,
and therefore a check to ensure that the path is absent will always
succeed when there is a directory or file located there.

This updates the check to use os.access(path, os.F_OK) instead, which
instead just checks that the path exists instead of trying to open it as
a file, and therefore properly handles directories and sockets.

This causes a slight semantic change in how permissions are handled.
The existing code will fail to work correctly if the user running the
module on the managed host has no read access to the path specified.
The new code will work correctly in that situation.
Both versions fail if the user can't traverse the parent directory.

I've also added a check to the try block to catch OSError. I've seen
this call fail with an OSError on rare occasion in the face of odd
extended permissions (usually MAC configuration) in cases where it
should technically return False. In such cases, the file is functionally
inaccessible to the user making the call, so it's essentially not there,
but it can't be created by them either. I've documented this, as well as
the fact that the bug this change fixes exists, and a rather nasty
inconsistency involving symbloic handling that I stumbled across while
testing this change.

Fixes: #20870
2017-12-13 11:10:19 -06:00
tchernomax
29bed12cdd vmware_host: add reconnect and add_or_reconnect states (#30582)
* vmware_host: add reconnect and add_or_reconnect states

Add "reconnect" and "add_or_reconnect" choices for "state".

* reconnect: reconnect an esxi to a vcenter (imply it is present).
* add_or_reconnect: do the same but add the esxi if absent.

Also:
* tag the cluster_name as required (because it is).
* tag esxi_username and esxi_password as not required because
    they aren't when the esxi isn't added.

* vmware_host: add + prepare/document integration tests

vmware_host module

Add integration test for the add part of "add_or_reconnect" state.

Prepare and document integration tests for the reconnect part
of "add_or_reconnect" state and "reconnect" and "absent" states.

Currently we can't test those states as ReconnectHost_Task (for
"reconnect") and EnterMaintenanceMode_Task (for "absent") aren't
implemented yet in vcsim (from vmware/govmomi)
2017-12-13 11:13:12 -05:00
cyrill
d08179593f Add a new option firstmatch to lineinfile module. (#33825)
* Add a new option firstmatch to lineinfile module.

* Add firstmatch option in DOCUMENTATION

* Fix indent

* Add version_added "2.5"
2017-12-13 09:49:44 -06:00