Matt Martz
19d99e0da6
Remove some broken and unnecessary required args logic
2016-12-08 11:22:38 -05:00
Matt Martz
63e5d5dcc4
Use rax_to_dict and make sure to return the volume details after deletion
2016-12-08 11:22:38 -05:00
Brian Coca
02a1cb62df
corrected release when this feature was added
2016-12-08 11:22:38 -05:00
Patrik Lundin
88fe45d7e7
Update OpenBSD rcctl handling to use new syntax.
...
See http://marc.info/?l=openbsd-cvs&m=142054488027109&w=2
2016-12-08 11:22:38 -05:00
Matt Martz
3a46c79451
Clean up some required argument logic
2016-12-08 11:22:38 -05:00
Matt Martz
db5f2bf3df
Just use built in required functionality for arguments
2016-12-08 11:22:38 -05:00
Matt Martz
617048b717
It is not correct that you need at least 1 primary node
2016-12-08 11:22:38 -05:00
Tim G
b2e39265e1
Load distutils on all platforms EXCEPT Solaris.
...
Solaris doesn't ship distutils with with the default Python package. This patch fixes "service" on Solaris since 30d6713.
2016-12-08 11:22:38 -05:00
Toshio Kuratomi
1728f9bba7
Add detection of uid,gid,mode changes when deciding whether an archive needs to be unarchived again.
2016-12-08 11:22:38 -05:00
Brian Coca
65d3b167e6
now captures cache fetch failures
2016-12-08 11:22:38 -05:00
Toshio Kuratomi
f9a6ec95b0
Implement user,group,mode,selinux settings for unarchive.
...
This is a partial fix for #234 . Still have to figure out how to
make change reporting work as we can no longer rely on tar's --compare
option
2016-12-08 11:22:38 -05:00
Toshio Kuratomi
44354e31e4
Better error messages if a2enmod/a2dismod are not found
2016-12-08 11:22:38 -05:00
Toshio Kuratomi
f3d41cdb06
Potential fix for 640
2016-12-08 11:22:38 -05:00
Tim G
ea77ac076b
distutils is not available on some non-Linux OS's
2016-12-08 11:22:37 -05:00
Alex Clifford
d4c4dd31d8
Fix slight typo in doco
2016-12-08 11:22:37 -05:00
Toshio Kuratomi
e11ea4b402
Also catch mysql errors so we can give the error message back through json rather than tracebacking
2016-12-08 11:22:37 -05:00
Michael Scherer
0a745de765
Do not use echo shell builtin for password
...
Using \t in a password may result in a different password
being set :
$ echo 'a\ta'
a a
Problem report originally found by Pilou-
( https://github.com/ansible/ansible-modules-extras/pull/198 )
2016-12-08 11:22:37 -05:00
Michael Scherer
b154bf967e
Remove unused code
...
There is no call to yum_base using 'cachedir' argument, so
while it work fine from a cursory look, that's useless code,
and so should be removed to clarify the code.
2016-12-08 11:22:37 -05:00
Michael Scherer
2dfc7122af
Use the rpm python module rather than execing rpm
...
Using the rpm module prevent a uneeded fork, and permit
to skip the signature checking which slow down a bit the
operation, and which would be done by yum on installation
anyway.
2016-12-08 11:22:37 -05:00
Bruce Pennypacker
605a5a5b53
requested changes
2016-12-08 11:22:37 -05:00
Bruce Pennypacker
9cbe3eb8ae
Added support for 'REQUIRE SSL' grant option
2016-12-08 11:22:37 -05:00
Brian Coca
a3de4db57d
fix for allowing permissions on hard links and soft links + follow=yes
2016-12-08 11:22:37 -05:00
Toshio Kuratomi
e75dc7e5a6
Clarify documented behaviour of user module's ssh_key_file parameter
...
Fixes #9873
2016-12-08 11:22:37 -05:00
Brian Coca
c5dfc66cb1
added version added for new template options
2016-12-08 11:22:37 -05:00
Vasyl Kaigorodov
d41ec7027f
gce_net - creating firewall rule, src_range value seems to get lost or set to empty string -- fixes #252
2016-12-08 11:22:37 -05:00
James Martin
07dbc333b2
vpc_zone_identifier must be a csv string when an asg is updated.
2016-12-08 11:22:37 -05:00
Brian Coca
9eb77bdb4f
fix for when state=directory, follow=yes and target is symlink to directory
2016-12-08 11:22:37 -05:00
Philip Misiowiec
f3abfa0f19
Adds tenancy state to returning json
2016-12-08 11:22:37 -05:00
Johnny Robeson
6fc04862a4
rename FedoraStratgy to SystemdStrategy
2016-12-08 11:22:37 -05:00
Michael J. Schultz
588d03db8d
Build the db connection on "postgres"
instead of "template1"
...
According to the postgresql docs[1], you should not have a connection with
`"template1"` when copying multiple databases.
[1]: http://www.postgresql.org/docs/9.1/static/manage-ag-templatedbs.html
2016-12-08 11:22:36 -05:00
Jeff Gonzalez
30822706dd
Added ability to use url as key source
2016-12-08 11:22:36 -05:00
Michael Scherer
d357f309b5
Fix #370 , by allowing to export over a existing repository
...
This requires to use force=True
2016-12-08 11:22:36 -05:00
Michael Scherer
e1194116b2
Make force parameter work for export operation
...
The default is changed from 'yes' to 'no' to follow
subversion behavior (ie, requiring explicit confirmation
to erase a existing repository). Since that was not working before
cf #370 and since the option was ignored before and unused, this
should be safe to change.
2016-12-08 11:22:36 -05:00
Patrik Lundin
9803938663
Handle string returned by 'default' correctly.
...
We need to handle the string returned by 'default' in the same way we handle
the string returned by 'status' since the resulting flags are compared later.
2016-12-08 11:22:36 -05:00
Jesse Buchanan
06a58dcad7
Files module: Allow touch on hardlinks
2016-12-08 11:22:36 -05:00
Patrik Lundin
d88080007a
Fix typo: Replace "N0" with "NO".
2016-12-08 11:22:36 -05:00
anatoly techtonik
59a700ad17
acl: Fix X support in ACL permissions
...
If you try to set rwX permissions, ACL fails to set them at all.
Expected:
$ sudo setfacl -m 'group::rwX' www
...
drwxrwxr-x 2 root root 4096 Nov 10 17:09 www
With Ansible:
acl: name=/var/www permissions=rwX etype=group state=present
...
drwxrw-r-x 2 root root 4096 Nov 10 17:30 www
x for group is erased. =/
2016-12-08 11:22:36 -05:00
Patrik Lundin
6594a1458d
Multiple fixes for OpenBSD rcctl handling.
...
* Use the newly added 'default' argument to know if the default flags are set
or not.
* Handle that 'status' may either return flags or YES/NO.
* Centralize flag handling logic.
* Set action variable after check if we need to keep going.
Big thanks to @ajacoutot for implementing the rcctl 'default' argument.
2016-12-08 11:22:36 -05:00
Ricky Cook
522c644bf1
Fix regex string format
2016-12-08 11:22:36 -05:00
Ricky Cook
a6a9e2c247
Get warn option same as other args
2016-12-08 11:22:36 -05:00
Ricky Cook
095400c45e
Add comment to command options dict
2016-12-08 11:22:36 -05:00
Ricky Cook
5e21c81ca4
Simplify command module option parsing
2016-12-08 11:22:36 -05:00
Luís Guilherme F. Pereira
b347875de0
Allow ec2_lc to create EC2-Classic Launch Configs
...
Removes default value from ec2_lc so it can create launch configurations valid on a EC2-Classic environment. AWS API will not accept a assign_public_ip when creating an ASG outside of VPC.
2016-12-08 11:22:36 -05:00
Nate Coraor
771fdfb1f8
Fix a few bugs and misbehavior in the hg module: 1. Don't pull when dest
is already at the desired changeset. 2. Don't change the working copy when cleaning or pulling and a revision was specified. 3. Change the default for the revision
param to match the behavior of hg.
2016-12-08 11:22:36 -05:00
Jonathan Mainguy
aef138107c
Fixes bind mounts
...
Fixed tab's and spaces, or so I think I did
Fixed tabs and spaces for real this time
2016-12-08 11:22:36 -05:00
Jonathan Mainguy
6be46cb2e3
Fixes --enable-repo for Oracle Linux
2016-12-08 11:22:35 -05:00
Jonathan Mainguy
13990e9479
adds error message if socket does not exist
2016-12-08 11:22:35 -05:00
Philip Misiowiec
c57c1ea419
added version
2016-12-08 11:22:35 -05:00
billwanjohi
b019076dd3
user: add expired state
...
ported from
https://github.com/ansible/ansible/pull/6303
It's very useful and routine to disable a *nix user.
I implemented expired instead of locked because this prevents any use of
the account, safer than just preventing password-based authentication.
I have tests [1], but since none of the suite came along with the core
modules, I'm unsure how to submit them.
[1] https://github.com/billwanjohi/ansible/blob/add_locked_state/test/integration/roles/test_user/tasks/main.yml
2016-12-08 11:22:35 -05:00
kustodian
447c625cb3
Set selinux state to 'permissive' for state=disabled
2016-12-08 11:22:35 -05:00
Michael Scherer
36c653f54a
Add hostname to generated user SSH key comment
...
The default is not very useful to sort between different
keys and user. Adding the hostname in the comment permit to later
sort them if you start to reuse the key and set them in different
servers. See https://github.com/ansible/ansible/pull/7420
for the rational.
2016-12-08 11:22:35 -05:00
Phillip Holmes
0d3b144eb2
Route53 fix - forcing zone_in, record_in to lower case
...
Fixed the .tolower to .lower() for correct syntax (copied change from older notes).
2016-12-08 11:22:35 -05:00
Philip Misiowiec
23668e41b0
Support for EC2 dedicated tenancy option
2016-12-08 11:22:35 -05:00
Philip Misiowiec
d30881a461
Ability to detach an EBS volume from an EC2 instance
2016-12-08 11:22:35 -05:00
fabios
3c53b3b268
mark as upgradable and let apt-get install deal with it
2016-12-08 11:22:35 -05:00
fabios
043242df2c
improve fail message and use itertools chain
2016-12-08 11:22:35 -05:00
fabios
21bfa80203
older python-apt compatibility
2016-12-08 11:22:35 -05:00
fabios
301c8b8e09
handle list of list for python-apt < 0.7.9 compatibility
2016-12-08 11:22:35 -05:00
Lorin Hochstein
88d5f15025
docker: fix volume[s]_from typo
...
Code makes reference to volume_from instead of volumes_from. If volumes_from is
passed as an argument, generates a KeyError.
2016-12-08 11:22:35 -05:00
Toshio Kuratomi
1dc2ae0aef
Cleanup the old apt compatibility changes
2016-12-08 11:22:35 -05:00
fabios
0ad355585a
use low-level apt_pkg.Package
2016-12-08 11:22:35 -05:00
Jan Weitz
8146b45203
Fixes invalid dictionary access.
2016-12-08 11:22:35 -05:00
FabioBatSilva
a748229f3a
fix compatibility issues with python-apt < 0.7.9
2016-12-08 11:22:34 -05:00
Mark Phillips
786aceb43b
vsphere_guest fix for KeyError: folder message
2016-12-08 11:22:34 -05:00
Jan Weitz
1b9d0c5987
Fixes version check for docker-py
2016-12-08 11:22:34 -05:00
Toshio Kuratomi
1be539d870
git fetch --tags overwrites normal fetching with git < 1.8.x so do a normal fetch followed by using the refspec format for fetching tags
2016-12-08 11:22:34 -05:00
Toshio Kuratomi
73b7d6ea7b
Fix typo in git refspec code. Change lists to tuples
2016-12-08 11:22:34 -05:00
Brian Coca
945909bf67
update to use connect_to_region to avoid errors with china
2016-12-08 11:22:34 -05:00
Brian Coca
abdb1afa0a
Revert "Merge pull request #384 from jhawkesworth/win_copy_file_template_ansible_modules_core_1" I missed some discussion in devel, these need more work before inclusion
...
This reverts commit 58bfebb0477adda2a676381850038e0abf8c8f00, reversing
changes made to 27dee77ca0449bdb338b2db89e044d1d9b553b4a.
2016-12-08 11:22:34 -05:00
Peter Oliver
432a6286db
Fix appending to a user's group on Solaris
...
Without this change, you get:
AttributeError: 'set' object has no attribute 'extend'
Tested on a Solaris 11.2 client with the included Python 2.6.8.
2016-12-08 11:22:34 -05:00
Toshio Kuratomi
5c090207ff
Make documentation clear about update=no vs clone=no
2016-12-08 11:22:34 -05:00
Chris Church
9d0830a181
Change version added in win_user docs to 1.9 for updates that didn't make it into 1.8.
2016-12-08 11:22:34 -05:00
Rohan McGovern
b607ffb7c6
git: add 'refspec' argument
...
This argument may be used to fetch additional refs beyond the default
refs/heads/* and refs/tags/*. Checking out GitHub pull requests or Gerrit
patch sets are two examples where this is useful.
Without this, specifying version=<sha1> with a SHA1 unreachable from any
tag or branch can't work.
2016-12-08 11:22:34 -05:00
Rohan McGovern
06ff34f364
git: clean up "fetch" method
...
De-duplicate repetitive code checking the exit code.
Include the stdout/stderr of the failed process in all cases.
Remove the returned values because no caller uses them.
Combine git commands where possible. There is no need to fetch branches
and tags as two separate operations.
2016-12-08 11:22:34 -05:00
Toshio Kuratomi
d28cd02ab7
Newstyle class
2016-12-08 11:22:34 -05:00
Toshio Kuratomi
4aaba45e29
Make insecure_registry feature version check against the client API
2016-12-08 11:22:34 -05:00
Maksim Losev
807d964a48
Add insecure_registry to docker-py pull method
...
Starting from docker-py>=0.5.0 it is impossible to work with private registries based on HTTP.
So we need additional parameter to allow pull from insecure registry
Related to ansible/ansible#9111
2016-12-08 11:22:34 -05:00
Toshio Kuratomi
7b74e451d9
Make docker ver checks issue failures rather than silently ignoring
...
Also:
* make client version checks robust for two digit version pieces and
alpha versions
* consolidate version checking code
2016-12-08 11:22:33 -05:00
Will Thames
834c8d2f59
Added better region handling and enabled eu-central-1
...
Make use of improved connect_to_aws that throws an exception
if a region can't be connected to (e.g. eu-central-1 requires
boto 2.34 onwards)
Add eu-central-1 to the two modules that hardcode their regions
Add us-gov-west-1 to ec2_ami_search to match documentation!
This pull request makes use of the changes in ansible/ansible#9419
2016-12-08 11:22:33 -05:00
Ingo Gottwald
f88107bc9b
Add support for new docker restart policies
2016-12-08 11:22:33 -05:00
Toshio Kuratomi
8af70de1fc
Probably would make clone a 1.9 feature rather than 1.8.3
2016-12-08 11:22:33 -05:00
Toshio Kuratomi
a7ff6c4cba
Make git's update parameter revert to its old behaviour and add new clone parameter to take its place.
...
Fixes #426
Fixes https://github.com/ansible/ansible/issues/8630
2016-12-08 11:22:33 -05:00
Kale Franz
7c8f0b99af
#531 correction
...
correct list comprehension for older versions of python (back to python 2.4)
2016-12-08 11:22:33 -05:00
Kale Franz
eac743dc39
fixes #529 ec2_group module bug
2016-12-08 11:22:33 -05:00
Toshio Kuratomi
104b2d684c
Add text/json as a mimetype to try deserializing
...
Fixes #503
2016-12-08 11:22:33 -05:00
Jonathan Mainguy
8c05023be3
Fixed hostname for rhel5 python 2.4.3
2016-12-08 11:22:33 -05:00
zitterbacke
1d4808780f
re-enable AIX password setting
...
the AIX class uses a unsafe shell for setting the user password (containing a pipe in the command). This patch adopts to the new behavior of module_utils/basic.py (since somewhere around 1.7).
besides it changes the qoutes for the echo command from double to single, because password-hashes contain $-signs and one would not have this variables expanded.
2016-12-08 11:22:33 -05:00
Toshio Kuratomi
123c99f879
Add error message from git to message returned from ansible
...
Fixes #81
2016-12-08 11:22:33 -05:00
Jeff Gonzalez
8eedd915cd
Fixed formatting in documentation
...
The example was using mixed shorthand and long form yaml (region: "us-east-1 disable_rollback=true"
I modified the entire example to be long form.
2016-12-08 11:22:33 -05:00
Jeff Bradberry
60ed80f99a
Fix breakage in lineinfile check mode when target file does not exist.
...
Similarly to https://github.com/ansible/ansible/issues/6182 , checking of the file attributes should be avoided in check mode when the file didn't originally exist.
Also, avoid creating parent directories in check mode.
Fixes https://github.com/ansible/ansible/issues/9546
2016-12-08 11:22:33 -05:00
Michael Scherer
104f91ed3b
Revert commit cbc417c, as the code is broken, see #438
...
LooseVersion expect a string, so filtering to return a int
is incorrect. Thanks to Jeremy Brown for the analysis.
2016-12-08 11:22:33 -05:00
sysadmin75
7fbb422ae7
Fixes #9518 - "file state=directory" silently skips if it's currently a file
2016-12-08 11:22:33 -05:00
kustodian
8621f9a7cd
Fixed postgresql_db failing on Python 2.4 with --check
...
This reverts commit 81cbdb6c8cf54c41ba2ee3330c968e2feea05a5c and adds ignoring of the SystemExit exception because of Python 2.4.
2016-12-08 11:22:33 -05:00
Toshio Kuratomi
e359f7cfcf
Don't traceback if a gid is specified instead of a group name
...
Fixes https://github.com/ansible/ansible/issues/9796
2016-12-08 11:22:33 -05:00
Mike Putnam
d2d0ffd83a
Type fix on delete_snapshot docs.
2016-12-08 11:22:32 -05:00
Toshio Kuratomi
37f237ecfc
Fixup the directory name at a higher level so it can be used by both conditional branches
...
Fixes #500
2016-12-08 11:22:32 -05:00
Jon Hawkesworth
44cc1a75ba
Switched to SHA1 checksum instead of MD5
2016-12-08 11:22:32 -05:00
Harald Skoglund
1a8b9b8935
add support for stack policies in cloudformation
2016-12-08 11:22:32 -05:00
Jon Hawkesworth
67def35795
Adding first pass at win_copy, win_file and win_template modules (include new files).
2016-12-08 11:22:32 -05:00
Harri Hämäläinen
299d28f7e5
Fixed typo in comment
2016-12-08 11:22:32 -05:00
Brian Coca
6d56767454
fixed hostname for gentoo
2016-12-08 11:22:32 -05:00
Matt Martz
411e4cfae8
Make a few enhancements to the rax_scaling_group module
...
* Cast loadbalancer id and port to integers
* Do not attempt to base64 encode NoneType values
2016-12-08 11:22:32 -05:00
Petros Moisiadis
63b18ae618
mysql_user: Added missing privileges
...
Added missing privileges 'CREATE TABLESPACE' and 'PROXY' (see: http://dev.mysql.com/doc/refman/5.5/en/privileges-provided.html ).
2016-12-08 11:22:32 -05:00
PikachuEXE
fbba80d72e
~ Add missing documentation for option email
2016-12-08 11:22:32 -05:00
Andrew Shults
2390184084
Strip white space to support multiline permissions in YAML
2016-12-08 11:22:32 -05:00
Toshio Kuratomi
88ccfc219a
Change git update param documentation to match reality
2016-12-08 11:22:32 -05:00
Toshio Kuratomi
8b586ad055
Before pulling submodules from repos add ssh hostkeys for those submodules
...
Fixes #9655
2016-12-08 11:22:32 -05:00
Mike Putnam
1de5248a0a
Clarify possible variable value in the docs.
2016-12-08 11:22:32 -05:00
Toshio Kuratomi
6f3f0904eb
Fix git mod so that we switch to the desired version even if it was previously downloaded
2016-12-08 11:22:32 -05:00
Toshio Kuratomi
59066f6138
Some cleanups to the git module
2016-12-08 11:22:32 -05:00
Toshio Kuratomi
fc15177e6e
Revert git module doc update because it appears ssh:// works and bare ssh repo does not
...
This reverts commit e715909831e27cbfed2ae86e886bf154cefd7b6c.
2016-12-08 11:22:31 -05:00
Marcus Ahle
a71b1b7385
Preventing Nonetype is not iterable error when no tags are passed in for a newly created ASG
2016-12-08 11:22:31 -05:00
Ben Whaley
6609ebde27
vpc_zone_identifier should be a list as per the docs
2016-12-08 11:22:31 -05:00
Brian Coca
77ec45e3d1
vastly simplified systemd detection, made enable/disable errors clearer both of which allows us to remove 'service name detection' as if systemd is init we still use it to handle initscripts.
2016-12-08 11:22:31 -05:00
Brian Coca
8b9772565e
now actually adds usable name for systemd when service only has init script
2016-12-08 11:22:31 -05:00
Peter Bwire
20eb900065
Update django_manage to add database option for migrate
...
Allow passing the database option to the django_manage module for migrations. This is usefull in situations where multiple databases are used by a django application.
2016-12-08 11:22:31 -05:00
Dale Bewley
65d8fbd9ab
use state parameter in examples
2016-12-08 11:22:31 -05:00
follower
b15a633103
Note that rsync
must be installed on both local & remote machine
...
In particular, if `rsync` is not installed on the remote machine the following error message will be encountered:
"rsync error: remote command not found"
2016-12-08 11:22:31 -05:00
Toshio Kuratomi
9fde3c2dc5
Add USAGE as a valid privilege
2016-12-08 11:22:31 -05:00
Scott Miller
c49a20b0e5
fix documentation
...
AWS does not recognize the subnet if it is presented in a comma delimited format with spaces. you must remove the space for Amazon to recognize the second subnet.
2016-12-08 11:22:31 -05:00
Toshio Kuratomi
cd7cc07e85
Gixes to doc formatting
2016-12-08 11:22:31 -05:00
Francois Deppierraz
181c3aa25f
Fix auto_floating_ip documentation
...
The default value is 'no' instead of the currently documented 'yes'.
See cloud/openstack/nova_compute.py line 543:
auto_floating_ip = dict(default=False, type='bool'),
2016-12-08 11:22:31 -05:00
Toshio Kuratomi
307116b838
Fix typo so docs will build
2016-12-08 11:22:31 -05:00
Toshio Kuratomi
7ff9b3990a
Update cron example for setting to run twice a day
...
Fixes #415
2016-12-08 11:22:31 -05:00
Tomasz Kontusz
103b5954c7
supervisorctl: Don't try to start a starting program
...
Starting a "STARTING" program throws ERROR (already started),
so don't do that.
2016-12-08 11:22:31 -05:00
Steve Fox
7af1c96623
retry_interval needs to be a float before passing to time.sleep
2016-12-08 11:22:31 -05:00
Lorin Hochstein
0cf3cfbf5a
git doc: don't prepend ssh:// for ssh repo
...
The github ssh example has ssh:// at the beginning of the url. However, this doesn't
work. It does work if the ssh:// is removed.
2016-12-08 11:22:31 -05:00
Chris Church
ff193241b1
Minor win_user fixes based on feedback.
2016-12-08 11:22:30 -05:00
Brian Coca
ab96ff8b6d
service cleanup
2016-12-08 11:22:30 -05:00
Stewart Rutledge
0f1bf6c8c1
Fixed a typo on power options
2016-12-08 11:22:30 -05:00
Jérémie Astori
c52bfe3e35
Fix #91 : Expand user home folder for the key_file path of the git module
2016-12-08 11:22:30 -05:00
Chris Church
262624ca12
Update win_feature module to work on server 2008 and fail with error message on non-server windows, fix output messages and error handling.
2016-12-08 11:22:30 -05:00
Chris Church
c81c192dcb
Update win_user module to support more user options and group membership changes.
2016-12-08 11:22:30 -05:00
sterutkb
944ce9c7c3
Added support for deploying virtual machine from a virtual template
2016-12-08 11:22:30 -05:00
Michael Scherer
4e4e0cca17
Fix old ticket #9092 where a playbook can enter in recursion
...
This can be tested with this command :
ansible -c local -m copy -a 'src=/etc/group dest=foo/' all
This is a corner case of the algorithm used to find how we should
copy recursively a folder, and this commit detect it and avoid it.
Check https://github.com/ansible/ansible/issues/9092 for the story
2016-12-08 11:22:30 -05:00
Philip Misiowiec
3f4d412bff
Ability to specify new SSD EBS option
2016-12-08 11:22:30 -05:00
Patrik Lundin
8a6a4a7757
Simplify self.arguments logic.
...
Strange logic pointed out by @jarmani, thanks!
2016-12-08 11:22:30 -05:00
Patrik Lundin
2b18e544f5
Depend more on rcctl if it is present.
...
* Make the module support enable/disable of special services like pf via rcctl.
Idea and method from @jarmani.
* Make the module handle when the user supplied 'arguments' variable does not
match the current flags in rc.conf.local.
* Update description now that the code tries to use rcctl for everything if it
is available.
2016-12-08 11:22:30 -05:00
Will Thames
63656e5ef7
Fixed tagging
2016-12-08 11:22:30 -05:00
Denver Janke
61cfccff1c
Fix few bugs around renaming db instances.
2016-12-08 11:22:30 -05:00
Will Thames
daac0e3a3e
Improved error handling
...
More tests, particular for failure testing
2016-12-08 11:22:30 -05:00
Patrik Lundin
25c3c03a11
Tweak error checking for "enabled" code.
...
Based on input from @jarmani:
* A return value of 2 now means a service does not exist. Instead of
trying to handle the different meanings of rc after running "status",
just look at stderr to know if something failed.
* Skip looking at stdout to make the code cleaner. Any errors should
turn up on stderr.
2016-12-08 11:22:30 -05:00
Patrik Lundin
32cb025b85
Fail if "rcctl status" writes to stderr.
2016-12-08 11:22:30 -05:00
Patrik Lundin
03d4b76b14
Check rc and print error message if any.
...
It is probably good to use stdout before printing a generic error
message as well.
2016-12-08 11:22:29 -05:00
Patrik Lundin
38d8db473f
Make "enabled" code aware of --check mode.
2016-12-08 11:22:29 -05:00
Jonathan Armani
d1433eca14
Add enable / disable of services for OpenBSD if rcctl is present
2016-12-08 11:22:29 -05:00
Will Thames
22a3b3f811
RDS rewrite to use boto.rds and boto.rds2
...
Using rds2 allows tags and the control over whether or not DBs are
publicly accessible.
Move RDS towards a pair of interfaces implementing the details of rds
and rds2
Added tests to ensure that all operations work correctly as well as
requirements files that allow virtualenvs to test either boto.rds or
boto.rds2
2016-12-08 11:22:29 -05:00
Antti Salminen
75e15e2ae9
Find the actual commit annotated tags refer to instead of the tag object.
2016-12-08 11:22:29 -05:00
willthames
ef88ff6dd8
Added the ability to remove snapshots
...
Added state option, and accompanying snapshot_id option for
when state=absent.
2016-12-08 11:22:29 -05:00
Michael DeHaan
f875cc5197
Remove potentially out of date or specific product references.
2016-12-08 11:22:29 -05:00
Michael DeHaan
76efaa6cfb
More EC2 doc tweaks
2016-12-08 11:22:29 -05:00
Michael DeHaan
590d20db24
Misc EC2 doc tweaks.
2016-12-08 11:22:29 -05:00
Toshio Kuratomi
ddc81c7b93
Escape % in db+table names before adding to a format string being passed into db.execute()
...
Fixes #416
2016-12-08 11:22:29 -05:00
Dan
fe787f1bc9
Adds a login_unix_socket option to the postgresql_privs module.
2016-12-08 11:22:29 -05:00
Dan
ee65c55fb0
Adds a unix_socket/login_unix_socket option to the postgresql_user module.
2016-12-08 11:22:29 -05:00
Dan
789ee410f1
Adds a login_unix_socket option to the postgresql_db module.
2016-12-08 11:22:29 -05:00
René Moser
ceeeea84cd
yum: add update_cache option
...
Yum does not always update to latest package version unless metadata cache has expired. By runing yum makecache, we ensure the metadata cache has been updated.
Signed-off-by: René Moser <mail@renemoser.net>
2016-12-08 11:22:29 -05:00
Toshio Kuratomi
5734838cd1
Fix module traceback instead of returning an error
2016-12-08 11:22:29 -05:00
Eric
11bd0fed9d
Fix lineinfile documentation typo
2016-12-08 11:22:28 -05:00
Achilleas Pipinellis
872f6aa559
Clarify supported init systems.
2016-12-08 11:22:28 -05:00
follower
4889701874
Fix typo of "rules_egress"
...
Or is "rules_egree" supposed to be a plural? The sentence is difficult to parse.
Maybe the correct fix is to "Purge existing rules on security group that are not found in rules_egress"?
2016-12-08 11:22:28 -05:00
Pascal Borreli
187b07e6c0
Fixed typo
2016-12-08 11:22:28 -05:00
Fabrice Bernhard
3d437b068e
Typo in comments
...
Credit goes to @kbsali
@pborreli : you did not see that one? :-)
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
e8081baca9
Fix for single role_attr
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
47b009b001
Add a bare grant to the list of allowed privileges
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
b00e6464e9
Fix cornercase tracebaxk when detecting whether submodules changed
2016-12-08 11:22:28 -05:00
Devin Christensen
b2829cf6b9
Fix user_alter in postgresql_user
2016-12-08 11:22:28 -05:00
Devin Christensen
ff7a9eb625
Fix user_add in postgresql_user
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
bed60553ca
Escape mysql identifiers
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
87b2afc272
Correct new function name
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
3e9771f544
Normalize privs and flags to uppercase so comparisons against allowed names will work
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
e0ac340f59
Make sure we quote or confirm good all user provided identifiers
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
d3787840a4
Audit escaping of identifiers in the postgresql_user module
2016-12-08 11:22:28 -05:00
Toshio Kuratomi
32aaa07325
More robust quoting of database identifiers
...
Note: These aren't database values, those are already using the
appropriate Pyhton DB API method for quoting.
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
f7fafa8c16
Cannot readlink() on a hard link
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
3e09de7aef
Fix git module checking out correct version after initial clone
...
Fixes #313
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
1af6a85492
Correct variable name
2016-12-08 11:22:27 -05:00
Brian Coca
78fb3217d6
service now detects systemd is actually running, not just installed
2016-12-08 11:22:27 -05:00
Jonathan Mainguy
a71ce0615a
fixes user module for rhel5 by using -n instead of -N, all other distros will still use -N
2016-12-08 11:22:27 -05:00
Henry Finucane
2363074dd8
If force=true, ignore python-apt's advice
...
This lets you downgrade packages, for instance.
2016-12-08 11:22:27 -05:00
IndyMichaelB
07d4ddfeff
docfix for vsphere_guest.py
...
Corrected parameter name from user to username in documentation
2016-12-08 11:22:27 -05:00
Sam Kottler
bb9c7acc2f
Remove trailing whitespace in digital_ocean_domain
2016-12-08 11:22:27 -05:00
Nejc Zupan
442c8a5457
digital ocean: Remove unsupported states
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
81978cbacb
Fix retrieval of package version in apt module
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
83e43415da
Documentation update for apt version wildcards from bryanlarsen
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
9472a27345
Clean up the docker module just a little so that we can unittest the get_split_image_tag function
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
f45e70fdbc
Moving unittests to the main ansible repo for now
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
615b954cd8
Update package_status and install to account for wildcarded versions.
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
1ca1b80fe8
Decide to allow pkgname and version wildcards so that things like libxml2*=2.9* would work
2016-12-08 11:22:27 -05:00
Toshio Kuratomi
37fa22eb93
Cache pkg name list so we don't recreate the list for every package
2016-12-08 11:22:26 -05:00
Toshio Kuratomi
6b776da7bc
Just make things a little more readable
2016-12-08 11:22:26 -05:00
Toshio Kuratomi
f2c1d49de7
Correct trivial spelling.
2016-12-08 11:22:26 -05:00
Toshio Kuratomi
945447e392
if __name__ does work with ansible modules
2016-12-08 11:22:26 -05:00
Michael Vogt
e360582c4a
add apt unittest
2016-12-08 11:22:26 -05:00
Michael Vogt
80d520dde8
Allow foo=1.0* like expressions in apt
2016-12-08 11:22:26 -05:00
Robert Estelle
4e2d05b1f3
Remove incorrect executable permissions.
2016-12-08 11:22:26 -05:00
Adam Miller
c707107e1b
fix gce_net add firewall rule example
2016-12-08 11:22:26 -05:00
John Batty
dd78dde449
Fix get_flavor_id() when flavor_ram is specified
...
Without this fix, _get_flavor_id() fails to find a matching flavor if
both:
* the flavor_ram parameter is specified
* the first flavor in the list does not match.
The bug is simply that the module.fail_json() call lies within the loop
iterating through the flavors. This call should only be made if the
loop completes and no matching flavors have been found.
2016-12-08 11:22:26 -05:00
Brian Coca
5d16410518
corrected comparisson which had accidentally chaned in previous fixes
2016-12-08 11:22:26 -05:00
Brian Coca
9de01b8e10
better handling of deprecated aliases
2016-12-08 11:22:26 -05:00
Brian Coca
f91859c817
make sure 'present' is fully equivalente of 'installed' and remove installed from feedback in favoer of 'present'
2016-12-08 11:22:26 -05:00
James Martin
dd46f7275f
asg will now be terminated if state=absent.
...
adds mutually exclusive options
2016-12-08 11:22:26 -05:00
James Cammarata
e9fbb5f1b6
Serialize tag attributes to ASG properties in ec2_asg
...
Fixes #108
2016-12-08 11:22:26 -05:00
James Martin
f59a1348ad
Removes orphaned code.
2016-12-08 11:22:26 -05:00
James Martin
17cd9d18b0
fixes #240 , #274 , #108
2016-12-08 11:22:26 -05:00
Brian Coca
ba040784b8
let implied type do the spliting
2016-12-08 11:22:25 -05:00
Brian Coca
7d577e4447
minor fixes to wait_for to avoid tracebacks as per ansible core issue #9244
2016-12-08 11:22:25 -05:00
Jeff Geerling
5d103793ee
Add mention of fetch module to the copy module docs.
2016-12-08 11:22:25 -05:00
Brian Coca
c071d6a85c
switched to iterator as per comments
2016-12-08 11:22:25 -05:00
James Cammarata
a32a50568e
Use new prompt detection in run_command to detect aptitude prompts
...
Also adds flags to aptitude command when force=yes is used, in order
to bypass the prompts given for untrusted packages.
Fixes #31
2016-12-08 11:22:25 -05:00
Martijn P. Rijkeboer
fcf527557d
Fix whitespace around '=' in sysctl.conf.
2016-12-08 11:22:25 -05:00
José Moreira
82450c6811
Fixed small typo on ec2 task name
2016-12-08 11:22:25 -05:00
Francois Deppierraz
9620346c36
Fix a typo in nova_compute documentation string
...
Without this patch, ansible-doc was failing this way:
$ ansible-doc nova_compute
Traceback (most recent call last):
File "/home/francois/WORK/dev/ansible/bin/ansible-doc", line 324, in <module>
main()
File "/home/francois/WORK/dev/ansible/bin/ansible-doc", line 316, in main
text += get_man_text(doc)
File "/home/francois/WORK/dev/ansible/bin/ansible-doc", line 112, in get_man_text
desc = " ".join(opt['description'])
KeyError: 'description'
2016-12-08 11:22:25 -05:00
Brian Coca
a91b5fc170
made hostname work with python 2.4
2016-12-08 11:22:25 -05:00
Fwiffo
64e07acb19
typo in comments: of -> or
2016-12-08 11:22:25 -05:00
Toshio Kuratomi
34d65647bf
Move from md5 to sha1 to work on FIPS-140 enabled systems
2016-12-08 11:22:25 -05:00
Michael DeHaan
98fdc389d0
Deprecate docker_image, use the docker module to deploy docker images, or shell out to docker to call docker build if you want from a playbook.
2016-12-08 11:22:25 -05:00
Brian Coca
a091d8c59a
added missing init.py for utilities modules
2016-12-08 11:22:25 -05:00
Brian Coca
5a467bc72c
added __init__.py to new cloud subcategories so builds work again
2016-12-08 11:22:25 -05:00
Michael DeHaan
d31ac79269
Move internal category to utilities to remove one more category from the left hand menu, keeping it concise.
2016-12-08 11:22:25 -05:00
Michael DeHaan
677ed39cb4
Renames.
2016-12-08 11:22:25 -05:00
Michael DeHaan
5d814d9fb2
Some more module categorization.
2016-12-08 11:22:25 -05:00
Brian Coca
32e85c0944
made subcategories for cloud modules for better organization
2016-12-08 11:22:24 -05:00
James Cammarata
bb9433f198
Fail in ec2 if exact_count is specified without using count_tag
...
Fixes ansible/ansible#9431
2016-12-08 11:22:24 -05:00
Toshio Kuratomi
dfd4433fba
Fix git module handling of the recursive flag
...
Fixes : #169
2016-12-08 11:22:24 -05:00
Toshio Kuratomi
5fc463eee7
Update desctiprion, parameter name, and default value as discussed in #55
2016-12-08 11:22:24 -05:00
Lorin Hochstein
5c06bb6dca
ec2_snapshot: document wait, wait_timeout params
...
Document the wait and wait_timeout params for ec2_snapshot.
This is important because snapshots can take a long time to complete,
and the module defaults to wait=yes.
2016-12-08 11:22:24 -05:00
Ashish Ranjan
57ce7b1ea1
fields in /proc/net/tcp* are not always delimited by single space
2016-12-08 11:22:24 -05:00
Adam Chainz
dddc5ffd2c
Update syntax for cloudformation example
2016-12-08 11:22:24 -05:00
Jaanus Torp
7be83dc844
Fixed really annoying omission in the example without the task would complete without errors or warnings but delete all egress rules
2016-12-08 11:22:24 -05:00
Toshio Kuratomi
1429507489
Fix for systemd service scripts with newlines
...
Fixes #127
2016-12-08 11:22:24 -05:00
CptLausebaer
a572f85d43
correct requirement of parameter dest
...
The parameter "dest:" is required, but it is documented as "required: false".
2016-12-08 11:22:24 -05:00
Toshio Kuratomi
bcc058249c
Use original_basename to set the dest path even if src is not set
2016-12-08 11:22:24 -05:00
Tim Gerla
26698246c3
Fix a typo of a function call
2016-12-08 11:22:24 -05:00
Richard Glew
dac24deeb4
Fixed bug #193 where parameter name was set incorrectly
2016-12-08 11:22:24 -05:00
Jorge Bastida
d82bfcb75f
Initialize create_changed and replace_changed
2016-12-08 11:22:24 -05:00
Sapan Bhatia
d492544714
Added user, tenant and password to module parameters declaration -- these parameters are already handled by the implementation
2016-12-08 11:22:24 -05:00
Ted Timmons
6e900744f2
fix spelling
2016-12-08 11:22:23 -05:00
James Cammarata
dd2807ef3c
Strip newlines off k=v pairs in command/shell argument parsing
...
Fixes ansible/ansible#9272
2016-12-08 11:22:23 -05:00
Lorin Hochstein
06218fe7d2
apt_key: add keyserver example to docs
2016-12-08 11:22:23 -05:00
Jon Hadfield
f63ad7894e
Remove redundant check for creates argument.
2016-12-08 11:22:23 -05:00
Tadej Janež
9a845a03f4
Simplified condition in a stat module example testing if path is a directory.
2016-12-08 11:22:23 -05:00
James Cammarata
429ab56e14
Adding file doc fragment to those modules in files/ missing it
2016-12-08 11:22:23 -05:00
Joe Adams
6eda3cbee7
Added note to files/synchronize module about synchronizing two directories on the same host
2016-12-08 11:22:23 -05:00
Tongliang Liu
59477d2e9a
Added support of returning owner's group name in stat module
2016-12-08 11:22:23 -05:00
anatoly techtonik
90091b1277
files.stat: Expose path in returned result
...
This is needed to apply subsequent operation on tested path
2016-12-08 11:22:23 -05:00
Matt Martz
cce5b600c0
Don't count DELETED servers when adding new servers
2016-12-08 11:22:23 -05:00
Matt Martz
6a6faeb506
Fix determination if a few configurations change in the launch config
2016-12-08 11:22:23 -05:00
Matt Martz
e905162571
Ensure that files is the right type, and that we send the formatted personality var
2016-12-08 11:22:23 -05:00
Matt Martz
591ba934c3
Support config_drive and user_data in rax_scaling_group
2016-12-08 11:22:23 -05:00