Colin Heinzmann
1d14de1d8c
fixed win_nssm escaping issue ( #22512 )
...
* bugfix: applicaiton setting was not properly escaped leading to issues
when picking application under C:\Program Files (x86)\...
2017-07-14 10:11:02 -07:00
Brian Coca
52e6c54d49
ignore as maintainers as requested ( #26813 )
...
see #22512
2017-07-14 13:06:59 -04:00
Nathaniel Case
61249995a1
Update nxos_interface_ospf & add test ( #26644 )
...
* Update nxos_interface_ospf & add test
2017-07-14 12:31:36 -04:00
Dylan Silva
ba000abe1c
Added in dates for freeze ( #26814 )
...
* Added in dates for freeze
* Update ROADMAP_2_4.rst
2017-07-14 09:30:09 -07:00
Jordan Borean
eb1ed6567c
win_regedit: rewrite to support edge cases and fix issues ( #26468 )
...
* win_regedit: rewrite to support edge cases and fix issues
* fix up byte handling of single bytes and minor doc fix
* removed unused method
* updated with requested changes
2017-07-14 09:28:49 -07:00
Ricardo Carrillo Cruz
080e9ee694
Add missing test_cases var to eos_vrf and eos_vlan ( #26815 )
2017-07-14 18:28:32 +02:00
Greg
3506febbb9
Fixing issue related to writing ini files
...
When the file is opened with rwa+ and the update file size is smaller than the original the ini file can become corrupt. The issue was noticed when we had comments at the top of /etc/yum/pluginconf.d/rhnplugin.conf after using the rhn_register module the file became correct.
rwa+ also make no sense as the file is only written too and why would any appending need to happen?
2017-07-14 11:20:32 -04:00
Ricardo Carrillo Cruz
9d95ea0832
Bump EOS EAPI set hostname timeout param ( #26810 )
...
For some reason, it's taking longer as usual in CI, bumping it
makes the tests to pass on my manual testing.
2017-07-14 17:10:53 +02:00
Matt Clay
76158db10c
Improve sanity import test messaging. ( #26782 )
2017-07-14 08:04:43 -07:00
Jonan
088b930808
Update service.py
...
Ensure "initctl status servicename" passes along arguments to check correct instance.
2017-07-14 10:57:10 -04:00
Arne de Laat
c536f7789b
In cronvar only use '-u {user}' if self.user is not the current user
...
Use the same logic as in the cron module.
2017-07-14 10:44:31 -04:00
Brian Coca
c581ae4b8d
corrected version
2017-07-14 10:25:40 -04:00
Peter Shrom
80e88a7d40
updated version added
2017-07-14 10:25:41 -04:00
Peter Shrom
de5fb8d98c
adding ability to set openstack image ids
2017-07-14 10:25:41 -04:00
Gawain
6608629d25
Add 'mac_address' to the attributes returned from the vmware_vm_facts module ( #26527 )
...
* Add 'mac_address' to the attributes returned from the vmware_vm_facts module
* fix pep8 issue
2017-07-14 10:25:20 -04:00
Ricardo Carrillo Cruz
ca5439e1e2
Switch to save_when on EAPI tests as well ( #26807 )
...
save is deprecated.
2017-07-14 16:15:23 +02:00
Ganesh Nalawade
751ad7021c
vyos implementation for net_interface module ( #26799 )
...
* vyos implementation for net_interface module
* vyos_interface implementation module
* vyos_interface integration test
* net_interface integration test for vyos
* Change collection to aggregate
2017-07-14 19:39:21 +05:30
Abhijeet Kasurde
a1977d9654
Remove redundant get_obj method ( #26324 )
...
vmware_guest_facts has redundant get_obj method, this can
be removed safetly.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-07-14 10:04:10 -04:00
Abhijeet Kasurde
c10a59b745
Add testcase for vmware_vm_facts ( #26342 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-07-14 10:03:45 -04:00
Toshio Kuratomi
e986e31a75
This function is for setting variables on hosts. So those two parts are always required.
...
Don't have to check for the existence of those in the function. If they
aren't set to iterables then it should be up to the calling code to
handle it.
2017-07-14 07:03:26 -07:00
Abhijeet Kasurde
b4a58b65fb
Add param for snapshot subtree removal ( #26576 )
...
Fix adds a parameter for removing snapshot subtree.
Fixes : #26522
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-07-14 10:00:37 -04:00
Matt Clay
789218c215
Initial ansible-test sanity docs. ( #26775 )
...
* Rename no-iterkeys test for consistency.
* Require docs for all ansible-test sanity tests.
* Initial ansible-test sanity docs.
* Fix capitalization of Python.
* Fix sanity code smell test false positives.
* Fix another code-smell false positive.
2017-07-14 14:24:45 +01:00
Peter Sprygada
b9a1998af5
changes changed
to modified
in save_when choices ( #26801 )
2017-07-14 15:08:19 +02:00
Peter Sprygada
3bbb32cac5
fixes error when trying to run show start over eapi ( #26800 )
2017-07-14 15:07:44 +02:00
Abhijeet Kasurde
156b29b26b
Fix for check_mode in archive ( #26788 )
...
Fix adds check_mode fix for archive module. Also,
adds unit tests for archive module
Fixes : #26750
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-07-14 09:06:17 -04:00
Ricardo Carrillo Cruz
8333a8b908
Fix eos_config defaults logic ( #26798 )
...
Current code is bogus, it was passing flags all unconditionally.
2017-07-14 13:43:17 +02:00
Robin Roth
d4482761ba
Make lujeni only maintainter of mongodb_user ( #26789 )
2017-07-14 11:16:26 +01:00
Robin Roth
a94055f0e1
Update pip maintainers ( #26790 )
...
mattupstate is no longer active and agreed via email to pass on
maintainership
2017-07-14 11:15:56 +01:00
Lujeni
661791dcb7
Fix the editable condition into pip module ( #19028 ) ( #19688 )
...
* Fix the editable condition into pip module (#19028 )
* Add editable to tests
Default changed to False, so now editable: True is needed explicitly in
tests
2017-07-14 10:54:04 +01:00
Morgan Robertson
44730c28cc
Allow creation of Mongo user via localhost exception ( #22792 )
...
* Allow creation of user with localhost exception.
Fixes #22791
When access control is enabled, Mongo allows a user to be created from
localhost (called the "localhost exception":
https://docs.mongodb.com/v3.2/core/security-users/#localhost-exception ).
When the `update_password` parameter was added to this module in
Ansible 2.1, this functionality was broken due to a query performed
before `user_add()` is called. This fix only performs the query when
when `update_password` is set to `on-create`, allowing a user to be
created via the localhost exception.
* Only set `password = None` when user exists.
2017-07-14 10:52:19 +01:00
Lujeni
640131c464
Missing documentation about the include directive for requirements files ( #20090 )
...
* Missing documentation about the include directive for requirements files
* Code block needs blank line
* Correct casing
2017-07-14 10:48:51 +01:00
Matt Clay
7bc85f9b44
Restore zypper tests. ( #26784 )
...
* Revert "Temporarily disable zypper tests due to timeouts."
This reverts commit 25f943e22f
.
* Revert "Disable zypper_repository tests due to errors."
This reverts commit 5833197a19
.
2017-07-14 00:18:32 -07:00
Matt Clay
e1b9af9082
Add retries to remote test package installs.
2017-07-13 22:29:11 -07:00
Will Thames
0ed1c3ba9c
Split up testing IAM policies and automate creating them ( #26223 )
...
* Split up testing IAM policies and automate creating them
Move to managed policies to avoid the 5KB limit on policies
for an IAM entity.
The policy file is templated, so need to make sure that there
is an easy mechanism to populate the templates and push the
new policies.
* Update IAM policies for ec2_scaling_policy tests
* Fix RouteTable policies
DescribeRouteTable should be plural
ModifyRouteTable does not exist, but ReplaceRouteTableAssociation
does.
* Some IAM policies do not allow specified Resources
Various IAM policies do not allow Resources
to be specified and should just use `*`. This differs
per service
* [Autoscaling](http://docs.aws.amazon.com/autoscaling/latest/userguide/control-access-using-iam.html#policy-auto-scaling-resources )
* [EC2](http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ec2-api-permissions.html#ec2-api-unsupported-resource-permissions )
* [ECR](http://docs.aws.amazon.com/AmazonECR/latest/userguide/ecr-supported-iam-actions-resources.html )
* [ELB](http://docs.aws.amazon.com/elasticloadbalancing/latest/userguide/load-balancer-authentication-access-control.html )
* Finish fixing AWS IAM resource specifications for testing
Update Lambda and RDS policies
2017-07-14 14:50:55 +10:00
scottb
4f01a323a0
Replace 'simple module development' topic ( #26267 )
...
* WIP: Initial bulk move of quick start content into rst docs. Needs rewrite.
* Swapping out old quick start for new material (thanks @tstringer!). Still work in progress.
* Fixed formatting; removed extraneous file.
* Fixed some formatting errors.
* Once more, with feeling.
* Fixed formatting error
2017-07-13 19:06:01 -07:00
jctanner
245a4d30b9
vmware_guest: fix datastore selection on equal sized disks and add tests ( #26774 )
...
* Fix datastore selection on equal sized disks and add tests
2017-07-13 22:02:33 -04:00
Will Thames
df321e8579
[cloud] change iam_managed_policy return to snake_case ( #26219 )
...
* Change iam_managed_policy to return snake case
Import module_utils.ec2 methods explicitly
* iam_managed_policy: tidy argument spec
Remove unnecessary specifications (`default=None`, `required=False`)
Use `required_if` to check for `policy` when `state` is `present`
* Provide exception handling in iam_managed_policy
Pretty much all AWS API calls can go wrong, and we should handle them.
Update line wrapping to improve readability of method calls
* Improve error handling when policy version limit exceeded
Better document policy version limit exceeded, and check
the error code to see that that's actually what happened
(rather than e.g. no permissions to add a new version)
* iam_managed_policy: better handle pagination and retry
2017-07-13 21:30:41 -04:00
Takuya Sato
179e2882f7
ecs_taskdefinition module: containers.environment convert to string ( fix #23297 ) ( #23681 )
...
It is to fix the failed comparison of containers.
2017-07-13 20:10:31 -04:00
Rene Moser
a4359d5818
cloudstack: cs_role: add integration tests
2017-07-14 00:51:35 +02:00
Rene Moser
6d81c9670f
cloudstack: cs_role: fix UnboundLocalError in check mode
2017-07-14 00:51:35 +02:00
Brian Coca
3a1b84153c
ensure all groups inherit from 'all'
2017-07-13 18:38:39 -04:00
Brian Coca
84367eacef
added ansible_remote_tmp inventory var ( #26754 )
...
* added ansible_remote_tmp inventory var
* fixed horrible crime of no space after #
2017-07-13 15:31:10 -07:00
Matt Clay
462444b2be
PEP 8 fix.
2017-07-13 15:07:40 -07:00
Nathaniel Case
62e4353ba1
nxos_facts cleanup ( #26192 )
2017-07-13 16:56:04 -04:00
Nathaniel Case
f3acf9c929
Fix NX-API json handling ( #26716 )
2017-07-13 16:23:24 -04:00
Graham Mainwaring
cde36b883c
Fix pycrypto backend setting to work when multiple distros are specified in DEB_DIST
2017-07-13 12:13:54 -07:00
Sloane Hertel
ed51380c2c
[cloud] ec2_vol module snapshot and volume_size are not mutually exclusive ( #26764 )
2017-07-13 15:08:03 -04:00
Pilou
2a92120ffa
INI inventory plugin: add documentation about variable types ( #25798 )
...
* INI inventory: check variable types
* INI inventory: add doc about variable types
Fixes #25784
2017-07-13 12:04:20 -07:00
Ricardo Carrillo Cruz
af4dc6d0eb
Add vyos_lldp and vyos_lldp_interface modules ( #26753 )
...
* Add vyos_lldp and vyos_lldp_interface modules
* Fix module docstring issue
* Fix bogus aggregate reference
* Add vyos_lldp integration tests
* Add vyos_lldp_interface integration tests
* Remove unused import for run_commands
* Add VyOS net_lldp integration tests
* Remove junos and netconf from net_lldp integration tests
* Add net_lldp_interface integration tests
* Correct CLI filtering tests for VyOS
* Fix pep8 issues
* Fix more pep8 issues
2017-07-13 20:58:18 +02:00
Pilou
4b3d6dfa8a
Use pycodestyle instead of pep8 ( #25947 )
2017-07-13 11:46:31 -07:00