1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

802 commits

Author SHA1 Message Date
Nigel Metheringham
3e0e572cce Rework of user module to support portability
Split module into a main calling function, and a generic
(Linux useradd/usermod/userdel) User class.
Added a __new__ function that selects most appropriate superclass
Added a FreeBSD User class
Tested against FreeBSD 9.0
2012-10-29 22:00:58 +00:00
Seth Vidal
7c1e0de141 fix removal case where first pkg in a list is not installed at all
and the next one gets ignored despite being installed.

also clean up unnecessary second check.
2012-10-29 13:48:20 -04:00
Maxim Burgerhout
82cc382c6a More useful error message for if not HAVE_SELINUX 2012-10-29 16:23:00 +01:00
Jeroen Hoekx
b336d40101 Add a group_by action plugin. 2012-10-29 13:10:23 +01:00
Dag Wieers
63fa33b0b7 Make sure we always return 'rc' from the command module
If this is not a certainty, playbooks will fail without an 'rc' and checking both if there is an rc, and whether the 'rc' is (not) 0 is very complicated. (especially because ${something.rc} will not be substituted and all that)
2012-10-26 15:02:03 +02:00
Daniel Hokka Zakrisson
7a8009f979 When atomically replacing files, copy attributes 2012-10-25 21:40:05 -04:00
Michael DeHaan
523f2bf327 Merge pull request #1455 from bleader/devel
user module: fix typo in documentation
2012-10-25 18:26:58 -07:00
Michael DeHaan
cbcc133cdd Merge pull request #1453 from sfromm/issue1211
Use shutil.copyfile so as to preserve file ownership in authorized_keys
2012-10-25 18:22:56 -07:00
Michael DeHaan
5b36e374d7 Merge pull request #1451 from dhozac/command-strip-newlines
Only strip trailing newlines from output, preserving other space
2012-10-25 18:21:16 -07:00
Michael DeHaan
06fa3e820d Merge pull request #1448 from jpmens/user_user1
User is alias for name in 'user' module
2012-10-25 18:18:56 -07:00
bleader
5a5751d1d0 user module: fix typo in documentation
tyep -> type

Signed-off-by: bleader <bleader@ratonland.org>
2012-10-25 20:56:13 +02:00
Stephen Fromm
a033ad4d74 Use shutil.copyfile so as to preserve file ownership in authorized_keys 2012-10-25 11:20:53 -07:00
Daniel Hokka Zakrisson
73cd3ef617 Only strip trailing newlines from output, preserving other space 2012-10-25 14:26:37 +02:00
Jan-Piet Mens
89f28a98dd User is alias for name in 'user' module 2012-10-25 14:03:13 +02:00
Michael DeHaan
895715b65b Merge pull request #1445 from sfromm/issue1439
Skip check of primary group when checking other group membership
2012-10-25 03:58:17 -07:00
Stephen Fromm
544dc76704 Create temp file in directory where ssh key lives 2012-10-24 20:50:11 -07:00
Stephen Fromm
b2e94e53fc Write keys file to temp location to avoid potential corruption 2012-10-24 20:47:45 -07:00
Stephen Fromm
e97916cfc1 Skip check of primary group when checking other group membership 2012-10-24 20:39:42 -07:00
Michael DeHaan
f2a7ca9a36 Merge pull request #1435 from stijnopheide/mysql-grant
Mysql grant, take 2
2012-10-24 18:18:13 -07:00
Michael DeHaan
3e491513a9 Merge pull request #1432 from skvidal/devel
yum enablerepo/disablerepo option complete
2012-10-24 17:13:29 -07:00
Dag Wieers
f4c4537327 Resolve traceback when python-selinux is not installed 2012-10-24 18:57:24 +02:00
Seth Vidal
0a153c6798 add comments that enablerepo/disablerepo are new in 0.9 2012-10-24 09:08:42 -04:00
Stijn Opheide
733693ffdc - removed space escapes from MySQL SHOW GRANTS regex
- proper checking for with grant option (if this is not the only option the user has)
- added revoking of grant option
2012-10-24 15:02:54 +02:00
Stijn Opheide
6b92b69fe6 added the GRANT privilege for a mysql user (WITH GRANT OPTION) 2012-10-24 15:02:54 +02:00
Jan-Piet Mens
82955606c4 fix DOCUMENTATION for user 2012-10-24 07:35:56 +02:00
Seth Vidal
d8337dab06 tested and verified yum enable/disablerepo option for yum module 2012-10-24 00:46:15 -04:00
Seth Vidal
d89d07550f first cut at yum module with enable/disable repo 2012-10-24 00:24:40 -04:00
Michael DeHaan
9626111d5b Merge pull request #1427 from bleader/devel
mount: update example with mandatory option
2012-10-23 21:02:46 -07:00
Stephen Fromm
5d8c130a7f Document ssh_key options are in version 0.9 2012-10-23 08:21:40 -07:00
bleader
e16e3fb4ca mount: update example with mandatory option
- 'state' is required, but wasn't in example

Signed-off-by: bleader <bleader@ratonland.org>
2012-10-23 15:49:47 +02:00
Jan-Piet Mens
feab57e270 Reformat code: examples consistently
- added terse syntax to modules.rst
 - added description of special variables to template module
2012-10-23 15:14:01 +02:00
Stephen Fromm
769bd9125a Help git module work when working in 'no branch' scenario
Detect when on a 'no branch' branch.  If so, checkout the HEAD branch
as reported by 'git remote show <remote>'.  That should put the repo
back on a branch such that git can then merge changes as necessary.
In addition, removed hard-coded references to origin and replaced
with remote var.
2012-10-22 16:03:35 -07:00
Michael DeHaan
cbc12f0dba Various performance streamlining and making the file features usable in all modules without daisy chaining. 2012-10-20 22:55:09 -04:00
Michael DeHaan
4104478abd Added 'script', a module that can push and insantly run a remote script. Replaces the need to copy+command.
This is a bit of a rough draft, some error handling still needs to be added.
2012-10-20 12:12:07 -04:00
Michael DeHaan
6b8448051f Merge pull request #1389 from sfromm/issue1214
Add ability to create SSH key for user in user module
2012-10-20 07:30:24 -07:00
Michael DeHaan
3c739b1a88 Merge pull request #1339 from inertialbit/add-basic-pg-role-attribute-support
add role_attr_flags parameter to postgresql_user
2012-10-20 07:29:26 -07:00
Stephen Fromm
87954f2110 Use os.path.join where appropriate 2012-10-19 22:22:27 -07:00
Stephen Fromm
63ba441163 Add ability to create SSH key for user in user module
This allows one to create a SSH key for user.  You may define:
ssh_key_type, ssh_key_bits, ssh_key_file, ssh_key_comment,
and ssh_key_passphrase.  If no passphrase is provided, the
key will be passphrase-less.  This will not overwrite an existing key.
In the JSON returned, it will provide the ssh_fingerprint and
ssh_key_file.
2012-10-19 22:00:31 -07:00
Michael DeHaan
68cf9a96fc Merge pull request #1388 from goozbach/selinux_bugs
make policy only be required if state is not disabled
2012-10-19 16:35:15 -07:00
Derek Carter
99180e7da3 make policy only be required if state is not disabled 2012-10-19 17:17:30 -04:00
Seth Vidal
326b160241 when a pkg is installed, but not from any repo, don't error out
that it is not installed.

Also when a pkg is both installed and in a repo do not look it up
more than once
2012-10-19 16:28:39 -04:00
Michael DeHaan
d58bc4da4e Merge pull request #1361 from lantins/devel
Copy module can replace symlink with a real file.
2012-10-18 16:59:45 -07:00
Michael DeHaan
05866bba1e Merge pull request #1372 from jpmens/rst_template1
module_formatter: .rst now correctly handles code examples
2012-10-18 16:58:08 -07:00
Jonathan Palley
702469f7bf symlink fix 2012-10-18 20:08:57 +08:00
Jan-Piet Mens
575459465e module_formatter: .rst now correctly handles code examples
- fixed template (it was the template), adding indentation with Jinja2
 - added description of code examples to man-page template (was missing)
 - fixed fireball, cron, and debug module examples to confrom
2012-10-18 13:49:19 +02:00
Luke Antins
0dbd3aa821 Add examples to user module documentation. 2012-10-18 02:55:58 +01:00
Luke Antins
4f17aa9fa0 Fix indent of fail module example to prevent unwanted <blockquote></pre></p> <br/></blockquote> from showing up in docsite output. 2012-10-18 02:09:11 +01:00
Luke Antins
7d41045b2f Erroneous space in facter documentation. 2012-10-18 01:20:40 +01:00
Luke Antins
6354898b09 Copy module can replace symlink with a real file. 2012-10-18 01:04:52 +01:00
Michael DeHaan
54257a6a4c Remove "the the" 2012-10-17 19:38:17 -04:00
Michael DeHaan
edb7a054ae Merge pull request #1349 from bcoca/fix_bsd_dmesg_jails
fixed but in pulling data from dmesg command, wrong function to use as f...
2012-10-16 16:15:36 -07:00
Brian Coca
620aeeb572 fixed but in pulling data from dmesg command, wrong function to use as file for for loop
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2012-10-16 18:44:09 -04:00
Michael DeHaan
5bb8dcea08 Fix help text 2012-10-16 18:17:44 -04:00
Michael DeHaan
6f14e35c36 Merge pull request #1335 from phgrau/devel
Use && for executing next command if, and only if, command1 returns an e...
2012-10-16 15:16:46 -07:00
Michael DeHaan
7583704144 "force=" code under the file module is problematic, remove it 2012-10-16 18:14:42 -04:00
Jan-Piet Mens
e35d5188f9 typo 2012-10-16 14:40:35 +02:00
Jeremiah Heller
37bdefae74 add role_attr_flags parameter to postgresql_user
Pass role_attr_flags a list of comma separated role
attributes when creating or updating a user.
2012-10-15 16:03:10 -07:00
Philipp Grau
4290a904ff Add note: Debian Squeeze has no add-apt-repository 2012-10-15 17:20:23 +02:00
Maxim Burgerhout
2f6b9e69a7 Test for python-pip as well as pip
On Red Hat, CentOS and Fedora systems, the pip binary will be called python-pip
instead of pip. This commit makes the pip module also check for python-pip.

The reason we check for python-pip *first*, is to have ansible fail on not
finding 'pip' and reporting *that*. This is consistent with current behaviour
and will not confuse users of Debian et al., where the 'python-pip' binary
never exists.

Tested on Fedora 18 and Ubuntu 12.04.
2012-10-14 12:14:59 +02:00
Tim Bielawa
8831e59700 The pause 'prompt' parameter now requires quotes around the message. 2012-10-12 23:48:08 -04:00
Michael DeHaan
8dadf8a905 Use 'path' in file documentation, though src/dest work, it's less intuitive. 2012-10-12 22:08:07 -04:00
Michael DeHaan
2c90298841 Merge pull request #1314 from apenney/bugfix/git
Check rc instead of parsing for errors.
2012-10-12 18:18:04 -07:00
Michael DeHaan
c5d2f6b0d3 implement lookup plugins for arbitrary enumeration over arbitrary things. See the mailing list for some cool examples. 2012-10-12 20:07:05 -04:00
Michael DeHaan
29d49d415f fix mentioning of redundant aliases in module docs, remove was removed anyway 2012-10-12 18:14:09 -04:00
Michael DeHaan
621708e976 user module should be using module.BOOLEANS for choices 2012-10-12 18:06:36 -04:00
Michael DeHaan
aa98c84a62 HP and vsphere modules are crazy awesome but I am thinking these belong in contrib not core. 2012-10-12 17:49:48 -04:00
Brian Coca
6886683e16 small patch to fact gathering for when no dmesg.boot exists on freebsd, mainly happens in jails
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2012-10-12 17:37:30 -04:00
Michael DeHaan
35163bce96 Merge pull request #1310 from dagwieers/hpilo_boot-cleanup
hpilo_boot: Various clean ups in documentation and code
2012-10-12 14:33:05 -07:00
Michael DeHaan
b1ccda00f8 Merge pull request #1311 from dagwieers/hpilo_facts-cleanup
hpilo_facts: Various clean ups in documentation and code
2012-10-12 14:32:46 -07:00
Michael DeHaan
1487b6a1bb Merge pull request #1313 from dagwieers/vsphere_facts-cleanup
vsphere_facts: Various cleanups in documentation
2012-10-12 14:32:31 -07:00
Michael DeHaan
a82522a5c4 Merge pull request #1317 from abondis/fix_mysql_db
fix issue with mysql authentication and states not dump or import
2012-10-12 14:26:45 -07:00
Michael DeHaan
20a7227056 Merge pull request #1318 from dsummersl/cron24
fixed cron library so backups are python2.4 compatible
2012-10-12 14:25:51 -07:00
Jeroen Hoekx
25e415c031 Add virt_boot module to define libvirt boot parameters. 2012-10-12 22:40:04 +02:00
Dane Summers
7399224428 fixed cron library so backups are python2.4 compatible 2012-10-12 16:34:34 -04:00
Aurélien Bondis
1f91a70310 fix issue with mysql authentication and states not dump or import 2012-10-12 16:26:59 -04:00
Ashley Penney
f4484f800b Further cleanup to add another rc check and remove a now redundent one. 2012-10-12 18:26:40 +00:00
Ashley Penney
6042419624 Check rc instead of parsing for errors. This now catches the case where the remote branch has been deleted and you're still trying to pull against it. 2012-10-12 18:16:37 +00:00
Dag Wieers
5927373c26 Various clean ups in documentation and code
This commit improves the following items:
 - Remove the 'match' functionality, this can now be achieve by using the `fail` module together with `only_if` after running the `hpilo_facts` module. Since this gives more functionality, e.g. comparing server names, but also serial numbers or uuids with other inventory information, this is prefered. An example is added to show how this is achieved.
 - Clean up all C() calls in documentation
 - Added state=poweroff in order to power off a server. The use-case is here that in general we do not want to provision systems that are already running (this enforcement can be disabled using force=yes) but for test systems we should be able to power them off so we can start the normal provisioning process. (We could also force boot them, but that's less elegant)
 - The module now correctly indicates when something has changed. So if a server is powered off that was not off already, this is indicated, or when media boot-settings have been changed, this is also correctly indicated. Previously every call to hpilo_boot was (incorrectly) considered a change.
2012-10-12 19:49:30 +02:00
Dag Wieers
5fe8205d36 vsphere_facts: Various cleanups in documentation
This commit improves the following items:
 - Clean up all C() calls in documentation
 - Reindent the documentation
2012-10-12 19:46:20 +02:00
Dag Wieers
5612cce4a4 hpilo_facts: Various clean ups in documentation and code
This commit improves the following items:
 - Remove the 'match' functionality, this can now be achieve by using the `fail` module together with `only_if` after running the `hpilo_facts` module. Since this gives more functionality, e.g. comparing server names, but also serial numbers or uuids with other inventory information **and** a proper message, this is prefered. An example is added to show how this is achieved.
 - Clean up all C() calls in documentation
 - Remove trailing spaces in HP iLO's Serial Number output so that they can be compared to CMDB or other inventory information
2012-10-12 19:38:59 +02:00
Michael DeHaan
dfaef8061a Merge pull request #1289 from abondis/mysql_migration
mysql_db: connection test, dump/import state
2012-10-11 17:39:13 -07:00
Dag Wieers
dfdf4ab8eb Damn you, colons... 2012-10-11 09:26:21 +02:00
Aurélien Bondis
1a51af0e38 mysql_db: use the database to test connexion, added dump and import state - requires target=path/to/a/file 2012-10-10 23:28:42 -04:00
Michael DeHaan
e74b9e1d34 Add .gitdir 2012-10-10 20:00:15 -04:00
Michael DeHaan
e593c828b4 Merge remote branch 'dagwieers/module-mail' into devel 2012-10-10 19:46:38 -04:00
Michael DeHaan
7788dea238 Merge pull request #1268 from dagwieers/hpilo-reboot-fix
Workaround for when HP iLO is in a state it won't accept requests
2012-10-10 05:34:22 -07:00
Michael DeHaan
f1dfddc5e5 Fix typo in autogenerated docs 2012-10-10 08:32:41 -04:00
Dag Wieers
2f74cd84bd Module mail to send out emails as an action
Sending mails could be part of the workflow to have teams/responsibles perform specific task. Or simply to notify that a process has finished successfully (e.g. provisioning).
2012-10-09 19:36:23 +02:00
Dag Wieers
790ed81b14 Workaround for when HP iLO is in a state it won't accept requests
This workaround is recommended from HP iLO's documentation, but may not be sufficient in all cases. Time will tell.

I also made a few cosmetic changes with no impact.
2012-10-09 19:31:31 +02:00
Michael DeHaan
06688efb24 Merge pull request #1263 from dagwieers/hpilo_facts-fix
Sigh, another retypo
2012-10-09 05:22:49 -07:00
Dag Wieers
98624cb394 Fixes to documentation 2012-10-09 12:42:10 +02:00
Dag Wieers
3f149e09bc Sigh, another retypo problem 2012-10-09 12:30:00 +02:00
Michael DeHaan
612561ad0e Merge pull request #1250 from dagwieers/hpilo_boot-fixes
Various small fixes to boolean usage and defaults
2012-10-08 14:27:20 -07:00
Michael DeHaan
62a56a219b Merge pull request #1243 from dsummersl/squash2-cron
cron feature (w/o tests)
2012-10-08 14:25:55 -07:00
Michael DeHaan
1b36446ab3 Merge pull request #1255 from dagwieers/module-namespace
Add this module's namespace to the 'module_' namespace.
2012-10-08 14:25:20 -07:00
Tim Bielawa
1e35ac7603 Fix typo in service module docs 2012-10-08 12:46:16 -04:00
Dane Summers
c3a6e8dfd6 added new documentation string to cron library 2012-10-08 11:10:40 -04:00
Dag Wieers
b39aed8736 Add this module's namespace to the 'module_' namespace.
Much like we currently have *setup* register the variable `module_setup`, we would like other facts-modules register their own namespace. This means that:

 - *network_facts* registers `module_network`
 - *hpilo_facts* registers `module_hw`
 - *vsphere_facts* registers `module_hw`

In retrospect, it would have made more sense to have `setup` register `module_ansible` instead as the setup module uses the `ansible_` namesepace.

Having the `module_` namespace allows us to check whether a certain namespace has already been loaded so we can avoid running the facts module a second time using only_if.

```yaml
 - action: network_facts host=${ansible_hostname_short}
   only_if: is_unset('$module_network')
```
2012-10-08 15:13:17 +02:00
Dag Wieers
5503cfaa44 Various small fixes to boolean usage, using module.params.get and default values 2012-10-08 15:07:02 +02:00
Michael DeHaan
c8854a23ea Merge pull request #1251 from dagwieers/hpilo_facts-fixes
Fix typo/cosmetic change
2012-10-07 16:58:05 -07:00