1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

5974 commits

Author SHA1 Message Date
Bryan Larsen
bdbc963736 digital_ocean: don't run update_attr if wait=no
Sometimes when using digital_ocean with wait=no I get the error "No ip is found".  But with wait=no I wouldn't expect there to be any IP, that gets allocated later.   However, looking at the code, it turns out that with even with wait=no it waits up to 10 seconds for an IP to be allocated.  We could wait longer, but with wait=no that seems like the wrong choice; it's easy enough to grab an IP later with a wait=yes command.

To make this change I removed the call to update_attr in @classmethod add.  An add is always followed by an ensure_powered_on which will do the update_attr if wait=yes.   It would be possible to instead do a call to update_attr with no retries and ignore the errors but I figured it would be better to be consistently not return an IP than to sometimes return it and sometimes not.   Inconsistent behaviour makes debugging deployment scripts very difficult.
2013-07-11 13:30:42 -04:00
Michael DeHaan
4971736660 Merge pull request #3501 from cristobalrosa/devel
Devel
2013-07-11 06:20:48 -07:00
Michael DeHaan
afcd869487 Merge pull request #3451 from sergevanginderachter/template_ansible_ssh_host
allow ansible_ssh_host to be templated
2013-07-11 06:04:13 -07:00
Michael DeHaan
95b90cf71a Merge pull request #3454 from nyetsche/abspath
set checkout destination directory to be full path
2013-07-11 06:03:39 -07:00
Michael DeHaan
9990688fd1 Merge pull request #3453 from jsmartin/cleanup
Fixed #3433. Using get_bin_path, removed uneeded imports, "module" is in...
2013-07-11 06:03:19 -07:00
Michael DeHaan
aacf81da59 Merge pull request #3488 from weltenwort/devel
Use the force=yes option for apt upgrade actions
2013-07-11 05:56:32 -07:00
Michael DeHaan
3a84254f6d Merge pull request #3496 from johanwiren/bsd-ipv6-facts
Fix for populating default_ipv6 on BSD systems
2013-07-11 05:55:53 -07:00
Michael DeHaan
d1398594ce Merge pull request #3497 from johanwiren/bsd-gateway
Updated setup module to collect gateway fact for BSD systems
2013-07-11 05:55:26 -07:00
Michael DeHaan
7cc9ebc1a7 Merge pull request #3387 from stoned/test-ignore-errors
Add test for 'ignore_errors:'
2013-07-11 05:39:40 -07:00
Michael DeHaan
2e8a78b3e0 Merge pull request #3415 from neomantra/digital_ocean_inv
digital_ocean.py enhancements
2013-07-11 05:36:38 -07:00
Michael DeHaan
952760c605 Merge pull request #3388 from bcoca/fixed_user_create_doc
updated module docs to reflect 'correct' on_create vs on_creation
2013-07-11 05:34:37 -07:00
Michael DeHaan
324a28f3dd Merge pull request #3439 from eest/bestpractices_templates_fix
Fix path to ntp.conf.j2 in example.
2013-07-11 05:31:25 -07:00
Michael DeHaan
f8c7a3c654 Merge pull request #3406 from podollb/devel
fixing small mis-spelling
2013-07-11 05:29:11 -07:00
Michael DeHaan
0fd7864482 Merge pull request #3432 from jlund/hg-spelling
Fix some minor spelling mistakes in the hg module documentation
2013-07-11 05:26:57 -07:00
Michael DeHaan
90dfc115d6 Merge pull request #3463 from stoned/filterskipped
Add Jinja2 filter 'skipped' to test for a registered variable from a ski...
2013-07-11 05:26:25 -07:00
Michael DeHaan
279247dfac Merge pull request #3464 from stoned/filterquote
Add Jinja2 filter 'quote' to quote string for shell usage
2013-07-11 05:25:43 -07:00
Michael DeHaan
d6d9e804d3 Merge pull request #3480 from j2sol/fail_doc
Update fail docs for new syntax
2013-07-11 05:22:47 -07:00
Michael DeHaan
5f36079ffd Merge pull request #3486 from pieska/expandvars
expand vars like $HOME used in config values too
2013-07-11 05:22:18 -07:00
Michael DeHaan
ee73276310 Merge pull request #3492 from jlund/advanced-playbooks
Fix some minor typos in the Advanced Playbooks documentation
2013-07-11 05:21:13 -07:00
Michael DeHaan
e44847e3d6 Merge pull request #3494 from jlund/authorized-key
Add a new with_file example to the authorized_key documentation
2013-07-11 05:20:24 -07:00
Johan Wirén
1c247c9eb4 Updated GenericBsdIfconfigNetwork to collect gateway 2013-07-11 00:05:53 +02:00
Johan Wirén
10e9194744 Fix for populating default_ipv6 on BSD systems 2013-07-10 22:54:33 +02:00
Joshua Lund
cc275ca2be Added a new with_file example to the authorized_key documentation 2013-07-10 14:09:03 -06:00
Patrik Lundin
1b08da26fd openbsd_pkg: some whitespace cleanup. 2013-07-10 21:23:10 +02:00
Joshua Lund
7c78fef1f5 Fixed some minor typos in the Advanced Playbooks documentation 2013-07-10 13:09:12 -06:00
Patrik Lundin
af52cd6ec1 openbsd_pkg: sync package_latest().
This diff syncs package_latest() with the changes to package_present().
I have not managed to figure out how to handle the cornercases where
stderr is set but the command has not failed, so leave a FIXME blob for
other adventurers.
2013-07-10 21:06:35 +02:00
Patrik Lundin
0e4e6e8a84 openbsd_pkg: Handle another pkg_add gotcha
* Add '-m' to pkg_add incovation to get access to the "packagename-1.0: ok"
  message.
* Watch for that message if we are about to fail because of stderr in
  package_present().
2013-07-10 18:19:01 +02:00
Darragh O'Reilly
6346798e7e Keystone_user module: fix authentication needs tenant_name too
The keystone client needs to be passed tenant_name when authenticating the
user/password way. Also it needs auth_url instead of endpoint.
This fix adds login_tenant_name as a module parameter which is consistent
with the other OpenStack modules.
2013-07-10 07:21:07 +01:00
Patrik Lundin
a67ea75dec openbsd_pkg: handle pkg_add quirks better.
This fixes a problem when trying to install a package with a specific version
number from a local directory and the local directory is checked after a remote
repository:

Error from http://ftp.eu.openbsd.org/pub/OpenBSD/[...]/packagename-1.0.tgz
ftp: Error retrieving file: 404 Not Found
packagename-1.0: ok
2013-07-09 20:56:22 +02:00
Andreas Piesk
e5ff35bbdb expand vars like $HOME used in config values too 2013-07-09 20:33:33 +02:00
Frank Shearar
9ba4a42ff8 Minor typo 2013-07-09 17:33:30 +01:00
Frank Shearar
ec78daa456 Let someone specify a path to a Rabbit that's not installed in the usual place. 2013-07-09 17:33:14 +01:00
Felix Stuermer
b5df29901f Use the force=yes option for apt upgrade actions 2013-07-09 10:57:19 +02:00
Jesse Keating
1689001036 Update fail docs for new syntax
Use when instead of only_if
Use new variable style
2013-07-08 14:22:05 -07:00
Michael DeHaan
714cb02f5b Merge pull request #3477 from bcoca/fix_service_checkmode
fixed check mode for service module
2013-07-08 12:44:44 -07:00
Brian Coca
0664e36aa2 fixed check mode
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-08 15:41:39 -04:00
Michael DeHaan
1bf4a4fa97 Merge pull request #3469 from johnny-die-tulpe/devel
Fixed indention of vv() output
2013-07-08 05:58:11 -07:00
Lasse Borchard
8c8b4d56fc Fixed indention of vv() output 2013-07-08 11:18:33 +02:00
Stoned Elipot
247322bb16 Add Jinja2 filter 'quote' to quote string for shell usage 2013-07-08 00:37:23 +02:00
Stoned Elipot
906746b1f0 Add Jinja2 filter 'skipped' to test for a registered variable from a skipped task 2013-07-07 22:13:14 +02:00
Cristobal Rosa
51166c9cfa Remove unnecesary call 2013-07-06 22:12:30 +02:00
Michael DeHaan
b2d881a899 Fixup changelog dates 2013-07-05 22:12:33 -04:00
Michael DeHaan
8a82b5c817 Slight revisement to configuration file comment. 2013-07-05 22:11:51 -04:00
Michael DeHaan
6063f64526 Update changelog 2013-07-05 22:11:32 -04:00
Michael DeHaan
3712ca7cde Update releases 2013-07-05 22:10:34 -04:00
Michael DeHaan
5354ab043d Update changelogs 2013-07-05 22:09:04 -04:00
Michael DeHaan
cf6e1f8db9 Make it possible to tell paramiko to not record new host keys, which can be slow with a large number of hosts.
-c ssh is preferred in most cases if you have ControlPersist available, otherwise if you are comfortable you
can turn off recording while leaving host key checking on, etc.
2013-07-05 22:06:54 -04:00
Michael DeHaan
14818af446 Merge pull request #3450 from tonk/sudo
Repair issue #3447
2013-07-05 16:08:29 -07:00
Michael DeHaan
aa9385411d Merge pull request #3443 from ajsalminen/arg_unicode_fix
Use .encode() instead of str() to support unicode arguments.
2013-07-05 15:26:29 -07:00
Matt Lesko
b37ecb055c set checkout destination directory to be full path
we chdir into this path and read the playbook/inventory if a
non-absolute path is given on the command line, that will fail
2013-07-05 17:57:01 +00:00