Patrik Lundin
d4af9e4c5c
Use shlex for rc.conf parsing.
...
This makes the line parsing a lot more robust (and easier to read).
Code supplied by @dhozac, thanks!
Remove re import because this is not used anywhere.
2012-11-25 13:09:54 +01:00
Patrik Lundin
fde00327b0
Rework "enabled" implementation for FreeBSD.
...
When trying to perform enabled=yes followed by enabled=no
against FreeBSD the module would die with the following error:
TypeError: sub() takes at most 4 arguments (5 given)
The target FreeBSD client (8.2) is running python 2.6.6. It seems the
extra 'flags' argument was added to re.sub() in 2.7.
In fixing this issue I have attempted to create a general atomic method
for modifying a rc.conf file. Hopefully this will make it easier to add
other rc based platorms. The strip/split magic was inspired by the user
module.
2012-11-25 13:09:54 +01:00
Daniel Hokka Zakrisson
4679d8d6e5
Remove references to non-existant variable rc
2012-11-25 00:23:29 +01:00
Daniel Hokka Zakrisson
1ec2a59073
Merge pull request #1676 from dagwieers/service-action-fix
...
The vars stop/start were intended as strings
2012-11-24 15:16:30 -08:00
Dag Wieers
18b797f096
The vars stop/start were intended as strings
...
This is a typo that was reported on IRC, because of this people got: "NameError: global name 'stop' is not defined".
2012-11-25 00:13:53 +01:00
Ton Kersten
7bba04b176
Corrected for fallthrough
2012-11-24 16:26:15 +01:00
Ton Kersten
ee4fe9ff55
Added pip-python to the search for CentOS 6 compatibility
2012-11-24 13:36:32 +01:00
Michael DeHaan
ac09b47ec4
Merge pull request #1668 from eest/refactor_service_module
...
Repost: Refactor service module to use subclasses like user module.
2012-11-23 13:19:09 -08:00
Patrik Lundin
5b7aa494b2
Refactor module to use subclasses like user module.
...
* Basically the moving parts from the original service module arranged in
subclasses.
* General structure and helper methods comes from the user module.
* Less forgiving to unsupported platforms: it requires a subclass per platform.
(This makes it easier to work on one platform without having to think about.
what other platform might be affected in unexpected ways).
* Now has basic OpenBSD support.
* Solaris support needs to be added.
Thanks to @dhozac for general advice and Linux testing.
Thanks to @bcoca for clearing up some FreeBSD questions.
2012-11-23 21:03:17 +01:00
Michael DeHaan
ce487a8544
Merge pull request #1658 from jpmens/docs_2
...
module_formatter: re-instate code
2012-11-23 07:58:48 -08:00
Michael DeHaan
3981c72957
Streamline code
2012-11-23 10:58:17 -05:00
Michael DeHaan
17020d6a75
Merge pull request #1656 from dagwieers/setup-virtualization
...
Implemented more virtualization types
2012-11-23 07:55:42 -08:00
Jan-Piet Mens
3b83295581
DOCUMENTATION: yum (moved version to added)
2012-11-22 15:16:20 +01:00
Jan-Piet Mens
068ef0e979
module_formatter: re-instate code
2012-11-22 07:23:10 +01:00
Dag Wieers
e528826dba
Implemented more virtualization types
...
I added all known virtualization types from the virt-what project. However, the few virt types that rely on cpuid information have not been implemented lacking native python cpuid access. (hyperv)
2012-11-22 02:48:13 +01:00
Jan-Piet Mens
caf003c813
DOCUMENTATION strings
2012-11-21 18:49:30 +01:00
Dag Wieers
118ccc68c9
Make the default an empty string
...
Seems a bit strange I have to set a default in two locations.
2012-11-21 16:11:20 +01:00
Michael DeHaan
663a8fef3f
chmod -x for all module files in source checkout
2012-11-19 13:47:40 -05:00
Daniel Hokka Zakrisson
b95bcf1b9d
Use single-quotes to contain SSH keys as they may contain double-quotes
...
Fixes #1624 .
2012-11-18 18:31:57 +01:00
Michael DeHaan
99a0ebcad0
Merge pull request #1642 from dagwieers/service-options
...
Allow adding additional arguments to service module
2012-11-17 16:58:37 -08:00
Dag Wieers
3852b9918a
Allow adding additional arguments to service module
...
Some services allow additional arguments to be provided on the command line. This patch makes it possible.
2012-11-18 01:48:06 +01:00
Michael DeHaan
bb2e5e12b8
Merge pull request #1638 from jpmens/ec2_userdata
...
Support for user_data in ec2 module
2012-11-17 07:43:35 -08:00
Michael DeHaan
c9aef42ac4
Merge pull request #1636 from romeotheriault/add-sunos-subclass-to-group-mod
...
Add sunos subclass to group mod
2012-11-17 07:39:17 -08:00
Michael DeHaan
e13d67bbf1
Merge pull request #1635 from romeotheriault/classify-group-module
...
convert group module to be platform sub-classable
2012-11-17 07:38:32 -08:00
Jan-Piet Mens
e4606d500c
Support for user_data in ec2 module
...
fix
2012-11-17 16:12:46 +01:00
Romeo Theriault
bb976ddfe0
add solaris subclass to group module
2012-11-16 16:05:16 -10:00
Romeo Theriault
a52faa841f
convert group module to be platform sub-classable
2012-11-16 15:38:13 -10:00
Fabian Arrotin
269a0779b4
Added a requirement on euca2ools external package and ec2 url example
2012-11-16 20:47:39 +01:00
Michael DeHaan
0ab3bd0034
Fix for #1577 (python 2.4 compliance for mysql_user), tested only for syntax, please exercise MySQL fans!
2012-11-14 20:02:39 -05:00
Michael DeHaan
096607eea4
Allow fireball to transfer binary files, fixup fireball docs, make fetch work with fireball.
2012-11-14 18:37:17 -05:00
Michael DeHaan
613539810e
Missing import
2012-11-14 18:19:16 -05:00
Romeo Theriault
ae36fb1dc6
minor linux user module fixups
2012-11-12 11:13:51 -10:00
Michael DeHaan
001e2e564f
Merge pull request #1590 from romeotheriault/minor-freebsd-user-module-fixes
...
minor freebsd user fixes
2012-11-10 06:33:13 -08:00
Michael DeHaan
80f196fdbc
Merge pull request #1589 from romeotheriault/add-sunos-user-support
...
Add solaris support to user module
2012-11-10 06:32:41 -08:00
Romeo Theriault
6c6bcff4ee
minor freebsd user fixes
2012-11-09 22:29:45 -10:00
Romeo Theriault
3bab27abdb
Add solaris support to user module
2012-11-09 21:58:51 -10:00
Jan-Piet Mens
e32f4a0564
Move get_docstring from module_formatter into ansible/utils
2012-11-09 17:15:41 +01:00
Yvan Cottyn
e9a356bbde
Fix exception catching for Python 2.4
2012-11-09 14:28:21 +01:00
Yvan Cottyn
37de471ab6
Fix exception catching for Python 2.4
2012-11-09 14:27:03 +01:00
Michael DeHaan
09cde86e83
Merge pull request #1571 from skvidal/ec2
...
add ec2 module
2012-11-09 04:53:03 -08:00
Seth Vidal
e147ad4213
add add_host action plugin - add hosts to inventory during a playbook
...
run - lets act on those hosts in the next play
2012-11-09 00:16:17 -05:00
Seth Vidal
7e0cb4f052
add ec2 module
2012-11-09 00:15:12 -05:00
Dag Wieers
2fdb217be3
Documentation of svr4pkg module breaks 'make rpm'
...
Without this fix, generating documentation results in:
```
Traceback (most recent call last):
File "hacking/module_formatter.py", line 376, in <module>
main()
File "hacking/module_formatter.py", line 365, in main
text = template.render(doc)
File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 669, in render
return self.environment.handle_exception(exc_info, True)
File "hacking/templates/man.j2", line 20, in top-level template code
{% for desc in v.description %}@{ desc | jpfunc }@{% endfor %}
File "hacking/module_formatter.py", line 94, in man_ify
t = _ITALIC.sub(r'\\fI' + r"\1" + r"\\fR", text)
TypeError: expected string or buffer
```
2012-11-09 02:22:20 +01:00
Michael DeHaan
03591e0fc8
Merge pull request #1551 from dagwieers/local_action-fail
...
Turn 'fail' and 'debug' modules into action_plugins
2012-11-08 16:47:24 -08:00
Michael DeHaan
f3cbcecf53
Merge pull request #1563 from lllama/devel
...
Add an "executable" option to the command and shell modules
2012-11-08 16:45:48 -08:00
Michael DeHaan
03f4b0f923
Merge pull request #1560 from dagwieers/module-output-consistency
...
Make module output more consistent wrt. changed/failed
2012-11-08 16:45:05 -08:00
Michael DeHaan
cbff02139f
Merge pull request #1557 from sfromm/issue1412
...
Updates to git module: use git-fetch and other changes
2012-11-08 16:44:00 -08:00
Michael DeHaan
42375d14b3
Merge pull request #1556 from sfromm/issue1099
...
Wrap getpwnam in try/except in authorized_key module
2012-11-08 16:43:45 -08:00
Boyd Adamson
528a457848
Add svr4pkg module for traditional Solaris packages
2012-11-09 09:43:19 +11:00
Felix Ingram
e0f0e8c023
Add an "executable" option to the command and shell modules
...
The option will be passed to the Popen object created and will be used to
execute the command instead of the default shell.
2012-11-08 13:56:16 +00:00