Brian Coca
d9e510b192
narrow down exception catching in block builds
...
this was obscuring other errors and should have always been narrow scope
2015-12-11 13:13:05 -05:00
Chrrrles Paul
e56efa49c4
Merge pull request #13509 from chrrrles/vca_default_host
...
fix default host for non vcd service types
2015-12-11 10:17:55 -05:00
Abhijit Menon-Sen
37c4e9aee3
Clean up debug logging around _low_level_execute_command
...
We were logging the command to be executed many times, which made debug
logs very hard to read. Now we do it only once.
Also makes the logged ssh command line cut-and-paste-able (the lack of
which has confused a number of people by now; the problem being that we
pass the command as a single argument to execve(), so it doesn't need an
extra level of quoting as it does when you try to run it by hand).
2015-12-11 07:11:48 +05:30
Charles Paul
a6a58d6947
fix default host for non vcd service types
2015-12-10 16:39:27 -05:00
Toshio Kuratomi
bd9582d072
Update submodule refs
2015-12-10 08:10:45 -08:00
Toshio Kuratomi
1dda8158ff
become_pass needs to be bytes when it is passed to ssh.
...
Fixes #13240
2015-12-10 07:29:38 -08:00
Charles Paul
6680cc7052
allow custom callbacks with adhoc cli for scripting
...
missing import of CallbackBase
2015-12-10 09:49:54 -05:00
James Cammarata
2b36343451
Missed one place we were appending the incorrectly escaped item to raw params
2015-12-09 17:58:44 -05:00
Toshio Kuratomi
62cbc03af6
Revert "Remove the funcd connection plugin"
...
This reverts commit c0d79cf7e1
.
We may still port the funcd connection plugin, just not in time for
2.0.0
2015-12-09 13:32:11 -08:00
James Cammarata
30b6dd8bcd
Merge pull request #13495 from Yannig/devel_debug_null_error
...
Do not fail when variable is not correct in debug action.
2015-12-09 16:27:05 -05:00
Yannig Perré
18ac12aee6
Do not fail when variable is not correct in debug action.
...
See https://github.com/ansible/ansible/issues/13484 for more information.
2015-12-09 22:08:30 +01:00
Toshio Kuratomi
c0d79cf7e1
Remove the funcd connection plugin
2015-12-09 13:07:00 -08:00
Brian Coca
64864829c4
changed deprecation to removal warning
2015-12-09 12:37:56 -08:00
Toshio Kuratomi
61dc4a7e67
Update module refs
2015-12-09 12:10:21 -08:00
James Cammarata
14e19c239d
Make on_file_diff callback item-aware
2015-12-09 14:52:53 -05:00
Brian Coca
04d74fd680
reenabled --tree for ansible adhoc command
...
previous fix to avoid callbacks now conflicted with tree optoin
which is implemented as a callback in 2.0
2015-12-09 10:13:50 -08:00
Brian Coca
7936a4687e
adhoc avoids callbacks by default as it did before
...
Previous emptying of whitelist only affected callbacks that were
constructed for need whitelist. This now works for all callbacks.
2015-12-09 10:01:21 -08:00
Brian Coca
ae2447df91
attribute defaults that are containers are a copy
...
This is simpler way to prevent persistent containers across instances
of classes that use field attributes
2015-12-09 08:40:06 -08:00
Brian Coca
2bfb13bfb3
removed unused 'pattern' from ansible.cfg
...
also moved the config param to a 'deprecated' list in constants.py
added TODO for producing a deprecation warning for such vars
2015-12-09 08:40:06 -08:00
Brian Coca
2820b4c243
removed default from hosts to make it requried
...
prevents writing a play w/o a hosts entry which would default to
all/empty
2015-12-09 08:40:06 -08:00
Brian Coca
c64298de02
Revert "avoid persistent containers in attribute defaults"
...
This reverts commit 87969868d4
.
found better way to do it
2015-12-09 08:40:06 -08:00
James Cammarata
332a008273
Merge pull request #13489 from chouseknecht/galaxy-2.0
...
Galaxy 2.0
2015-12-09 11:29:20 -05:00
chouseknecht
4f84769a17
Galaxy 2.0
2015-12-09 10:51:12 -05:00
Brian Coca
87969868d4
avoid persistent containers in attribute defaults
...
moved from the field attribute declaration and created a placeholder
which then is resolved in the field attribute class.
this is to avoid unwanted persistent of the defaults across objects which introduces
stealth bugs when multiple objects of the same kind are used in succession while
not overriding the default values.
2015-12-09 07:29:36 -08:00
Brian Coca
0719eb3e2d
clarified warning from tree callback
2015-12-09 07:29:12 -08:00
Brian Coca
d82d65ee7b
keep string type filters as strings
...
now we don't try to convert types if using a filter that outputs a specifically formated string
made list of filters configurable
2015-12-08 12:52:20 -08:00
James Cammarata
1799de8528
Preserve original token when appending to _raw_params in parse_kv
...
Fixes #13311
2015-12-08 15:06:36 -05:00
Brian Coca
795fac917e
fixed typo in tree callback, added default dir
...
this would allow it to work with playbooks also
2015-12-08 11:59:04 -08:00
James Cammarata
398f6bbb89
Fix typo from 5ae850c
2015-12-08 14:36:36 -05:00
James Cammarata
de690445bc
Make fact delegating configurable, defaulting to 1.x behavior
2015-12-08 14:36:33 -05:00
Brian Coca
7ffd578a9d
Revert "Fix always_run support in the action plugin for template when copying"
...
This reverts commit 9c4eae5253
.
2015-12-08 09:24:20 -08:00
Brian Coca
d4ccb0be59
have always_run override check mode for a task
...
Fixes #13418
2015-12-08 09:24:07 -08:00
James Cammarata
9c4eae5253
Fix always_run support in the action plugin for template when copying
...
Fixes #13418
2015-12-08 11:56:39 -05:00
David L Ballenger
cdc3c88018
Merge remote-tracking branch 'ansible/devel' into issue_13438
2015-12-08 07:42:49 -08:00
Peter Sprygada
2d5b4b1799
Merge pull request #13273 from privateip/nxapi
...
adds new device argument to nxapi command arguments
2015-12-08 10:24:07 -05:00
David L Ballenger
970d7cadb7
Add ssh_host support for MacOSX El Capitan.
...
OS X El Capitan moved the /etc/ssh_* files into /etc/ssh/. This fix
adds a distribution version check for Darwin to set the keydir
appropriately on El Capitan and later.
2015-12-08 07:11:02 -08:00
Brian Coca
9ae1dede03
adhoc does not load plugins by default
...
reimplemented feature from 1.x which kept additional callbacks from
poluting adhoc unless specifically asked for through configuration.
2015-12-08 06:37:57 -08:00
Brian Coca
17b334d4a5
Merge pull request #13450 from privateip/feature_ios_shared_module
...
bugfix for ios.py shared module argument creation
2015-12-07 09:59:04 -05:00
James Cammarata
540cbe0f64
Merge pull request #13445 from n-st/tasks-string-repr
...
More meaningful string representation for meta tasks (like 'noop' and 'flush_handlers')
2015-12-07 08:10:54 -05:00
James Cammarata
2884ff3932
Merge pull request #13455 from Yannig/devel_fix_debug_var_when_content_same_as_name
...
Fix issue when var name is the same as content.
2015-12-07 08:02:22 -05:00
Yannig Perré
2c8eee956f
Fix issue when var name is the same as content.
...
See https://github.com/ansible/ansible/issues/13453 for more details.
2015-12-07 09:25:37 +01:00
Toshio Kuratomi
4d637e5780
Use self.args when we parse arguments that way the arguments can be constructed manually
2015-12-06 22:17:47 -08:00
Toshio Kuratomi
a8e015cc22
Add representers so we can output yaml for all the types we read in from yaml
2015-12-06 22:17:47 -08:00
Peter Sprygada
41773630ed
adds new device argument to nxapi command arguments
...
The device argument allows a dict of nxapi parameters to be passed to
the module to simplify passing the nxapi parameters
2015-12-05 22:51:40 -05:00
Brian Coca
8607aa527d
Merge pull request #13446 from lberruti/no_target_syslog
...
Make no_target_syslog consistent.
2015-12-05 16:08:00 -05:00
Brian Coca
955710267c
only set become defaults at last possible moment
...
tasks were overriding commandline with their defaults, not with the
explicit setting, removed the setting of defaults from task init and
pushed down to play context at last possible moment.
fixes #13362
2015-12-05 16:03:50 -05:00
Luca Berruti
8ea45e8608
Make no_target_syslog consistent.
...
no_target_syslog = False --> do log on target
2015-12-05 19:43:02 +01:00
Brian Coca
f89f906f87
simplified get_hosts code to have 1 retrun point
2015-12-05 10:10:25 -05:00
Nils Steinger
a1f6d17e37
More meaningful string representation for meta tasks (like 'noop' and 'flush_handlers')
2015-12-05 15:55:39 +01:00
Nils Steinger
0129fb0a44
Remove duplicates from host list *before* caching it
...
Ansible previously added hosts to the host list multiple times for commands
like `ansible -i 'localhost,' -c local -m ping 'localhost,localhost'
--list-hosts`.
8d5f36a
fixed the obvious error, but still added the un-deduplicated list to a
cache, so all future invocations of get_hosts() would retrieve a
non-deduplicated list.
This caused problems down the line: For some reason, Ansible only ever
schedules "flush_handlers" tasks (instead of scheduling any actual tasks from
the playbook) for hosts that are contained in the host lists multiple times.
This probably happens because the host states are stored in a dictionary
indexed by the hostnames, so duplicate hostname would cause the state to be
overwritten by subsequent invocations of … something.
2015-12-05 15:54:08 +01:00