1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

17597 commits

Author SHA1 Message Date
Yanis Guenane
d4e7b045b7 Extend test coverage for openssl modules (#27548)
* openssl_privatekey: Extend test coverage

Extend the coverage of the integration test for the module
openssl_privatekey.

New tests have been added:

  * passphrase
  * idempotence
  * removal

Co-Authored-By: Pierre-Louis Bonicoli <pierre-louis.bonicoli@gmx.fr>

* openssl_publickey: Extend test coverage

Extend the coverage on the integration test for the module
openssl_publickey.

New tests have been added:

  * OpenSSH format
  * passphrase
  * idempotence
  * removal
2017-08-21 12:19:41 +01:00
Emma
4653f892c8 Documentation fix - subnet_name (#28462)
virtual_network was incorrectly stated as an alias for subnet_name. It should be 'subnet'.
2017-08-21 08:30:30 +01:00
nrwahl2
535ede4d15 Fixes #28444: Renamed function print_match to match_print due to variable name conflict (#28445)
* Fixes #28444: Renamed print_match function to match_print due to name conflict

* Rename `match_print` to `do_print_match`

I think this is less confusing.
2017-08-20 05:28:30 +02:00
Dag Wieers
b9cee65756 Original author wishes not to be notified by ansibot (#28447)
And moving maintainers to BOTMETA.yml as well.
2017-08-20 03:56:31 +02:00
David Kretch
beed59f303 Fix trailing space in ec2_vol example, fix 'the the' typos (#28440)
* Fix 'the the' typos, fix 'pahting' filename typo

* Change 'the the' typos to a single 'the'.
* Change `playbook_pahting.rst` to `playbook_pathing.rst`.

* Delete trailing space in ec2_vol example

Delete the trailing space in `instance: "{{ item.id }} "`, which makes the
example fail when run because it looks for instance "i-xxxx ".
2017-08-19 23:00:51 +02:00
Mike
b5a00d05d3 fixed #28183 - user module shadowfile update on SunOS (#28276)
* fixed #28183 - user module shadowfile update on SunOS
2017-08-19 13:14:58 -07:00
Jordan Borean
8e40ac54dd win_copy: rewrite with new tests and functionality (#27678)
* win_copy rewrite with new tests and functionality

* minor pep fixes

* Handle UTF-8 filenames in zip

* fix for template

* when zip assemblies are not available in .net revert to old behaviour of copying one by one

* typo fix

* some more typos

* updated logic to correctly handle when new directories can be created

* removed testing file as it is not needed

* updated documentation based on PR
2017-08-18 20:33:37 -07:00
Matt Clay
7fc4e6b4af Fix PEP 8 issue. 2017-08-18 16:19:27 -07:00
Brian Coca
49c54024e6 added helper function to convert objects to dicts 2017-08-18 18:13:51 -04:00
Brian Coca
de16ce42ef optimize reserved names warning 2017-08-18 17:45:39 -04:00
René Moser
b3a57a4014 cloudstack: cs_host: add host_tag alias (#28417) 2017-08-18 22:41:52 +02:00
Drew Bomhof
ea51567697 Allow a miq token as an argument passed into the ManageIQ Python API Client (#28088) 2017-08-18 16:25:09 -04:00
Nathaniel Case
33f342435a Attempt to detect and abort when 'fex-fabric' is present (#28342) 2017-08-18 16:13:12 -04:00
Ganesh Nalawade
4f54d6cea1 eos aggregate spec validation and doc changes (#28414)
*  Add aggregate validation for eos DI modules
*  Doc change to add aggregate examples
2017-08-19 01:41:20 +05:30
Rene Moser
f6b7c1a6c1 cloudstack: cs_storage_pool: fix state handling, add tests
cs_storage_pool: rm CloudStackException dependency

cs_storage_pool: fix UnboundLocalError in check mode
local variable 'pool' referenced before assignment
2017-08-18 22:08:41 +02:00
John McEleney
7549b27544 Add new module cs_storage_pool
- Changed zone_name to name - Changed cluster_name to cluster - Changed pod_name to pod - Corrected tags type in docs - Remove unneeded returns - Other simplifications
2017-08-18 22:08:41 +02:00
Abhijeet Kasurde
be86d77a70 Add check for correct parsing of sysctl (#24540)
* PEP8 fixes
* Refactoring of code
* Check to skip non-comment lines which doesn't
  contain = character

Fixes #24453

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-08-18 15:31:26 -04:00
Deyan Stoykov
2f732a621d haproxy: fix fail_on_not_found behaviour (#24790)
* haproxy: fix fail_on_not_found behaviour

* fix pep8 compliance
2017-08-18 15:31:12 -04:00
Dmitriy Khomutov
277b8bfaf0 Alternatives module: Add a check that the path to the executable exist (#24800)
* Add check that the path to the executable exists

* Corrected a typo
2017-08-18 15:31:06 -04:00
Sloane Hertel
29ab182537 elasticache_parameter_group: fix KeyError bug #24475 (#24509)
* Fix KeyError bug by appending None if key doesn't exist

ensure value is the expected type; if if expecting something parsed as truthy try to turn it back into the desired value - fixes result showing always changed since bool compared to str

use to_text

* use string_types instead of str, remove inline conditionals, abbreviate boolean logic
2017-08-18 15:23:38 -04:00
Guillaume Coré
ccdea1c3b8 archive: allow ZIP64 by default (#24200)
allowZip64 is True by default since python 3.4,
see https://docs.python.org/3/library/zipfile.html#zipfile-objects

With python 2.7, when the file or folder to zip is >2G,
zipfile raises LargeZipFile.

This commit set allowZip64 to true.

Fixes #24125
2017-08-18 14:55:40 -04:00
Ganesh Nalawade
c4b9dfe542 Remove default description in network DI modules (#28411) 2017-08-19 00:09:01 +05:30
Abhijeet Kasurde
a572de626c Pep8 fixes for acl module (#24666)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-08-18 14:31:16 -04:00
Catatonic
b146ba37da Update capabilities.py (#23879)
Fixes issue when using python3 interpreter: 'filter' object has no attribute 'append'
Ensure list type of data is used before appending data.
2017-08-18 14:24:33 -04:00
Konstantin Shalygin
343da35381 mail: Fix auth over starttls. (#24089) 2017-08-18 12:13:24 -06:00
Peter Sprygada
03b888052b fixes bugs in network filter for parsing ip address (#28404)
also adds parse_cli and parse_cli_textfsm to changelog
2017-08-18 14:05:26 -04:00
Gaige B Paulsen
54c50cc983 netconfig module updated to pay attention to .ssh/config (#23876) 2017-08-18 12:04:30 -06:00
Sloane Hertel
b9762b52af s3_sync was setting HAS_BOTO3 by the existence of botocore alone. Fixes #28023 (#28339)
* s3_sync was setting HAS_BOTO3 by the existence of botocore alone. Fixed to import from module_utils.ec2 to ensure boto3 + botocore are present.

Also documented module requirements.

* Remove unused import
2017-08-18 13:21:10 -04:00
Bobby Watson
8e8a7c869a Changed string check to verify that EOS device is not in config mode. (#28332)
Changed string check to verify that EOS device is not in config mode. This was required in order to work with Arista 7500 series modular switches.
Resolves #2830
2017-08-18 09:06:46 -06:00
Chris Alfonso
bd56e6c9ce Removing deprecated openswitch modules (#28397) 2017-08-18 08:58:45 -06:00
Doug Gorley
5e6984a34c Added support to GCE module for image families and external projects. (#26711)
* Added support to GCE module for image families and external projects.

* Added image_family and external_projects to gce_pd.

* Added version_added for new options.
2017-08-18 10:45:13 -04:00
Nathaniel Case
db5d799122 Fix nxos_pim idempotence (#28348) 2017-08-18 09:47:41 -04:00
TaoBeier
be6c4908a2 executor stats and task_executor pep8 error (#23651) 2017-08-18 08:55:48 -04:00
Abhijeet Kasurde
6fd579b9f5 Refactor DigitalOcean modules
Fix adds refactoring of DigitalOcean modules by adding
common functionality to module_utils.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-08-18 00:23:54 -07:00
Ganesh Nalawade
9ab9945cf3 iosxr modules aggregate check and other minor refactor (#28360)
*  iosxr aggregate validation
*  vyos_user, junos_user minor changes
*  Aggregated documentation
2017-08-18 09:50:35 +05:30
Ganesh Nalawade
ceef4f97ed Use merge operation for load configuration in junos modules (#28369)
*  Change load configuration operation from replace to merge
2017-08-18 09:50:02 +05:30
Mehran Kholdi
ecfa7f696d Enforce state='file' in copy module
This was causing wrong behaviour when `prev_state` was `hard`-link,
since the `file` module tried to apply the same `state` on the new
file, causing unexpected errors.

Particularly, both `overlay` and `devicemapper` storage drivers in
docker use hardlinks to share files between layers. This causes
most ansible playbooks to fail when working with files from layers
below.
2017-08-17 18:16:17 -07:00
Dag Wieers
78dfbed2a5 openbsd_pkg: Fix when failed, PEP8-compliant (#26018)
This PR includes:
- PEP8 compliancy
- A fix to ensure the module fails when it failed for a package
- Various cosmetic changes to documentation
- Make `state: present` the default (and not required)
2017-08-17 18:20:02 -04:00
Sam Doran
9fe898add6 Make options match others in the file 2017-08-17 17:44:27 -04:00
Kurt Bomya
05fd51f77d Added "choices" true/false for user_install 2017-08-17 17:44:27 -04:00
Julien Stroheker
0b29162b97 Azure Availability Set module (azure_rm_availabilityset) (#28353)
* Adding the module and int. tests

* upgrading metadata to 1.1
2017-08-17 17:20:16 -04:00
Sergio Millan
400085aa5b return EXCL_STATE when color property is not in the response 2017-08-17 17:17:49 -04:00
Artem Loginov
6e8eb7612a Fixed issue with legacy jenkins instances 2017-08-17 17:17:49 -04:00
Filipe Azevedo
6868c892ed Fixes https://github.com/ansible/ansible-modules-extras/issues/2462 (#21891) 2017-08-17 17:16:55 -04:00
Adrian Likins
01c0b2f714 Handle errors in jmespath in json_query better (#22109)
* Handle errors in jmespath in json_query better

Catch any exceptions raised from jmespath and raise
an AnsibleFilterError instead.

Avoid a traceback.

Fixes #20379

* pep8
2017-08-17 17:16:35 -04:00
Lukas Beumer
eebc0cea6e [cloud][gcp] Add region and versioning parameter to gc_storage (#27802) 2017-08-17 15:58:29 -04:00
John Bond
722579356d correct handeling of execute option (#23814) 2017-08-17 15:50:38 -04:00
Nihlaeth
e5ff8e3407 Don't remove comment from public key, and improve error message for duplicate keys (github_key) (#22282)
* improve error message for duplicate public keys

* don't consider self when searching for duplicates

* don't strip comment from key
2017-08-17 15:38:39 -04:00
Antony Messerli
e0d0446183 Updates lldp module example to use ifname instead of ifalias (#23064) 2017-08-17 15:38:30 -04:00
Anthony Arnaud
3da1036baa zfs bad volume block size #23090 (#23092) 2017-08-17 15:38:24 -04:00