James Cammarata
d0d9be30d5
Correctly compile handler blocks for dependent roles
2015-06-23 15:48:48 -04:00
James Cammarata
0b16580567
Add in playbook_dir magic variable
2015-06-23 14:29:39 -04:00
James Cammarata
4c6adcf143
Submodule pointer update
2015-06-23 13:32:50 -04:00
Hugh Saunders
4246777759
Re-implement the ssh connection retry, originally added in 2df690
2015-06-23 12:14:14 -04:00
James Cammarata
006391eb83
Add the improved exception reporting to the minimal callback plugin
2015-06-23 12:14:14 -04:00
Toshio Kuratomi
6aae500a2c
Documentation fix
2015-06-23 08:58:26 -07:00
Toshio Kuratomi
125e6f49a1
Update submodule refs
2015-06-23 08:49:01 -07:00
James Cammarata
72d4b40a26
Don't allow empty (none) loop values
...
Fixes #8593
2015-06-23 10:42:33 -04:00
James Cammarata
24d2202591
Make sure role parsing can handle a few more types in includes/defs
2015-06-23 10:20:09 -04:00
James Cammarata
aa53212a9b
Don't use all task params for vars, just the module args
2015-06-23 10:20:09 -04:00
Toshio Kuratomi
952166f48e
Fix problem with chroot connection plugins and symlinks from within the chroot.
2015-06-22 20:08:08 -07:00
Toshio Kuratomi
61e367f549
Better error messages when the file to be transferred does not exist.
2015-06-22 20:08:08 -07:00
James Cammarata
7490044bbe
Implement play_hosts magic variable (and ansible_current_hosts)
...
Fixes #8073
2015-06-22 21:03:55 -04:00
James Cammarata
cb5f630f33
Don't post_validate vars and vars_files on Play objects
...
Fixes #11343
2015-06-22 11:23:23 -04:00
James Cammarata
ff251a0dcc
Catch runtime errors due to recursion when calculating group depth
...
Fixes #7708
2015-06-22 02:06:07 -04:00
James Cammarata
97954ff658
Minor tweak to potentially speed the linear strategy up
...
* Don't fetch vars for the task unless we're going to use them
2015-06-22 00:53:34 -04:00
Benno Joy
f17bdc4d61
Set the ansible_ssh_port variable instead of saving it internally for Host
...
Fixes #11330
2015-06-22 00:38:41 -04:00
Brian Coca
b34b606fcf
fixed and/or grouping
2015-06-21 01:51:28 -04:00
Brian Coca
68325dbfe2
fixed remote tmp creation when becoem user is not root and '~/' instead of $HOME is the default
2015-06-21 01:43:35 -04:00
Brian Coca
102de96ebf
avoid password handling when no password is supplied
2015-06-21 01:24:35 -04:00
Brian Coca
3bad03d57a
cleaned up and optimized become handling paths
2015-06-21 01:13:22 -04:00
Benno Joy
be81b650e8
fixes issue 11286 where role handlers are not run
2015-06-21 00:36:37 -04:00
James Cammarata
fc5be30c2f
Change the use of a mutable arg for a default value for locals
2015-06-19 23:04:35 -04:00
James Cammarata
0d92599d18
Make exception printing a bit smarter
2015-06-19 22:59:12 -04:00
Toshio Kuratomi
a77b58e351
Bumpt the BUFSIZE to 64k for better performance
2015-06-19 11:52:06 -07:00
Toshio Kuratomi
0777d02505
Fix problem with jail and zone connection plugins and symlinks from within the jail/zone.
2015-06-19 11:09:48 -07:00
Toshio Kuratomi
ca2f2c4ebd
Fix problem with jail and zone connection plugins and symlinks from within the jail/zone.
2015-06-19 09:41:48 -07:00
Toshio Kuratomi
f0777d9c4e
Update submodule refs
2015-06-19 09:08:57 -07:00
James Cammarata
18a9eff11f
Properly use local variables from templates including other templates
...
Fixes #6653
2015-06-18 16:10:21 -04:00
James Cammarata
c0dfa8d512
Make sure task names are templated before callbacks are sent
2015-06-18 14:27:20 -04:00
James Cammarata
98fee172ee
Fix bug in async action plugin
2015-06-18 13:49:34 -04:00
James Cammarata
270eb4274c
Make sure we safe_eval booleans too
...
Fixes #5779
2015-06-18 11:12:46 -04:00
Brian Coca
4d5a98d8d9
Merge pull request #11307 from dagwieers/patch-6
...
Change syslog (priority) level from LOG_NOTICE to LOG_INFO
2015-06-18 10:29:16 -04:00
Brian Coca
7bb2a7aa87
actually no password to handle, this should return false
2015-06-18 10:23:37 -04:00
Brian Coca
87a0ccc354
fixed typo
2015-06-18 10:12:04 -04:00
Brian Coca
aede9f08db
fixed case in which prompt was None
2015-06-18 10:05:23 -04:00
Dag Wieers
4ca4d36ae6
Change syslog (priority) level from LOG_NOTICE to LOG_INFO
...
If you look at the meaning of the different syslog levels, NOTICE means that the event may need someone to look at it. Whereas INFO is pure informational.
Since module invocations are in fact requested (deliberate) actions, they shouldn't need any additional post-processing, and therefore should not be logged as NOTICE.
This may seem like hairsplitting, but correctly categorizing system events helps weeding through the noise downhill.
According to Wikipedia: https://en.wikipedia.org/wiki/Syslog
5 Notice notice Events that are unusual but not error conditions .
6 Informational info Normal operational messages -no action required. Example an application has started, paused or ended successfully.
2015-06-18 11:00:10 +02:00
Brian Coca
7c65f3ddd7
partial become support for local connection plugin
2015-06-18 01:46:43 -04:00
Brian Coca
671118ba71
fixed become password handling with paramiko
2015-06-17 23:31:55 -04:00
Brian Coca
744ec2bbad
put hostkey locking into function (still needs fixing)
...
implemneted become handling here, cannot generalize well enough in base class
2015-06-17 23:31:54 -04:00
Brian Coca
d6672ad285
removed unused import
2015-06-17 23:31:54 -04:00
Brian Coca
5cfd0f82a0
moved away from generic function for become
2015-06-17 23:31:54 -04:00
Brian Coca
3fab516d3d
fixed detection of incorrect password
2015-06-17 23:31:54 -04:00
Brian Coca
faed1b2d05
better error reporting when doc parsing fails
2015-06-17 23:31:54 -04:00
James Cammarata
87ca475704
Exclude the all/ungrouped groups from pattern matching results
...
Fixes #5375
2015-06-17 16:25:58 -04:00
James Cammarata
90445ee67d
Add ::1 where we see 127.0.0.1, for better ipv6 support
...
Fixes #5764
2015-06-17 16:03:19 -04:00
James Cammarata
c3c398cffe
Cleaning up some task failure detection problems
...
* fixed a bug in which failures from a with_* loop were not being
caught correctly, leading to tasks continuing when they should stop
* when ignore_errors is enabled, the failure will no longer count
towards the number of failed tasks
2015-06-17 15:40:04 -04:00
Marc Abramowitz
a385744426
Add inventory file to "Unable to find" error msg
...
E.g.:
$ ansible gabriel -m ping -i ssh_config.py
ERROR! Unable to find an inventory file (ssh_config.py), specify one with -i ?
2015-06-17 11:00:13 -07:00
James Cammarata
daa319881f
Make sure registered variable message is sent before other messages
...
Avoids a race condition where previously the registered variable message
was being sent after the 'host_task_ok' message, meaning the next task
may be started before the var is registered, leading to an undefined
variable error
2015-06-17 12:42:47 -04:00
Benno Joy
0d5b7ae669
fixes 11296 where the groups does not have all the groups
2015-06-17 19:18:19 +05:30
James Cammarata
ff998b6022
Make sure the templar is using the right vars when evaluating conditionals
2015-06-17 00:10:11 -04:00
Brian Coca
d7fcd9456a
Merge pull request #11288 from kstrauser/aixfixes
...
Don't panic if AIX's uname doesn't support -W
2015-06-16 19:02:50 -04:00
Kirk Strauser
eb820837ac
Don't panic if AIX's uname doesn't support -W
...
The current code expects "uname -W" on AIX to always succeed. The AIX 5
instance I have doesn't support the -W flag and facts gathering always
crashes on it.
This skips some WPAR handling code if "uname -W" doesn't work.
2015-06-16 15:26:02 -07:00
Kirk Strauser
935da01068
Fixes for FreeBSD get_memory_facts
...
- swapinfo on FreeBSD 6 (maybe 7 too?) doesn't support the "-m" flag for
fetching amounts in megabytes. This patch fetches amounts in kilobytes
and divides by 1024 (and also returns the result as an int instead of
a string).
- When no swap is configured, swapinfo prints a header line and nothing
else:
$ swapinfo
Device 1K-blocks Used Avail Capacity
The old version unexpectedly parsed that header line and emitted
nonsense values like:
"ansible_swapfree_mb": "Avail"
"ansible_swaptotal_mb": "1K-blocks"
This version emits those items altogether.
2015-06-16 14:35:36 -07:00
Brian Coca
3b1b95b916
moved ipv6 handling to init
...
fixed become password handling
2015-06-16 15:48:10 -04:00
Brian Coca
bb7d33adbc
moved become password handlingn to base class
2015-06-16 15:48:10 -04:00
James Cammarata
4b28a51f25
Don't fail outright when a play has an empty hosts list
2015-06-16 13:56:23 -04:00
James Cammarata
30c1a2d861
Have group/host var file loading check for YAML extensions too
...
Fixes #11132
2015-06-16 11:55:56 -04:00
Brian Coca
423f1233c8
removed typo file
2015-06-16 10:49:37 -04:00
Brian Coca
c87591f76f
updated to new exec_command signature
2015-06-16 09:28:27 -04:00
Brian Coca
b76dbb01cc
generalized prereqs check
...
added vaultfile class for action and lookup plugin usage
2015-06-16 09:20:15 -04:00
Brian Coca
9116ff1c28
replaced removed pager_print for print
2015-06-16 09:19:37 -04:00
Brian Coca
98f5534d9c
adaptaed to new exec signature
...
should fix #11275
2015-06-16 09:12:42 -04:00
Brian Coca
6c884c9e39
Merge pull request #11271 from sivel/build-play-method
...
Allow AdHocCLI to be more flexible for overriding
2015-06-15 16:21:32 -04:00
Brian Coca
dcf81e3ffe
removed useless comments
2015-06-15 15:04:19 -04:00
Matt Martz
1d55e193c1
Expose the TaskQueueManager to self
2015-06-15 13:50:40 -05:00
Matt Martz
670894e2bd
Move building the play_ds into a method, that can be overridden
2015-06-15 10:35:26 -05:00
Brian Coca
8ae58f7ea3
fixed executable, correctly this time
2015-06-15 11:26:45 -04:00
Brian Coca
f576d29b6b
allow for any non string iterable in listify
2015-06-15 11:02:51 -04:00
Brian Coca
1ce1c52f6f
centralized bad password handling, fixed outputing of become method
2015-06-15 01:40:53 -04:00
Brian Coca
b89071e485
now detects incorrect password with sudo and su (at least in english)
2015-06-15 01:30:03 -04:00
Brian Coca
be8d797c23
fixed su prompt function reference
2015-06-15 01:07:02 -04:00
Brian Coca
872448e9e8
updated connection info update_vars to only update if data is not alreayd present
...
aslo added comment clarifying why we do this
2015-06-15 01:02:27 -04:00
Brian Coca
956937b110
made executable shell configurable again
2015-06-15 00:15:31 -04:00
Brian Coca
580993fef7
enabled initial support for password prompt on become
...
- moved check prompt/password functions to connection, make more senes there
- TODO: consider moving make_become to connection from connection_info
- removed executable param that was never overriden outside of connection info
2015-06-15 00:09:25 -04:00
Brian Coca
bac35ae773
set correct become mehotds for plugin
...
fixed mixup with remote password vs become_password
2015-06-14 23:49:10 -04:00
Brian Coca
ff443d4534
added note to figurte out correct var udpate on connection_info
2015-06-14 23:48:03 -04:00
Brian Coca
c3ccf26b70
added become check back to connections
2015-06-14 23:45:56 -04:00
Brian Coca
de82c953f2
added privilege escalation special var mapping
2015-06-14 23:19:49 -04:00
Brian Coca
a248678518
initial become support to ssh plugin
...
- password prompt detection and incorrect passwrod detection to connection info
- sudoable flag to avoid become on none pe'able commands
2015-06-14 23:03:23 -04:00
Brian Coca
a267f93c83
removed incorrect assumption on become user being set
2015-06-14 21:05:23 -04:00
Brian Coca
ff15f374ad
fixed new become settings, rearranged constants to find PE related vars easier
2015-06-14 20:50:38 -04:00
Brian Coca
e7abe06440
added first_found to template
2015-06-13 00:34:15 -04:00
Brian Coca
8ee4c7266c
corrected original_file code path to use actually use data from original file
2015-06-13 00:10:17 -04:00
Brian Coca
491761f880
added note to add faf deprecation
2015-06-12 23:54:09 -04:00
Brian Coca
a6ca133da8
got first_available working with copy
2015-06-12 23:54:09 -04:00
Brian Coca
aca125d03e
Merge pull request #11252 from sivel/deprecated-warning
...
Display a warning when using a deprecated module
2015-06-12 16:30:45 -04:00
Matt Martz
9ed3e2ef48
Display a warning when using a deprecated module
2015-06-12 15:21:33 -05:00
Toshio Kuratomi
d315f6e22c
Fix Etcd constructor
2015-06-12 12:59:29 -07:00
Toshio Kuratomi
77c76e632e
Switch etcd and url lookup plugins to verify ssl certificates
2015-06-12 12:54:57 -07:00
Toshio Kuratomi
4161d78a94
Split the fetch_url() function into fetch_url and open_url().
...
open_url() is suitable for use outside of a module environment. Will
let us use open_url to do SSL cert verification in other, non-module
code.
2015-06-12 12:54:56 -07:00
Brian Coca
e07dde1a3c
Merge pull request #11251 from sivel/issue/11244
...
Require passlib over crypt in password_hash for Mac OS X/Darwin. Fixes #11244
i was almost done with my patch ... but I like yours better
2015-06-12 14:58:02 -04:00
Matt Martz
a4e2d1eb62
Require passlib over crypt in password_hash for Mac OS X/Darwin. Fixes #11244
2015-06-12 13:54:43 -05:00
Brian Coca
aaab69cae9
brought back terms testing as with_ is not only way to call and we cannot guarantee terms is a list otherwise.
2015-06-11 13:45:04 -04:00
Toshio Kuratomi
c346788194
Slight optimization of how we squash loops. Add dnf to the list of modules for which we squash.
...
Fixes #11235
2015-06-11 08:55:56 -07:00
Brian Coca
aed429554d
better checks to ensure listify emits a non string iterable
2015-06-11 10:03:44 -04:00
Brian Coca
c8fde467b5
Merge pull request #11163 from sivel/ssh-private-key-fixme
...
Re-introduce ssh connection private key support
2015-06-11 09:16:27 -04:00
Brian Coca
f174682e19
facts should now not be overriten with NA option unless they are NA
...
this way we don't need a break per distro that matched already with
the python default functions
2015-06-11 00:48:40 -04:00
Brian Coca
4098e8283e
several fixes to template
...
- now obeys global undefined var setting and allows override (mostly for with_ )
- moved environment instanciation to init instead of each template call
- removed hardcoded template token matching and now use actually configured tokens, now it won't break if someone changes default configs in ansible.cfg
- made reenetrant template calls now pass the same data it got, dictionary and lists were loosing existing and new params
- moved fail_on_undeinfed parameter to template call, as it should only realky be set to false on specific templates and not globally
- added overrides, which will allow template to implement jinja2 header override features
- added filter list to overrides to disallow possibly insecure ones, TODO: check if this is still needed as facts should not be templated anymore
- TODO: actually implement jinja2 header overrides
2015-06-11 00:21:53 -04:00
Brian Coca
7291f9e965
removed cruft
...
made sure it does not fail on undefined
2015-06-11 00:13:40 -04:00
Brian Coca
f29c1c7452
respect undefined config setting
2015-06-10 23:26:01 -04:00
Brian Coca
40336b50af
removed redundant string check
...
added playbook path lookup
2015-06-10 22:58:08 -04:00
Brian Coca
7306a5397e
simplified function, always attempt to template, always check if string before return, should avoid most cases of strings being passed to lookups
2015-06-10 22:55:50 -04:00
Brian Coca
aa6e204b6e
Merge pull request #11115 from jhawkesworth/second_go_at_fixing_1404
...
Part fix for https://github.com/ansible/ansible-modules-core/issues/1404 (replaces #11086 )
2015-06-10 20:43:32 -04:00
Brian Coca
f2934eeb0a
Merge pull request #11226 from resmo/for-ansible
...
cloudstack: cleanup, remove unused parts
2015-06-10 14:44:49 -04:00
Brian Coca
d68111382d
updated with nagios doc fix
2015-06-10 13:00:29 -04:00
Brian Coca
39764ed7d8
updated submodule refs
2015-06-10 13:00:29 -04:00
Rene Moser
0b074c449b
cloudstack: methods renaming
2015-06-10 17:31:46 +02:00
Rene Moser
7b3dd55c3d
cloudstack: remove unused methods used for backward compatibility
2015-06-10 17:28:45 +02:00
Dionysis Grigoropoulos
6f11896303
ansible-pull: Add option to verify gpg signature of a commit
...
Add option '--verify-commit' to verify a GPG signature of the checked
out commit. As noted in the git module documentantion, this requires
git version >= 2.1.0
2015-06-10 17:29:04 +03:00
Brian Coca
757fb39a2e
now uses new module_loader
2015-06-09 21:35:44 -04:00
Brian Coca
24b7c353cc
readjusted limit opts, makes no sense in adhoc when you already specify selection
...
changed pull to reflect this
2015-06-09 17:35:19 -04:00
Brian Coca
845d564d89
removed debug, moved limit to runtask instead section
2015-06-09 17:32:34 -04:00
Brian Coca
fdeca37257
switched to argv[0] from __file__ as it is what we actually wanted
2015-06-09 17:29:46 -04:00
Brian Coca
5aec5e5eb0
fixed ansible pull, reorged validate function for cli to be function specific like parser
...
added missing cmd_functions with run_cmd, mostly for ansible pull
2015-06-09 17:24:43 -04:00
Brian Coca
19161dfd72
fixed typo in placeholder check
2015-06-09 11:46:08 -04:00
Rene Moser
fc3020c57a
cloudstack: prevent getting the wrong project.
...
Since we use domain and account data to filter the project, listall is not needed and can return the wrong identical named project of another account if root admin permissions are used.
Fixed projects names are not case insensitive.
2015-06-09 16:16:58 +02:00
Brian Coca
8e3213a91e
updated copyright as MPD does not deserve the blame for this one
2015-06-08 20:20:07 -04:00
Brian Coca
45f80328ae
updated submodule refs
2015-06-08 20:14:47 -04:00
Brian Coca
70b5c28694
initial implementation of the generic OS package module
2015-06-08 20:12:42 -04:00
Toshio Kuratomi
e88a9e943c
Use to_bytes to avoid tracebacks when passed a byte str instead of a unicode string
...
Fixes #11198
2015-06-08 11:15:11 -07:00
Brian Coca
97bc92d2df
minor cleanup, pushed ipv6 fixing to init
...
pushed up using host short var
made close conditional, started implementing close for controlmaster
2015-06-08 10:52:08 -04:00
Matt Martz
6a1c175991
Raise AnsibleParserError instead of AssertionError
2015-06-06 09:16:38 -05:00
Brian Coca
bdba807fd1
minor fixes to ssh error reporting
...
shoudl fix #11041
2015-06-06 00:16:35 -04:00
Edward J Kim
6a5a930c5a
Add missing import in vault.py
2015-06-05 23:04:21 -04:00
Toshio Kuratomi
65d982b186
Merge pull request #11186 from sivel/winrm-syntax-error
...
Fix syntax error in winrm
2015-06-05 15:47:21 -07:00
Brian Coca
d67c9858a9
removed become_pass as it should not be used
2015-06-05 18:43:42 -04:00
Brian Coca
46673cd620
Merge pull request #11183 from sivel/issue/11169-become-pass
...
Don't empty out become_pass. See #11169
2015-06-05 18:21:29 -04:00
Matt Martz
6f5ebb4489
Fix syntax error in winrm
2015-06-05 16:02:29 -05:00
Matt Martz
45b4ee9cfe
Don't allow setting become_pass in a play
2015-06-05 14:10:00 -05:00
Toshio Kuratomi
f9b56a5d7c
Fix raising AnsibleError
2015-06-05 11:41:23 -07:00
Matt Martz
6bc2ea1f2b
Don't empty out become_pass. See #11169
2015-06-05 12:02:35 -05:00
Brian Coca
04f4f77d91
Merge pull request #11124 from sivel/jit-connect
...
Use a decorator to perform just in time connection
2015-06-05 11:38:17 -04:00
James Cammarata
73c956366e
Correctly determine failed task state when checking results
...
Fixes #11172
2015-06-05 07:16:19 -04:00
James Cammarata
a4ebee4b16
Merge pull request #11170 from dguerri/devel
...
Fix lookup() plugin
2015-06-04 16:05:06 -04:00
James Cammarata
ee5e166563
Fixing ansible_*_interpreter use
...
Fixes ansible/ansible-modules-core#1459
2015-06-04 15:43:07 -04:00
Davide Guerri
ee06eebea3
Fix lookup() plugin
...
lookup() plugin is currently broken because _get_file_contents() now
returns a tuple: (contents, show_data).
This patch fix that issue.
2015-06-04 19:46:09 +01:00
Matt Martz
bce281014c
Decorate the ConnectionBase methods, switch to calling super from individual connection classes
2015-06-04 13:27:18 -05:00
Matt Martz
9754c67138
Use a decorator to ensure jit connection, instead of an explicit call to _connect
2015-06-04 13:14:28 -05:00
James Cammarata
f3f3fb7c49
Fixing vars_prompt
2015-06-04 13:54:51 -04:00
Matt Martz
6a97e49a06
Re-introduce ssh connection private key support
2015-06-04 08:15:25 -05:00
Toshio Kuratomi
7dd3ef7b60
Older python-six from early RHEL and ubuntu do not have add_metaclass but do have with_metaclass
2015-06-03 13:29:24 -07:00
Brian Coca
f3ccff42e5
Merge pull request #11142 from Etienne-Carriere/factor_f5
...
Add common fonctions for F5 modules (FQ Name functions)
2015-06-03 16:27:57 -04:00
Etienne CARRIERE
94fa5e8794
Simplify Fully Qualified function
2015-06-03 21:19:11 +02:00
Brian Coca
9856a8f674
added missing imports to doc module
2015-06-03 15:00:41 -04:00
Toshio Kuratomi
96836412aa
Make error messages tell which inventory script the error came from
2015-06-03 11:51:33 -07:00
Brian Coca
a87687dccb
Merge pull request #11147 from sivel/module-docs-import-mutablemapping
...
Import missing MutableMapping class for module_docs
2015-06-03 14:50:17 -04:00
Toshio Kuratomi
1c8527044b
Fix error handling when pasing output from dynamic inventory
2015-06-03 11:29:20 -07:00
Toshio Kuratomi
c3caff5eeb
Fix for six version 1.1.0 (rhel6).
2015-06-03 10:25:07 -07:00
Brian Coca
6b642afc7b
Merge pull request #11146 from sivel/issue/11136
...
Don't set a default on the _become FieldAttribute
2015-06-03 12:38:20 -04:00
Toshio Kuratomi
d8c8ca11cf
Add compatibility for old version of six (present on rhel7)
2015-06-03 08:45:36 -07:00
Matt Martz
89dceb503a
Import missing MutableMapping class
2015-06-03 10:02:27 -05:00
Matt Martz
f983557e7e
Don't set a default on the _become FieldAttribute. Fixes #11136
2015-06-03 09:54:00 -05:00
Etienne CARRIERE
5204d7ca88
Add common fonctions for F5 modules (FQ Name functions)
2015-06-03 08:20:26 +02:00
Patrick McConnell
a899f8f016
Fix for task_executor on OS X
...
I get this exception during the setup task:
AttributeError: 'ConnectionInformation' object has no attribute 'remote_pass'
I believe it is supposed to be looking at the password attribute. Either that
or we should create a remote_pass attribute in ConnectionInformation.
2015-06-03 07:26:18 +02:00
Brian Coca
3e2e81d896
missing path in import path for making paths
2015-06-02 23:42:00 -04:00
Brian Coca
65b82f69e4
avoid failing when mode is none
2015-06-02 23:39:57 -04:00
Brian Coca
5622fc23bc
fixed frozen set, missing iterable
2015-06-02 23:35:15 -04:00
Brian Coca
48c0d6388f
moved RAW var to class and as a frozenset
2015-06-02 23:35:15 -04:00
Matt Martz
1b48111b12
If remote_addr isn't set, set to ipv4_address
2015-06-02 14:56:32 -05:00
James Cammarata
f57eaece88
Merge pull request #11134 from sivel/import-display-cli-base
...
Add missing import in ansible.cli
2015-06-02 14:11:32 -05:00
Matt Martz
6519118106
Add missing import in ansible.cli
2015-06-02 14:11:16 -05:00
James Cammarata
7a617e7b93
Merge pull request #11131 from sivel/issue/11130
...
Don't override ansible_ssh_host with inventory_hostname
2015-06-02 14:03:25 -05:00
James Cammarata
c4ae51089d
Merge pull request #11129 from sivel/fix-scp-if-ssh
...
Fix command building for scp if ssh
2015-06-02 14:02:51 -05:00
Matt Martz
697a1a4061
Don't override ansible_ssh_host with inventory_hostname
2015-06-02 14:01:11 -05:00
Matt Martz
71014ab01e
Fix command building for scp if ssh
2015-06-02 13:35:53 -05:00
Brian Coca
093b5b6051
Merge pull request #11127 from bcoca/makedirs_safe
...
created makedirs_safe function for use in cases of multiprocess
2015-06-02 13:36:39 -04:00
Brian Coca
e0ef217f97
Revert "Adding raw module to list of modules allowing raw params"
...
This reverts commit bc041ffea0
.
same fix x2 does not fix it 'more'
2015-06-02 13:33:33 -04:00
Brian Coca
ba02e5e3bf
minor adjustments as per code review
2015-06-02 13:01:59 -04:00
Brian Coca
2590df6df1
created makedirs_safe function for use in cases of multiprocess
...
should fix #11126 and most race conditions
2015-06-02 11:41:30 -04:00
Brian Coca
47be5b4166
added missing ansibleoptionserror import and moved args check in playbook to after parser exists to allow for creating usage info
2015-06-02 11:03:17 -04:00
James Cammarata
d1b4371287
Correctly evaluate changed/failed for tasks using loops
2015-06-02 09:42:08 -05:00
Brian Coca
860a96cf70
Merge pull request #11097 from resmo/for-ansible
...
cloudstack: updates and v1 sync
2015-06-02 10:25:45 -04:00
James Cammarata
bc041ffea0
Adding raw module to list of modules allowing raw params
...
Fixes #11119
2015-06-02 08:42:24 -05:00
Brian Coca
e251e70178
added raw to 'raw' modules
2015-06-02 08:54:37 -04:00
Rene Moser
caf3cf6930
cloudstack: add timeout to utils
2015-06-02 14:51:25 +02:00
Rene Moser
fc807e29c8
cloudstack: add api_timeout to doc fragments
2015-06-02 14:51:25 +02:00
Rene Moser
7bb9cd3766
cloudstack: minor cleanup in doc fragments
2015-06-02 14:51:25 +02:00
James Cammarata
620fad9f8d
Fixing an oops in inventory/__init__.py where the slots are incorrect
2015-06-01 20:02:15 -05:00
James Cammarata
7f1b64d934
Submodule pointer update for core to the merged v2 branch
2015-06-01 19:46:29 -05:00
James Cammarata
e547e1f9ba
Merge branch 'devel' into devel_switch_v2
2015-06-01 16:53:15 -05:00
James Cammarata
fe41f109a9
Merge branch 'v2_final' into devel_switch_v2
2015-06-01 16:42:59 -05:00
James Cammarata
4bc7703db3
Fixing some small bugs related to integration tests (v2)
2015-06-01 16:42:10 -05:00
Jon Hawkesworth
30b92a6f4c
Get-FileChecksum allways returns a string now,
...
and the test_win_copy integration tests that depend on the checksum
have been updated in this change too.
2015-06-01 21:53:49 +01:00
Brian Coca
9a90ca5a36
Merge pull request #11062 from Etienne-Carriere/factor_f5
...
Factor primitives for F5 modules
2015-06-01 10:34:11 -04:00
sysadmin75
816b20af0b
Fixes #11046
2015-06-01 10:24:20 -04:00
sysadmin75
908d6c0ef2
Fixes #11046
2015-05-31 20:05:02 -04:00
Toshio Kuratomi
5954892457
Update submodule refs
2015-05-29 19:00:16 -07:00
Brian Coca
529726d0ba
fixed mistaken module update in prev commit
2015-05-29 16:22:55 -04:00
Brian Coca
7e020d21de
correctly identify ubuntu now in all cases
...
made NA the last resort
2015-05-29 16:19:09 -04:00
Brian Coca
a8c290cc3b
fixed ubuntu facts for all versions
...
made sure NA is option of last resort
2015-05-29 16:14:30 -04:00
Monty Taylor
2046d76310
Add defaults and a link to os-client-config docs
2015-05-29 13:10:13 -07:00
Monty Taylor
b659621575
Remove unneeded required_one_of for openstack
...
We're being too strict - there is a third possibility, which is that a
user will have defined the OS_* environment variables and expect them to
pass through.
2015-05-29 13:09:45 -07:00
Toshio Kuratomi
2924c90a5d
Merge pull request #10977 from emonty/fix-envvars
...
Fix envvars support in openstack modules
2015-05-29 13:05:03 -07:00
Toshio Kuratomi
dee2d53b3e
Update v2 submodule refs
2015-05-29 08:51:50 -07:00
Jon Hawkesworth
12691ce109
Add -Compress to ConvertTo-Json calls in common powershell code
2015-05-29 10:40:24 -04:00
Jon Hawkesworth
9371c38af9
Add -Compress to ConvertTo-Json calls in common powershell code
2015-05-29 14:50:08 +01:00
James Cammarata
7985d2a8be
Moving included file stuff to a proper dedicated class and file (v2)
2015-05-28 23:58:38 -05:00
James Cammarata
fe014148d9
Removing errant debug print
2015-05-28 20:29:16 -05:00
Brian Coca
e7a096c4c5
cowsay is back!
2015-05-28 20:01:39 -04:00
Stefan Midjich
e5190327f2
this fixes ansible on openbsd and freebsd systems. only tested on openbsd.
2015-05-28 19:17:31 -04:00
Toshio Kuratomi
5d213cab23
Update extras submodule ref for doc fix
2015-05-28 16:00:58 -07:00
Toshio Kuratomi
5ffc1183dd
WHoops, that was the core module stable branch
2015-05-28 15:37:12 -07:00
Toshio Kuratomi
2f4ad2714f
Update core module ref
2015-05-28 15:36:35 -07:00
Toshio Kuratomi
4d8427538d
Update submodule refs
2015-05-28 15:10:06 -07:00
James Cammarata
60bea844b3
Merge branch 'v2_final' into devel_switch_v2
2015-05-28 15:27:09 -05:00
James Cammarata
2bad888f28
Merge branch 'v2_final' into devel_switch_v2
...
Conflicts:
lib/ansible/inventory/__init__.py
lib/ansible/modules/core
lib/ansible/utils/__init__.py
lib/ansible/utils/module_docs.py
2015-05-28 15:26:03 -05:00
Toshio Kuratomi
afc19894e1
Make fetch_url check the server's certificate on https connections
2015-05-28 13:20:40 -07:00
Toshio Kuratomi
1ccf2a4685
Make fetch_url check the server's certificate on https connections
2015-05-28 12:35:37 -07:00
James Cammarata
e59d4f3b51
More module_utils/basic.py unit tests for v2
2015-05-28 01:26:04 -05:00
Toshio Kuratomi
388827a636
Update submodule ref
2015-05-27 20:28:29 -07:00
Toshio Kuratomi
b72a912562
Update submodule refs
2015-05-27 06:50:46 -07:00
James Cammarata
339a02c384
Started reworking module_utils/basic unit tests (v2)
2015-05-27 03:21:15 -05:00
Toshio Kuratomi
ea4421d10e
Update submodule refs
2015-05-26 15:33:47 -07:00
Toshio Kuratomi
f1ab1c48f4
Update submodule refs for v2
2015-05-26 12:38:26 -07:00
Brian Coca
3865c5051b
Merge pull request #11058 from srvg/bug/11017
...
limit extensions for files in group/host_vars dir
2015-05-26 15:31:12 -04:00
Toshio Kuratomi
d793ed360b
Fix syntaxerror in the required_if arg spec check
2015-05-26 11:30:06 -07:00
Toshio Kuratomi
0f23d8a503
Fix syntaxerror in the required_if arg spec check
2015-05-26 11:29:35 -07:00
Brian Coca
7c6ebcab6d
Merge pull request #11073 from msabramo/include_more_info_in_errors
...
Include more info when a task fails
2015-05-26 14:26:50 -04:00
Monty Taylor
31609e1b16
Add required_if to AnsibleModule
...
There is a common pattern in modules where some parameters are required
only if another parameter is present AND set to a particular value. For
instance, if a cloud server state is "present" it's important to
indicate the image to be used, but if it's "absent", the image that was
used to launch it is not necessary. Provide a check that takes as an
input a list of 3-element tuples containing parameter to depend on, the
value it should be set to, and a list of parameters which are required
if the required parameter is set to the required value.
2015-05-26 11:21:38 -07:00
Toshio Kuratomi
c6b286424f
Merge pull request #9423 from emonty/features/required-if
...
Add required_if to AnsibleModule
2015-05-26 11:20:40 -07:00
Marc Abramowitz
d0a154c446
Include more info when a task fails
...
Adds "playbook", "role", and "task" fields to the output when a task fails.
This makes it easier to pinpoint where the problem is, especially
when you have a lot of roles and playbooks.
e.g.:
failed: [vagrant] => {..."playbook": "/Users/marca/dev/ansible/vagrant.yml",
..."role": "pythonapp",
..."task": "pip install -r /opt/src/{{ sm_app_role }}/requirements.txt"...}
2015-05-26 09:25:12 -07:00
Stefan Midjich
540c23dfce
this fixes ansible on openbsd and freebsd systems. only tested on openbsd.
2015-05-26 12:04:35 -04:00
Brian Coca
16c70dd7d4
added equivalent of #9636 to v2
2015-05-26 11:55:52 -04:00
Brian Coca
6000db7e5d
Merge pull request #9636 from Batmat/fix-message-i18n-parsing-error
...
Setting LC_MESSAGES: prevent unparseable messages (fixes issue #9635 )
2015-05-26 11:49:56 -04:00
Toshio Kuratomi
5f246dc1a6
Update extras submodule for doc fixes
2015-05-25 09:35:40 -07:00
Toshio Kuratomi
dcc691f462
Update submodule refs
2015-05-25 09:23:04 -07:00
Brian Coca
eaddc0b309
removed duplicate retry config entries
2015-05-25 11:06:04 -04:00
Etienne CARRIERE
3775dd5ec8
Factor F5 primitives
2015-05-25 09:53:23 +02:00
Serge van Ginderachter
b6ea8de399
limit extensions for files in group/host_vars dir
...
inventory vars: make loading from a directory obey the same rules as
when checking the base paths, looking at the file name extensions
as defined in CONSTANTS.YAML_FILENAME_EXTENSIONS
Fixes Github issue #11017
2015-05-23 20:34:08 +02:00
James Cammarata
ed4df57361
Submodule update for devel
2015-05-22 13:30:00 -05:00
James Cammarata
ecd5eb902d
Adding unit tests for ConnectionInformation (v2)
2015-05-22 03:32:40 -05:00
Toshio Kuratomi
16c2de84ec
Update the submodule refs
2015-05-21 10:00:25 -07:00
Toshio Kuratomi
13253f9c68
Merge pull request #10565 from bcoca/with_sequence_expand
...
made sequence more flexible
2015-05-21 08:05:17 -07:00
Toshio Kuratomi
04e15ab54f
Update v2 submodule refs
2015-05-21 07:59:02 -07:00
James Cammarata
9921a1d2be
Unit tests for base strategy class (v2)
2015-05-21 02:03:59 -05:00
Toshio Kuratomi
bb81f025b0
Merge pull request #8679 from j0057/support-arch-8653
...
Add support for Arch to module_utils.basic.py
2015-05-20 22:57:54 -07:00
Toshio Kuratomi
cc51e6b7c2
Update submodule refs in v2
2015-05-20 18:12:09 -07:00
Toshio Kuratomi
3b5a3aa80a
Update submodule refs
2015-05-20 17:58:40 -07:00
Toshio Kuratomi
b48be7c484
Update submodule refs for v2
2015-05-19 14:27:54 -07:00
Toshio Kuratomi
73804b375e
Update submodule ref for core doc update
2015-05-19 14:24:16 -07:00
Toshio Kuratomi
b93674b380
Update submodule refs
2015-05-19 14:19:17 -07:00
Rene Moser
8da580a29c
basic: fix ValueError if value of a type='int' is not an int
...
With this fix, we get a friendly error message:
failed: [localhost] => {"failed": true}
msg: value of argument start_port is not of type int and we were unable to automatically convert
2015-05-19 11:51:56 -04:00
Rene Moser
8f29ca23ae
basic: fix ValueError if value of a type='int' is not an int
...
With this fix, we get a friendly error message:
failed: [localhost] => {"failed": true}
msg: value of argument start_port is not of type int and we were unable to automatically convert
2015-05-19 17:40:46 +02:00
Brian Coca
9a88e0fc8e
removed empty choices from files
2015-05-19 10:46:44 -04:00
Brian Coca
da6d15d1f9
removed empty choices from files
2015-05-19 10:46:20 -04:00
James Cammarata
21fa385ce7
Reorganizing plugin unit tests and adding start of strategy tests (v2)
2015-05-18 17:26:59 -07:00
Hugh Saunders
2e07567c16
Retry exec command via ssh_retry
...
This PR adds the option to retry failed ssh executions, if the failure
is caused by ssh itself, not the remote command. This can be helpful if
there are transient network issues. Retries are only implemented in the
openssh connection plugin and are disabled by default. Retries are
enabled by setting ssh_connection > retries to an integer greater
than 0.
Running a long series of playbooks, or a short playbook against a large
cluster may result in transient ssh failures, some examples logged
[here](https://trello.com/c/1yh6csEQ/13-ssh-errors ).
Ansible should be able to retry an ssh connection in order to survive
transient failures.
Ansible marks a host as failed the first time it fails to contact it.
2015-05-18 14:22:52 -07:00
Toshio Kuratomi
f083ca747a
Update submodule ref to fix postgres_user
2015-05-18 12:46:31 -07:00
Toshio Kuratomi
e69c7f5474
Update modules refs
2015-05-18 12:08:45 -07:00
Toshio Kuratomi
5343c99cb1
Update submodule pointers
2015-05-18 09:25:15 -07:00
Toshio Kuratomi
684e30a5f4
Update submodule refs
2015-05-18 09:00:16 -07:00
Brian Coca
16df2726ca
Merge pull request #11018 from tyll/ed25519
...
facts: Add ed25519 ssh pubkey
2015-05-18 08:15:11 -04:00
Toshio Kuratomi
525de8b7cf
Fix codecs.escape_decode() usage
2015-05-17 09:28:48 -07:00
Toshio Kuratomi
8f71e47a73
Update core and extras module refs
2015-05-17 09:23:39 -07:00
Toshio Kuratomi
8e2938c997
Update core module ref for lineinfile fix
2015-05-17 09:22:31 -07:00
James Cammarata
9aa8676bdd
More template unit tests for v2
2015-05-17 01:06:02 -05:00
Brian Coca
718898891e
Merge pull request #11011 from bcoca/fuse_selinux_fix
...
attempt to fix selinux context on fuse filesystems
2015-05-15 18:07:35 -04:00
Till Maas
02d784598f
facts: Simplify ssh key fetching
2015-05-15 22:36:13 +02:00
Till Maas
e7846343e5
facts: Add ed25519 ssh pubkey
2015-05-15 22:25:20 +02:00
Toshio Kuratomi
5a94720905
Pull in a lot more doc fixes
2015-05-15 12:12:45 -07:00
Toshio Kuratomi
674d1016c0
Update extras ref for doc fix
2015-05-15 11:52:57 -07:00
Toshio Kuratomi
b0448d9cf4
Update submodule refs
2015-05-15 11:34:54 -07:00
Brian Coca
0913b8263c
made special treatment of certain filesystem for selinux configurable
2015-05-15 13:52:27 -04:00
Toshio Kuratomi
2e31a67532
Update module refs in v2
2015-05-15 10:42:41 -07:00
Brian Coca
e2de336a23
made special treatment of certain filesystem for selinux configurable
2015-05-15 13:19:15 -04:00
James Cammarata
ac7dce4631
Fixing broken set_extra_vars method after fixing unit tests (v2)
2015-05-15 10:45:55 -05:00
James Cammarata
48d62fd934
Cleaning up VariableManager tests (v2)
2015-05-14 20:10:31 -05:00
Toshio Kuratomi
b91ce29007
Go to next task when we get an error in linear
2015-05-13 12:52:51 -07:00
James Cammarata
b94e2a1f4e
Fixing bugs related to parsing and fixing up parsing integration tests (v2)
2015-05-13 11:27:12 -05:00
Brian Coca
b85ce38834
slight changes to error handling to align with v1
2015-05-13 11:15:32 -04:00
Toshio Kuratomi
892fba265b
Update to fix documentation build
2015-05-13 08:15:12 -07:00
Toshio Kuratomi
0a1dc74463
Update submodule refs
2015-05-13 07:52:13 -07:00
Toshio Kuratomi
079fca27a2
Update module refs for v2
2015-05-13 06:57:04 -07:00
James Cammarata
830225d9c1
Fix errors in subelements lookup plugin and associated tests (v2)
2015-05-12 15:09:03 -05:00
James Cammarata
4d999f8fe0
Fix logic error in parent attribute retrieval for blocks/roles (v2)
2015-05-12 15:08:35 -05:00
James Cammarata
b03b7892f8
Fix method of exiting task loop (v2)
2015-05-12 13:09:08 -05:00
Toshio Kuratomi
d0d0e9933f
Update module refs in v2
2015-05-12 11:05:58 -07:00
Serge van Ginderachter
9b646dea41
Add optional 'skip_missing' flag to subelements
2015-05-12 12:52:16 -05:00
James Cammarata
1ca8cb8553
Fixing up v2 unit tests
2015-05-12 12:24:57 -05:00
James Cammarata
361eb29146
Also make task_executor connect explicitly (v2)
2015-05-12 11:30:08 -05:00
James Cammarata
3697d6582f
Connection plugins no longer auto-connect (v2)
...
Also fixed a bug in ssh.py where an attribute was being inappropriately
initialized in the _connect() method instead of __init__()
2015-05-12 11:23:40 -05:00
Brian Coca
09605706d9
relly fix it this time
2015-05-12 12:26:20 -04:00
Brian Coca
12a800c0e7
fixed less opts issue
2015-05-12 12:24:32 -04:00
Brian Coca
8fdf9ae59b
moved module_doc_fragments to v2
2015-05-12 12:18:55 -04:00
Toshio Kuratomi
6918a588c6
Update the extras module ref
2015-05-12 08:44:24 -07:00
James Cammarata
75b2082529
Submodule update
2015-05-12 10:33:19 -05:00
Toshio Kuratomi
490cde3cbd
Add python2.6+ as a documented requirement for rackspace modules
2015-05-11 12:25:03 -07:00
James Cammarata
fd321355d6
Adding 'role_path' to VariableManager "magic" variables (v2)
2015-05-11 14:04:17 -05:00
James Cammarata
7b1c6fbab9
Fix playbook includes so tags are obeyed (v2)
2015-05-11 12:48:03 -05:00
Toshio Kuratomi
c80c5c980d
Add python2.6 dep to aws and cloudstack doc fragments
2015-05-11 10:10:58 -07:00
James Cammarata
daf533c80e
V2 fixes
...
* PluginLoader class will now be more selective about loading some
plugin classes, if a required base class is specified (used to avoid
loading v1 plugins that have changed significantly in their apis)
* Added ability for the connection info class to read values from a
given hosts variables, to support "magic" variables
* Added some more magic variables to the VariableManager output
* Fixed a bug in the ActionBase class, where the module configuration
code was not correctly handling unicode
2015-05-11 11:29:48 -05:00
Toshio Kuratomi
f141ec9671
Update v2 module refs
2015-05-11 09:28:19 -07:00
Toshio Kuratomi
ebb4695da8
Update the submodule pointers
2015-05-11 09:09:00 -07:00
Monty Taylor
cd14d73be8
Add defaults and a link to os-client-config docs
2015-05-11 08:10:37 -04:00
Monty Taylor
d2782f0d84
Remove unneeded required_one_of for openstack
...
We're being too strict - there is a third possibility, which is that a
user will have defined the OS_* environment variables and expect them to
pass through.
2015-05-11 08:06:21 -04:00
Brian Coca
d1977dad23
started implementing syntax check
2015-05-08 19:19:03 -04:00
Toshio Kuratomi
7f21f270d9
Be more lenient in instance check: MutableMapping is more general than dict
2015-05-08 13:18:19 -07:00
Toshio Kuratomi
3a87b2727d
Fix format strings for python2.6
2015-05-08 13:11:04 -07:00
Brian Coca
a6683ba2b8
Merge pull request #10958 from resmo/fix/cloudstack_variable_typo
...
cloudstack: fix typo in variable, fixes get_domain()
2015-05-08 14:31:49 -04:00