Abhijeet Kasurde
d1eb4fe58c
VMware: Refactor vmware_target_canonical_facts ( #36964 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-03-04 10:20:47 +05:30
Abhijeet Kasurde
3a161fa157
VMware: new module : vmware_datastore_maintenancemode ( #36436 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-03-02 23:35:53 +05:30
Ganesh Nalawade
83c3561ee5
Enable eapi integration test for eos modules ( #36934 )
2018-03-02 12:39:00 +05:30
Matt Martz
ca092b5c26
Skip top level args that are the same as args in provider in doc<->arg_spec comparisons ( #36911 )
2018-03-01 10:47:20 -06:00
Ganesh Nalawade
5c2a1a6124
Fix eos_vrf integration test failures ( #36893 )
2018-03-01 13:05:39 +05:30
Trishna Guha
2fbfce06e7
Fix nxos_interface multiple issues ( #36827 )
...
* fix interface_type
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix setting mtu, doc for state check param, doc for params applicable for ethernet intf
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* speed idempotence and add unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fabric_forwarding_anycast_gateway applicable for svi type intf only
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix speed
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-01 10:56:16 +05:30
Abhijeet Kasurde
0694aca2a0
VMware: refactor configure disk logic ( #36617 )
...
This fix corrects logic related to disk parameters.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-03-01 09:36:54 +05:30
Pilou
274a4b0688
gitlab_project: don't ignore errors ( #36702 )
...
* gitlab_project: check that errors are reported
* gitlab_project: report encountered errors
Fix #36495
2018-02-28 23:22:47 +01:00
Gaurav Rastogi
60e39b9718
Updated the documentation of modules to match argspec including the type setting for bool parameters ( #36821 )
2018-02-28 14:38:03 +00:00
Claes Nästén
042c111563
nso_config break cycles in dependency sorting ( #36828 )
...
False assumption that values can not have cyclic dependencies. Fix by
removing dependency on self and look for cycles, if found remove
dependency to get a partial sort done.
2018-02-28 11:16:49 +00:00
Matt Clay
dc71c2197f
More code-smell sanity test updates. ( #36830 )
...
* Add test for missing Azure requirements.
* Improve readability.
* Enhance no-unicode-literals code-smell test.
2018-02-28 00:50:00 -08:00
Ed Costello
645952c139
Add aws_caller_facts module and use it in setup-iam.yml ( #36683 )
...
* Add aws_caller_facts module and use it in setup-iam.yml
This removes the dependency on having the command line AWS tools
installed.
2018-02-28 16:30:34 +10:00
saichint
db43fe6a76
nxos_facts fix and integration tests ( #36796 )
...
* fix nxos_facts ipv6 error
* time_range not supported for N35
2018-02-28 10:45:50 +05:30
Abhijeet Kasurde
8d49bb6eee
VMware: new module: vmware_host_capability_facts ( #36497 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-28 09:54:52 +05:30
Matt Clay
ac1698099d
Overhaul additional sanity tests. ( #36803 )
...
* Remove unnecessary sys.exit calls.
* Add files filtering for code-smell tests.
* Enhance test-constraints code-smell test.
* Simplify compile sanity test.
* Pass paths to importer on stdin.
* Pass paths to yamllinter on stdin.
* Add work-around for unicode path filtering.
* Enhance configure-remoting-ps1 code-smell test.
* Enhance integration-aliases code-smell test.
* Enhance azure-requirements code-smell test.
* Enhance no-illegal-filenames code-smell test.
2018-02-27 15:05:39 -08:00
Claes Nästén
e75989ec88
nso_config work around ordering issues ( #36774 )
...
Include dependencies when sorting entries to avoid issues with certain
versions of NSO.
2018-02-27 15:22:57 +00:00
Matt Clay
60a24bbdaa
Pass code-smell paths on stdin.
2018-02-27 00:36:16 -08:00
Abhijeet Kasurde
87d6bdaf98
VMware: Re-enable VM poweroff testcases ( #36734 )
...
This testcases were failing due to vcsim version.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-27 09:04:42 +05:30
nwsparks
e15a903bdf
Win lineinfile fix ( #35100 )
...
* win_lineinfile: fix #33858 . Removed conversion from \r\n
* win_lineinfile: added test for #33858
* win_lineinfile: added documentation and more tests for change
* win_lineinfile: fixed wrong hash in testing
2018-02-26 19:34:44 -05:00
Matt Clay
009f536d4e
Update default docker container SHA.
...
ci_complete
2018-02-26 13:23:22 -08:00
David Newswanger
6bd715a17d
skip fmg_script unit test if the pyFMG script is not present ( #36732 )
...
* skip fmg_script unit test if the pyFMG script is not present
* appease the sanity test gods
2018-02-26 12:01:14 -05:00
Claes Nästén
2789cc5c09
NSO ValueBuilder improvements. 4.5 leaf-list compatability. ( #36583 )
...
Fix issues in ValueBuilder used in nso_config and nso_verify so that it
can handle leaf-list in NSO 4.5 and detect identityref types from
unions.
Fail gracefully if a type is not found.
2018-02-26 13:18:20 +00:00
Mário Santos
8b52006d5c
Fix sanity checks in OpenStack docs fragment ( #36722 )
...
* Fix sanity checks in OpenStack docs fragment
Signed-off-by: Mário Santos <mario.rf.santos@gmail.com>
2018-02-26 13:05:53 +00:00
Peter Sprygada
93b795baf0
allows ib_spec attrs to be filtered in update ( #36673 )
...
* allows ib_spec attrs to be filtered in update
This change will allow the ib_spec entries to be be filtered on a change
object by setting the update keyword to false. The default value for
update is true. When the update keyword is set to false, the keyed
entry will be removed from the update object before it is sent to the
api endpoint.
fixes #36563
* fix up pep8 issues
2018-02-26 07:55:26 -05:00
René Moser
cdb2969703
cs_sshkeypair: fix ssh key rename ( #36726 )
...
* tests: cs_sshkeypair: add reproducer for failed key rename
* cs_sshkeypair: fix rename ssh key
2018-02-26 13:43:40 +01:00
Martin Krizek
54e9096950
Add integration test for #36534 ( #36581 )
2018-02-26 09:49:25 +01:00
Abhijeet Kasurde
d94a1ef4cc
VMware: refactor vmware_datastore_facts ( #36423 )
...
This fix adds datastore cluster details about datastore in returning
facts. Updated documentation and tests.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-26 13:23:22 +05:30
Trishna Guha
44332bda78
fix nxos_vlan aggregate ( #36710 )
...
* fix nxos_vlan aggregate
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-26 12:29:49 +05:30
Ganesh Nalawade
5a6b893240
Decouple config and state check in vlan and vrf network modules ( #36386 )
...
* Decouple config and state check in {network_os }_vlan and { network_os }_vrf modules
Fixes #35567
Fixes #34754
`interfaces` option is used for configuration as well as operational state
check. If interface is configured to given vlan or vrf but if
operational state of interface is disabled it results in module failure.
Fix is to decouple same option usage for config and state.
With this fix `interfaces` is used as config option and a new
option named `associated_interfaces` will be used for intent check
for assigned interfaces.
* Fix CI failures
* Fix review comment
* Fixed integration test failure
2018-02-26 09:23:54 +05:30
Matt Clay
f283edcb19
Temporarily disable subversion test on osx.
2018-02-24 13:46:40 -08:00
Ed Costello
2a0c7c4331
Fix documentation of validate_certificates option in aws doc_fragment.
...
Unignore sanity test failures for AWS modules caused by this common
fragment.
2018-02-23 13:21:44 -08:00
Chris Houseknecht
53cfd70b7d
Adds k8s_raw, openshift_raw tests ( #36228 )
2018-02-23 10:13:09 -05:00
Pilou
07927f52ae
filesystem: fix documentation ( #36556 )
2018-02-23 10:59:38 +00:00
Matt Martz
a7062b7587
Start of tests for modify_module, specifically to ensure proper shebang replacement on old style modules ( #36602 )
2018-02-22 16:27:53 -06:00
Matt Clay
5b5cba5e50
Update more code-smell tests. ( #36570 )
...
* Enhance use-compat-six code-smell test.
* Enhance use-argspec-type-path code-smell test.
* Enhance replace-urlopen code-smell test.
* Enhance boilerplate code-smell test.
* Enhance no-underscore-variable code-smell test.
2018-02-22 08:08:29 -08:00
Matt Clay
891f4f3b2d
Upgrade more code-smell tests. ( #36560 )
...
* Enhance no-dict-* code-smell tests.
* Enhance no-basestring code-smell test.
* Enhance no-get-exception code-smell test.
* Enhance empty-init code-smell test.
* Enhance required-and-default-attribute test.
* Remove unused code-smell test.
2018-02-21 20:09:13 -08:00
Jordan Borean
ef4f8851dc
win_feature: better error handling to make it easier to debug issues ( #36491 )
...
* win_feature: better error handling to make it easier to debug issues
* removed ignroed pslint rules that are no longer needed
2018-02-22 11:33:48 +10:00
Dag Wieers
430088c6f0
aci_interface_policy_leaf_policy_group: Fix test ( #36551 )
2018-02-21 23:48:10 +01:00
Sam Doran
723daf3e3a
Check for regexp match when using insertbefore or insertafter ( #36474 )
...
Add tests to cover this scenario
Fixes #36156
2018-02-21 17:03:38 -05:00
Bruno
afdd748f4c
changed cisco mail to normail hotmail ( #36546 )
2018-02-21 23:01:26 +01:00
Bruno
53125d37d1
add aci_static_binding_to_epg integration tests ( #36542 )
2018-02-21 21:45:38 +01:00
Dag Wieers
51ba115dea
aci_domain_to_encap_pool: Remove integration tests ( #36535 )
2018-02-21 20:33:23 +01:00
Toshio Kuratomi
03a6d72633
Revert "remove query/q ( #36315 )"
...
This reverts commit b47d2e07e1
.
query is a feature for 2.5. We're not reverting it now.
2018-02-21 10:37:51 -08:00
Dag Wieers
7435e115e0
ACI: Various changes to module documentation and guide ( #36516 )
...
* ACI: Various changes to module documentation and guide
This PR includes:
- We moved the object class information to the notes
- Add version information to guide chapters
- Add generic note to modules with reference to ACI guide
- Reference known issues in aci_rest documentation
- Remove module_utils function docs from modules
- Indicate which parameters are not required for querying all objects
- Added missing RETURN information
* Fix copyright strings
* Remove aci_domain_to_encap_pool.py for v2.5
* More updates
* PEP8 fix
* Improve listings of parameters/return values
2018-02-21 19:35:59 +01:00
Brian Coca
b47d2e07e1
remove query/q ( #36315 )
...
* remove query/q
remove and fixed tests for removed func
* paren fix
2018-02-21 10:42:54 -05:00
John R Barker
5d0ed38e3a
Fixup VMware module docs issues ( #36409 )
...
Fix various argspec vs documentation issue
2018-02-21 15:20:42 +00:00
Martin Krizek
9fced4f0a9
Add integration test for #36430 ( #36432 )
2018-02-21 16:16:02 +01:00
Sloane Hertel
f7d79d4789
[cloud] Retry WAF actions on WAFStaleDataException ( #36405 )
...
Add a util to run functions with AWSRetry to retry on WAFStaleDataExceptions and update ChangeToken for each attempt
2018-02-21 08:14:17 -05:00
mikedlr
52f2057472
aws ssm parameter lookup - change to return Nones for missing variables ( #36456 )
...
* aws ssm parameter lookup - change to return Nones for missing variables
* aws ssm parameter lookup - fix error case message to dump response
* aws ssm parameter lookup - fix integration test cases
2018-02-21 06:50:00 -05:00
Jordan Borean
df8a5d7a4f
fetch: set fail_on_missing: True as default as per docs ( #36469 )
...
* fetch: set fail_on_missing: True as default as per docs
* Updated docs for fetch to say behaviour was changed in 2.5 and updated tests
2018-02-21 18:10:23 +10:00