Peter Sprygada
0cef38cf02
adds feature to all modules to be run locally ( #18763 )
...
* adds new error AnsibleModuleExit to handle module returns
* adds new action plugin network for attaching connection to network modules
* adds new shared module local to receive connection
* splits out function to update task_args with common updates
This commit provides a mechansim for running local modules that require
a connection object for interative commands tyically implemented for
network devices. It provides a way to locally import modules (post fork)
and run them using exception handling to exit.
2016-12-15 15:47:29 -05:00
Fabio Alessandro Locati
066872cdc6
Improve examples ( #18830 )
2016-12-15 10:43:50 -08:00
Fabio Alessandro Locati
8dc3b60d0f
Remove unneeded quotes - windows/win_uri.py ( #18828 )
2016-12-15 10:38:02 -08:00
Fabio Alessandro Locati
cf5449c5d9
Remove unneeded quotes - windows/win_unzip.py ( #18827 )
2016-12-15 10:37:02 -08:00
Fabio Alessandro Locati
439f98005f
Highly rewrite and fix the examples - windows/win_iis_webbinding.py ( #18823 )
2016-12-15 10:34:20 -08:00
saller
d8c97ac275
Fix typo.
...
Fix typo in section "Installing multiple roles from a file".
2016-12-15 12:35:47 -05:00
Sam Doran
73fc4e42f1
Correct type-o on support statement
2016-12-15 11:32:55 -05:00
Artur Molchanov
a8d5358d7f
systemd module: Allow to stop activating service ( #19383 )
...
* systemd module: Allow to stop activating service
Allow to stop service with ActiveState=activating.
* systemd: Fix incompatibility with Python 2.4
2016-12-15 11:14:33 -05:00
Adrian Likins
d48ad47fda
add coverage/test and misc items to .gitignore ( #19384 )
2016-12-15 10:47:59 -05:00
John R Barker
7dc86648c4
Docs typo ( #19380 )
2016-12-15 13:32:28 +00:00
Matt Clay
39f6368015
Update aliases
file for uri
integration test.
2016-12-14 20:36:50 -08:00
Matt Clay
9b5c782a0b
Use docker pull
by default in ansible-test.
2016-12-14 20:11:43 -08:00
Matt Clay
80c559bdef
Test sftp and scp for ssh connection.
2016-12-14 17:34:03 -08:00
Ryan S. Brown
197658aff4
Handle when the AMI launch permissions are unset.
...
Use an empty list to avoid a TypeError because `'NoneType' is not iterable``
2016-12-14 19:45:14 -05:00
Michael Gugino
250f862573
Fix bug #5328 apache module loading ( #19355 )
...
* Fix bug #5328 apache module loading
Currently, the apache2_module module parses apache configs
for correctness when enabling or disabling apache2 modules.
This behavior introduced a conflict condition when transitioning
between mpm modules, such as mpm_worker and mpm_event.
This change accounts for the specific error condition raised
by ``apachectl -M``:
``AH00534: apache2: Configuration error: No MPM loaded.``
When loading or unloading a module with a name that contains 'mpm_',
apache2_module will ignore the error raised by apachectl if stderr
contains 'AH00534'.
Fixes #5328
* Add AH00534 warning
* Added changes from PR #5629
* Modified ignore_configcheck behavior
2016-12-14 13:18:19 -08:00
Toshio Kuratomi
0b440a9289
Code smell test for iteritems and itervalues ( #19292 )
...
* Code smell test for iteritems and itervalues
* Change the keydict object in authorized_keys so it doesn't throw a false postive
keydict is a bad data structure anyway. We don't use the iteritems and
itervalues methods so just disable them so that the code-smell tests do
not trigger on it.
* Change release templates so they work with py3
2016-12-14 12:16:16 -08:00
Brian Coca
f550b4541f
bad/missing fact plugin is a warning ( #19350 )
2016-12-14 14:25:19 -05:00
John R Barker
739a310382
Formatting ( #19353 )
2016-12-14 18:26:17 +00:00
Steve Kuznetsov
d5324c11a0
Factored polling std{out,err} reads into a function
...
The process to poll for data in the stdout and/or stderr pipes during a
low-level command execution was repetitive. Factoring this out into a
function DRYs out the code.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
2016-12-14 10:14:31 -08:00
Tim Rupp
362c86d323
Fixes map call usage
...
For the comparisions that need to be done, this map call needs
to convert to a list because the six import in ansible changes
the behavior of map to return an iterator instead of a list
2016-12-14 10:00:47 -08:00
Ondra Machacek
f84f97d035
cloud: ovirt: Add support to upload/copy/move disks ( #19337 )
2016-12-14 12:43:25 -05:00
Brian Coca
ed933421fe
correct template lookup path
...
now all paths get 'templates/'
2016-12-14 12:25:08 -05:00
Ryan Brown
60a1e719c8
Move GUIDELINES.md from modules repo ( #19313 )
2016-12-14 11:46:14 -05:00
Ondra Machacek
5400a06ac4
cloud: ovirt: Various fixes for oVirt modules ( #19141 )
...
* cloud: ovirt: fix various issues in ovirt modules
* cloud: ovirt: add support for nfs version
* cloud: ovirt: Fix facts documentation
* Add proper documentation fragmet
* Add proper argument_spec
* Fix return values
* cloud: ovirt: fix pep8
2016-12-14 11:42:15 -05:00
Robin Roth
afca957396
Fix UnboundLocalError remote_head in git ( #19057 )
...
* Fix UnboundLocalError remote_head in git
Fixes #5505
The use of remote_head was a leftover of #4562 .
remote_head is not necessary, since the repo is unchanged anyway and
after is set correctly.
Further changes:
* Set changed=True and msg once local_mods are detected and reset.
* Remove need_fetch that is always True (due to previous if) to improve
clarity
* Don't exit early for local_mods but run submodules update and
switch_version
* Add test for git with local modifications
2016-12-14 08:36:15 -08:00
Dag Wieers
8a25b2477c
Remove the hint to report module issue elsewhere.
2016-12-14 11:30:44 -05:00
Ondra Machacek
fa96438f4c
cloud: ovirt: Add support to list nested entities parameters ( #19300 )
2016-12-14 11:15:50 -05:00
Andrea Tartaglia
59227d8c31
Removed dict.iteritems() in several other files.
...
This is for py3 compatibility #18506
2016-12-14 08:01:45 -08:00
Dag Wieers
7c71c678fa
Fix regression in search path behaviour
...
This PR fixes a few issues:
- Missing role parent directory for relative paths
- Fix integration tests (add missing stage)
- Redesign integration tests
- Incorrect order with tasks-lookups
- Duplicate paths are listed
- Repetitive tasks/tasks or files/files were possible
==== using copy with test.txt
Before:
```
491 1481281038.29393: search_path:
/home/dag/home-made/ansible.testing/roles/test134/files/test.txt
/home/dag/home-made/ansible.testing/roles/test134/tasks/test.txt
/home/dag/home-made/ansible.testing/roles/test134/tasks/files/test.txt
/home/dag/home-made/ansible.testing/roles/test134/tasks/tasks/test.txt
/home/dag/home-made/ansible.testing/files/test.txt
/home/dag/home-made/ansible.testing/test.txt
```
After:
```
32505 1481280963.22418: search_path:
/home/dag/home-made/ansible.testing/roles/test134/files/test.txt
/home/dag/home-made/ansible.testing/roles/test134/test.txt
/home/dag/home-made/ansible.testing/roles/test134/tasks/files/test.txt
/home/dag/home-made/ansible.testing/roles/test134/tasks/test.txt
/home/dag/home-made/ansible.testing/files/test.txt
/home/dag/home-made/ansible.testing/test.txt
```
==== Using copy with files/test.txt
Before:
```
31523 1481280499.63052: search_path:
/home/dag/home-made/ansible.testing/roles/test134/files/test.txt
/home/dag/home-made/ansible.testing/roles/test134/tasks/files/test.txt
/home/dag/home-made/ansible.testing/roles/test134/tasks/files/test.txt
/home/dag/home-made/ansible.testing/roles/test134/tasks/tasks/files/test.txt
/home/dag/home-made/ansible.testing/files/files/test.txt
/home/dag/home-made/ansible.testing/files/test.txt
```
After:
```
31110 1481280299.38778: search_path:
/home/dag/home-made/ansible.testing/roles/test134/files/test.txt
/home/dag/home-made/ansible.testing/roles/test134/tasks/files/test.txt
/home/dag/home-made/ansible.testing/files/test.txt
```
==== Using template with files/test.txt.j2
Before:
```
30074 1481280064.15191: search_path:
/home/dag/home-made/ansible.testing/roles/test134/templates/files/test.txt.j2
/home/dag/home-made/ansible.testing/roles/test134/tasks/files/test.txt.j2
/home/dag/home-made/ansible.testing/roles/test134/tasks/templates/files/test.txt.j2
/home/dag/home-made/ansible.testing/roles/test134/tasks/tasks/files/test.txt.j2
/home/dag/home-made/ansible.testing/templates/files/test.txt.j2
/home/dag/home-made/ansible.testing/files/test.txt.j2
```
After:
```
29201 1481279823.52752: search_path:
/home/dag/home-made/ansible.testing/roles/test134/templates/files/test.txt.j2
/home/dag/home-made/ansible.testing/roles/test134/files/test.txt.j2
/home/dag/home-made/ansible.testing/roles/test134/tasks/templates/files/test.txt.j2
/home/dag/home-made/ansible.testing/roles/test134/tasks/files/test.txt.j2
/home/dag/home-made/ansible.testing/templates/files/test.txt.j2
/home/dag/home-made/ansible.testing/files/test.txt.j2
```
This fixes #19048
2016-12-14 10:33:14 -05:00
René Moser
18b7852940
cloudstack: utils: fail friendlier if no zones available ( #19332 )
2016-12-14 11:37:26 +01:00
Matt Clay
f28b5a0ed8
Add --tox-sitepackages option to ansible-test.
2016-12-13 16:57:23 -08:00
Toshio Kuratomi
dd46cb7b05
Add a code-smell test for iterkeys ( #18589 )
...
* Add a code-smell test for iterkeys
* Add a message on how to port iterkeys problems and make the grep more robust
2016-12-13 16:39:03 -08:00
Matt Clay
f789a20f29
Update log download url.
2016-12-13 16:26:10 -08:00
Matt Clay
45772b961f
Add private fork CI support to ansible-test.
2016-12-13 15:49:57 -08:00
Toshio Kuratomi
c6b42028c4
Fixes for uri under python3 and local (non-httptester) testing
2016-12-13 15:46:07 -08:00
Simon Li
de714e5af8
Use volume
as input parameter name to match image
.
2016-12-13 23:25:21 +00:00
Simon Li
9bfa2963b6
Add version_added 2.3 as suggested by shippable
2016-12-13 23:25:20 +00:00
Simon Li
178811d174
Return an error if volume_src wasn't found
2016-12-13 23:25:20 +00:00
Simon Li
e861195773
Add volume_src to os_volume
...
Depending on the OpenStack installation it may be quicker to create a volume from an existing volume (copy-on-write) compared to from a snapshot (allocating a completely new volume).
This adds a new `volume_src` parameter to the `os_module` which accepts a volume id or name.
2016-12-13 23:25:19 +00:00
Matt Clay
dab2bf7e13
Skip test_uri on python 3.
2016-12-13 13:51:57 -08:00
Ken Evensen
6b62b9f48c
Adding pamd module for Ansible ( #19029 )
2016-12-13 15:34:44 -05:00
Adrian Likins
c693ba19f9
unit tests for playbook/conditional.py ( #18586 )
...
Start of unit tests for playbook/conditional.py
2016-12-13 14:38:16 -05:00
Adrian Likins
3efef40822
Add unit tests for playbook/helpers.py ( #18709 )
2016-12-13 14:36:04 -05:00
Adrian Likins
1653a77f1d
add unit tests for playbook/included_file.py ( #18710 )
2016-12-13 14:35:27 -05:00
Adrian Likins
08a5d506bb
Fix errors on 'ansible-playbook --flush-cache' ( #18754 )
...
Add a unit test, and split out the flush cache logic to
it's own method.
Fixes #18708
2016-12-13 14:35:15 -05:00
Adrian Likins
6c4f554f5a
Provide slightly better msg on fact cache error ( #18759 )
...
If the configured fact_cache plugin (fact_caching config)
fails, raise a fatal error instead of failing mysteriously
later.
Fixes #18751
2016-12-13 14:34:58 -05:00
Adrian Likins
2979488b08
Allow sphinx to use multiple cpus w -j support ( #18900 )
...
'CPUS=6 make webdocs' for example
2016-12-13 14:34:21 -05:00
Carlos E. Garcia
0b8011436d
minor spelling changes
2016-12-13 13:51:13 -05:00
Michael Scherer
054a3fccf8
Cleanup import for sysctl module
2016-12-13 13:26:54 -05:00
Michael Scherer
f9460f3c80
Use type='path' instead of 'str' for deploy_helper
2016-12-13 13:25:45 -05:00