Mike Mars
a406ec30df
corrected the string formatting (format isn't in 2.4 and even in some later versions of python 2.x requires an index). Tested for both compile ***& runtime exceptions*** against 2.4, 2.6, and 3.5.
2016-12-08 11:24:35 -05:00
Toshio Kuratomi
79d12db02f
Fix the six import
2016-12-08 11:24:35 -05:00
Toshio Kuratomi
8ba0af5df3
Be sure to import urllib.parse from somewhere
2016-12-08 11:24:35 -05:00
chouseknecht
fc486824b8
Fix issue #3866
2016-12-08 11:24:35 -05:00
Mike Mars
097f57d327
Missed umask octal conversion.
2016-12-08 11:24:35 -05:00
Mike Mars
f592e92177
Corrected string of text...
2016-12-08 11:24:35 -05:00
Mike Mars
7af767f435
1) Modified error handling to work with Python 2.4. 2) Fixed octal codes to fall in line with the ansible guide, "Porting Modules to Python 3" 3) updated the requirements. All changes have been verified against Python 2.4, 2.6, & 3.5.
2016-12-08 11:24:35 -05:00
nitzmahone
570defc6d8
correct gs_storage docs to match reality
2016-12-08 11:24:35 -05:00
Mike Mars
b30f6e02f6
Fixing compile time errors irt exception handling for Python 3. This particular diff fixes problems with Exception handling and the use/misues IRT Python 3 of octal numbers (InvalidToken exceptions).
2016-12-08 11:24:35 -05:00
Elena Washington
cf31b4d8b5
Add support for PostgreSQL 9.5 in rds_param_group (fix for #3846 )
2016-12-08 11:24:35 -05:00
Gilles Gagniard
bbfea348df
better error message if libcloud is not recent enough to use gce subnetworks
2016-12-08 11:24:34 -05:00
Jonathan A. Sternberg
97917121a6
Paginate the results from boto.iam
...
The default pagination is every 100 items with a maximum of 1000 from
Amazon. This properly uses the marker returned by Amazon to concatenate
the various pages from the results.
This fixes #2440 .
2016-12-08 11:24:34 -05:00
Gilles Gagniard
152a713fd3
fix documentation to reflect subnetwork option is new in ansible 2.2
2016-12-08 11:24:34 -05:00
Gilles Gagniard
3404c0891b
Initial support for specifying in which subnetwork a gce instance should be created. This is required for non-legacy networks.
2016-12-08 11:24:34 -05:00
pic
8494b0af4b
fix #3528 : dns type
2016-12-08 11:24:34 -05:00
Michael Pappas
585003c546
Prevent ec2group from deleting sgs during check_mode runs
2016-12-08 11:24:34 -05:00
@
7e4b1ebff5
Fixing Rackspace compile time errors irt exception handling for Python 3 ( #3849 )
2016-12-08 11:24:34 -05:00
@
7960e99310
Fixing open stack compile time errors irt exception handling for Python 3 ( #3848 )
2016-12-08 11:24:34 -05:00
@
13bebda244
Fixing gce compile time errors irt exception handling for Python 3 ( #3845 )
2016-12-08 11:24:34 -05:00
chouseknecht
950931144f
Fix 3857 name regex
2016-12-08 11:24:34 -05:00
chouseknecht
9549c66a56
Fix #147 automatically expose published ports
2016-12-08 11:24:34 -05:00
chouseknecht
17fc0f11db
Remove unused method in ContainerManager
2016-12-08 11:24:34 -05:00
@
c3aab8ddcf
Fixing compile time error exception handling for python 3. ( #3843 )
2016-12-08 11:24:34 -05:00
Mike Mars
e2dbd0f445
Fixing Docker compile time errors irt exception handling for Python 3
2016-12-08 11:24:34 -05:00
@
3fa745eef9
Fixing error exception handling for python3. Does not need to be compa… ( #3840 )
...
* Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above.
* Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above.
* Fixing compile time errors IRT error exception handling for Python 3.5.
This does not need to be compatible with Python2.4 b/c Boto is Python 2.6 and above.
2016-12-08 11:24:34 -05:00
@
1573066ec1
Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above. ( #3839 )
2016-12-08 11:24:33 -05:00
chouseknecht
ec9f56d8e0
Fix #3822 stop container
2016-12-08 11:24:33 -05:00
chouseknecht
c9e4955d38
Remove registery option per #3824 .
2016-12-08 11:24:33 -05:00
chouseknecht
be2d32f04d
Fix upate typo and expected volume compare.
2016-12-08 11:24:33 -05:00
René Moser
b7265d7b28
apt: fix deb=file with --diff does not show diff on upgrades ( #3826 )
2016-12-08 11:24:33 -05:00
René Moser
a85d9930c5
apt: fix KeyError for deb=file ( #3816 )
...
Fix KeyError: 'prepared' while installing dependencies using deb=<file>.deb
This error shows up when --diff was not passed by and the deb files has dependencies not yet installed.
Closes #3752 .
2016-12-08 11:24:33 -05:00
Brian Coca
73bc9fd0e0
Revert "Add prefixing and suffixing fuctionality to assemble"
...
This reverts commit 4c386dba565109d971e88be961abe93d700939b3.
keeping in sync with main repo revert
2016-12-08 11:24:33 -05:00
Brian Coca
cffe358260
fixed enabled state
2016-12-08 11:24:33 -05:00
Brian Coca
df1b03d0c6
fixed reported state
2016-12-08 11:24:33 -05:00
chouseknecht
9dd95efe76
Fixed binds and volumes. Now recognizes bound vs unbound as well as named volumes.
2016-12-08 11:24:33 -05:00
chouseknecht
abbddbde49
Fix missing ansible_facts.
2016-12-08 11:24:33 -05:00
Matthias Frey
d5fc44610b
Fixed error in assemble module when validation failed. ( #3814 )
...
Error was: TypeError: fail_json() takes exactly 1 argument (2 given)
2016-12-08 11:24:33 -05:00
Jirayut 'Dear' Nimsaeng
d373e0a7c4
Fix volume to support not binding volumes to host
2016-12-08 11:24:33 -05:00
Anton Simernia
1aa1b617f5
Update gc_storage.py ( #3802 )
2016-12-08 11:24:33 -05:00
chouseknecht
96192ead02
Remove debug/register from examples.
2016-12-08 11:24:33 -05:00
chouseknecht
3d0d14c5ff
Fix network comparison. Fix handling of links. Updated doc strings. Added more examples.
2016-12-08 11:24:33 -05:00
chouseknecht
a4bd558240
Set version added to 2.2 so that tests pass
2016-12-08 11:24:32 -05:00
chouseknecht
e398efb04f
For new options move vesion_added to 2.1.1
2016-12-08 11:24:32 -05:00
chouseknecht
c8f63e867a
Fixed bug in _get_network_id
2016-12-08 11:24:32 -05:00
chouseknecht
a9ddb5023d
Fix doc strings.
2016-12-08 11:24:32 -05:00
chouseknecht
1d327a23cd
Fixed issues post testing.
2016-12-08 11:24:32 -05:00
chouseknecht
39bfb136a7
First pass at implementing networks parameter. Also added purge_networks option to remove container from networks not included in networks param.
2016-12-08 11:24:32 -05:00
chouseknecht
f3c33ee35f
Fix for 3768 - adding support for env_file
2016-12-08 11:24:32 -05:00
Jan Fader
3afbe28b8a
fix for #3706 ( #3778 )
2016-12-08 11:24:32 -05:00
chouseknecht
2016911e64
Check self.parameters.env exists.
2016-12-08 11:24:32 -05:00
chouseknecht
bc665fca9c
Fix for issue #3775 - env config comparison
2016-12-08 11:24:32 -05:00
chouseknecht
65e71d8960
Update restart_policy doc strings.
2016-12-08 11:24:32 -05:00
chouseknecht
b5666c0f1c
Fix restart_poicy
2016-12-08 11:24:32 -05:00
chouseknecht
8f9ef1213d
Fix for #3783 - command returns not found or does not exist.
2016-12-08 11:24:32 -05:00
Dan Schmidt
c8ec843ac2
Fix "ansbile_facts" typo in docker_container module
2016-12-08 11:24:32 -05:00
Erik Nadel
6f5dfcf1bd
Added statement about escaping characters in chron tasks ( #3770 )
2016-12-08 11:24:32 -05:00
David Fischer
adec050165
Add MariaDB to valid RDS engines ( #3337 )
...
* Add MariaDB to valid RDS engines
* Update RDS module documentation
2016-12-08 11:24:32 -05:00
Gabriele
1977b42956
Fixing bug, added missing param ( #3737 )
2016-12-08 11:24:31 -05:00
Dmitry Marakasov
13d7a61160
Fix crontab argument order for writing ( #3750 )
...
Currently, when writing user's crontab, ansible calls
crontab <file> -u <user>
This is incorrect according to crontab(1) on both FreeBSD and Linux,
which suggest that file argument should be the last.
At least on FreeBSD, this leads to incorrect cron module bahavior which
writes to root's crontab instead of users's
2016-12-08 11:24:31 -05:00
Ghe Rivero
3ae6583510
Make add ip_floating_ip idempotent
...
Closes issue #1858
2016-12-08 11:24:31 -05:00
Dag Wieers
f7fcb81dd9
Add unpack results to error output, for debugging purposes on failure
...
This may help understand what is going on with #3631
2016-12-08 11:24:31 -05:00
Toshio Kuratomi
286a46e8b4
Python2.4's zipfile library cannot handle zip 64bit extensions which are needed for > 64K files ( #3754 )
...
Fallback to unzip if zipfile fails and hope that unzip can deal with it
(sites have an easier time upgrading the unzip utility than all of
python).
https://bugs.python.org/issue3997
Fixes #3560
2016-12-08 11:24:31 -05:00
Wolfgang Powisch
20d9c0c484
Update junos_facts.py ( #3759 )
2016-12-08 11:24:31 -05:00
Brian Coca
01819bbc9d
fixed enabled reporting
2016-12-08 11:24:31 -05:00
Brian Coca
38d71b9eef
fixed typo
2016-12-08 11:24:31 -05:00
Brian Coca
472d5c11ef
added state in results for backwards compat
2016-12-08 11:24:31 -05:00
chouseknecht
0c5eac4243
Fix missing key error when updating existing virtual network.
2016-12-08 11:24:31 -05:00
Roberto Bampi
375884464e
Add an example for SRV record in route53 ( #3749 )
2016-12-08 11:24:31 -05:00
Brian Coca
8085678dc8
first draft systemd service plugin ( #3660 )
...
* first draft systemd service plugin
* now systemd status handles multiline values
2016-12-08 11:24:31 -05:00
chouseknecht
d0da544aef
Fix for issue 3740. Make docker_service more resilient when targeting older API versions.
2016-12-08 11:24:31 -05:00
Brian Coca
f6690828af
deprecated docker ( #3710 )
...
* deprecated docker
* updated formatting
2016-12-08 11:24:31 -05:00
Alvaro Aleman
2f2f80ad4c
Fix can_update test in os_subnet ( #3664 )
2016-12-08 11:24:31 -05:00
René Moser
5fc7bc45ac
Add no_gateway_ip option to os_subnet module ( #3736 )
...
no_gateway_ip option can provide subnet that is not having a gateway.
fixes #1880
2016-12-08 11:24:31 -05:00
james-prior
68b9c2ffa7
Make explicit that virtualenv is created if needed for pip module. ( #3731 )
...
packaging/language/pip.py:
virtualenv option:
Mention that virtualenv is created if it does not exist.
(Explicit is better than implicit.)
Mention other relevant options.
notes:
initialized -> created
Wrap long lines.
2016-12-08 11:24:31 -05:00
Doug Luce
9167abdd10
Fix S3 unavailable region error
...
This is to address this error:
fatal: [site]: FAILED! => {"changed": false, "failed": true, "msg": "Failed to connect to S3: Region does not seem to be available for awsmodule boto.s3. If the region definitely exists, you may need to upgrade boto or extend with endpoints_path"}
Commit 0dd58e9 changed the logic so an exception is thrown (by
`connect_to_aws`) before the `s3 is None` check is performed. This
changes the `None` check to a catch so the old logic can compensate.
2016-12-08 11:24:30 -05:00
Marcos Diez
d34c5dfd69
Added one extra example in the authorized_key module. ( #3637 )
2016-12-08 11:24:30 -05:00
Marcos Diez
366d52cf18
The documentation of lineinfile now makes reference to blockinfile ( #3639 )
2016-12-08 11:24:30 -05:00
Ken Mitchell
8c2b333a73
Proposed fix to not require src and fstype arguments for mount. Issue #1259 . ( #1357 )
2016-12-08 11:24:30 -05:00
Michael Scherer
d519fca04b
Port vsphere_guest to py3/py2.4 syntax ( #3721 )
2016-12-08 11:24:30 -05:00
Michael Scherer
fefc0cdd50
Fix wait_for to compile on python3 ( #3722 )
2016-12-08 11:24:30 -05:00
Michael Scherer
82df6f981e
Improve error reporting when git binary fail ( #3266 )
...
Showing stderr or stdout is a great help to understand
when something go south.
2016-12-08 11:24:30 -05:00
Michael Scherer
b8175f70ce
Convert packaging/* to py3/py2.4 syntax ( #3702 )
2016-12-08 11:24:30 -05:00
Kenny Woodson
cd09aab9b4
Unindenting the delete to user ( #3147 )
2016-12-08 11:24:30 -05:00
Ryan Brown
962a446238
Allow users to pick AWS Aurora as an RDS engine ( #3414 )
...
Per the [RDS docs](http://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateDBInstance.html ),
add `aurora` as a valid DB engine.
2016-12-08 11:24:30 -05:00
Nathan Brown
c053fa5378
Do not expect the elb to have policies or instances. Fixes #3593 ( #3595 )
2016-12-08 11:24:30 -05:00
kwerey
963cb64337
Add option to make RDS param groups for the MySQL 5.7 engine family. ( #3695 )
2016-12-08 11:24:30 -05:00
Lloyd Hazlett
20e86d1062
Add path type to argument_spec where applicable ( #3040 )
2016-12-08 11:24:30 -05:00
Matt Martz
a2d94c85e9
2 Module fixes ( #3611 )
...
* Fix syntax error in azure_rm_virtualmachine.py
* Allow rhn_register to fail gracefully when rhn-client-tools is not installed
2016-12-08 11:24:30 -05:00
jctanner
c952753735
Do not ignore the primary group if modifying the list of secondary groups. ( #3585 )
...
Fixes #1118
2016-12-08 11:24:30 -05:00
Toshio Kuratomi
7d9fb08e1a
Py3 exclude list ( #3698 )
...
* Fix a few modules to pass syntax checks under python3
* Move from a whitelist of modules to check for python3 compat to a blacklist
2016-12-08 11:24:29 -05:00
Cheuk Lam
a2ff7fc7ea
Added support for accepting extra config options in vm reconfiguration. ( #3327 )
2016-12-08 11:24:29 -05:00
chouseknecht
afc8c42e57
Fixed the URL in description. It's now valid Yaml.
2016-12-08 11:24:29 -05:00
chouseknecht
f14d675d2a
Remove the U().
2016-12-08 11:24:29 -05:00
chouseknecht
176363052f
Uppercase
2016-12-08 11:24:29 -05:00
chouseknecht
2b4ee0c19d
Make the new bits a NOTE
2016-12-08 11:24:29 -05:00
chouseknecht
4ac31f1e8d
Where to get the full docker picture.
2016-12-08 11:24:29 -05:00
Michael Scherer
c0217e14a7
Convert the network subfolder to py3/py2.4 syntax ( #3690 )
2016-12-08 11:24:29 -05:00
Michael Scherer
09066f1518
Convert all databases modules to python3 and 2.4 syntax ( #3688 )
2016-12-08 11:24:29 -05:00
Michael Scherer
f7b29ba8fd
Convert the whole files/ directory to py3 syntax ( #3685 )
2016-12-08 11:24:29 -05:00
Mike Bryant
0027158b74
junos_template: Simplify arguments. Fixes #3621
...
Simplify the arguments to junos_template, such that
merge/overwrite/replace can be selected easily.
2016-12-08 11:24:29 -05:00
Kei Nohguchi
d738ad0ee0
ops_template.py: Change integer key into stirng
...
This fix passing the update variable to the str()
so that it avoids the exception when ops.dc.read()
returns a dictionary which contains non-string keys.
This is due to the fact that some of the key types in
OpenSwitch schema are actually defined as integer
and ops.dc declerative config module encode those
in integer inside the dictionary. This could be
the right encoding from the schema point of view
but someone needs to convert it to the string
somewhere, as JSON key should be string.
2016-12-08 11:24:29 -05:00
Kaz Cheng
ff1c591c3e
Allow create_iam_role to return an additional value of role_result and ( #2418 )
...
instance_profile_result, in addition to the existing role list and change value
2016-12-08 11:24:29 -05:00
Shubham
8a6237955d
remove module argument, fix #3682 ( #3683 )
2016-12-08 11:24:29 -05:00
Michael Scherer
cca89ef489
Port seboolean to py3/py2.4 syntax ( #3679 )
2016-12-08 11:24:29 -05:00
Michael Scherer
c793571bc3
Port mount to python3 and python 2.4 compatible syntax ( #3678 )
2016-12-08 11:24:29 -05:00
Michael Scherer
fd61e81764
Port authorized_keys to a syntax compatible with python3 and 2.4 ( #3677 )
2016-12-08 11:24:28 -05:00
Michael Scherer
907b3fb667
Port hostname to a py24 and py3 compatible syntax ( #3676 )
2016-12-08 11:24:28 -05:00
Michael Scherer
e02f401225
Port sysctl to a py3 and py24 compatible syntax ( #3675 )
2016-12-08 11:24:28 -05:00
Michael Scherer
f0fd1109dd
Port cron to a py3 and py24 compatible syntax ( #3674 )
2016-12-08 11:24:28 -05:00
Michael Scherer
f2212dc41a
Port user module to python3 and 2.4 compatible syntax ( #3673 )
2016-12-08 11:24:28 -05:00
Michael Scherer
31126034b0
Port htpasswd to python3 compatible syntax ( #3672 )
2016-12-08 11:24:28 -05:00
Michael Scherer
73a33c02a9
Do not use a tuple as argument for _create_connection ( #3655 )
2016-12-08 11:24:28 -05:00
Michael Scherer
abfc8d36a8
Add a test on jnpr.junos.utils.sw presence ( #3666 )
2016-12-08 11:24:28 -05:00
jhawkesworth
2042d948db
fix formatting to avoid smart quotes, which breaks ability to copy and paste the jinja2 header from the web docs ( #3671 )
2016-12-08 11:24:28 -05:00
Michael Scherer
f423554e20
Testing the module on freebsd fail, since module is not assigned yet
2016-12-08 11:24:28 -05:00
Michael Scherer
98c729bfd7
Fix the argument for acl module ( #3653 )
2016-12-08 11:24:28 -05:00
Matt Martz
190f24f30e
Revert "Fix doc strings spacing."
...
This reverts commit 127d518011224289f7917fd3b2ec8ddf73c7dd17.
2016-12-08 11:24:28 -05:00
chouseknecht
26392077c0
Fix doc strings spacing.
2016-12-08 11:24:28 -05:00
chouseknecht
8e6d00f28e
Fix doc strings. Missing requirements and doc fragment reference.
2016-12-08 11:24:28 -05:00
Michael Scherer
b788f45b49
Use the proper type for 'dest' argument
2016-12-08 11:24:28 -05:00
Toshio Kuratomi
291e00d43a
Docs fixes
2016-12-08 11:24:28 -05:00
Dag Wieers
c650f06b03
Fix small typo ( #3642 )
2016-12-08 11:24:28 -05:00
chouseknecht
d5b82d67b8
Fail gracefully when build path is not found.
2016-12-08 11:24:27 -05:00
Brian Coca
ca7defeee5
made note about slurp memory consumption
2016-12-08 11:24:27 -05:00
chouseknecht
9a021b4181
Fixed files/project_files naming. Correct name is files.
2016-12-08 11:24:27 -05:00
chouseknecht
5837f744e0
Flip version added back to 2.2 to make tests pass.
2016-12-08 11:24:27 -05:00
chouseknecht
018c2f8f73
Moving version added to 2.1
2016-12-08 11:24:27 -05:00
chouseknecht
e8d49261e3
Added actions to RETURN docs. Show actions when debug or check mode.
2016-12-08 11:24:27 -05:00
chouseknecht
2860f57551
Removed use of --diff. Replaced 'diff' in output with 'actions'. Only show 'actions' in output if debug true.
2016-12-08 11:24:27 -05:00
chouseknecht
be24f83a41
Removed fail method. Combined recreate and force_recreate params.
2016-12-08 11:24:27 -05:00
chouseknecht
50ef604713
Adding docker_service
2016-12-08 11:24:27 -05:00
Toshio Kuratomi
93fe022aa4
Port to dual python2/python3 compat
2016-12-08 11:24:27 -05:00
Toshio Kuratomi
e10b7e1773
Port ping to dual python3/2 compat.
2016-12-08 11:24:27 -05:00
Chris Houseknecht
8ba5cc4392
Fixed parameters passing in container_create method. ( #3618 )
2016-12-08 11:24:27 -05:00
Johannes Meixner
af634ff5c7
network/*/*_config.py: Correct typo.
...
- Replace syntanx with syntax in all things network.
2016-12-08 11:24:27 -05:00
Scott Butler
e606a1237b
Fixed typos
2016-12-08 11:24:27 -05:00
René Moser
326f7166c0
apt: fix always changed when using deb file on Debian 8 ( #3541 )
...
Extends d74e82a3f1e3293ffb70c172e5bb2b6e1ff6dbcc with also support
downgrade.
2016-12-08 11:24:26 -05:00
James Tanner
bc39f8c42e
Revert "remove checking of stderr for insserv ( #1846 )"
...
This reverts commit 2ee6e4cf668a9bba77c3bb019d473f3614563838.
2016-12-08 11:24:26 -05:00
Veaceslav Mindru
8c6af73218
add vlidate_certs option for unarchive module ( #2635 )
2016-12-08 11:24:26 -05:00
TheSameCH
ca8bf6ab4c
remove checking of stderr for insserv ( #1846 )
...
stderr of insserv can also contain warnings which can be ignored. checking rc only is more accurate.
fixes #1502
2016-12-08 11:24:26 -05:00
Brian Coca
985abd2020
switched to return facts
2016-12-08 11:24:26 -05:00
Brian Coca
c03e1bd2d5
fixed documentation and arg issues
2016-12-08 11:24:26 -05:00
Rene Moser
9f1cfe07bb
mysql_user: fix unresolved reference
...
L282, module is used but not passed into function. Replaced check_mode reference and used module instead since check_mode is also in module.
2016-12-08 11:24:26 -05:00
Rene Moser
6a7682c7ea
mysql_variables: fix inconsistent params, fixes ubuntu 16.04 support
...
In the mysql_user module, login_host is defined as "localhost". Setting this to localhost also fixes Ubuntu 16.04 support.
To make it more consistent in the future, the params in all mysql modules should move to module utils. I'll take care.
Also fixed a few other things along.
2016-12-08 11:24:26 -05:00
hyperized
82cefd7ce1
Added restart functionality to ec2.py
2016-12-08 11:24:26 -05:00
n0trax
2c3caa33f7
Add checkmode and reduce code duplication ( #2417 )
...
- httpd removed from control_binaries
- check for enabled module after running a2enmod/a2dismod
- fail, if user has no permissions to run control_binary
- reduce code duplication
2016-12-08 11:24:26 -05:00
Toshio Kuratomi
ed932a53cd
Fix documentation
2016-12-08 11:24:26 -05:00
John R Barker
d13046a905
ansible-validate-modules part 4: Enable check on ansible-modules-core ( #3526 )
...
* Call ansible-validate-modules
* Correct quotes + add newline
2016-12-08 11:24:26 -05:00
Toshio Kuratomi
fa00c69ff2
bytearray isn't available in python2.4 ( #3583 )
...
* Detection of handler depends on the wrong handler failing to list the contents of the tarfile.
Use explicit compression types with the python tarfile library to
achieve that.
* bytearray isn't available in python2.4
2016-12-08 11:24:26 -05:00
Toshio Kuratomi
cd26cc8a0d
Detection of handler depends on the wrong handler failing to list the contents of the tarfile. ( #3584 )
...
Use explicit compression types with the python tarfile library to
achieve that.
2016-12-08 11:24:26 -05:00