ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity
3979 commits 10 branches 167 tags 272 MiB
Commit graph

1095 commits

Author SHA1 Message Date
Michael DeHaan
cbcc133cdd Merge pull request #1453 from sfromm/issue1211 
Use shutil.copyfile so as to preserve file ownership in authorized_keys
 2012-10-25 18:22:56 -07:00
Michael DeHaan
5b36e374d7 Merge pull request #1451 from dhozac/command-strip-newlines 
Only strip trailing newlines from output, preserving other space
 2012-10-25 18:21:16 -07:00
Michael DeHaan
06fa3e820d Merge pull request #1448 from jpmens/user_user1 
User is alias for name in 'user' module
 2012-10-25 18:18:56 -07:00
bleader
5a5751d1d0 user module: fix typo in documentation 
tyep -> type

Signed-off-by: bleader <bleader@ratonland.org>
 2012-10-25 20:56:13 +02:00
Stephen Fromm
a033ad4d74 Use shutil.copyfile so as to preserve file ownership in authorized_keys 2012-10-25 11:20:53 -07:00
Daniel Hokka Zakrisson
73cd3ef617 Only strip trailing newlines from output, preserving other space 2012-10-25 14:26:37 +02:00
Jan-Piet Mens
89f28a98dd User is alias for name in 'user' module 2012-10-25 14:03:13 +02:00
Michael DeHaan
895715b65b Merge pull request #1445 from sfromm/issue1439 
Skip check of primary group when checking other group membership
 2012-10-25 03:58:17 -07:00
Stephen Fromm
544dc76704 Create temp file in directory where ssh key lives 2012-10-24 20:50:11 -07:00
Stephen Fromm
b2e94e53fc Write keys file to temp location to avoid potential corruption 2012-10-24 20:47:45 -07:00
Stephen Fromm
e97916cfc1 Skip check of primary group when checking other group membership 2012-10-24 20:39:42 -07:00
Michael DeHaan
f2a7ca9a36 Merge pull request #1435 from stijnopheide/mysql-grant 
Mysql grant, take 2
 2012-10-24 18:18:13 -07:00
Michael DeHaan
3e491513a9 Merge pull request #1432 from skvidal/devel 
yum enablerepo/disablerepo option complete
 2012-10-24 17:13:29 -07:00
Dag Wieers
f4c4537327 Resolve traceback when python-selinux is not installed 2012-10-24 18:57:24 +02:00
Seth Vidal
0a153c6798 add comments that enablerepo/disablerepo are new in 0.9 2012-10-24 09:08:42 -04:00
Stijn Opheide
733693ffdc - removed space escapes from MySQL SHOW GRANTS regex 
- proper checking for with grant option (if this is not the only option the user has)
- added revoking of grant option
 2012-10-24 15:02:54 +02:00
Stijn Opheide
6b92b69fe6 added the GRANT privilege for a mysql user (WITH GRANT OPTION) 2012-10-24 15:02:54 +02:00
Jan-Piet Mens
82955606c4 fix DOCUMENTATION for user 2012-10-24 07:35:56 +02:00
Seth Vidal
d8337dab06 tested and verified yum enable/disablerepo option for yum module 2012-10-24 00:46:15 -04:00
Seth Vidal
d89d07550f first cut at yum module with enable/disable repo 2012-10-24 00:24:40 -04:00
Michael DeHaan
9626111d5b Merge pull request #1427 from bleader/devel 
mount: update example with mandatory option
 2012-10-23 21:02:46 -07:00
Stephen Fromm
5d8c130a7f Document ssh_key options are in version 0.9 2012-10-23 08:21:40 -07:00
bleader
e16e3fb4ca mount: update example with mandatory option 
- 'state' is required, but wasn't in example

Signed-off-by: bleader <bleader@ratonland.org>
 2012-10-23 15:49:47 +02:00
Jan-Piet Mens
feab57e270 Reformat code: examples consistently 
- added terse syntax to modules.rst
 - added description of special variables to template module
 2012-10-23 15:14:01 +02:00
Stephen Fromm
769bd9125a Help git module work when working in 'no branch' scenario 
Detect when on a 'no branch' branch.  If so, checkout the HEAD branch
as reported by 'git remote show <remote>'.  That should put the repo
back on a branch such that git can then merge changes as necessary.
In addition, removed hard-coded references to origin and replaced
with remote var.
 2012-10-22 16:03:35 -07:00
Michael DeHaan
cbc12f0dba Various performance streamlining and making the file features usable in all modules without daisy chaining. 2012-10-20 22:55:09 -04:00
Michael DeHaan
4104478abd Added 'script', a module that can push and insantly run a remote script. Replaces the need to copy+command. 
This is a bit of a rough draft, some error handling still needs to be added.
 2012-10-20 12:12:07 -04:00
Michael DeHaan
6b8448051f Merge pull request #1389 from sfromm/issue1214 
Add ability to create SSH key for user in user module
 2012-10-20 07:30:24 -07:00
Michael DeHaan
3c739b1a88 Merge pull request #1339 from inertialbit/add-basic-pg-role-attribute-support 
add role_attr_flags parameter to postgresql_user
 2012-10-20 07:29:26 -07:00
Stephen Fromm
87954f2110 Use os.path.join where appropriate 2012-10-19 22:22:27 -07:00
Stephen Fromm
63ba441163 Add ability to create SSH key for user in user module 
This allows one to create a SSH key for user.  You may define:
ssh_key_type, ssh_key_bits, ssh_key_file, ssh_key_comment,
and ssh_key_passphrase.  If no passphrase is provided, the
key will be passphrase-less.  This will not overwrite an existing key.
In the JSON returned, it will provide the ssh_fingerprint and
ssh_key_file.
 2012-10-19 22:00:31 -07:00
Michael DeHaan
68cf9a96fc Merge pull request #1388 from goozbach/selinux_bugs 
make policy only be required if state is not disabled
 2012-10-19 16:35:15 -07:00
Derek Carter
99180e7da3 make policy only be required if state is not disabled 2012-10-19 17:17:30 -04:00
Seth Vidal
326b160241 when a pkg is installed, but not from any repo, don't error out 
that it is not installed.

Also when a pkg is both installed and in a repo do not look it up
more than once
 2012-10-19 16:28:39 -04:00
Michael DeHaan
d58bc4da4e Merge pull request #1361 from lantins/devel 
Copy module can replace symlink with a real file.
 2012-10-18 16:59:45 -07:00
Michael DeHaan
05866bba1e Merge pull request #1372 from jpmens/rst_template1 
module_formatter: .rst now correctly handles code examples
 2012-10-18 16:58:08 -07:00
Jonathan Palley
702469f7bf symlink fix 2012-10-18 20:08:57 +08:00
Jan-Piet Mens
575459465e module_formatter: .rst now correctly handles code examples 
- fixed template (it was the template), adding indentation with Jinja2
 - added description of code examples to man-page template (was missing)
 - fixed fireball, cron, and debug module examples to confrom
 2012-10-18 13:49:19 +02:00
Luke Antins
0dbd3aa821 Add examples to user module documentation. 2012-10-18 02:55:58 +01:00
Luke Antins
4f17aa9fa0 Fix indent of fail module example to prevent unwanted <blockquote></pre></p> <br/></blockquote> from showing up in docsite output. 2012-10-18 02:09:11 +01:00
Luke Antins
7d41045b2f Erroneous space in facter documentation. 2012-10-18 01:20:40 +01:00
Luke Antins
6354898b09 Copy module can replace symlink with a real file. 2012-10-18 01:04:52 +01:00
Michael DeHaan
54257a6a4c Remove "the the" 2012-10-17 19:38:17 -04:00
Michael DeHaan
edb7a054ae Merge pull request #1349 from bcoca/fix_bsd_dmesg_jails 
fixed but in pulling data from dmesg command, wrong function to use as f...
 2012-10-16 16:15:36 -07:00
Brian Coca
620aeeb572 fixed but in pulling data from dmesg command, wrong function to use as file for for loop 
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
 2012-10-16 18:44:09 -04:00
Michael DeHaan
5bb8dcea08 Fix help text 2012-10-16 18:17:44 -04:00
Michael DeHaan
6f14e35c36 Merge pull request #1335 from phgrau/devel 
Use && for executing next command if, and only if, command1 returns an e...
 2012-10-16 15:16:46 -07:00
Michael DeHaan
7583704144 "force=" code under the file module is problematic, remove it 2012-10-16 18:14:42 -04:00
Jan-Piet Mens
e35d5188f9 typo 2012-10-16 14:40:35 +02:00
Jeremiah Heller
37bdefae74 add role_attr_flags parameter to postgresql_user 
Pass role_attr_flags a list of comma separated role
attributes when creating or updating a user.
 2012-10-15 16:03:10 -07:00
Philipp Grau
4290a904ff Add note: Debian Squeeze has no add-apt-repository 2012-10-15 17:20:23 +02:00
Maxim Burgerhout
2f6b9e69a7 Test for python-pip as well as pip 
On Red Hat, CentOS and Fedora systems, the pip binary will be called python-pip
instead of pip. This commit makes the pip module also check for python-pip.

The reason we check for python-pip *first*, is to have ansible fail on not
finding 'pip' and reporting *that*. This is consistent with current behaviour
and will not confuse users of Debian et al., where the 'python-pip' binary
never exists.

Tested on Fedora 18 and Ubuntu 12.04.
 2012-10-14 12:14:59 +02:00
Tim Bielawa
8831e59700 The pause 'prompt' parameter now requires quotes around the message. 2012-10-12 23:48:08 -04:00
Michael DeHaan
8dadf8a905 Use 'path' in file documentation, though src/dest work, it's less intuitive. 2012-10-12 22:08:07 -04:00
Michael DeHaan
2c90298841 Merge pull request #1314 from apenney/bugfix/git 
Check rc instead of parsing for errors.
 2012-10-12 18:18:04 -07:00
Michael DeHaan
c5d2f6b0d3 implement lookup plugins for arbitrary enumeration over arbitrary things. See the mailing list for some cool examples. 2012-10-12 20:07:05 -04:00
Michael DeHaan
29d49d415f fix mentioning of redundant aliases in module docs, remove was removed anyway 2012-10-12 18:14:09 -04:00
Michael DeHaan
621708e976 user module should be using module.BOOLEANS for choices 2012-10-12 18:06:36 -04:00
Michael DeHaan
aa98c84a62 HP and vsphere modules are crazy awesome but I am thinking these belong in contrib not core. 2012-10-12 17:49:48 -04:00
Brian Coca
6886683e16 small patch to fact gathering for when no dmesg.boot exists on freebsd, mainly happens in jails 
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
 2012-10-12 17:37:30 -04:00
Michael DeHaan
35163bce96 Merge pull request #1310 from dagwieers/hpilo_boot-cleanup 
hpilo_boot: Various clean ups in documentation and code
 2012-10-12 14:33:05 -07:00
Michael DeHaan
b1ccda00f8 Merge pull request #1311 from dagwieers/hpilo_facts-cleanup 
hpilo_facts: Various clean ups in documentation and code
 2012-10-12 14:32:46 -07:00
Michael DeHaan
1487b6a1bb Merge pull request #1313 from dagwieers/vsphere_facts-cleanup 
vsphere_facts: Various cleanups in documentation
 2012-10-12 14:32:31 -07:00
Michael DeHaan
a82522a5c4 Merge pull request #1317 from abondis/fix_mysql_db 
fix issue with mysql authentication and states not dump or import
 2012-10-12 14:26:45 -07:00
Michael DeHaan
20a7227056 Merge pull request #1318 from dsummersl/cron24 
fixed cron library so backups are python2.4 compatible
 2012-10-12 14:25:51 -07:00
Jeroen Hoekx
25e415c031 Add virt_boot module to define libvirt boot parameters. 2012-10-12 22:40:04 +02:00
Dane Summers
7399224428 fixed cron library so backups are python2.4 compatible 2012-10-12 16:34:34 -04:00
Aurélien Bondis
1f91a70310 fix issue with mysql authentication and states not dump or import 2012-10-12 16:26:59 -04:00
Ashley Penney
f4484f800b Further cleanup to add another rc check and remove a now redundent one. 2012-10-12 18:26:40 +00:00
Ashley Penney
6042419624 Check rc instead of parsing for errors. This now catches the case where the remote branch has been deleted and you're still trying to pull against it. 2012-10-12 18:16:37 +00:00
Dag Wieers
5927373c26 Various clean ups in documentation and code 
This commit improves the following items:
 - Remove the 'match' functionality, this can now be achieve by using the `fail` module together with `only_if` after running the `hpilo_facts` module. Since this gives more functionality, e.g. comparing server names, but also serial numbers or uuids with other inventory information, this is prefered. An example is added to show how this is achieved.
 - Clean up all C() calls in documentation
 - Added state=poweroff in order to power off a server. The use-case is here that in general we do not want to provision systems that are already running (this enforcement can be disabled using force=yes) but for test systems we should be able to power them off so we can start the normal provisioning process. (We could also force boot them, but that's less elegant)
 - The module now correctly indicates when something has changed. So if a server is powered off that was not off already, this is indicated, or when media boot-settings have been changed, this is also correctly indicated. Previously every call to hpilo_boot was (incorrectly) considered a change.
 2012-10-12 19:49:30 +02:00
Dag Wieers
5fe8205d36 vsphere_facts: Various cleanups in documentation 
This commit improves the following items:
 - Clean up all C() calls in documentation
 - Reindent the documentation
 2012-10-12 19:46:20 +02:00
Dag Wieers
5612cce4a4 hpilo_facts: Various clean ups in documentation and code 
This commit improves the following items:
 - Remove the 'match' functionality, this can now be achieve by using the `fail` module together with `only_if` after running the `hpilo_facts` module. Since this gives more functionality, e.g. comparing server names, but also serial numbers or uuids with other inventory information **and** a proper message, this is prefered. An example is added to show how this is achieved.
 - Clean up all C() calls in documentation
 - Remove trailing spaces in HP iLO's Serial Number output so that they can be compared to CMDB or other inventory information
 2012-10-12 19:38:59 +02:00
Michael DeHaan
dfaef8061a Merge pull request #1289 from abondis/mysql_migration 
mysql_db: connection test, dump/import state
 2012-10-11 17:39:13 -07:00
Dag Wieers
dfdf4ab8eb Damn you, colons... 2012-10-11 09:26:21 +02:00
Aurélien Bondis
1a51af0e38 mysql_db: use the database to test connexion, added dump and import state - requires target=path/to/a/file 2012-10-10 23:28:42 -04:00
Michael DeHaan
e74b9e1d34 Add .gitdir 2012-10-10 20:00:15 -04:00
Michael DeHaan
e593c828b4 Merge remote branch 'dagwieers/module-mail' into devel 2012-10-10 19:46:38 -04:00
Michael DeHaan
7788dea238 Merge pull request #1268 from dagwieers/hpilo-reboot-fix 
Workaround for when HP iLO is in a state it won't accept requests
 2012-10-10 05:34:22 -07:00
Michael DeHaan
f1dfddc5e5 Fix typo in autogenerated docs 2012-10-10 08:32:41 -04:00
Dag Wieers
2f74cd84bd Module mail to send out emails as an action 
Sending mails could be part of the workflow to have teams/responsibles perform specific task. Or simply to notify that a process has finished successfully (e.g. provisioning).
 2012-10-09 19:36:23 +02:00
Dag Wieers
790ed81b14 Workaround for when HP iLO is in a state it won't accept requests 
This workaround is recommended from HP iLO's documentation, but may not be sufficient in all cases. Time will tell.

I also made a few cosmetic changes with no impact.
 2012-10-09 19:31:31 +02:00
Michael DeHaan
06688efb24 Merge pull request #1263 from dagwieers/hpilo_facts-fix 
Sigh, another retypo
 2012-10-09 05:22:49 -07:00
Dag Wieers
98624cb394 Fixes to documentation 2012-10-09 12:42:10 +02:00
Dag Wieers
3f149e09bc Sigh, another retypo problem 2012-10-09 12:30:00 +02:00
Michael DeHaan
612561ad0e Merge pull request #1250 from dagwieers/hpilo_boot-fixes 
Various small fixes to boolean usage and defaults
 2012-10-08 14:27:20 -07:00
Michael DeHaan
62a56a219b Merge pull request #1243 from dsummersl/squash2-cron 
cron feature (w/o tests)
 2012-10-08 14:25:55 -07:00
Michael DeHaan
1b36446ab3 Merge pull request #1255 from dagwieers/module-namespace 
Add this module's namespace to the 'module_' namespace.
 2012-10-08 14:25:20 -07:00
Tim Bielawa
1e35ac7603 Fix typo in service module docs 2012-10-08 12:46:16 -04:00
Dane Summers
c3a6e8dfd6 added new documentation string to cron library 2012-10-08 11:10:40 -04:00
Dag Wieers
b39aed8736 Add this module's namespace to the 'module_' namespace. 
Much like we currently have *setup* register the variable `module_setup`, we would like other facts-modules register their own namespace. This means that:

 - *network_facts* registers `module_network`
 - *hpilo_facts* registers `module_hw`
 - *vsphere_facts* registers `module_hw`

In retrospect, it would have made more sense to have `setup` register `module_ansible` instead as the setup module uses the `ansible_` namesepace.

Having the `module_` namespace allows us to check whether a certain namespace has already been loaded so we can avoid running the facts module a second time using only_if.

```yaml
 - action: network_facts host=${ansible_hostname_short}
   only_if: is_unset('$module_network')
```
 2012-10-08 15:13:17 +02:00
Dag Wieers
5503cfaa44 Various small fixes to boolean usage, using module.params.get and default values 2012-10-08 15:07:02 +02:00
Michael DeHaan
c8854a23ea Merge pull request #1251 from dagwieers/hpilo_facts-fixes 
Fix typo/cosmetic change
 2012-10-07 16:58:05 -07:00
Dag Wieers
250f52bfba Add an alias 'name=' for guest 
This is the opposite as library/virt, but much better than using name= as the default option name.
 2012-10-07 22:23:22 +02:00
Dag Wieers
8c5a146013 Fix typo/cosmetic change 2012-10-07 22:12:00 +02:00
Michael DeHaan
c5d7ef3d7f Merge pull request #1249 from dagwieers/module-hpilo_boot 
Module hpilo_boot to boot from specific media using an HP iLO interface
 2012-10-07 06:12:42 -07:00
Dag Wieers
b58228a73b Module hpilo_boot to boot from specific media using an HP iLO interface 
This module allows to boot a system through HP iLO and can be used to start the provisioning process.
 2012-10-06 23:56:50 +02:00
Michael DeHaan
323cbdafb7 Merge pull request #1240 from jpmens/hpdoc 
fix examples in hpilo_facts DOCUMENTATION
 2012-10-06 13:39:31 -07:00
Dane Summers
3d65d6159f cron feature (w/o tests) 2012-10-05 21:35:37 -04:00
Michael DeHaan
a1c23af6fc Merge pull request #1239 from jpmens/shelldoc 
fix wording of shell documentation
 2012-10-05 06:11:31 -07:00
Jan-Piet Mens
91dc8bc136 fix examples in hpilo_facts DOCUMENTATION 2012-10-05 15:07:45 +02:00
Jan-Piet Mens
70907f574e fix wording of shell documentation 2012-10-05 14:59:49 +02:00
Dag Wieers
70b063ce0e Use the standard 'dest' option for target files, make 'name' an alias 2012-10-05 11:03:14 +02:00
Michael DeHaan
f470ebe6b7 Merge pull request #1213 from dagwieers/debug-module 
Module debug to assist users in understanding Ansible
 2012-10-04 16:28:25 -07:00
Michael DeHaan
a95bff0f5f Merge pull request #1230 from dagwieers/module-vsphere_facts 
Module vsphere_facts to add facts from a VMWare vSphere guest
 2012-10-04 16:18:39 -07:00
Michael DeHaan
5d7ab8a300 Merge pull request #1231 from dagwieers/fail-doc-fix 
This hopefully fixes the documentation for the fail module
 2012-10-04 16:18:10 -07:00
Dag Wieers
8c8552ac32 Module vsphere_facts to add facts from a VMWare vSphere guest 
This module gathers facts from a VMWare vSphere guest by querying vSphere. The facts include OS, network info (vlan, macaddress) and system info (cpu, memory, uuid) information. Useful information for provisioning and management.
 2012-10-04 21:55:16 +02:00
Dag Wieers
e07674d756 Module hpilo_facts to add facts from HP iLO interfaces 
This module gathers facts from the hardware interface by querying HP iLO. The facts include network info (vlan, macaddress) and system info (cpu, memory, uuid) information. Useful information for provisioning and management.

This module was previously named ilo_facts and mentioned in #1080, #1085, #1125 and #1217.
 2012-10-04 21:50:34 +02:00
Dag Wieers
3d5c4df2ac This hopefully fixes the documentation for the fail module 2012-10-04 20:58:07 +02:00
Dag Wieers
03af450bdc Module to assist users in understanding Ansible 
After helping someone on IRC he was interested to have this debug module in upstream. This module simply 'prints' a message, and can be ordered to fail if needed. It helps to troubleshoot or understand inventory/facts issues and/or experiment with statements and conditions using only_if.

Here is a small example playbook:

```yaml
- hosts: all
  tasks:
  - local_action: debug msg="System $inventory_hostname has uuid ${ansible_product_uuid}"
  - local_action: debug msg="System $inventory_hostname lacks a gateway" fail=yes
    only_if: "is_unset('$ansible_default_ipv4.gateway')"
  - local_action: debug msg="System $inventory_hostname has gateway ${ansible_default_ipv4.gateway}"
    only_if: "is_set('$ansible_default_ipv4.gateway')"
```

outputting:
```
[root@moria ansible]# ansible-playbook -v -l localhost:x220 test6.yml

PLAY [all] *********************

GATHERING FACTS *********************
ok: [localhost]
ok: [x220]

TASK: [debug msg="System $inventory_hostname has uuid $ansible_product_uuid"] *********************
ok: [localhost] => {"msg": "System localhost has uuid d125a48c-364f-4e65-b225-fed42ed61fac"}
ok: [x220] => {"msg": "System x220 has uuid d125a48c-364f-4e65-b225-fed42ed61fac"}

TASK: [debug msg="System $inventory_hostname lacks a gateway" fail=yes] *********************
failed: [localhost] => {"failed": true, "msg": "System localhost lacks a gateway", "rc": 1}
ok: [x220] => {"msg": "System x220 has gateway 192.168.1.1"}

PLAY RECAP *********************
localhost                      : ok=2    changed=0    unreachable=0    failed=1
x220                           : ok=3    changed=0    unreachable=0    failed=0

```

I had some other plans for the module, like displaying host inventory and complete inventory to help understand inventory and facts modules, but that would require an action-plugin for transfering inventory information etc... And I am not sure this is wanted/best done in a module.
 2012-10-04 09:50:18 +02:00
Michael DeHaan
e170d7304b Added documentation on file force parameter 2012-10-03 20:57:36 -04:00
Michael DeHaan
046c6c66f2 various small doc tweaks 2012-10-02 22:43:46 -04:00
Michael DeHaan
f67aa85c3f Fixing various module related things. 2012-10-02 22:32:17 -04:00
Michael DeHaan
85a31616de Call os.path.expanduser in the creates= and removes= section of the command module so ~/ and the like works. 2012-10-02 22:12:49 -04:00
Dag Wieers
1d27909ec0 Added a fail module in order to fail execution on certain conditions 
In some cases you may want to deliberately fail the execution of a playbook. In our provisioning workflow we want to have safeguards in place to avoid provisioning systems that are already in production. Since we reboot physical and virtual systems, it is mandatory we take all the precautions to prevent accidental provisioning.

So in our use-case we have the following at the very start of the provisioning playbook:

    ### Safeguard to protect production systems
    - local_action: fail msg="System is not ready to be staged according to CMDB"
      only_if: "'$cmdb_status' != 'to-be-staged'"

and we repeat the same task in the (separate included) play that takes care of (re)booting the system using our own boot-media, so that it cannot be accidentally separately run by someone.
 2012-10-02 21:40:28 +02:00
Petetin Ludovic
17423c9268 Fix issue https://github.com/ansible/ansible/issues/1194 2012-10-02 15:12:33 +02:00
Michael DeHaan
6616fba1ab Merge pull request #1189 from jpmens/nagpause 
standardize DOCUMENTATION for nagios, pause
 2012-10-02 05:15:56 -07:00
Jan-Piet Mens
a1f192976f attempt at DOCUMENTATION for async_status 2012-10-02 09:56:55 +02:00
Jan-Piet Mens
83029755f7 standardize DOCUMENTATION for nagios, pause 2012-10-02 09:15:11 +02:00
Michael DeHaan
f897f19fc5 Teach fireball mode to disable the fireball by paying attention to 'minutes=N' (default 30) and do not let fireball module crash 
on input.
 2012-10-01 22:41:00 -04:00
Michael DeHaan
2165351f2c Merge pull request #1185 from tbielawa/pause_docs 
Add DOCUMENTATION to pause task
 2012-10-01 19:09:24 -07:00
Tim Bielawa
ca87fa56d8 Add DOCUMENTATION to pause task 2012-10-01 12:42:03 -04:00
Tim Bielawa
f3d9f8da7b Add DOCUMENTATION to nagios module. 2012-10-01 12:26:57 -04:00
Michael DeHaan
886a17853f Merge pull request #1176 from jpmens/fireball-doc1 
fireball DOCUMENTATION
 2012-10-01 05:46:02 -07:00
Jan-Piet Mens
f2dc815e3f fireball DOCUMENTATION 
- amended
 2012-10-01 14:39:15 +02:00
Michael DeHaan
6600f7b7ac Merge pull request #1170 from jpmens/docspatch01 
Jumbo DOCUMENTATION patch
 2012-10-01 05:19:16 -07:00
Michael DeHaan
ac3ec0a410 Merge pull request #1173 from dhozac/command-quote-less 
Use a regexp to filter out arguments instead
 2012-10-01 05:17:29 -07:00
Jan-Piet Mens
a72a6e42c5 Added attribution to all module DOCUMENTATION strings 2012-10-01 12:37:51 +02:00
Daniel Hokka Zakrisson
6477bdc6fc Use a regexp to filter out arguments instead 
pipes.quote is a bit overzealous for what we want to do, quoting ;
and other characters that you most likely want to use in your shell
invocations. The regexp is the best I could come up with to be able
to only replace the parts of the arguments that shouldn't be
executed.
 2012-10-01 12:13:17 +02:00
Jan-Piet Mens
e620fed755 Jumbo DOCUMENTATION patch 2012-10-01 09:18:54 +02:00
Michael DeHaan
190e4c26d1 Merge pull request #1167 from jpmens/slurp01 
module docs for slurp
 2012-09-30 08:15:19 -07:00
Jan-Piet Mens
8b737c959d module docs for slurp 2012-09-30 16:58:15 +02:00
Michael DeHaan
a00d6d7234 Merge pull request #1166 from mavimo/documentation-seboolean 
Added DOCUMENTATION to seboolean module.
 2012-09-30 06:44:02 -07:00
Marco Vito Moscaritolo
f9bdf07387 Added DOCUMENTATION to seboolean module. 2012-09-30 15:41:00 +02:00
Michael DeHaan
f8060d109e Merge pull request #1165 from mavimo/documentation-selinux 
Added DOCUMENTATION to selinux module.
 2012-09-30 06:36:27 -07:00
Michael DeHaan
349af83c91 Merge pull request #1164 from jpmens/modformatter 
module_formatter now also uses Jinja2 trim_blocks
 2012-09-30 06:36:09 -07:00
Marco Vito Moscaritolo
7491054ed6 Added DOCUMENTATION to selinux module. 2012-09-30 15:34:26 +02:00
Jan-Piet Mens
e4338d0ca3 module_formatter now also uses Jinja2 trim_blocks 
- Updated man template accordingly
- seem to have left in illegal char in facter DOCUMENTATION...
 2012-09-30 15:06:18 +02:00
Jan-Piet Mens
8a4df98f69 template DOCUMENTATION added to fireball 2012-09-30 14:50:32 +02:00
Jan-Piet Mens
28698d5fcf Attribute author of virt correctly (sorry) 2012-09-30 14:08:47 +02:00
Michael DeHaan
b8a2a526fc Merge pull request #1156 from jpmens/m-docs5 
DOCUMENTATION for virt
 2012-09-30 04:59:24 -07:00
Michael DeHaan
39c4a4f8a7 Merge pull request #1155 from jpmens/m-docs4 
DOCUMENTATION for fetch,mount,ohai,easy_install; .rst template tweaks
 2012-09-30 04:57:50 -07:00
Michael DeHaan
bf6e783d7a Merge pull request #1152 from sfromm/moduledocs 
Add module documentation for git, group, service, and user
 2012-09-30 04:56:37 -07:00
Jan-Piet Mens
7a3b2ac287 DOCUMENTATION for virt 2012-09-30 12:40:11 +02:00
Jan-Piet Mens
754888d896 DOCUMENTATION for fetch,mount,ohai,easy_install 
- .rst now supresses default if none is set (looks better in HTML)
  - .rst now handles empty options list
  - Fixed postgresql_user and mysql_user because YAML contained colons
  - docs for facter
 2012-09-30 12:29:32 +02:00
Stephen Fromm
ed07940386 Add LSB facts, as derived from lsb_release -a 
This gathers LSB facts via lsb_release.  This complements the
platform facts collected via the platform module.  This reoprts
release, id, description, release, and codename.  It also adds
'major_release', which is the major version number of a distribution.
 2012-09-29 23:58:04 -07:00
Stephen Fromm
be19e21126 Add module documentation for git, group, service, and user 2012-09-29 23:50:25 -07:00
Michael DeHaan
13e8ef5f35 Merge pull request #1146 from dhozac/command-escape-args 
Properly parse escaped special arguments
 2012-09-29 16:25:37 -07:00
Michael DeHaan
e744e864d9 Merge pull request #1140 from mavimo/devel 
Refs #1116: DOCUMENTATION string update
 2012-09-29 13:26:42 -07:00
Michael DeHaan
78911f1b26 Merge pull request #1145 from mavimo/documentation-supervisorctl 
Added DOCUMENTATION to supervisorctl module.
 2012-09-29 13:23:54 -07:00
Michael DeHaan
4823371aff Merge pull request #1144 from mavimo/documentation-pip 
Added DOCUMENTATION to pip module.
 2012-09-29 13:23:41 -07:00
Daniel Hokka Zakrisson
9261d3962b Properly parse escaped special arguments 
Fixes issue #1134
 2012-09-29 21:05:49 +02:00
Marco Vito Moscaritolo
d80ec35183 Fixed error in author name 2012-09-29 21:04:17 +02:00
Marco Vito Moscaritolo
95d7b4c5db Added DOCUMENTATION to supervisorctl module. 2012-09-29 21:02:07 +02:00
Marco Vito Moscaritolo
ac5afcae28 Added DOCUMENTATION to pip module. 2012-09-29 20:53:28 +02:00
Marco Vito Moscaritolo
b1d88235f0 Added DOCUMENTATION to shell module. 2012-09-29 20:40:06 +02:00
Marco Vito Moscaritolo
e1c83b0367 Fixed error on official docs (reported on DOCUMENTATION string). Name param must be pkg and is required. 2012-09-29 18:23:13 +02:00
Marco Vito Moscaritolo
e30e9a74c2 Added DOCUMENTATION to postgresql_user module. 2012-09-29 16:46:30 +02:00
Marco Vito Moscaritolo
a4620920b2 Added DOCUMENTATION to postgresql_db module. 2012-09-29 16:46:13 +02:00
Marco Vito Moscaritolo
6184a0a313 Fixed doc string 2012-09-29 16:43:21 +02:00
Marco Vito Moscaritolo
0d0bc5e620 Added DOCUMENTATION to subversion module. 2012-09-29 16:28:55 +02:00
Marco Vito Moscaritolo
29ffed869c Added ping module author in docs. 2012-09-29 16:23:58 +02:00
Marco Vito Moscaritolo
2aaaf986d3 Added DOCUMENTATION to ping module. 2012-09-29 16:21:00 +02:00
Marco Vito Moscaritolo
a75348b406 Added DOCUMENTATION to musql_db module. 2012-09-29 16:15:52 +02:00
Marco Vito Moscaritolo
8898643c1d Added DOCUMENTATION to musql_user module. 2012-09-29 16:15:41 +02:00
Jan-Piet Mens
0604d580d9 Removed embedded colon in DOCUMENTATION of apt_repository: building manpages failed 2012-09-29 12:53:17 +02:00
Michael DeHaan
e108d1758c Merge pull request #1132 from jpmens/m-doc-inifile 
removed EXAMPLES from ini_file
 2012-09-28 17:59:30 -07:00
Jan-Piet Mens
1193810d46 module DOCUMANTATION for apt, apt_respository cleanup 2012-09-29 01:51:55 +02:00
Jan-Piet Mens
0649e637d3 removed EXAMPLES from ini_file 
testing YAML in YAML: small glitch in rst template; a </pre></p> is outdented and causes messy display
 2012-09-29 01:26:40 +02:00
Michael DeHaan
ce5dceab0e Merge pull request #1128 from mavimo/devel 
Added documentation to APT module
 2012-09-28 16:12:58 -07:00
Michael DeHaan
508e6ecf43 Merge pull request #1131 from jpmens/m-docs3 
Module DOCUMENTATION for template, wait_for, and yum
 2012-09-28 16:11:33 -07:00
Jan-Piet Mens
a040807fd0 Module DOCUMENTATION for template, wait_for, and yum 2012-09-29 00:49:02 +02:00
Marco Vito Moscaritolo
7b8bd280e8 Added documentation to APT_REPOSITORY module 2012-09-28 23:07:41 +02:00
Marco Vito Moscaritolo
c976238a81 Added documentation to APT module 2012-09-28 22:35:29 +02:00
Jan-Piet Mens
e0fb264a89 Module DOCUMENTATION: assemble, authorized_key, command, copy 
plus a small fix in rst.j2 template
  manpages generated & checked
  modules.html generated & checked
 2012-09-28 21:55:49 +02:00
Michael DeHaan
405c097c43 Various fixes for the module documentation auto-generator 2012-09-27 21:30:32 -04:00
Michael DeHaan
83f277cfe6 Various tweaking to get the module formatter to work for 'make docs' in the docs project. Likely the templates for other module formatting types will have to change 
by the time I'm done.
 2012-09-27 21:06:31 -04:00
Michael DeHaan
10bce54ef0 Merge pull request #1098 from jpmens/ini_file 
New module: manipulate INI-style settings
 2012-09-27 16:03:45 -07:00
Daniel Hokka Zakrisson
66d0acfde3 Remove assemble action plugin, fix daisychaining 2012-09-27 18:30:08 +02:00
Michael DeHaan
69612ba16d The very first start of 'fireball mode', which uses ansible in SSH mode to deploy a ephemeral zeromq daemon (entirely optional) that is will die after 
it is no longer used.  No key signing will be required.  At this point, development use only -- NOT complete.
 2012-09-26 23:51:59 -04:00
Jan-Piet Mens
c2daa77089 New module: manipulate INI-style settings 
split off examples from DOCUMENTATION into own array as per #1098
 2012-09-26 13:44:19 +02:00
Michael DeHaan
af8f11e3f7 Merge pull request #1096 from sfromm/issue1067 
Ignore failure of stop command if start succeeds with state=restarted
 2012-09-26 04:02:02 -07:00
Stephen Fromm
19c0202aaf Ignore failure of stop command if start succeeds with state=restarted 
In some cases (see issue #1067) with state=restarted, a failure to stop
the service (which wasn't running) would appear to the module to be a
failure to restart the service even though it successfully started the
service.  This changes the behavior of the service module to focus
on the return code of the start command.  If the rc of stop is not
0 and the rc of start does equal 0, it considers the service
successfully restarted.  It then ignores the rc, stdout, and stderr
from the unsuccessful stop command.
 2012-09-25 22:51:13 -07:00
Stephen Fromm
f52624f6d2 Give nice error message if destination directory doesn't exist (issue #1048) 2012-09-25 14:57:32 -07:00
Michael DeHaan
2f97afb634 Merge pull request #1071 from dhozac/git-expanduser 
User-expand the destination path of the git module
 2012-09-23 10:21:04 -07:00
Michael DeHaan
0b3e05d9a4 Merge pull request #1066 from jpmens/doc3_lineinfile 
Added DOCUMENTATION to lineinfile module
 2012-09-23 10:20:08 -07:00
Michael DeHaan
4e6d89b5b5 Merge pull request #1073 from dcoutu/devel 
Added cases for 'dead but subsys locked' status
 2012-09-23 10:19:19 -07:00
Dave Coutu
9bb83067bc Added cases for 'dead but subsys locked' status 2012-09-21 14:55:59 -04:00
Daniel Hokka Zakrisson
f6af88fe9f User-expand the destination path of the git module 2012-09-21 19:20:05 +02:00
Jan-Piet Mens
5a75433ce9 Added DOCUMENTATION to lineinfile module 2012-09-19 22:29:11 +02:00
Jan-Piet Mens
60e0410298 Tweak DOCUMENTATION YAML as per latest 991 2012-09-19 16:09:26 +02:00
Michael DeHaan
1bd9ea6440 Merge pull request #1062 from dagwieers/wait_for-fix 
Fix on older python versions, plus various improvements
 2012-09-19 06:36:56 -07:00
Dag Wieers
8912258016 Fix on older python versions, plus various improvements 
This change includes:

 - (on possibly older python versions ?) a string variable test using the 'is' operator fails (so it always return ok immediately after initial delay)
 - add a missing socket.settimeout() for the state=started case (if the machine does not exist, timeout defaults to 60 seconds)
 - add a connect_timeout option to customize the default connection timeout
 - use socket.shutdown(2) to close immediately
 - return the elapsed time
 2012-09-19 15:19:59 +02:00
Michael DeHaan
4cd3262f50 Merge pull request #1054 from jpmens/geturl_doc1 
First attempt at standardizing DOCUMENTATION string
 2012-09-19 06:09:39 -07:00
Aleksej Romanov
eefe66f1cc Squashed commit of the following: 
commit 80a26a8175b779b707bc08e9d28c451c30ee4ada
Merge: b25b9fd 61e9b27
Author: Michael DeHaan <michael.dehaan@gmail.com>
Date:   Tue Sep 18 21:01:47 2012 -0400

    Merge branch 'devel' of git://github.com/alopropoz/ansible into file-force

commit 61e9b27df25c36015c2b1b4a58155ccfdfb993a0
Merge: 3f6f329 16bf3e1
Author: Aleksej Romanov <alopropoz2@yandex.ru>
Date:   Thu Sep 13 20:48:02 2012 +0700

    Merge remote branch 'upstream/devel' into devel

commit 3f6f3291dffefa2a802def25a1e8bd38de0cba75
Author: Aleksej Romanov <alopropoz2@yandex.ru>
Date:   Thu Sep 13 20:41:31 2012 +0700

    'force' option for 'file' module.

commit 6223bba94160c60153448655803d084f7eaa5168
Author: Aleksej Romanov <alopropoz2@yandex.ru>
Date:   Thu Sep 13 20:40:19 2012 +0700

    changed = True when changing symlink referent, #1008. Needed for tests.
 2012-09-18 21:04:42 -04:00
Jan-Piet Mens
e041c2e2cd First attempt at standardizing DOCUMENTATION string (new DICT) 2012-09-18 14:04:43 +02:00
Michael DeHaan
d77be4eecf Merge pull request #1052 from romeotheriault/add-SunOSVirtual-facts 
Adding SunOSVirtual facts
 2012-09-17 17:27:43 -07:00
Romeo Theriault
d72eaa3fc5 Adding SunOSVirtual facts 2012-09-16 23:14:06 -10:00
Stephen Fromm
65fe7b7003 Update package manager fact innards to a list of dicts 2012-09-16 21:42:55 -07:00
Stephen Fromm
94eb11a6d7 Add pkg_mgr fact to setup 
This should help facilitate playbook decision making that are not
strictly distribution specific, but more package manager.
 2012-09-16 21:42:54 -07:00
Michael DeHaan
7df0e5259f Merge pull request #1038 from bcoca/atomic_copy2 
Atomic copy2
 2012-09-14 15:53:49 -07:00
Ali Asad Lotia
c0aac03b0c url_get module returns dest 
The url_get module now includes the destination in the returned JSON.
 2012-09-14 08:34:41 +01:00
Ali Asad Lotia
99746d4a83 Indicate thirsty argument required if dest is dir. 
The check for the destination being a directory is now done before
checking if the file exists, that way the user is informed that the
thirsty argument is required.
 2012-09-14 08:02:30 +01:00
Daniel Hokka Zakrisson
56b1a8ceed Invoke is_installed correctly from rpm path 2012-09-13 12:34:52 +02:00
Brian Coca
88d1285f33 time is what i wanted, not gmtime 
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
 2012-09-12 14:52:54 -04:00
Brian Coca
06b914c5b3 small fix to prevent temp file from living past its succesful usage 
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
 2012-09-12 14:47:06 -04:00
Brian Coca
f5481621f8 made copy atomic by creating tmp file in dest location (ensures same partition) 
uses pid and epoch to prevent collisions, good enough for most cases
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
 2012-09-12 14:42:51 -04:00
Michael DeHaan
565f336182 lineinfile should use 'search' everywhere 2012-09-08 14:53:34 -04:00
Michael DeHaan
14a9c3ab9e Line in file regexep should match a portion of the line, not the whole line! 2012-09-07 21:03:59 -04:00
Michael DeHaan
5b57011152 Merge pull request #1027 from mcodd/setup_bug_python24 
setup not python24 compatible in 0.7
 2012-09-08 05:24:09 -07:00
Michael DeHaan
335f136e71 Merge pull request #1023 from lorin/postgres-user-fix 
Fix postgresql_user bug
 2012-09-08 05:23:29 -07:00
Matt Coddington
c0638842d8 make this python24 compatible 2012-09-07 22:47:03 -04:00
Lorin Hochstein
b3b01bb7a3 Fix postgresql_user bug 
If I create a database from scratch and assign permissions by doing:

      - name: ensure database is created
        action: postgresql_db db=$dbname

      - name: ensure django user has access
        action: postgresql_user db=$dbname user=$dbuser priv=ALL password=$dbpassword

Then it fails with the error:

  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 565, in <module>
    main()
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 273, in main
    changed = grant_privileges(cursor, user, privs) or changed
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 174, in grant_privileges
    changed = grant_func(cursor, user, name, privilege)\
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 132, in grant_database_privilege
    prev_priv = get_database_privileges(cursor, user, db)
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 118, in get_database_privileges
    r = re.search('%s=(C?T?c?)/[a-z]+\,?' % user, datacl)
  File "/usr/lib/python2.7/re.py", line 142, in search
    return _compile(pattern, flags).search(string)
TypeError: expected string or buffer

This fix fixes the problem by not executing the regex if the
db query on pg_database returns None.
 2012-09-07 16:24:00 -04:00
Seth Vidal
9d88b3eedd add import sys to virt module b/c it needs it if the libvirt python 
module is missing
 2012-09-07 16:05:42 -04:00
Michael DeHaan
4280e00d56 Merge pull request #1000 from mavimo/patch-1 
Add support to removes control param
 2012-09-06 17:52:02 -07:00
Michael DeHaan
7ef3e7dccb Merge pull request #1003 from bladypirat/devel 
added support for custom port definition for postgresql_* modules
 2012-09-06 17:51:35 -07:00
Michael DeHaan
49bef3f6c2 Merge pull request #1005 from dagwieers/cmdline 
Add /proc/cmdline information to the default facts
 2012-09-06 17:51:19 -07:00
Jan-Piet Mens
b36aa61237 Add support for RSA/DSA SSH host key detection in setup module for OS/X 
s/<8spaces>/<4spaces>/g
 2012-09-06 20:40:21 +02:00
Dag Wieers
d158218c3f Add /proc/cmdline information to the default facts 
The use-case here is that based on information in the /proc/cmdline certain actions can be taken.

A practical example in our case is that we have a play at the end of the provisioning phase that reboots the system. Since we don't want to accidentally reboot a system (or restart the network) on a production machine, having a way to separate an Anaconda post-install (sshd in chroot) with a normal system is a good way to make that distinction.

    ---
    - name: reboot
      hosts: all
      tasks:
      - action: command init 6
        only_if: "not '${ansible_cmdline.BOOT_IMAGE}'.startswith('$')"

A practical problem here is the fact that we cannot simply check whether it is set or empty:

    ---
    - name: reboot
      hosts: all
      tasks:
      - action: command init 6
        only_if: "'${ansible_cmdline.BOOT_IMAGE}'"

If ansible_cmdline was a string, a simple only_if: "'${ansible_cmdline}'.find(' BOOT_IMAGE=')" was an option, but still not very "beautiful" :-/

This implementation uses shlex.split() and uses split(sep, maxsplit=1).
 2012-09-06 09:35:33 +02:00
Piotr Kweclich
8360f9f46c added support for custom port definition 2012-09-05 18:18:30 +02:00
Marco Vito Moscaritolo
2dd430d9c0 Add support to removes control param 
Execute action only if specified file using param removes exist (execute reverse control of creates).

Some usage eg.:

```yaml
- name: enable apache2 default websites
  action: command /usr/sbin/a2ensite $item
creates=/etc/apache2/sites-enabled/$item
  with_items:
    - default
    - default-ssl

- name: disable apache2 default websites
  action: command /usr/sbin/a2dissite $item
removes=/etc/apache2/sites-enabled/$item
  with_items:
    - default
    - default-ssl
```
 2012-09-05 14:06:47 +03:00
Michael DeHaan
eed031cd82 Check for ipv6 2012-09-04 21:22:47 -04:00
Michael DeHaan
aa704a6111 backuplocal => backup_local for API standardization reasons 2012-09-04 19:49:49 -04:00
Michael DeHaan
b97e2a6f5a Merge branch 'backup-common' of https://github.com/dhozac/ansible into devel 2012-09-04 19:45:39 -04:00
Michael DeHaan
c69c3d6e18 Merge pull request #995 from mattupstate/devel 
Use `get_bin_path` properly for supervisorctl module
 2012-09-04 16:44:22 -07:00
Daniel Hokka Zakrisson
a5d63532d3 Add backup to assemble 2012-09-04 16:04:53 +02:00
Daniel Hokka Zakrisson
2a8b92954f Add backups to lineinfile 2012-09-04 16:04:53 +02:00
Daniel Hokka Zakrisson
dfcb9d3c2d Move backup to module_common 2012-09-04 16:04:53 +02:00
willthames
8b8eae7d82 Allow ~ expansion in chdir argument of command module 
This allows the use of ~ in the chdir argument of the command module
I know the later change is absolutely necessary as the first change
was not sufficient. It may be that the first change fixes shell and
the second fixes command.
 2012-09-04 14:22:53 +10:00
willthames
d4c4a51866 Subversion dest should allow ~ expansion 
Used os.path.expanduser on dest to allow e.g. ~/svn/repo as
a destination
 2012-09-04 10:15:13 +10:00
Michael DeHaan
8f220a4f77 Always pipe stderr in the setup module to avoid JSON interference. 2012-09-02 12:34:28 -04:00
Matt Wright
d52f1d969b Use get_bin_path properly 2012-08-31 15:03:26 -04:00
Matt Wright
a092eadbbb Fix supervisorctl module after merge issue 2012-08-31 11:03:14 -04:00
Michael DeHaan
8e02b165f1 chmod +x 2012-08-30 19:43:14 -04:00
Michael DeHaan
b0ac7e07b0 Merge branch 'binpath' of https://github.com/sfromm/ansible into devel 
Conflicts:
	library/supervisorctl
 2012-08-30 19:24:09 -04:00
Michael DeHaan
a454db5345 Merge pull request #970 from mattupstate/devel 
Improve apt_repository and supervisorctl
 2012-08-30 16:21:47 -07:00
Michael DeHaan
90f051f818 Merge pull request #971 from sfromm/seboolean 
Add seboolean module
 2012-08-30 16:10:30 -07:00
Michael DeHaan
092bd8e3da make parameter required 2012-08-30 19:09:02 -04:00
Michael DeHaan
4da4c31dfb Merge pull request #974 from goozbach/add_selinux_module 
add selinux module
 2012-08-30 16:02:16 -07:00
Derek Carter
2aa760a3fc add selinux module 2012-08-30 15:29:59 -04:00
Stephen Fromm
6742e9c3f4 Add option required=(True|False) to get_bin_path and update modules 
Added required as optional argument to get_bin_path(). It defaults to
false.  Updated following modules to use required=True when calling
get_bin_path():  apt_repository, easy_install, group, pip,
supervisorctl, and user.
Also removed _find_supervisorctl() from supervisorctl module and updated
_is_running() to not need it.
 2012-08-30 11:01:37 -07:00
Matt Wright
b93df1fc60 Update handling of state changes 2012-08-30 12:37:02 -04:00
Matt Wright
bdfccbfb34 Move conditional that accounts for variances in distros/versions to work when removing and adding. 2012-08-30 12:35:37 -04:00
Stephen Fromm
97c2e58081 Add seboolean module 
Will manage values of seboolean on a host.  Options are name (name of
boolean), state (on or off), and persistent (on or off).  Persistent
defaults to no.
 2012-08-30 09:33:09 -07:00
Stephen Fromm
e5a635672c Migrate remaining modules to use get_bin_path in module_common.py 
* Migraed easy_install, pip, service, setup, and user.
* Updated fail_json message in apt_repository
* Fixed easy_install to not hardcode location of virtualenv in
  /usr/local/bin/.
* Made handling of virtualenv more consistent between easy_install and
  pip.
 2012-08-29 20:26:22 -07:00
Stephen Fromm
bdb39058ae Migrate apt_repository, group, and supervisorctl to use module.get_bin_path 2012-08-29 16:24:49 -07:00
Daniel Hokka Zakrisson
ed8e31d618 Add a lineinfile module 2012-08-30 00:07:58 +02:00
Michael DeHaan
d0994cd169 Merge branch 'setup-no-dash-facts' of https://github.com/tima/ansible into devel 
Conflicts:
	library/setup
 2012-08-28 20:29:40 -04:00
Matt Wright
a82928e7dc fix bug in supervisorctl module 2012-08-28 19:21:05 -04:00
Timothy Appnel
8c32aefc80 Replace - with _ in setup module key names to avoid variable access problems reported in #954 2012-08-28 19:02:19 -04:00
Michael DeHaan
f9e9753141 Remove obsolete comment 2012-08-28 07:29:32 -04:00
Michael DeHaan
d7eed66a06 Merge pull request #951 from gottwald/devel-git-sudo-fix 
Added cwd to tempdir in git clone method. Fixes usage with sudo.
 2012-08-28 04:28:46 -07:00
Ingo Gottwald
30fdd56560 Added cwd to tempdir in git clone method. Fixes usage with sudo. 2012-08-28 11:28:50 +02:00
Tim Bielawa
6b73907811 Change from a module config file to brute force locating the nagios configs so we can find the command file. 2012-08-28 02:16:07 -04:00
Tim Bielawa
98d3e2bfc8 Nagios is executable now 2012-08-27 20:01:06 -04:00
Tim Bielawa
8b8aaa7f76 Fix copying that special character 2012-08-27 11:55:38 -04:00
Tim Bielawa
da2665bcd2 In-line docs. 2012-08-27 11:39:52 -04:00
Tim Bielawa
9829033a8a Now reading from a config file actually works. 2012-08-27 11:30:13 -04:00
Tim Bielawa
62ffeb93a5 Services iterate correctly now 
Cleaned up return methods
 2012-08-27 11:08:16 -04:00
Tim Bielawa
5d41fffa00 Groundwork for nagios module. 2012-08-27 04:11:59 -04:00
Florian Diebold
886fed5ae7 Remove ternary operator to fix python 2.4 compatibility. 2012-08-26 00:16:58 +02:00
Florian Diebold
af17bab373 Support systemd in the service module. 
Most of it worked already, except for the enable parameter, because it
tried to use chkconfig which only sees SysV services. First look for
systemctl and use that if it exists.
 2012-08-25 22:26:34 +02:00
Michael DeHaan
4816644b22 Merge pull request #937 from jhoekx/wait-state 
Add a state parameter to the wait_for module.
 2012-08-24 16:46:41 -07:00
Michael DeHaan
165f4b514d Merge pull request #938 from skvidal/devel 
fix up local_nvra and fix for a missing localinstall rpm file.
 2012-08-24 16:46:06 -07:00
Maxim Burgerhout
3d44de284a Add working CPU model fact for some ARM devices 
Works on Sheevaplug, probably works on Rasberry Pi as well
 2012-08-24 23:11:06 +02:00
Jeroen Hoekx
81c9a0cb78 wait_for: remove restarted, add delay, rename name to host, make port required. 2012-08-24 20:58:05 +02:00
Jeroen Hoekx
18d5c875d0 Change wait_for return message to be machine readable. 2012-08-24 20:47:55 +02:00
Seth Vidal
5dbc85e8ad fix up local_nvra 2012-08-24 13:51:07 -04:00
Jeroen Hoekx
5ba34572d9 Add a state parameter to the wait_for module. 
This takes started, stopped and restarted.

Started returns when connecting is possible.
Stopped when connecting is not possible.
Restarted first waits for connecting to be impossible and returns when it is
possible again.
 2012-08-24 19:08:45 +02:00
Michael DeHaan
150a47c66c Merge pull request #922 from dsummersl/subversion 
Subversion
 2012-08-23 18:43:29 -07:00
Michael DeHaan
b3b607ff5e Merge pull request #931 from elventear/postgresql_db 
Allow change of ownership and checks for existing database
 2012-08-23 18:41:15 -07:00
Michael DeHaan
7341ed241e Merge pull request #924 from elventear/postgresql_user 
Change semantics of postgresql_user module
 2012-08-23 18:40:45 -07:00
Jeroen Hoekx
8660fb074a Add the wait_for module. 
This module waits until a specific port on a given host can be connected to.
 2012-08-23 19:41:26 +02:00
Dane Summers
71cff25254 added force option to git - made both subversion and git default to force=true for backward compatibility with git's previous behavior 2012-08-23 00:07:14 -04:00
Dane Summers
6dd6a4c534 tested library - fixed several test cases, added 'force' option, and removed grep requirement 2012-08-22 23:06:03 -04:00
Pepe Barbe
fdaf65282b bugfix in sql query 2012-08-22 13:34:24 -05:00
Pepe Barbe
fdbc99dc28 Check for database ownership 2012-08-22 12:20:51 -05:00
Pepe Barbe
6d473df324 Typo 2012-08-22 12:19:55 -05:00
Pepe Barbe
af5d67c496 Query for all active privileges instead 
Use a different method to query for current 
privileges at the table and database level. 
This method is more robust if newer privileges 
are added in future versions and also supports the 
ALL wildcard.
 2012-08-22 10:04:58 -05:00
Pepe Barbe
95169b75c4 Add fail_on_user option 
fail_on_user option can be used to ignore silently
if the user cannot be removed because of remaining
privilege dependencies to other objects in the 
database. By default it will fail, so that this new 
behavior won't surprise unsuspecting users.
 2012-08-22 10:04:58 -05:00
Pepe Barbe
4e833cf506 Initial commit of change of semantics for module 
The postgresql_user module has several drawbacks:
* No granularity for privileges
* PostgreSQL semantics force working on one
  database at time, at least for Tables. Which
  means that a single call can't remove all the 
  privileges for a user, and a user can't be
  removed until all the privileges are removed, 
  forcing a module failure with no way to 
  work around the issue.

Changes:
* Added the ability to specify granular privileges
  for database and tables within the database
* Report if user was removed, and add an option to 
  disable failing if user is not removed.
 2012-08-22 10:04:57 -05:00
Dane Summers
24c8c22e75 removed logger, removed superfluous mkdir 2012-08-21 16:10:17 -04:00
Dane Summers
157fa3868a added TODO for test scenarios to add 2012-08-21 13:59:39 -04:00
Dag Wieërs
9d4f70f0ad Handle special files just like normal files 
As discussed in #923
 2012-08-21 23:48:18 +02:00
Michael DeHaan
1ae018ce94 Adds a thirsty=yes|no to the get_url module, such that if downloading a large file from the internet you can decide 
whether to download it every time or not -- will replace only on change, or decide to not download.  The default
is thirsty=no which will not download every time by default.
 2012-08-20 18:39:37 -04:00
Tim Bielawa
3d3c8a004e Fix setup module explosion when a route is empty. Closes #909 2012-08-19 21:19:07 -04:00
Michael DeHaan
14c2e8de0c Fix invalid usage or fail_json in apt module 2012-08-18 19:43:45 -04:00
Michael DeHaan
798c35d83e Apt module should accept 'absent', and 'present' like the yum module does. 2012-08-18 18:38:10 -04:00
Michael DeHaan
8eda23f856 tweak service module pattern= logic so ./hacking/test-module does not give false positives 2012-08-17 20:26:22 -04:00
Michael DeHaan
bc571ccb55 Merge pull request #902 from sfromm/issue719 
Add pattern option to service module
 2012-08-17 17:17:32 -07:00
Michael DeHaan
2b51cf04c7 Merge pull request #901 from dhozac/setup-ip 
Work with tun and p2p interfaces
 2012-08-17 17:10:59 -07:00
Michael DeHaan
705057b9a6 Merge pull request #900 from lorin/pip-venv-bug 
Retrieve pip path after creating virtualenv
 2012-08-17 17:10:35 -07:00
Michael DeHaan
229ab1582a Merge pull request #898 from elventear/postgresql_user_py24 
Fixes for postgresql_user to make it work with postgresql defaults and under Python 2.4
 2012-08-17 17:09:35 -07:00
Stephen Fromm
18f0302de8 Add pattern option to service module 
Adds ability to check service status based on pattern.  The pattern
is a simple string.  If a pattern is provided, the output of ps is
checked first.
 2012-08-17 14:00:01 -07:00
Daniel Hokka Zakrisson
121341833a Work with tun and p2p interfaces 2012-08-17 22:08:04 +02:00
Lorin Hochstein
8223d3ee3f Retrieve pip path after creating virtualenv 
Retrieve the pip path after creating a non-existent virtualenv.
Prevents the problem of using the wrong pip if virtualenv doesn't
exist yet.
 2012-08-17 14:38:49 -04:00
Pepe Barbe
3dd2c0700f Syntax change to make module compatible with Python 2.4 2012-08-17 10:37:02 -05:00
Lorin Hochstein
8af3403f65 Return both stdout and stderr on pip failures. 
pip failure message sometimes (always?) go to standard out. Return
both standard out and standard error when there's a failure.
 2012-08-17 11:32:47 -04:00
Michael DeHaan
c93df29249 Make a more logical error when the command/shell module is used with no arguments. 2012-08-16 21:40:52 -04:00
Sundar Raman
3aff9396e8 (Re #882) Handle errors in get_interfaces 
If there is an error in how interfaces are configured (or only one set, like IPv6),
the setup command should not error out.
 2012-08-15 19:22:05 -04:00
Dane Summers
19686d549c support for subversion repositories 2012-08-15 09:04:17 -04:00
Jeremy Penner
09d5812cbb Make easy_install module actually work. 
mpdehaan requested in ansible/ansible#795 that globals be removed.
The response was to remove the lines with the word 'global', but not
the actual use of global variables.  Which makes the module break silently.
Updated to use local variables.
 2012-08-14 23:31:13 -04:00
Michael DeHaan
ded0c61750 meaningless whitespace changes 2012-08-14 19:33:11 -04:00
Michael DeHaan
de4b8dc53a Can use fail JSON here, remove debug statement 2012-08-14 19:29:09 -04:00
Michael DeHaan
58c975d621 Fix aliases, package not found is not an error 2012-08-14 19:27:02 -04:00
Michael DeHaan
07fd96acc9 Merge branch 'devel' of https://github.com/skvidal/ansible into devel 2012-08-14 19:20:09 -04:00
Michael DeHaan
731adc0eaf Merge pull request #866 from akhayyat/devel 
setup: add type and default_ipv{4,6} to linux network facts
 2012-08-14 16:19:14 -07:00
Michael DeHaan
a2a8cfe099 Merge pull request #876 from elventear/postgresql_fix 
Changes to postgresql to support defaults settings and older psycopg2
 2012-08-14 16:17:37 -07:00
Pepe Barbe
7dcd1bd223 Autocommit support for psycopg2 < 2.4.2 2012-08-14 17:12:09 -05:00
Pepe Barbe
95fc5dd4a8 Fix using postgres default values 
When initalizing a connection to psycopg2, in order to use the default
values, the keywords must be missing. So we use a dictionary as a kwarg
and include only the keywords that do not have an empty value on the
module parameters.
 2012-08-14 17:11:53 -05:00
Seth Vidal
3175eacfc4 fixes to yum module 
include local_nvra
change the remove behavior to pretty much NEVEr error out if the pkg is not there (or anywhere)
 2012-08-14 16:23:40 -04:00
Seth Vidal
14479e6adc cover all of the edge cases with and without yum-utils installed. 
it is possible those folks w/o yum-utils installed but with rhn-plugin
installed but w/o any rhn-certificates will still see an error msg.
they have 3 options:
1. remove rhn-plugin
2. enable some channels w/rhn certs
3. install yum-utils
 2012-08-14 13:23:49 -04:00
Seth Vidal
2e3926d13f subprocess is already imported in module_common - no need for it here 2012-08-14 13:23:49 -04:00
Daniel Hokka Zakrisson
ae964b97c4 Fix spelling of architecture for non-x86 2012-08-14 15:57:54 +02:00
Ahmad Khayyat
c96c51a534 setup: add type and default_ipv{4,6} to linux network facts 2012-08-14 01:37:14 -04:00
Michael DeHaan
7ab0d60b1a update config code 2012-08-13 20:17:07 -04:00
Michael DeHaan
3b259ef5f6 Merge pull request #859 from zecrazytux/bugfix/apt_repository 
Bugfix/apt repository
 2012-08-13 15:30:21 -07:00
Michael DeHaan
e29ee9db2b Merge pull request #860 from goozbach/broken_mount 
fixed missing module argument for mount module
 2012-08-13 15:29:43 -07:00
Pepe Barbe
bce1d4da53 Use Python 2.4 compatible syntax 2012-08-13 16:02:16 -05:00
Derek Carter
556593bb18 fixed missing module argument for mount module 2012-08-13 15:20:36 -04:00
Sebastien Bocahu
d95eddceb1 Quote the repository string when appending it to the command line in the apt_repository module. 2012-08-13 19:36:08 +02:00
Sebastien Bocahu
3e9bcd351d Add support for Debian in apt_repository 2012-08-13 19:23:53 +02:00
Sebastien Bocahu
df269c72c1 Fixed scoping issue in apt_repository module. 2012-08-13 19:06:53 +02:00
Stephen Fromm
c4ce5f9497 Try to find ip command in either /sbin or /usr/sbin 
If ip is not found in either /sbin or /usr/sbin, this will return
an empty result.  It seems extremely unlikely that a linux system will
not have iproute2 installed
 2012-08-11 23:54:22 -07:00
Stephen Fromm
84028c2339 Tweak invocation of ip in LinuxNetwork 
Specify full path to ip and add third argument 'show' to be explicit
about requested action.  This goes from 'ip addr' to
'/sbin/ip addr show'.
 2012-08-11 23:54:22 -07:00
Michael DeHaan
75bbd73173 Fix indentation 2012-08-11 18:39:09 -04:00
Michael DeHaan
67301c1015 rename variable 'pkg' in yum module such that the auto-handled error messages use the same key. 2012-08-11 18:16:10 -04:00
Michael DeHaan
1e4d45af1e Add module common code to allow it to be easier to indicate whether arguments are mutually exclusive, required in conjunction, or whether one of a list of arguments is required. This simplifies writing Python modules. 2012-08-11 18:13:29 -04:00
Michael DeHaan
e9c9d8f523 tweak config mode check to just have a default 2012-08-11 12:38:05 -04:00
Michael DeHaan
477ca2ed1a Make pep8 tests run against the library directory as well, and associated tweaks (mostly to indentation) in the library 
directory.
 2012-08-11 12:35:58 -04:00
Michael DeHaan
e0765be1ea Merge pull request #850 from akhayyat/virt-facts 
Add openvz detection to virtualization facts, and some cleanup
 2012-08-11 09:11:01 -07:00
Michael DeHaan
32922e404b Don't include local addresses in the all_ipv4/6 list 2012-08-11 12:08:55 -04:00
Ahmad Khayyat
916fcdb93b Add openvz detection to virtualization facts, and some cleanup 2012-08-11 08:33:43 -04:00
Ahmad Khayyat
f0a8e13628 Update doc string and minor cleanup 2012-08-11 06:39:22 -04:00
Ahmad Khayyat
7950dd01e5 Recognize interface aliases in network facts, and add IP facts 2012-08-11 06:20:32 -04:00
Michael DeHaan
36527ca9d5 Merge pull request #838 from sfromm/issue825 
Update file module to not recurse when setting ownership
 2012-08-10 17:02:23 -07:00
Sébastien Bocahu
487d07a845 Fix variable scope 2012-08-10 21:58:58 +02:00
Stephen Fromm
94696fb88e Update file module to not recurse when setting ownership 
This updates set_owner_if_different() and set_group_if_different()
to not implicitly recurse when setting ownership (whether user or
group).  It drops the os.system() call and replaces it with os.chown().
Resolves issue #825.

The recursion should be explicit.  A recurse=yes|no option should be
added to the file module.
 2012-08-09 22:59:39 -07:00
Michael DeHaan
9e934acfca Relative symlinks don't really work (module bug) and would be confusing anyway, better to be explicit. 2012-08-09 21:46:03 -04:00
Michael DeHaan
ef18f9d953 Fix a scoping issue that was fixing some non-repoquery-installed cases 2012-08-09 21:35:21 -04:00
Michael DeHaan
63641da225 Merge branch 'yum-wo-repoquery' of https://github.com/dhozac/ansible into devel 
Conflicts:
	library/yum
 2012-08-09 21:29:59 -04:00
Michael DeHaan
8e12440db4 Merge pull request #830 from cybertoast/feature/pip_module_py2.4 
Feature/pip module py2.4
 2012-08-09 17:24:27 -07:00
Michael DeHaan
f311d685cb Merge pull request #828 from skvidal/devel 
add backup= option to copy. makes a backup of the file on the target
 2012-08-09 17:23:52 -07:00
Sundar Raman
66a6231922 Further syntax fix work on Python2.4 
The `val if something else something-else` syntax does not work prior to 2.5.
 2012-08-09 18:09:18 -04:00
Sundar Raman
9ad91d7369 Fix syntax to work on Python2.4 
The `val if something else something-else` syntax does not work prior to 2.5
 2012-08-09 17:54:29 -04:00
Seth Vidal
588b129018 fix case where destination does not yet exist - no backup can be made 2012-08-09 15:33:05 -04:00
Seth Vidal
28e9b1128f add backup= option to copy. makes a backup of the file on the target 
in a file named: $filename.YYYY-MM-DD@HH:MM~

backup=False is default
 2012-08-09 14:24:21 -04:00
Seth Vidal
5c458b9761 make yum module work with list=pkgspec 2012-08-09 13:22:51 -04:00
Daniel Hokka Zakrisson
5a7d271759 Allow using the yum module without repoquery 
It is still required to use list=..., but the typical install and remove
won't need it.
 2012-08-09 17:22:09 +02:00
Michael DeHaan
c82f06258c Only run yum,apt through the with_items loop if there is a list of items. Just a cosmetic fix on return values 
for the most part.
 2012-08-08 20:43:01 -04:00
Michael DeHaan
d451cc6463 Merge pull request #794 from mattupstate/apt_repository 
add apt_repository module
 2012-08-08 16:14:38 -07:00
Michael DeHaan
b378a94b7b Merge pull request #796 from mattupstate/pip 
add pip module
 2012-08-08 16:13:32 -07:00
Michael DeHaan
82dfb11fb9 Merge pull request #807 from mattupstate/supervisorctl 
Add supervisorctl module
 2012-08-08 16:13:16 -07:00
Michael DeHaan
67205eb816 Merge pull request #795 from mattupstate/easy_install 
Add easy_install module
 2012-08-08 16:12:30 -07:00
Michael DeHaan
311d7c46ca Merge pull request #806 from skvidal/devel 
fix up yum state=latest with pkg groups
 2012-08-08 16:11:41 -07:00
Michael DeHaan
fe65648ea5 Merge pull request #808 from sfromm/issue800 
Make exception more specific (OSError) in setup module for selinux call
 2012-08-08 16:11:04 -07:00
Seth Vidal
61e02d508c add show-duplicates to reqpoquery to keep people who 
want to install an old package happy.
 2012-08-08 14:02:38 -04:00
Stephen Fromm
0cc73c930b Make exception more specific (OSError) in setup module for selinux call 2012-08-08 08:56:12 -07:00
Matt Wright
34e0faaf4b Add supervisorctl module 2012-08-08 10:59:46 -04:00
Matt Wright
15e9f1e15a Update per ansible/ansible#794 2012-08-08 10:46:23 -04:00
Seth Vidal
ca63173bf0 missed the quotes 2012-08-08 10:43:45 -04:00
Matt Wright
2a68f5d0af Updates per ansible/ansible#795 2012-08-08 10:38:27 -04:00
Seth Vidal
70eea69e79 fix up yum state=latest with pkg groups 2012-08-08 10:35:43 -04:00
Matt Wright
0116e53e48 Updates per ansible/ansible#796 2012-08-08 10:35:07 -04:00
Michael DeHaan
f757d659cc Merge pull request #804 from sfromm/issue789 
Abstract how to look up user password to be more flexible
 2012-08-08 04:46:28 -07:00
Michael DeHaan
ae7e1928df Merge pull request #790 from sfromm/fixgit 
Fix error handling when switching versions
 2012-08-08 04:44:43 -07:00
Stephen Fromm
49f3ab6757 Abstract how to look up user password to be more flexible 
This adds user_password() to abstract how the user's password is looked
up.  If spwd is not available, this will read the shadow file for the
user's shadow entry.  This will then facilitate idempotent password
changes on hosts without spwd.
 2012-08-07 23:57:17 -07:00
Stephen Fromm
3fb3eae7b6 Protect all selinux calls with try/except 2012-08-07 22:57:44 -07:00
Matt Wright
62297b608f Add easy_install module 2012-08-07 16:41:34 -04:00
Matt Wright
bef4c1b955 add apt_repository module 2012-08-07 16:39:31 -04:00
Matt Wright
4de0e5de54 add pip module 2012-08-07 16:38:04 -04:00
Stephen Fromm
6265be3aee Fix error handling when switching versions 
git module used to check stderr for the string 'error' after calling
switch_version().  This changes that to just look at the return code to
determine whether the command failed.  If the rc is not zero, the git
module will call fail_json().

The problem is that git checkout will summarize the commit message,
such as:

    HEAD is now at ea38409... removing artificial error

When the string 'error' is the commit message, this check will
erroneously think the command failed.

This also removes the method switchLocalBranch() since it is no longer
used.
 2012-08-07 11:20:14 -07:00
Michael DeHaan
092f83e6f8 Merge pull request #781 from gottwald/devel-mysql-socketOption 
login_unix_socket option for mysql modules
 2012-08-06 18:45:36 -07:00
Michael DeHaan
faed4b5a33 whitespace + remove deprecated YAML parser (migration script lives in examples/scripts and warning was added 
in 0.6 release)
 2012-08-06 20:07:02 -04:00
Michael DeHaan
08c1f96e4b Fix some subtle behavior of how the get_url module chains into the file module, plus blend the results of daisy chain 
operations in the correct order, so the file module results overlay the original module results, not the other way
around (which keeps any failure msg's intact)
 2012-08-03 07:02:31 -04:00
Ingo Gottwald
891415e616 Added login_unix_socket option to mysql_user module 2012-08-03 12:35:18 +02:00
Ingo Gottwald
a2aa30f4e5 Added login_unix_socket option to mysql_db module 2012-08-03 12:34:55 +02:00
Michael DeHaan
7e9e29011e Add encoding lines to python modules such that they can take unicode options if they are fed them, since the 
AnsibleModule stuff no longer base64 encodes for simplicity and speed reasons.
 2012-08-02 21:29:10 -04:00
Michael DeHaan
ce01c3f7e7 Allow unicode transfer by not base64 encoding. Also: faster 2012-08-02 21:20:43 -04:00
Seth Vidal
4d29cd6ee3 make virt module command= work again - better error handling should be in its 
future
 2012-08-02 17:46:21 -04:00
Seth Vidal
fd492bebc6 - add a check for repoquery so we can abort politely 
- make the results output a bit more readable
- fix up where repoquery is looked for so it is easier to change
 2012-08-02 17:02:37 -04:00
Michael DeHaan
98e4034de2 Merge pull request #772 from gottwald/devel-serviceFix 
Fixed a Bug in the service module "state changed" recognition
 2012-08-02 08:49:30 -07:00
Ingo Gottwald
25b52109b4 Fixed a Bug in the service module state changed recognition 2012-08-02 17:18:25 +02:00
Stephen Fromm
85c838c835 Add Blade to FORM_FACTOR list and document SMBIOS spec URL 2012-08-02 07:24:05 -07:00
Stephen Fromm
9a3ad060dc Catch exception if form factor id is unknown 2012-08-02 07:06:55 -07:00
Michael DeHaan
fa79d57d13 changelog / remove a failed=False 2012-08-01 22:35:07 -04:00
Michael DeHaan
b7c3fd1246 failed should not be in the result returns for a module upon success 2012-08-01 22:30:22 -04:00
Michael DeHaan
91d31d8164 Merge pull request #761 from skvidal/devel 
redo of yum module - uses more system calls but should handle
 2012-08-02 05:13:23 -07:00
Seth Vidal
c91befda5c redo of yum module - uses more system calls but should handle 
random plugin vomit better.
also should handle multiple withitems in a single execution, now.
 2012-08-02 01:47:48 -04:00
Michael DeHaan
e820c282be Merge pull request #760 from sfromm/fixes 
A couple fixes for the file module
 2012-08-02 04:54:16 -07:00
Will Thames
0e26ef9bdd Revert acceptance of directory as dest for copy 
Although library/copy can be corrected to understand that dest is
a directory, I can't see how to let _execute_copy know this and let the
file module know.

As a better solution than before #733, the copy module now explicitly (rather
than silently) fails when dest is a directory.
 2012-08-02 16:54:03 +10:00
Stephen Fromm
d0892c19ad Add setype to file's argument_spec and remove secontext 
secontext is used internally and should not be in argument_spec
 2012-08-01 22:24:09 -07:00
Stephen Fromm
52afacf475 Fix module_fail_json call when symlink src does not exist 2012-08-01 22:23:02 -07:00
Michael DeHaan
25acfa8170 Join with_items for the apt module, yum pending, and various fixes to the yum module to support aliases 2012-08-01 20:33:13 -04:00
Michael DeHaan
ed14312ad6 reinstate invalid argument checks where possible, daisy chainee/chained modules turn it off 2012-08-01 19:42:31 -04:00
Michael DeHaan
77029a4227 Merge pull request #752 from go2sh/apt-patch 
Enable apt module to handle multiply packages (comma separated)
 2012-08-01 16:27:29 -07:00
Stephen Fromm
abe8d8d4d6 Return extra information from service module 
If _do_enable() is run and returns rc == 0, set changed=True
Add enabled and state to result if they are supplied when the module is
run.
 2012-08-01 14:58:32 -07:00
Stephen Fromm
42ad1c879f Fix service module for issue 755 and another bug 
Allow use of service module with just enable parameter, per issue #755.
Also fixed two other issues:
- fixed parameter to be 'enabled' per docs, not 'enable'.
- fixed if block that checks whether to run _do_enable() to check
  whether the parameter is set, not the value of the enable value which
  may be None or False.  If enabled=no, the service would never be
  disabled.
 2012-08-01 14:44:26 -07:00
Christoph Seitz
6baaea90ae Tweaked error massages. 2012-08-01 18:45:32 +02:00
Christoph Seitz
b973910283 Some optimizations to previous code. 2012-08-01 18:43:39 +02:00