James Cammarata
eab4ce19f3
Making the return parsing in ActionBase generic for reuse
...
Now also correctly parses the return value for the _low_level_execute_command
2016-03-30 12:45:21 -04:00
James Cammarata
4fc0aadd84
Only combine vars in include_vars if both are mappings
...
Fixes #15184
2016-03-30 11:11:26 -04:00
Brian Coca
c09e085480
Merge pull request #14735 from jsok/open_url-netrc
...
Lookup netrc for credentials in open_url
2016-03-30 07:41:56 -07:00
Malte Krupa
3c954e6572
Add '--skip-tags' to ansible-pull
2016-03-30 16:36:16 +02:00
Brian Coca
92d154f4ef
centralize path list handling
...
move it to constants and avoid duplicating code or misinforming
developers on the nature of the data
2016-03-30 07:16:09 -07:00
Brian Coca
3f6166d2bf
always return rc
2016-03-30 07:15:51 -07:00
Rob White
a46de20772
Handle lists during dict recursion
2016-03-30 16:49:02 +11:00
Peter Sprygada
fa6464e807
feature to localize prompt search logic for ios shared module
...
Prompt search logic is now localized to the ios shared module instead
of using the common regexps in the shell module. This resolves a number
of problems with ios modules functioning properly
2016-03-29 22:13:38 -04:00
James Cammarata
2be1726350
Don't remove _raw_params from static include args
2016-03-29 21:40:29 -04:00
nitzmahone
05af5c88ea
fix Mac chown/chmod -R issue, add error checks
...
The changes to chown/chmod were broken on Mac (-R was being appended to the end of the command- OSX requires it before the file list).
A number of base action remote setup commands were also blindly proceeding without checking for success. Added error raises for unrecoverable failure cases.
2016-03-29 07:44:09 -07:00
James Cammarata
f2713f764c
Take previous jinja2 blocks into account in splitter when we see quotes
...
Previously, split_args() was not taking print/block/comment depth into account
when splitting things, meaning that if there was a quote character inside an
un-quoted variable (ie. {{ foo | some_filter(' ') }}), it was incorrectly
splitting on the quotes instead of continuing to append to the previous param.
Fixes #13630
2016-03-28 15:43:43 -04:00
Brian Coca
04610106a3
Merge pull request #15173 from mattclay/issue6072
...
Support remote_user in jail connection plugin.
2016-03-28 09:22:00 -07:00
Brian Coca
e9a4526251
allow bypassing executable setting
...
if you set executable to an empty string this avoids passing one to the command constructor
fixes #14813
2016-03-28 08:02:27 -07:00
Rob White
a5b05922ed
Some helper functions to work with boto3
2016-03-28 21:43:31 +11:00
Brian Coca
c303ed24b5
Merge pull request #15159 from sigio/filter-ip4-hex
...
Add ip4_hex filter to convert ip-address to hex notation
2016-03-27 14:14:25 -07:00
Brian Coca
b77bba8f9f
Merge pull request #15175 from wimnat/feature/camel_case_fixing
...
Add function to convert CamelCased key names to snake_names
2016-03-27 14:12:23 -07:00
Brian Coca
363384f517
Merge pull request #15174 from mattclay/conn-msg-host
...
Fix inconsistent/missing host names in messages.
2016-03-27 14:07:13 -07:00
David Wittman
5036d1742c
Fix boolean choices in module docs fragments
...
A few of the docs fragments have the available choices for some params
defined as "BOOLEANS". Because choices accepts a list, it treats
"BOOLEANS" as an iterable and then generates a list composed of each
letter.
Instead, define the available choices as a list of `['yes', 'no']`,
as is common in most other modules.
2016-03-27 15:30:27 -05:00
Toshio Kuratomi
0fffb6c60c
Merge pull request #15163 from ansible/synchronize-connection-vs-play_context
...
Use _connection instead of _play_context for information about the connection
2016-03-27 10:24:46 -07:00
Brian Coca
c6c3fd79c2
Merge pull request #15168 from bcoca/script_exists_fix
...
Script exists fix
2016-03-26 22:08:13 -07:00
Rob White
ef8c1124d0
Add function to convert CamelCased key names to snake_names
2016-03-26 18:46:50 +11:00
James Cammarata
eff89d6290
Merge pull request #15140 from berlic/args-splitter-exception-context
...
Show error context in args splitter exception
2016-03-26 01:02:54 -04:00
Matt Clay
5fdc29e00f
Fix inconsistent/missing host names in messages.
2016-03-25 21:11:53 -07:00
Matt Clay
b60062bdf9
Support remote_user in jail connection plugin.
...
Resolves #6072 .
2016-03-25 20:15:52 -07:00
Brian Coca
28d20dbe53
moved 'path exists' function to shell
...
now it will work with powershell/winrm
2016-03-25 12:56:48 -07:00
Toshio Kuratomi
0cabd133ba
have to always run dwim() on the path to get the full absolute path.
...
Fixes #14944
2016-03-25 12:09:30 -07:00
Toshio Kuratomi
e2f5762232
Use _connection instead of _play_context for information about the connection
...
If we're not delegating then we change _connection into a local
connection midway through the file but we don't change
_play_context.connection (no need to alter that). When we later check
it in process_remote() we need to know the actual connection, not the
connection that we thought we were going to use at the start of run().
So we have to use _connection.transport in process_remote(). The rest
of the places could use either one (because we have not yet changed to
a local connection) but we go ahead and switch those to
_connection.transport as well to avoid confusion in the future.
Fixes https://github.com/ansible/ansible-modules-core/issues/3136
2016-03-25 09:25:19 -07:00
James Cammarata
f4eb9aac24
Fix --start-at-task which was broken by the setup task revamp
...
Fixes #15010
2016-03-25 11:32:19 -04:00
Toshio Kuratomi
2adf8f7ec9
Update submodule refs
2016-03-25 07:42:04 -07:00
Mark Janssen -- Sig-I/O Automatisering
b1015d897d
Re-add accidentaly removed comment
2016-03-25 15:33:35 +01:00
Mark Janssen -- Sig-I/O Automatisering
73766e0816
Add ip4_hex filter to convert ip-address to hex notation
2016-03-25 15:24:48 +01:00
Matt Davis
afc82f6beb
Merge pull request #14930 from mholiv/enable_dollar_as_first_char_in_folder_and_userName
...
Modified files to use single quotes rather than double for file path.…
2016-03-25 07:14:42 +00:00
Toshio Kuratomi
3221be4340
Reverse boilerplate order because from __future__ must be the first code in the file
2016-03-24 20:08:39 -07:00
Brian Coca
1c4cfee415
Merge pull request #15046 from bcoca/script_raw
...
removes python requirement to script
2016-03-24 19:52:06 -07:00
nitzmahone
4241106ad2
fix breakage from new recursive=True arg to chmod
2016-03-24 19:47:43 -07:00
Toshio Kuratomi
80e7fbff75
Add python3 compat boilerplate
2016-03-24 18:04:16 -07:00
Toshio Kuratomi
17e8500202
Don't process the same host multiple times
...
Fixes #14259
2016-03-24 16:43:43 -07:00
Brian Coca
1ebc2fda71
removes python requirement to script
...
mistakenly added when checksum was made to use stat module
fixed assertion in test
2016-03-24 16:17:58 -07:00
Brian Coca
6768f34b31
Merge pull request #15062 from gechr/gc-subset-superset-filters
...
Add `issubset` and `issuperset` tests
2016-03-24 16:17:13 -07:00
Thomas Steinbach
870160b8ed
fixed some breaks after merging ansible/devel
2016-03-24 22:09:41 +01:00
Thomas Steinbach
cd2c140f69
forwarded docker_extra_args to latest upstream/origin/devel
2016-03-24 21:25:38 +01:00
Toshio Kuratomi
228ad3ca39
Should be errors=strict since we don't want to end up matching hosts like '???'
2016-03-24 09:25:37 -07:00
Toshio Kuratomi
13b295f1ee
Fix using non-ascii for inventory hostname patterns with the CLI.
2016-03-24 09:22:35 -07:00
James Cammarata
2c20579a06
Add options to make includes 'static'
...
* Can be configured in the ansible.cfg for tasks/handlers individually
* If an included filename contains no vars or loops, it will be expanded
in-place as if it were marked as static
2016-03-24 10:12:51 -04:00
Toshio Kuratomi
f323eb858e
nv_por is needed later in the file
...
Fixes #14654
2016-03-24 06:58:56 -07:00
Toshio Kuratomi
c4a5cf174b
Merge pull request #15009 from bcoca/py3_compat_fixes
...
Py3 compat fixes
2016-03-24 06:55:29 -07:00
James Cammarata
f427955640
Make default var lookup for tasks follow the dep chain
...
Related to #14296 (@jjshoe's follow-up example on that issue)
2016-03-24 09:51:36 -04:00
Konstantin Suvorov
1c922135a0
show error context in args splitter exception
2016-03-24 16:50:21 +03:00
Brian Coca
5b11494437
python3 compatiblity
...
remove use of basestring
deal with configparser
2016-03-24 06:39:21 -07:00
Toshio Kuratomi
52e9209491
Don't create world-readable module and tempfiles without explicit user permission
2016-03-23 09:52:19 -07:00
Brian Coca
fdb56e4bad
avoid bad path entries
2016-03-23 09:30:48 -07:00
Toshio Kuratomi
728bb7d85e
Update submodule refs
2016-03-23 08:32:42 -07:00
Toshio Kuratomi
917da92e2b
Get rid of extra trailing space in log messages
2016-03-23 08:01:21 -07:00
Matthew Gamble
7b06ec79e3
Add documentation for squash_actions configuration setting
2016-03-23 20:38:12 +11:00
Matthew Gamble
197e590d7c
Small comment improvement in AnsibleModule class
2016-03-23 19:22:18 +11:00
Abhijit Menon-Sen
1b242ffb89
Merge pull request #15111 from xiaket/devel
...
complete the docstring. Fixed #14794
2016-03-23 13:13:42 +05:30
夏恺(Xia Kai)
f9a9e5e1b9
complete the docstring. Fixed #14794
...
Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
2016-03-23 07:24:43 +00:00
Peter Sprygada
5bb876b0e2
fixes issue with getting value with . (dot) in key in netcfg
...
This commit addresses a problem when attempting to retrieve a value from
the result that includes a dict key using . (dot).
2016-03-23 02:36:48 -04:00
Brian Coca
b4b44b2708
Merge pull request #15086 from robinro/patch-2
...
remove double read of "path" (/etc/SuSE-release) in facts.py
2016-03-22 16:14:51 -07:00
Brian Coca
43f70d66a5
Merge pull request #15088 from robinro/patch-3
...
break after parsing SuSE-release in facts.py
2016-03-22 12:12:29 -07:00
Joel
23a74eb125
Sort plugins by basename to support ordering callbacks
2016-03-22 12:12:51 -05:00
Toshio Kuratomi
06d77996da
Update submodule refs
2016-03-22 09:21:49 -07:00
Robin Roth
2c28dcc5cb
break after parsing SuSE-release in facts.py
...
All sections that lead to succesful parsing of the version break afterwards, for SuSE-release this break was missing, potentiall causing #14837
2016-03-22 08:12:17 +01:00
Robin Roth
fea5500605
remove double read of "path"
...
path is already read in line 444, don't reread the file here, but use the existing content
2016-03-22 07:50:04 +01:00
Toshio Kuratomi
3511abb9d9
Merge pull request #15055 from ansible/ansible_sudo_pass-should-override-cli
...
Fix ansible_sudo_pass inventory variable so that it overrides setting of sudo password from the command line
2016-03-21 13:31:35 -07:00
Toshio Kuratomi
f39a1da360
Merge pull request #15074 from ansible/pluginloader-cleanups
...
Cleanup some minor issues in PuginLoader:
2016-03-21 12:57:46 -07:00
George Christou
02ad029840
Add issubset
and issuperset
tests
2016-03-21 19:22:39 +00:00
Toshio Kuratomi
ed9e164b80
Fix ansible_sudo_pass inventory variable so that it overrides setting of sudo password from the command line
2016-03-21 10:20:40 -07:00
Toshio Kuratomi
7ce130212f
Cleanup some minor issues in PluginLoader:
...
* class_only was a keyword arg of get() and all() that was mistakenly
passed on to Plugins. Be sure to strip it from the keyword args
before instantiating Plugins. (Reworked API probably should either
not instantiate Plugins or take the args for the Plugin as a separate
list and a dict.)
* Checking required base_classes was only done in get() and only if
class_only was False (ie: that Plugin was instantiated). This meant
that different plugins could be found depending on whether the call
was to .get() or to all() and whether it was for classes or instances.
Fixed so that required base_classes are always checked.
2016-03-21 09:54:37 -07:00
Brian Coca
3ae9a272e0
Merge pull request #14977 from towolf/hide_ok_items_in_actionable
...
For `actionable` cb plugin also hide ok for itemized results
2016-03-21 08:04:52 -07:00
James Cammarata
ae21d98955
Properly use check_raw when using parse_kv in cli/ code
...
Fixes ansible-modules-core#3070
2016-03-21 11:00:44 -04:00
Toshio Kuratomi
407f8f934e
Merge pull request #14976 from xiaket/devel
...
use __mro__ for plugin loading when we search for its base class.
2016-03-21 07:32:07 -07:00
Tobias Wolf
4938b98e4e
For actionable
cb plugin also hide ok for itemized results
...
The purpose of the `actionable` callback plugin is to hide uninteresting
results.
Also hide the ok results when the task was itemized.
2016-03-21 14:59:57 +01:00
夏恺(Xia Kai)
38092dcc27
import the base class and check whether this obj has the required base class.
...
Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
2016-03-21 07:21:54 +00:00
Toshio Kuratomi
9053d0468e
Merge pull request #15006 from ansible/local-pipelining
...
Add changes necessary for enabling pipelining for local connections
2016-03-20 22:12:07 -07:00
James Cammarata
9d2fe2fb2c
Fixing role param precedence issues
...
* Make role param resolution follow the role dependency chain, rather
than using all roles within the play
* Also move params to be merged in after role vars in general, to match
our variable precedence rules
* Changes to the way var lookup is done in role helper methods for
get_vars(), get_inherited_vars(), and get_role_params() to make the
above possible without trampling on previously merged vars
Fixes #14472
Fixes #14475
2016-03-20 11:09:32 -04:00
Toshio Kuratomi
4a00999875
Update to latest git submodules
2016-03-20 08:03:58 -07:00
Toshio Kuratomi
b80c9b5032
Merge pull request #15049 from mattclay/paramiko-unicode
...
Add missing to_bytes for cmd.
2016-03-19 22:37:23 -07:00
Matt Clay
24c4384f0e
Add missing to_bytes for cmd.
2016-03-19 11:13:38 -07:00
James Cammarata
e4a5bcae3c
Merge pull request #14679 from dagwieers/merge_hash_v2
...
Avoid merging a dict and a AnsibleUnicode
2016-03-19 12:58:42 -04:00
Brian Coca
7a5ff16aee
Merge pull request #15042 from RNanney/RNanney-validate_certs
...
Update nxos.py
2016-03-18 19:32:32 -07:00
Toshio Kuratomi
f5654dced9
Merge pull request #15043 from mattclay/docker-user
...
Use docker exec -u only when supported.
2016-03-18 18:46:46 -07:00
Matt Clay
ea1a6c56b9
Use docker exec -u when needed and if supported.
...
If remote_user is given and cannot be set in docker, a warning will
be displayed unless the default container user matches remote_user.
2016-03-18 18:19:41 -07:00
RNanney
8bceff5136
Update nxos.py
2016-03-18 15:55:41 -05:00
James Cammarata
13f3cbaf3b
Renaming per-item and retry callbacks
2016-03-18 15:17:43 -04:00
Toshio Kuratomi
60c943997b
More doc updates regarding ansible_shell_executable
2016-03-18 09:16:21 -07:00
Toshio Kuratomi
8bdf0d4746
And another doc fix
2016-03-18 09:09:31 -07:00
Toshio Kuratomi
08394df8d0
Update submodule links for docs fixes
2016-03-18 09:06:05 -07:00
Abhijit Menon-Sen
efdac490ff
Merge pull request #14924 from mvgrimes/patch-1
...
Dynamically add ssl key to the mysql config hash iff needed
2016-03-18 20:38:33 +05:30
Brian Coca
d43fc631dd
mount facts now include network mounts (nfs)
2016-03-18 07:28:53 -07:00
Brian Coca
b809d23863
fixed typo
2016-03-18 07:04:12 -07:00
Abhijit Menon-Sen
e5460d6a6e
Merge pull request #15002 from camradal/devel
...
add find_host_portgroup_by_name function to vmware utils
2016-03-18 19:32:17 +05:30
Toshio Kuratomi
e25caebe7a
Cleanups to docs and rename of inv var
2016-03-18 06:42:37 -07:00
Toshio Kuratomi
8fc1c26c37
Merge pull request #14936 from bcoca/ansible_executable
...
add ansible_executable inventory var
2016-03-18 06:41:24 -07:00
Toshio Kuratomi
2ba4428424
Catch ValueError as well because of El Capitan provoking a bug in python2's subprocess
...
Fixes #14895
2016-03-18 05:52:53 -07:00
Abhijit Menon-Sen
a61a3e28da
Merge pull request #9776 from MiLk/fixes/git-repo-info-branch
...
ansible.utils._git_repo_info() now supports branch names with slashes
2016-03-18 18:08:02 +05:30
Brian Coca
db61e9be0c
add ansible_executable inventory var
...
also handle the overrides appropriately
also new executable to set shell type
2016-03-17 18:54:37 -07:00
Thomas Steinbach
14dfad730e
use just 'remote_user' as user for the docker connection
2016-03-17 14:39:44 -07:00
Thomas Steinbach
4ac49ed4a8
use remote_user or become_user in docker connection
2016-03-17 14:39:44 -07:00
Brian Coca
5d9b552317
Merge pull request #15024 from bcoca/delegation_vars_fix
...
ensure we use delegated vars on delegation
2016-03-17 14:33:36 -07:00