1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

20265 commits

Author SHA1 Message Date
Krzysztof Zawadzki
ef9dac548f File Module docs, adding mode permission example with sticky bit (#36151)
* File Module docs, adding mode permission example with sticky bit
2018-02-14 12:18:13 +00:00
Anil Kumar Muraleedharan
cf9b427add Changing Lenovo Inc to Lenovo and update License file to be consistent. (#36155) 2018-02-14 10:44:05 +00:00
Lachlan Cooper
4267d12e61 Fix description for rabbitmq_policy (#36149)
This was copied from rabbitmq_vhost.
2018-02-14 09:41:05 +01:00
Lindsay Hill
08eaf37ca8 Fixed Arista typo in docstring (#36139) 2018-02-14 13:23:06 +05:30
Sean Cavanaugh
a52a7d2065 adding support for loopback interface (#36141)
* adding support for loopback interface

currently the loopback interface lo is not supported with vyos_l3_interface, this commit fixes that.  Right now there is a limit of loopback interfaces to just lo, if you want more interfaces you need to use a dummy interface https://wiki.vyos.net/wiki/Dummy_interfaces

* fixing spacing as per pep8 test

fixing issues for sanity test

lib/ansible/modules/network/vyos/vyos_l3_interface.py:120:15: E111 indentation is not a multiple of four
lib/ansible/modules/network/vyos/vyos_l3_interface.py:122:15: E111 indentation is not a multiple of four
lib/ansible/modules/network/vyos/vyos_l3_interface.py:126:19: E111 indentation is not a multiple of four
lib/ansible/modules/network/vyos/vyos_l3_interface.py:128:19: E111 indentation is not a multiple of four
lib/ansible/modules/network/vyos/vyos_l3_interface.py:131:19: E111 indentation is not a multiple of four
lib/ansible/modules/network/vyos/vyos_l3_interface.py:133:19: E111 indentation is not a multiple of four
lib/ansible/modules/network/vyos/vyos_l3_interface.py:137:15: E111 indentation is not a multiple of four
lib/ansible/modules/network/vyos/vyos_l3_interface.py:140:15: E111 indentation is not a multiple of four
lib/ansible/modules/network/vyos/vyos_l3_interface.py:145:15: E111 indentation is not a multiple of four
lib/ansible/modules/network/vyos/vyos_l3_interface.py:148:15: E111 indentation is not a multiple of four

* ugh, missed on spacing issue

* getting rid of continuation lines, the CI system does not like it
2018-02-14 13:01:48 +05:30
Dag Wieers
7897558b95
aci_aep_to_domain: Fix query all objects (#36131)
This PR includes:
- A fix to the module where domain_type without domain caused havoc
- A fix to the integration tests when querying all binding objects
- Improvements to integration tests
2018-02-13 19:07:23 +01:00
Chris Houseknecht
69be2c169f
Upgrade to openshift client 0.4.0 (#35127) 2018-02-13 10:34:24 -05:00
Matt Martz
76ff3e9efc
Prevent reparenting a block with itself (#36075)
* Prevent reparenting a block with itself

* Move __eq__ to Block, to avoid some unexpected problems
2018-02-13 09:30:05 -06:00
Daniel Andrei Mincă
6cfd198b13 provide detailed description of module (#36107)
Fix vague description of module.

Resolves:
Related:
Signed-off-by: Daniel Andrei Minca <mandrei17@gmail.com>
2018-02-13 14:00:48 +00:00
John R Barker
e4c04aa0f3
Fix YAML issue (#36103) 2018-02-13 12:46:56 +00:00
Charl van Niekerk
5861d3333c Corrected the helm module documentation to the correct default state (installed -> present). (#35950) (#35951) 2018-02-13 13:34:17 +01:00
saichint
eab1b62cd2 fix nxos_interface_ospf issues (#35988)
* fix nxos_interface_ospf issues

* review comment
2018-02-13 09:27:22 +05:30
Dag Wieers
218f008dab
ACI docs: Add a section about common error messages (#36088)
Since we pass information directly to ACI, we sometimes get error messages back to the user that require some additional information or context.

This PR includes:
- Changes to the default error output so the error is easier to find
  when searching in e.g. Google
- 3 specific error messages that we have encountered and has confused
  our users before
2018-02-13 03:13:08 +01:00
Dag Wieers
9f028e9dea
aci_domain_to_vlan_pool: Add missing integration tests (#36079) 2018-02-12 23:54:30 +01:00
Brian Coca
e8b631d4df corrected dump signature 2018-02-12 16:52:04 -05:00
Dag Wieers
30adc2f124
aci_domain: Add missing integration tests (#36051) 2018-02-12 21:37:25 +01:00
Martin Krizek
39d9496282 add_host: check if name or hostname arg is provided 2018-02-12 15:24:45 -05:00
tedder
e8fc269cd3 fix spelling. Seriously, that's it. 2018-02-12 13:17:55 -05:00
Dag Wieers
487cf0ee8d Improve convert_bool error message
The error message as it was confused me when the value was 'enabled' and
there was also a module parameter named 'enabled'.

    enabled is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

So by clearly describing it as a value, the confusion would have been
avoided.

    The value 'enabled' is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...
2018-02-12 13:05:38 -05:00
John R Barker
17c0d3eae0
Fix more docs vs argspec (#36048) 2018-02-12 17:42:25 +00:00
Stefan Horning
404f9260d9 [cloud][aws] Add metrics_collection options to ec2_asg module (#35180)
* Added metrics_collection management to ec2_asg module to switch ASG metrics on and off.

* Fixed typo in documentation of ec2_asg module

* Removed extra blank line in ec2_asg.py

* Docs fixes for ec2_asg module

* Added integration test for ec2_asg metrics flag

* Trying different syntax for ec2_asg test
2018-02-12 10:22:18 -05:00
Ganesh Nalawade
6a223d5576
Fix vrf parsing in eos_vrf and eos_eapi module (#35791)
* Fix vrf parsing in eos_vrf and eos_eapi module

Fixes #30250

Fix logic to parse vrf when interface value in `show vrf`
command output spans on multiple lines

* Add idempotent test case
2018-02-12 12:33:22 +05:30
Mike Wiebe
7a711cf942 Fix nxos_igmp_interface for diff nxos versions (#35959) 2018-02-12 10:30:38 +05:30
Abhijeet Kasurde
429c63510a
VMware: Minor typo in vmware_host_dns_facts (#36018)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-12 10:24:06 +05:30
Nathaniel Case
6cdf91fd35
Fix VyOS check mode (#35977)
* Revert "commented out check tests (#35788)"

This reverts commit 3df2561405.

* `discard_changes()` now uses `exit discard`

instead of just `discard`. Also a slight tweak to avoid a second `exit` after
`exit discard`
2018-02-11 11:40:33 -05:00
James Vornhagen
9704668277 Fixed spelling error in runit module (#35948) 2018-02-10 21:13:55 +05:30
Abhijeet Kasurde
52f79fa5a4
VMware: Additional check for RootSnapshot (#36001)
This fix adds an additional check if there is no snapshot available
in VM. `rootSnapshotList` is None, if no snapshot is taken.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-10 21:11:11 +05:30
David Newswanger
15fa18a619 removed to_subnet from list of imports on ios_l3_interface.py as it was not being used (#35969) 2018-02-10 12:06:34 +05:30
Matt Davis
26f551d1c3
initial cutover to API profiles (#35538)
* hardcoded API profiles in azure_rm_common
* changed azure_rm_securitygroup module to use api_profiles, dynamic models, kwargs on all SDK methods
* changed azure_rm_containerinstance module to use api_profiles, dynamic models, kwargs on all SDK methods
* fixed polling performance issue in azure_rm_securitygroup (default poll interval was 30s)
2018-02-09 14:26:42 -08:00
Sloane Hertel
fd33dc6cd1 [cloud] Make ec2_vpc_route_table wait for the route to propagate (#35975)
* Stabilize ec2_vpc_route_table

Wait for route table to be present before attempting to use it

Sleep before getting the final state of the route table in case modifications are incomplete

* Conditionally wait if changes were made

* Simplify logic
2018-02-09 16:32:23 -05:00
Dag Wieers
01ba3a4efc
ACI: Fixes to recent change to parameter choices (#35968)
This PR includes:
- Fixes related to the recent merge of #31637 and #34537
- A generic fix for a reference for assignment issue
- Fixes to aci.boolean() in order to catch exception
2018-02-09 21:21:56 +01:00
Ryan Brown
f4d896c716 Tower callback fixes (#35927)
* Fix tower_callback script return code

* Add ec2_key parameter to integration tests
2018-02-09 14:28:52 -05:00
Dag Wieers
3693e560dc
Provide more debug output on failures (#35961)
This PR includes:
- payload output on failure, when requested
- add additional kwargs to aci.exit_json()

We may want to enable some of this debug output by default on failure ?
2018-02-09 17:06:59 +01:00
Dag Wieers
764e78d302
Fix issue with module (#35960) 2018-02-09 16:10:25 +01:00
Bobby Watson
79b0739ba2 Accept interfaces without address family or method (#34200) 2018-02-09 15:09:09 +00:00
Tyler
15b0371eb2 Add examples and language to better showcase the 'parents' parameter in multiple network modules (#34486)
* Add additional language and examples for 'parents' parameter to clarify its usage.
2018-02-09 13:31:37 +00:00
Matt Clay
6cbd7cc5d8 Fix version in lib/ansible/release.py
Including `devel` in the version causes pip failures.
2018-02-09 04:47:31 -08:00
saichint
c7305393a3 fix nxos_evpn_vni issues (#35930) 2018-02-09 13:02:41 +05:30
Giorgio Crivellari
54e0327e5d added 'local' option to group (#34805)
* added 'local' option to group

fixes #34804'

* fix to version 2.5

fixes #34804'

* fix missing local var
2018-02-09 01:02:35 -05:00
Nick Wilde
aa09ed1a88 Fix typo in examples in Lookup/password plugin. (#35022) 2018-02-08 21:01:23 -05:00
Tomasz Kontusz
89ad40b129 Fix for #31477: return 'dest' from copy when file wasn't changed 2018-02-08 16:17:36 -08:00
Matt Martz
7d1eb88ecf Address memory ballooning caused by task caching changes (#35921)
* Exclude parent when copying included task to avoid memory issues. Fixes #35796

* Simplify implicit block squashing to pre-group, instead of post re-parenting
2018-02-08 15:28:07 -08:00
Matt Davis
b6dc27249a bump devel to 2.6 2018-02-08 15:24:37 -08:00
Brian Coca
79fbe09a4d remove slice filter as it already exists in jinja (#35922) 2018-02-08 16:30:51 -05:00
Alex Tsitsimpis
933bc45cf2 callback: Get handlers with json callback plugin (#35842)
Implement the `v2_playbook_on_handler_task_start()' method in the json
callback plugin to correctly include handlers in the results.

This fixes a bug where the last task in the results returned by
json callback would be wrong if an unconditional handler was triggered,
since the result of that handler would overwrite the result of the last
task.

Signed-off-by: Alex Tsitsimpis <alextsi@arrikto.com>
2018-02-08 16:01:32 -05:00
Sam Doran
b7f4b89757 Code style words in docs 2018-02-08 15:58:01 -05:00
Yanis Guenane
b37549f679 openssl_csr: Improved documentation on subject_alt_name possible values 2018-02-08 15:58:01 -05:00
Brian Coca
0bd9b3019f caller to preprocess must be None aware (#33653)
also removed unused copy of method

fixes #33650
2018-02-08 11:25:20 -06:00
Paweł Krupa
88f1f40aca expect default value of version param as None (#35790) 2018-02-08 12:10:19 -05:00
Toshio Kuratomi
03c73e2bbb Rename var lookup to vars and add tests 2018-02-08 08:03:41 -08:00
Toshio Kuratomi
db29190c28 Allow var lookup plugin to operate on a list of terms
Not sure this has a good use case but it's how nearly all other lookups
work so we should support the common interface.
2018-02-08 08:03:41 -08:00
Toshio Kuratomi
59faad3a6b Fix var lookup plugin to return a list 2018-02-08 08:03:41 -08:00
Daniel Jaouen
33cbbe0b39 Homebrew Cask: Multiple updates (#35759) 2018-02-08 11:00:06 -05:00
Toshio Kuratomi
5c085b2436 Fix aysnc failure by forgetting the remote tempdir that async_wrapper will delete on the remote end 2018-02-08 06:57:09 -08:00
Adam Friedman
a3b1c94d11 New dimensiondata_vlan module. (#21218)
* Initial (re)implementation of dimensiondata_vlan module.

This module was rewritten because the original implementation was imperative rather than declarative (which is the preferred style, and consistent with our other modules).

Credit for the original module implementation goes to Aimon Bustardo (@aimonb).

* Remove unused imports.

* Improve error message and documentation around expansion of a VLAN's private IPv4 network.

* Split message string over 2 lines.

* Add check_mode support to dimensiondata_vlan module.

ansible/ansible#21218

* Fix errors / warnings reported by Ansible sanity tests.

ansible/ansible#21218

* Remove 'metadata_version' key from documentation.

ansible/ansible#21218

* Return changed=True when changes would be made.

ansible/ansible#21218
2018-02-08 08:42:55 -06:00
Ryan Brown
0036cff493
[cloud] Add key_name parameter to ec2_instance (#35901) 2018-02-08 09:27:02 -05:00
Dave Buckley
cef1a666f3 name is not a required parameter (#35434) 2018-02-08 08:47:50 -05:00
saichint
80fcfdc0d1 fix nxos_vpc issues (#35868) 2018-02-08 18:50:37 +05:30
Sam Doran
6264a55cdc Add aliases for parameters to rhsm_repository module (#35800)
Allow 'enabled' and 'disabled' as synonymns to 'present' and 'absent'.

Minor updates to module docs.
2018-02-08 14:13:47 +01:00
Eike Frost
ecdb04119b keycloak_client: expand documentation, add some checking (#35545)
* add protocol mapper dict argument spec, documentation for protocol mappers, and documentation for attributes

* reformat docs to stay in line length limit

* better formatting/highlighting for docs

* ooops
2018-02-08 08:07:54 -05:00
Felix Fontein
d1f19125a5 openssl_csr: added support for the OCSP Must Staple extension (#35082)
* Added support for the OCSP Must Staple extension.

* Trying to clean up magic constants a bit.
2018-02-08 12:03:28 +00:00
Yuwei Zhou
273a3d1d51 Fixes #34913: azure_rm_loadbalance should accpet a list of rules instead of one (#35592)
* azure_rm_loadbalance should accpet a list of rules instead of one

* fix lint

* fix

* fix

* hook up load balancer rules, doc fixes, test updates
2018-02-08 01:32:27 -08:00
Toshio Kuratomi
8a22b51755
Fix copy for implicit relative paths (#35016)
copy currently fails if you specify a destination without any directory
component.  This is because we take the dirname of the destination for
some processing and no dirname causes issues.

This corrects that by prepending "./" if there is no directory component
in dest.
2018-02-08 00:12:32 -08:00
René Moser
2f36b9e5ce basic: allow one or more when param list having choices (#34537)
* basic: allow one or more when param list having choices

* add unit tests

* optimize a bit

* re-add get_exception import

* a number of existing modules expect to be able to get it from basic.py
2018-02-07 22:59:21 -08:00
Toshio Kuratomi
82c1456781
If the timeout in _poll_async_result has expired, raise the exception (#35878) 2018-02-07 22:57:16 -08:00
Ryan Brown
e71c6d8e17 New module: ec2_instance (#35749)
New module: ec2_instance

Integration tests for ec2_instance
2018-02-08 01:50:41 -05:00
James Mighion
663c410da4 Fixing eos_config save option. Was removed when deprecated. Fixing ot… (#35628)
* Fixing eos_config save option. Was removed when deprecated. Fixing other deprecation documentation. Adding unit tests.

* Fixing removed_in_version for force.
2018-02-08 11:54:17 +05:30
James Mighion
73650cf854 fixing the removed_in_version to 2.6. (#35853) 2018-02-08 09:56:08 +05:30
Sam Doran
6037e73c16
Add EdgeOS config module (#35867)
* Add edgeos_config module

* Add edgeos_config module

* Remove debugging statements

* Add future import and correct module name in docs
2018-02-07 21:12:15 -05:00
Sam Doran
a9da1c2927
Add EdgeOS facts module (#35871)
* Add edgeos_facts module and unit tests

* Add future import
2018-02-07 21:11:57 -05:00
Sloane Hertel
e10e1d6ddf [ecs_service_facts] replace map with dict for Python3 compatibility (#35355) 2018-02-07 21:05:51 -05:00
s-hertel
927ef22ad6 Fix docs and imports for os_project_access 2018-02-07 20:06:36 -05:00
s-hertel
2bcce99994 PEP8 os_project_access 2018-02-07 19:29:48 -05:00
s-hertel
2855f22e2b Fix spacing in os_project_access docs
Import openstack_module_kwargs
2018-02-07 19:28:42 -05:00
Ryan S. Brown
dff5fa3ec2 Fix os_project_access metadata and argspec import 2018-02-07 19:11:20 -05:00
KrdLab
2a6b03459b Fix aws_s3_cors documentation (#35684) 2018-02-07 18:27:47 -05:00
Brian Coca
6340d58cd1 add 'never' tag (#34104)
* add 'never' tag

skips a task unless a tag on the task is explicitly targeted

* never also affects untagged, clearer layout
2018-02-07 15:21:55 -08:00
Toshio Kuratomi
71f46d69d6 First bit of fixing temporary to have one source of truth (#35747)
* First bit of fixing temporary to have one source of truth

* Fix pep8

* Remove explicit make_tmp_path() in copy

The copy action plugin sets TRANSFER_FILES=True so it does not need to
set the temporary directory explicitly; the base class's run() method
will do that for us.

* Fix for calling a module's run when a shell has already created a temp path.

* Remember to inform the rest of the world when tempdir is removed

* New strategy for how to warn on passing tmp

Now we just warn when calling the parent class run() early.  If the
module does a late call to the parent run() and doesn't make use of the
temporary directory, then we don't check for the possibility that the
user mistakenly is sending tmp in.  If we truly deprecate this (rather
than ignoring it forever) then we might want to switch back to checking
for someone passing a value in as tmp.

* Remove tmp parameter from _execute_module as well

* Port all action plugins to not send tmp explicitly

This is now handled inside of _execute_module via the
_connection._shell.tempdir attribute.

Also update warnings and docs to tell people to set the attribute
instead of using _execute_module's tmp parameter.

* Always set local tempdir variable
2018-02-07 15:11:36 -08:00
Maarten Bezemer
7225839bef [git] Fix switching branch of shallow clone (#18728)
* [git] Fix fetching branch of shallow clone

* Use absolute file:// paths to make sure git uses shallow clones

* Improve tests

* Fix sanity errors
* Match style according to other (depth) tests

* Improve tests

Now they will fail without the fix of this PR
2018-02-07 18:07:02 -05:00
Adam Miller
6791990992 fix version_added in modules/cloud/openstack/os_project_access.py for merge
Signed-off-by: Adam Miller <admiller@redhat.com>
2018-02-07 17:05:27 -06:00
Adam Miller
13ec1d874d Merge branch 'os-project-access' of https://github.com/ioggstream/ansible into ioggstream-os-project-access
* 'os-project-access' of https://github.com/ioggstream/ansible:
  Module granting project_access to various resources
2018-02-07 17:04:38 -06:00
subcon42
920eaafde2 [cloud] New Module ec2_vpc_vpn: Facilitate VPN TunnelOptions (#35210)
AWS (and Boto3) supports VPN TunnelOption keys to be specified for VPNs.  Specifically (at least at the moment), the options for 'TunnelInsideCidr' (str) and 'PreSharedKey' (str) are particularly noteworthy.  One or both may be specified within a 'dict' object (max 2 dicts).  AWS defaults shall apply in absence of said parameters.
2018-02-07 17:39:12 -05:00
Jonathan Towne
1e04cababd add DragonFlyBSD support to modules/system/{user,group} 2018-02-07 17:18:49 -05:00
Brian Coca
3b0d864683 fix keep remote files 2018-02-07 16:58:27 -05:00
Nathaniel Case
dfcae9fc8e
Remove potentially confusing provider from module documentation (#35851) 2018-02-07 16:33:11 -05:00
Brian Coca
8ba8d1a131 remove new tmp var for localhost
this was causing issues with keep remote files as the 'local cleanup' would trump the setting.
it will revert back to using the 'remote path' setti.ng for 'localhost' actions.

fixes #35724
2018-02-07 16:16:10 -05:00
Pilou
a7461179cf Fix lookup plugins documentation (nios, conjur_variable) (#35847)
* conjur_variable lookup plugin doc: fix YAML
* nios lookup plugin doc: fix a typo
2018-02-07 13:14:51 -08:00
Willian Ricardo
ee64dbfec5 new module cloudfrontwatchlogs_log_group to create cloudwatch log group (#32272)
* new module to create cloudwatch log group

* Add new module cloudfrontwatchlogs_log_group to the changelog.
2018-02-07 15:52:28 -05:00
Jacob McGill
c7d9a1594d ACI_EPG_TO_DOMAIN: Add note about Openstack VMMs (#34845) 2018-02-07 21:38:48 +01:00
Jacob McGill
76a6c59e35 Pathatt encap (#35803)
* ACI_STATIC_BINDING: Rename 'encap' parameters

* Capitilize 'c' in docstring

* replicate name change in 'required_if'
2018-02-07 21:37:27 +01:00
Sloane Hertel
f20b9dab72 Add cloudwatchlogs_log_group_facts module (#35314)
* Add cloudwatchlogs_log_group_facts module

* pep8

* Add new module cloudwatchlogs_log_group_facts to CHANGELOG
2018-02-07 15:04:36 -05:00
Amel Ajdinovic
3381ff3ac9 New module: manage 1&1 public ip (cloud/oneandone/oneandone_public_ip) (#35079)
* Added firewall_policy, load_balancer, and monitoring_policy cloud modules for oneandone provider.

* Updated OneAndOneResources class and argument specs for monitoring policy and load balancer.

* Addressed ansible-test sanity pep8 and validate-modules errors.

* Added oneandone_public_ip cloud module for oneandone cloud provider. Removed extra modules to adhere to one module per PR.
2018-02-07 12:15:27 -06:00
Brian Coca
02a7e9fb88 remove runtime msg also 2018-02-07 12:35:56 -05:00
Brian Coca
4dcc5588f6 undeprecate include
defering deprecation until we are comfortable that the new actions
cover most of the ground users need.
2018-02-07 12:35:56 -05:00
Ondra Machacek
dcd1c40e66 ovirt: Require Python SDK 4.2.4 for Ansible 2.5 (#35841) 2018-02-07 11:49:25 -05:00
Ondra Machacek
7d4a2de66a Improve ovirt_vms, ovirt_hosts and ovirt_storage_domains (#35782)
* ovirt_vms: Add graphics consoles

* ovirt_hosts: Fix kdump integration check

* ovirt_storage_domains: Support multiple targets for block storages

* ovirt_vms: add cloud_init_persist parameter

* ovirt_vms: Change IO threads to int

* ovirt_vms: Fix update check

* ovirt_vms: Remove choices of OS, to not enforce it
2018-02-07 11:48:00 -05:00
Yaniv Kaul
51c4412de2 Fix the example - a cluster is a required propery (#35836) 2018-02-07 11:47:17 -05:00
Antonio Huete Jimenez
fae21f6aad service: Add support for DragonFly BSD
For now create a subclass of the FreeBsd class
2018-02-07 11:23:10 -05:00
Chad Norgan
9bbf97632c [WIP] Add new network module for EdgeOS (#33109)
* Add edgeos network module using network_cli

* Add documentation and some sanity test fixes

* Update copyright and documentation
2018-02-07 10:36:26 -05:00
Martin Krizek
e2c0865800 redhat_subscription: do not use defaults from the conf file (#33763)
* redhat_subscription: do not read defaults from the rhsm.conf file, let subman provide those.

* Only pass options specified by user to the config
2018-02-07 10:18:58 -05:00
Amel Ajdinovic
2e848b68ba New module: manage 1&1 private network (cloud/oneandone/oneandone_private_network) (#35076)
* Added firewall_policy, load_balancer, and monitoring_policy cloud modules for oneandone provider.

* Updated OneAndOneResources class and argument specs for monitoring policy and load balancer.

* Addressed ansible-test sanity pep8 and validate-modules errors.

* Added firewall_policy, load_balancer, and monitoring_policy cloud modules for oneandone provider.

* Updated OneAndOneResources class and argument specs for monitoring policy and load balancer.

* Addressed ansible-test sanity pep8 and validate-modules errors.

* Added oneandone_private_network cloud module for oneandone cloud provider. Removed extra modules to adhere to one module per PR.

* Updated check mode scenario for remove members, using proper wait_for method in remove_network, renamed private_network_id argument to private_network.

* Fixing validate-modules issue - Documented datacenter.

* Added oneandone_private_network cloud module for oneandone cloud provider. Removed extra modules to adhere to one module per PR.
2018-02-07 08:30:26 -06:00
Amel Ajdinovic
17626dd300 New module: manage 1&1 load balancer (cloud/oneandone/oneandone_load_balancer) (#35067)
* Added firewall_policy, load_balancer, and monitoring_policy cloud modules for oneandone provider.

* Updated OneAndOneResources class and argument specs for monitoring policy and load balancer.

* Addressed ansible-test sanity pep8 and validate-modules errors.

* Removed extra modules to adhere to one module per PR.
2018-02-07 08:30:17 -06:00
Amel Ajdinovic
aa541f662b New module: manage 1&1 firewall policy (cloud/oneandone/oneandone_firewall_policy) (#35066)
* Added firewall_policy, load_balancer, and monitoring_policy cloud modules for oneandone provider.

* Updated OneAndOneResources class and argument specs for monitoring policy and load balancer.

* Addressed ansible-test sanity pep8 and validate-modules errors.

* Removed extra modules to adhere to one module per PR.
2018-02-07 08:30:01 -06:00
Rob
9451212855 [cloud] New AWS module - elb_target (#26483)
* New module - elb_target

* Work to add deregister functionality

* Add jurajseffer work on waiting for status change

* List the set of statuses as a choices list

* default target_status_timeout is 60

* Add 'unavailable' as a target status choice per API docs

* Add support to remove targets that are in unused state

* add support for availability zone selection

Fix deregistering targets from used target groups

Fix waiting for unused state for targets that have started deregistering
2018-02-07 07:45:35 -05:00
Will Thames
fcd09e2f02 New aws_waf_web_acl module (#33212)
* Add aws_waf_web_acl rule

* Add new aws_waf_web_acl to CHANGELOG
2018-02-07 07:06:15 -05:00
Michael Scherer
2efd6bcaac Remove deadcode since diff is never used (#35147)
Flake8 keep warning me about that
2018-02-07 05:03:22 -05:00
Jordan Borean
a0178b79f1
win_uri: fixes (#35487)
* win_uri: moved away from Invoke-WebRequest and fixed multiple issues

* fixes from review
2018-02-07 20:58:47 +11:00
Martin Krizek
63fdc3f08f
Fix jinja2>=2.9 nested include vars (#35099)
This fixes a bug when parent's local vars where not available in nested
includes. The bug can only be seen with jinja>=2.9 which changes
how the variable scopes work.

Fixes #34886
2018-02-07 10:58:29 +01:00
Jacob McGill
0c5650ee1b Pathatt connection (#35806)
* add interfacce_type to absent required if...not sure how this would work without it

* move fex requirement to required_if

* Fix incorrect documentation about port_channels
2018-02-07 09:08:53 +01:00
Tim Rupp
95188ed35c
Fixes repeated calls to create an API object (#35816)
This patch fixes repeated attempts that the module would make to
re-create an API object. The change stores a copy for later lookup
instead. This prevents uncontrolled tokens from being created.
2018-02-06 22:16:26 -08:00
Ian Philpot
e62c1cd050 Az mod keyvault ops (#33606)
* keyvault_operations module init + template

* Created KeyVault Secrets Module. No Tests

* Passing 2.7/3.x sanity tests

* added intergration tests for keyvault secrets noop

* integration test pass/need keyvault module

* Added az env cleanup to intergration tests

* Updated auth to 0.3.6 ver

* fixed typo in integration tests

* Added check_mode

* Added tags

* Updated tags test, sanity + integration passed

* checked mode

* updated tests

* fixing sanity

* fix copyright
2018-02-06 20:40:15 -08:00
Ian Philpot
11382fac7a Az mod keyvault key (#33607)
* key module init

* Create/Delete pass sanity

* Integration tests passed

* Added check_mode

* Updated to support tags

* updated key tests

* fixed sanity

* added things that went missing during rebase

* fixed sanity

* fixed doc

* fix copyright
2018-02-06 20:40:00 -08:00
saichint
c9e0ce1d7d fix nxos_vpc_interface peer_link idempotence (#35737)
* fix peer_link idempotence

* review comment
2018-02-07 08:35:43 +05:30
Toshio Kuratomi
8a2bda0e06 When tempdir fails to be created, we have nothng to remove
This commit should get us a better error traceback when things do go
wrong.

References #35613
2018-02-06 17:29:20 -08:00
Pilou
54882d4715 dimensiondata: fix broken import (#35634)
* Fix broken import

* Remove never reached statements

exit_json and fail_json methods call sys.exit, subsequent statements
can not be executed.
2018-02-07 00:44:42 +01:00
Jacob McGill
417d11eeb9 ACI_STATIC_BINDING: Update paths paramater (#35807)
* ACI_STATIC_BINDING: Update paths paramater

* Fix small issue
2018-02-07 00:40:17 +01:00
Toshio Kuratomi
86242e6871
Enable wildcard import pylint (#35786)
* Wildcard imports should be taken care of.  Enable the pylint check for them
* Remove wildcard import code-smell test as we're now checking via pylint
* Add unused-wildcard-import as ignored in our compat code.

These three files use wildcard imports so that they can export
symbols in a compatible location.  The real code lives elsewhere.
So disable the pylint tests for the relevant sections of code.
2018-02-06 15:17:49 -08:00
mikedlr
d31ded47fb Aws ssm multiple fixes (#35569)
* aws ssm parameter lookup test case - fails demonstrating no exception when parameter missing

* aws ssm parameter lookup - fail in case parameter doesn't exist

* aws ssm parameter lookup test case - failing case for nice return from path lookup

* aws ssm parameter lookup - convert incoming taglist to a key-value dictionary

* aws ssm parameter lookup - pep8 / style clean up

* aws_ssm lookup plugin rewrite for more standard interface

* aws_ssm module and lookup - introduce integration test and fix:

* aws_ssm module and lookup - error case integraton test and many PEP8 and other cleanups

* aws ssm parameter lookup - Various fixes in response to review + recursive fix & test

* aws ssm parameter lookup - more in response to review - shertel/abadger

* aws ssm parameter lookup unit test - move to mocker according to abadger

* aws ssm parameter lookup - integrate with new documentation fragment

* aws ssm parameter lookup - accept either aws_profile or boto_profile

* aws ssm parameter lookup - eliminate lookup document fragment until env vars are fixed later
2018-02-06 17:41:46 -05:00
Jacob McGill
49eb0c49ea Pathatt mode (#35804)
* ACI_STATIC_BINDING: Update parameter to use more standard network lingo

* Add 'mode' as an alias
2018-02-06 23:20:06 +01:00
Yvan-Masson
44650d5e3a Fix typo (#35810) 2018-02-06 23:10:19 +01:00
Amel Ajdinovic
238760045e New module: manage 1&1 monitoring policy (cloud/oneandone/oneandone_monitoring_policy) (#35068)
* Added server_type parameter - defaults to K8S

* Changed server_type default value to cloud.

* Added server_type entry to documentation and updated server_type choice K8S to k8s_node

* Added support for overriding the default ONEANDONE_API_URL, and custom wait_timeout period for wait_for methods.

* Added firewall_policy, load_balancer, and monitoring_policy cloud modules for oneandone provider.

* Updated OneAndOneResources class and argument specs for monitoring policy and load balancer.

* Addressed ansible-test sanity pep8 and validate-modules errors.

* Removed extra modules to adhere to one module per PR.

* Fixed a typo
2018-02-06 17:06:54 -05:00
Chris Houseknecht
c20beeef37
Apply regex to dir name only (#35744) 2018-02-06 16:39:57 -05:00
Giovanni Sciortino
038b281da2 lineinfile creating underlying directory manage permission denied exception (#35794) 2018-02-06 14:03:20 -06:00
Ivan Bojer
e46ae45b66 new panos_match_rule module (#35202)
* new panos_match_rule module
2018-02-06 19:57:19 +00:00
Sean Cavanaugh
e93e76266c hostname parameter should be host_name (#35798)
the hostname parameter is wrong.  It will throw an error: "Unsupported parameters for (vyos_system) module: hostname Supported parameters include: domain_name, domain_search, host, host_name, name_server, password, port, provider, ssh_keyfile, state, timeout, username"  It is supposed to be host_name.  Only the example for documentation seems to be wrong in the module.
2018-02-06 12:52:19 -07:00
George Nikolopoulos
b1a8f3b3d3 Netscaler various fixes (#34800)
* Add default lb vserver option in netscaler_cs_vserver
Add documentation for ssl_certkey option in netscaler_cs_vserver

* Add options for gracefully disabling netscaler_server

* Add "state" suboption for netscaler_servicegroup servicemembers
Fix servicemember modification algorithm in netscaler_servicegroup
Fix monitorbindings modification algorithm in netscaler_servicegroup
2018-02-06 19:11:44 +00:00
Alex Stephen
9706abf685 [cloud] New GCP module: DNS Managed Zones (gcp_dns_managed_zone.py) (#35014) 2018-02-06 11:50:16 -05:00
Toshio Kuratomi
a5b80464df Fix packaging/os modules for wildcard imports and get_exception 2018-02-06 08:44:49 -08:00
Anil Kumar Muraleedharan
5c50720325 Changing ENOS action plugin license from BSD to GPL (#34888)
* Changing BSD to GPL

* Updating License Information

* Updating Copyright year to 2017

* Changed copy right info
2018-02-06 21:47:56 +05:30
Abhijeet Kasurde
1119709b56 Remove get_exception from modules
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-06 07:49:24 -08:00
Giovanni Sciortino
fb2c0181c5 Fixes: #20986 blockinfile create undelying directory when create=true (#27961) 2018-02-06 09:48:15 -06:00
tterranigma
14841e453a Fix config option descriptions (#35638)
* Fix config option descriptions

* Better describe ANSIBLE_PRIVATE_ROLE_VARS
2018-02-06 09:59:47 -05:00
chifu1234
98f804ecb4 nxos_facts: svi support ipv4 (#35222)
* nxos_facts: svi support ipv4

* nxos_facts: copy paste error

* https://app.shippable.com/github/ansible/ansible/runs/51845/1/tests

* E111 indentation is not a multiple of four

* Update nxos_facts.py
2018-02-06 19:40:12 +05:30
Bruno
dea860aff6 added aci_switch_policy_vpc_protection_group module (#35769)
* added aci_switch_policy_vpc_protection_group module

* Small change wrt. new interface
2018-02-06 12:37:46 +01:00
Abhijeet Kasurde
4ac92c97a3 VMware: Detect SDRS for datastore cluster (#35644)
This fix adds a fallback mechanism where Storage Datacluster
is not enabled with SDRS. If user has Storage Datacluster without SDRS
then we will not get any datastore recommendation. This will fallback to
normal datastore selection method.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-06 06:34:53 -05:00
Kai
f30a08d049 Add vfat support for the filesystem module (#23527)
* Add fat filesystem support

fatresize is temporarily disabled

* Refactor Filesystem.get_dev_size

For more sharing with vFAT class

* Fix filesystem tests on some OSs

I think this is due to older mke2fs on those systems.

* Fix vFAT command on FreeBSD

newfs doesn't seem to work on image files

* Refactor filesystem.grow()

Split out grow_cmd generation and Device operations

* Use swap as unsupported filesystem

Except FreeBSD, which doesn't have mkswap

* Be consistent about str(dev) vs dev.path

Prefer str(dev), this works transparently with '%s' formatting.

* Enable vfat resize, only test fatresize >= 1.0.4

Lower versions have a segfault bug.

* Only install fatresize where available

FreeBSD, OpenSUSE, RHEL and CentOS < 7 don't ship it.
2018-02-06 11:56:43 +01:00
Artem Zinenko
56f640d874 influxdb_user: implement user password change (#35471)
* Added tests on user removing

* Implemented password changing

* Fix after review

* Added zhhuta changes
2018-02-06 11:01:51 +01:00
Martin Perina
138de603d9 Fix the oVirt high_performance VM type description. 2018-02-06 03:38:12 -05:00
Yaniv Kaul
56ce2773c5 Adds the oVirt High Performance (high_performance) VM type. 2018-02-06 03:38:12 -05:00
Ganesh Nalawade
df5fc7af67
Fix ios enable password regex in terminal plugin (#35741)
Fixes #33993

On some ios devices the enable password prompt does not
end with a space, add a fix to handle this scenario.
2018-02-06 12:10:32 +05:30
Abhijeet Kasurde
575e9e9294 FreeIPA: Add Env variable as module parameter (#35391)
This fix adds environment variable fallback method to read
argument parameters if user has not specified.

Fixes: #35368

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-06 00:00:16 -05:00
Abhijeet Kasurde
6bd0fbb63c Remove deprecated get_exception API
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-05 23:39:56 -05:00
Sylvain Rabot
caefe31125 Fix typo in azure_rm_subnet (#35731)
Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
2018-02-06 09:40:05 +05:30
root
1f30ecef02 add support for configuring smtpport in callback_mail 2018-02-05 22:58:38 -05:00
Dirk Götz
7c998027c0 Add the option to use config file instead of enviroment variables (#32497)
and some error handling for the requests
2018-02-05 22:19:56 -05:00
Andrew Gaffney
e9b0a4ccb4 Add support for defining index var for task loops 2018-02-05 22:14:05 -05:00
Matt Martz
7be8079bad Add configurable blacklist filtering for python logger 2018-02-05 22:12:16 -05:00
Abhijeet Kasurde
635036fb62
VMware: Add new module : vmware_host_firewall_manager (#35596)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-06 08:29:56 +05:30
Sam Doran
636ef65099 Fix panos_object docs so they generate properly (#35756)
Change description field to a list rather than folder scalar.

Cleanup formatting and line breaks in README.
2018-02-05 18:49:02 -07:00
Zim Kalinowski
86c62e228d [new module] azure_rm_keyvault (#35150)
* updates to azure_rm_keyvault

* updates to azure_rm_keyvault

* updates to azure_rm_keyvault

* updates to azure_rm_keyvault

* updates to azure_rm_keyvault

* updates to azure_rm_keyvault

* updates to azure_rm_keyvault

* updates to azure_rm_keyvault

* updates to azure_rm_keyvault

* updates to azure_rm_keyvault

* updates to azure_rm_keyvault

* updates to azure_rm_keyvault

* updates to azure_rm_keyvault

* fix update bugs, add update test
2018-02-05 16:08:22 -08:00