ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity
27949 commits 10 branches 167 tags 272 MiB
Commit graph

1905 commits

Author SHA1 Message Date
James Cammarata
159aa26b36 FEATURE: adding variable serial batches 
This feature changes the scalar value of `serial:` to a list, which
allows users to specify a list of values, so batches can be ramped
up (commonly called "canary" setups):

- hosts: all
  serial: [1, 5, 10, "100%"]
  tasks:
  ...
 2016-08-04 15:04:10 -05:00
Matt Clay
5f12731797 Run more integration tests on FreeBSD. (#16923) 2016-08-02 14:00:56 -07:00
Matt Clay
00fbc76e69 Increase async time limit on tests to 10 seconds. (#16921) 2016-08-02 13:30:26 -07:00
Matt Clay
ff4f4bc8a0 Add binary module tests to Windows CI. (#16914) 2016-08-02 10:42:07 -07:00
Matt Clay
17e4629d52 Add remote CI support for modules. (#16908) 2016-08-01 15:39:17 -07:00
Matt Clay
e2602e9be0 Add FreeBSD to Shippable CI. (#16883) 2016-08-01 13:46:37 -07:00
Matt Clay
6dc148d82c Download files from S3 to improve reliability. (#16891) 
Binary module tests now download pre-compiled binaries from S3
instead of downloading go and compiling the modules.

Files downloaded form SourceForge are now downloaded from S3.
 2016-07-31 08:48:32 -07:00
Gennady Trafimenkov
2bc679be07 Testing that service not enabled during check run (#16739) 
* Enabled more tests in test_service on systems with systemd.
* Fix inconsistency in cleaning up test service. The conditions for service setup and service cleanup were different.
* Add check mode run for service enable.
 2016-07-29 08:35:03 -07:00
Matt Clay
380ed053e8 Add Windows integration tests to Shippable. (#16803) 
Enable Windows integration tests on Shippable.
 2016-07-28 21:03:14 -07:00
William Albert
409d95d67e Refactored gce util module to support other GCP services (#15924) 
This is a refactoring of the existing GCE utility module to support other projects on Google Cloud Platform.

The previous gce.py module was hard-coded specifically for GCE, and attempting to use it with other projects in GCP failed.

See https://github.com/ansible/ansible/pull/15918#issuecomment-220165913  for more detail.

This has also been an issue for others in the past, although they've handled it by simply
duplicating some of the logic of gce.py in their own modules.

-   The existing gce.py module was renamed to gcp.py, and modified to remove any 
     imports or other code that refers to libcloud.compute or GCE (the GCE_* params were
     retained for compatibility). I also renamed the gce_connect function to gcp_connect, 
     and modified the function signature to make supplying a provider, driver, and agent 
     information mandatory.

-  A new gce.py module was created to handle connectivity to GCE. It imports the
   appropriate libcloud.compute providers and drivers, and then passes them on
   to gcp_connect in gcp.py. The constants and function signatures are the same
   as the old gce.py, so compatibility with existing modules is retained.

- A new gcdns.py module was created to support PR ansible/ansible-modules-extras#2252
  for two new Google Cloud DNS modules, and to demonstrate support for a non-GCE 
  Google Cloud service. It follows the same basic structure as the new gce.py module,
  but imports from libcloud.dns instead.
 2016-07-28 12:54:39 -04:00
Gennady Trafimenkov
ad24f2d206 Enable color output from integration tests in Docker containers (#16660) 
Enable color output from integration tests in Docker containers:

* In run_tests.sh when output is attached to a terminal.
* In shippable/integration.sh using force mode (can be disabled).

Also fix blocks tests to work with or without color output
 2016-07-25 14:07:15 -07:00
Matt Clay
9497a814a8 Add apache2 to improve test speed and reliability. (#16819) 2016-07-25 07:19:49 -07:00
Brian Coca
e2f17f8d9b set cwd to task's basedir (#16805) 
* switch cwd to basedir of task

This restores previous behaviour in pre 2.0 and allows for 'local type' plugins
and actions to have a more predictable relative path.

fixes #14489

* removed FIXME since prev commit 'fixes' this

* fix tests, now they need a loader (thanks jimi!)
 2016-07-25 08:11:45 -04:00
Matt Martz
4065acc37d indent callback output if using 3verbosity or higher (#16231) 2016-07-23 18:10:53 -04:00
Robin Roth
2b28beb1d7 add check_mode option for tasks (#16056) 
* add check_mode option for tasks

includes example testcases for the template module

* extend check_mode option

* replace always_run, see also proposal rename_always_run
* rename always_run where used and add deprecation warning
* add some documentation

* have check_mode overwrite always_run

* use unique template name to prevent conflicts

test_check_mode was right before, but failed due to using the same filename as other roles

* still mention always_run in the docs

* set deprecation of always_run to version 2.4

* fix rst style

* expand documentation on per-task check mode
 2016-07-22 20:40:14 -04:00
s-hertel
93c5ec42cf Test GalaxyCLI when no actions are provided 
Adds a new test for GalaxyCLI. Tests cases when:

- no actions are provided
- invalid actions are provided
- each valid action is provided

When parser() runs successfully the method returns True, creates a
SortedOptParser instance, a Galaxy instance, and updates certain class data.
 2016-07-22 14:39:01 -04:00
s-hertel
671f9c3d15 Merge pull request #16783 from s-hertel/test_display_galaxy_info_fix 
fixing a logic error in test_galaxy
 2016-07-21 15:22:07 -04:00
s-hertel
3cb5747f54 fixing a logic error in test_galaxy 2016-07-21 15:02:19 -04:00
s-hertel
aae5e50299 Adding a test for GalaxyCLI. Tests exit_without_ignore method. 2016-07-21 13:53:44 -04:00
Christoph Dittmann
d55452d3ed Adding unit tests for role variable precedence 
Originally from PR #16735
 2016-07-20 10:14:44 -04:00
Matt Clay
4cc4dc6793 Add postgresql dependencies to opensuseleap. 2016-07-18 16:55:10 -04:00
nitzmahone
7aa39981c4 fix setup test for renamed windows fact 2016-07-14 18:02:04 -07:00
jctanner
238c6461f6 Add a function to check for killed processes in all strategies (#16684) 
* Add a function to check for killed processes so that if any
threads are sigkilled or sigtermed, the entire playbook execution is aborted.
 2016-07-14 16:37:35 -04:00
James Cammarata
153133132d Updating tests for new module feature for remote_src in unarchive 
Fixes #10218
 2016-07-14 12:15:17 -05:00
Toshio Kuratomi
c8a8f546d4 A little unittest refactoring (#16704) 
A little unittest refactoring

* Add a class decorator to generate tests when using a unittest.TestCase base class
* Add a TestCase subclass with setUp() and tearDown() that sets up
  module parameter parsing
* Move test_safe_eval to use the class decorator and ModuleTestCase base
  class
* Move testing of set_mode_if_different into its own file and separate
  some test methods out so we get better errors and more coverage in
  case of errors.
* Naming convention for test cases doesn't need to duplicate information
  that's already in the file path.
 2016-07-14 09:22:54 -07:00
James Cammarata
221520cbad Fixing type in 293723f (mock_handler -> mock_handler_task) 2016-07-12 17:00:29 -05:00
James Cammarata
0ea2b2a6af Fix unit test for base strategy in regards to handler changes 2016-07-12 16:50:10 -05:00
s-hertel
e84ab95733 Fixing bug in GalaxyCLI test; creates temp dir for role_path instead … (#16689) 
* Fixing bug in GalaxyCLI test; creates temp dir for role_path instead of installing to /etc/ansible/roles

* Update test_galaxy.py
 2016-07-12 16:01:47 -04:00
nitzmahone
de549ad675 update action unit test for powershell shebang behavior 2016-07-11 12:38:18 -07:00
s-hertel
9c925eeeab Adding a test for GalaxyCLI and two methods on which it depends. Tes… (#16651) 
* Adding a test for GalaxyCLI and two methods on which it depends. Tests execute_info method.

*  Adding a test for GalaxyCLI and two methods on which it depends. Tests execute_remove method.

* Update test_galaxy.py

* Revising test for GalaxyCLI execute_remove.

* Removing mocks
 2016-07-11 13:54:29 -04:00
Matt Clay
0ada7eae5e Add test tags for shell and command modules. 2016-07-08 17:41:58 -07:00
=
3c66caa058 fix win_msi tests by setting wait: true on all win_msi tasks. 
I suspect this problem was masked previously as older versions of pywinrm
where significantly slower, allowing more time for the windows installer service to complete.
 2016-07-08 06:46:27 +01:00
Matt Clay
bbffa0a0e9 Add tags for modules without dedicated test roles. 2016-07-07 12:42:07 -07:00
James Cammarata
cd4412016a Updating integration tests for async testing 2016-07-07 13:48:11 -05:00
Matt Davis
30c63a41e9 Merge pull request #16555 from matsu-chara/fix-error-msg-default-to-defaults 
fix default/main.yml to defaults/main.yml
 2016-07-07 11:14:54 -07:00
Matt Clay
9a6b8ab271 Add more tags to test_async role. 2016-07-07 10:38:41 -07:00
Matt Clay
fdf22b5a40 Support module tests on a single image. (#16620) 2016-07-06 23:37:56 -07:00
Matt Clay
696feacbb6 Add script to generate module tests. (#16617) 2016-07-06 20:07:33 -07:00
Robin Roth
d0ccedc617 Fix git shallow update (#16224) 
* add git shallow fetch test

covers https://github.com/ansible/ansible-modules-core/issues/3782

updating a repo with depth=1 fails silently if version==HEAD

* raise git version support supporting depth to 1.9.1
 2016-07-05 15:07:42 -04:00
Robin Roth
1f04130c00 add more distribution version tests (#16563) 
* ubuntu 16.04
* solaris 10, 11
* fedora 22, 25

Thanks Peter Oliver for providing the test data
 2016-07-04 15:57:57 +02:00
Robin Roth
8021adfe97 use git-core ppa instead of menulibre 
menulibre is no longer actively maintained and does not support 16.04
 2016-07-03 15:18:08 +02:00
Robin Roth
a5e394d23a reenable apt_repository tests in ubuntu 16.04 
fixes #15718
 2016-07-03 14:43:04 +02:00
matsu-chara
9f8b0cabcd fix default/main.yml to defaults/main.yml 2016-07-02 21:16:33 +09:00
Matt Clay
4e369a31db Fix test_async. (#16552) 
* Conditionally run test_async in docker containers.
* Revise test_async test.
 2016-07-01 17:59:06 -07:00
Matt Clay
292785ff2b Parse async response in async action. (#16534) 
* Parse async response in async action.
* Add async test for non-JSON data before module output.
* Fix existing async unit test.

Resolves #16156
 2016-07-01 14:52:45 -07:00
Abhijit Menon-Sen
950cc26aab Use loop_control.loop_var directly 
6eefc11c converted task.loop_control into an object, but while the other
callers were updated to use .loop_var instead of .get('loop_var'), this
site was overlooked.

This can be reproduced by including with loop_control a file that does
set_fact; a simple regression test along these lines is included.
 2016-07-01 07:03:42 +05:30
Matt Clay
fbfadc47c7 Update shippable shared dir for COPY_SOURCE. (#16511) 
Tests now use '/shared' instead of '/tmp/shared-dir' when using
COPY_SOURCE. This avoids issues with containers purging '/tmp'.
 2016-06-29 15:09:40 -07:00
Matt Clay
f1e1558f4f Unpin yamllint now that version 1.3.2 is out. (#16479) 
The newer version of yamllint fixes the UnicodeEncodeError
which previously required pinning the version to 1.2.2.
 2016-06-28 11:40:14 -07:00
jctanner
4ba60d00c8 Refactor the parameter splitting in ini lookup to handle more path formats (#16477) 
Refactor the parameter splitting in ini lookup to handle more path formats.

Fixes #16468
 2016-06-28 13:24:57 -04:00
Matt Clay
394430a61e Switch test_lookups to badssl/local testing. (#16466) 
* Switch test_lookups to badssl/local testing.
* Use var for checking badssl host content.
 2016-06-27 18:58:13 -07:00
Matt Clay
81a49912b0 Pin yamllint to 1.2.2 to avoid issues in 1.3.0. (#16464) 
This also moves shippable test requirements to external files.
 2016-06-27 16:34:19 -07:00
Pilou
b361bf90d7 Lookup password omit salt (#16361) 
* Lookup unencrypted password must not include salt
* Integration test lookup: remove previous directory
* Test that lookup password doesn't return salt
* Lookup password: test behavior with empty encrypt parameter

Closes #16189
 2016-06-27 10:44:25 -07:00
Matt Clay
1b29c87936 Test ansible version and ping during sanity tests. (#16441) 2016-06-24 19:32:54 -07:00
YueMing Qin
310692abe0 Changes to be committed: (#16430) 
renamed:    lookup_pipe.py -> lookup_pipe.yml
 2016-06-24 10:26:51 -04:00
nitzmahone
1f92ade584 add integration test to assert included tasks run in proper order 2016-06-23 17:53:08 -07:00
Matt Clay
8a55a446bf Fix fedora23 Dockerfile after fedora:23 updates. 2016-06-22 19:21:40 -07:00
Pilou
7ffbbd34f4 Add python-passlib to docker images. (#16376) 
Related to #16361
 2016-06-22 13:30:10 -07:00
Matt Clay
7de23a1c5b Update opensuseleap Dockerfile. 
- Do not update base image packages unnecessarily.
- Fix incorrect package names.
- Remove commented out RUN statements.
- Sort list of packages to install.
 2016-06-21 17:46:30 -07:00
jctanner
b7f9037b5b Add test for multi-options in authorized_key (#16375) 
Addresses https://github.com/ansible/ansible-modules-core/issues/1715
 2016-06-20 21:12:45 -04:00
James Cammarata
ca6ee4c789 FEATURE: handler listeners 
Fixes ansible/proposals#8
 2016-06-20 09:30:20 -05:00
James Cammarata
8218591fec Track notified handlers by object rather than simply their name 
Due to the fact that roles may be instantiated with different sets of
params (multiple inclusions of the same role or via role dependencies),
simply tracking notified handlers by name does not work. This patch
changes the way we track handler notifications by using the handler
object itself instead of just the name, allowing for multiple internal
instances. Normally this would be bad, but we also modify the way we
search for handlers by first looking at the notifying tasks dependency
chain (ensuring that roles find their own handlers first) and then at
the main list of handlers, using the first match it finds.

This patch also modifies the way we setup the internal list of handlers,
which should allow us to correctly identify if a notified handler exists
more easily.

Fixes #15084
 2016-06-20 09:30:20 -05:00
Nate Coraor
706778ee7f Fix distro detection for Solaris derivatives 2016-06-17 16:54:52 -04:00
nitzmahone
7bc3be64ae fix win_setup integration test to match fact name 2016-06-17 12:28:32 -07:00
=
9857af2b6e added further tests for win_regedit to cover the changes made 
under https://github.com/ansible/ansible-modules-extras/pull/2436
 2016-06-16 06:37:49 +01:00
jctanner
587d3c368b Fix synchronize+vagrant dest assertions that were incorrect. (#16291) 
Addresses #16284
 2016-06-14 19:56:50 -04:00
Matt Clay
cabbafb650 Update Fedora and CentOS docker images. 
- Reduce image size by skipping weak package references.
- Consolidate and sort packages to install.
- Improve consistency between versions.
- Combine yum/dnf install and clean to avoid unwanted caching.
- Don't update existing packages from base image unnecessarily.
 2016-06-14 16:15:49 -07:00
Matt Clay
82b978e186 Add curl to Ubuntu docker images. 2016-06-13 20:06:26 -07:00
Matt Clay
349b06974e Update Ubuntu docker images. 
- Reduce image size by skipping recommended packages.
- Consolidate and sort packages to install.
- Improve consistency between Ubuntu versions.
- Combine apt-get update and install to avoid caching stale updates.
 2016-06-13 19:13:44 -07:00
Matt Clay
2f1fc5a324 Update integration test runner on shippable. 2016-06-13 18:06:55 -07:00
Matt Clay
62e6f6b885 Add junit-xml to docker images. 2016-06-13 15:06:51 -07:00
jctanner
3b3ab605f6 Add a get_url test for www.google.com (#16212) 
Add a get_url test for www.google.com

Addresses #16191
 2016-06-13 10:59:42 -07:00
Dag Wieers
d91df20620 Fix unit tests for module_name commit #16087 2016-06-10 21:13:34 +02:00
Brian Coca
a529a60478 raw should not use default executable (#16085) 
also removed unused cruft in script
 2016-06-10 11:37:58 -04:00
Toshio Kuratomi
872f3c5503 Revert "Add git shallow fetch test (#16055)" -- Broke integration tests: 
https://app.shippable.com/runs/57599a7897ae890c00c2898d

This reverts commit e81f14ab48.
 2016-06-09 14:49:42 -07:00
Robin Roth
e81f14ab48 Add git shallow fetch test (#16055) 
* add git shallow fetch test

covers https://github.com/ansible/ansible-modules-core/issues/3782

updating a repo with depth=1 fails silently if version==HEAD

* disable git shallow tests for old git versions

Older git versions don't treat the --depth option correctly.
While the git module tried to work around this and introduced subtle
bugs, ansible/ansible-modules-core#3794 falls back to full checkouts.
Don't run the tests then.
 2016-06-09 09:33:57 -07:00
James Cammarata
fbec2d9692 Expand return code values returned by TQM and strategies 
This allows the PlaybookExecutor to receive more information regarding
what happened internal to the TaskQueueManager and strategy, to determine
things like whether or not the play iteration should stop.

Fixes #15523
 2016-06-08 10:21:57 -05:00
Matt Clay
03597143d0 Detect use of Travis tests on Shippable. 
This can occur when building pre-Shippable branches or PRs.
 2016-06-06 13:36:21 -07:00
James Cammarata
61f132a609 Adding unit tests for playbook group/host vars 2016-06-06 10:52:39 -05:00
Toshio Kuratomi
5a3493be5f Port urls.py to python3 and other byte vs text fixes (#16124) 
* Port urls.py to python3

Fixes (largely normalizing byte vs text strings) for python3

* Rework what we do with attributes that aren't set already.

* Comments
 2016-06-04 16:19:57 -07:00
Matt Clay
6e1e86028f Split integration tests into multiple groups. 
This will allow tests to complete much faster.
 2016-06-04 12:02:11 -07:00
Toshio Kuratomi
73bb06ae84 Fix the code-smell tests for six again 2016-06-04 11:05:21 -07:00
Adrien Vergé
4d48711242 Fix YAML source and check it on Shippable (#15678) 
Fix YAML source and check it on Shippable
 2016-06-04 10:58:17 -07:00
Matt Clay
643a7ec01d Merge pull request #16126 from mattclay/shippable-fix 
Update how shippable scripts are called.
 2016-06-03 10:13:01 -07:00
Matt Clay
7a533406f9 Merge pull request #13145 from Mic92/devel 
lxc connection plugin
 2016-06-03 10:09:04 -07:00
Matt Clay
6d74f43eff Update how shippable scripts are called. 2016-06-03 09:20:33 -07:00
Saran Ahluwalia
fda927a14b added failing test for testing if executable is not empty string 2016-06-02 16:04:15 -07:00
Matt Clay
b0e1efbd62 Add full support for Shippable CI. 2016-06-01 22:33:38 -07:00
Toshio Kuratomi
08fd017d99 Test file needed to be renamed 2016-06-01 13:50:57 -07:00
Toshio Kuratomi
2a5ef4496a Workaround test failures on OSX controllers for now -- will have to look 
more heavily into normailizing the unicode later.
 2016-06-01 13:35:11 -07:00
Toshio Kuratomi
f86df7c88b Test that task.args are also set properly (#15950) 2016-06-01 13:28:57 -07:00
Adrian Likins
644f0fb190 Merge pull request #15178 from alikins/galaxy_info_output 
galaxy info displayed 'galaxy_info' section wrong [fix for #15177]
 2016-06-01 10:27:15 -04:00
Brian Coca
3387d557bc Revert "Add prefixing and suffixing fuctionality to assemble module" (#16084) 2016-06-01 09:17:10 -04:00
Matt Clay
e45b3b89a2 Skip some service tests for systemd. 2016-05-31 20:12:55 -07:00
jctanner
c52cea8db3 Add a framework, fixtures and test for common synchronize scenarios. (#15983) 
* Add a framework, fixtures and test for common synchronize scenarios.

Addresses #15905
 2016-05-31 22:35:59 -04:00
Chris Houseknecht
ce34397cf8 Merge pull request #10399 from underyx/assemble-with-prefix-and-suffix 
Add prefixing and suffixing fuctionality to assemble module
 2016-05-31 18:16:23 -04:00
jctanner
373b23cc24 Fix mock loader for osx /etc symlinks (#16074) 
Fix role based unit tests for osx via mock.patch
 2016-05-31 18:02:39 -04:00
Robin Roth
c06884eff0 Run tests on ubuntu1604 and opensuseleap (#15936) 
* reduce async sleep time in test
* make zypper test less destructive (don't break following uses of zypper)
* fix ca cert on suse
* fix/enable postgres/mysql on opensuseleap
* fix mysql test for mysql versions 5.7.6 and newer
* skip sni_host check on ubuntu1604
* add HTTPTESTER flag for test_uri

ubuntu 16.04 uses dash which drops env variables containing a dot
we work around this by adding an explicit env variable to enable httptester
 2016-05-31 14:47:36 -07:00
Bence Nagy
13210e346f Add integration test for assemble with a header and a footer 2016-05-31 14:44:33 -07:00
Matt Clay
027006b846 Don't use TEST_FLAGS for the test_tags target. 
This allows use of --skip-tag in TEST_FLAGS without conflicting with the test.
 2016-05-31 14:35:24 -07:00
Matt Clay
844b415066 Mark tasks expected to fail with EXPECTED FAILURE. 
This allows for automated identification of tasks which are
expected to fail, but which cannot use ignore_errors because
they need to fail.
 2016-05-31 11:29:04 -07:00
Adrian Likins
1468538414 galaxy info displayed 'galaxy_info' section wrong 
The output of 'ansible-galaxy info' was formatting the
'galaxy_info' key with one char per line.

Previously, when building the output string, items in
role_info that had a dict for value, the label for
it's key ('galaxy_info' for ex) was being added to
the text list in addition to being appended. Only
the append is needed.

Also added a unit test in test/units/cli/test_galaxy.py,
but skip it on py3 until galaxy is py3 compatible.

fixes #15177
 2016-05-31 13:28:15 -04:00
jctanner
018d3c3118 Add a new vmware inventory script backed by pyvmomi (#15967) 
Add a new dynamic vmware inventory script backed by pyvmomi
 2016-05-30 20:41:48 -04:00
Jörg Thalheim
88482234e6
lxc connection plugin 2016-05-28 00:15:09 +02:00
Toshio Kuratomi
c03555b650 Fix unarchive failures when the destination is a symlink to a directory (#15999) 
Also add integration tests for this problem and unicode filenames inside
a tarball.

Fixes #3725
 2016-05-26 14:47:11 -07:00
Matt Clay
b755bcd875 Corrected reference to httptester container. 2016-05-26 12:39:57 -07:00
Matt Martz
164f247ec8 Add httptester docker container files and update run_tests.sh to use ansible/httptester 2016-05-26 13:09:28 -05:00
Brian Coca
329c62e914 docker was deprecated, test now reflects new name 2016-05-26 09:12:23 -04:00
Toshio Kuratomi
650bfdce8f Update grep for six to not falsely trigger when six is only a substring of a different library 2016-05-24 13:49:37 -07:00
Robin Roth
0edec45c3d install packages for tests (#15979) 
* curl is needed for test_binary_modules
* glibc-i18ndata is needed for postgresql (localedef)
 2016-05-24 08:22:34 -07:00
John R Barker
1861151fa4 [WIP] Extra test and build dependencies in Docker images (#15692) 
* Merge conflicts:

* [skip ci] Revert changes to run_tests.sh

gundalow will update this in a different PR

* [skip ci] Add in ubuntu1604 and opensuseleap

NOTE: We are not configuring anything to use these new images yet.
Therefore no impact on Travis performance

* python-mysql for opensuse

* It's mysql-server on centos6
 2016-05-20 07:37:06 -07:00
Toshio Kuratomi
b41b6b2ec5 Update test off make_become for ssh pty race mitigation (#15931) 2016-05-19 15:17:28 -07:00
nitzmahone
42f6114b61 fix windows integration tests to run under kerberos users 2016-05-17 13:40:54 -07:00
Michael Scherer
376fc21f92 Add a exception for module_utils/six.py regarding code smell (#15878) 
Since six replace urlopen, it is normal to trigger the test,
hence the exception
 2016-05-16 17:00:21 -07:00
Michael Scherer
cc61531a74 Do not test vca and vmware.py for py2.4 (#15887) 
Since both of them depend on libraries not
working on python 2.4, we shouldn't restrict
ourself on 2.4, cf https://github.com/ansible/ansible/pull/15870
 2016-05-16 10:51:48 -04:00
Robin Roth
85477fa215 Don't use 'from ansible.module_utils import foo' style here as it breaks (#15756) 
py.test"
 2016-05-13 21:09:13 -07:00
Toshio Kuratomi
c1cc9f1f23 Merge pull request #15845 from abadger/ziploader-constants 
Ship constants to the modules via internal module params rather than a secondary dict
 2016-05-13 10:03:16 -07:00
Toshio Kuratomi
186337db28 Ship constants to the modules via internal module params rather than a secondary dict. 2016-05-12 20:30:05 -07:00
Matt Davis
bc7405efc9 Merge pull request #15797 from robinro/patch-1 
reduce async timeout in unittests
 2016-05-12 17:19:10 -07:00
Matt Martz
196453b9b2 Merge pull request #13771 from sivel/binary-modules 
First pass at allowing binary modules
 2016-05-12 18:36:34 -05:00
Matt Martz
651b83d8be Run test_binary_modules 2016-05-12 12:53:44 -05:00
Matt Martz
0faddfa168 Move binary module detection into executor/module_common.py 2016-05-12 12:25:09 -05:00
Matt Martz
3466e73c50 Resolve test failures 2016-05-12 12:25:09 -05:00
Matt Martz
2d18607f1e Add GPL3 header to helloworld.go 2016-05-12 12:25:09 -05:00
Matt Martz
6ad8ec0919 Add integration tests for binary modules 2016-05-12 12:25:09 -05:00
Toshio Kuratomi
292f0ed0d6 If we can't squash for any reason, then simply do not optimize the items loop. 
Also add more squashing testcases

Fixes #15649
 2016-05-12 10:06:18 -07:00
Toshio Kuratomi
8a184381af Strip junk after JSON return. (#15822) 
Fixes #15601
 2016-05-11 17:54:01 -07:00
James Cammarata
67c32ac30a Merge branch 'samples-to-test' of https://github.com/dagwieers/ansible into dagwieers-samples-to-test 2016-05-11 09:57:21 -04:00
Matt Martz
accf40d8a8 Use httptester docker image for http tests (#15811) 
* Use httptester docker image for http tests

* When not running with an httptester linked container, use public test sites
 2016-05-10 23:43:07 -04:00
Toshio Kuratomi
c730af5dc2 Remove reload from arg related tests. Changes to how ziploader passes args mean we don't need reload anymore. (#15782) 2016-05-10 08:13:48 -07:00
Toshio Kuratomi
7ccb08cc7e Switch to a different url for testing SNI right now. (#15798) 2016-05-10 07:08:47 -07:00
Robin Roth
254cf9ea68 reduce async timeout 
reduce from 3 sec to 0.1 sec; the 3 sec sleep was about half of the total unittest time on my development machine...
 2016-05-10 08:09:28 +02:00
Toshio Kuratomi
5c7ad654db Add some more tests for item squashing 2016-05-05 20:33:44 -07:00
nitzmahone
133395db30 add jimi-c's unit test for squashed skip results, tweaked is_skipped() logic to pass 2016-05-05 15:29:10 -07:00
Brian Coca
2af8e3b9d8 fix default for removing images 2016-05-05 16:00:02 -04:00
Brian Coca
27a1ae4732 added ability to also subset make tests 2016-05-05 11:50:39 -04:00
Rene Moser
5583027f99 tests, postgresql: add ubuntu 16.04 support 2016-05-04 00:11:19 +02:00
Rene Moser
39e4caafb2 tests, apt_repository: disable Ubuntu 16.04 as there is no package yet 2016-05-04 00:11:19 +02:00
Rene Moser
c20d1fced7 tests: fix tests on Debian 8 2016-05-04 00:11:19 +02:00
Robin Roth
cf62a62b83 use userdir module as example instead of alias (#15540) 
* alias module is very basic and removing it leads to the suse default
  config failing
* future improvements might test different modules and the effect of
  them being removed
 2016-05-04 00:09:26 +02:00
Brian Coca
47d58c30e4 another var 'defaulted' in run_tests 2016-05-03 11:25:21 -04:00
Brian Coca
3669ab2456 added defaults for 'optional' vars 2016-05-03 10:38:54 -04:00
Brian Coca
52a714143f fine tuned shell switches for run_tests.sh 2016-05-03 09:39:19 -04:00
Yannig
3901556b35 When var name is the same as var content, try to template it before reporting that var is not defined. (#13629) 
* When var name is the same as var content, try to template it before reporting that var is not defined.
Add asserts in test_var_blending to check this special corner case.

* Fix integration tests when using debug with list or dict.
 2016-05-01 06:42:09 -07:00
Robin Roth
1d6608e84f Dist version fix for Red Hat and more tests (#15663) 
* add tests for centos6, rhel6 and rhel7

* gen_distribution_version_testcase with python2.6

* remove unused imports

* fix redhat/vmware/... parsing

* add centos7 test case
 2016-04-29 13:18:50 -07:00
Toshio Kuratomi
1b78fd57b1 Merge pull request #15656 from abadger/ziploader-namespace 
Fix ziploader for the cornercase of ansible invoking ansible.
 2016-04-29 11:12:11 -07:00
Matt Davis
ca5080d56b Merge pull request #15570 from jhawkesworth/regedit_fix_str_compare_tests 
win_regedit integration test to cover change to allow empty string comparison
 2016-04-29 11:03:30 -07:00
Toshio Kuratomi
487e6562ca Fix ziploader for the cornercase of ansible invoking ansible. 
* Make ziploader's ansible and ansible.module_utils libraries into
  namespace packages.
* Move __version__ and __author__ from ansible/__init__ to
  ansible/release.py.  This is because namespace packages only load one
  __init__.py.  If that is not the __init__.py with the author and
  version info then those won't be available.
* In ziplaoder, move the version ito ANSIBLE_CONSTANTS.
* Change PluginLoader to properly construct the path to the plugins even
  when namespace packages are present.
 2016-04-29 08:47:49 -07:00
Toshio Kuratomi
d652b2edc0 Fix for unittests on python2.6 or less 2016-04-27 10:45:39 -07:00
Robin Roth
12f7f50f31 extend zypper integration tests (#15596) 
* extend zypper integration tests

* fix caching issue of local RPMS on openSUSE 42.1 Leap
* add tests for simultaneous install/remove via prefixes +-
* test fail cases (rm patch or URL)
* test patch install (succes, unchanged second run, fail on wrong name)

* add test for pattern install
 2016-04-27 08:04:58 -07:00
Toshio Kuratomi
7e1fbe2e03 Some algorithmic unittests for the apt and docker modules 2016-04-27 07:23:31 -07:00
Toshio Kuratomi
e4a1622f53 Do not check docker or azure module_utils code for py2.4 compat (the libs require py2.6+) 2016-04-26 07:21:36 -07:00
Toshio Kuratomi
85bef402b1 Merge pull request #14614 from gundalow/test_binary 
non-destructive says we should run test_binary at v2
 2016-04-25 09:45:00 -07:00
Tegan Snyder
bf0da4aa3c add centrify dzdo escalation (#15219) 
add dzdo context, and test
 2016-04-25 11:24:26 -04:00
=
bd74091ed9 win_regedit integration test to cover change to allow empty strings to be compared 2016-04-24 17:24:03 +01:00
Toshio Kuratomi
44e21f7062 Allow AnsibleModules to be instantiated more than once in a module 
Fix SELINUX monkeypatch in test_basic
 2016-04-23 14:04:45 -07:00
jctanner
4d36b3f7b6 Extend the get_url integration tests to include file schemas. (#15532) 
Addresses https://github.com/ansible/ansible-modules-core/issues/3511
 2016-04-22 11:38:03 -07:00
Toshio Kuratomi
e893b65a9b Don't pick up whole commented lines in the urlopen code-smell tests 2016-04-22 08:24:56 -07:00
Robin Roth
7a4e4c2b02 extend integration test for zypper_repository (#15387) 
* include options refresh and priority introduced in ansible/ansible-modules-extras#1990
* test repo update both based on name and URL
* run on all suse flavors
* test overwriting repos by url or name
 2016-04-21 20:10:29 +02:00
Robin Roth
59bad647b6 Revert "Disable new git tests until a fix for rhel6/7 is merged." 
This reverts commit 197d3dfe97.
 2016-04-20 09:52:02 +02:00
Toshio Kuratomi
03126f7097 Fix cut and paste error of test code 2016-04-19 10:38:44 -07:00
Toshio Kuratomi
197d3dfe97 Disable new git tests until a fix for rhel6/7 is merged. 2016-04-19 08:53:19 -07:00
Toshio Kuratomi
0a31c24938 Merge pull request #15419 from nitzmahone/module_debug_arg_override 
add _load_params debug overrides for module args/file passed on cmdline
 2016-04-19 07:49:05 -07:00
Brian Coca
33761efd19 Merge pull request #15417 from bcoca/copy_vaulted 
Copy vaulted
 2016-04-19 10:22:30 -04:00
Robin Roth
e8b1c4e14a add test for git with both depth and version arguments (#15471) 
* add test for ansible/ansible-modules-core#3456

combination of options version and depth

* add test of switching to older branch
 2016-04-19 07:00:45 -07:00
Matt Davis
822f904aa6 Merge pull request #14813 from mattclay/lxd-plugin 
Add lxd connection plugin.
 2016-04-19 02:06:31 -07:00
James Cammarata
6eefc11c39 Make the loop variable (item by default) settable per task 
Required for include+with* tasks which may include files that also
have tasks containing a with* loop.

Fixes #12736
 2016-04-19 01:42:40 -04:00
nitzmahone
5b336832af add _load_params debug overrides for module args/file passed on cmdline 
Updated python module wrapper explode method to drop 'args' file next to module.
Both execute() and excommunicate() debug methods now pass the module args via file to enable debuggers that are picky about stdin.
Updated unit tests to use a context manager for masking/restoring default streams and argv.
 2016-04-18 11:06:46 -07:00
Matt Davis
6322ed833e Merge pull request #15422 from jhawkesworth/win_regedit_binary_tests 
Windows: add win_regedit integration tests (needs https://github.com/ansible/ansible-modules-extras/pull/2034)
 2016-04-18 10:56:30 -07:00
James Cammarata
ed35e8bce2 Don't override the http status code when successful in urls.py 2016-04-18 13:20:24 -04:00
Toshio Kuratomi
7833b5bec4 Merge pull request #15420 from robinro/distribution_version_tests 
Distribution version tests
 2016-04-18 10:05:55 -07:00
Robin Roth
9bb069f873 Apache2 module integration test (#15380) 
* add integration test for apache2_module

* fix assert syntax

* check os_family for this test

* add comment why only debian and suse are tested

* move apache2 test to destructive

* install apache2 package
 2016-04-18 18:00:02 +02:00
Matt Clay
5fc76df18b Add lxd connection plugin. 2016-04-15 19:10:57 -07:00
Matt Martz
a985bf6a31 Don't pass context to urlopen, instead add it to the handlers. Fixes https://github.com/ansible/ansible-modules-core/issues/3437 2016-04-15 16:10:54 -05:00
Robin Roth
49cdc565c5 remove nose.tools use 2016-04-15 19:40:08 +02:00
Robin Roth
4088aa2b4c get rid of assert_in 2016-04-15 19:30:49 +02:00
Robin Roth
692bf51fde move gen_testcase to hacking/tests 
* also use json instead of pprint
 2016-04-15 17:14:43 +02:00
Robin Roth
37188ea336 cleanup tests 
* use nose test generator
* more comments
* move facts import inside the skipped function, fix python3 warning
 2016-04-15 17:14:14 +02:00
Robin Roth
2b104fe6ad fix tests for SLES and CoreOS 
* include #15230
 2016-04-15 17:13:59 +02:00
Robin Roth
b48e628429 test git version before running test on depth 2016-04-15 09:49:05 +02:00
=
157072a39f Windows: win_regedit integration tests (following https://github.com/ansible/ansible-modules-extras/pull/2034 ) 2016-04-14 21:47:17 +01:00
Cambell
cdf6e3e4bf feature/copy-vault-dataloader: Add method get_real_file(file_path) to dataloader 
- get_real_file will decrypt vault encrypted files and return a path to
  a temporary file.

- cleanup_real_file will remove a temporary file created previously with
  get_real_file
 2016-04-14 14:12:48 -04:00
Robin Roth
776bffb52b Expand git integration test (#15391) 
* add testcases to git for depth

* also in combination with refspec, which gets more tricky

* add testcase for ansible/ansible-modules-core#527
 2016-04-14 09:41:10 -07:00
Robin Roth
3c883d8a6d add testcases from refactor PR 2016-04-14 18:26:00 +02:00
Matt Clay
af8258cdf2 Revert "Increase verbosity of connection tests." (#15305) 2016-04-14 11:06:46 -04:00
Toshio Kuratomi
208ad36ce4 Merge pull request #15344 from abadger/ziploader 
Ziploader "recursive imports" and caching
 2016-04-13 10:27:01 -07:00
Jonathon Klobucar
7bee994e1c Fix for serial when percent amount is less than one host (#15396) 
Ansible when there was a percentage that was calculated to be less than
1.0 would run all hosts as the value for a rolling update.

The error is due to the fact that Python will round a
float that is under 1.0 to 0, which will trigger the case of
0 hosts. The 0 host case tells ansible to run all hosts.

The fix will see if the percentage calculation after int
conversion is 0 and will else to 1 host.
 2016-04-13 10:49:38 -04:00
Toshio Kuratomi
75546678d9 Fix unittests 2016-04-12 08:01:07 -07:00
Toshio Kuratomi
dcc5dfdf81 Controller-side module caching. 
This makes our recursive, ast.parse performance measures as fast as
pre-ziploader baseline.

Since this unittest isn't testing that the returned module data is
correct we don't need to worry about os.rename not having any module
data.  Should devise a separate test for the module and caching code
 2016-04-12 08:01:07 -07:00
Matt Martz
dd39f57ae7 Merge pull request #15289 from sivel/sni-urllib3-contrib-try2 
Optional Use of urllib3 for SNI verification
 2016-04-08 11:26:49 -05:00
nitzmahone
698ae7c383 ensure test_win_user fails on bogus error 
We weren't previously checking the error message- it failed as expected, but for the wrong reason.
 2016-04-07 18:24:12 -07:00
Strahinja Kustudić
eed6cf5dad Adds 'ansible_check_mode' boolean magic variable 
* Makes it possible to pass any options variable to VariableManager
  by changing `load_options_vars(options)` in `lib/ansible/utils/vars.py`
 2016-04-08 00:26:02 +02:00
Matt Martz
6e9c09d7f7 Utilize urllib3.contrib.pyopenssl functionality for SNI capability in python versions lacking SNI support 
Also add SNI tests, move test_uri to destructive since we are messing with packages for SNI testing
 2016-04-06 10:14:13 -05:00
Toshio Kuratomi
4b0aa1214c Ziploader 
* Ziploader proof of concept (jimi-c)

* Cleanups to proof of concept ziploader branch:

* python3 compatible base64 encoding
* zipfile compression (still need to enable toggling this off for
  systems without zlib support in python)
* Allow non-wildcard imports (still need to make this recusrsive so that
  we can have module_utils code that imports other module_utils code.)
* Better tracebacks: module filename is kept and module_utils directory
  is kept so that tracebacks show the real filenames that the errors
  appear in.

* Make sure we import modules that are used into the module_utils files that they are used in.

* Set ansible version in a more pythonic way for ziploader than we were doing in module replacer

* Make it possible to set the module compression as an inventory var

This may be necessary on systems where python has been compiled without
zlib compression.

* Refactoring of module_common code:

* module replacer only replaces values that make sense for that type of
  file (example: don't attempt to replace python imports if we're in
  a powershell module).
* Implement configurable shebang support for ziploader wrapper
* Implement client-side constants (for SELINUX_SPECIAL_FS and SYSLOG)
  via environment variable.
* Remove strip_comments param as we're never going to use it (ruins line
  numbering)

* Don't repeat ourselves about detecting REPLACER

* Add an easy way to debug

* Port test-module to the ziploader-aware modify_module()

* strip comments and blank lines from the wrapper so we send less over the wire.

* Comments cleanup

* Remember to output write the module line itself in powershell modules

* for line in lines strips the newlines so we have to add them back in
 2016-04-05 11:06:17 -07:00
jpic
4985411816 Test other use-cases for PluginLoader's config 2016-04-05 14:45:40 +02:00
jpic
da175d0a57 Bugfix: proper plugin configuration was reset 
Before this patch, if config was ['/some/path'] then it would enter the
else block and config would be set to [].

The regression this patch fixes was introduced by 700db154.
 2016-04-05 14:41:49 +02:00
Toshio Kuratomi
4b0f65a3e5 Merge pull request #15207 from mattclay/verbose-test 
Increase verbosity of connection tests.
 2016-03-31 22:02:19 -07:00
Matt Davis
3f70d7a70d Merge pull request #15144 from mattclay/winrm-test 
Add winrm tests and fix exposed unicode errors.
 2016-03-31 16:30:45 -07:00
James Cammarata
180a0a8e77 Fixing up the logic in the test_script tests removal portion 2016-03-31 15:59:19 -04:00
Matt Clay
262c341cda Add connection tests for winrm connection plugin. 
These are the same tests used for the other connection plugins,
adapted to use winrm modules and Windows friendly paths.
 2016-03-31 08:32:41 -07:00
Matt Clay
a0361626c9 Increase verbosity of connection tests. 2016-03-30 06:57:53 -07:00
James Cammarata
5fdac707fd New unit tests for #13630 fix 2016-03-28 15:54:07 -04:00
René Moser
f2a81e580d Merge pull request #15169 from mgruener/test_cloudflare_dns 
Integration tests for the cloudflare_dns module
 2016-03-26 09:39:52 +01:00
James Cammarata
d00ac6e2d1 Merge pull request #15072 from rajatguptarg/fix-requirements 
Add pycrypto as a requirement to run tests
 2016-03-26 00:39:01 -04:00
Michael Gruener
94806e1953 Add integration tests for the cloudflare_dns module 2016-03-25 21:22:29 +01:00
Brian Coca
1ebc2fda71 removes python requirement to script 
mistakenly added when checksum was made to use stat module
fixed assertion in test
 2016-03-24 16:17:58 -07:00
Matt Clay
943e4d37f5 Run more connection tests in Docker. 
Connection tests are now run before non_destructive to make sure
that the known_hosts file in our Docker image has not been removed.
 2016-03-23 21:21:52 -07:00
Toshio Kuratomi
52e9209491 Don't create world-readable module and tempfiles without explicit user permission 2016-03-23 09:52:19 -07:00
Toshio Kuratomi
1802e09b08 Exclude .tox from paths scanned for urlopen 2016-03-23 08:49:37 -07:00
Toshio Kuratomi
d3583108ec Fix log_invocation test on python2 with hash randomization 2016-03-23 08:01:21 -07:00
Matt Martz
ad30bad14f Skip test_module_utils_basic__log_invocation until we can figure out the cause of the failure 2016-03-22 21:59:03 -05:00
Matt Martz
a6d52ce098 Ensure that any command in run_tests.sh that fails results in immediate failure 2016-03-22 20:41:37 -05:00
Toshio Kuratomi
c3548677de Add TEST_FLAGS to test_hash 2016-03-22 13:19:29 -07:00
James Cammarata
6afed7083a Revert "Use docker cp instead of docker volumes to allow for testing with remote docker servers" 
This reverts commit 18599047cd.
 2016-03-22 15:37:47 -04:00
James Cammarata
90ffb8d8f0 Also remove volumes when removing containers 2016-03-22 13:53:54 -04:00
James Cammarata
9a2c1cf94d Force removal of docker container after test ends 2016-03-22 11:45:26 -04:00
Matt Martz
18599047cd Use docker cp instead of docker volumes to allow for testing with remote docker servers 2016-03-22 10:54:57 -04:00
James Cammarata
081c33c451 Adding a docker pull to the run_tests.sh script 2016-03-22 09:49:19 -04:00
James Cammarata
395ff361d4 Adding acl package to all docker images 2016-03-22 07:54:13 -04:00
Toshio Kuratomi
3511abb9d9 Merge pull request #15055 from ansible/ansible_sudo_pass-should-override-cli 
Fix ansible_sudo_pass inventory variable so that it overrides setting of sudo password from the command line
 2016-03-21 13:31:35 -07:00
Brian Coca
9c6b49fd3d Merge pull request #15004 from agx/zypper-repository-integration-tests 
Integration tests for zypper repository
 2016-03-21 11:00:50 -07:00
Toshio Kuratomi
ed9e164b80 Fix ansible_sudo_pass inventory variable so that it overrides setting of sudo password from the command line 2016-03-21 10:20:40 -07:00
Rajat Gupta
dd27157b9d Add pycrypto as a requirement to run tests 2016-03-21 21:37:18 +05:30
James Cammarata
7460f76f8d Merge pull request #15052 from mattclay/travis-docker-ssh 
Add ssh client and server to docker containers.
 2016-03-20 16:41:10 -04:00
Matt Clay
4224c11b5f Combine new RUN commands into one RUN command. 2016-03-20 10:48:11 -07:00
Toshio Kuratomi
6824f3a7cc Change url so that we don't test https in the tests for file perms 2016-03-20 08:49:40 -07:00
Toshio Kuratomi
cbd93b6ad3 Add integration test for #11821 2016-03-20 07:59:00 -07:00
Matt Clay
da99e4e0aa Add ssh client and server to docker containers. 
This will allow for future integration tests using ssh to localhost
from within docker containers running on Travis.
 2016-03-19 21:33:23 -07:00
nitzmahone
b95286c88e re-integrate test_test_infra output checking 
added secondary run with overridden inventory/test args per bcoca request
 2016-03-18 10:14:22 -07:00
nitzmahone
6578e63e63 improve test_test_infra debug messaging, rc check 2016-03-18 08:51:43 -07:00
Toshio Kuratomi
bdf90d20dd Add :Z to mount the volume. This is a docker-1.7+ option that makes the mount properly relabel for selinux 2016-03-18 07:47:09 -07:00
Brian Coca
db61e9be0c add ansible_executable inventory var 
also handle the overrides appropriately
also new executable to set shell type
 2016-03-17 18:54:37 -07:00
Toshio Kuratomi
e80cd8bcaf Merge pull request #14908 from mattclay/mysql-connect-timeout 
Document mysql connect_timeout and update tests.
 2016-03-17 07:18:01 -07:00
James Cammarata
8eadc1d8eb Adding more unit tests for AnsibleModule things in basic.py 2016-03-17 02:02:15 -04:00
Matt Clay
9a922fcf0d Update test to use mysql connect_timeout option. 2016-03-16 22:31:48 -07:00
Guido Günther
2095d1ab33 Integration tests for zypper repository 2016-03-16 19:56:56 +01:00
Rene Moser
5d5d905e36 cloudstack: new integration tests test_cs_resourcelimit 2016-03-15 21:41:08 +01:00
Rene Moser
4d6a15ebc3 cloudstack: new integration tests test_cluster 2016-03-15 21:41:08 +01:00
Rene Moser
d50026b108 cloudstack: new integration tests test_cs_pod 2016-03-15 21:41:08 +01:00
Rene Moser
ae6d2a5602 cloudstack: new integration tests test_cs_instance_facts 2016-03-15 21:40:45 +01:00
Rene Moser
d9f7589460 cloudstack: new integration tests test_cs_configuration 2016-03-15 21:39:09 +01:00
René Moser
7587c20d27 Merge pull request #13183 from resmo/for-ansible 
[2.1] cloudstack: add tests for cs_volume
 2016-03-15 21:30:01 +01:00
Toshio Kuratomi
ea58ccfd5e Make the fact gathering give a little more information on failure 2016-03-15 12:32:27 -07:00
James Cammarata
88310a7f28 Adding iproute to certain RH-based docker images 2016-03-15 15:28:22 -04:00
Toshio Kuratomi
9a6a5a5516 add a fact gathering check for the default of all 2016-03-15 11:58:23 -07:00
Toshio Kuratomi
f0e6d28815 Make integration tests for fact gathering assert on failure 2016-03-14 18:48:40 -07:00
Toshio Kuratomi
512825455e Make ohai and facter work via module_utils Fact classes rather than in the setup module 2016-03-14 14:53:29 -07:00
Yannig Perré
88772b6003 Add a way to restrict gathered facts in Ansible: 
- Using gather_subset options
- By ignoring ohai/chef or facter/puppet facts
 2016-03-14 14:53:28 -07:00
James Cammarata
81788e627d Adding unit tests for TaskResult 2016-03-14 01:33:46 -04:00
James Cammarata
2fa1936ff9 Adding python-dev to the list of packages for ubuntu1204 docker 
[ci skip]
 2016-03-13 09:21:47 -04:00
James Cammarata
9d459386ce Also adding an upgrade of pycrypto to ubuntu1204 config 2016-03-13 09:14:15 -04:00
James Cammarata
90afc5e7d2 Adding rubygems to the ubuntu1204 docker config 
[no ci]
 2016-03-13 08:50:21 -04:00
James Cammarata
af282eb979 Fixing typo in ubuntu1204 docker config 2016-03-13 08:31:47 -04:00
James Cammarata
ff5584a349 Updating jinja2 in ubuntu1204 docker image 2016-03-13 08:27:52 -04:00
James Cammarata
1222830155 Initial commit for Ubuntu 12.04 docker config for testing 2016-03-13 03:19:47 -04:00
Matt Clay
a44b88936b Add unicode dir to connection tests. 2016-03-11 16:55:14 -08:00
Dag Wieers
5775739437 Moving samples/ out of the root into test/ 
Since samples/ is used for v2 testing, it fits better into the existing test/ structure.
 2016-03-11 21:59:06 +01:00
James Cammarata
286d91d722 Reorganizing tox stuff and making py3-specific requirements 2016-03-11 11:25:28 -05:00
James Cammarata
ab682b2917 Moving docker tests to pre-compiled images 2016-03-10 21:52:23 -05:00
James Cammarata
adc9a25a06 Merge pull request #14904 from mattclay/mysql-test-timeout 
Lower connect timeout for test_mysql_variables.
 2016-03-10 16:04:06 -05:00
James Cammarata
c6af811573 Fixing equality check in run_tests.sh for sanity 2016-03-10 15:34:06 -05:00
Matt Clay
20eee14a2c Lower connect timeout for test_mysql_variables. 2016-03-10 12:18:00 -08:00
Brian Coca
7e3c92e909 predictable docker names and autoremove if no fail 2016-03-10 15:07:17 -05:00
James Cammarata
f700a7e3ce Removing forced pull from build step in run_tests.sh 2016-03-10 14:07:58 -05:00
Matt Clay
5c206eaf0b Add additional plugins to connection tests. 
- docker
- libvirt_lxc
- jail

These tests will not run as part of the build, but can be run manually.
 2016-03-10 09:04:32 -08:00
Brian Coca
a07495e4c8 allow tests to run with parameters 
also fixed test_test_infra to allow tags
 2016-03-10 10:50:14 -05:00
James Cammarata
c2441c15c3 Revert "corrected failed_when test" 
This reverts commit 140df20504.
 2016-03-10 09:08:17 -05:00
James Cammarata
963178f392 Revert "complete correction of test, key exists but is false" 
This reverts commit 7e6343213b.
 2016-03-10 09:06:08 -05:00
Brian Coca
923548f6d5 removed test_infra from setup as it fails when using --tags 2016-03-10 00:29:32 -05:00
Brian Coca
7e6343213b complete correction of test, key exists but is false 2016-03-10 00:24:27 -05:00
Brian Coca
140df20504 corrected failed_when test 2016-03-10 00:16:38 -05:00
nitzmahone
6c835b2600 ensure assert and fail work before we test anything else 2016-03-09 17:36:39 -08:00
Toshio Kuratomi
2b8a0cdddc Fix ssh connection unittests for python3.4 2016-03-09 11:14:02 -08:00
James Cammarata
9d61a6cba8 Fixing PlayIterator bugs 
* Unit tests exposed a problem where nested blocks did not correctly
  hit rescue/always portions of parent blocks
* Cleaned up logic in PlayIterator
* Unfortunately fixing the above exposed a potential problem in the
  block integration tests, where a failure in an "always" section may
  always lead to a failed state and the termination of execution
  beyond that point, so certain parts of the block integration test
  were disabled.
 2016-03-09 13:31:30 -05:00
James Cammarata
f0d3284ead Adding more unit tests for ssh connection plugin 2016-03-08 14:50:35 -05:00
James Cammarata
2f472fd4e9 Adding start of ssh connection unit tests 2016-03-08 01:07:16 -05:00
Matt Davis
22344c5320 Merge pull request #14812 from mattclay/test-connection 
Add tests for connection plugins.
 2016-03-08 04:17:30 +00:00
Matt Martz
8aee648bc9 Add as dependency of the parsing make target 2016-03-07 17:38:47 -06:00
Matt Martz
098333b2ec Fix redirects for get_url 
* fetch_url shouldn't both accept follow_redirects and support follow_redircts via module.params
* Default follow_redirects for open_url should be 'urllib2'
* Add redirect test for get_url
 2016-03-07 15:44:31 -06:00
James Cammarata
299d93f6e9 Updating unit tests for PlayIterator 
This knowingly introduces a broken test, planning to fix that later.
 2016-03-07 13:03:06 -05:00
James Cammarata
8cfdaa16f4 Fixing error in localedef usage for f23 docker image 2016-03-06 11:07:27 -05:00
James Cammarata
0e17a6f036 Another attempt at fixing random f23 locale failures in docker image 2016-03-06 09:56:31 -05:00
James Cammarata
2ee0c1b175 Fixing centos6 docker image for pycrytpo too 2016-03-06 08:09:30 -05:00
James Cammarata
762c99f77c Fixing centos6 docker image to upgrade jinja2 2016-03-06 07:49:00 -05:00
James Cammarata
56670bd150 More tweaks for fedora on docker 2016-03-05 18:36:41 -05:00
James Cammarata
b97a98f69e Trying to fix up the fedora23 docker image 2016-03-05 15:45:37 -05:00
James Cammarata
b72cd3a6d2 Adding fedora rawhide to the travis mix 2016-03-05 14:35:49 -05:00
James Cammarata
c632873936 Adding centos 6 to the travis mix 2016-03-05 13:47:23 -05:00
James Cammarata
e5844ee03d Revert "Testing adding -j2 to the run_tests.sh script to speed up docker tests" 
This reverts commit db2a0ae255, as it does not
add any speed to the tests on Travis.
 2016-03-05 11:50:10 -05:00
James Cammarata
db2a0ae255 Testing adding -j2 to the run_tests.sh script to speed up docker tests 2016-03-05 10:58:30 -05:00
Matt Clay
49892b287b Use vars to eliminate redundant test commands. 2016-03-04 18:14:52 -08:00
Matt Clay
ca62bc5db3 Add tests for connection plugins. 2016-03-04 13:16:31 -08:00
James Cammarata
981f451f0e Adding fedora 23 to the Docker tests on travis 2016-03-04 14:02:13 -05:00
James Cammarata
7f34705b0c Fixing up Dockerfiles some more to get tests passing fully 2016-03-04 09:16:28 -05:00
James Cammarata
fa630872d9 Minor update to the Dockerfiles 2016-03-04 02:48:44 -05:00
James Cammarata
069e597aaa Fixing locale stuff in ubuntu 14.04 Dockerfile 2016-03-03 22:29:21 -05:00
James Cammarata
f56af2ec3f Updating docker files for tests 2016-03-03 21:03:28 -05:00
James Cammarata
e4acd44e23 Make sure test script fails on any error 2016-03-03 20:44:13 -05:00
Matt Martz
d8876b5c03 Run /sbin/init in the ubuntu docker image, as we do with centos 2016-03-03 16:45:47 -06:00
James Cammarata
92dcad8e99 Adding docker container capabilities to Travis 2016-03-03 15:26:08 -05:00
James Cammarata
80b10bd669 Moving creating of testing work dir out of dep role and into Makefile 2016-03-03 15:26:08 -05:00
Toshio Kuratomi
7160b40ab1 Fix the Makefile to run under dash (POSIX /bin/test syntax) 2016-03-03 09:25:12 -08:00
James Cammarata
b853e932d1 Adding unit tests for symbolic mode conversion stuff in basic.py 2016-03-01 16:41:57 -05:00
James Cammarata
18240d350c Adding a skip for the literal_eval test on py3 2016-03-01 14:33:05 -05:00
James Cammarata
0ea3a9d08d Removing tabs from test_basic.py 2016-03-01 14:15:15 -05:00
James Cammarata
1de9357c2f Attempt at cleaning up issues introduced by new basic.py unit tests 2016-03-01 14:06:58 -05:00
James Cammarata
e011f52557 Expanding unit tests for module_utils/basic.py 2016-03-01 13:53:13 -05:00
Matt Davis
3d58fd1402 Merge pull request #13481 from jhawkesworth/a21_reg_merge_tests 
windows; adding integration tests for win_regmerge (extras module)
 2016-03-01 00:42:09 +00:00
James Cammarata
c56e3aabfb Clean up jsonify unit test with format to remove json lib differences 2016-02-29 15:08:59 -05:00
James Cammarata
7c049c3200 Fixing up jsonify and adding unit tests 2016-02-29 14:51:23 -05:00
James Cammarata
a9d25f455c More unit tests for ActionBase 2016-02-29 12:59:58 -05:00
James Cammarata
e588437067 Adding some unicode params to the ActionBase module formatting test 2016-02-27 10:05:22 -05:00
Toshio Kuratomi
7cb29cdbec Workaround py2.6's StringIO 2016-02-26 17:59:00 -08:00
Toshio Kuratomi
b70bf3b056 Use io.StringIO and io.BytesIO instead of StringIO.StringIO for compat with py3 2016-02-26 16:43:05 -08:00
Toshio Kuratomi
c29f51804b Fix mixing of bytes and str in module replacer (caused traceback on python3) 2016-02-26 16:43:05 -08:00
James Cammarata
01d835700b Cleaning up some py version problems with ActionBase unit tests 2016-02-26 16:22:35 -05:00
James Cammarata
3518a05db6 Starting to expand unit tests for ActionBase plugin class 2016-02-26 12:47:59 -05:00
James Cammarata
9de24a3735 Assert things against the recursive copy result to make sure it did something 2016-02-23 16:29:08 -05:00
James Cammarata
e02b98274b issue callbacks per item and retry fails 
- now workers passes queue to task_executor so it can send back events per item and on retry attempt
- updated result class to pass along events to strategy
- base strategy updated to forward new events to callback
- callbacks now remove 'items' on final result but process them directly when invoked per item
- new callback method to deal with retry attempt messages (also now obeys nolog)
- updated tests to match new signature of task_executor

fixes #14558
fixes #14072
 2016-02-23 15:07:06 -05:00
Matt Martz
cacb74aeeb Merge pull request #14340 from sivel/uri-no-httplib2 
Add RedirectHandler class for controlling redirects in urllib2
 2016-02-23 11:53:16 -06:00
Matt Martz
3e9408e317 Add some additional integration tests that mix SSL verification and redirects 2016-02-23 11:48:09 -06:00
John Barker
4fb1839ebe non-destructive says we should run test_binary at v2 
We are now using Ansible v2 and these tests pass, so run them.
 2016-02-22 21:58:43 +00:00
Brian Coca
3b3709e715 Merge pull request #14488 from bcoca/become_shell_fixes 
shell + become fixes
 2016-02-18 01:45:37 -08:00
James Cammarata
58a6cf822a Merge pull request #13203 from willthames/galaxy_10620 
Allow tree-ish versions for ansible-galaxy
 2016-02-17 08:41:29 -05:00
Brian Coca
6dc910c13a shell + become fixes 
1 less level of shell + quoting
simplified become commands, less quote and shell
 2016-02-15 13:00:13 -05:00
Brian Coca
bb155e1142 added test for cartesian lookup 2016-02-11 10:46:44 -05:00
Brian Coca
08b3dbcda3 corrected several usages of deprecated bare vars 2016-02-08 13:13:15 -05:00
Brian Coca
ba51ed06cf changed from deprecated implicit bare var 2016-02-08 13:05:19 -05:00
Matt Martz
97e0f29a5b Add/improve tests for the uri module 2016-02-05 12:14:57 -06:00
James Cammarata
b713f1ca53 Fix for copy test as ansible_ssh_user is not set by default now 2016-02-05 10:36:07 -05:00
James Cammarata
8039ceee0f Tweak block integration tests to also test the free strategy 2016-02-03 18:42:06 -05:00
James Cammarata
5466510edb Removing .out file for integration tests and adding to .gitignore 2016-02-03 15:00:37 -05:00
James Cammarata
f4bd3be71f Adding block integration tests 2016-02-03 15:00:37 -05:00
Robin Roth
ed059ffca9 add integration test for ansible-pull 
* this test includes the behavior described in #13688 and #13681
* it runs a minimal playbook and checks for correct use of inventory and limit
 2016-02-02 12:18:04 +01:00
Toshio Kuratomi
0e410bbc8a Squashing was occuring even though pkgs didn't have a template that would be affected by squash 
This broke other uses of looping (looping for delegate_to in the
reported bug)

Fixes #13980
 2016-01-27 21:55:00 -08:00
Brian Coca
fad6eb1844 fixed unit test to match new output of become/su 2016-01-27 16:49:51 -05:00
Brian Coca
46fde754af Merge pull request #14044 from skorochkin/devel 
Adding support for scm-based role source urls (ansible-galaxy)
 2016-01-26 10:41:05 -05:00
James Cammarata
fb797a9e77 Fixing role dependency chain creation 
The dep chain for roles created during the compile step had bugs, in
which the dep chain was overwriten and the original tasks in the role
were not assigned a dep chain. This lead to problems in determining
whether roles had already run when in a "diamond" structure, and in
some cases roles were not correctly getting variables from parents.

Fixes #14046
 2016-01-22 12:54:00 -05:00
Sergii Korochkin
13e8732598 [hotfix] add missed playbook file 2016-01-21 14:08:26 +02:00
Sergii Korochkin
1325c21ca0 Adding support for scm-based role source urls (incl. integration test to cover it) 2016-01-21 14:00:29 +02:00
Toshio Kuratomi
d97d28ecb0 Merge pull request #14025 from ansible/run_command-env-rework 
rework run_command's env setting to not change os.environ for the res…
 2016-01-20 12:13:43 -08:00
Toshio Kuratomi
a68d90a71a rework run_command's env setting to not change os.environ for the rest of the module. 
New param to run_command to modify the environment for just this invocation.
Documentation and comment adjustments.
 2016-01-20 12:03:32 -08:00
Brian Coca
c09c01a1f5 go back to defaulting wrapping commands in shell 
this was taken out in an effort to default to the user's shell but creates issues as this is not known ahead of time
and its painful to set executable and shell_type for all servers, it should only be needed for those that restrict the user
to specific shells and when /bin/sh is not available. raw and command may still bypass this by explicitly passing None.
fixes #13882

still conditional
 2016-01-19 22:09:17 -05:00
James Cammarata
b1223746cd Relocate use of ERROR to display class, to avoid doubling up 2016-01-19 12:10:39 -05:00
Brian Coca
27f4730c29 correctly deals with non serializable type 
combine_vars shoudl really be data types, but some just get in
in test, add dict to mock and avoid combine_vars using object
 2016-01-18 15:17:43 -05:00
Matt Davis
acf49cf837 Merge pull request #13569 from mattclay/apt-repository-filename 
Test for filename option in apt_repository module.
 2016-01-15 09:01:48 -08:00
Toshio Kuratomi
bcb22b0e1a Integration tests for https://github.com/ansible/ansible-modules-core/pull/558 2016-01-11 17:16:40 -08:00
James Cammarata
749fbd43ef Removing test for map filter until we can figure out how that's supposed to work 2016-01-08 16:41:56 -05:00
Brian Coca
e7804a6fdd fixed test to use hostvars and not expect vars sub 
vars is at the same level as hostvars and was only included in hostvars
temporarily as a bug
 2016-01-08 16:25:57 -05:00
Toshio Kuratomi
46903c80fa More fixes for unicode handling in the connection plugins. 
Tested that ssh, docker, local, lxc-libvirt, chroot all work with the
updated unicode integration test.
 2016-01-06 15:19:40 -08:00
Toshio Kuratomi
c0a8cd950b Fix problems with non-ascii values passed as part of the command to connection plugins 
@drybjed discovered this with non-ascii environment variables and
command line arguments to script and raw module.
 2016-01-04 20:35:25 -08:00
Toshio Kuratomi
1ed3a018eb Revert "Fix make tests-py3 on devel. Fix for https://github.com/ansible/ansible/issues/13638." 
This reverts commit e70061334aa99bee466295980f4cd4146096dc29.

Going to do this in the connection plugins
 2016-01-04 19:25:40 -08:00
James Cammarata
2d11cfab92 Squashed commit of the following: 
commit 24efa310b58c431b4d888a6315d1285da918f670
Author: James Cammarata <jimi@sngx.net>
Date:   Tue Dec 29 11:23:52 2015 -0500

    Adding an additional test for copy exclusion

    Adds a negative test for the situation when an exclusion doesn't
    exist in the target to be copied.

commit 643ba054877cf042177d65e6e2958178bdd2fe88
Merge: e6ee59f 66a8f7e
Author: James Cammarata <jimi@sngx.net>
Date:   Tue Dec 29 10:59:18 2015 -0500

    Merge branch 'speedup' of https://github.com/chrismeyersfsu/ansible into chrismeyersfsu-speedup

commit 66a8f7e873ca90f7848e47b04d9b62aed23a45df
Author: Chris Meyers <chris.meyers.fsu@gmail.com>
Date:   Mon Dec 28 09:47:00 2015 -0500

    better api and tests added

    * _copy_results = deepcopy for better performance
    * _copy_results_exclude to deepcopy but exclude certain fields. Pop
    fields that do not need to be deep copied. Re-assign popped fields
    after deep copy so we don't modify the original, to be copied, object.
    * _copy_results_exclude unit tests

commit 93490960ff4e75f38a7cc6f6d49f10f949f1a7da
Author: Chris Meyers <chris.meyers.fsu@gmail.com>
Date:   Fri Dec 25 23:17:26 2015 -0600

    remove uneeded deepcopy fields
 2015-12-29 11:40:18 -05:00
Brian Coca
d89d7951e6 fixed tests to follow new invocation structure 
also added maxdiff setting to see issues clearly when they happen
 2015-12-23 11:45:07 -05:00
Yannig Perré
b22d998d1d Fix make tests-py3 on devel. Fix for https://github.com/ansible/ansible/issues/13638. 2015-12-22 16:47:27 -05:00
James Cammarata
d22bbbf52c Actually disable parallel makes for integration runner 2015-12-21 16:11:53 -05:00
James Cammarata
8119ea37af Dropping instance size back down since we're not doing parallel builds 2015-12-21 15:55:43 -05:00
James Cammarata
45afa642c3 Integration test runner tweaks 2015-12-21 15:48:58 -05:00
James Cammarata
6d6822e66e Kick up the integration runner test image size 2015-12-21 14:37:17 -05:00
James Cammarata
08b580decc Parallelize make command for integration test runner 
Also adds a new var, used by the prepare_tests role, to prevent it from
deleting the temp test directory at the start of each play to avoid any
potential race conditions
 2015-12-21 14:10:23 -05:00
Brian Coca
2281c455db Merge pull request #13616 from resmo/for-ansible-stable-2.0 
[stable-2.0] cloudstack: test_cs_instance: more integration tests
 2015-12-21 13:45:29 -05:00
Brian Coca
75e94e0cba allow for non standard hostnames 
* Changed parse_addresses to throw exceptions instead of passing None
* Switched callers to trap and pass through the original values.
* Added very verbose notice
* Look at deprecating this and possibly validate at plugin instead
fixes #13608
 2015-12-21 13:42:34 -05:00
Brian Coca
e957335b0d Merge pull request #13607 from mattclay/test-cache-typo 
Fixed import typo for memcache module in tests.
 2015-12-21 10:23:38 -05:00
James Cammarata
54455a06e5 Disable docker test for Fedora, due to broken packaging 2015-12-20 21:32:37 -05:00
James Cammarata
3a57d9472c Save output of integration test results to files we can archive 2015-12-20 17:55:39 -05:00
Rene Moser
b85b92ecdd cloudstack: test_cs_instance: more integration tests 
cloudstack: extend test_cs_instance addressing recovering

cloudstack: test_cs_instance: add tests for using display_name as indentifier.
 2015-12-20 22:37:48 +01:00
Rene Moser
b0525da8c8 cloudstack: cs_volume: add tests for volume resize 
See https://github.com/ansible/ansible-modules-extras/pull/1333
 2015-12-20 22:33:53 +01:00
Rene Moser
8b5e553828 cloudstack: add tests for cs_volume 2015-12-20 22:33:53 +01:00
Toshio Kuratomi
6963955cb4 And change the task a little more since different shlex versions are handling the quotes differently 2015-12-20 11:51:32 -08:00
Toshio Kuratomi
21ca0ce1ce Fix test playbook syntax 2015-12-20 11:46:49 -08:00
Toshio Kuratomi
3792a586b5 Since the velox test server seems to be dropping using iptables to drop requests from aws, test via a different website instead 2015-12-20 11:34:57 -08:00
Toshio Kuratomi
8d7892cc7b Done troubleshooting 
Revert "Troubleshooting has reduced us to this"

This reverts commit 9abef1a1d7.
 2015-12-20 11:34:57 -08:00
Toshio Kuratomi
5fef2c4297 Try updating the centos7 image to a newer version (trying to resolve issue being unable to connect to some webservers) 2015-12-20 09:11:53 -08:00
Toshio Kuratomi
b90506341a Fixes for tests that assumed yum as package manager for systems that 
have dnf
 2015-12-20 08:06:26 -08:00
Toshio Kuratomi
3da312da9c Switch from yum to package when installing sudo so that dnf is handled as well 2015-12-19 23:13:11 -08:00
James Cammarata
3ec0104128 Fixing bugs in conditional testing with until and some integration runner tweaks 2015-12-19 21:14:48 -05:00
Toshio Kuratomi
e2d9f4e2f2 Fix unittests for return of invocation from fail_json and exit_json 2015-12-19 15:49:59 -08:00
Toshio Kuratomi
9abef1a1d7 Troubleshooting has reduced us to this 2015-12-19 12:39:48 -08:00
Toshio Kuratomi
51cca87d67 Also need redhat-rpm-config to compile pycrypto 2015-12-19 11:27:16 -08:00
Toshio Kuratomi
c63ae99485 Make sure that yum is present on redhat family systems (makes things also work on fedora systems where dnf is the default) 2015-12-19 10:11:42 -08:00
Matt Clay
d2ad17e88f Fixed import typo for memcache module in tests. 
The typo caused the test for the memcached cache plugin to be skipped
even when the necessary memcache python module was installed.
 2015-12-19 00:08:49 -08:00
Toshio Kuratomi
f7ed33378e Fix the fedora host detection 2015-12-18 15:42:41 -08:00
Toshio Kuratomi
78dde62710 What is going on here 2015-12-18 15:14:38 -08:00
Toshio Kuratomi
26e5bcdb39 Bugfix the fedora 23 install task 2015-12-18 14:38:54 -08:00
Toshio Kuratomi
ec60bfbb3f Ubuntu images with hvm ssd 2015-12-18 14:36:17 -08:00
Toshio Kuratomi
68fe3d856f Fedora 23 needs to have python2 packages installed 2015-12-18 14:05:33 -08:00
James Cammarata
0823a2c16f Removing update all for test deps, it didn't fix the problem 2015-12-18 15:34:11 -05:00
James Cammarata
02f65eaa80 Make integration runner ec2 add_hosts use valid host names 2015-12-18 14:59:22 -05:00
Toshio Kuratomi
1cc83dd0d9 Make tests that use kennethreitz retry. 2015-12-18 11:50:36 -08:00
James Cammarata
73a0153b8e Fix typo in integration test runner role 2015-12-18 12:45:12 -05:00
James Cammarata
0c154e81f0 Make integration tests run in parallel with async 2015-12-18 11:30:51 -05:00
Toshio Kuratomi
f2364ecf5f Add a Fedora latest host into the mix 2015-12-18 08:13:22 -08:00
James Cammarata
1debc2da44 Do a full yum update to make sure packages are latest version 
For the deps setup of integration tests, as we sometimes see odd
errors we can't reproduce, which may be related to slightly out of
date package dependencies.
 2015-12-18 10:34:27 -05:00
James Cammarata
44e30e49dd Add awk to integration test deps list 2015-12-18 07:47:40 -05:00
Toshio Kuratomi
a391d6f89a Add state=latest to pip install of pycrypto 2015-12-17 20:10:26 -08:00
James Cammarata
3143b352c5 Add ca-certificates update to the integration deps playbook 2015-12-17 23:08:04 -05:00
Toshio Kuratomi
1f3eec293b Install an updated version of pycrypto on Ubuntu12 from pip 2015-12-17 20:06:53 -08:00
James Cammarata
12c0bb9414 Use --source instead of -e for awk in integration Makefile 2015-12-17 20:53:11 -05:00
Toshio Kuratomi
c5eda277ac Fix get_url tests in light of distros backporting SNI support 2015-12-17 17:51:42 -08:00
Toshio Kuratomi
8c6f56f982 kennetreitz.org times out but www.kennethreitz.org is fine 2015-12-17 11:46:26 -08:00
Toshio Kuratomi
ce1febe28b debug line needs var not msg 2015-12-17 11:25:45 -08:00