Jim Richardson
bbfe11fc1e
return True/False from remove_job_file()
...
revised fix for https://github.com/ansible/ansible/issues/4795
2013-11-04 14:14:53 -08:00
Jim Richardson
bcc08564e7
fix for https://github.com/ansible/ansible/issues/4795
...
Incorrect changed result in cron module.
Report changed=False if no cron is removed:wq
2013-11-03 17:43:51 -08:00
Michael DeHaan
3705f41992
Merge pull request #4754 from mscherer/fix_4648
...
Fix 4648, cron module is not working on solaris
2013-10-31 14:49:25 -07:00
Michael DeHaan
d34a26e307
Undo an inadvertant revert from template changes so we still allow pythonic imports in module land.
2013-10-31 16:53:05 -04:00
Michael Scherer
9e7b02aaee
make cron module work on solaris
...
Cron on solaris do not take the same
set of option than vixie cron on linux, and
among the biggest difference, root cannot set
the crontab of a user directly from a file. Thus the
use of su to run the crontab command. Fix issue #4648
2013-10-31 19:58:26 +01:00
Michael Scherer
506ce6a809
remove unused function
2013-10-31 19:58:26 +01:00
Scott Dunlop
dbc1e20462
add "zle" as a supported ZFS compression type
...
ZFS supports "zle" compression, which compresses runs of null bytes efficiently.
2013-10-31 10:48:41 -07:00
James Tanner
d154bf8781
Revert templating enhancements from 73dbab70 e6c28658 d409352c 9858b1f2 4587528b 9b1fe455 214b0b05 8d3db803 7f9504d1 5031104c 35cb9dc2 2bd8cb57 1e85c754
2013-10-30 10:50:16 -04:00
jctanner
a1fcaf5c61
Merge pull request #4715 from mscherer/fix_4702
...
Fix #4702 , make setup work on windows
2013-10-29 06:03:49 -07:00
Michael Scherer
3f0b3a71ca
Fix #4702 , make setup work on windows
2013-10-28 23:41:18 +01:00
James Cammarata
0e9184eefd
Fixing authorized_keys module to make the key part detection better
...
Fixes #4677
Fixes #4657
Fixes #4599
2013-10-28 13:52:45 -05:00
Michael DeHaan
3badedc983
Merge pull request #4424 from localvoid/firewalld-rich_rules
...
Add support for Rich Rules in firewalld module
2013-10-27 08:55:22 -07:00
Michael DeHaan
d0904ded84
Merge pull request #4600 from earchibald/devel
...
Added ['date_time']['tz_offset'] using %z to get the time offset rather ...
2013-10-27 08:30:28 -07:00
Michael DeHaan
b725361bce
Merge pull request #4560 from tronner/issue4461
...
Fix illegal set operation in FreeBSD section of user module.
2013-10-26 11:31:20 -07:00
Michael DeHaan
9858b1f2f3
Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions
...
to be reused between modules. See library/system/service and library/system/ping for initial examples. Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
2013-10-26 11:09:30 -04:00
James Tanner
40574c1938
Fixes #4448 reloaded services should be started if not running
2013-10-25 15:30:02 -04:00
James Cammarata
aa0577c211
Merge branch 'fix_autorized_keys' of https://github.com/mscherer/ansible into mscherer-fix_autorized_keys
2013-10-24 20:13:38 -05:00
James Cammarata
b58b287fce
Fixing up authorized_keys to accept comments with spaces
2013-10-24 20:12:56 -05:00
Michael Scherer
951a91723d
make sure that options are quoted, as people can add a shell
...
script there with a comma that would produce invalid configuration
upon being wrote again
2013-10-24 23:51:55 +02:00
Michael Scherer
7672e9fef8
sort the option_key to have a constant predictable line
2013-10-24 23:47:34 +02:00
Michael Scherer
264945a1f7
adding a single comma at the end of the options list confuse the module
...
it start to duplicate line, because this create
a empty option in the list, and so the module add a new line along the previous
one. See
>>> ' a,b, '.strip().split(',')
['a', 'b', '']
2013-10-24 23:46:49 +02:00
Scott Sturdivant
4d24e2e29f
If the output of rcvar isn't a key=value pair, ignore it.
2013-10-21 14:20:54 -06:00
Eugene Archibald
30eb5c7342
Fixed (broken) tab to (correct) spaces for indentation
2013-10-19 17:04:37 -07:00
Michael DeHaan
21d4400c96
Misc pep8 fixes
2013-10-19 13:03:15 -04:00
Michael DeHaan
75e0a1c6de
Merge pull request #4592 from mscherer/fix_4586
...
setup module, replace ':' by '_' in interface name, fix #4586
2013-10-19 09:07:56 -07:00
Eugene Archibald
145c0b8be1
Added ['date_time']['tz_offset'] using %z to get the time offset rather than time zone.
2013-10-18 20:32:35 -07:00
Michael Scherer
d5c290b513
fix logic in module host to add aliases even if none exist already, fix #4563
...
self._has_aliases is used to know if a alias already exist, but
the test we want is to know if we need to add a new alias, which
is stored in self.aliases
2013-10-19 01:51:42 +02:00
Michael Scherer
fc211ac1a0
setup module, replace ':' by '_' in interface name, fix #4586
2013-10-19 00:24:07 +02:00
James Tanner
4f674ec522
Fixes #4554 Enumerate user homedir if not passed as an argument
2013-10-17 13:15:32 -04:00
Thomas Ronner
aee68511e6
Fix illegal set operation in FreeBSD section of user module.
2013-10-17 15:02:23 +00:00
jctanner
7e8e186b3b
Merge pull request #4517 from adfinis-sygroup/devel
...
Remove keys regardless of the options
2013-10-16 17:40:43 -07:00
James Tanner
23cbdba65e
Fixes #4350 Create homedirectory if create=yes and directory is missing
2013-10-16 20:08:41 -04:00
James Cammarata
35284818a9
Handle ssh key files that may only have a type/key specified
...
If a specified key did not have a comment, it would be ignored as
an invalid key.
Fixes #4513
2013-10-15 09:05:50 -05:00
Stefan Heinemann
af704562a9
Set the options of an authorized key comma separated
...
According to the sshd man page, no spaces are permitted between the
options of an authorized ssh key
2013-10-15 15:29:52 +02:00
Stefan Heinemann
346d46a94c
Don't mind the options of a key when removing it
...
This allows to remove a key without knowing the options in the
authorized_key file
2013-10-15 15:29:47 +02:00
Michael DeHaan
6ff4806b90
Merge branch 'devel' of git://github.com/shirou/ansible into devel
2013-10-14 11:50:25 -04:00
Keith Buck
36a8312de6
Improve the formatting and content for the sysctl module's description.
2013-10-14 07:16:47 +00:00
James Cammarata
49130c688d
Adding 'unique' option to authorized_key module and cleanup
...
A small refactoring of the authorized_key module to accomodate these
changes, plus fixing some things like not rewriting the file on every
new key. These changes bring the original feature for ssh options in-
line with the comments in #3798
Fixes #3785
2013-10-11 16:22:37 -05:00
David Minor
ed7d3f92a0
Add ssh key options parameter to authorized_key module
2013-10-11 16:22:37 -05:00
James Tanner
e3849f1be7
Fixes #4312 for older versions of usermod which do not have --append
2013-10-11 09:10:46 -04:00
Michael DeHaan
119b6d73dd
Remove examples of module antipattern of setting the choices array for boolean types.
2013-10-11 08:45:13 -04:00
Boris Kaul
5a34e572f5
Add support for Rich Rules in firewalld module
2013-10-10 20:09:52 +07:00
Boris Kaul
194a7dab9f
Fix timeout bug in firewalld module
2013-10-10 13:41:42 +07:00
James Tanner
b7f229d390
Second attempt at preventing ipv6 route enumeration on EL4 machines
2013-10-08 18:40:15 -04:00
James Tanner
4b1600aae5
Revert "Do not enumerate ipv6 routes in CentOS 4"
...
This reverts commit 5186c408f7
2013-10-08 15:51:12 -04:00
James Tanner
5186c408f7
Do not enumerate ipv6 routes in CentOS 4
2013-10-08 15:12:38 -04:00
Michael DeHaan
135f79f337
Add documentation about how passwords are generated.
2013-10-08 08:36:48 -04:00
James Cammarata
a2ac5d6df2
Better detection/categorization of ipv4 secondaries/virtual IPs
...
Fixes #3916
Fixes #3478
2013-10-07 15:18:33 -05:00
Michael DeHaan
c5672cf16e
Merge pull request #4389 from MattTheRat/devel
...
addresses #4371 - adds -m to usermod commands
2013-10-07 12:15:20 -07:00
Matt Warren
74c412e249
addresses https://github.com/ansible/ansible/issues/4371 - adding -m to home directory modification
2013-10-07 10:47:12 -04:00
