1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

4408 commits

Author SHA1 Message Date
Dag Wieers
1e3dcfce4b Add option create= to lineinfile module
We use the lineinfile module to modify configuration files of a proprietary application. This application reads configuration options from files, but does not require those files to exist (if the default options are fine). However this application may modify the configuration file at will, so we cannot copy or template those files. And after a silent install the configuration may not exist (depending on the response file).

Whatever the case, during deployment we need to make sure some configuration options are set after the installation.

So the cleanest way to handle this situation is to allow the lineinfile module to create the file if it is missing (and this is the expected behavior). When I proposed this behavior, @sergevanginderachter needed the same functionality and was now working around it as well.
2012-10-30 17:57:15 +01:00
Stephen Fromm
4619e99443 Make sure ownership is set correctly for user's new ssh keys 2012-10-30 09:37:23 -07:00
Fabian Arrotin
96770a3057 - Fixed some typos for the ansible config file
- added the ANSIBLE_CONFIG environment variable
2012-10-30 17:08:12 +01:00
Daniel Hokka Zakrisson
efe83daf19 Fix ${var.$other_var} and add test cases for it 2012-10-30 13:05:45 +01:00
Michael DeHaan
f0000a89b0 Merge pull request #1480 from dagwieers/command-fix2
Use return codes > 255 for Ansible-specific errors.
2012-10-30 05:04:44 -07:00
Michael DeHaan
730031ec1f Merge pull request #1479 from wzzrd/selinux
More useful error message for if not HAVE_SELINUX
2012-10-30 05:04:28 -07:00
Dag Wieers
8d4f9febd8 Use return codes > 255 for Ansible-specific errors.
I had made and pushed this change after you already pulled the request.

@dhozac indicated that it would probably be better to use return codes > 255 for anything related to Ansible itself. Which makes sens :)
2012-10-30 10:36:11 +01:00
Seth Vidal
49dce05cdd fix up remove and fix fixme checking to see if pkg was removed 2012-10-29 23:48:21 -04:00
Michael DeHaan
9a12873166 Merge pull request #1477 from skvidal/devel
add check that vars plugins are not handing back None
2012-10-29 16:02:26 -07:00
Michael DeHaan
08cc961dcf Merge pull request #1475 from dagwieers/errors-fix
Missing errors-import causes traceback
2012-10-29 16:01:47 -07:00
Nigel Metheringham
9a2545957f Turn off some of the additional debug syslogging 2012-10-29 22:04:06 +00:00
Nigel Metheringham
3e0e572cce Rework of user module to support portability
Split module into a main calling function, and a generic
(Linux useradd/usermod/userdel) User class.
Added a __new__ function that selects most appropriate superclass
Added a FreeBSD User class
Tested against FreeBSD 9.0
2012-10-29 22:00:58 +00:00
Seth Vidal
7c1e0de141 fix removal case where first pkg in a list is not installed at all
and the next one gets ignored despite being installed.

also clean up unnecessary second check.
2012-10-29 13:48:20 -04:00
Seth Vidal
3fcc591f18 add check that vars plugins are not handing back None 2012-10-29 12:11:57 -04:00
Maxim Burgerhout
82cc382c6a More useful error message for if not HAVE_SELINUX 2012-10-29 16:23:00 +01:00
Dag Wieers
3728b2f459 Missing errors-import causes traceback 2012-10-29 15:16:26 +01:00
Jeroen Hoekx
b336d40101 Add a group_by action plugin. 2012-10-29 13:10:23 +01:00
Michael DeHaan
ea8cb0b2e9 Merge pull request #1472 from jhoekx/action-host-letter
Send a host to runner executor instead of a letter.
2012-10-29 04:19:35 -07:00
Jeroen Hoekx
f963db6c2a Fix output of pause plugin. 2012-10-29 10:57:13 +01:00
Jeroen Hoekx
77162e95e4 Send a host to runner executor instead of a letter.
Discovered in #1463 .
2012-10-29 09:45:44 +01:00
Daniel Hokka Zakrisson
e72fdccd87 Allow vars_files sequences without a default 2012-10-28 16:35:22 +01:00
Michael DeHaan
fb27cb45e1 Merge pull request #1465 from dhozac/no-default-file-args
Don't add file module arguments by default
2012-10-28 06:43:08 -07:00
Daniel Hokka Zakrisson
55a1473d50 Don't add file module arguments by default
This allows the postgresql_db module to work properly, as it uses
an argument named owner that conflicts with the file module.
2012-10-28 11:14:29 +01:00
Michael DeHaan
457cdb2be0 Add note about when you still have to use only_if 2012-10-27 18:22:16 -04:00
Michael DeHaan
2ae090b1db Update 'who uses' page 2012-10-27 18:10:24 -04:00
Michael DeHaan
21258dcc66 Added 'when' as a shortcut around only_if. 2012-10-27 17:55:35 -04:00
Michael DeHaan
a768e9a9ff Fix for sudo defaults if sudo is passed in via --extra-vars 2012-10-27 16:46:33 -04:00
Michael DeHaan
7d7ff9d616 Fixup setup.py path 2012-10-26 20:20:02 -04:00
Michael DeHaan
7f6aa2d3d5 Config parameter rename 2012-10-26 20:19:09 -04:00
Michael DeHaan
6ba30170dd Make group_vars and host_vars available to usr/bin/ansible, and make vars_plugins exist 2012-10-26 19:55:59 -04:00
Michael DeHaan
e04dab904a Use previous proven multiprocessing logic as the simplification didn't have the same Ctrl-C handling and may
be subject to race issues, though still don't pass Runner to each.  Still seems performant.
2012-10-26 18:11:38 -04:00
Michael DeHaan
03f303fba3 Merge pull request #1460 from dhozac/init-sftp-paramiko
Initialize sftp variable to fix error on transferless session
2012-10-26 14:59:10 -07:00
Daniel Hokka Zakrisson
1052dd9c8f Initialize sftp variable to fix error on transferless session 2012-10-26 23:54:21 +02:00
Michael DeHaan
2d3c9452c9 Merge pull request #1456 from dagwieers/command-fix
Make sure we always return 'rc' from the command module
2012-10-26 06:13:12 -07:00
Dag Wieers
63fa33b0b7 Make sure we always return 'rc' from the command module
If this is not a certainty, playbooks will fail without an 'rc' and checking both if there is an rc, and whether the 'rc' is (not) 0 is very complicated. (especially because ${something.rc} will not be substituted and all that)
2012-10-26 15:02:03 +02:00
Michael DeHaan
8dbe6b6a74 Add HP on request 2012-10-25 23:26:24 -04:00
Michael DeHaan
ebd9673ceb Tweak docsite re: resources/contrib page 2012-10-25 23:17:05 -04:00
Michael DeHaan
23533b60e3 update changelog 2012-10-25 23:05:31 -04:00
Michael DeHaan
5e2c2564bc Explicitly execute /bin/sh versus $SHELL because some folks have very incompatible/weird shells. We do not
execute modules through the shell, this is only for basic ops, so should be sufficient.
2012-10-25 23:00:07 -04:00
Michael DeHaan
ff787146d1 stray debug 2012-10-25 22:24:15 -04:00
Michael DeHaan
24416b9e49 Remove stray debug message 2012-10-25 22:19:50 -04:00
Michael DeHaan
3257c5b61f Some caching improvements to paramiko which are still not yet fully leveraged
in playbook mode, since the Runner still closes abstract host connections completely
and does not have a LRU.
2012-10-25 22:09:54 -04:00
Michael DeHaan
4c83c274e0 Don't close paramiko SFTP multiple times in the same runner pass. Noticeable performance increase. 2012-10-25 21:49:28 -04:00
Michael DeHaan
8b50ad7e85 Fix for atomic_replace patch if file does not yet exist 2012-10-25 21:40:05 -04:00
Daniel Hokka Zakrisson
7a8009f979 When atomically replacing files, copy attributes 2012-10-25 21:40:05 -04:00
Michael DeHaan
523f2bf327 Merge pull request #1455 from bleader/devel
user module: fix typo in documentation
2012-10-25 18:26:58 -07:00
Michael DeHaan
19a5f86c2e Merge pull request #1452 from dhozac/with_items-as-plugin
Make with_items a lookup plugin
2012-10-25 18:24:34 -07:00
Michael DeHaan
cbcc133cdd Merge pull request #1453 from sfromm/issue1211
Use shutil.copyfile so as to preserve file ownership in authorized_keys
2012-10-25 18:22:56 -07:00
Michael DeHaan
5b36e374d7 Merge pull request #1451 from dhozac/command-strip-newlines
Only strip trailing newlines from output, preserving other space
2012-10-25 18:21:16 -07:00
Michael DeHaan
c17aad3a59 Merge pull request #1450 from jpmens/docs_contrib1
Move contrib to .rst into the main docsite
2012-10-25 18:20:59 -07:00